Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-09 Thread zhou xing
/persistent_volume_endpoints_tests.cpp 81185a161498394020a27f1f5bf747bac5425f43 src/tests/reservation_endpoints_tests.cpp f95ae7a32c3809d150adf1e9e515a3b527e61699 Diff: https://reviews.apache.org/r/44606/diff/ Testing --- Thanks, zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-09 Thread zhou xing
a3ad57a1c3f8a01aa609b28c12825670bb243387 src/tests/persistent_volume_endpoints_tests.cpp 81185a161498394020a27f1f5bf747bac5425f43 src/tests/reservation_endpoints_tests.cpp f95ae7a32c3809d150adf1e9e515a3b527e61699 Diff: https://reviews.apache.org/r/44606/diff/ Testing --- Thanks, zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-09 Thread zhou xing
ly. Thanks for the review, has updated the patch - zhou --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44606/#review122879 ---

Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

2016-03-23 Thread zhou xing
/ Testing --- make make check Thanks, zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-27 Thread zhou xing
might just do the change > > in 0.29.0. This should go into the 0.29.0 CHANGELOG though (API Changes > > section). > > zhou xing wrote: > Thanks for the review, we have sent a message to the community to see > wether anyone are using the return code. will update you the late

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

2016-03-31 Thread zhou xing
://reviews.apache.org/r/45213/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

2016-03-31 Thread zhou xing
/45213/#review126429 --- On 四月 1, 2016, 5:57 a.m., zhou xing wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

2016-03-31 Thread zhou xing
3d0d5828ef095884ca87156d69f963f04dba40a1 Diff: https://reviews.apache.org/r/45213/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

2016-03-31 Thread zhou xing
> On 三月 31, 2016, 8:25 p.m., Vinod Kone wrote: > > Can you call this out specifically in the CHANGELOG (under "Binary API > > Changes) section. > > zhou xing wrote: > Vinod?thanks for the review. I just resubmit the patch to rebase to the > latest code, p

Review Request 45806: Replace Master/Slave Terminology Phase I - Add duplicate binaries.

2016-04-06 Thread zhou xing
-slaves.sh.in 3dd9b51edff2beb3ccc8d5dd44f0cdc265f623f9 Diff: https://reviews.apache.org/r/45806/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-07 Thread zhou xing
s-stop-cluster.sh.in e5f8c1fb400c56715774889632aa74d9eac33645 src/deploy/mesos-stop-slaves.sh.in 3dd9b51edff2beb3ccc8d5dd44f0cdc265f623f9 Diff: https://reviews.apache.org/r/45806/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-07 Thread zhou xing
: https://reviews.apache.org/r/44606/diff/ Testing --- Thanks, zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-11 Thread zhou xing
r your review - zhou --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44606/#review127678 --- On 四月 7, 2016, 8:56 a.m., zhou xing wrote: > &

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-11 Thread zhou xing
0d56e Diff: https://reviews.apache.org/r/44606/diff/ Testing --- Thanks, zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-11 Thread zhou xing
pport/generate-endpoint-help.py 5d23b10f0bab9c0e5848c0c1c26855522cf44a70 support/test-upgrade.py 2c4061d71338f66e432dfa4ac86a9693f3ad38bf Diff: https://reviews.apache.org/r/45806/diff/ Testing (updated) --- cd mesos ./bootstrap mkdir build cd build ../configure --prefix=${HOME}/install/mesos make make check Thanks, zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-12 Thread zhou xing
he.org/r/45806/diff/ Testing --- cd mesos ./bootstrap mkdir build cd build ../configure --prefix=${HOME}/install/mesos make make check Thanks, zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-12 Thread zhou xing
he.org/r/45806/diff/ Testing --- cd mesos ./bootstrap mkdir build cd build ../configure --prefix=${HOME}/install/mesos make make check Thanks, zhou xing

Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-12 Thread zhou xing
reviews.apache.org/r/46134/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-12 Thread zhou xing
ll/uninstall-hooks to create a > > symlink from `agent->slave`. Possibly renaming `copy-agent-env-template` to > > something more meaningful to cover both the existing stuff, plus setting up > > this symlink. > > > > Finally, the CHANGELOG

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread zhou xing
he.org/r/45806/diff/ Testing --- cd mesos ./bootstrap mkdir build cd build ../configure --prefix=${HOME}/install/mesos make make check Thanks, zhou xing

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread zhou xing
partyConfigure.cmake 7b53a49baddc8b65f9c5b4b8fe5a53b6883b3652 Diff: https://reviews.apache.org/r/46134/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread zhou xing
you are correct, I added $(DESTDIR) in Makefile.am and tried locally, it worked. have submitted the updated patch to see if this can make CI happy, thanks - zhou --- This is an automatically generated e-mail. To re

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread zhou xing
32dfa4ac86a9693f3ad38bf Diff: https://reviews.apache.org/r/45806/diff/ Testing --- cd mesos ./bootstrap mkdir build cd build ../configure --prefix=${HOME}/install/mesos make make check Thanks, zhou xing

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread zhou xing
partyConfigure.cmake 7b53a49baddc8b65f9c5b4b8fe5a53b6883b3652 Diff: https://reviews.apache.org/r/46134/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread zhou xing
op-slaves.sh.in 3dd9b51edff2beb3ccc8d5dd44f0cdc265f623f9 > src/slave/containerizer/mesos/launch.cpp > 54079c37143f4b5c22e0c9a8fe4bacb31f60ed1b > src/tests/balloon_framework_test.sh > ae32753e8942f77f94752543c384d218d6e4d48d > support/generate-endpoint-help.py 5d23b10f0bab9c0e5848c0c1c26855522cf44a70 > support/test-upgrade.py 2c4061d71338f66e432dfa4ac86a9693f3ad38bf > > Diff: https://reviews.apache.org/r/45806/diff/ > > > Testing > --- > > cd mesos > ./bootstrap > mkdir build > cd build > ../configure --prefix=${HOME}/install/mesos > make > make check > > > Thanks, > > zhou xing > >

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread zhou xing
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 7b53a49baddc8b65f9c5b4b8fe5a53b6883b3652 Diff: https://reviews.apache.org/r/46134/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread zhou xing
32dfa4ac86a9693f3ad38bf Diff: https://reviews.apache.org/r/45806/diff/ Testing --- cd mesos ./bootstrap mkdir build cd build ../configure --prefix=${HOME}/install/mesos make make check Thanks, zhou xing

Review Request 46189: Slave rename - Update strings in error messages and other strings.

2016-04-14 Thread zhou xing
b4c4ca88f96836de601e Diff: https://reviews.apache.org/r/46189/diff/ Testing --- make make check Thanks, zhou xing

Review Request 46190: Slave rename - Update standard output messages in libprocess.

2016-04-14 Thread zhou xing
party/libprocess/src/test-slave.cpp 9797792d79448dc8e9ed31ef689fa9655250c1c4 Diff: https://reviews.apache.org/r/46190/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 46190: Slave rename - Update standard output messages in libprocess.

2016-04-14 Thread zhou xing
r to find out all the message strings(in Eclipse IDE): ``` ^[^#include].*".*slave.*" ``` then filter out the lines that using term 'slave' as the field name or attribute name make make check Thanks, zhou xing

Re: Review Request 46190: Slave rename - Update standard output messages in libprocess.

2016-04-14 Thread zhou xing
message strings(in Eclipse IDE): ``` ^[^#include].*".*slave.*" ``` then filter out the lines that using term 'slave' as the field name or attribute name make make check Thanks, zhou xing

Re: Review Request 46189: Slave rename - Update strings in error messages and other strings.

2016-04-14 Thread zhou xing
nclude].*".*slave.*" ``` then filter out the lines that using term 'slave' as the field name or attribute name make make check Thanks, zhou xing

Re: Review Request 46190: Slave rename - Update standard output messages in libprocess.

2016-04-17 Thread zhou xing
7; folder to find out all the message strings(in Eclipse IDE): ``` ^[^#include].*".*slave.*" ``` then filter out the lines that using term 'slave' as the field name or attribute name make make check Thanks, zhou xing

Re: Review Request 46189: Slave rename - Update strings in error messages and other strings.

2016-04-17 Thread zhou xing
t all the message strings(in Eclipse IDE): ``` ^[^#include].*".*slave.*" ``` then filter out the lines that using term 'slave' as the field name or attribute name make make check Thanks, zhou xing

Re: Review Request 46190: Slave rename - Update standard output messages in libprocess.

2016-04-17 Thread zhou xing
l. To reply, visit: https://reviews.apache.org/r/46190/#review129276 --- On 四月 18, 2016, 2:31 a.m., zhou xing wrote: > > --- > This is an automatically generated e-mai

Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-19 Thread zhou xing
/files.cpp 4e916101b378b0e9032a08a3f6c73e195b2a08a1 src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd Diff: https://reviews.apache.org/r/46373/diff/ Testing --- make make check request 'files/read.json' endpoint with negative offset or length argument Tha

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-19 Thread zhou xing
sting --- make make check request 'files/read.json' endpoint with negative offset or length argument Thanks, zhou xing

Review Request 50184: Fixed length argument bug when reading file.

2016-07-19 Thread zhou xing
7; link on the home page. The log of master shall be shown and updated correctly. Thanks, zhou xing

Review Request 50208: Fixed a file descriptor leak bug while reading file.

2016-07-19 Thread zhou xing
8ab8f8aad9cfe1e536b29e8994fcd8599627e590 Diff: https://reviews.apache.org/r/50208/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 50184: Fixed length argument bug when reading file.

2016-07-19 Thread zhou xing
://reviews.apache.org/r/50184/diff/ Testing --- make make check run mesos-master with --log_dir or --external_log_file specified. Open a browser and goto 127.0.0.1:5050, click 'LOG' link on the home page. The log of master shall be shown and updated correctly. Thanks, zhou xing

Re: Review Request 50184: Fixed length argument bug when reading file.

2016-07-19 Thread zhou xing
/ Testing --- make make check run mesos-master with --log_dir or --external_log_file specified. Open a browser and goto 127.0.0.1:5050, click 'LOG' link on the home page. The log of master shall be shown and updated correctly. Thanks, zhou xing

Re: Review Request 50246: Modified 'master' to accecpt request with charset in Content-Type.

2016-07-24 Thread zhou xing
g/r/50246/#comment209132> just wonder if we can just use regexp to extract string 'application/json' or 'application/x-protobuf' from Content-Type, as we are not interested in charset parse/validation? - zhou xing On July 20, 2016, 6:11 p.m

Re: Review Request 50246: Modified 'master' to accecpt request with charset in Content-Type.

2016-07-24 Thread zhou xing
"application/json; charset=UTF-8" content-type to our operator API? - zhou xing On July 20, 2016, 6:11 p.m., Abhishek Dasgupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 50246: Modified 'master' to accecpt request with charset in Content-Type.

2016-07-27 Thread zhou xing
> On 七月 25, 2016, 3:06 a.m., zhou xing wrote: > > src/master/http.cpp, line 491 > > <https://reviews.apache.org/r/50246/diff/1/?file=1448176#file1448176line491> > > > > just wonder if we can just use regexp to extract string > > 'application/js

Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

2016-04-25 Thread zhou xing
cca Diff: https://reviews.apache.org/r/46676/diff/ Testing --- cd mesos ./bootstrap mkdir build cd build ../configure --prefix=${HOME}/install/mesos make make check make install Thanks, zhou xing

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-26 Thread zhou xing
check request 'files/read.json' endpoint with negative offset or length argument Thanks, zhou xing

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

2016-04-26 Thread zhou xing
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46676/#review130664 --- On 四月 26, 2016, 6:06 a.m., zhou xing wrote: > > -

Review Request 46720: Fix the titles of 'Slave/Agent Rename' series tickets in CHANGELOG.

2016-04-26 Thread zhou xing
check Thanks, zhou xing

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

2016-04-26 Thread zhou xing
gure --prefix=${HOME}/install/mesos make make check make install Thanks, zhou xing

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-27 Thread zhou xing
check request 'files/read.json' endpoint with negative offset or length argument Thanks, zhou xing

Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

2016-04-27 Thread zhou xing
ngs on web page and url Thanks, zhou xing

Re: Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

2016-04-28 Thread zhou xing
- zhou --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46761/#review130946 --- On 四月 28, 2016, 5:20 p.m., zhou xing wrote: > >

Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.

2016-04-29 Thread zhou xing
e' is completely removed in the code, I'm ok to the change - zhou xing On 四月 29, 2016, 4:55 a.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

2016-05-05 Thread zhou xing
gure --prefix=${HOME}/install/mesos make make check make install start mesos master/agent and run a sample framework, then open browser and goto : to check all the strings on web page and url Thanks, zhou xing

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-05 Thread zhou xing
; endpoint with negative offset or length argument Thanks, zhou xing

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-16 Thread zhou xing
request 'files/read.json' endpoint with negative offset or length argument Thanks, zhou xing

Re: Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

2016-05-17 Thread zhou xing
-mail. To reply, visit: https://reviews.apache.org/r/46761/#review133591 --- On 五月 6, 2016, 4:59 a.m., zhou xing wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46761/ &g

Re: Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

2016-05-17 Thread zhou xing
/:framework_id/executors/:executor_id' '/slaves/:agent_id/frameworks/:framework_id/executors/:executor_id/browse', redirectTo: '/agents/:agent_id/frameworks/:framework_id/executors/:executor_id/browse' '/slaves/:agent_id/browse', redirectTo: '/agents/:agent_id/browse' Thanks, zhou xing

Re: Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

2016-05-17 Thread zhou xing
work_id/executors/:executor_id', redirectTo: '/agents/:agent_id/frameworks/:framework_id/executors/:executor_id' '/slaves/:agent_id/frameworks/:framework_id/executors/:executor_id/browse', redirectTo: '/agents/:agent_id/frameworks/:framework_id/executors/:executor_id/browse' '/slaves/:agent_id/browse', redirectTo: '/agents/:agent_id/browse' Thanks, zhou xing

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-17 Thread zhou xing
check request 'files/read.json' endpoint with negative offset or length argument Thanks, zhou xing

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-17 Thread zhou xing
.json' endpoint with negative offset or length argument Thanks, zhou xing

Review Request 47582: Include v1 Executor Protos in maven jar.

2016-05-18 Thread zhou xing
-sources.jar | grep "v1\/executor" | wc -l Thanks, zhou xing

Re: Review Request 47582: Include v1 Executor Protos in maven jar.

2016-05-18 Thread zhou xing
classes inside: unzip -lf mesos-0.29.0.jar | grep "v1\/executor" | wc -l Thanks, zhou xing

Review Request 47805: Add authorization to GET /weights.

2016-05-24 Thread zhou xing
master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 src/master/weights_handler.cpp 4bc060fdb015df6658194eef92fe11b14aa15c79 src/tests/dynamic_weights_tests.cpp 362c59aae7b305710d5985bfec28f881be3b64b8 Diff: https://reviews.apache.org/r/47805/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 47909: Slave/Agent Rename Phase I - Updated terms in the website.

2016-05-26 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47909/#review135125 --- Ship it! ok to me - zhou xing On 五月 26, 2016, 5:15 p.m

Re: Review Request 47805: Add authorization to GET /weights.

2016-05-26 Thread zhou xing
ly, I suggest not to add a new get request test in this test case. Or we can merge the get weights test and update weights test together into one, please let me know your comments, thanks. - zhou --- This is an automatically

Re: Review Request 47805: Add authorization to GET /weights.

2016-05-26 Thread zhou xing
che.org/r/47805/diff/ Testing --- make make check Thanks, zhou xing

Review Request 47944: Set timestamp when updating task status from long lived framework.

2016-05-27 Thread zhou xing
"46 years ago", it should show "just now" or the current timestamp Thanks, zhou xing

Re: Review Request 47805: Add authorization to GET /weights.

2016-05-27 Thread zhou xing
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47805/#review135190 --- On May 27, 2016, 5:45 a.m., zhou xing wrote: > >

Re: Review Request 47805: Add authorization to GET /weights.

2016-05-27 Thread zhou xing
reply, visit: https://reviews.apache.org/r/47805/#review135190 ------- On May 27, 2016, 5:45 a.m., zhou xing wrote: > > --- > This is an automatically

Re: Review Request 47805: Add authorization to GET /weights.

2016-05-27 Thread zhou xing
ly, visit: https://reviews.apache.org/r/47805/#review135190 --- On 五月 27, 2016, 5:45 a.m., zhou xing wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47805/ > --

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-30 Thread zhou xing
will submit a patch then - zhou --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review135408 --- On 五月 18,

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-30 Thread zhou xing
.json' endpoint with negative offset or length argument Thanks, zhou xing

Re: Review Request 47805: Add authorization to GET /weights.

2016-05-30 Thread zhou xing
che.org/r/47805/diff/ Testing --- make make check Thanks, zhou xing

Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-08 Thread zhou xing
/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 Diff: https://reviews.apache.org/r/48438/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-09 Thread zhou xing
-mail. To reply, visit: https://reviews.apache.org/r/48438/#review136864 --- On 六月 8, 2016, 6:37 p.m., zhou xing wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-09 Thread zhou xing
6e1bf9557a854a89fa9173223295816a9e114e7c src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 Diff: https://reviews.apache.org/r/48438/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.

2016-06-15 Thread zhou xing
g/r/48596/#comment203125> for some of the set_xxx or update_xxx method, we do not need contentType, we keep this param only for consistency? - zhou xing On 六月 15, 2016, 5:14 p.m., haosdent huang wrote: > > --- > This is a

Re: Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.

2016-06-15 Thread zhou xing
> On 六月 16, 2016, 1:11 a.m., zhou xing wrote: > > src/master/http.cpp, line 1371 > > <https://reviews.apache.org/r/48596/diff/4/?file=1420195#file1420195line1371> > > > > for some of the set_xxx or update_xxx method, we do not need > > contentType,

Review Request 48835: Remove duplicate return in getHealth method.

2016-06-16 Thread zhou xing
Description --- removed the duplicate return clause. Diffs - src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d Diff: https://reviews.apache.org/r/48835/diff/ Testing --- make Thanks, zhou xing

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-16 Thread zhou xing
) - src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 src/tests/api_tests.cpp 03e46cc5e0af8250ba36281e1293a1dc89f8e266 Diff: https://reviews.apache.org/r/48438/diff/ Testing --- make make check Thanks, zhou xing

Review Request 48841: Add Agent protobuf message.

2016-06-16 Thread zhou xing
f: https://reviews.apache.org/r/48841/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48841: Add Agent protobuf message.

2016-06-17 Thread zhou xing
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48841/#review138173 --- On 六月 17, 2016, 6:37 a.m., zhou xing wrote: > >

Re: Review Request 48841: Add Agent protobuf message.

2016-06-18 Thread zhou xing
/master.proto 59e978fef6e0faca7dc8c25b47a79f0b5007d0a6 include/mesos/v1/mesos.proto 9be22f02861f1eb89ab547d88530faf90ebee7ab Diff: https://reviews.apache.org/r/48841/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-18 Thread zhou xing
dated) - src/master/http.cpp a6beb1721958a77886f0aa535346e2ff33bd5d04 src/master/master.hpp 618d928ef1398e7397df968c7cd47acbc987d1e3 src/tests/api_tests.cpp afa5ffab8729dfc5b102968ec64c6a3bcd832dfd Diff: https://reviews.apache.org/r/48438/diff/ Testing --- make make check Thanks,

Review Request 48924: Extract public logic of collecting weights info into _getWeights.

2016-06-19 Thread zhou xing
weight info. Diffs - src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d src/master/weights_handler.cpp 25075357c5ac8450d2fa1790844802f121908e9e Diff: https://reviews.apache.org/r/48924/diff/ Testing --- make make check Thanks, zhou xing

Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

2016-06-19 Thread zhou xing
src/master/weights_handler.cpp 25075357c5ac8450d2fa1790844802f121908e9e src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf Diff: https://reviews.apache.org/r/48925/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-19 Thread zhou xing
/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d src/tests/api_tests.cpp d9596f35c2adfbb223c831136546bd854b19c320 Diff: https://reviews.apache.org/r/48438/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48924: Extract public logic of collecting weights info into _getWeights.

2016-06-19 Thread zhou xing
Thanks, zhou xing

Re: Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

2016-06-19 Thread zhou xing
check Thanks, zhou xing

Re: Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

2016-06-21 Thread zhou xing
cally generated e-mail. To reply, visit: https://reviews.apache.org/r/48925/#review138732 --- On 六月 20, 2016, 3:35 a.m., zhou xing wrote: > > --- > This is an automati

Re: Review Request 48841: Add Agent protobuf message.

2016-06-21 Thread zhou xing
make check Thanks, zhou xing

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-21 Thread zhou xing
, zhou xing

Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-21 Thread zhou xing
weights. Diffs - src/master/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4 src/master/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 Diff: https://reviews.apache.org/r/48940/diff/ Testing --- make make check Thanks, zhou xing

Review Request 49064: Implement v1 operator update weights API.

2016-06-21 Thread zhou xing
bf1a294f1fc3c8659c31115beee3876d4d0a45e2 Diff: https://reviews.apache.org/r/49064/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48841: Add Agent protobuf message.

2016-06-22 Thread zhou xing
aster/master.proto Diffs (updated) - include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 Diff: https://reviews.apache.org/r/48841/diff/ Testing --- make make check Thanks,

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-22 Thread zhou xing
/ Testing --- make make check Thanks, zhou xing

Re: Review Request 49064: Implement v1 operator update weights API.

2016-06-22 Thread zhou xing
n.cpp 9120b71fc7725bdf7094aac6619d8aadcc352df5 src/master/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49064/diff/ Testing --- make make check Thanks, zhou xing

Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

2016-06-23 Thread zhou xing
src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49137/diff/ Testing --- make make check Thanks, zhou xing

Review Request 49136: Add Framework protobuf message.

2016-06-23 Thread zhou xing
include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 Diff: https://reviews.apache.org/r/49136/diff/ Testing --- make make check Thanks, zhou xing

  1   2   >