Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15480
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95310486
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95309134
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95306902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95306485
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95306125
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95303089
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95300754
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/OrderingSuite.scala
---
@@ -127,4 +127,17 @@ class OrderingSuite extends
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95300735
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95300097
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/OrderingSuite.scala
---
@@ -127,4 +127,17 @@ class OrderingSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r9536
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r90769457
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,42 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r90474669
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,42 @@ object
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r90454770
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,42 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r90441646
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,42 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r89802303
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,42 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r89789490
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,42 @@ object
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r89516712
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,42 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r89513885
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,42 @@ object
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r89490417
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,42 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r89339644
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,42 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r86504407
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -537,7 +537,6 @@ class CodegenContext {
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r86494742
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -537,7 +537,6 @@ class CodegenContext {
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r83990016
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,45 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r83837138
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -537,7 +537,6 @@ class CodegenContext {
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r83803058
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,45 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r83582242
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,45 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r83577461
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,45 @@ object
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r83574850
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,45 @@ object
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r83574830
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,45 @@ object
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r83574113
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,45 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r83530625
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,45 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r83530039
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,45 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r83528941
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,45 @@ object
GitHub user lw-lin opened a pull request:
https://github.com/apache/spark/pull/15480
[SPARK-16845][SQL] `GeneratedClass$SpecificOrdering` grows beyond 64 KB
## What changes were proposed in this pull request?
Prior to this patch, we'll generate `compare(...)` for
35 matches
Mail list logo
