Sorry for sending this to public alias.
It is because of an auto-complete typo.
Thanks,
Serguei
On 1/12/21 10:16, serguei.spit...@oracle.com wrote:
https://myhelp.oracle.com/app/answers/answer_view/a_id/1015343
Hi Charlie,
It is hard to say what is wrong from the information you provided.
I agree with Mikael the following lines look incorrect:
assert(jvmti->SetEventCallbacks(, sizeof(callbacks)) ==
JVMTI_ERROR_NONE);
assert(jvmti->SetEventNotificationMode(JVMTI_ENABLE,
Okay, thanks, guys!
Serguei
On 9/18/20 14:17, Daniel D. Daugherty wrote:
On 9/18/20 5:13 PM, Chris Plummer wrote:
On 9/18/20 1:59 PM, Serguei Spitsyn wrote:
On Fri, 18 Sep 2020 20:23:15 GMT, Chris Plummer
wrote:
In the platform-specific implementations of linker_md.c, we see
the
Hi Richard,
This is on my review list. I'll try to get it reviewed by the end of
this week.
Thanks,
Serguei
On 9/8/20 10:02, Reingruber, Richard wrote:
Hello Marty,
Sure. I'd be happy if Serguei could review the change.
Thanks, Richard.
-Original Message-
From: Marty Thompson
Hi Dan,
It is always nice to return from vacation a little bit refreshed. Thank
you for good words!
Yes, this is already on my list.
Thanks!
Serguei
On 9/14/20 14:20, Daniel D. Daugherty wrote:
Hi Serguei,
Welcome back from your vacation.
When you get the chance, we need you to chime in
Hi Vipin,
I've only looked at the management files. They look good in
general.
src/java.management/share/classes/java/lang/management/ClassLoadingMXBean.java
108 * @throws java.lang.SecurityException if a security manager
109 *
) for this enhancement?
I know you give +1 to this change, but I want to confirm in light of
the discussion again so far.
Thanks,
Yasumasa
On 2020/09/04 19:29, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
On 9/4/20 02:49, Yasumasa Suenaga wrote:
Hi Serguei,
For example, JvmtiThreadState_lock would
to get rid of these
handshake closures.
Thanks,
Serguei
So I think they are needed both direct handshake and
JvmtiThreadState_lock.
Thanks,
Yasumasa
On 2020/09/04 17:38, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
Only PopFrame, ForceEarlyReturn, NotifyFramePop and ResumeThread
require
to be safe because the target thread is suspended.
Grabbing the JvmtiThreadState_lock is good enough to ensure MT-safety.
Thanks,
Serguei
On 9/4/20 01:28, Yasumasa Suenaga wrote:
Hi Serguei,
Thanks for your review!
On 2020/09/04 15:43, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
Thanks
handshake, then other threads can enter these functions. Is it
safe?
Thanks,
Yasumasa
On 2020/09/03 16:34, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
Wood it be MT-safe
On 9/2/20 01:42, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
Thank you for the explanation. At least, I see the real motivation.
I've overlooked this in the email thread.
Thanks,
Serguei
On 9/2/20 00:00, Yasumasa Suenaga wrote:
Hi Serguei,
On 2020/09/02 15:29, David Holmes wrote:
Hi
Hi Richard,
This looks reasonable to me.
The only question is about the quality of this testing.
How are we sure these errors are caused by races but not bugs in
the GetLocalObject implementation?
Thanks,
Serguei
On
no longer convinced that holding that lock in place of executing
at a safepoint is either necessary nor sufficient.
David
On 2/09/2020 6:38 pm, serguei.spit...@oracle.com wrote:
Hi David,
On 9/2/20 00:32, David Holmes wrote:
Hi Serguei,
On 2/09/2020 5:10 pm, serguei.spit...@oracle.com wrote
Thanks,
Serguei
On 9/1/20 21:34, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
On 9/1/20 21:17, Yasumasa Suenaga wrote:
Hi David,
On 2020/09/02 13:13, David Holmes wrote:
Hi Yasumasa,
On 31/08/2020 7:10 pm, Yasumasa Suenaga wrote:
Hi David,
I uploaded new webrev. Could you revi
Hi David,
On 9/2/20 00:32, David Holmes wrote:
Hi Serguei,
On 2/09/2020 5:10 pm, serguei.spit...@oracle.com wrote:
Hi David,
On 9/1/20 23:29, David Holmes wrote:
Hi Serguei,
On 2/09/2020 4:11 pm, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
It seems to me your update for sync
Hi David,
On 9/1/20 23:29, David Holmes wrote:
Hi Serguei,
On 2/09/2020 4:11 pm, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
It seems to me your update for sync with the JvmtiThreadState_lock is
incorrect.
Let me explain it.
The original design was that the functions is_frame_pop
,
Serguei
On 9/1/20 21:34, serguei.spit...@oracle.com wrote:
Hi
Yasumasa,
On 9/1/20 21:17, Yasumasa Suenaga wrote:
Hi David,
On 2020/09/02 13:13, David Holmes wrote:
Hi Yasumasa,
On 9/1/20 21:17, Yasumasa Suenaga wrote:
Hi David,
On 2020/09/02 13:13, David Holmes wrote:
Hi Yasumasa,
On 31/08/2020 7:10 pm, Yasumasa Suenaga wrote:
Hi David,
I uploaded new webrev. Could you review again?
http://cr.openjdk.java.net/~ysuenaga/JDK-8242427/webrev.04/
Hi Lin,
Thank you for double-checking it.
Thanks,
Serguei
On 9/1/20 20:26, linzang(臧琳) wrote:
Hi Serguei,
Thanks for your reminder!
Yes, just checked we have discussed that before. I will close the bug.
BRs,
Lin
On Sep 2, 2020, at 11:22 AM, "serguei.spit...@oracle.com&quo
Hi Yasumasa,
It looks good to me.
Thanks,
Serguei
On 9/1/20 15:28, Yasumasa Suenaga wrote:
On 2020/09/02 1:00, Daniel D. Daugherty wrote:
On 9/1/20 9:42 AM, Yasumasa Suenaga wrote:
Hi all,
Please review this change:
JBS: https://bugs.openjdk.java.net/browse/JDK-8252657
webrev:
Hi Lin,
I agree with David.
If I remember correctly, we already discussed this in the CSR for
parallel flag and decided it should not be accepted without a value.
Thanks,
Serguei
On 9/1/20 16:51, David Holmes wrote:
Hi Lin,
On 1/09/2020 7:06 pm, linzang(臧琳) wrote:
Hi All,
Please
:
http://cr.openjdk.java.net/~iignatyev//8252532/webrev.01/ (whole)
http://cr.openjdk.java.net/~iignatyev//8252532/webrev.0-1/ (incremental)
Thanks,
-- Igor
On Sep 1, 2020, at 1:39 AM, serguei.spit...@oracle.com
Hi Eric,
It looks good to me.
Thank you for taking care about it.
Thanks,
Serguei
On 9/1/20 01:15, Eric Liu wrote:
Hi all,
Please review this simple change to fix some compile warnings.
The newer gcc (gcc-8 or higher) would warn for calls to bounded string
manipulation functions such as
Hi Igor,
This looks fine to me too.
I also agree with David's suggestions.
Thanks,
Serguei
On 8/30/20 21:53, David Holmes wrote:
Hi Igor,
On 29/08/2020 1:52 pm, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8252532/webrev.00
145 lines changed: 28 ins; 22 del; 95 mod;
Hi
Hi Igor,
LGTM++
I've lost track of what Linux distro's have the systemtap though. :)
Thanks,
Serguei
On 8/31/20 15:29, Alex Menkov wrote:
Hi Igor,
LGTM
--alex
On 08/31/2020 12:03, Igor Ignatyev wrote:
ping?
On Aug 26, 2020, at 10:14 PM, Igor Ignatyev
wrote:
Hi Igor,
LGTM++
It is a nice clean. Surprisingly, this code had a lot of typos!
Thanks,
Serguei
On 8/30/20 21:18, David Holmes wrote:
Hi Igor,
Update looks good.
Thanks,
David
On 29/08/2020 4:18 am, Igor Ignatyev wrote:
Hi David,
good point, parseArguments (or rather checkOption) does
ort IPv6 at all.
-Dmitry
On 18.08.2020 3:20, serguei.spit...@oracle.com wrote:
Hi Dmitry,
I agree with Alex, it is better to rename compareIPv6Addr to
isEqualIPv6Addr.
705 static int compareIPv6Addr(struct addrinfo *ai, struct in6_addr
in6Addr)
706 {
707
708 if (ai->ai_addr->
Hi Igor,
It looks good and trivial.
Thanks,
Serguei
On 8/26/20 16:59, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8252401/webrev.00
6 lines changed: 5 ins; 0 del; 1 mod;
Hi all,
could you please review this trivial patch which adds
j.t.l.Utils.TEST_NATIVE_PATH static
.
Except:
> The error code from the inet_pton is not checked.
inet_pton performs conversion of the constant value in our case and
the only possible reason for it to fail is that the system doesn't
support IPv6 at all.
-Dmitry
On 18.08.2020 3:20, serguei.spit...@oracle.com wrote:
Hi Dmitry,
at 4:05 PM
To: "serguei.spit...@oracle.com"
,
"serviceability-dev@openjdk.java.net"
, Claes
Redestad
Subject: Re: 8251155: HostIdentifier fails to
canonicalize hostnames star
Hi Lin,
LGTM++
Thanks,
Serguei
On 8/24/20 11:44, serguei.spit...@oracle.com wrote:
Hi Paul,
I tried to complete my review but the webrev is not loaded at
the moment.
The server
Hi Paul,
I tried to complete my review but the webrev is not loaded at the
moment.
The server cr.openjdk.java.net
was very slow yesterday.
Will check if anything can be dome on my side.
Thanks,
Serguei
if the
first character in the string is a digit.
/Claes
[1] https://tools.ietf.org/html/rfc3986#section-3.1
On 2020-08-18 22:03, serguei.spit...@oracle.com wrote:
Hi Jie,
I've added Claes to the list as he may have an expertise in this area.
83 *
84 * {@code } - transformed
Hi Lin,
LGTM++
Thanks,
Serguei
On 8/21/20 14:01, Daniel D. Daugherty wrote:
On 8/20/20 7:42 PM, linzang(臧琳) wrote:
After discuss with paul, it is not a good idea to combine two fix
together in one webrev. I will handle them separately
Please help review the updated one. Thanks!
Webrev:
On 8/21/20 11:07, serguei.spit...@oracle.com wrote:
Hi Paul,
Sorry, Volker, for using this "indirection".
I hope, Paul redirected my "Hi" to you. :)
Thanks,
Serguei
Thank you for explanation.
Thanks,
Serguei
On 8/21/20 10:54, Volker Simonis wrote:
On Thu, Aug
Hi Paul,
Thank you for explanation.
Thanks,
Serguei
On 8/21/20 10:54, Volker Simonis wrote:
On Thu, Aug 20, 2020 at 10:06 PM serguei.spit...@oracle.com
wrote:
Hi Paul,
I was also wondering if there is a compatibility risk involved with the
JMM_VERSION change.
So, thanks to Volker
, Reingruber, Richard wrote:
Hi Serguei,
I have prepared a new webrev based on your suggestions.
Webrev: http://cr.openjdk.java.net/~rrich/webrevs/8249293/webrev.6/
Delta: http://cr.openjdk.java.net/~rrich/webrevs/8249293/webrev.6.inc/
Thanks,
Richard.
__
From: serguei.spit
local_val;
Better to rename it to local_obj or just obj.
Ok, done.
There are still problems with the indent.
I reformatted the file using 2 space indentation like in other C++ sources. I didn't include the
indentation change in the delta webrev.
Hi Paul,
I was also wondering if there is a compatibility risk involved
with the JMM_VERSION change.
So, thanks to Volker for asking these questions.
One more question.
I do not see a backport of the
question is:
Do we really want to update each nsk test depending on JVMTI or there
is a way to solve it on the test suite level?
Here we may need some recommendation from Igor.
Thanks,
Serguei
On 8/20/20 11:50, Alex Menkov wrote:
Hi Serguei,
On 08/19/2020 20:34, serguei.spit...@oracle.com wrote
//8252005/webrev.01/index.html
could you please re-review it?
Thanks,
-- Igor
On Aug 19, 2020, at 4:22 PM, serguei.spit...@oracle.com
wrote:
Hi Igor
Hi Alex,
It looks good to me.
But there are more tests in test/hotspot/jtreg/runtime and
test/hotspot/jtreg/compiler which use the Instrumentation API, and so,
depend on the JVMTI.
Examples are:
test/hotspot/jtreg/compiler/jsr292
read started. Polling thread '%s' for local variables\n",
It is better to get rid of leading stars in all messages.
Ok, done.
176 // the native method Java_GetLocalWithoutSuspendTest_notifyAgentToGetLocalAndWaitShortly
The part 'Java_GetLocalWithoutSuspendTest_' can
Thank you for the update, Alex!
It looks good.
Thanks,
Serguei
On 8/19/20 16:35, Alex Menkov wrote:
Updated webrev:
http://cr.openjdk.java.net/~amenkov/jdk16/jdb_options/webrev.02/
--alex
On 08/19/2020 16:14, serguei.spit...@oracle.com wrote:
On 8/19/20 15:11, Alex Menkov wrote:
Hi
Hi Igor,
This looks reasonable.
Thanks,
Serguei
On 8/18/20 16:42, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8252005/webrev.00/
0 lines changed: 0 ins; 0 del; 0 mod;
Hi all,
could you please review this trivial (and apparently empty) patch which sets
allowSmartActionArgs
On 8/19/20 15:11, Alex Menkov wrote:
Hi Serguei,
thank you for the feedback.
On 08/19/2020 13:58, serguei.spit...@oracle.com wrote:
Hi Alex,
Sorry, I've overlooked this request for review.
The fix looks good in general.
http://cr.openjdk.java.net/~amenkov/jdk16/jdb_options/webrev/src
Hi Alex,
Sorry, I've overlooked this request for review.
The fix looks good in general.
http://cr.openjdk.java.net/~amenkov/jdk16/jdb_options/webrev/src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/VMConnection.java.frames.html
81
Hi Fairoz,
LGTM++
Thanks,
Serguei
On 8/19/20 09:38, Vladimir Kozlov wrote:
Looks good.
Thanks,
Vladimir K
On 8/19/20 5:30 AM, Fairoz Matte wrote:
Hi Vladimir,
Thanks for the review.
I would suggest to run test with -XX:+PrintCodeCache flag which prints
CodeCache usage on exit.
Also
Hi Jie,
I've added Claes to the list as he may have an expertise in this
area.
83 *
84 * {@code } - transformed into "//localhost"
85 * localhost - transformed into "//localhost"
86 * hostname - transformed into "//hostname"
87 *
Hi Dmitry,
I agree with Alex, it is better to rename compareIPv6Addr to
isEqualIPv6Addr.
705 static int compareIPv6Addr(struct addrinfo *ai, struct in6_addr in6Addr)
706 {
707
708 if (ai->ai_addr->sa_family == AF_INET6) {
709 const struct
Hi Stefan and Paul,
Thank you for taking care and fixing this regression!
It seems, the fix from Paul is more complete and is better to push after
testing.
It looks good to me.
Unfortunately, there is very limited test coverage for this.
Thanks,
Serguei
On 8/14/20 09:47, Stefan Karlsson
Hi David and Serguei,
On 11/08/2020 3:21 am, serguei.spit...@oracle.com wrote:
Hi Richard and David,
The implementation looks good to me.
But I do not understand what the test is doing with all this counters
and recursions.
For instance, thes
gt;
>> On 8/12/20 17:08, linzang(臧琳) wrote:
>> Hi Paul and Serguei,
>> Thanks for your comments, here is the updated patch:
http://cr.openjdk.java.net/~lzang/8251374/webrev02/
>>
>> BRs,
>> Li
Hi Lin.
Thank you for the update.
It looks good.
Thanks,
Serguei
On 8/12/20 17:08, linzang(臧琳) wrote:
Hi Paul and Serguei,
Thanks for your comments, here is the updated patch:
http://cr.openjdk.java.net/~lzang/8251374/webrev02/
BRs,
Lin
On 2020/8/13, 12:55 AM, "serguei
,
Lin
From: "serguei.spit...@oracle.com"
Date: Thursday, August 13, 2020 at 1:06 AM
To: "linzang(臧琳)"
Cc: "Hohensee, Paul" , Stefan Karlsson , David Holmes
, serviceability-dev ,
"hotspot-gc-...@openjdk.java.net"
Subject: Re: RFR(L): 8215624: add p
,
Lin
From:
"serguei.spit...@oracle.com"
Date: Wednesday, August 12, 2020 at 4:23 AM
To: "linzang(臧琳)"
Cc: "Hohensee, Paul" ,
Stefan Karlsso
Hi Lin,
It looks good.
Just one comment.
+ System.err.println("Fail: invalid option: '" + subopt +"'");
+ System.exit(1);
Exit needs to be replaced wit usage for consistency.
Thanks,
Serguei
On 8/10/20 19:57, linzang(臧琳) wrote:
Here is the webrev:
it need more review and approval for pushing this
change?
BRs,
Lin
On 2020/8/11, 2:40 PM,
"serguei.spit...@oracle.com"
wrote:
Hi Lin,
I prefer a conservativ
. And I checked that
other jcmd tools usually use System.exit() after print errors. So I made the
change.
Thanks!
Lin
On Aug 11, 2020, at 11:05 AM, "serguei.spit...@oracle.com"
wrote:
Hi Lin,
I've re-reviewed the JMap.java only.
It looks good except there was no need to replace t
ue that jmap -dump
could accept undefined options, will setup a new issue in JBS and fix it
separately soon.
BRs,
Lin
From: "serguei.spit...@oracle.com"
Date: Tuesday, August 11, 2020 at 8:40 AM
To: "linzang(臧琳)" , "Hohensee, Paul" , Stefan Karlsson
,
e when parameter check fail in Jmap.java
> *Retrive the histo logic that if “all” and “live” are set at same time, use “live”, rather than print error message. (not sure which one is better :P)
My last point is to retrive the behavior for compatibility. And do you think make a separat
, serguei.spit...@oracle.com wrote:
On 8/10/20 13:34, serguei.spit...@oracle.com wrote:
Hi Coleen,
It looks good to me.
Minor:
+void JvmtiExport::initialize_oop_storage() {
+ // OopStorage needs to be created early in startup and
unconditionally
+ // because of OopStorageSet static array indices
Thanks,
Serguei
Thanks!
BRs,
Lin
From:
"serguei.spit...@oracle.com"
Date: Friday, August 7, 2020 at 3:28 PM
To: "linza
Hi Coleen,
It looks good to me.
Minor:
+void JvmtiExport::initialize_oop_storage() {
+ // OopStorage needs to be created early in startup and unconditionally
+ // because of OopStorageSet static array indices.
+ _jvmti_oop_storage =
-Original Message-
From: serviceability-dev
On Behalf Of
Reingruber, Richard
Sent: Montag, 27. Juli 2020 09:45
To: serguei.spit...@oracle.com;
serviceability-dev@openjdk.java.net
Subject: [
On 8/10/20 10:21,
serguei.spit...@oracle.com wrote:
Hi Richard and David,
The implementation looks good to me.
But I do not understand what the test is doing with all these
counters and recursions
On 8/7/20 00:24,
serguei.spit...@oracle.com wrote:
Hi Lin,
Not sure, I fully understand the spec update and the options
processing in the file:
http://cr.openjdk.java.net/~lzang/jmap-8214535/8215624/webrev_11/src/jdk.jcmd
+ 8 byte
> klassptr + 8byte field) in a heap that is larger than 96 GB, uint64_t
> is ok in this case.
Exactly.
Thanks,
StefanK
>
r
than 96 GB, uint64_t
> is ok in this case.
Exactly.
Thanks,
StefanK
>
> BRs,
>
, serguei.spit...@oracle.com wrote:
On 8/4/20 16:46, Chris Plummer
wrote:
On 8/4/20 4:41 PM, Chris Plummer
wrote:
On 8/4/20 4:05 PM, serguei.spit...@oracle.com
wrote
-alex
On 08/04/2020 17:22, serguei.spit...@oracle.com wrote:
Hi Alex,
This looks good to me.
But do we need a CSR for this?
I understand that the intention is to comply with the
TransportService spec but the behavior is being changed.
How long did we have this behavior?
Thanks,
Serguei
O
.
BRs,
Lin
From:
"serguei.spit...@oracle.com"
Date: Wednesday, August 5, 2020 at 1:02 PM
To: "linzang(臧琳)"
, "Hohensee, Paul"
Oh, sorry for the confusion, please,
skip my question. :)
C++ does not have the '&&=' operator.
Thanks,
Serguei
On 8/4/20 21:56, serguei.spit...@oracle.com wrote:
Hi Lin,
https://cr.openjdk.java.net/~lz
/~lzang/jmap-8214535/8215624/webrev_08/
BRs,
Lin
-
From: "Hohensee, Paul"
Date: Thursday, July 23, 2020 at 6:48 AM
To: "linzang(臧琳)" , Stefan Karlsson , "serguei.spit...@or
Hi Igor,
It looks okay to me.
At least, I've not noticed any issues.
Thanks,
Serguei
On 8/4/20 16:59, Igor Ignatyev wrote:
ping?
-- Igor
On Jul 31, 2020, at 1:24 PM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8249030/webrev.00
2258 lines changed: 0 ins; 1144 del; 1114
Hi Jie,
Could you, please, split the format string in two shorter lines?
Otherwise, it looks okay.
There is no need in another webrev.
Thanks,
Serguei
On 8/4/20 18:38, jiefu(傅杰) wrote:
Thanks Chris and
Hi Alex,
This looks good to me.
But do we need a CSR for this?
I understand that the intention is to comply with the TransportService
spec but the behavior is being changed.
How long did we have this behavior?
Thanks,
Serguei
On 8/4/20 16:32, Alex Menkov wrote:
Needs one more reviewer.
On 8/4/20 11:04, Chris Plummer wrote:
On 8/4/20 2:11 AM, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
The fix looks good to me.
Thanks to Chris for discussing the details in previous emails.
Just
Hi Chris,
LGTM++
Thanks,
Serguei
On 8/3/20 22:10, Yasumasa Suenaga wrote:
Hi Chris,
Looks good.
Yasumasa
On 2020/08/04 13:10, Chris Plummer wrote:
Ping!
On 7/27/20 10:04 PM, Chris Plummer wrote:
I should have mentioned that currently there is no testing of this
code. There will with
Hi Yasumasa,
It looks good.
I forgot to say there is no need in new webrev.
Thanks,
Serguei
On 8/4/20 05:22, Yasumasa Suenaga wrote:
Hi Serguei,
Thanks for your comment!
On 2020/08/04 18:11, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
The fix looks good to me.
Thanks to Chris
Hi Yasumasa,
The fix looks good to me.
Thanks to Chris for discussing the details in previous emails.
Just one suggestion:
Hi Chris,
LGTM++
Thanks,
Serguei
On 8/3/20 16:19, Alex Menkov wrote:
Hi Chris,
Looks good
--alex
On 08/03/2020 14:53, Chris Plummer wrote:
Ping! This is a fairly trivial testing fix to avoid timeouts when
using LingeredApp to generate a core dump. No knowledge of SA is needed.
thanks,
Hi Chris,
LGTM++
Thanks,
Serguei
On 7/30/20 02:16, Kevin Walls wrote:
Hi Chris - Yes, that's a good discovery, looks good,
Thanks
Kevin
On 29/07/2020 21:08, Chris Plummer wrote:
Hello,
Please help review the following:
https://bugs.openjdk.java.net/browse/JDK-8250750
Hi Joe,
It looks good to me.
Thanks,
Serguei
On 7/27/20 23:45, Alan Bateman wrote:
On 27/07/2020 21:42, Joe Darcy wrote:
Hello,
Another module, another set of default constructors to replace with
explicit ones. Please review the code changes and CSR to address:
JDK-8250640:
va.net/~lmesnik/8244537/webrev.04/
Leonid
On Jul 28, 2020, at 11:06 PM, serguei.spit...@oracle.com
wrote:
http://cr.openjdk.java.net/~lmesnik/8244537/webrev.03/tes
:
Included
in webrev.03
http://cr.openjdk.java.net/~lmesnik/8244537/webrev.03
Leonid
On Jul 28, 2020, at 6:44 PM, serguei.spit...@oracle.com
wrote:
http
og3("ERROR:IllegalThreadStateException");
387 }
388 }
Above is one more case where suspend/resume is needed, I guess.
Thanks,
Serguei
On 7/28/20 17:45, serguei.spit...@oracle.com wrote:
http:/
net/~lmesnik/8244537/webrev.01/
Leonid
On Jul 28, 2020, at 2:06 PM, serguei.spit...@oracle.com
wrote:
I prefer to suspend/resume
in all cases, so we avoid
Hi Chris,
It looks good and trivial.
Thanks,
Serguei
On 7/28/20 16:02, Chris Plummer wrote:
Hello,
Please review the following.
diff --git a/test/hotspot/jtreg/ProblemList-zgc.txt
b/test/hotspot/jtreg/ProblemList-zgc.txt
--- a/test/hotspot/jtreg/ProblemList-zgc.txt
+++
On Jul 28, 2020, at 1:54 PM, serguei.spit...@oracle.com
wrote:
Does it mean, you did not
fix cases 0 and 2 because the related failures have
never been observed
if
we can enable events. Such failures should be easily identified by
reading logs.
Leonid
On Jul 27, 2020, at 10:28 PM, serguei.spit...@oracle.com
wrote
Hi Leonid,
The fix looks good in general.
You missed to explain that the suspend/resume are added to avoid
actual generation of event that cause this issue.
The reason is that these events are not actually required.
Okay, thank you for explanations.
Serguei
On 7/27/20 16:53, Chris Plummer wrote:
On 7/27/20 4:40 PM, serguei.spit...@oracle.com wrote:
Hi Chris,
The fix looks okay to me.
Nit
Hi Joe,
The update looks okay to me too.
Thanks,
Serguei
On 7/25/20 11:18, Alan Bateman wrote:
On 25/07/2020 18:52, Joe Darcy wrote:
Hello,
I'm not positive serviceability-dev is the best alias for this
review; if not, please direct me elsewhere.
In any case, please review the changes
JDK-8248882.
[1] https://bugs.openjdk.java.net/browse/JDK-8249779
[2] https://bugs.openjdk.java.net/browse/JDK-8248882
thanks,
Chris
Hi Chris,
LGTM++
Thanks,
Serguei
On 7/27/20 14:45, Alex Menkov wrote:
Hi Chris,
Looks good to me.
--alex
On 07/27/2020 12:11, Chris Plummer wrote:
Ping! This one is pretty easy. I just changed the two tools to no
longer refuse to run on OSX if we are debugging a core file, and
updated
Hi Coleen,
The fix looks good to me.
I've more focused on the serviceability related update.
Thank you for taking care about it!
Thanks,
Serguei
On 7/24/20 06:10, coleen.phillim...@oracle.com wrote:
I can also replace method_oop with method_ptr in the CPU ad files, and
this seems to build
Hi Richard,
Thank you for filing the CR and taking care about it!
The fix itself looks good to me.
I still need another look at new test.
Could you, please, convert the agent of new test to C++?
It will make it a little bit simpler.
Thanks,
Serguei
On 7/20/20 01:15, Reingruber, Richard wrote:
/df75038b5449
Yasumasa
On 2020/07/23 9:31, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
Looks good.
Just one minor comment.
http://cr.openjdk.java.net/~ysuenaga/JDK-8248362/webrev.00/src/hotspot/share/prims/jvmtiEnv.cpp.udiff.html
// JVMTI get java stack frame location
to OverpassMethods.java to avoid warnings during the build
about conflict with native library for runtime/jni/8033445/DefaultMethods.java
test.
[1] http://cr.openjdk.java.net/~dtitov/8216324/webrev.04/
Thank you,
Daniil
From: "serguei.spit...@oracle.com"
Date: Tuesday, July 21, 2020 at 10:53 PM
1 - 100 of 2392 matches
Mail list logo
