Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

On 04/05/2013 02:17 PM, Johannes Renner wrote: > On 04/05/2013 08:52 AM, Jan Pazdziora wrote: >> Hmm, I wonder if the current logic is actually correct. It feel that >> a kickstartable channel (for the purpose of creating kickstart profile, >> for example) would be channel

Re: [Spacewalk-devel] On quality of patches

On 03/05/2014 08:04 AM, Lamont Peterson wrote: > On 3/4/14, 12:31 AM, "Silvio Moioli" wrote: > >>> From: Paul Robert Marino >> > >>> I think we need a map of what these shared file and functions effect so >>> we can do more formal QA testing in the future >> >> On 03/0

[Spacewalk-devel] [PATCH] Add missing GMT+3 timezone

fer >From 6d3be8faa7754e7151c57c07827eda8543c7a83e Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Wed, 12 Feb 2014 09:42:05 +0100 Subject: [PATCH] Add missing GMT+3 timezone as Saudi Arabia --- .../rhn/frontend/strings/database/StringResource_en_US.xml | 6 ++ schema/spacewalk/common/data/rhnTimezone.sql

Re: [Spacewalk-devel] [PATCH] SUSE Studio API will stop working via unencrypted HTTP

On 01/22/2014 12:18 PM, Johannes Renner wrote: Hello, The SUSE Studio API will no longer process requests via unencrypted HTTP after Jan 2014, see here: http://blog.susestudio.com/2013/12/coming-soon-https-only-on-suse-studio.html Therefore attached is a patch to change the default endpoint

Re: [Spacewalk-devel] [PATCH] Allow null as createdBy and lastModifiedBy for custom data values

On 01/21/2014 06:10 PM, Johannes Renner wrote: > On 01/21/2014 03:38 PM, Jan Dobes wrote: >> Hello Johannes, >> >> I'm not sure how to reproduce this. I tried to create user, create custom >> key, assign value to system, delete user, changing values... >>

[Spacewalk-devel] [PATCH] SUSE Studio API will stop working via unencrypted HTTP

Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From f523f1d0188c4094888513026478435db169ce3c Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Wed, 22 Jan 2014 10:41:08 +0100 Subject: [PATCH] SUSE Studio API will stop working via unencrypted H

Re: [Spacewalk-devel] [PATCH] Allow null as createdBy and lastModifiedBy for custom data values

On 01/21/2014 03:38 PM, Jan Dobes wrote: > - Original Message - >> From: "Johannes Renner" >> To: spacewalk-devel@redhat.com >> Sent: Friday, January 17, 2014 12:30:09 PM >> Subject: [Spacewalk-devel] [PATCH] Allow null as createdBy and >

[Spacewalk-devel] [PATCH] Allow null as createdBy and lastModifiedBy for custom data values

ute(GenericIndexTask.java:91) Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 910d1db851a485ec565f7e59f6b1d0d89c29 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Fri, 17 Jan 2014 12:01:45 +0100 Su

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

On 01/08/2014 02:34 PM, Michael Mraka wrote: > Maximilian Meister wrote: > % >I see. Then it should keep the original name so we can easily figure out > % >where it came from and replace it with newer version in the future. > % > % Hi Michael, > % > % the original name would be pwstrength.js (in

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

On 01/07/2014 10:54 AM, Michael Mraka wrote: > Maximilian Meister wrote: > % Hi everybody, > % ... > > Hello Maximilian, > > Is the spacewalk-pwstrength.js a copy of jquery.pwstrength.bootstrap > (i.e. third party stuff) or your own implementation of it? Currently it's basically a copy of third

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

On 12/20/2013 05:15 PM, R P Herrold wrote: > On Fri, 20 Dec 2013, Maximilian Meister wrote: > >> this patch would add a bootstrapified password strength >> meter to all pages where user details are being created or >> edited (create the initial admin user, create/edit normal >> users and create

[Spacewalk-devel] [PATCH] Fix the Java package of DeleteGroupAction class

rom 8e0a0192c54255e50a760887e1349d55492ab813 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Wed, 18 Dec 2013 14:57:00 +0100 Subject: [PATCH] Fix the java package of DeleteGroupAction class --- .../src/com/redhat/rhn/frontend/action/groups/DeleteGroupAction.java| 2 +- 1 file changed, 1 insertion(+), 1 delet

[Spacewalk-devel] [PATCH] Fix NPE when uploading kickstart profile

16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From dbe021e76741e7f8a503ad37021e78deeeb13c3f Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Wed, 18 Dec 2013 11:32:26 +0100 Subject: [PATCH] Fix NPE when uploading kickstart profile with virt type none --- .../fr

[Spacewalk-devel] [PATCH] License of spacewalk-branding needs to be changed

>From 633c050f3a068aa8a52a217c5f6ea55cd15a3937 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Thu, 21 Nov 2013 15:00:27 +0100 Subject: [PATCH] Fix the "License" of spacewalk-branding package --- branding/spacewalk-branding.spec | 2 +- 1 file changed, 1 insertion(+), 1 dele

[Spacewalk-devel] [PATCH] Fix Search for Custom Info Values + NPE

ting a new custom key value and before clicking on "Update Key", do "delete value" above. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From a61776d4e453cdc7462ee95a0b9a3077f0fe886d Mon Sep 17 00

Re: [Spacewalk-devel] [PATCH] Fix navigation for the default snippets page

rnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From c3d4d35e6606e625eaf01719d41ef498741b8d2a Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Wed, 6 Nov 2013 10:04:12 +0100 Subject: [PATCH] Use kickstart icon on the snippets page --- java/code/webapp/WEB-INF/pages/kickstar

Re: [Spacewalk-devel] [PATCH] Fix navigation for the default snippets page

On 11/04/2013 05:52 PM, Stephen Herr wrote: > Hi Johannes, > > On 11/04/2013 10:05 AM, Johannes Renner wrote: >> Further I wonder if we shouldn't go to the "Default Snippets" page per >> default once >> a user navigates to Systems -> Kickstart? A

[Spacewalk-devel] [PATCH] Fix navigation for the default snippets page

Guild, Felix Imendörffer >From 6c53744d2759101d20f9603475fdcbf98c475a72 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Mon, 4 Nov 2013 15:23:37 +0100 Subject: [PATCH] Fix navigation for the default snippets page --- java/code/webapp/WEB-INF/nav/sitenav-authenticated.xml | 1 + 1 file changed, 1 insertion(+) diff --

Re: [Spacewalk-devel] Less compiler package to use

On 10/22/2013 02:07 PM, Tomáš Kašpárek wrote: > I've noticed that some icons (e.g. in legend text on the left) are missing, > also search button is > missing some picture or text. On pages like > /rhn/channels/ChannelDetail.do?cid=101 (Channels -> pick > one from displayed channels) old update bu

Re: [Spacewalk-devel] Less compiler package to use

On 10/22/2013 02:07 PM, Tomáš Kašpárek wrote: > I've locally merged contents of bootstrap-css branch and apart from > spacewalk-branding all other > packages (spacewalk-java and spacewalk-web) all packages were build correctly > and all packages were > correctly upgraded. > > I've noticed that s

Re: [Spacewalk-devel] Less compiler package to use

On 10/22/2013 01:05 PM, Tomáš Kašpárek wrote: > Hello Johannes, > > I've discovered issue in 12ce0476ba547fade1cbe3819e77fd560de7fdb0 which > causes RPM build errors > during build time. > > RPM build errors: > File not found: > /root/rpmbuild/BUILDROOT/spacewalk-branding-2.1.5-1.git.233.e7a

Re: [Spacewalk-devel] Less compiler package to use

On 10/21/2013 01:06 PM, Michael Mraka wrote: > Johannes Renner wrote: > % Hello, > % > % While working on the Spacewalk redesign, we so far used less.js > client-side. This is fine for > % development purposes, but it's however not the recommended way to go for &g

[Spacewalk-devel] Less compiler package to use

Hello, While working on the Spacewalk redesign, we so far used less.js client-side. This is fine for development purposes, but it's however not the recommended way to go for production environments, see [1]. Rather we probably want to compile the spacewalk.less into spacewalk.css during the rpm

Re: [Spacewalk-devel] ISE when changing user details on /rhn/users/UserDetails.do?uid=2

On 10/17/2013 04:17 PM, Tomáš Kašpárek wrote: > Hello, > > I've merged contents of bootstrap-css branch with current Spacewalk master, > built it and applied. > I've noticed that changing user details as admin produces ISE. > > Sending you patch which fixes the problem Thank you very much for t

[Spacewalk-devel] [PATCH] Make taskomatic max memory configurable via rhn.conf

Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From bff7c320b8b6a20f1f829982a166077e07989afa Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Fri, 13 Sep 2013 11:11:13 +0200 Subject: [PATCH] Make taskomatic max memory configurable via rhn.conf

[Spacewalk-devel] [PATCH] Fix javascript "Uncaught TypeError"

081d4ca2ebf202 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Tue, 27 Aug 2013 12:19:48 +0200 Subject: [PATCH] Fix javascript "Uncaught TypeError" --- java/code/webapp/WEB-INF/pages/user/create/usercreate.jsp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ja

Re: [Spacewalk-devel] [PATCH] Make CSV Separator Character Configurable

call it something other than *.csv. >> >> -Stephen >> >> On 08/19/2013 08:21 AM, Johannes Renner wrote: >>> Hey, >>> >>> here is a small feature patch that allows users to choose semicolon (";") >>> as an >>> alte

[Spacewalk-devel] [PATCH] Make CSV Separator Character Configurable

ff Hawn, Jennifer Guild, Felix Imendörffer >From 7a446a37f1582321f432d097bd3dabdac8ecb9a2 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Mon, 19 Aug 2013 13:31:35 +0200 Subject: [PATCH 1/3] Allow users to change the CSV separator (schema changes) --- schema/spacewalk/common/tab

[Spacewalk-devel] [PATCH] Fix html not being escaped in package information

and regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 63be1b2d99b4a594e3cd198565ea5a13197aae87 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Mon, 5 Aug 2013 15:42:53 +0200 Subject: [PATCH] Fix HTML not

[Spacewalk-devel] [PATCH] Fix ISE when UUID and host ID is null

HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 1e0f80e4b6f43ade890dd3dae2a71bb4544dff01 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Fri, 19 Jul 2013 13:39:51 +0200 Subject: [PATCH] Fix ISE when UUID and host ID is null --- .../rhn/frontend/a

[Spacewalk-devel] [PATCH] Fix indentation on user preferences page

Thanks and regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From b687d7444374ca60fdc6a8387e70013e3acb8f12 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Fri, 12 Jul 2013 11:33:30 +0200 Subject: [PATCH] Fix indent

Re: [Spacewalk-devel] [PATCH] SSH Push Feature Proposal

On 04/12/2013 01:24 PM, Jan Pazdziora wrote: > Johannes, > > let me summarize some big picture impressions, without commenting on > every detail. > > You propose to address two situations: > > 1) clients in DMZ that cannot reach the server, with server able to >reach the clients; > > 2) ove

[Spacewalk-devel] [PATCH] Add missing string "systems.details.virt.actions.scheduled"

from VirtualGuestsConfirmAction.java though, so the attached patch puts it back in place. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From d1a7f3acdecb7dbd988f0da5237c08d2cc2809f2 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Tue, 16 Apr

Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

On 04/05/2013 08:52 AM, Jan Pazdziora wrote: > Hmm, I wonder if the current logic is actually correct. It feel that > a kickstartable channel (for the purpose of creating kickstart profile, > for example) would be channel that has at least one kickstartable > tree, or channel cloned from one that h

Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

On 04/04/2013 04:31 PM, Jan Pazdziora wrote: > On Thu, Apr 04, 2013 at 03:37:07PM +0200, Johannes Renner wrote: >> On 03/22/2013 02:55 PM, Michael Calmer wrote: >>> Hi, >>> >>> please do not apply these patches. I found out, that it is not correct. >>>

Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

ohannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 3420bb7304b4522984b3d26871ca7a3f9106575a Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Thu, 4 Apr 2013 14:45:27 +0200 Subject: [PATCH] Kickstartable vs. autoinstallabl

Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

On 03/13/2013 05:33 PM, Johannes Renner wrote: > attached is a patch that should take care that only kickstartable channels > are actually > returned by the getKickstartableChannels() method in the ChannelFactory class. Argh, this fixes ConcurrentModificationException, sorry! -- S

[Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

on Sep 17 00:00:00 2001 From: Johannes Renner Date: Wed, 13 Mar 2013 17:00:01 +0100 Subject: [PATCH] Kickstartable channels should contain the anaconda package --- .../src/com/redhat/rhn/common/conf/ConfigDefaults.java|1 + .../src/com/redhat/rhn/domain/channel/ChannelFactory.java | 1

[Spacewalk-devel] [PATCH] Fix typo on "Task Schedules" page

f1b005622557c Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Thu, 21 Feb 2013 13:34:25 +0100 Subject: [PATCH] Fix nasty typo throughout translation files --- .../src/com/redhat/rhn/frontend/strings/jsp/StringResource_de.xml |4 ++-- .../com/redhat/rhn/frontend/strings/jsp/StringResource

Re: [Spacewalk-devel] Timezone problem with DB timestamps

On 02/15/2013 09:55 AM, Tomas Lestach wrote: > On Wednesday 13 of February 2013 11:04:46 Johannes Renner wrote: >> On 08/01/2012 06:04 PM, Tomas Lestach wrote: >>> Hello Johannes, >>> >>> I somehow misread the javadoc you linked in your original e-mail. >>

Re: [Spacewalk-devel] Timezone problem with DB timestamps

stamp val = gmtime(val) ... Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 95e80666b5c3c163dd5c0d4763efa61ebea60ee6 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Tue, 12 Feb 2013 18:05:51 +0100 Subject: [PATC

[Spacewalk-devel] [PATCH] Support native kvm images in SUSE Studio integration

uot; % extractedImagePath) if not os.path.exists( extractedImagePath ): diff --git a/client/tools/rhn-virtualization/scripts/studio-kvm-template.xml b/client/tools/rhn-virtualization/scripts/studio-kvm-template.xml index 42ac7dd..73d7797 100644 --- a/client/tools/rhn-virtualization/scripts/studio-

Re: [Spacewalk-devel] List of installable packages: API vs. Web UI

On 11/08/2012 12:18 PM, Johannes Renner wrote: > On 11/05/2012 12:03 PM, Tomas Lestach wrote: >> ... >> If there's a bug in the API call, we of course fix it. >> But we try to keep the current API interface as is. Spacewalk users have >> their >> scripts

Re: [Spacewalk-devel] [PATCH] Errors with unrequired field "Prefix"

On 11/15/2012 03:57 PM, Johannes Renner wrote: > Hey again, > > We found some errors with the prefix field of a user's properties. First, > when creating > a new user with the UI, it is not possible to leave the prefix empty, it > complains about > a non-valid va

[Spacewalk-devel] [PATCH] Errors with unrequired field "Prefix"

mewhere.. This works for me now, but I tested the fix on PG only. Thanks, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 7e095b96cc5d104b76cb0121ed8dc89e62ce50eb Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Thu, 1

Re: [Spacewalk-devel] [PATCH] WebUI HTTP proxy validator doesn't check for special characters

On 11/14/2012 04:21 PM, Tomas Lestach wrote: > On Wednesday 14 of November 2012 15:06:44 Johannes Renner wrote: >> Hello, >> >> I just extended the HostPortValidator class to check proxy hostnames against >> a regex defining a valid character set. It should allo

[Spacewalk-devel] [PATCH] WebUI HTTP proxy validator doesn't check for special characters

nnes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 9628af3c615588d24d6be31d999b19e0532fdf24 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Wed, 14 Nov 2012 14:54:35 +0100 Subject: [PATCH] Check hostnames for special ch

[Spacewalk-devel] [PATCH] SUSE Studio integration patches

. Catch MalformedURLExceptions for not crashing in case of a missing protocol etc. Best regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 0cc632b53cb828837bfb556758c1b2922d4df96e Mon Sep 17 00:00:00 2001 From: Johannes Ren

Re: [Spacewalk-devel] [PATCH] Kickstart profiles error handling

gt; Related commits: > 747754ef > 74aa5047 > d1789a9e Thank you, I merged your commits into our branch, but did not do any testing yet. Two remarks regarding d1789a9e: - I fixed a typo in one of the new messages: "bellow" -> "below" - I think we could omit the 

[Spacewalk-devel] [PATCH] Quartz SimpleTrigger mis-fire situations

Guild, Felix Imendörffer >From e6172072966a2a7824770a48a033b064c787ac8b Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Fri, 9 Nov 2012 11:22:50 +0100 Subject: [PATCH] Fix quartz trigger initialization repeat count --- java/code/src/com/redhat/rhn/taskomatic/TaskoQuartzHelper.java |2 +-

Re: [Spacewalk-devel] List of installable packages: API vs. Web UI

On 11/05/2012 12:03 PM, Tomas Lestach wrote: > ... > If there's a bug in the API call, we of course fix it. > But we try to keep the current API interface as is. Spacewalk users have > their > scripts using our API calls and we do not want to break the scripts by > renaming/deleting existing AP

Re: [Spacewalk-devel] [PATCH] Kickstart profiles error handling

On 11/07/2012 04:50 PM, Tomas Lestach wrote: > On Tuesday 06 of November 2012 12:30:09 Johannes Renner wrote: >> Hello, >> >> this is a proposed extension to commit 1ea830a in master: >> >> Validation of a kickstart profile is currently done by downloading it fr

[Spacewalk-devel] [PATCH] Kickstart profiles error handling

ards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 5e754d93de7475a88e38578faa0d32fce7581cdb Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Tue, 6 Nov 2012 12:10:34 +0100 Subject: [PATCH] Improve kickstart profiles e

Re: [Spacewalk-devel] [PATCH] Use braces for accessing composite types in PG

On 10/31/2012 05:00 PM, Tomas Lestach wrote: > On Wednesday 31 of October 2012 14:38:49 Johannes Renner wrote: >> Hey, >> >> Ok, here is the patch to make the rewritten query work with PG as well (API >> call 'system.listLatestUpgradablePackages'). It

Re: [Spacewalk-devel] List of installable packages: API vs. Web UI

On 11/01/2012 01:59 PM, Tomas Lestach wrote: > On Wednesday 31 of October 2012 15:00:48 Johannes Renner wrote: >> Hello, >> >> We found that the list of installable packages for a given system differs if >> you either ask the API (via system.listLatestInstallablePacka

[Spacewalk-devel] List of installable packages: API vs. Web UI

Hello, We found that the list of installable packages for a given system differs if you either ask the API (via system.listLatestInstallablePackages) or if you go to the Web UI (Systems -> [choose a system] -> Software -> Packages -> Install). After looking into it, I found there is two differe

[Spacewalk-devel] [PATCH] Use braces for accessing composite types in PG

only.. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From f48143d211baeb4161814ae5deb537aa57642c70 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Wed, 31 Oct 2012 12:18:02 +0100 Subject: [PATCH] Use braces for accessing

Re: [Spacewalk-devel] [PATCH] Schedule updates for the software update stack first

This is just a small follow up patch which makes the list conversion obsolete. Thanks, Johannes On 10/19/2012 11:01 AM, Johannes Renner wrote: > Hello, > > attached is patches that will take care that, in case there is an update to > the software update > stack, it will be sched

[Spacewalk-devel] [PATCH] Schedule updates for the software update stack first

-- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From b27fdfcda077af488a17d6a2b7a18e133b01909a Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Thu, 18 Oct 2012 17:26:01 +0200 Subject: [PATCH] Schedule updates for software updat

Re: [Spacewalk-devel] [PATCH] Validate proxy format on general config page

6c7332a44974b95f51146e59a527356f29 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Tue, 18 Sep 2012 14:17:11 +0200 Subject: [PATCH] Validate proxy format on general config page --- .../rhn/common/validator/HostPortValidator.java| 134 .../validato

Re: [Spacewalk-devel] [PATCH] Validate proxy format on general config page

s [1] https://code.google.com/p/guava-libraries/source/browse/guava/src/com/google/common/net/HostAndPort.java -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 8f2afb12a36939da36856dff630d09746b9cd8ff Mon Sep 17 00:00:00 2001 From: J

Re: [Spacewalk-devel] [PATCH] Validate proxy format on general config page

On 09/11/2012 01:32 PM, Tomas Lestach wrote: > On Monday 10 of September 2012 11:36:49 Johannes Renner wrote: >> Hey, >> >> Here is a patch for adding some validation to the HTTP proxy field on the >> general config page (https:///rhn/admin/config/GeneralConfig.do). >

[Spacewalk-devel] [PATCH] Validate proxy format on general config page

e case for you? I might look after this bug as well.. Thanks, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 8ecd2908bb32bbce565503176b6fe937e851a2de Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Mon, 10 Sep 2012 1

Re: [Spacewalk-devel] [PATCH] CVEs missing in the security patches listing (on Oracle 11)

On 08/17/2012 01:20 PM, Jan Pazdziora wrote: > On Fri, Aug 17, 2012 at 01:02:38PM +0200, Johannes Renner wrote: >> Hey, >> >> apparently the method getColumnLabel() of class ResultSetMetaData returns >> the column >> label in uppercase with Oracle 11 (using ojd

[Spacewalk-devel] [PATCH] CVEs missing in the security patches listing (on Oracle 11)

ix Imendörffer >From dd9bf777412f470c7a8fee58408b495036f0d55b Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Fri, 17 Aug 2012 12:06:49 +0200 Subject: [PATCH] Fix missing CVEs in patches listing with Oracle 11 --- .../rhn/frontend/dto/SecurityErrataOverview.java |2 +- 1 files changed, 1 insertions(+), 1 del

[Spacewalk-devel] [PATCH] Insert pxt session errors on postgres

:///help/about.pxt Attached please find a patch for the issue. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 76dfe76b7cb8a7882951849ed537a66154aa86cc Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Wed, 15

Re: [Spacewalk-devel] [PATCH] Script contents not properly displayed

On 08/14/2012 03:36 PM, Stephen Herr wrote: > Johannes, > > Could you ensure in /usr/share/pgsql/postgresql.conf that bytea_output = > 'escape', and if not see if > that corrects your problem? > > -Stephen Thanks, setting this option fixes the problem on the postgres 9.1 database we are using.

[Spacewalk-devel] [PATCH] Script contents not properly displayed

ot; The attached patch fixes the problem by converting the ASCII codes into a string using the pack() function. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From b00d36ff71783dd870e67cc969a9de2f55df4221 Mon Sep

Re: [Spacewalk-devel] [PATCH] Query not elaborated?

On 08/06/2012 05:59 PM, Tomas Lestach wrote: > Hello Johannes, > > On Friday 03 of August 2012 12:44:11 Johannes Renner wrote: >> Hi, >> >> We found out that commit 16f30f97d657ab7019489dfac5a11f67afc2143e apparently >> broke the Errata page for custom channels: &

[Spacewalk-devel] [PATCH] Query not elaborated?

rom 3a688e6570caa2ef2a4d0a20ffbf3f9237865efe Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Fri, 3 Aug 2012 12:13:49 +0200 Subject: [PATCH] Call elaborate manually --- .../redhat/rhn/manager/channel/ChannelManager.java |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/java/code/src/

Re: [Spacewalk-devel] Timezone problem with DB timestamps

Guild, Felix Imendörffer >From 57cc8bee7b5d77486671cff244551d12a95cdcb2 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Tue, 31 Jul 2012 16:03:40 +0200 Subject: [PATCH] Fix wrong package build times in repository metadata --- .../com/redhat/rhn/frontend/dto/PackageDto.java| 12 +++- 1 f

[Spacewalk-devel] Timezone problem with DB timestamps

times only, and do so in PackageDto.setBuildTime(). What do you think? Thanks, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 861cf5c634c611f19ed509fb96126adb5f4cea19 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Mon,

[Spacewalk-devel] New column 'mac_address'

Hey, I just saw in commit 8a0662e (Allow user to set MAC Address when provisioning a virtual guest), that there is a new database migration script (109-rhnactionkickstartguest...), but the initial creation of this table was not modified. Shouldn't the initial creation also add the 'mac_address'

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

ing with the new constant RhnHelper.DEFAULT_FORWARD, just for being consistent with recent changes here. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From d3fe367991d13c85b83e5a821688d4c32db5f248 Mon Sep 17 00:00:00 2001

[Spacewalk-devel] spacewalk-search declared as GPL-2.0 but contains Apache licenses

? I guess you would have to add both license texts to the package and it should be reflected in the specfile (spacewalk-search.spec) as well: "License: GPLv2" --> "License: GPL-2.0 and Apache-2.0" Thank you, Johannes Renner Please see the list of files here: spacewa

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

On 05/21/2012 02:17 PM, Miroslav Suchý wrote: > On 05/18/2012 05:11 PM, Miroslav Suchy wrote: >> >> I still have to test the client part. > > in spec: > Requires: python-curl > > In Fedora/RHEL the package is called python-pycurl, please fix it using %if No problem. > After image is scheduled,

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

On 05/18/2012 05:11 PM, Miroslav Suchy wrote: > In WebUI patch please do s/SUSE Manager/@@PRODUCT_NAME@@/ Sure, I will do that for the next version of the patches. Sorry for that. > When I enter credentials for Suse studio they are not validated. Can you > later add some code to do > some valida

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

On 05/18/2012 02:45 PM, Miroslav Suchy wrote: > In patch 0001 - schema db - you are missing upgrades for table > suseCredentialsType. > > And upgrades for table suseCredentials differs from clean install. Oh yeah, sorry, I forgot to revise the upgrade files. I can come up with another patch fixi

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

On 05/16/2012 12:49 PM, Miroslav Suchy wrote: > On 16.5.2012 11:01, Johannes Renner wrote: >> I guess we could have some "%if (0%?rhel/?suse_version) %else ..." though, >> if you prefer that. > > Ok, I will put there %if and for license as well. Good, let me see

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

On 05/15/2012 09:29 PM, Miroslav Suchy wrote: > On 15.5.2012 14:28, Johannes Renner wrote: >> On 05/15/2012 01:25 PM, Miroslav Suchy wrote: >>> +Requires: susestudio-java-client >>> >>> This will require susestudio-java-client rpm? It is not present in neithe

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

On 05/15/2012 01:25 PM, Miroslav Suchy wrote: > +Requires: susestudio-java-client > > This will require susestudio-java-client rpm? It is not present in neither in > Fedora nor in jpackage. > Can I take: > > https://build.opensuse.org/package/view_file?file=susestudio-java-client.spec&package=su

[Spacewalk-devel] [PATCH] Fix errata clone name generation in perl code

was not rewritten? Or is it just remaining by accident? Thank you, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From b497b86fdfa6054c60c35a2d78f5eb8a05a445af Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Mon, 23 Apr 2012

Re: [Spacewalk-devel] [PATCH] Naming of cloned errata

On 04/11/2012 02:28 PM, Jan Pazdziora wrote: > On Wed, Apr 11, 2012 at 11:43:07AM +0200, Johannes Renner wrote: >> >> I agree that clones of clones should get CM, CN, etc. instead of >> CL-CL-kernel*. >> How would you propose to detect clones for implementing this algor

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

On 04/05/2012 02:00 PM, Miroslav Suchý wrote: > On 03/30/2012 04:46 PM, Johannes Renner wrote: >> Oh yes, there is two new required jar files, while RPM packages + spec files >> can be >> found here: >> >> -https://build.opensuse.org/package/show?package=susestudi

Re: [Spacewalk-devel] [PATCH] Naming of cloned errata

On 04/04/2012 03:42 PM, Cliff Perry wrote: > On 04/04/2012 04:47 AM, Tomas Lestach wrote: >> On Friday 30 of March 2012 17:06:17 Johannes Renner wrote: >>> On 03/07/2012 11:57 AM, Johannes Renner wrote: >>>> On 03/06/2012 05:42 PM, Johannes Renner wrote: >>>

Re: [Spacewalk-devel] Removed strings still being used

On 04/02/2012 03:32 PM, Miroslav Suchy wrote: > On 2.4.2012 14:47, Johannes Renner wrote: >> Hey, >> >> After running our testsuite against a recent codebase, we saw (from >> catalina.out) >> that the following removed strings seem to be still in us

[Spacewalk-devel] Removed strings still being used

Hey, After running our testsuite against a recent codebase, we saw (from catalina.out) that the following removed strings seem to be still in use: configchannelfilter.name configfilefilter.path config_subscribed_systems.unsubscribeSystems.success config_target_systems.subscribeSystems.success he

Re: [Spacewalk-devel] [PATCH] Naming of cloned errata

On 03/07/2012 11:57 AM, Johannes Renner wrote: > On 03/06/2012 05:42 PM, Johannes Renner wrote: >> Hey, >> >> I want to propose a change concerning the names of cloned errata. >> Currently, names of cloned errata are generated like this: >> &

[Spacewalk-devel] [PATCH] Checkstyle 4.1 vs. 4.3

endörffer >From 0bcacfc4bbc032c17263198f5bc8dde4ec000aef Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Fri, 30 Mar 2012 10:26:25 +0200 Subject: [PATCH] Add lib directory to checkstyle classpath --- java/spacewalk-java.spec |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [Spacewalk-devel] ivy

On 03/28/2012 10:38 AM, Tomas Lestach wrote: > On Tuesday 27 of March 2012 23:00:53 Miroslav Suchy wrote: >> Do we still use ivy from jpp? Can we use apache-ivy from Fedora? > > Where do you see, we use ivy? I believe we do not require ivy in run or build > time. > If you mean development worksta

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

On 03/27/2012 11:35 AM, Miroslav Suchý wrote: > On 03/27/2012 10:27 AM, Johannes Renner wrote: >> The feature involves a new action type to be put in table rhnActionType, >> which >> we chose to give the ID 500 for now (just to make sure there will be no >> clash in

[Spacewalk-devel] Deployment of images built with SUSE Studio

Hello, We recently added a feature to our branch of Spacewalk that enables users to deploy images that were built with SUSE Studio [1] to registered virtual host systems. The feature involves a new action type to be put in table rhnActionType, which we chose to give the ID 500 for now (just to ma

Re: [Spacewalk-devel] [PATCH] Bug about cloned channels and errata

On 03/08/2012 04:04 PM, Tomas Lestach wrote: >> So, AFAICS the rhnServerNeededCache table is there for caching which errata >> need to be applied to a system together with the respective package ids. So >> I don't really see how it makes sense to insert rows in there with errata >> id == null. > >

[Spacewalk-devel] [PATCH] Generate API documentation as DocBook XML

ager_apidoc.pdf -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 00c004a31a7cc95a37d83f8ba5a79530a90b4fe6 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Fri, 9 Mar 2012 12:09:34 +0100 Subject: [PATCH 1/2] Add support for generating DocBoo

Re: [Spacewalk-devel] [PATCH] Bug about cloned channels and errata

aId(null); ... But it's called in 3-4 other places as well, so you (or somebody else who knows) should better have a look and verify this first, see the second patch. -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 22cab15a789c1d

Re: [Spacewalk-devel] [PATCH] Naming of cloned errata

On 03/06/2012 05:42 PM, Johannes Renner wrote: > Hey, > > I want to propose a change concerning the names of cloned errata. > Currently, names of cloned errata are generated like this: > > String clonedAdvisoryName = "CL" + published.getAdvisoryName().substring(3); &

[Spacewalk-devel] [PATCH] Naming of cloned errata

I am missing any reason to keep the old naming scheme. Attached please find my proposed patch for spacewalk master. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 30c638790f3f3d354c2381c6f9b2f23c90e20a50 Mon Sep 1

Re: [Spacewalk-devel] [PATCH] Bug about cloned channels and errata

On 03/05/2012 03:40 PM, Tomas Lestach wrote: > On Friday 02 of March 2012 18:11:41 Johannes Renner wrote: >> On 02/29/2012 05:38 PM, Cliff Perry wrote: >>> On 02/29/2012 11:05 AM, Johannes Renner wrote: >>>> Hello, >>>> >>>> I am investiga

Re: [Spacewalk-devel] [PATCH] Bug about cloned channels and errata

On 02/29/2012 05:38 PM, Cliff Perry wrote: > On 02/29/2012 11:05 AM, Johannes Renner wrote: >> Hello, >> >> I am investigating into a bug about cloned channels and errata. This is how >> to >> reproduce it on the UI: >> >> 1. Clone a channel that cont

Re: [Spacewalk-devel] [PATCH] Bug about cloned channels and errata

On 02/29/2012 05:38 PM, Cliff Perry wrote: > On 02/29/2012 11:05 AM, Johannes Renner wrote: >> Hello, >> >> I am investigating into a bug about cloned channels and errata. This is how >> to >> reproduce it on the UI: >> >> 1. Clone a channel that cont

  1   2   >