Re: [13] RFR JDK-8214253: Tooltip is transparent rather than having a black background

testcase. Applicable for all gtk3 bugs, I presume. Done. I will add this to other bugs too. [1] https://github.com/GNOME/gtk/blob/gtk-3-22/gtk/theme/Adwaita/gtk-contained.css -Pankaj *From:*Prasanta Sadhukhan *Sent:* Tuesday, March 5, 2019 9:04 AM *To:* Pankaj Bansal; swing-dev@openjdk.java.net

Re: [13] Review Request: 8177960 Deprecate the Swing Motif Look and Feel and document it as unsupported on macOS

Looks good to me. Regards Prasanta On 05-Mar-19 6:17 AM, Sergey Bylokhov wrote: Hello. Please review the fix for JDK 13. Bug: https://bugs.openjdk.java.net/browse/JDK-8177960 CSR: https://bugs.openjdk.java.net/browse/JDK-8218637 Fix: http://cr.openjdk.java.net/~serb/8177960/webrev.01 This is

Re: [13] RFR JDK-8214253: Tooltip is transparent rather than having a black background

Hi Pankaj, One question, dont we need to do 1782 fp_gtk_style_context_add_class(context, "background");after 2366 context = get_style(widget_type, "tooltip"); Also,please put noreg-demo in JBS since you are not providing any testcase. Applicable for all gtk3 bugs, I presume. Regards Prasanta

Re: [13] RFR: JDK-8218674 - HTML Tooltip with "img=src" on component doesn't show

the state even if width/height can be 0. I am not sure about possible repurcussions? I do not see any test with image of width/height=0 so thought that you probably do not check that path. Regards Prasanta Thanks, Krishna On 04-Mar-2019, at 5:12 PM, Prasanta Sadhukhan <mailto:prasanta.sad

Re: [13] RFR: JDK-8218674 - HTML Tooltip with "img=src" on component doesn't show

assigning to d.width/height, no? In that case, can we need to change the newstate without checking? Regards Prasanta Thanks, Krishna On 04-Mar-2019, at 1:29 PM, Prasanta Sadhukhan <mailto:prasanta.sadhuk...@oracle.com>> wrote: Hi Krishna, You can reuse existing method getLoad

Re: [13] RFR JDK-8214112: The whole text in target JPasswordField image are not selected.

ok. +1 Regards Prasanta On 04-Mar-19 1:50 PM, Pankaj Bansal wrote: Hi Prasanta, << Dont we have to take care of else part for if (gtk3_version_3_20)? Actually this change has been done in gtk 3.20. So all works well before that and nothing needs to be done. -Pankaj *From:*Pr

Re: [13] RFR JDK-8214112: The whole text in target JPasswordField image are not selected.

Hi Pankaj, Dont we have to take care of else part for if (gtk3_version_3_20)? Regards Prasanta On 26-Feb-19 4:03 PM, Pankaj Bansal wrote: Hi All, Please review the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8214112 webrev:

Re: [13] RFR: JDK-8218674 - HTML Tooltip with "img=src" on component doesn't show

Hi Krishna, You can reuse existing method getLoadsSynchronously() instead of checking for (state & SYNC_LOAD_FLAG) != 0) BTW, do we not have to check if (newWidth > 0) & newHeight >0 before changing the newstate @l797? The copyright year in testcase should be changed to 2019. Regards

[13] RFR JDK-8215396: JTabbedPane preferred size calculation is wrong for SCROLL_TAB_LAYOUT

Hi All, Please review a fix for an issue where it is seen that for SCROLL_TAB_LAYOUT the border of the content of JTabbedPane is not fully shown, whereas for WRAP_TAB_LAYOUT policy, the content is fully shown. It seems BasicTabbedPaneUI.TabbedPaneScrollLayout inner class (used for

Re: [13] RFR JDK-8214702:Wrong text position for whitespaced string in printing Swing text

from. Buttons & Label text are the typical cases where this showed up. There maybe other things to change, as well but the incorrect screenWidth is the main problem I see here. -phil. On 2/25/19 12:05 AM, Prasanta Sadhukhan wrote: On 21-Feb-19 4:50 AM, Sergey Bylokhov wrote: On 13/02/2019 22:53,

Re: [13] RFR JDK-8214702:Wrong text position for whitespaced string in printing Swing text

On 21-Feb-19 4:50 AM, Sergey Bylokhov wrote: On 13/02/2019 22:53, Prasanta Sadhukhan wrote: Hi Sergey, I believe drawChars() also has same printing issue [and should be changed like modified drawString()] but I am not able to test it as reproducer testcase uses JLabel whose constructor can

Re: [13] RFR JDK-8213781:web page background renders blue in JEditorPane

Hi Sergey, Any more comments on this? Regards Prasanta On 21-Feb-19 11:22 PM, Prasanta Sadhukhan wrote: Thanks Sergey for the pointer. I have modified the test not to use google.com. http://cr.openjdk.java.net/~psadhukhan/8213781/webrev.2/ Regards Prasanta On 21-Feb-19 10:53 PM, Sergey

Re: [13] RFR JDK-8213781:web page background renders blue in JEditorPane

; }     Title On 21/02/2019 09:14, Prasanta Sadhukhan wrote: On 21-Feb-19 10:39 PM, Sergey Bylokhov wrote: Why is is impossible to create such page by the test? I am not sure how to create such page with #fff as its bg-color setting. If you are aware, please give a pointer. Regards

Re: [13] RFR JDK-8213781:web page background renders blue in JEditorPane

Hi Sergey, On 21-Feb-19 10:31 PM, Sergey Bylokhov wrote: On 21/02/2019 08:46, Prasanta Sadhukhan wrote: But it can always be changed if somebody wants to run as a standalone test. There are many test in java/net, sun/security where they explicitly do setProperty(proxy) [for ex, java/net

Re: [13] RFR JDK-8213781:web page background renders blue in JEditorPane

On 21-Feb-19 10:39 PM, Sergey Bylokhov wrote: Why is is impossible to create such page by the test? I am not sure how to create such page with #fff as its bg-color setting. If you are aware, please give a pointer. Regards Prasanta On 21/02/2019 09:03, Prasanta Sadhukhan wrote: You should

Re: [13] RFR JDK-8213781:web page background renders blue in JEditorPane

as decided in the other review. Regards Prasanta On 21-Feb-19 10:33 PM, Prasanta Sadhukhan wrote: On 21-Feb-19 10:31 PM, Sergey Bylokhov wrote: On 21/02/2019 08:46, Prasanta Sadhukhan wrote: But it can always be changed if somebody wants to run as a standalone test. There are many test in java

Re: [13] RFR JDK-8213781:web page background renders blue in JEditorPane

On 21-Feb-19 10:31 PM, Sergey Bylokhov wrote: On 21/02/2019 08:46, Prasanta Sadhukhan wrote: But it can always be changed if somebody wants to run as a standalone test. There are many test in java/net, sun/security where they explicitly do setProperty(proxy) [for ex, java/net/ProxySelector

Re: [13] RFR JDK-8213781:web page background renders blue in JEditorPane

On 21-Feb-19 10:04 PM, Sergey Bylokhov wrote: On 21/02/2019 08:31, Prasanta Sadhukhan wrote: The test has some assumptions which is no necessary true:  - it might be executed outside of our internal network I know that but it was not working inside internal network, without proxy, which

Re: [13] RFR JDK-8213781:web page background renders blue in JEditorPane

, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that some webpage shows wrong background color when displayed in JEditorPane. It seems that some webpage can have #rgb [as in #fff] as CSS attributes which when parsed and passed to hexToColor() it is decoded

Re: [13] RFR JDK-8213781:web page background renders blue in JEditorPane

quot;an attempt will be made to fix it up"..so I guess it is correct. I will add the above line to my comment where I add the code, when I push. Any other objection? Regards Prasanta Thanks and regards, Shashi -Original Message- From: Prasanta Sadhukhan Sent: Thursday, Febru

Re: [13] RFR JDK-8213781:web page background renders blue in JEditorPane

with the short notation (#fff) and removes any dependencies on the color depth of the display. Regards Prasanta On 21-Feb-19 7:45 PM, Prasanta Sadhukhan wrote: Hi Shashi, As you can see, Color.decode() called from hexToColor() accepts an opaque 24 bit integer which is what returns the actual

Re: [13] RFR JDK-8213781:web page background renders blue in JEditorPane

ly default these days. I also think we should receive the expanded form at the hexToColor() rather than expanding at this function. We should simply apply the received color at this lower function level I think. Thanks and regards, Shashi -Original Message----- From: Prasanta Sadhukhan Sent: Thursday

[13] RFR JDK-8213781:web page background renders blue in JEditorPane

Hi All, Please review a fix for an issue where it is seen that some webpage shows wrong background color when displayed in JEditorPane. It seems that some webpage can have #rgb [as in #fff] as CSS attributes which when parsed and passed to hexToColor() it is decoded as 0x000fff resulting in

Re: [13] RFR JDK-8219156: RTFEditorKit writes background color but doesn't read

a foreground color(attrBackground, "green_foreground ") but it is unused. On 19/02/2019 03:23, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that JTextPane with RTFEditorKit writes background color for specific word into rtf file but doesn't r

[13] RFR JDK-8219156: RTFEditorKit writes background color but doesn't read

Hi All, Please review a fix for an issue where it is seen that JTextPane with RTFEditorKit writes background color for specific word into rtf file but doesn't read it. So, if yellow background color is set, it will read default white background. This is because

Re: [12] RFR JDK-8210807:Printing a JTable with a JScrollPane prints table without rows populated

Graphics);     } you could perhaps make it public and call that. Thanks for the pointer. I have made the suggested change and here's the modified webrev http://cr.openjdk.java.net/~psadhukhan/8210807/webrev.1/ Regards Prasanta -phil On 11/12/18 3:36 AM, Prasanta Sadhukhan wrote: Hi All, Please revi

Re: [13] RFR JDK-8214702:Wrong text position for whitespaced string in printing Swing text

Hi Sergey, I believe drawChars() also has same printing issue [and should be changed like modified drawString()] but I am not able to test it as reproducer testcase uses JLabel whose constructor can only accept "String" and not char[] so I can only test drawString(). Using drawChars()

[13] RFR JDK-8217464: Remove resolved client bugs from the ProblemList.txt

Hi All, Please review an updation of ProblemList to remove/update resolved client bugs from ProblemList Bug: https://bugs.openjdk.java.net/browse/JDK-8217464 webrev: http://cr.openjdk.java.net/~psadhukhan/8217464/webrev.0/ Few test are closed as duplicate of other bug so the ProblemList is

Re: [13] RFR JDK-8214702:Wrong text position for whitespaced string in printing Swing text

On 28-Jan-19 10:34 AM, Philip Race wrote: On 1/27/19, 8:37 PM, Prasanta Sadhukhan wrote: On 28-Jan-19 12:23 AM, Philip Race wrote: This seems to invalidate the preceding comment as well as contradict it's intent : /* The printed text must scale linearly with the UI. 519

Re: [13] RFR JDK-8214702:Wrong text position for whitespaced string in printing Swing text

an/8214702/print-output-beforefix.pdf Regards Prasanta -phil. On 1/25/19, 3:41 AM, Prasanta Sadhukhan wrote: Hi All, Please find an updated webrev using FontRenderContext compatible to printer device. With this, swing text with and without leading spaces are printed ok. http://cr.openjd

Re: [13] RFR JDK-8214702:Wrong text position for whitespaced string in printing Swing text

Hi All, Please find an updated webrev using FontRenderContext compatible to printer device. With this, swing text with and without leading spaces are printed ok. http://cr.openjdk.java.net/~psadhukhan/8214702/webrev.1/ Regards Prasanta On 25-Jan-19 11:01 AM, Prasanta Sadhukhan wrote

Re: [13] RFR JDK-8214702:Wrong text position for whitespaced string in printing Swing text

On 25-Jan-19 10:57 AM, Philip Race wrote: On 1/24/19, 8:19 PM, Prasanta Sadhukhan wrote: On 25-Jan-19 2:00 AM, Phil Race wrote: I can't work out what you are trying to say. The changes are only in the printing code path. However what it looks like to me is that Prasanta is now using

Re: [13] RFR JDK-8214702:Wrong text position for whitespaced string in printing Swing text

es in text is making text justifcation going astray? I have seen even without leading spaces in swing text in console , the text justification during printing is wrong as I am getting Regards Prasanta -phil. On 1/24/19 9:33 AM, Sergey Bylokhov wrote: Hi, Prasanta. On 24/01/2019 02:18, Prasanta

[13] RFR JDK-8214702:Wrong text position for whitespaced string in printing Swing text

Hi All, Please review a fix for an issue where it is seen that a string beginning with multiple whitespaces is displayed properly in Swing component. However, when printing, the start position of the line changes. Basically,in SwingUtilities#drawString(), during printing,  we calculate the

Re: [13] RFR [JDK-8217377] javax/swing/JPopupMenu/6583251/bug6583251.java failed with UnsupportedOperation exception

ok. +1 Regards Prasanta On 22-Jan-19 2:27 PM, Vikrant Agarwal wrote: Hi Prasanta, I ran the updated test on Windows, Ubuntu and Mac and the test ran fine. Best Regards, Vikrant -Original Message- From: Prasanta Sadhukhan Sent: Tuesday, January 22, 2019 1:55 PM To: Vikrant Agarwal Cc

Re: [13] RFR [JDK-8217377] javax/swing/JPopupMenu/6583251/bug6583251.java failed with UnsupportedOperation exception

Hi Vikrant, Which platforms you have run the test? Only in linux or in all win,linux and mac platforms? Iguess it will be better if you run the updated test in all 3, if not run already. Regards Prasanta On 21-Jan-19 12:53 PM, Vikrant Agarwal wrote: Hi Sergey, I have updated the test.

Re: [13] RFR JDK-8214765: All TrayIcon MessageType icons does not show up with gtk3 option set

looks ok to me. Regards Prasanta On 17-Jan-19 11:59 PM, Pankaj Bansal wrote: Hi All, Please review the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8214765 webrev: http://cr.openjdk.java.net/~pbansal/8214765/webrev.00/

Re: [13] RFR JDK-8214111: There is no icon in all JOptionPane target image

Hi Pankaj, looks ok to me. Although there is this statement for gtk_check_version() "However, such a check isn’t completely reliable, since the module may be linked against an old version of GTK+ and calling the old version of |gtk_check_version()|

Re: [13] RFR JDK-8214252: Expanded & Collapsed nodes of a JTree look the same on GTK3

Looks good to me. Regards Prasanta On 09-Jan-19 3:39 PM, Pankaj Bansal wrote: Hi All, Please review the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8214252 webrev: http://cr.openjdk.java.net/~pbansal/8214252/webrev.00/ Issue: The icon for collapsed and expanded node in

[13] RFR JDK-8215909: Typo in Swing ProcessMouseEvent method documentation

Hi All, Please review a doc fix to fix space missing after {@code} tag. diff -r 9eee0b148002 src/java.desktop/share/classes/javax/swing/MenuElement.java --- a/src/java.desktop/share/classes/javax/swing/MenuElement.java Thu Dec 20 12:44:41 2018 + +++

[12] RFR JDK-8214943:PIT: javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java errors out in mac

Hi All, It is found that this test is not able to find ExtendedRobot directory which has been moved to lib/client as per this bugfix JDK-8186549 :move ExtendedRobot closer to tests and errors out citing "Error. can't find ExtendedRobot in

Re: [12] RFR JDK-8213049:Invalid HTML5 in javax.swing files

docs. *componentProperties.html* I propose adding empty paragraph between two tables: to visually separate them in these cases: 167 168 169 170 JComboBox Specific Properties 794 795 796 797 JScrollBar Specific Properties Regards, Alexey On 03/12/2018 16:53, Prasanta Sadhukhan wrote

Re: [12] RFR JDK-8213049:Invalid HTML5 in javax.swing files

/tabular-data.html#the-caption-element [3] https://bugs.openjdk.java.net/browse/JDK-8213049 On 03/12/2018 05:25, Prasanta Sadhukhan wrote: Hi Sergey, OK. Replaced summary by caption http://cr.openjdk.java.net/~psadhukhan/8213049/webrev.1/ Regards Prasanta On 01-Dec-18 3:56 AM, Sergey Bylokhov wrote

[12] RFR JDK-8213049:Invalid HTML5 in javax.swing files

Hi All, Please review a doc-fix to comply with HTML5 standard,mainly removing the obsolete "summary" attributes. Bug: https://bugs.openjdk.java.net/browse/JDK-8213049 webrev: http://cr.openjdk.java.net/~psadhukhan/8213049/webrev.0/ Regards Prasanta

Re: [12] Review Request: 8198339 Test javax/swing/border/Test6981576.java is unstable

Hi Sergey, fix looks ok but I guess you would want to remove this test from ProblemList too. Regards Prasanta On 13-Nov-18 7:33 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8198339 Webrev:

Re: [12] Review Request: 8198398 Test javax/swing/JColorChooser/Test6199676.java fails in mach5

Hi Sergey, I see that only the 1st 2 L UIManager.getInstalledLookAndFeels()[0] and UIManager.getInstalledLookAndFeels()[1] are being tested? Why is it so? Shouldn;t we iterate over all L to see if preview panel works when L changes from one to other and not just from 1st to 2nd L? Regards

[12] JDK-8214470: PIT: javax/swing/JPopupMenu/7154841/bug7154841.java errors out on mac10.13

Hi All, It is found that this test is not able to find ExtendedRobot directory which has been moved to lib/client as per this bugfix JDK-8186549 :move ExtendedRobot closer to tests Bug: https://bugs.openjdk.java.net/browse/JDK-8214470 diff

Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after JDK-8153732

Hi Shashi, I think l437 check of if-else if (prevRemotePrinters != null) {is not required. prevRemotePrinters null check is addressed in str1==null case in doCompare(). If prevRemotePrinters is null and currentRemotePrinters is not null, then you update prevRemotePrinters to

Re: [12] RFR JDK-8213843: Changing L from Nimbus to Window L causes NPE in SwingSet2

On 22-Nov-18 11:03 AM, Prasanta Sadhukhan wrote: HI Sergey, I am not sure why which requires some investigation. I see none of the Synth*UI class has caching, maybe it was done intentionally. Since it is quite close to RDP1 and there are other issues need to be fixed, I would like

Re: [12] RFR JDK-8213843: Changing L from Nimbus to Window L causes NPE in SwingSet2

would be opened). Meanwhile, I would like this fix to go in as it breaks SwingSet2 demo. Regards Prasanta On 22-Nov-18 1:47 AM, Sergey Bylokhov wrote: Hi, Prasanta On 21/11/2018 02:27, Prasanta Sadhukhan wrote: where caching of SynthButtonUI is done. It seems caching of button ui object causes

[12] RFR JDK-8213843: Changing L from Nimbus to Window L causes NPE in SwingSet2

Hi All, Please review a fix for an issue seen where when we switch look and feel from Nimbus to Windows or any other l, it causes a NPE in SwingSet2 demo. NPE is caused by SynthButtonUI.getMinimumSize() calling SynthContext.getStyle().getGraphicsUtils()...when getStyle() return null. This is

Re: [12]RFR JDK-8212882: links to tutorial should be updated to use https:

Looks good to me. Regards Prasanta On 19-Nov-18 12:26 PM, Krishna Addepalli wrote: Hi All, Can I have the new webrev reviewed? As per suggestions, I have removed all the files not in client area. Thanks, Krishna *From:*Krishna Addepalli *Sent:* Thursday, October 25, 2018 11:54 AM *To:*

Re: Swing Dev> [12] RFR JDK-8213514: com/sun/java/swing/plaf/windows/Test8173145.java fails on mach5

vironment. Regards Prasanta Note that HeadlessGraphicsEnvironment does not implement DisplayChangedListener so the additional check for HeadlessGraphicsEnvironment is not necessary. On 13/11/2018 02:32, Prasanta Sadhukhan wrote: Modified webrev to prevent ClassCastException which can happen in headle

Swing Dev> [12] RFR JDK-8213514: com/sun/java/swing/plaf/windows/Test8173145.java fails on mach5

Sadhukhan wrote: On 09-Nov-18 2:22 AM, Sergey Bylokhov wrote: On 08/11/2018 01:11, Prasanta Sadhukhan wrote: Hi Sergey, I am not getting ClassCastException when I run com/sun/java/swing/plaf/windows/Test8173145 on mach5, rather I get the below mentioned exception. I guess the below problem

Re: [12] RFR JDK-8211703: JInternalFrame : java.lang.AssertionError: cannot find the internal frame

aps one call to "getParent()" is superfluous? What is the hierarchy of panes/buttons/internal frames? On 12/11/2018 03:21, Prasanta Sadhukhan wrote: Thanks Muneer for the confirmation. Gentle reminder to review which is pending for over a month now. http://cr.openjdk.java.net/~psadhukhan/8211

[12] RFR JDK-8210807:Printing a JTable with a JScrollPane prints table without rows populated

Hi All, Please review a fix for an issue where it is seen that a simple JTable doesn't print correctly if the table is contained in a JScrollPane. This is a regression of the fixJDK-8164032: JViewport backing store image is not scaled on HiDPI

Re: [12] RFR JDK-8211703: JInternalFrame : java.lang.AssertionError: cannot find the internal frame

with this fix. Thanks for fixing this issue. Regards, Muneer -Original Message- From: Muneer Kolarkunnu Sent: Wednesday, October 24, 2018 12:00 PM To: Prasanta Sadhukhan ; Sergey Bylokhov ; swing-dev@openjdk.java.net Subject: Re: [12] RFR JDK-8211703: JInternalFrame

[12] RFR JDK-8196097: javax/swing/JPopupMenu/6675802/bug6675802.java fails

Hi All, Please review a test fix for jdk12 Bug: https://bugs.openjdk.java.net/browse/JDK-8196097 webrev: http://cr.openjdk.java.net/~psadhukhan/8196097/webrev/ The test sometimes fails due to paint operation not being executed properly when run in group as the test always passes if run in

[12] RFR JDK-8198340: Test javax/swing/plaf/basic/Test6984643.java is unstable

Hi All, Please review this test fix for jdk12. Bug: https://bugs.openjdk.java.net/browse/JDK-8198340 webrev: http://cr.openjdk.java.net/~psadhukhan/8198340/webrev.0/ The test fails citing java.lang.ExceptionInInitializerError at

Re: [12] Review Request: 8198321 javax/swing/JEditorPane/5076514/bug5076514.java fails

looks ok. Regards Prasanta On 09-Nov-18 2:34 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8198321 Webrev: http://cr.openjdk.java.net/~serb/8198321/webrev.00 This test verifies that "JEditorPane.copy()" method will trigger

Re: [12] Review Request: 8199072 Test javax/swing/GroupLayout/6613904/bug6613904.java is unstable

looks ok. Please add the bugid to the test. Regards Prasanta On 09-Nov-18 5:28 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8199072 Webrev: http://cr.openjdk.java.net/~serb/8199072/webrev.00 Bug was found when our tests

Re: [12] RFR JDK-8198334: java/awt/FileDialog/8003399/bug8003399.java fails in headless mode

On 09-Nov-18 2:22 AM, Sergey Bylokhov wrote: On 08/11/2018 01:11, Prasanta Sadhukhan wrote: Hi Sergey, I am not getting ClassCastException when I run com/sun/java/swing/plaf/windows/Test8173145 on mach5, rather I get the below mentioned exception. I guess the below problem is expected

Re: [12] RFR JDK-8198334: java/awt/FileDialog/8003399/bug8003399.java fails in headless mode

a.net/browse/JDK-8198334?focusedCommentId=14157839=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14157839 On 07/11/2018 01:29, Prasanta Sadhukhan wrote: Hi Sergey, Actually, I was more concerned about the swing test failure com/sun/java/swing/plaf/windows/T

Re: [12] RFR JDK-8213181:Updation of ProblemList.txt for removal of passing swing test

On 08-Nov-18 11:59 AM, Prasanta Sadhukhan wrote: On 08-Nov-18 11:52 AM, Sergey Bylokhov wrote: On 07/11/2018 21:44, Prasanta Sadhukhan wrote: I found that these tests are passing when ran for 100 iterations on windows javax/swing/plaf/basic/Test6984643.java It is necessary to check

Re: [12] RFR JDK-8213181:Updation of ProblemList.txt for removal of passing swing test

On 08-Nov-18 11:52 AM, Sergey Bylokhov wrote: On 07/11/2018 21:44, Prasanta Sadhukhan wrote: I found that these tests are passing when ran for 100 iterations on windows javax/swing/plaf/basic/Test6984643.java It is necessary to check the code of the tests as well, for example the test

Re: [12] RFR JDK-8213181:Updation of ProblemList.txt for removal of passing swing test

Since some of the tests are marked generic-all and it's difficult to run 100 iterations on all platforms, I concentrated on the tests that are marked failing on one platform. I found that these tests are passing when ran for 100 iterations on windows

Re: [12] RFR JDK-8198334: java/awt/FileDialog/8003399/bug8003399.java fails in headless mode

are not HeadlessException but ClassCastException which is think is a product bug. On 05/11/2018 02:16, Prasanta Sadhukhan wrote: > Hi All, > > Please review a fix for an issue where some tests are found to be failing > with HeadlessException in mach5 systems. > Proposed fix is to mark those t

[12] RFR JDK-8198334: java/awt/FileDialog/8003399/bug8003399.java fails in headless mode

Hi All, Please review a fix for an issue where some tests are found to be failing with HeadlessException in mach5 systems. Proposed fix is to mark those tests as headful. Bug: https://bugs.openjdk.java.net/browse/JDK-8198334 webrev: http://cr.openjdk.java.net/~psadhukhan/8198334/webrev.0/

Re: [12] RFR JDK-8213181:Updation of ProblemList.txt for removal of passing swing test

On 04-Nov-18 12:06 AM, Philip Race wrote: On 11/2/18, 9:12 PM, Prasanta Sadhukhan wrote: Ok. I can retain the 1st test javax/swing/border/Test6981576.java 8198339 generic-all So shouldn't this test just be marked @headful ? I can mark it headful if Sergey is ok with it. Can I remove

Re: [12] RFR JDK-8213116:javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java fails in Windows

tests pass ? It probably isn't too many .. FYI...I have run all JCombobox swing tests which has passed. Regards Prasanta -phil. On 11/1/18, 11:02 PM, Prasanta Sadhukhan wrote: Hi Sergey, On 01-Nov-18 12:25 AM, Sergey Bylokhov wrote: Hi, Prasanta. On 31/10/2018 11:40, Prasanta Sadhukhan wrote

Re: [12] RFR JDK-8213181:Updation of ProblemList.txt for removal of passing swing test

generic-all* It creates a frame which may produce HeadlessException, but sometimes the test completes successfully because it uses invokeLater() which is not necessary completes before the end of the main(). On 02/11/2018 02:30, Prasanta Sadhukhan wrote: Hi Sergey, Checked on mach5 and these tests

[12] RFR 8213261: test javax/swing/plaf/nimbus/AllSwingComponentsBaselineTest.java fails

Hi All, Please review a test fix which is seen to be failing in mach5 systems with NPE when frame is disposed. Added null check before dispose to prevent NPE, but then mach5 systems fail with HeadlessException so added key headful to the test. diff --git

Re: [12] RFR JDK-8213181:Updation of ProblemList.txt for removal of passing swing test

in headless and mach5? On 31/10/2018 02:52, Prasanta Sadhukhan wrote: Hi All, Please review an updation of ProblemList for removal of tests which are now passing. These 5 tests are being removed from ProblemList as they were tested on windows7,10, ubuntu 16.04,18.04, mac 10.12/10.13 and oel7.5

Re: [12] RFR JDK-8213116:javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java fails in Windows

Hi Sergey, On 01-Nov-18 12:25 AM, Sergey Bylokhov wrote: Hi, Prasanta. On 31/10/2018 11:40, Prasanta Sadhukhan wrote: This is a regression ofJDK-8203281: <https://bugs.openjdk.java.net/browse/JDK-8203281>[Windows] JComboBox change in ui when editor.setBorder() is called where combobox

Re: [12] RFR JDK-8213181:Updation of ProblemList.txt for removal of passing swing test

that? Just give a remote-build-and-test mach5 job with this tests removed from ProblemList.txt? I believe we need to run some tier3 tests for this, right? how to do that? Regards Prasanta On 31/10/2018 02:52, Prasanta Sadhukhan wrote: Hi All, Please review an updation of ProblemList for removal

[12] RFR JDK-8213116:javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java fails in Windows

Hi All, Please review a fix for an issue where it is seen that this test javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java fails because combobox height is more than textfield height on which the combobox is placed. This is a regression ofJDK-8203281:

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

On 31-Oct-18 9:06 PM, Sergey Bylokhov wrote: On 31/10/2018 03:19, Prasanta Sadhukhan wrote: I tested on windows 10 and mac10.13 and the test passed. Not sure why it will fail on mach5 system. It complains about NPE which can be checked and prevented but am not seeing it locally so should I

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

. Looks like this test started to fail on our mach5 systems, please take a look. On 22/10/2018 11:39, Sergey Bylokhov wrote: Hi, Prasanta. Thank you for investigation, the fix looks fine. On 21/10/2018 22:52, Prasanta Sadhukhan wrote: Hi Sergey, I saw that in *ButtonUI class for all lookandfeels

[12] RFR JDK-8213181:Updation of ProblemList.txt for removal of passing swing test

Hi All, Please review an updation of ProblemList for removal of tests which are now passing. These 5 tests are being removed from ProblemList as they were tested on windows7,10, ubuntu 16.04,18.04, mac 10.12/10.13 and oel7.5 and found to be passing. diff -r edc729e2ee36

Re: [12] Review Request: JDK-8212903 : [TestBug] Tests test/jdk/javax/swing/LookAndFeel/8145547/DemandGTK2.sh and DemandGTK3.sh fail on Ubuntu 18.04 LTS

looks good to me. Regards Prasanta On 30-Oct-18 4:30 PM, Pankaj Bansal wrote: Hi All, Please review test fix for the below bug: Bug: https://bugs.openjdk.java.net/browse/JDK-8212903 webrev: http://cr.openjdk.java.net/~pbansal/8212903/webrev.00/

Re: [12] RFR JDK-8213138: Update ProblemList.txt for mac

On 31-Oct-18 4:27 AM, Sergey Bylokhov wrote: Hi, Prasanta. On 30/10/2018 02:58, Prasanta Sadhukhan wrote: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java: JDK-8213126 <https://bugs.openjdk.java.net/browse/JDK-8213126> The failure of the TestMainKeyWindow.java is not a bug, you

[12] RFR JDK-8213138: Update ProblemList.txt for mac

Hi All, Please review an updation of ProblemList for mac jtreg run. Following tests were added in ProblemList. With this addition, mac10.13 jtreg run shows no failures/errors. java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java: JDK-8213126

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213130: Update ProblemList after verification of jtreg tests in Win 7

looks ok. Regards Prasanta On 30-Oct-18 2:13 PM, Jayathirth D V wrote: Hello All, Please review the following fix in JDK 12: Bug : https://bugs.openjdk.java.net/browse/JDK-8213130 Webrev : http://cr.openjdk.java.net/~jdv/8213130/webrev.00/

Re: [12]RFR JDK-8212882: links to tutorial should be updated to use https:

looks good to me but src/java.sql.rowset and src/java.sql/ changes should be sent to some other list or prepare the webrev without those changes, as I guess we do not have committer rights for those modules. Regards Prasanta On 24-Oct-18 11:51 AM, Krishna Addepalli wrote: Hi All, Please

Re: [12] RFR JDK-8211703: JInternalFrame : java.lang.AssertionError: cannot find the internal frame

Hi Muneer, Could you check (as a submitter) if the proposed fix works in your jemmy environment? It seems to work for me with the command line you gave in JBS. Regards Prasanta On 22-Oct-18 11:24 AM, Prasanta Sadhukhan wrote: Gentle reminder... Regards Prasanta On 05-Oct-18 2:31 PM

[12] RFR JDK-8212735:Compilation issue with javax.swing.InputVerifier example in javadoc section

Hi All, In https://download.java.net/java/early_access/jdk12/docs/api/java.desktop/javax/swing/InputVerifier.htmljavadoc, the example given does not compile as the "field" variable is not declared. Following fix ensures proper variable is used. Checked the example works after this. ---

Re: [12] RFR JDK-8211703: JInternalFrame : java.lang.AssertionError: cannot find the internal frame

Gentle reminder... Regards Prasanta On 05-Oct-18 2:31 PM, Prasanta Sadhukhan wrote: Hi Sergey, On 04-Oct-18 11:03 PM, Prasanta Sadhukhan wrote: On 04-Oct-18 10:44 PM, Prasanta Sadhukhan wrote: On 04-Oct-18 10:29 PM, Sergey Bylokhov wrote: On 04/10/2018 09:44, Prasanta Sadhukhan wrote

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

:20, Prasanta Sadhukhan wrote: Yes. So, it seems getBaseline() gets null style because of this reason: When JButton is created, it calls JButton.updateUI() which calls UIManager.updateUI() which calls UIDefaults.getUI and it calls SynthButtonUI.createUI() which created a new SynthButtonUI

[12] RFR JDK-8212098:Cleanup of ProblemList.txt for fixed swing tests

Hi All, Please review a cleanup of ProblemList for fixed swing tests. 1st one 8196434 is fixed by JDK-8207941 2nd one 8202656 is fixed by JDK-8208638 diff -r d96a607e9594

Re: [12] Review Request: 8210739 Calling JSpinner's setFont with null throws NullPointerException

Looks good to me. Regards Prasanta On 02-Oct-18 4:15 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 12. This change updates the implementation of JDK-6421058, JDK-5036022 and JDK-8205144. The goal of those changes were to use the font of the JSpinner in textComponent(which

[12] RFR JDK-8211987: Menu bar gets input focus even if Alt-released event is consumed

Hi All, Please review a fix for an issue where it is seen that typing(pressing+releaseing) ALT key in a JTextArea transfer focus to and activates JMenu (rather than focus staying in textarea) if both JTextArea and JMenu are present in a JFrame, even if there is a KeyListener on the text

[12] RFR JDK-8211886: Bad/broken link in synthFileFormat.html

Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-8211886 Please review a doc fix to fix broken link where a is found before java.lang.Class api/java.desktop/javax/swing/plaf/synth/SynthLookAndFeel.html#load(java.io.InputStream, java.lang.Class) Fix is to remove the space diff -r

Re: [12] RFR JDK-6828982: UIDefaults.getUI swallows original exception

Can I get a 2nd (R)eviewer for this? Regards Prasanta On 29-Sep-18 3:55 PM, Krishna Addepalli wrote: Looks fine. Krishna On 29-Sep-2018, at 10:28 AM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that UIDefaults.getUI() swallows the original

Re: [12] RFR JDK-8211703: JInternalFrame : java.lang.AssertionError: cannot find the internal frame

Hi Sergey, On 04-Oct-18 11:03 PM, Prasanta Sadhukhan wrote: On 04-Oct-18 10:44 PM, Prasanta Sadhukhan wrote: On 04-Oct-18 10:29 PM, Sergey Bylokhov wrote: On 04/10/2018 09:44, Prasanta Sadhukhan wrote: Hi Sergey, Yes, this method should return JInternalFrame but there is no way to get

Re: [12] RFR JDK-8211703: JInternalFrame : java.lang.AssertionError: cannot find the internal frame

On 04-Oct-18 10:44 PM, Prasanta Sadhukhan wrote: On 04-Oct-18 10:29 PM, Sergey Bylokhov wrote: On 04/10/2018 09:44, Prasanta Sadhukhan wrote: Hi Sergey, Yes, this method should return JInternalFrame but there is no way to get JinternalFrame object from BasicInternalFrameTitlePane

Re: [12] RFR JDK-8211703: JInternalFrame : java.lang.AssertionError: cannot find the internal frame

On 04-Oct-18 10:29 PM, Sergey Bylokhov wrote: On 04/10/2018 09:44, Prasanta Sadhukhan wrote: Hi Sergey, Yes, this method should return JInternalFrame but there is no way to get JinternalFrame object from BasicInternalFrameTitlePane currently. But why it is not possible

Re: [12] RFR JDK-8211703: JInternalFrame : java.lang.AssertionError: cannot find the internal frame

.getParent();     } So maybe we can improve it to fetch the JInternalFrame from the BasicInternalFrameTitlePane or from another class passed to this method? On 04/10/2018 07:35, Prasanta Sadhukhan wrote: Hi All, Please review a cleanup of the code where wrong assertion is used when Component is a

[12] RFR JDK-8211703: JInternalFrame : java.lang.AssertionError: cannot find the internal frame

Hi All, Please review a cleanup of the code where wrong assertion is used when Component is an instance of BasicInternalFrameTitlePane. Now, BasicInternalFrameTitlePane is extended from JComponent and not from JInternalFrame so it will never satisfy the if-else condition if "Component is

Re: [12] RFR JDK-8203281:[Windows] JComboBox change in ui when editor.setBorder() is called

.js is ok for you, because that`s all I can do. A year ago my sponsor uploaded webrev for me, cause I have no rights to do it. best regards, Martin po 1. 10. 2018 o 12:10 Prasanta Sadhukhan mailto:prasanta.sadhuk...@oracle.com>> napísal(a): BTW, I saw that you have

Re: [12] RFR JDK-8203281:[Windows] JComboBox change in ui when editor.setBorder() is called

BTW, I saw that you have 379 , arrowButton.getPrefrredSize().widthwhich will cause build failure. Did you actually build this code and test? Regards Prasanta On 01-Oct-18 11:24 AM, Prasanta Sadhukhan wrote: Thanks Martin. Can you please send the webrev in proper format like you did

<    4   5   6   7   8   9   10   11   12   13   >