[12] Review Request: 8213110 Remove the use of applets in automatic tests

Hello. Please review the fix for jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8213110 Webrev: http://cr.openjdk.java.net/~serb/8213110/webrev.03 Description of the bug: A number of our tests in jdk still launch by applets via "@run applet". Usually we drop this usage when we update

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

n says to use the tab key to do this operation. Only with this fix, I was able to select the progress bar control and otherwise not and that is true as per the focus traversal policy used for this control type. Thanks and regards, Shashi On 03/11/18 3:00 AM, Sergey Bylokhov wrote: I am no

Re: [12] RFR JDK-8198334: java/awt/FileDialog/8003399/bug8003399.java fails in headless mode

Hi, Prasanta. In the log of Test8173145 the ClassCastException exists as well: https://bugs.openjdk.java.net/browse/JDK-8198334?focusedCommentId=14157839=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14157839 On 07/11/2018 01:29, Prasanta Sadhukhan wrote: Hi

Re: [12] RFR JDK-8198334: java/awt/FileDialog/8003399/bug8003399.java fails in headless mode

Hi, Prasanta. An exception which was occurred in these tests are not HeadlessException but ClassCastException which is think is a product bug. On 05/11/2018 02:16, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where some tests are found to be failing with

Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

, shashidhara.veerabhadra...@oracle.com wrote: Hi All, Here is the new webrev with fixes for the comments: http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.03/ Thanks and regards, Shashi On 31/10/18 11:19 PM, Sergey Bylokhov wrote: Also robot.setAutoDelay() can be used instead of a lis

Re: [12] RFR JDK-8213181:Updation of ProblemList.txt for removal of passing swing test

> > So shouldn't this test just be marked @headful ? > I can mark it headful if Sergey is ok with it. This will skip the test in our nightly, but actually does not solve the existed bug in the test. > fails last time due to some update dialog or antivirus popup) >

Re: [12] JDK-8198624: java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html fails on mac

Hi, Shashi. A few notes: 1. All Swing components are still created on non-EDT thread. 2. Why did you change this line: this.setLayout (new BorderLayout ()); to this: frame.setLayout (new BorderLayout ()); The first line was related to the applet, and actually it was

Re: [12] RFR [JDK-8213168] Enable different look and feel tests in SwingSet3 demo test FileChooserDemoTest

Looks fine. On 04/11/2018 21:24, Muneer Kolarkunnu wrote: Gentle Reminder. Regards, Muneer *From:* Muneer Kolarkunnu *Sent:* Wednesday, October 31, 2018 10:40 AM *To:* swing-dev@openjdk.java.net *Cc:* Aleksandre Iline *Subject:* [12] RFR [JDK-8213168] Enable different look and feel tests

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

s. Thanks and regards, Shashi -Original Message----- From: Sergey Bylokhov Sent: Thursday, October 25, 2018 3:11 AM To: Shashidhara Veerabhadraiah ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the pr

Re: [12] RFR JDK-8213181:Updation of ProblemList.txt for removal of passing swing test

completes successfully because it uses invokeLater() which is not necessary completes before the end of the main(). On 02/11/2018 02:30, Prasanta Sadhukhan wrote: Hi Sergey, Checked on mach5 and these tests passed. Regards Prasanta On 31-Oct-18 11:38 PM, Sergey Bylokhov wrote: Hi, Prasanta

Re: [12] RFR 8213261: test javax/swing/plaf/nimbus/AllSwingComponentsBaselineTest.java fails

Looks fine. On 02/11/2018 04:23, Prasanta Sadhukhan wrote: Hi All, Please review a test fix which is seen to be failing in mach5 systems with NPE when frame is disposed. Added null check before dispose to prevent NPE, but then mach5 systems fail with HeadlessException so added key headful

Re: [12] RFR JDK-8213138: Update ProblemList.txt for mac

r RE, so you can use pre-build test-image if you wish. Regards Prasanta On 31-Oct-18 4:27 AM, Sergey Bylokhov wrote: Hi, Prasanta. On 30/10/2018 02:58, Prasanta Sadhukhan wrote: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java: JDK-8213126 <https://bugs.openjdk.java.net/browse/JDK

Re: [12] RFR JDK-8213116:javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java fails in Windows

Hi, Prasanta. On 31/10/2018 11:40, Prasanta Sadhukhan wrote: This is a regression ofJDK-8203281: [Windows] JComboBox change in ui when editor.setBorder() is called where combobox arrow button height is reduced by 2 It is reduced if the

Re: [12]RFR: JDK-8198003: javax/swing/JFileChooser/6396844/TwentyThousandTest.java throws error

Hi, Krishna. The current timeout for this test is 1000 seconds, which is 16 minutes. I guess such timeout should be enough for everything which is done in this test. BTW there is no Disposer thread in the stack, it is also strange that most of the threads in the stack thread are blocked. See

Re: [12] RFR JDK-8213181:Updation of ProblemList.txt for removal of passing swing test

Hi, Prasanta. Some of them were added to the problem list as part of the tests cleanup for the headless mode, which is used in mach5. Did you check that these tests works fine in headless and mach5? On 31/10/2018 02:52, Prasanta Sadhukhan wrote: Hi All, Please review an updation of

Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

Also robot.setAutoDelay() can be used instead of a list of .delay() +I suggest to add robot.waitForIdle after the createAndShowGUI, because it can be slow operation on the slow systems. On 31/10/2018 04:59, Krishna Addepalli wrote: Hi Shashi, 1. Please add "@key headful" to the test. 2. I

Re: [12] JDK-7124293: [macosx] VoiceOver reads percentages rather than the actual values for sliders.

Looks fine. Hi Sergey, Yeah I saw that problem. It happens even before this fix. please file a separate CR for this. -- Best regards, Sergey.

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

? Regards Prasanta On 31-Oct-18 3:04 AM, Sergey Bylokhov wrote: Hi, Prasanta. Looks like this test started to fail on our mach5 systems, please take a look. On 22/10/2018 11:39, Sergey Bylokhov wrote: Hi, Prasanta. Thank you for investigation, the fix looks fine. On 21/10/2018 22:52, Prasanta

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

in the headless mode which is used in mach5? note that this is not necessary a test issue. Regards Prasanta On 31-Oct-18 3:04 AM, Sergey Bylokhov wrote: Hi, Prasanta. Looks like this test started to fail on our mach5 systems, please take a look. On 22/10/2018 11:39, Sergey Bylokhov wrote: Hi

Re: [12] JDK-7124293: [macosx] VoiceOver reads percentages rather than the actual values for sliders.

Hi, Shashi. I am not sure is the next issue is related to this fix, but when I tried to move the slider by mouse then VO reads the value of the slider only once(for the first time). On 28/10/2018 23:51, shashidhara.veerabhadra...@oracle.com wrote: Hi All, Please review a fix for the vpat

Re: [12] RFR JDK-8213138: Update ProblemList.txt for mac

Hi, Prasanta. On 30/10/2018 02:58, Prasanta Sadhukhan wrote: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java: JDK-8213126 The failure of the TestMainKeyWindow.java is not a bug, you need to provide -nativepath to the jtreg, because

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

Hi, Prasanta. Looks like this test started to fail on our mach5 systems, please take a look. On 22/10/2018 11:39, Sergey Bylokhov wrote: Hi, Prasanta. Thank you for investigation, the fix looks fine. On 21/10/2018 22:52, Prasanta Sadhukhan wrote: Hi Sergey, I saw that in *ButtonUI class

Re: [12]RFR JDK-8212882: links to tutorial should be updated to use https:

Hi, Krishna I think you need to include more groups to this review: hotspot-dev, core-libs-dev and security-dev. On 23/10/2018 23:21, Krishna Addepalli wrote: Hi All, Please review a trivial fix of updating the links to https. Bug: https://bugs.openjdk.java.net/browse/JDK-8212882 Webrev:

Re: [12] RFR [JDK-8212897] Some improvements in the EditorPaneDemotest

Looks fine. On 23/10/2018 23:14, Muneer Kolarkunnu wrote: Hi All, Please review fix for the task: Task: https://bugs.openjdk.java.net/browse/JDK-8212897 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8212897/webrev.00/ Description: 1) In Nimbus L, background color is not white, but in the

Re: [12] RFR JDK-8212735:Compilation issue with javax.swing.InputVerifier example in javadoc section

Looks fine. On 23/10/2018 07:45, Prasanta Sadhukhan wrote: Hi All, In https://download.java.net/java/early_access/jdk12/docs/api/java.desktop/javax/swing/InputVerifier.htmljavadoc, the example given does not compile as the "field" variable is not declared. Following fix ensures proper

Re: [TEST] [12] RFR [JDK-8211443] Enable different look and feels in SwingSet3 demo test SplitPaneDemoTest

Looks fine. On 23/10/2018 03:07, Gauri Patil wrote: Hi All, Please review fix for the below task: Bug: https://bugs.openjdk.java.net/browse/JDK-8211443 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8211443/webrev.00/ Description: Enabled different look and feels in SwingSet3 demo test

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

Hi, Shashi. Can you please provide more information about relation of focusable state and a VoiceOver? The simple JLabel is not focusable, but VoiceOver reads its contents, and it is possible to select the label using VoiceOver's shortcuts. On 22/10/2018 00:36,

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

as this fix so I guess we should do the same for SynthButtonUI too as has been done in webrev.2 below. Regards Prasanta On 15-Sep-18 5:39 AM, Sergey Bylokhov wrote: Hi, Prasanta. I have checked some other UI delegates(in Synth and others L), and found that sometimes result of createUI is cached

Re: [TEST] [12] RFR [JDK-8210057] Enable different look and feels in SwingSet3 demo test InternalFrameDemoTest

Looks fine. On 18/10/2018 00:07, Gauri Patil wrote: Hi, Gentle Reminder. Thanks and Regards Gauri Patil *From:* Gauri Patil *Sent:* Tuesday, October 09, 2018 2:47 PM *To:* swing-dev@openjdk.java.net *Cc:* Aleksandre Iline *Subject:* RE: [TEST] [12] RFR [JDK-8210057] Enable different look

Re: [12] RFR JDK-8211987: Menu bar gets input focus even if Alt-released event is consumed

Looks fine. On 10/10/2018 23:31, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that typing(pressing+releaseing) ALT key in a JTextArea transfer focus to and activates JMenu (rather than focus staying in textarea) if both JTextArea and JMenu are present

Re: [12] RFR JDK-8212098:Cleanup of ProblemList.txt for fixed swing tests

Looks fine. On 11/10/2018 22:17, Prasanta Sadhukhan wrote: Hi All, Please review a cleanup of ProblemList for fixed swing tests. 1st one 8196434 is fixed by JDK-8207941 2nd one 8202656 is fixed by JDK-8208638

Re: [12] Review Request: 8133713 [macosx] Accessible JTables always reported as empty

ared as a table. So the current code will not be dropped. What does it take to fix it properly ? I'll start to working on it after complete some other related things, like jtree which is also complete not implemented. -phil. On 10/3/18, 5:56 PM, Sergey Bylokhov wrote: On 02/10/2018 1

Re: [12] RFR JDK-8211886: Bad/broken link in synthFileFormat.html

Looks fine. On 08/10/2018 23:20, Prasanta Sadhukhan wrote: Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-8211886 Please review a doc fix to fix broken link where a is found before java.lang.Class api/java.desktop/javax/swing/plaf/synth/SynthLookAndFeel.html#load(java.io.InputStream,

Re: [12] JDK-8061359: [macosx] Checkbox toggles on Space press but does not spoken by Voice Over

Looks fine. On 01/10/2018 21:54, shashidhara.veerabhadra...@oracle.com wrote: Hi Sergey, Thanks for your review and here is the updated webrev: http://cr.openjdk.java.net/~sveerabhadra/8061359/webrev.01/ Thanks and regards, Shashi On 02/10/18 1:14 AM, Sergey Bylokhov wrote: Hi, Shashi

Re: [12] RFR JDK-8211703: JInternalFrame : java.lang.AssertionError: cannot find the internal frame

ere is any failure if we run the without esa, so I have only done away with the wrong assertion for BasicInternalFrameTitlePane. Regards Prasanta On 04-Oct-18 9:43 PM, Sergey Bylokhov wrote: Hi, Prasanta. Can you please clarify this code a little bit. As far as I understand this method sho

Re: [12] RFR JDK-8211703: JInternalFrame : java.lang.AssertionError: cannot find the internal frame

Hi, Prasanta. Can you please clarify this code a little bit. As far as I understand this method should return the JInternalFrame, which should be accessed via the comp passed to this method. This method already has this check: if (comp.getParent() instanceof

Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

v05/> Thanks, Krishna *From:*Krishna Addepalli *Sent:* Monday, September 17, 2018 10:44 PM *To:* Sergey Bylokhov *Cc:* swing-dev@openjdk.java.net *Subject:* Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9 Hi Sergey, Thanks for checking on Mac. I re

Re: [12] Review Request: 8133713 [macosx] Accessible JTables always reported as empty

tp://cr.openjdk.java.net/~serb/8133713/webrev.01 -phil. On 8/29/18, 3:03 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk12. Bug: https://bugs.openjdk.java.net/browse/JDK-8133713 Webrev: http://cr.openjdk.java.net/~serb/8133713/webrev.00 This fix provides the minimal supp

Re: [12] RFR [TEST][JDK-8209499] Create test for SwingSet3 EditorPaneDemo

.01/ Regards, Muneer -Original Message- From: Alexandre (Shura) Iline Sent: Thursday, August 30, 2018 10:45 PM To: Sergey Bylokhov Cc: Muneer Kolarkunnu ; swing-dev@openjdk.java.net Subject: Re: [12] RFR [TEST][JDK-8209499] Create test for SwingSet3 EditorPaneDemo Thank you - makes

Re: [12] RFR [JDK-8211139] Increase timeout value in all tests under jdk/sanity/client/SwingSet/src

Looks fine. On 03/10/2018 07:55, Muneer Kolarkunnu wrote: Hi All, Please review fix for the below task: Bug: https://bugs.openjdk.java.net/browse/JDK-8211139 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8211139/webrev.00/

Re: [11] RFR [JDK-8211160] Handle different look and feels in JInternalFrameOperator

Looks fine, I assume that the fix is for jdk12 not jdk11. On 01/10/2018 01:28, Muneer Kolarkunnu wrote: Gentle Reminder. Regards, Muneer *From:* Muneer Kolarkunnu *Sent:* Thursday, September 27, 2018 6:37 AM *To:* swing-dev@openjdk.java.net *Cc:* Aleksandre Iline *Subject:* [11] RFR

[12] Review Request: 8210739 Calling JSpinner's setFont with null throws NullPointerException

Hello. Please review the fix for jdk 12. This change updates the implementation of JDK-6421058, JDK-5036022 and JDK-8205144. The goal of those changes were to use the font of the JSpinner in textComponent(which is used inside the JSpinner). But the NPE may occur when the user sets the font of

Re: [12] JDK-8061359: [macosx] Checkbox toggles on Space press but does not spoken by Voice Over

Hi, Shashi. It looks like this line is not necessary; "if(ptr != 0) {" The prt is checked at the beginning of this method. On 01/10/2018 02:54, Shashidhara Veerabhadraiah wrote: Hi All, Please review a fix for an accessibility bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8061359 Webrev:

Re: [12] RFR JDK-6994403:Grammatical error in documentation of javax.swing.GroupLayout.ParallelGroup

Looks fine. On 28/09/2018 01:58, Prasanta Sadhukhan wrote: Hi All, Please review another doc fix where "its" is misspelt as "it's". Correct string should be as written in file copyright itself, "Copyright (c) 2006, 2015, Oracle and/or *its* affiliates" diff -r b5afdf0bbd9e

Re: [12] JDK-6821316:comment in source code of SynthStyleFactory.java has a self-reference

Looks fine. On 28/09/2018 03:07, Prasanta Sadhukhan wrote: Hi All, Please review another doc-fix where self reference is made in SynthSyleFactory diff -r d96a607e9594 src/java.desktop/share/classes/javax/swing/plaf/synth/SynthStyleFactory.java ---

Re: RFR; 8211031: Remove un-needed qualified export to java.desktop from java.base on macos

Hi, Phil. On 21/09/2018 22:24, Philip Race wrote: [*] at this exact moment, cr.openjdk.java.net isn't working but hopefully that will be fixed by the time anyone reads this :-) The classExists() method still there in version .1 -- Best regards, Sergey.

Re: [12] RFR [TEST][JDK-8210055] Enable different look and feel tests in SwingSet3 demo tests

Looks fine. On 24/09/2018 02:13, Muneer Kolarkunnu wrote: Gentle Reminder. Regards, Muneer *From:* Muneer Kolarkunnu *Sent:* Tuesday, September 18, 2018 3:08 PM *To:* Sergey Bylokhov ; swing-dev@openjdk.java.net *Cc:* Aleksandre Iline *Subject:* Re: [12] RFR [TEST][JDK-8210055] Enable

Re: [12] RFR [TEST][JDK-8210994] Create test for SwingSet3 FrameDemo

Looks fine. On 21/09/2018 00:23, Muneer Kolarkunnu wrote: Hi All, Please review the following, a new client sanity test case: Task: https://bugs.openjdk.java.net/browse/JDK-8210994 Webrev Link:http://cr.openjdk.java.net/~akolarkunnu/8210994/webrev.00/

Re: [12] RFR [JDK-8210910] Create test for FileChooserDemo

Looks fine. On 20/09/2018 01:04, Vikrant Agarwal wrote: Hi All, Please review this new test for SwingSet3 FileChooserDemo: Task: https://bugs.openjdk.java.net/browse/JDK-8210910 Webrev: http://cr.openjdk.java.net/~vagarwal/8210910/webrev.0/

Re: RFR: [12] JDK-8208638: Instead of circle rendered in appl window, but ellipse is produced JEditor Pane

Looks fine. On 10/09/2018 05:35, Prasanta Sadhukhan wrote: +1 Regards Prasanta On 9/10/2018 5:56 PM, Krishna Addepalli wrote: Thanks for the comments Prasanta, here is the updated webrev: http://cr.openjdk.java.net/~kaddepalli/8208638/webrev02/

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

, createUI should be updated not to create a new object everytime but to cache the object in appcontext and retrieves that instead of recreating everytime. Modified webrev: http://cr.openjdk.java.net/~psadhukhan/8192888/webrev.2/ Regards Prasanta On 13-Sep-18 1:18 AM, Sergey Bylokhov wrote

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

On 11/09/2018 22:03, Prasanta Sadhukhan wrote: Why SynthLookAndFeel.updateStyle() which is called in SynthButtonUI.updateStyle(AbstractButton b) did not update the context which is passed to it? Is it possible that SynthButtonUI.installDefaults() was not called before getBaseline()?

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

Hi, Prasanta. One small comment about the test, it will be good to check all supported LaF. On 11/09/2018 14:09, Sergey Bylokhov wrote: Hi, Prasanta. On 07/09/2018 03:57, Prasanta Sadhukhan wrote: Please review a fix for an issue where obtaining baseline for Button UI in Nimbus L results

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

Hi, Prasanta. On 07/09/2018 03:57, Prasanta Sadhukhan wrote: Please review a fix for an issue where obtaining baseline for Button UI in Nimbus L results in NPE. Reason for it is when SynthPanelUI#installDefaults is called during frame instantiation, it calls SynthPanelUI#updateStyle which sets

Re: [12] RFR JDK-8210052:Enable testing for all the available look and feels in SwingSet3 demo tests

Looks fine. On 11/09/2018 01:18, Vikrant Agarwal wrote: Gentle Reminder -Original Message- From: Vikrant Agarwal Sent: Tuesday, September 04, 2018 8:57 PM To: Aleksandre Iline Cc: swing-dev@openjdk.java.net Subject: Re: [12] RFR JDK-8210052:Enable testing for all the available look

Re: [12] Review Request: 8133713 [macosx] Accessible JTables always reported as empty

actions with the table. Thanks, Krishna On 30-Aug-2018, at 3:33 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk12. Bug: https://bugs.openjdk.java.net/browse/JDK-8133713 Webrev: http://cr.openjdk.java.net/~serb/8133713/webrev.00 This fix provides the minimal support of acce

Re: [8u-backport] JDK 8145547: [AWT/Swing] Conditional support for GTK 3 on Linux

HI, Pankaj. Can you please recheck that FX<-->Swing interop still works? Probably there are some other than GThreadHelper issues On 05/09/2018 11:44, Pankaj Bansal wrote: Hello Kevin, Thanks for pointing it out. I will remove this fix for now. I hope its ok, if I create new webrev when I

Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

BTW I am not sure do we need this refinement, or maybe this text is enough: "Returns an array of files representing the values which will be shown in the file chooser shortcuts panel." One more notes, if result of this method should be "shown in the file chooser shortcuts panel", then this

Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

Hi, Krishna. Are you sure that this text is correct?: "The array returned will be empty if there are no appropriate permissions". It is not necessary empty if "there are no appropriate permissions". BTW I am not sure do we need this refinement, or maybe this text is enough: "Returns an array

Re: [12] RFR [TEST][JDK-8209499] Create test for SwingSet3 EditorPaneDemo

Hi, Alexandr. I assume that one of the purpose of the test is to check that the html (including images) are correctly loaded to the EditorPane and present it to the user. If there are some issues like - absent of the image files - errors in the file system - bugs in EditorPane, etc which

Re: [12] RFR [TEST][JDK-8209993] Create a test for SwingSet3 ToolTipDemo

Looks fine. On 27/08/2018 18:30, Muneer Kolarkunnu wrote: Hi All, Please review the following, a new client sanity test case: Task: https://bugs.openjdk.java.net/browse/JDK-8209993 Webrev Link:http://cr.openjdk.java.net/~akolarkunnu/8209993/webrev.00/

[12] Review Request: 8133713 [macosx] Accessible JTables always reported as empty

Hello. Please review the fix for jdk12. Bug: https://bugs.openjdk.java.net/browse/JDK-8133713 Webrev: http://cr.openjdk.java.net/~serb/8133713/webrev.00 This fix provides the minimal support of accessibility(VoiceOver) for JTable. The table will be represented as a grid. The user will get

Re: RFR(M) : 8210039 : move OSInfo to top level testlibrary

Looks fine. On 28/08/2018 09:50, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8210039/webrev.00/index.html 698 lines changed: 114 ins; 240 del; 344 mod Hi all, could you please review this clean up of jdk testlibrary? the patch updates the tests to use jdk.test.lib.Platform

Re: [12] RFR [JDK-8209789] : Synchronize test/jdk/sanity/client/lib/jemmy with code-tools/jemmy/v2

Looks fine. On 21/08/2018 04:46, Muneer Kolarkunnu wrote: Hi, Please take a look on the set of changes brought into JDK Jemmy copy from the code-tools Jemmy repository. Task id: https://bugs.openjdk.java.net/browse/JDK-8209789 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8209789/webrev.00/

Re: [12] RFR JDK-8201925:JEditorPane unordered list bullets look pixelated

Hi, Prasanta. The fix will change the rendering of all elements in the JEditorPane. And it can be possible that we will introduce the issue similar to the bug when rendering uses one font metrics(anti-aliasing on) and layout uses another metrics(anti-aliasing off). This is similar to the

Re: [12] RFR [TEST][JDK-8209499] Create test for SwingSet3 EditorPaneDemo

Hi, Muneer. Is it possible to enhance the test so it will fail if the images are not loaded by the editor pane(it will pass if you apply the patch w/o images)? On 19/08/2018 22:05, Muneer Kolarkunnu wrote: Gentle Reminder. Regards, Muneer *From:*Muneer Kolarkunnu *Sent:* Tuesday, August

Re: [12] RFR [TEST][JDK-8209494] Create a test for SwingSet3 InternalFrameDemo

Looks fine. On 19/08/2018 22:05, Muneer Kolarkunnu wrote: Gentle Reminder. Regards, Muneer *From:*Muneer Kolarkunnu *Sent:* Tuesday, August 14, 2018 10:32 PM *To:* swing-dev@openjdk.java.net *Subject:* [12] RFR [TEST][JDK-8209494] Create a test for SwingSet3 InternalFrameDemo Hi All,

Re: [12] RFR JDK-8202702:Clearing selection on JTable causes disappearance of a row

Looks fine. On 08/08/2018 07:51, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that when clearing a selected row by calling JTable.clearSelection() causes this selected row to be not painted. This is because, the present BasicTableUI paint() method

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

sion in 11, works as a native cocoa components, and duplicate 300 lines of code. -phil. On 8/11/18, 3:14 PM, Sergey Bylokhov wrote: Hi, Krishna. Is it possible to deduplicate this code, I guess it should. On 11/08/2018 08:21, Krishna Addepalli wrote: Hi All, Please review a fix for J

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

BTW. Looks like this bu was reported before here: https://bugs.openjdk.java.net/browse/JDK-8167160 And the test was updated because our radio-buttons in the native L behave in the same way as the native cocoa equivalents. Can you confirm that? On 11/08/2018 15:14, Sergey Bylokhov wrote: Hi

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

Hi, Krishna. Is it possible to deduplicate this code, I guess it should. On 11/08/2018 08:21, Krishna Addepalli wrote: Hi All, Please review a fix for JDK-8208640: https://bugs.openjdk.java.net/browse/JDK-8208640 Webrev: http://cr.openjdk.java.net/~kaddepalli/8208640/webrev00/

Re: [12] RFR JDK-8209343:Test javax/swing/border/TestTitledBorderLeak.java should be marked as headful

+1 On 09/08/2018 22:20, Prasanta Sadhukhan wrote: Hi All, Please review this test which needs to be marked headful to avoid mach5 test failing. --- a/test/jdk/javax/swing/border/TestTitledBorderLeak.java Thu Aug 09 11:01:59 2018 +0530 +++

[12] Review Request: 8209340 The code which avoids synthetic accessors has become outdated

Hello. Please review the small cleanup for jdk12. Bug: https://bugs.openjdk.java.net/browse/JDK-8209340 Webrev: http://cr.openjdk.java.net/~serb/8209340/webrev.00 To avoid synthetic accessors in the class files, in some of our private nested classes the empty default constructor was added.

Re: [12] RFR JDK-8204963:javax.swing.border.TitledBorder has a memory leak

Looks fine. On 07/08/2018 07:28, Prasanta Sadhukhan wrote: OK. Thanks Sergey. Simplified my fix http://cr.openjdk.java.net/~psadhukhan/8204963/webrev.1/ Regards Prasanta On 8/7/2018 10:57 AM, Sergey Bylokhov wrote: On 06/08/2018 22:05, Krishna Addepalli wrote: Hi Sergey, AFAIK, lambdas

Re: [12] RFR JDK-8204963:javax.swing.border.TitledBorder has a memory leak

On 06/08/2018 22:05, Krishna Addepalli wrote: Hi Sergey, AFAIK, lambdas are syntactic sugar for anonymous inner classes, so I think using a lambda may not help. No, lambdas are implemented differently. BTW I think it can be simplified in the same way as in this fix:

Re: [12] RFR JDK-8204963:javax.swing.border.TitledBorder has a memory leak

Hi, Prasanta. On 06/08/2018 07:40, Prasanta Sadhukhan wrote: Proposed fix is to make it a named static class so that it does not hold reference and can be garbage collected. The same effect can be achieved by using lambda instead of anonymous PropertyChangeListener. Can you please check

Re: exception for JFileChooser

Hello, Can you please provide some more details. Which jdk and OS did you test? On 30/05/2018 20:45, Yu, Tristan (NSB - CN/Qingdao) wrote: Hi Swing-dev, I tried the example from oracle

Re: [12] RFR JDK-8203281:[Windows] JComboBox change in ui when editor.setBorder() is called

Hi, Prasanta. I am not sure that previous fix[JDK-6490753] was implemented for Vista only. Maybe Martin (CC) can take a look to this? On 01/08/2018 10:11, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that combobox gets an unwanted border around it. This

Re: [11] RFR:JDK-8176359: Frame#setMaximizedbounds not working properly in multi screen environments

, I have added back the uiScaling tests, and here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/8176359/webrev03/ Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Thursday, July 5, 2018 7:54 PM To: Krishna Addepalli ; swing-dev@openjdk.java.net Subject: Re: [11

Re: [12] RFR JDK-8203904:javax/swing/JSplitPane/4816114/bug4816114.java: The divider location is wrong

Looks fine. On 27/07/2018 07:57, Prasanta Sadhukhan wrote: Can I have a 2nd "R"eviewer for this? Regards Prasanta On 7/25/2018 4:59 PM, Krishna Addepalli wrote: +1 -Original Message- From: Prasanta Sadhukhan Sent: Wednesday, July 25, 2018 11:59 AM To: Krishna Addepalli ;

Re: RFR: 8206375 : ProblemList update of bug ID for SwingFontMetricsTest

Looks fine. On 06/07/2018 01:23, Phil Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8206375 One bug was closed as a dup of another, so the Problem List needs to be updated to refer to the one that is still open: diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt

Re: [11] RFR:JDK-8176359: Frame#setMaximizedbounds not working properly in multi screen environments

the point lies, and use the scale of that screen. 3. Thanks for pointing that out, fixed it in the new webrev. Here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/8176359/webrev02/ Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Saturday, June 30, 2018 1:40

Re: [11] RFR:JDK-8176359: Frame#setMaximizedbounds not working properly in multi screen environments

Hi, Krishna. Also, while running the testcase, I discovered that the -Dsun.java2d.uiScale=1.25 will uniformly apply the scaling across all the screens, whereas if the underlying monitor is not scaled, the results will be different. Hence I modified the test to remove the uiScale settings

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L at Hidpi

n the GC=null will be replaced by the GC=non-null). Before my fix it it was done using "ancestor" property(in some cases) On 6/28/2018 1:54 PM, Sergey Bylokhov wrote: Hi, Phil. The new webrev: http://cr.openjdk.java.net/~serb/8201552/webrev.03/ I have checked why valida

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L at Hidpi

g a pointless invalidation with consequent overhead. Can  you check if we can skip it in some cases ? -phil. On 6/22/18, 4:16 PM, Sergey Bylokhov wrote: The place where the current graphicsConfiguration of the component is matter:  - JComponent.getFontMetrics(Font)  -- SwingUtilities2.getFontMetri

Re: JDesktopPane and menu bars

Hi, Alan. I think this use case is not specified and it was implemented in the same way as it works in jdk 6 from Apple. On 26/06/2018 07:58, Alan Snyder wrote: I gather from recent bug fixes that JDesktopPane is being used, but I don’t have a feel for how it is being used. Can someone

Re: [11] JDK-8194873: right ALT key hotkeys no longer work in Swing components

difier passed to it. Webrev: http://cr.openjdk.java.net/~pbansal/8194873/webrev.06/ Regards Pankaj Bansal -Original Message- From: Sergey Bylokhov Sent: Friday, June 22, 2018 5:13 AM To: Pankaj Bansal; Prasanta Sadhukhan Cc: swing-dev@openjdk.java.net Subject: Re: [11] JDK-8194873: right A

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L at Hidpi

another GC. The first GC which is used for size calculation may be null or it maybe a non-null value pointed to another screen, for example if the jtree was shown on one screen and then dragged to another. On 22/06/2018 14:40, Sergey Bylokhov wrote: In the SwingSet2 the bug is visible only

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L at Hidpi

the text using another GC. If the user will switch L the size will be recalculated using correct GraphicsConfiguration. -phil. On 06/22/2018 01:48 PM, Sergey Bylokhov wrote: Any volunteers for review? =) On 17/06/2018 15:37, Sergey Bylokhov wrote: Unfortunately after additional testing I

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L at Hidpi

Any volunteers for review? =) On 17/06/2018 15:37, Sergey Bylokhov wrote: Unfortunately after additional testing I found a bug in our text related components. In the JTextPane the text looks broken if we request some change in the component after it is became visible. For example if we

[11] Review Request: 8205454 is displayed in some Swing docs

Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8205454 Webrev: http://cr.openjdk.java.net/~serb/8205454/webrev.00 A few typos were fixed. - In some cases it was caused by the JDK-8025230(Lamp;F in the javadoc in JPanel.java). - The bug in javabeans

Re: [11] JDK-8194873: right ALT key hotkeys no longer work in Swing components

ankaj Bansal; Andrej Golovnin Cc: Sergey Bylokhov; swing-dev@openjdk.java.net Subject: Re: [11] JDK-8194873: right ALT key hotkeys no longer work in Swing components Hi Pankaj, looks good. but it still does not test JMenuItem as I can see. Did you check if you have some menu items inside JMenu

Re: RFR: 8205119: SwingApplet demo should be removed

Looks fine. On 21/06/2018 13:53, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8205119 Webrev : http://cr.openjdk.java.net/~prr/8205119/ This demo only demonstrates how to create a Swing Applet, nothing more, but Applet is now deprecated, and the demo can't be run without

Re: [11] JDK-8194873: right ALT key hotkeys no longer work in Swing components

- From: Prasanta Sadhukhan Sent: Thursday, April 19, 2018 12:41 PM To: Pankaj Bansal; Andrej Golovnin Cc: Sergey Bylokhov; swing-dev@openjdk.java.net Subject: Re: [11] JDK-8194873: right ALT key hotkeys no longer work in Swing components Hi Pankaj, looks good. but it still does not test JMenuItem a

[11] Review Request: 8205144 JSpinner may change the font after became visible

Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8205144 Webrev: http://cr.openjdk.java.net/~serb/8205144/webrev.00 Our implementation of JSpinner tries to maintain the font which is used in the text field inside spinner. There are three cases when the font

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L at Hidpi

On 15/06/2018 23:31, Sergey Bylokhov wrote: Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8201552 Webrev: http://cr.openjdk.java.net/~serb/8201552/webrev.01/ Short description: This fix enhance implementation of JDK-8178025[1] for most of our Swing components

[11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L at Hidpi

Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8201552 Webrev: http://cr.openjdk.java.net/~serb/8201552/webrev.01/ Short description: This fix enhance implementation of JDK-8178025[1] for most of our Swing components. The main rule which I tried to

Re: [11] Review Request: 8202768 [macos] Appkit thread slows when any Window Manager active

tributes are cached and should not affect performance. Regards, Anton. On 6/4/2018 11:57 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8202768 Webrev: http://cr.openjdk.java.net/~serb/8202768/webrev.00 Short description: The r

[11] Review Request: 6608234 SwingWorker.get throws CancellationException

Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-6608234 Webrev: http://cr.openjdk.java.net/~serb/6608234/webrev.00 CSR: https://bugs.openjdk.java.net/browse/JDK-8204587 The SwingWorker.get(XX) methods copy the text of exceptions from the parent class, but

Re: RFR: 8203499 Uninitialised memory in WinAccessBridge.cpp

Looks fine. On 05/06/2018 13:24, Phil Race wrote: Bug: Uninitialised memory in WinAccessBridge.cpp:485 webrev: http://cr.openjdk.java.net/~prr/8203499/ element is not initialised on declaration. It should be initialised when its address is passed here messageQueue->remove(); but it is too

<    5   6   7   8   9   10   11   12   13   14   >