Re: [11]JDK-8200605: Create test for GridBagLayoutDemo

Hi, Vikrant. I tried to run the new test but it fails on my local system(macos): === sanity/client/SwingSet/src/GridBagLayoutDemoTest.java Total tests run: 4, Failures: 1, Skips: 0 === --System.err:(1

Re: RFR: 8201328: SynthParser should use Boolean.parseBoolean

Looks fine. BTW, I am curious can we implement equalsIgnoreCase via || and && instead of conditional operations to speedup it or not. On 09/04/2018 10:58, Martin Buchholz wrote: Here's a little cleanup suggested by Сергей Цыпанов 8201328: SynthParser should use Boolean.parseBoolean http://cr.

Re: [11][JDK-4842658] RFR: DefaultListModel and DefaultComboBoxModel should support addAll (Collection c)

Hi, Krishna. Please update the test to catch the difference between v00 and v01. Some comments about javadoc: - "183 * " is unnecessary - Do not use dots at the end of @param/@return tags - Not sure that the text below is necessary(it is duplicate description of @exception tag): "202

Re: [11]JDK-8200605: Create test for GridBagLayoutDemo

Hi, Vikrant. Thanks for the feedback, this failure was due to a bug in Mac, Component.getLocation() was giving an incorrect/inconsistent initial value when the component is located at (0,0). I have filed a bug for this issue: https://bugs.openjdk.java.net/browse/JDK-8201364 . I have added a

Re: [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description

Hi, Pankaj. Can you please check other methods in this class since we update it anyway. For example "setInstalledLookAndFeels" has @throws NPE but "installLookAndFeel" has not. The test to prove that, is welcome as well. On 10/04/2018 03:57, Pankaj Bansal wrote: Hi All, Please review a very si

Re: [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description

On 11/04/2018 02:55, Pankaj Bansal wrote: I have checked all the functions and I could not find any other API with wrong description. ok < This test will check that this method works according to its specification. Previously NPE was not specified and implementation of the method could or

Re: [11][JDK-4842658] RFR: DefaultListModel and DefaultComboBoxModel should support addAll (Collection c)

On 10/04/2018 05:43, Krishna Addepalli wrote: - Why in one class you use addElements/addElementsAt names and in another addAll? In the DefaultComboBoxModel, the functions to add a single element are named as addElement, addElementAt. To keep with that convention, I named the apis appropriately.

Re: [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description

Looks fine. On 12/04/2018 00:10, Pankaj Bansal wrote: Hi Sergey, <http://cr.openjdk.java.net/~pbansal/8153532/webrev.02/ Regards, Pankaj Bansal -Original Message- From: Sergey Bylokhov Sent: Thursday, April 12, 2018 4:18 AM To: Pankaj Bansal; [email protected] Subject:

Re: [11][JDK-4842658] RFR: DefaultListModel and DefaultComboBoxModel should support addAll (Collection c)

addAll is better, because it is aligned with the common names from Collection framework. Thanks, Krishna -----Original Message- From: Sergey Bylokhov Sent: Friday, April 13, 2018 2:59 AM To: Krishna Addepalli ; Andrej Golovnin Cc: [email protected] Subject: Re:

Re: [11] RFR JDK-8189687:Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows

ctly in user space (except for the cases when it comes to raster images may be). In scope of this, the suggested approach  doesn't seem right... So, could you please share your thoughts on it and consider the alternative fix referenced above? Thanks, Anton. On 3/31/2018 4:21 AM, Se

Re: [11] RFR JDK-8189687:Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows

On 24/04/2018 13:22, Anton Tarasov wrote: Clarification. The coordinate should not actually be split into displays every time it's scaled up/down. It's enough to calculate its offset in the "terminal" display and scale it accordingly. Then have all the displays already mapped b/w device and us

Re: [11] RFR JDK-8189687:Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows

BTW there is a typo: 3888 int sx = ScaleUpX(x) - p.x; 3889 int sy = ScaleUpX(y) - p.y; Thanks for the catch, fixed it. http://cr.openjdk.java.net/~ant/JDK-8202084/webrev.1 Looks fine. -- Best regards, Sergey.

Re: [11] RFR [JDK-8202064] Jemmy JInternalFrameOperator: Add wait for close(), activate(), resize() and move() operations

+1 On 24/04/2018 05:40, Muneer Kolarkunnu wrote: Gentle Reminder! Regards, Muneer *From:* Muneer Kolarkunnu *Sent:* Friday, April 20, 2018 10:23 AM *To:* [email protected] *Cc:* Aleksandre Iline *Subject:* [11] RFR [JDK-8202064] Jemmy JInternalFrameOperator: Add wait for close(),

Re: [11][JDK-4842658] RFR: DefaultListModel and DefaultComboBoxModel should support addAll (Collection c)

k.java.net/~kaddepalli/4842658/webrev05/ Thanks, Krishna -Original Message----- From: Sergey Bylokhov Sent: Wednesday, April 18, 2018 3:21 AM To: Krishna Addepalli ; Andrej Golovnin Cc: [email protected] Subject: Re: [11][JDK-4842658] RFR: DefaultListModel and DefaultComboBoxModel shou

Re: [11] Review Request: 8198342 Test FileSystemViewListenerLeak.java is unstable

Any volunteers to review? =) On 12/03/2018 22:27, Sergey Bylokhov wrote: Hello. Please review the update of the test for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8198342 Webrev can be found at: http://cr.openjdk.java.net/~serb/8198342/webrev.00 This test creates a number of

Re: [11] Review Request: 8198342 Test FileSystemViewListenerLeak.java is unstable

Hi, Jay. On 24/04/2018 23:27, Jayathirth D V wrote: I went through the changes done in JDK-8175968 and I can understand why you would have added creation of multiple CustomFileSystemView like stress test scenario. But as you have mentioned in highly loaded systems there can sometimes be proble

Re: Swing dev>[10] Review request for JDK-8189253: [macos] JPopupMenu is inadvertently shown when using setComponentPopupMenu

Hi, Manajit. Please clarify why this bug is occurred after JDK-8080729, how orderWindow/addChildWindow are related to the mouse events which we get? Did we start to get more event or less events or we get events in the different order, what is the difference? On 04/01/2018 10:22, Manajit Hald

Re: [11] RFR: JDK-8199441: Wrong caret position in multiline text components on Windows with a screen resolution higher than 100%

Hi, Prasanta. Please confirm that you run related jck/reg tests. On 26/04/2018 23:52, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that,  with a screen resolution higher than 100% and then clicking in a JTextArea having setLineWrap(true) set, the caret (

Re: RFR: 8202679 : Updates on windows failures in the problem list

Looks fine. On 04/05/2018 16:27, Philip Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8202679 webrev: http://cr.openjdk.java.net/~prr/8202679/ The additions comprise : 4 new bugs were filed for consistent failures A couple of bugs were not included for existing open bugs The modif

Re: [11] RFR [JDK-8202718] Jemmy JInternalFrameOperator: Dependency with orders of Minimize, Maximize and Close buttons

Then looks fine. On 07/05/2018 10:48, Alexandre (Shura) Iline wrote: These changes seem to be consistent with what’s in Jemmy code-tools repository and, therefore, correct. Shura On May 7, 2018, at 5:47 AM, Muneer Kolarkunnu mailto:[email protected]>> wrote: Hi All, Please review

[11] Review Request: 8202878 com/apple/laf/ScreenMenu/ScreenMenuMemoryLeakTest.java fails

Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8202878 Fix: http://cr.openjdk.java.net/~serb/8202878/webrev.00 The test tries to check that the JMenuItem will be collected by GC if it was removed from the menu. The problem is that the code below does not

Re: RFR: 8202811: Problem List some tests that leave windows open on the desktop

Looks fine as a first step in our cleanup of the tests on lin/mac. Note: I think that some of the tests fail because of some unrelated issues(other tests or some setup issues), at least some of them works fine on my mac, for example: java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java

Re: [11] Review Request: 8202878 com/apple/laf/ScreenMenu/ScreenMenuMemoryLeakTest.java fails

The fix problemList is updated after JDK-8202811[1] was pushed: http://cr.openjdk.java.net/~serb/8202878/webrev.01 [1] http://cr.openjdk.java.net/~prr/8202811.1/ On 10/05/2018 18:45, Philip Race wrote: +1 -phil. On 5/10/18, 6:42 PM, Sergey Bylokhov wrote: Hello. Please review the fix for

[11] Review Request: 8199150 and 8150156

Hello. Please review the fix for jdk11, which fixed some accessibility issues in the specification. Bug: https://bugs.openjdk.java.net/browse/JDK-8199150 https://bugs.openjdk.java.net/browse/JDK-8150156 Fix: http://cr.openjdk.java.net/~serb/8199150/webrev.01 Description: - The links to "

Re: [11]JDK-8200605: Create test for GridBagLayoutDemo

Thanks Phil, Updated Webrev: http://cr.openjdk.java.net/~vagarwal/8200605/webrev.2/ Best Regards, Vikrant -Original Message- From: Philip Race Sent: Thursday, May 03, 2018 4:33 AM To: Vikrant Agarwal Cc: Aleksandre Iline ; Sergey Bylokhov ; [email protected] Subject: Re: [11]JDK

Re: Docs error in javax.swing.JComponent

These typos were fixed in jdk9: https://bugs.openjdk.java.net/browse/JDK-8068374 On 29/05/2018 02:11, Alexandr Evstigneev wrote: -- Best regards, Sergey.

[11] Review Request: 8202768 [macos] Appkit thread slows when any Window Manager active

Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8202768 Webrev: http://cr.openjdk.java.net/~serb/8202768/webrev.00 Short description: The root cause of the bug is tremendous complexity of code which iterate over hierarchy of accessibility components, it was

Re: RFR: 8203499 Uninitialised memory in WinAccessBridge.cpp

Looks fine. On 05/06/2018 13:24, Phil Race wrote: Bug: Uninitialised memory in WinAccessBridge.cpp:485 webrev: http://cr.openjdk.java.net/~prr/8203499/ element is not initialised on declaration. It should be initialised when its address is passed here messageQueue->remove(&element); but it is

[11] Review Request: 6608234 SwingWorker.get throws CancellationException

Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-6608234 Webrev: http://cr.openjdk.java.net/~serb/6608234/webrev.00 CSR: https://bugs.openjdk.java.net/browse/JDK-8204587 The SwingWorker.get(XX) methods copy the text of exceptions from the parent class, but t

Re: [11] Review Request: 8202768 [macos] Appkit thread slows when any Window Manager active

re not set by default, because default attributes are cached and should not affect performance. Regards, Anton. On 6/4/2018 11:57 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8202768 Webrev: http://cr.openjdk.java.net/~serb/8

[11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L&F at Hidpi

Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8201552 Webrev: http://cr.openjdk.java.net/~serb/8201552/webrev.01/ Short description: This fix enhance implementation of JDK-8178025[1] for most of our Swing components. The main rule which I tried to follow:

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L&F at Hidpi

15/06/2018 23:31, Sergey Bylokhov wrote: Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8201552 Webrev: http://cr.openjdk.java.net/~serb/8201552/webrev.01/ Short description: This fix enhance implementation of JDK-8178025[1] for most of our Swing components

[11] Review Request: 8205144 JSpinner may change the font after became visible

Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8205144 Webrev: http://cr.openjdk.java.net/~serb/8205144/webrev.00 Our implementation of JSpinner tries to maintain the font which is used in the text field inside spinner. There are three cases when the font

Re: [11] JDK-8194873: right ALT key hotkeys no longer work in Swing components

- From: Prasanta Sadhukhan Sent: Thursday, April 19, 2018 12:41 PM To: Pankaj Bansal; Andrej Golovnin Cc: Sergey Bylokhov; [email protected] Subject: Re: [11] JDK-8194873: right ALT key hotkeys no longer work in Swing components Hi Pankaj, looks good. but it still does not test JMenuItem a

Re: RFR: 8205119: SwingApplet demo should be removed

Looks fine. On 21/06/2018 13:53, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8205119 Webrev : http://cr.openjdk.java.net/~prr/8205119/ This demo only demonstrates how to create a Swing Applet, nothing more, but Applet is now deprecated, and the demo can't be run without appl

Re: [11] JDK-8194873: right ALT key hotkeys no longer work in Swing components

ankaj Bansal; Andrej Golovnin Cc: Sergey Bylokhov; [email protected] Subject: Re: [11] JDK-8194873: right ALT key hotkeys no longer work in Swing components Hi Pankaj, looks good. but it still does not test JMenuItem as I can see. Did you check if you have some menu items inside JMenu

[11] Review Request: 8205454 & is displayed in some Swing docs

Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8205454 Webrev: http://cr.openjdk.java.net/~serb/8205454/webrev.00 A few typos were fixed. - In some cases it was caused by the JDK-8025230(L&F in the javadoc in JPanel.java). - The bug in javabeans desc

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L&F at Hidpi

Any volunteers for review? =) On 17/06/2018 15:37, Sergey Bylokhov wrote: Unfortunately after additional testing I found a bug in our text related components. In the JTextPane the text looks broken if we request some change in the component after it is became visible. For example if we

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L&F at Hidpi

GC, and will draw the text using another GC. If the user will switch L&F the size will be recalculated using correct GraphicsConfiguration. -phil. On 06/22/2018 01:48 PM, Sergey Bylokhov wrote: Any volunteers for review? =) On 17/06/2018 15:37, Sergey Bylokhov wrote: Unfortunately

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L&F at Hidpi

another GC. The first GC which is used for size calculation may be null or it maybe a non-null value pointed to another screen, for example if the jtree was shown on one screen and then dragged to another. On 22/06/2018 14:40, Sergey Bylokhov wrote: In the SwingSet2 the bug is visible only if the

Re: [11] JDK-8194873: right ALT key hotkeys no longer work in Swing components

difier passed to it. Webrev: http://cr.openjdk.java.net/~pbansal/8194873/webrev.06/ Regards Pankaj Bansal -Original Message- From: Sergey Bylokhov Sent: Friday, June 22, 2018 5:13 AM To: Pankaj Bansal; Prasanta Sadhukhan Cc: [email protected] Subject: Re: [11] JDK-8194873: right A

Re: JDesktopPane and menu bars

Hi, Alan. I think this use case is not specified and it was implemented in the same way as it works in jdk 6 from Apple. On 26/06/2018 07:58, Alan Snyder wrote: I gather from recent bug fixes that JDesktopPane is being used, but I don’t have a feel for how it is being used. Can someone explai

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L&F at Hidpi

g a pointless invalidation with consequent overhead. Can  you check if we can skip it in some cases ? -phil. On 6/22/18, 4:16 PM, Sergey Bylokhov wrote: The place where the current graphicsConfiguration of the component is matter:  - JComponent.getFontMetrics(Font)  -- SwingUtilities2.getFontMetri

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L&F at Hidpi

he GC=null will be replaced by the GC=non-null). Before my fix it it was done using "ancestor" property(in some cases) On 6/28/2018 1:54 PM, Sergey Bylokhov wrote: Hi, Phil. The new webrev: http://cr.openjdk.java.net/~serb/8201552/webrev.03/ I have checked why validation

Re: [11] RFR:JDK-8176359: Frame#setMaximizedbounds not working properly in multi screen environments

Hi, Krishna. Also, while running the testcase, I discovered that the -Dsun.java2d.uiScale=1.25 will uniformly apply the scaling across all the screens, whereas if the underlying monitor is not scaled, the results will be different. Hence I modified the test to remove the uiScale settings rela

Re: [11] RFR:JDK-8176359: Frame#setMaximizedbounds not working properly in multi screen environments

the point lies, and use the scale of that screen. 3. Thanks for pointing that out, fixed it in the new webrev. Here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/8176359/webrev02/ Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Saturday, June 30, 2018 1:40

Re: RFR: 8206375 : ProblemList update of bug ID for SwingFontMetricsTest

Looks fine. On 06/07/2018 01:23, Phil Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8206375 One bug was closed as a dup of another, so the Problem List needs to be updated to refer to the one that is still open: diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt --

Re: [12] RFR JDK-8203904:javax/swing/JSplitPane/4816114/bug4816114.java: The divider location is wrong

Looks fine. On 27/07/2018 07:57, Prasanta Sadhukhan wrote: Can I have a 2nd "R"eviewer for this? Regards Prasanta On 7/25/2018 4:59 PM, Krishna Addepalli wrote: +1 -Original Message- From: Prasanta Sadhukhan Sent: Wednesday, July 25, 2018 11:59 AM To: Krishna Addepalli ; swing-dev@op

Re: [11] RFR:JDK-8176359: Frame#setMaximizedbounds not working properly in multi screen environments

, I have added back the uiScaling tests, and here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/8176359/webrev03/ Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Thursday, July 5, 2018 7:54 PM To: Krishna Addepalli ; [email protected] Subject: Re: [11

Re: [12] RFR JDK-8203281:[Windows] JComboBox change in ui when editor.setBorder() is called

Hi, Prasanta. I am not sure that previous fix[JDK-6490753] was implemented for Vista only. Maybe Martin (CC) can take a look to this? On 01/08/2018 10:11, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that combobox gets an unwanted border around it. This i

Re: exception for JFileChooser

Hello, Can you please provide some more details. Which jdk and OS did you test? On 30/05/2018 20:45, Yu, Tristan (NSB - CN/Qingdao) wrote: Hi Swing-dev, I tried the example from oracle https://docs.oracle.com/javase/tutorial/displayCode.html?code=https://docs.oracle.com/javase/tutorial/uiswing

Re: [12] RFR JDK-8204963:javax.swing.border.TitledBorder has a memory leak

Hi, Prasanta. On 06/08/2018 07:40, Prasanta Sadhukhan wrote: Proposed fix is to make it a named static class so that it does not hold reference and can be garbage collected. The same effect can be achieved by using lambda instead of anonymous PropertyChangeListener. Can you please check which

Re: [12] RFR JDK-8204963:javax.swing.border.TitledBorder has a memory leak

On 06/08/2018 22:05, Krishna Addepalli wrote: Hi Sergey, AFAIK, lambdas are syntactic sugar for anonymous inner classes, so I think using a lambda may not help. No, lambdas are implemented differently. BTW I think it can be simplified in the same way as in this fix: https://bugs.openjdk.java

Re: [12] RFR JDK-8204963:javax.swing.border.TitledBorder has a memory leak

Looks fine. On 07/08/2018 07:28, Prasanta Sadhukhan wrote: OK. Thanks Sergey. Simplified my fix http://cr.openjdk.java.net/~psadhukhan/8204963/webrev.1/ Regards Prasanta On 8/7/2018 10:57 AM, Sergey Bylokhov wrote: On 06/08/2018 22:05, Krishna Addepalli wrote: Hi Sergey, AFAIK, lambdas are

[12] Review Request: 8209340 The code which avoids synthetic accessors has become outdated

Hello. Please review the small cleanup for jdk12. Bug: https://bugs.openjdk.java.net/browse/JDK-8209340 Webrev: http://cr.openjdk.java.net/~serb/8209340/webrev.00 To avoid synthetic accessors in the class files, in some of our private nested classes the empty default constructor was added. (Eac

Re: [12] RFR JDK-8209343:Test javax/swing/border/TestTitledBorderLeak.java should be marked as headful

+1 On 09/08/2018 22:20, Prasanta Sadhukhan wrote: Hi All, Please review this test which needs to be marked headful to avoid mach5 test failing. --- a/test/jdk/javax/swing/border/TestTitledBorderLeak.java Thu Aug 09 11:01:59 2018 +0530 +++ b/test/jdk/javax/swing/border/TestTitledBorderLeak.j

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

Hi, Krishna. Is it possible to deduplicate this code, I guess it should. On 11/08/2018 08:21, Krishna Addepalli wrote: Hi All, Please review a fix for JDK-8208640: https://bugs.openjdk.java.net/browse/JDK-8208640 Webrev: http://cr.openjdk.java.net/~kaddepalli/8208640/webrev00/

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

BTW. Looks like this bu was reported before here: https://bugs.openjdk.java.net/browse/JDK-8167160 And the test was updated because our radio-buttons in the native L&F-Aqua behave in the same way as the native cocoa equivalents. Can you confirm that? On 11/08/2018 15:14, Sergey Bylo

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

sion in 11, works as a native cocoa components, and duplicate 300 lines of code. -phil. On 8/11/18, 3:14 PM, Sergey Bylokhov wrote: Hi, Krishna. Is it possible to deduplicate this code, I guess it should. On 11/08/2018 08:21, Krishna Addepalli wrote: Hi All, Please review a fix for J

Re: [12] RFR [JDK-8209418] : Synchronize test/jdk/sanity/client/lib/jemmy with code-tools/jemmy/v2

Looks fine. BTW: there is a small typo: test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JInternalFrameOperator.java 1393 "Jemmy doesn't support getting or intializing title" On 13/08/2018 04:50, Muneer Kolarkunnu wrote: Hi, Please take a look on the set of changes brought in

Re: [12] RFR JDK-8202702:Clearing selection on JTable causes disappearance of a row

Looks fine. On 08/08/2018 07:51, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that when clearing a selected row by calling JTable.clearSelection() causes this selected row to be not painted. This is because, the present BasicTableUI paint() method paint

Re: [12] Review Request: 8209340 The code which avoids synthetic accessors has become outdated

On 13/08/2018 19:32, Krishna Addepalli wrote: I understand that with the new jep, we no longer need to explicitly write the constructor to avoid the synthetic accessor methods generated by the compiler. AFAIK, each inner class declared results in a class file being generated rather than each

Re: [12] RFR [TEST][JDK-8209494] Create a test for SwingSet3 InternalFrameDemo

Looks fine. On 19/08/2018 22:05, Muneer Kolarkunnu wrote: Gentle Reminder. Regards, Muneer *From:*Muneer Kolarkunnu *Sent:* Tuesday, August 14, 2018 10:32 PM *To:* [email protected] *Subject:* [12] RFR [TEST][JDK-8209494] Create a test for SwingSet3 InternalFrameDemo Hi All, Ple

Re: [12] RFR [TEST][JDK-8209499] Create test for SwingSet3 EditorPaneDemo

Hi, Muneer. Is it possible to enhance the test so it will fail if the images are not loaded by the editor pane(it will pass if you apply the patch w/o images)? On 19/08/2018 22:05, Muneer Kolarkunnu wrote: Gentle Reminder. Regards, Muneer *From:*Muneer Kolarkunnu *Sent:* Tuesday, August 14,

Re: [12] RFR JDK-8201925:JEditorPane unordered list bullets look pixelated

Hi, Prasanta. The fix will change the rendering of all elements in the JEditorPane. And it can be possible that we will introduce the issue similar to the bug when rendering uses one font metrics(anti-aliasing on) and layout uses another metrics(anti-aliasing off). This is similar to the mismat

Re: [12] RFR [JDK-8209789] : Synchronize test/jdk/sanity/client/lib/jemmy with code-tools/jemmy/v2

Looks fine. On 21/08/2018 04:46, Muneer Kolarkunnu wrote: Hi, Please take a look on the set of changes brought into JDK Jemmy copy from the code-tools Jemmy repository. Task id: https://bugs.openjdk.java.net/browse/JDK-8209789 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8209789/webrev.00/

Re: RFR(M) : 8210039 : move OSInfo to top level testlibrary

Looks fine. On 28/08/2018 09:50, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8210039/webrev.00/index.html 698 lines changed: 114 ins; 240 del; 344 mod Hi all, could you please review this clean up of jdk testlibrary? the patch updates the tests to use jdk.test.lib.Platform in

[12] Review Request: 8133713 [macosx] Accessible JTables always reported as empty

Hello. Please review the fix for jdk12. Bug: https://bugs.openjdk.java.net/browse/JDK-8133713 Webrev: http://cr.openjdk.java.net/~serb/8133713/webrev.00 This fix provides the minimal support of accessibility(VoiceOver) for JTable. The table will be represented as a grid. The user will get aud

Re: [12] RFR [TEST][JDK-8209993] Create a test for SwingSet3 ToolTipDemo

Looks fine. On 27/08/2018 18:30, Muneer Kolarkunnu wrote: Hi All, Please review the following, a new client sanity test case: Task: https://bugs.openjdk.java.net/browse/JDK-8209993 Webrev Link:http://cr.openjdk.java.net/~akolarkunnu/8209993/webrev.00/

Re: [12] RFR [TEST][JDK-8209499] Create test for SwingSet3 EditorPaneDemo

Hi, Alexandr. I assume that one of the purpose of the test is to check that the html (including images) are correctly loaded to the EditorPane and present it to the user. If there are some issues like - absent of the image files - errors in the file system - bugs in EditorPane, etc which pre

Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

Hi, Krishna. Are you sure that this text is correct?: "The array returned will be empty if there are no appropriate permissions". It is not necessary empty if "there are no appropriate permissions". BTW I am not sure do we need this refinement, or maybe this text is enough: "Returns an array of

Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

BTW I am not sure do we need this refinement, or maybe this text is enough: "Returns an array of files representing the values which will be shown in the file chooser shortcuts panel." One more notes, if result of this method should be "shown in the file chooser shortcuts panel", then this met

Re: [8u-backport] JDK 8145547: [AWT/Swing] Conditional support for GTK 3 on Linux

HI, Pankaj. Can you please recheck that FX<-->Swing interop still works? Probably there are some other than GThreadHelper issues On 05/09/2018 11:44, Pankaj Bansal wrote: Hello Kevin, Thanks for pointing it out. I will remove this fix for now. I hope its ok, if I create new webrev when I get

Re: [12] Review Request: 8133713 [macosx] Accessible JTables always reported as empty

ed for interactions with the table. Thanks, Krishna On 30-Aug-2018, at 3:33 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk12. Bug: https://bugs.openjdk.java.net/browse/JDK-8133713 Webrev: http://cr.openjdk.java.net/~serb/8133713/webrev.00 This fix provides the minimal suppo

Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

ch is why I'm failing if none of these are returned. Thanks, Krishna -Original Message- From: Krishna Addepalli Sent: Wednesday, September 5, 2018 5:04 PM To: Sergey Bylokhov <mailto:[email protected]>>; Prasanta Sadhukhan <mailto:[email protected]>>

Re: [12] RFR JDK-8210052:Enable testing for all the available look and feels in SwingSet3 demo tests

Looks fine. On 11/09/2018 01:18, Vikrant Agarwal wrote: Gentle Reminder -Original Message- From: Vikrant Agarwal Sent: Tuesday, September 04, 2018 8:57 PM To: Aleksandre Iline Cc: [email protected] Subject: Re: [12] RFR JDK-8210052:Enable testing for all the available look a

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

Hi, Prasanta. On 07/09/2018 03:57, Prasanta Sadhukhan wrote: Please review a fix for an issue where obtaining baseline for Button UI in Nimbus L&F results in NPE. Reason for it is when SynthPanelUI#installDefaults is called during frame instantiation, it calls SynthPanelUI#updateStyle which sets

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

Hi, Prasanta. One small comment about the test, it will be good to check all supported LaF. On 11/09/2018 14:09, Sergey Bylokhov wrote: Hi, Prasanta. On 07/09/2018 03:57, Prasanta Sadhukhan wrote: Please review a fix for an issue where obtaining baseline for Button UI in Nimbus L&F res

Re: [12] RFR [TEST][JDK-8210056] Enable different look and feel tests in SwingSet3 demo test TextFieldDemoTest

Looks fine. On 07/09/2018 00:13, Muneer Kolarkunnu wrote: Hi All, Please review the fix to add support for testing for all the available look and feels for the TextFieldDemoTest. Task: https://bugs.openjdk.java.net/browse/JDK-8210056 Webrev Link:http://cr.openjdk.java.net/~akolarkunnu/82100

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

On 11/09/2018 22:03, Prasanta Sadhukhan wrote: Why SynthLookAndFeel.updateStyle() which is called in SynthButtonUI.updateStyle(AbstractButton b) did not update the context which is passed to it? Is it possible that SynthButtonUI.installDefaults() was not called before getBaseline()? SynthButt

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

onUI, WindowsButtonUI, createUI should be updated not to create a new object everytime but to cache the object in appcontext and retrieves that instead of recreating everytime. Modified webrev: http://cr.openjdk.java.net/~psadhukhan/8192888/webrev.2/ Regards Prasanta On 13-Sep-18 1:18 AM, Sergey Bylokhov wrote:

Re: [12] RFR [TEST][JDK-8210055] Enable different look and feel tests in SwingSet3 demo tests

Hi, Muneer. Can you please take a look to this test: open/test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java On macOS before the fix, this test shown the frame for long period of time without any actions and then completes w/o errors. After the fix it fails because of timeout. On 16/0

Re: RFR: [12] JDK-8208638: Instead of circle rendered in appl window, but ellipse is produced JEditor Pane

Looks fine. On 10/09/2018 05:35, Prasanta Sadhukhan wrote: +1 Regards Prasanta On 9/10/2018 5:56 PM, Krishna Addepalli wrote: Thanks for the comments Prasanta, here is the updated webrev: http://cr.openjdk.java.net/~kaddepalli/8208638/webrev02/

Re: [12] RFR [JDK-8210910] Create test for FileChooserDemo

Looks fine. On 20/09/2018 01:04, Vikrant Agarwal wrote: Hi All, Please review this new test for SwingSet3 FileChooserDemo: Task: https://bugs.openjdk.java.net/browse/JDK-8210910 Webrev: http://cr.openjdk.java.net/~vagarwal/8210910/webrev.0/

Re: [12] RFR [TEST][JDK-8210994] Create test for SwingSet3 FrameDemo

Looks fine. On 21/09/2018 00:23, Muneer Kolarkunnu wrote: Hi All, Please review the following, a new client sanity test case: Task: https://bugs.openjdk.java.net/browse/JDK-8210994 Webrev Link:http://cr.openjdk.java.net/~akolarkunnu/8210994/webrev.00/

Re: [12] RFR [TEST][JDK-8210055] Enable different look and feel tests in SwingSet3 demo tests

Looks fine. On 24/09/2018 02:13, Muneer Kolarkunnu wrote: Gentle Reminder. Regards, Muneer *From:* Muneer Kolarkunnu *Sent:* Tuesday, September 18, 2018 3:08 PM *To:* Sergey Bylokhov ; [email protected] *Cc:* Aleksandre Iline *Subject:* Re: [12] RFR [TEST][JDK-8210055] Enable

Re: RFR; 8211031: Remove un-needed qualified export to java.desktop from java.base on macos

Hi, Phil. On 21/09/2018 22:24, Philip Race wrote: [*] at this exact moment, cr.openjdk.java.net isn't working but hopefully that will be fixed by the time anyone reads this :-) The classExists() method still there in version .1 -- Best regards, Sergey.

Re: RFR; 8211031: Remove un-needed qualified export to java.desktop from java.base on macos

Looks fine. On 26/09/2018 14:07, Phil Race wrote: Not 100% sure what happened there. I've re-uploaded it. Shift-reload to avoid browser caching and look again. -phil. On 09/26/2018 01:51 PM, Sergey Bylokhov wrote: Hi, Phil. On 21/09/2018 22:24, Philip Race wrote: [*] at this exact m

Re: [12] JDK-6821316:comment in source code of SynthStyleFactory.java has a self-reference

Looks fine. On 28/09/2018 03:07, Prasanta Sadhukhan wrote: Hi All, Please review another doc-fix where self reference is made in SynthSyleFactory diff -r d96a607e9594 src/java.desktop/share/classes/javax/swing/plaf/synth/SynthStyleFactory.java --- a/src/java.desktop/share/classes/javax/s

Re: [12] RFR JDK-6994403:Grammatical error in documentation of javax.swing.GroupLayout.ParallelGroup

Looks fine. On 28/09/2018 01:58, Prasanta Sadhukhan wrote: Hi All, Please review another doc fix where "its" is misspelt as "it's". Correct string should be as written in file copyright itself, "Copyright (c) 2006, 2015, Oracle and/or *its* affiliates" diff -r b5afdf0bbd9e src/java.desktop

Re: [12] JDK-8061359: [macosx] Checkbox toggles on Space press but does not spoken by Voice Over

Hi, Shashi. It looks like this line is not necessary; "if(ptr != 0) {" The prt is checked at the beginning of this method. On 01/10/2018 02:54, Shashidhara Veerabhadraiah wrote: Hi All, Please review a fix for an accessibility bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8061359 Webrev:

[12] Review Request: 8210739 Calling JSpinner's setFont with null throws NullPointerException

Hello. Please review the fix for jdk 12. This change updates the implementation of JDK-6421058, JDK-5036022 and JDK-8205144. The goal of those changes were to use the font of the JSpinner in textComponent(which is used inside the JSpinner). But the NPE may occur when the user sets the font of

Re: [11] RFR [JDK-8211160] Handle different look and feels in JInternalFrameOperator

Looks fine, I assume that the fix is for jdk12 not jdk11. On 01/10/2018 01:28, Muneer Kolarkunnu wrote: Gentle Reminder. Regards, Muneer *From:* Muneer Kolarkunnu *Sent:* Thursday, September 27, 2018 6:37 AM *To:* [email protected] *Cc:* Aleksandre Iline *Subject:* [11] RFR [JDK-82

Re: [12] RFR [JDK-8211139] Increase timeout value in all tests under jdk/sanity/client/SwingSet/src

Looks fine. On 03/10/2018 07:55, Muneer Kolarkunnu wrote: Hi All, Please review fix for the below task: Bug: https://bugs.openjdk.java.net/browse/JDK-8211139 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8211139/webrev.00/ De

Re: [12] RFR [TEST][JDK-8209499] Create test for SwingSet3 EditorPaneDemo

.01/ Regards, Muneer -Original Message- From: Alexandre (Shura) Iline Sent: Thursday, August 30, 2018 10:45 PM To: Sergey Bylokhov Cc: Muneer Kolarkunnu ; [email protected] Subject: Re: [12] RFR [TEST][JDK-8209499] Create test for SwingSet3 EditorPaneDemo Thank you - makes

Re: [12] Review Request: 8133713 [macosx] Accessible JTables always reported as empty

tp://cr.openjdk.java.net/~serb/8133713/webrev.01 -phil. On 8/29/18, 3:03 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk12. Bug: https://bugs.openjdk.java.net/browse/JDK-8133713 Webrev: http://cr.openjdk.java.net/~serb/8133713/webrev.00 This fix provides the minimal support o

Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

v05/> Thanks, Krishna *From:*Krishna Addepalli *Sent:* Monday, September 17, 2018 10:44 PM *To:* Sergey Bylokhov *Cc:* [email protected] *Subject:* Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9 Hi Sergey, Thanks for checking on Mac. I realised that there

Re: [12] RFR JDK-8211703: JInternalFrame : java.lang.AssertionError: cannot find the internal frame

Hi, Prasanta. Can you please clarify this code a little bit. As far as I understand this method should return the JInternalFrame, which should be accessed via the comp passed to this method. This method already has this check: if (comp.getParent() instanceof BasicInternalFrameTitlePane)

Re: [12] RFR JDK-8211703: JInternalFrame : java.lang.AssertionError: cannot find the internal frame

ed there is any failure if we run the without esa, so I have only done away with the wrong assertion for BasicInternalFrameTitlePane. Regards Prasanta On 04-Oct-18 9:43 PM, Sergey Bylokhov wrote: Hi, Prasanta. Can you please clarify this code a little bit. As far as I understand this method sh

Re: [12] JDK-8061359: [macosx] Checkbox toggles on Space press but does not spoken by Voice Over

Looks fine. On 01/10/2018 21:54, [email protected] wrote: Hi Sergey, Thanks for your review and here is the updated webrev: http://cr.openjdk.java.net/~sveerabhadra/8061359/webrev.01/ Thanks and regards, Shashi On 02/10/18 1:14 AM, Sergey Bylokhov wrote: Hi, Shashi. It

  1   2   3   4   5   6   7   8   9   10   >