cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java

2003-01-21 Thread costin
costin 2003/01/21 11:44:42 Modified:jasper2/src/share/org/apache/jasper JspC.java Log: Support for packages in precompiled servlets - otherwise all go to the same package and we get conflicts. Revision ChangesPath 1.21 +8 -5 jakarta-tomcat-jasper/jasper2

Jasper, JMX and JSR77

2003-01-21 Thread Costin Manolache
I'm alone :-) ? Costin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

RE: Tomcat 5 target JDK1.4?

2003-01-21 Thread Costin Manolache
ace them ). Find who uses or implements something. I only used vi 12 years, and emacs for about 7 - but I don't think I can turn back. ( eclipse looks nice, but it needs real key customization. Netbeans is even nicer - but too slow for my laptop ) Costin -- To unsubscribe, e-mail: <mailto:[EM

Re: Tomcat 5 target JDK1.4?

2003-01-21 Thread Costin Manolache
I use Idea. I should start learning vi :-) ( well, I do use emacs and vi a lot - but not for java, so I may still have a chance ... ) Costin Glenn Nielsen wrote: > This is off topic, but I do the same. > > Glenn > > Shapira, Yoav wrote: >> Howdy, >> >> >

Re: Tag reuse performance [Was: Re: DO NOT REPLY [Bug 16001] - Tag.release() not invoked]

2003-01-20 Thread Costin Manolache
Hans Bergsten wrote: > Costin Manolache wrote: >> [...] >> In an ideal world, all "core" tags would be recyclable and garbage-free - >> that may allow them to run at comparable speed with a hard-coded page. > > I think it's more important to implement

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session ManagerBase.java

2003-01-20 Thread costin
costin 2003/01/20 16:43:18 Modified:catalina/src/share/org/apache/catalina/session ManagerBase.java Log: Let the manager know its name. Revision ChangesPath 1.13 +35 -2 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ValveBase.java

2003-01-20 Thread costin
costin 2003/01/20 16:42:42 Modified:catalina/src/share/org/apache/catalina/valves ValveBase.java Log: Let the mbean know its name. Revision ChangesPath 1.2 +38 -5 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ValveBase.java Index

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core NamingContextListener.java

2003-01-20 Thread costin
costin 2003/01/20 16:38:27 Modified:catalina/src/share/org/apache/catalina/core NamingContextListener.java Log: Remove unused imports, convert to c-l. Revision ChangesPath 1.2 +18 -19 jakarta-tomcat-catalina/catalina/src/share/org

cvs commit: jakarta-tomcat-5 build.xml

2003-01-20 Thread costin
costin 2003/01/20 16:26:09 Modified:.build.xml Log: Added back some of the changes - precompile jsps in admin, generate .ser form for mbean descriptors, speed up compilation. Revision ChangesPath 1.66 +89 -1 jakarta-tomcat-5/build.xml Index

cvs commit: jakarta-tomcat-5 build.xml

2003-01-20 Thread costin
costin 2003/01/20 16:18:26 Modified:.build.xml Log: Few changes in the fast build targets. Revision ChangesPath 1.65 +7 -4 jakarta-tomcat-5/build.xml Index: build.xml === RCS file

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java

2003-01-20 Thread costin
costin 2003/01/20 16:17:11 Modified:util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java Log: Remove the dependency on JMX. ThreadPoolMX will be wrapped in a model mbean - but it doesn't need to depend on JMX. Revision Ch

Tag Pooling ( was: Re: DO NOT REPLY [Bug 16001] - Tag.release() not invoked

2003-01-20 Thread Costin Manolache
a different context ). > Of the four designs above I think the Global Thread Local design may be > the best. It removes the need for synchronized get/reuse and has a smaller > memory footprint than the Per JSP Page tag pool design. +1 for Context Thread Local ( eventually combined with some expiration strategy ). Costin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

cvs commit: jakarta-tomcat-connectors/jk build.xml

2003-01-20 Thread costin
costin 2003/01/20 15:57:58 Modified:jk build.xml Log: Move the paths higher, so jar target can be called directly. Exclude ajp connector for tomcat5. Revision ChangesPath 1.63 +42 -33jakarta-tomcat-connectors/jk/build.xml Index: build.xml

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java JkMain.java

2003-01-20 Thread costin
costin 2003/01/20 15:48:40 Modified:jk/java/org/apache/jk/common HandlerRequest.java jk/java/org/apache/jk/server JkCoyoteHandler.java JkMain.java Log: Few updates for RequestInfo. Revision ChangesPath 1.22 +13 -2 jakarta

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java

2003-01-20 Thread costin
costin 2003/01/20 15:47:05 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java Log: Update for RequestInfo and new group info. Revision ChangesPath 1.57 +1 -0 jakarta-tomcat-connectors/http11/src

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Request.java

2003-01-20 Thread costin
costin 2003/01/20 15:45:11 Modified:coyote/src/java/org/apache/coyote Request.java Log: Update RequestInfo. Add a new field - start time. It's very usefull - it can be used in many places to avoid calling System.currentTimeMillis(). Revision ChangesPath

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote RequestGroupInfo.java

2003-01-20 Thread costin
costin 2003/01/20 15:43:41 Added: coyote/src/java/org/apache/coyote RequestGroupInfo.java Log: Group info - agregate the data from all requests. Implement collection for the time data. Revision ChangesPath 1.1 jakarta-tomcat-connectors/coyote

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote RequestInfo.java RequestProcessor.java

2003-01-20 Thread costin
costin 2003/01/20 15:42:45 Added: coyote/src/java/org/apache/coyote RequestInfo.java Removed: coyote/src/java/org/apache/coyote RequestProcessor.java Log: Better name. Revision ChangesPath 1.1 jakarta-tomcat-connectors/coyote/src/java/org

Re: Tag reuse performance [Was: Re: DO NOT REPLY [Bug 16001] - Tag.release() not invoked]

2003-01-20 Thread Costin Manolache
nk the number of tags in a page is too important - even if you have 1 complex tag - with 100 concurent users - you should see a difference. In an ideal world, all "core" tags would be recyclable and garbage-free - that may allow them to run at comparable speed with a hard-coded page

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java

2003-01-20 Thread costin
costin 2003/01/20 11:20:32 Modified:jk/java/org/apache/jk/common ChannelSocket.java HandlerDispatch.java JkMX.java MsgAjp.java jk/java/org/apache/jk/server JkCoyoteHandler.java Log: Remove unused imports, add/fix comments. JkMX will only

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util CookieTools.java

2003-01-20 Thread costin
costin 2003/01/20 10:38:50 Modified:catalina/src/share/org/apache/catalina/util CookieTools.java Log: Add an extra space after ; in cookies. This avoids problems with some IE/Mac versions, and makes the cookies closer to the examples in the spec ( which include the space

RE: Why unpackWars=true default?

2003-01-20 Thread Costin Manolache
is running programs directly from the RPM or from inside the uninstalled install shield application. I would be pretty happy if packed wars will be deprecated or strongly discouraged in 5.0 - but strongly -1 on changing the default. Costin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Re: Tomcat 5 target JDK1.4?

2003-01-20 Thread Costin Manolache
. Production servers usually preffer more tested and stable VMs. Some people may also preffer an open-source VM ( kaffe, GCJ, etc ). Costin > Even now, TC4 is run on JDK1.4. > There is JDK 1.5 coming up, we would be one back. > > We do need to move ahead, and clean up the import so tha

Re: Tag reuse performance [Was: Re: DO NOT REPLY [Bug 16001] - Tag.release() not invoked]

2003-01-19 Thread Costin Manolache
tart, thanks for bringing this up. > > I hope it at least gives us a better idea about what types of gains > we can realistically expect from tag handler reuse. Most of the improvements in coyote ( or in 3.3 over 3.2 ) are due to object reuse. It is possible that tag handlers are diffe

Re: Tag reuse performance [Was: Re: DO NOT REPLY [Bug 16001] - Tag.release() not invoked]

2003-01-19 Thread Costin Manolache
arm up and 10.000 to run the test. This is a very good start, thanks for bringing this up. Costin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Re: DO NOT REPLY [Bug 16001] - Tag.release() not invoked

2003-01-18 Thread Costin Manolache
- with some conditionals and Class.forName() it can be done. It would be a pretty good idea to have jasper use tomcat-util buffers directly - as you know, I believe that would be a huge speedup. Costin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Re: DO NOT REPLY [Bug 16001] - Tag.release() not invoked

2003-01-18 Thread Costin Manolache
I attached a first draft, I'll enhance it later ( it could use ThreadWithAttributes - to save one extra hashtable lookup ). Let me know if it helps. Costin package org.apache.jasper.runtime; import javax.servlet.jsp.JspException; import javax.servlet.jsp.tagext.Tag; import org.apache.

Re: [VOTE] Branch j-t-c for Tomcat 5

2003-01-18 Thread Costin Manolache
branched, it should be possible to use either branch in any tomcat - if you have JMX, you can use HEAD with 3.3 or 4.1. Costin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Re: [VOTE] Branch j-t-c for Tomcat 5

2003-01-17 Thread Costin Manolache
the idea of branching > We can branch at tomcat_4_19 tag - that's the simplest solution. Sorry for the mess - but I think the benefits of knowing what happens inside tomcat are worth the extra dependencies and some temporary build problems ( and an extra branch ). Costin -- To unsubscri

Re: DO NOT REPLY [Bug 16001] - Tag.release() not invoked

2003-01-17 Thread Costin Manolache
ation - it is a problem with the tagpool implementation, not an indication that creating tons of garbage is good. You can make the whole tag reuse be sync-free, and have the entire page served without any allocation - just create the tags once, at init time - and keep them in a per/thread data. Costin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Cookies, space and MSIE

2003-01-17 Thread Costin Manolache
kport this to 4.1 ( and 4.0 ) ? I made the change in 5.0, and did the tests with a patched 4.1. The problem is: Path=/foo;Secure -> fails Path=/foo; Secure -> works The examples in the Netscape specification of the Cookie include space after ; - and don't explicitely say the space is op

Re: DO NOT REPLY [Bug 16001] - Tag.release() not invoked

2003-01-17 Thread Costin Manolache
is not worht the trouble for very low loads ). But I'm happy to hear that I'm wrong. Costin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Re: [5.0] Return of the CL bug

2003-01-17 Thread Costin Manolache
My +1 to remove the "endorsed". There is no need to use a different version of javax.xml or org.w3c.dom or org.xml - and if someone needs a different one, he can use JDK1.3 or file a bug report on Sun site. Costin Remy Maucherat wrote: > This one looks similar to the CL problems wit

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util CookieTools.java

2003-01-17 Thread costin
costin 2003/01/16 21:55:41 Modified:catalina/src/share/org/apache/catalina/util CookieTools.java Log: I am not very sure this is the right fix - but from the spec it seems to be ok. It seems some browsers ( some versions of IE on Mac ) have trouble parsing the cookie in

cvs commit: jakarta-tomcat-5/resources mbeans.xml

2003-01-16 Thread costin
costin 2003/01/16 15:16:12 Modified:resources mbeans.xml Log: Few changes. Starting and controlling tomcat5 from ant works pretty nice - but dynamic add/remove mbeans is not implemented. That's the main method I use to run tomcat5 - about 20sec startup time (

cvs commit: jakarta-tomcat-5 build.xml

2003-01-16 Thread costin
costin 2003/01/16 15:14:02 Modified:.build.xml Log: Few more improvments to the "fast" build: - more consistent names, - description so it is picked by -projecthelp and completion - don't detect tomcat5 and build stuff we don't need. Added

cvs commit: jakarta-tomcat-connectors/coyote build.xml

2003-01-16 Thread costin
costin 2003/01/16 14:31:01 Modified:coyote build.xml Log: Add commons-modeler. Revision ChangesPath 1.19 +5 -1 jakarta-tomcat-connectors/coyote/build.xml Index: build.xml === RCS file

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java

2003-01-16 Thread costin
costin 2003/01/16 14:29:52 Modified:http11 build.xml http11/src/java/org/apache/coyote/http11 Http11Processor.java Http11Protocol.java Log: Same thing as in jk - threads and request processors are registered in JMX (if coyote itself is

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/core MsgContext.java

2003-01-16 Thread costin
costin 2003/01/16 14:18:55 Modified:jk/java/org/apache/jk/core MsgContext.java Log: Store a "control" object, for guard-based access control Revision ChangesPath 1.6 +12 -1 jakarta-tomcat-connectors/jk/java/org/apache/jk/core/MsgContext.java

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java JkMain.java

2003-01-16 Thread costin
costin 2003/01/16 14:17:37 Modified:jk/java/org/apache/jk/server JkCoyoteHandler.java JkMain.java Log: When the coyote handler is registered ( by the Connector or other method ), it'll also register JkMain. JkMain will register all handlers as m

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/core JkHandler.java

2003-01-16 Thread costin
costin 2003/01/16 14:15:05 Modified:jk/java/org/apache/jk/core JkHandler.java Log: Let the handlers know their names. A handler is a notification listener - right now the method is not implemented, but will eventually call ( or replace ) invoke. Revision Changes

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/common HandlerRequest.java ChannelSocket.java

2003-01-16 Thread costin
costin 2003/01/16 14:13:37 Modified:jk/java/org/apache/jk/common HandlerRequest.java ChannelSocket.java Log: Add JMX info. The thread pool will be registered, as well as RequestProcessor. For each request we'll save in the thread pool attribute

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5 CoyoteAdapter.java CoyoteConnector.java

2003-01-16 Thread costin
costin 2003/01/16 13:58:15 Modified:coyote/src/java/org/apache/coyote/tomcat5 CoyoteAdapter.java CoyoteConnector.java Log: Removed unused imports. Let the coyote connector know its name. Register the protocol adapter with JMX, so it can know its

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote RequestProcessor.java Request.java Response.java

2003-01-16 Thread costin
costin 2003/01/16 13:56:02 Modified:coyote/src/java/org/apache/coyote Request.java Response.java Added: coyote/src/java/org/apache/coyote RequestProcessor.java Log: Collect data about incoming/outgoing traffic, other per/request statistics. To avoid sync and keep

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup LocalStrings.properties

2003-01-16 Thread costin
costin 2003/01/16 13:45:25 Modified:catalina/src/share/org/apache/catalina/startup LocalStrings.properties Log: Part 2 of messages change. If the tld can't be read, it helps to know what context has the problem. Revision ChangesPath

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup ContextConfig.java

2003-01-16 Thread costin
costin 2003/01/16 13:44:18 Modified:catalina/src/share/org/apache/catalina/startup ContextConfig.java Log: Better messages ( I hope ) Revision ChangesPath 1.17 +10 -13 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java

2003-01-16 Thread costin
costin 2003/01/16 13:41:45 Modified:catalina/src/share/org/apache/catalina/core StandardWrapper.java Log: The servlet wrapper will register itself using the JSR77 name. The app and server name are taken from the context. The load time, processing time

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

2003-01-16 Thread costin
costin 2003/01/16 13:38:25 Modified:catalina/src/share/org/apache/catalina/core StandardContext.java Log: - remove unused imports - converted to commons-logging - Implement the JSR77 "servlets" attribute ( required for WebModule ) -

cvs commit: jakarta-tomcat-catalina/catalina build.xml

2003-01-16 Thread costin
costin 2003/01/16 12:58:24 Modified:catalina build.xml Log: Split the build in 2 parts. One is "required", with no external dependencies ( except JAAS and JMX ). Also added fileupload check - probably it needs to be added to download too. Revision Chang

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapperValve.java

2003-01-14 Thread costin
costin 2003/01/14 16:19:16 Modified:catalina/src/share/org/apache/catalina/core StandardWrapperValve.java Log: Collect information about processing time, errors, requestCounts. Revision ChangesPath 1.8 +52 -5 jakarta-tomcat-catalina

Re: PROPOSAL/VOTE: JMX hook mechanism

2003-01-14 Thread Costin Manolache
ecome very complicated. You know my opinion on this - if you don't run the sandbox, user code can control the VM without problems ( with some JNI code - or introspection, or by overriding files ). If you run sandbox - the JMX1.2 policy-based access control should be good enough. Costin

Re: PROPOSAL/VOTE: JMX hook mechanism

2003-01-14 Thread Costin Manolache
the dependency to JMX. Time for a branch... Should I do the changes in a branch, or branch the current stable code and make changes in HEAD ? >> I posted some more notes on my weblog ( which I just started few days ago >> ), and I'll update it with more details. >> Se

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java

2003-01-14 Thread costin
costin 2003/01/14 10:47:39 Modified:util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java Log: Pass the domain. ThreadPools should be registered in the same domain with all catalina mbeans. Revision ChangesPath 1.9

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote BaseHook.java

2003-01-14 Thread costin
costin 2003/01/14 10:46:25 Removed: coyote/src/java/org/apache/coyote BaseHook.java Log: Rollback... A much better solution is to just use plain NotificationListener, without any tomcat/coyote/jk-specific modifications. All JK and coyote hooks ( "extension p

PROPOSAL/VOTE: JMX hook mechanism

2003-01-14 Thread Costin Manolache
nterested to help doing it. I posted some more notes on my weblog ( which I just started few days ago ), and I'll update it with more details. See http://www.webweavertech.com/costin/weblog/index.html and http://www.webweavertech.com/costin/archives/000152.html ( I'm just getting starte

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler PageDataImpl.java

2003-01-13 Thread costin
costin 2003/01/13 14:08:58 Modified:jasper2/src/share/org/apache/jasper/compiler PageDataImpl.java Log: NPE with empty files Revision ChangesPath 1.20 +4 -3 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler

ServletException and JDK1.4

2003-01-13 Thread Costin Manolache
Could we change the ServletException class to pass up the Throwable ? This way JDK1.4 getCause() and the better stack trace would work. Costin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Re: [JMX hooks/handler] was Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote BaseHook.java

2003-01-13 Thread Costin Manolache
ded notes and an int notification >>code for faster dispatch ). >> > What about using the setUserData/getUserData for doing that? I think "userData" should hold the Request or something like that. Notification is a base class, just like Event. It is perfectly fine to e

Re: jdk support in Tomcat 5

2003-01-13 Thread Costin Manolache
ld tomcat ). If possible, it would be nice to also have fallback code - i.e. code that works ( slower ) on JDK1.3. Costin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Re: Any idea about jakarta-modeler module?

2003-01-12 Thread Costin Manolache
Try build it from sources. Things will stabilize shortly ( I hope ) Costin Dhurandhar Bhatwadekar wrote: > I am trying to build the tomcat with first downloading > the other components. (in jakarta-tomcat-4.0, run ant > download.) > My problem is as follows: > jakarta-to

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java

2003-01-12 Thread costin
costin 2003/01/12 11:07:07 Modified:util/java/org/apache/tomcat/util/threads ThreadPool.java ThreadPoolMX.java Log: Few more changes ( on the new jmx code ). Old code will continue to use the normal pool, new code can get a JMX pool if JMX is available

cvs commit: jakarta-tomcat-connectors/util build.xml

2003-01-12 Thread costin
costin 2003/01/12 11:01:58 Modified:util build.xml Log: Conditional compilation for ThreadPoolMX Revision ChangesPath 1.16 +4 -0 jakarta-tomcat-connectors/util/build.xml Index: build.xml

Re: Duplicate session IDs are *common*[GFI-T105-3E21F8D3D7B6FFDE]

2003-01-12 Thread Costin Manolache
hronization you may get the same result ( if the seed wasn't updated ). I did check the code and it looks ok - plenty of synchronized() blocks. But who knows ? Costin Phil Steitz wrote: > Using a modified version of Tim Funk's "Collide.java", I ran the > following

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote BaseHook.java

2003-01-10 Thread costin
costin 2003/01/10 23:08:33 Modified:coyote/src/java/org/apache/coyote BaseHook.java Log: Added NotificationListener. JMX notifications are not as flexible - I really don't know what is the best solution here. Less flexibility might be very good - it can keep things si

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java

2003-01-10 Thread costin
costin 2003/01/10 22:55:24 Modified:util/java/org/apache/tomcat/util/threads ThreadPool.java Log: Update ThreadPool. Revision ChangesPath 1.7 +20 -51 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPool.java Index: ThreadPool.java

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadWithAttributes.java

2003-01-10 Thread costin
costin 2003/01/10 22:53:43 Added: util/java/org/apache/tomcat/util/threads ThreadWithAttributes.java Log: Moved ThreadWithAttribute out of ThreadPool. All attribute operations are guarded by ThreadPool - if an application has a reference to

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPoolMX.java

2003-01-10 Thread costin
costin 2003/01/10 22:52:27 Added: util/java/org/apache/tomcat/util/threads ThreadPoolMX.java Log: Added a "JMX" extension to threadpool. This will keep the ThreadPool independent of JMX. Also added few "informative" methods to display the threads

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote BaseHook.java

2003-01-10 Thread Costin Manolache
Bill Barker wrote: >> Jeanfrancois Arcand wrote: >> >> > Hi Costin, (you beat me on the proposal :-) ) >> >> Actually - this is a different story ( JMX-enabling different componets). >> I'll check in similar additions to ValveBase, BaseContainer,

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves AccessLogValve.java

2003-01-10 Thread costin
costin 2003/01/10 21:12:48 Modified:catalina/src/share/org/apache/catalina/valves AccessLogValve.java Log: I did that long ago - it just add %D to display the time in millis ( like in apache ) Usefull for people with fast servlets :-) Revision

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ContainerBase.java

2003-01-10 Thread costin
costin 2003/01/10 21:07:50 Modified:catalina/src/share/org/apache/catalina/core ContainerBase.java Log: Let ContainerBase know its own name ( and domain ) We can't change the Container interface ( that would break backward compat ), but there

JSR77 names for Context ( and ServletWrapper )

2003-01-10 Thread Costin Manolache
separated from each other. Not sure if the /admin is using the domain somehere. Opinions ? Anyone willing to help ? Costin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote BaseHook.java

2003-01-10 Thread Costin Manolache
Jeanfrancois Arcand wrote: > Hi Costin, (you beat me on the proposal :-) ) Actually - this is a different story ( JMX-enabling different componets). I'll check in similar additions to ValveBase, BaseContainer, CoyoteConnector. The idea is for each component to be aware of its name an

cvs commit: jakarta-tomcat-connectors gump.xml

2003-01-10 Thread costin
costin 2003/01/10 16:05:10 Modified:.gump.xml Log: Add jmx deps in gump. Revision ChangesPath 1.10 +23 -1 jakarta-tomcat-connectors/gump.xml Index: gump.xml === RCS file: /home/cvs

cvs commit: jakarta-tomcat-connectors/coyote build.xml

2003-01-10 Thread costin
costin 2003/01/10 16:03:01 Modified:coyote build.xml Log: Add the jmx dependency. Add a separate target that just builds for tomcat5, to avoid all the detection. Revision ChangesPath 1.16 +12 -1 jakarta-tomcat-connectors/coyote/build.xml Index

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote BaseHook.java

2003-01-10 Thread costin
costin 2003/01/10 14:36:43 Added: coyote/src/java/org/apache/coyote BaseHook.java Log: Added a base implementation of ActionHook - with some small additions :-) First, there is a getNext/setNext to allow multiple hooks to be chained. Both recursive and iterative will be

Re: Duplicate session IDs are *common*

2003-01-10 Thread Costin Manolache
amazing that 2 people reported beeing hit by meteors (duplicate session ids ) in the same week. You're right - a counter is better than time. It'll duplicate the counter if tomcat is restarted - so probably the initial value of the counter should be random or derived from time. Costi

Re: Duplicate session IDs are *common*

2003-01-10 Thread Costin Manolache
ver a > time scale far in excess of the time scale that is interesting. Adding the startup time doesn't hurt. Or enough bits of the startup time to guarantee a duplicate won't happen in our life. We'll still have the probability that 2 random number generated at the same time ( same millis ) will be identical. :-) Costin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Re: Duplicate session IDs are *common*

2003-01-10 Thread Costin Manolache
included in it ( that may be used for other purpose eventually ). Costin Glenn Olander wrote: > Here's a follow-up on the bug report I submitted that started this thread. > > 1) We confirmed the problem is a duplicate session id. > > Luckily we were logging session id&

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loader WebappLoader.java

2003-01-10 Thread costin
costin 2003/01/10 10:59:50 Modified:catalina/src/share/org/apache/catalina/loader WebappLoader.java Log: Some info for the jmx console. It's nice to see the repositories. It would also be nice to have a method to display info about how a class

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans GlobalResourcesLifecycleListener.java

2003-01-10 Thread costin
costin 2003/01/10 10:57:06 Modified:catalina/src/share/org/apache/catalina/mbeans GlobalResourcesLifecycleListener.java Log: If no java: naming is found - report it but don't be too verbose. Revision ChangesPath 1.2 +6 -7 ja

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans ServerLifecycleListener.java

2003-01-10 Thread costin
costin 2003/01/10 10:55:58 Modified:catalina/src/share/org/apache/catalina/mbeans ServerLifecycleListener.java Log: Use commons-logging. Most of the code here should disapear as we add it in the core objects ( remember - we voted that 5.0 will require and

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup Catalina.java

2003-01-10 Thread costin
costin 2003/01/10 10:48:49 Modified:catalina/src/share/org/apache/catalina/startup Catalina.java Log: Some versions of digester ( head ? ) seem to require the classloader to be set. It doesn't hurt to set it explicitely. Revision ChangesPath 1.12

RE: Duplicate session IDs are *common*

2003-01-09 Thread Costin Manolache
lion sessions that are active at the same time - if a session expires and the id is reused there is no harm. Costin > > Jeff Schnitzer > > -Original Message- > From: Remy Maucherat > Subject: Re: Duplicate session IDs are *common* > Date: Thu, 09 Jan 2003 02:57:23 -08

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session ManagerBase.java

2003-01-09 Thread costin
costin 2003/01/09 13:15:46 Modified:catalina/src/share/org/apache/catalina/session ManagerBase.java Log: Fix the imports. Hope the tab police won't give me another ticket. Revision ChangesPath 1.12 +7 -3 jakarta-tomcat-cat

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session ManagerBase.java StandardManager.java

2003-01-09 Thread Costin Manolache
I'll fix it. That's what happens when you let a program do the editing for you. Costin Jeanfrancois Arcand wrote: > Hi Costin, > > I was under the impression, as a convention, that we don't import using > * (java.util.*). I find it more easier when all the classes a

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session ManagerBase.java StandardManager.java

2003-01-09 Thread costin
costin 2003/01/09 11:09:33 Modified:catalina/src/share/org/apache/catalina/session ManagerBase.java StandardManager.java Log: Few changes to give more info in the jmx console. Switched StandardManager to c-l. There are still few dozens files that need

Re: Duplicate session IDs are *common*

2003-01-08 Thread Costin Manolache
that would work with 5.0 - but it can be backported ) that allow you to use /dev/urandom ( or another source - it can be a pipe or something like that ). Costin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Re: ClassLoader problems

2003-01-08 Thread Costin Manolache
Once again - debugging it is close to impossible ( just like most classloader problems), but luckily I guessed how to fix it - just remove the "endorsed" property and it works again... What "endorsed dirs" has to do with ActionHook - I don't know. Costin Costin Manol

Re: JMX-RI-1.2 problems

2003-01-08 Thread Costin Manolache
f changes. The build file and changing the [] seems to be all. I'm not sure how to best deal with the download, and I assume few build files or properties need to change. Let me know if you see additional problems - I have it running ( but I have a modified modeler and a lot of other changes

ClassLoader problems

2003-01-08 Thread Costin Manolache
ption few lines down. Any idea ? I get this with 4.1 head and also with 5.0 ( but in 5.0 I may have a strange env - that's why I tested with a clean 4.1 head ) Java is 1.4.1_01-b01 on linux. Costin The exception is: Using CATALINA_BASE: /ws/41/dist Using CATALINA_HOME: /ws/41/

cvs commit: jakarta-tomcat-5/resources mbeans.xml

2003-01-08 Thread costin
costin 2003/01/08 12:09:08 Modified:resources mbeans.xml Log: Moved the jmx starting from catalina.xml ( the one using server.xml ). This part works fine ( well, there are few small fixes that may be needed - and I don't know why naming doesn't seem to work w

JMX-RI-1.2 problems

2003-01-08 Thread Costin Manolache
ow - so we may be able to redistribute it without problems. Obviously MX4J should be preffered for the release. Opinions ? Volunteers :-) ? Costin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

RE: [PATCH] forward instead of redirect for welcome files

2003-01-06 Thread Costin Manolache
Please at least make it optional - with the default beeing the current behavior. Costin Matt Parker wrote: > Here's the new version of the patch. the code to redirect if there is no > trailing slash remains untouched, but it now forwards if there is a > trailing slash. i&#x

Re: Unable to compile class for JSP

2003-01-06 Thread Costin Manolache
ly tested tomcat4.1 with JDK1.4.0-b92 on w2k and xp ) Costin > > -- Jeanfrancois > > Costin Manolache wrote: > >>Just had the same problem - it seems JDK1.4 on windows has an interesting >>behavior - it will not load javac from tools.jar unless it is included in >&

RE: Unable to compile class for JSP

2003-01-06 Thread Costin Manolache
0-b92. Costin Gary Pollreis wrote: > will do - thanks for the heads up. > > -Original Message- > From: Matt Parker [mailto:[EMAIL PROTECTED]] > Sent: Monday, January 06, 2003 5:57 PM > To: Tomcat Developers List > Subject: Re: Unable to compile class for JSP > >

Re: [PATCH] forward instead of redirect for welcome files

2003-01-06 Thread Costin Manolache
rect should remain the default. But please verify that anchors work, including cases where the welcome file is in another directory. Costin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Re: [PATCH] forward instead of redirect for welcome files

2003-01-06 Thread Costin Manolache
to the Tomcat team (I guess I don't > have a choice :) If I remember corectly - this was how the first implementation of welcome files worked ( long, long ago ). After several strange bugs it changed to do redirects. Tomcat3.3 has an option - useInternal - that will change the behavior (

Re: [PATCH] forward instead of redirect for welcome files

2003-01-06 Thread Costin Manolache
have foo/index.html, etc ( i.e. things in other dirs ). That means #anchors would break if we don't do redirect. A second reason for doing redirects: a redirect will let the web server handle the file serving ( if the index.html is a static file - or some resource that apache can handle ). A third reason: it's safer :-) Costin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Re: cvs commit: jakarta-tomcat-5/resources mbeans.xml

2003-01-06 Thread Costin Manolache
Remy Maucherat wrote: > [EMAIL PROTECTED] wrote: >> costin 2003/01/05 22:09:47 >> >> Added: resources mbeans.xml >> Log: >> A small test file for the 'jmx-ified' config / profile. >> >> Each component will be defi

Re: cvs commit: jakarta-tomcat-5/resources mbeans.xml

2003-01-06 Thread Costin Manolache
Remy Maucherat wrote: > [EMAIL PROTECTED] wrote: >> costin 2003/01/05 22:09:47 >> >> Added: resources mbeans.xml >> Log: >> A small test file for the 'jmx-ified' config / profile. >> >> Each component will be defi

<    3   4   5   6   7   8   9   10   11   12   >