Re: [vdsm] pylint in make check-local

2014-02-17 Thread Ewoud Kohl van Wijngaarden
On Mon, Feb 17, 2014 at 01:11:41PM +, Dan Kenigsberg wrote: > On Mon, Feb 17, 2014 at 01:21:11PM +0100, Ewoud Kohl van Wijngaarden wrote: > > On Mon, Feb 17, 2014 at 11:44:37AM +, Dan Kenigsberg wrote: > > > While I'm waiting for more acks/nacks, could in

Re: [vdsm] pylint in make check-local

2014-02-17 Thread Ewoud Kohl van Wijngaarden
On Mon, Feb 17, 2014 at 11:44:37AM +, Dan Kenigsberg wrote: > While I'm waiting for more acks/nacks, could infra add "pylint" to our > Jenkins slaves? Is the version in EL6 recent enough or do we have to ship our own version? (EL6 is 0.21.1) Please review http://gerrit.ovirt.org/24556 ___

Re: [vdsm] Failing puppet runs due to python-cpopen

2013-11-20 Thread Ewoud Kohl van Wijngaarden
On Wed, Nov 20, 2013 at 01:04:26PM -0500, Nir Soffer wrote: > - Original Message - > > From: "Ewoud Kohl van Wijngaarden" > > To: "Nir Soffer" > > Sent: Wednesday, November 20, 2013 7:55:30 PM > > Subject: Re: Failing puppet runs due to py

[vdsm] Failing puppet runs due to python-cpopen

2013-11-20 Thread Ewoud Kohl van Wijngaarden
Hello all, Currently we attempt to install python-cpopen, but puppet fails to do this. When I manually run it: [root@jenkins-slave-vm01 ~]# yum install python-cpopen Loaded plugins: versionlock Resolving Dependencies --> Running transaction check ---> Package python-cpopen.x86_64 0:1.2.3-2.fc19 w

Re: [vdsm] [Users] Low quality of el6 vdsm rpms

2013-11-12 Thread Ewoud Kohl van Wijngaarden
On Tue, Nov 12, 2013 at 02:33:44PM +, Dan Kenigsberg wrote: > On Tue, Nov 12, 2013 at 11:31:04AM +0100, Sandro Bonazzola wrote: > > Il 12/11/2013 10:34, Patrick Hurrelmann ha scritto: > > > - How can the quality of the vdsm builds be increased? It is frustrating > > > to spend time on testing a

[vdsm] Errors installing python-cpopen on jenkins slaves

2013-10-16 Thread Ewoud Kohl van Wijngaarden
Hello all, On our jenkins slaves we installed python-cpopen and it shows a bunch of conflicts. I think it misses an obsoletes vdsm-python-cpopen in the spec file. Output I see from puppet: change from absent to present failed: Execution of '/usr/bin/yum -d 0 -e 0 -y install python-cpopen' retur

Re: [vdsm] stale gerrit patches

2013-10-09 Thread Ewoud Kohl van Wijngaarden
On Wed, Oct 09, 2013 at 06:16:09AM -0400, David Caro Estevez wrote: > > > - Original Message - > > From: "Dave Neary" > > To: "Itamar Heim" > > Cc: "engine-devel" , > > vdsm-devel@lists.fedorahosted.org > > Sent: Wednesday, October 9, 2013 12:07:45 PM > > Subject: Re: [vdsm] stale gerr

Re: [vdsm] Keeping VDSM Compatible with Ubuntu

2013-09-27 Thread Ewoud Kohl van Wijngaarden
On Fri, Sep 27, 2013 at 03:53:08PM +0800, Zhou Zheng Sheng wrote: > Recently we merged some patches to make VDSM run on Ubuntu. We also have > some packaging scripts in the debian/ sub-dir. You can either build .deb > packages manually or find binary packages from VDSM PPA [1] on > launchpad.net. O

Re: [vdsm] Nightly builds of vdsm in jenkins need NVR bump

2013-05-19 Thread Ewoud Kohl van Wijngaarden
On Sun, May 19, 2013 at 06:07:07AM -0400, Alon Bar-Lev wrote: > I believe git magic should not be used in source[1] I don't see how git describe is unsuitable for this. From the examples section of the manpage[1]: <

Re: [vdsm] Porting vdsmd.init.in and vdsm.spec.in to Ubuntu

2013-03-20 Thread Ewoud Kohl van Wijngaarden
On Wed, Mar 20, 2013 at 06:00:57PM +0800, Zhou Zheng Sheng wrote: > You can have a look at my modifications to this file at > https://github.com/edwardbadboy/vdsm-ubuntu/commit/0b23299f48c5a341b73f2bb2b3dfdb58e82f5459 I know oVirt isn't using github to develop, but you could fork it from https://g

Re: [vdsm] VDSM - top 10 with patches with no activity for more than 30 days

2013-03-01 Thread Ewoud Kohl van Wijngaarden
On Fri, Mar 01, 2013 at 04:27:33PM +0200, Itamar Heim wrote: > On 01/03/2013 15:58, Adam Litke wrote: > >On Thu, 2013-02-28 at 12:51 -0500, Doron Fediuck wrote: > >>- Original Message - > >>>From: "Itamar Heim" > >>>To: vdsm-devel@lists.fedorahosted.org > >>>Sent: Wednesday, February 20, 2

Re: [vdsm] Pretty printing for vdsClient

2013-02-12 Thread Ewoud Kohl van Wijngaarden
On Tue, Feb 12, 2013 at 10:22:08AM -0500, Antoni Segura Puimedon wrote: > Working with the networking side of vdsm side, I've grown tired of the > looks of the output of vdsClient. Thus, I have submitted a patch: > http://gerrit.ovirt.org/#/c/11979/ > That pretty prints the dictionaries that ar

Re: [vdsm] VDSM Repository Reorganization

2013-02-11 Thread Ewoud Kohl van Wijngaarden
On Mon, Feb 11, 2013 at 12:17:39PM -0500, Federico Simoncelli wrote: > It is some time now that we are discussing an eventual repository > reorganization for vdsm. In fact I'm sure that we all experienced > at least once the discomfort of having several modules scattered > around the tree. > The ma

Re: [vdsm] May I apply for a user account on jenkins.ovirt.org to run VDSM functional tests?

2013-01-29 Thread Ewoud Kohl van Wijngaarden
On Tue, Jan 29, 2013 at 06:15:08AM -0500, Eyal Edri wrote: > - Original Message - > > From: "Zhou Zheng Sheng" > > To: in...@ovirt.org > > Cc: "ShaoHe Feng" > > Sent: Tuesday, January 29, 2013 12:24:27 PM > > Subject: May I apply for a user account on jenkins.ovirt.org to run VDSM > >

Re: [vdsm] Helping ovirt-3.2 run on EL6

2013-01-13 Thread Ewoud Kohl van Wijngaarden
On Sun, Jan 13, 2013 at 03:39:57PM +0200, Dan Kenigsberg wrote: > On Sun, Jan 13, 2013 at 04:40:11PM +0400, Andrey Gordeev wrote: > > On Fri, Jan 11, 2013 at 12:42 AM, Dan Kenigsberg wrote: > > > I've posted http://gerrit.ovirt.org/#/c/10893/ which is taken from a > > > former patchset of yours -

Re: [vdsm] [PEP 8] About configuring editor plugins for checking PEP 8

2012-11-25 Thread Ewoud Kohl van Wijngaarden
On Tue, Nov 13, 2012 at 07:16:33PM +0800, Zhou Zheng Sheng wrote: > In the latest version of pep8 checking tool, the rules are very strict. > Currently the VDSM project applies a less strict rule set by suppressing > some errors from pep8. You can find them at Makefile.am . Under the > "check-local

Re: [vdsm] [RFC]about the implement of text-based console

2012-10-15 Thread Ewoud Kohl van Wijngaarden
On Tue, Oct 16, 2012 at 12:51:23AM +0800, Xu He Jie wrote: > [SNIP] > Hi, Adam, Could you explain more detail about how streaming API can > survive a VM migration? > > If we want to support migration, I think we should implement console > server out of vdsm. > Actually, It will work like proxy. So

Re: [vdsm] [Engine-devel] is gerrit.ovirt.org down?

2012-09-12 Thread Ewoud Kohl van Wijngaarden
In cases like these it's best to mail infra as well, or poke on #ovirt. On Wed, Sep 12, 2012 at 10:52:39AM -0400, Alon Bar-Lev wrote: > > Yes, I am experiencing this too... > > Itamar? > > - Original Message - > > From: "Shu Ming" > > To: "Alon Bar-Lev" > > Cc: "Shireesh Anjal" , engi

Re: [vdsm] [Engine-devel] Jenkins testing.

2012-08-14 Thread Ewoud Kohl van Wijngaarden
On Tue, Aug 14, 2012 at 06:20:11AM -0400, Eyal Edri wrote: > Deepak C Shetty wrote: > > On 08/14/2012 12:52 PM, Deepak C Shetty wrote: > > > On 08/14/2012 11:13 AM, Robert Middleswarth wrote: > > >> After a few false starts it looks like we have per patch testing > > >> working on VDSM, oVirt-engin

Re: [vdsm] Jenkins and Gerrit.

2012-08-08 Thread Ewoud Kohl van Wijngaarden
On Wed, Aug 08, 2012 at 03:48:13PM +0300, Dan Kenigsberg wrote: > On Wed, Aug 08, 2012 at 07:47:02AM -0400, Robert Middleswarth wrote: > > I have setup patch review on Jenkins.info for newly submitted > > patches and it seems to be working pretty well over all but last > > night well tweaking the p

Re: [vdsm] Please Review

2012-08-02 Thread Ewoud Kohl van Wijngaarden
On Wed, Aug 01, 2012 at 03:08:21PM -0400, Saggi Mizrahi wrote: > I have a bunch of patches going stale adding minor improvements: > I would like to get reviews so they get pushed in. > I know they contain code paths that are unused at the moment. > But adding death signal to certain copy operations

Re: [vdsm] Agenda for tomorrow's call

2012-06-29 Thread Ewoud Kohl van Wijngaarden
On Mon, Jun 18, 2012 at 05:24:26PM +0300, Dan Kenigsberg wrote: > Deepack: please review libstorage writeup. Saggi, Adam: will do. > Deepack: is there an irc bot logging #vdsm? No but I'd love if you > configure one ;-) > Deepack to research if there's an available bot to do this. It can b

Re: [vdsm] A Tool for PEP 8 Patches to Find Code Logic Changes

2012-06-11 Thread Ewoud Kohl van Wijngaarden
On Sun, Jun 10, 2012 at 11:15:48AM +0300, Dan Kenigsberg wrote: > On Thu, Jun 07, 2012 at 11:13:14PM +0800, Shu Ming wrote: > > On 2012-6-7 21:26, Adam Litke wrote: > > Yes, I agree with you. Also, we should merge this tool into vdsm as > > a helper for PEP8 clean work. > > Thanks, Zhou Zheng! I h

Re: [vdsm] Introducing a validation test package to vdsm

2012-04-27 Thread Ewoud Kohl van Wijngaarden
On Fri, Apr 27, 2012 at 11:23:49AM +0800, wenchao xia wrote: > 于 2012-4-26 22:35, Ewoud Kohl van Wijngaarden 写道: > >On Thu, Apr 26, 2012 at 08:57:55AM -0500, Adam Litke wrote: > >>On Thu, Apr 26, 2012 at 05:24:29PM +0800, wenchao xia wrote: > >>> It is just a scr

Re: [vdsm] Introducing a validation test package to vdsm

2012-04-26 Thread Ewoud Kohl van Wijngaarden
On Thu, Apr 26, 2012 at 11:11:49AM -0500, Adam Litke wrote: > On Thu, Apr 26, 2012 at 11:12:06PM +0800, Shu Ming wrote: > > One more comment about the test package version. Most likely, the > > package version will be the same version as the VDSM package > > version. The rule we need to consider

Re: [vdsm] Introducing a validation test package to vdsm

2012-04-26 Thread Ewoud Kohl van Wijngaarden
On Thu, Apr 26, 2012 at 08:57:55AM -0500, Adam Litke wrote: > On Thu, Apr 26, 2012 at 05:24:29PM +0800, wenchao xia wrote: > > It is just a scratch from my mind, so I'd like hear your opinions. > > Thanks for the idea! Do you have a sample test for the verification test > suite? > Will it be yo

Re: [vdsm] pep8 check in vim

2012-04-12 Thread Ewoud Kohl van Wijngaarden
On Thu, Apr 12, 2012 at 10:48:26AM -0400, Saggi Mizrahi wrote: > Now that we started moving to conform with pep8 you would probably > like to be able to easily check your code. > > If you use vim you could use this vim script > http://www.vim.org/scripts/script.php?script_id=2914 > > I you are not

Re: [vdsm] code sign-off/DCO for ovirt projects

2012-04-10 Thread Ewoud Kohl van Wijngaarden
On Mon, Apr 09, 2012 at 06:39:22AM -0600, Eric Blake wrote: > On 04/08/2012 02:11 AM, Dan Kenigsberg wrote: > > > Anything cooler we can do beyond putting > > > > SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p') > > grep -qs "^$SOB" "$1" || echo "$SOB" >> "$1" > > > > at

Re: [vdsm] gerrit submmission, review, comment process questions

2012-04-04 Thread Ewoud Kohl van Wijngaarden
On Tue, Apr 03, 2012 at 09:07:15PM -0500, Ryan Harper wrote: > I'm just starting to work with gerrit and I've got a number of process > questions on how to map typical opensource project development with > gerrit. First a general recommendation for working with gerrit: keyboard shortcuts are critic

Re: [vdsm] PEP8 in VDSM code

2012-03-26 Thread Ewoud Kohl van Wijngaarden
On Mon, Mar 26, 2012 at 04:57:24AM -0400, Ayal Baron wrote: > > I'd rather avoid gerrit hooks if possible to use a jenkins job to > > validate this to keep the gerrit deployment as simple to > > maintain/upgrade as possible. > > But that's the wrong place to be doing it. > Jenkins periodically poll

Re: [vdsm] Error when running autobuild

2012-03-01 Thread Ewoud Kohl van Wijngaarden
On Thu, Mar 01, 2012 at 03:18:59PM +, Itzik Brown wrote: > I have a problem building vdsm on RHEL 6.2 > > After running the following: > > # git clone http://gerrit.ovirt.org/p/vdsm.git > # cd vdsm > # git fetch http://gerrit.ovirt.org/p/vdsm refs/changes/93/1693/5 && git > checkout FETCH_HEAD