Edward Haas has posted comments on this change.
Change subject: net: Consume ifcfg files that have a non vdsm standard name
..
Patch Set 3: Verified+1
Func tests passed and checked by QE
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: lib: api: allow to return prebuilt responses
..
Patch Set 17: Code-Review+1
(1 comment)
Please remove the whitespace change and verify.
gerrit-hooks has posted comments on this change.
Change subject: lib: response: helper to detect valid responses
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Nir Soffer has submitted this change and it was merged.
Change subject: lib: response: helper to detect valid responses
..
lib: response: helper to detect valid responses
We should build responses in the API layer, and the
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 7:
See my comments in version 6
--
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 6:
(4 comments)
https://gerrit.ovirt.org/#/c/64169/6/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
gerrit-hooks has posted comments on this change.
Change subject: vdsClient: Configure logging before imports
..
Patch Set 5:
* #1377069::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 8:
ping
--
To view, visit https://gerrit.ovirt.org/62212
To unsubscribe, visit
Nir Soffer has abandoned this change.
Change subject: vdsClient: Configure logging before imports
..
Abandoned
Not needed now.
--
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64222/4/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line
Nir Soffer has submitted this change and it was merged.
Change subject: vm: Remove unneeded fallback to blockRebase
..
vm: Remove unneeded fallback to blockRebase
If blockCopy was not supported, we fallback to blockRebase.
gerrit-hooks has posted comments on this change.
Change subject: vm: Remove unneeded fallback to blockRebase
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line
Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line
Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line
Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: logging: Document the secret TRACE log level
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has submitted this change and it was merged.
Change subject: logging: Document the secret TRACE log level
..
logging: Document the secret TRACE log level
This may be useful to for developers to understand
Nir Soffer has posted comments on this change.
Change subject: logging: Document the secret TRACE log level
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64218
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64222/4/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: storage: Refactor workarounds.detect_format
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/64230
To
Adam Litke has abandoned this change.
Change subject: storage: Refactor workarounds.detect_format
..
Abandoned
Not needed.
--
To view, visit https://gerrit.ovirt.org/64230
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: Pass only srcVol to workarounds.detect_format
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: storage: Move detect_format to new workarounds module
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: storage: Use detect_format workaround in copy_data
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Share FakeScheduler and use in TestCopyDataDIV
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: tests: Rename qemuimgTests.py to new Vdsm convention
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Adam Litke has uploaded a new change for review.
Change subject: storage: Pass only srcVol to workarounds.detect_format
..
storage: Pass only srcVol to workarounds.detect_format
When copying an image we do not change the format
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Rename qemuimgTests.py to new Vdsm convention
..
tests: Rename qemuimgTests.py to new Vdsm convention
Change-Id:
Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
* #1377069::Update tracker: OK
* Set MODIFIED::bug 1377069#1377069OK
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: sos: collect 'nodectl info' output
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64258
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: vdsm: Do not modify warnings filter in a library
..
vdsm: Do not modify warnings filter in a library
vdsm.vdscli was modifying warnings filter, taking
Adam Litke has posted comments on this change.
Change subject: storage: Refactor workarounds.detect_format
..
Patch Set 1:
(7 comments)
https://gerrit.ovirt.org/#/c/64230/1/tests/storage_workarounds_test.py
File
Adam Litke has posted comments on this change.
Change subject: storage: Use mismatched_vm_conf_disk workaround in copy_data
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/64231/1/vdsm/storage/sdm/api/copy_data.py
Irit Goihman has posted comments on this change.
Change subject: sos: collect 'nodectl info' output
..
Patch Set 1: Verified+1
[root@rhevh-25 sos]# ll
Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit
..
Patch Set 4:
(5 comments)
https://gerrit.ovirt.org/#/c/64222/4/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line
Adam Litke has posted comments on this change.
Change subject: storage: Move detect_format to new workarounds module
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/64229/1/tests/storage_workarounds_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: tests: Rename qemuimgTests.py to new Vdsm convention
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 1: Verified+1
Trivial change, verified on master.
--
To view, visit https://gerrit.ovirt.org/64258
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 1:
* #1377069::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1377069::OK, public bug
Hello Piotr Kliczewski, Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/64258
to review the following change.
Change subject: vdsm: Do not modify warnings filter in a library
Edward Haas has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/64118
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: tests: TestCopyDataDIV needs to initialize the jobs module
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64228/1/tests/storage_sdm_copy_data_test.py
Edward Haas has posted comments on this change.
Change subject: net: Delete an OVS bridge when the last SB is detached.
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/64192
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net: Setup validation for OVS - Check nics usage
..
Patch Set 4: -Code-Review Verified+1
--
To view, visit https://gerrit.ovirt.org/64212
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net: Log a setup networks transaction failure when using ovs
switch
..
Patch Set 3: -Code-Review Verified+1
--
To view, visit https://gerrit.ovirt.org/64242
To
Edward Haas has posted comments on this change.
Change subject: net: Setup validation for OVS - Check nics usage
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64212
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net: Log a setup networks transaction failure when using ovs
switch
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64242
To
Adam Litke has posted comments on this change.
Change subject: qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/64169/7/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Edward Haas has posted comments on this change.
Change subject: net test: shared nic between bond and network
..
Patch Set 1: Code-Review-1
(3 comments)
test names
gerrit-hooks has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: net: Log a setup networks transaction failure when using ovs
switch
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
gerrit-hooks has posted comments on this change.
Change subject: net: Delete an OVS bridge when the last SB is detached.
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: net: Setup validation for OVS - Check nics usage
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: net: Log a setup networks transaction failure when using ovs
switch
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Edward Haas has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64118/4/lib/vdsm/network/netswitch.py
File
gerrit-hooks has posted comments on this change.
Change subject: net: Split bond setup handler for future validation
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/64241
Edward Haas has abandoned this change.
Change subject: net: Split bond setup handler for future validation
..
Abandoned
Squashed into https://gerrit.ovirt.org/#/c/64118
--
To view, visit https://gerrit.ovirt.org/64241
To
gerrit-hooks has posted comments on this change.
Change subject: net: Delete an OVS bridge when the last SB is detached.
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: net: Setup validation for OVS - Check nics usage
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sd: Add method to return compat by sd version.
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 3:
* #1374988::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374988::OK, public
Jenny Tokar has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/63748/2/lib/api/vdsm-api.yml
File
gerrit-hooks has posted comments on this change.
Change subject: implementing StorageDomain.movePV
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: Define the StorageDomain.reduce API
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/64169/6/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
gerrit-hooks has posted comments on this change.
Change subject: **WIP** tool: reconfigure containers networks
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 50:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 30:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: config: add tunables for container support
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: network: filter out 'veth' devices
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
gerrit-hooks has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 34:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: sd: Add method to return compat by sd version.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 32:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: implementing StorageDomain.movePV
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Liron Aravot has posted comments on this change.
Change subject: implementing StorageDomain.reduce
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/63269/3/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: implementing StorageDomain.reduce
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 43:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Define the StorageDomain.reduce API
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has uploaded a new change for review.
Change subject: config: add tunables for container support
..
config: add tunables for container support
Add the config items we'll need later on
Change-Id:
Liron Aravot has posted comments on this change.
Change subject: Define the StorageDomain.reduce API
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/62853/7/vdsm/API.py
File vdsm/API.py:
Line 1078: def
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: net: Log a setup networks transaction failure when using ovs
switch
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
gerrit-hooks has posted comments on this change.
Change subject: net: Split bond setup handler for future validation
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: net: Delete an OVS bridge when the last SB is detached.
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: net: Setup validation for OVS - Check nics usage
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
1 - 100 of 139 matches
Mail list logo
