Change in vdsm[master]: tests: Remove TODO for SDM.copy_data abort before copy test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Remove TODO for SDM.copy_data abort before copy test
..


Patch Set 4:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64480
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26e724560e9cb485fd4766ebcc04f644ad6431e4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: SDM.copy_data test for abort while copying

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: SDM.copy_data test for abort while copying
..


Patch Set 4:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I740d9ba42e3bd70865eadcb024ce6d9d8da0af95
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Increment generation id when completing operation

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Increment generation id when completing operation
..


Patch Set 3:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64487
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9a62289378b11c3b2f2f520c894336fc89c1fdc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Validate generation id in volume.operation context

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Validate generation id in volume.operation context
..


Patch Set 3:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64486
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77d9c6cb46053ab32c59c77599b7c1366e1c8196
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Support generation id in sdm.copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Support generation id in sdm.copy_data
..


Patch Set 3:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I701e220f5c275dccaa3767768e2d1433fe033839
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Use Volume.operation in SDM.copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Use Volume.operation in SDM.copy_data
..


Patch Set 3:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I574cea3387ab5b99368e0317aed73683d398a596
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: GenerationMismatch exception

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: GenerationMismatch exception
..


Patch Set 2:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2eb9ffb326f343d89fa17af462c3bbfb18697a04
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for generation to VolumeMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Add support for generation to VolumeMetadata
..


Patch Set 3:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64484
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb71e1fc78f6c1e411e725b26c48411ffd04d0b6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Report generation id in volume.getInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Report generation id in volume.getInfo
..


Patch Set 3:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64485
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62a6bb44c5f789acf3c63953f4b87c72585becc1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: GenerationMismatch exception

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: GenerationMismatch exception
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64543/1/lib/vdsm/storage/exception.py
File lib/vdsm/storage/exception.py:

Line 1789: 
Line 1790: 
Line 1791: class GenerationMismatch(StorageException):
Line 1792: code = 911
Line 1793: message = "The provided generation does not match the actual 
generation."
> Most error messages do not end with period, I think this is good. The messa
Actual number is 6 messages ending with period, 284 without.
Line 1794: 
Line 1795: def __init__(self, requested, actual):


-- 
To view, visit https://gerrit.ovirt.org/64543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2eb9ffb326f343d89fa17af462c3bbfb18697a04
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: qemuimg: Add qcow_compat optional parameter.
..


qemuimg: Add qcow_compat optional parameter.

Add qcow2_compat parameter that indicates the apropriate qemu
compatibility level to be used for create and convert operations.

Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Signed-off-by: Maor Lipchuk 
Reviewed-on: https://gerrit.ovirt.org/64169
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M lib/vdsm/qemuimg.py
M tests/qemuimg_test.py
2 files changed, 49 insertions(+), 5 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Add qcow_compat optional parameter.
..


Patch Set 28:

* update_tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Add gen_uuid test helper

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Add gen_uuid test helper
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/64542/1/tests/testlib.py
File tests/testlib.py:

Line 592: 
Line 593: 
Line 594: def gen_uuid():
Line 595: """
Line 596: Return a new UUID in the format used for all vdsm APIs that 
accept UUIDs.
Return a new UUID version 4 string...
Line 597: """


-- 
To view, visit https://gerrit.ovirt.org/64542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I622928911c3f07739fd61f61a58cee2e692c7eeb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: GenerationMismatch exception

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: GenerationMismatch exception
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64543/1/lib/vdsm/storage/exception.py
File lib/vdsm/storage/exception.py:

Line 1776: 
Line 1777: 
Line 1778: #
Line 1779: #  SDM Errors
Line 1780: #  Range: 910-919
I meant to submit this unrelated change separately, not the entire exception, 
but you can leave the exception in a separte patch if you like.
Line 1781: #
Line 1782: 
Line 1783: class DomainHasGarbage(StorageException):
Line 1784: code = 910


-- 
To view, visit https://gerrit.ovirt.org/64543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2eb9ffb326f343d89fa17af462c3bbfb18697a04
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: GenerationMismatch exception

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: GenerationMismatch exception
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/64543/1/lib/vdsm/storage/exception.py
File lib/vdsm/storage/exception.py:

Line 1789: 
Line 1790: 
Line 1791: class GenerationMismatch(StorageException):
Line 1792: code = 911
Line 1793: message = "The provided generation does not match the actual 
generation."
Most error messages do not end with period, I think this is good. The message 
from vdsm is not the error message show to a user, is is text engine may show 
as part of an error, maybe with additional info, so this is not the place to 
format a sentence.

$ grep 'message =' lib/vdsm/storage/exception.py | egrep '\."$' | wc -l
2
$ grep 'message =' lib/vdsm/storage/exception.py | egrep -v '\."$' | wc -l
290

This search is missing some long lines wrapped to two lines, but the trend is 
clear.
Line 1794: 
Line 1795: def __init__(self, requested, actual):


-- 
To view, visit https://gerrit.ovirt.org/64543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2eb9ffb326f343d89fa17af462c3bbfb18697a04
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Support generation id in sdm.copy_data

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Support generation id in sdm.copy_data
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/64488/2/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py:

Line 103: def __init__(self, params, host_id, writable):
Line 104: self.sd_id = params.get('sd_id')
Line 105: self.img_id = params.get('img_id')
Line 106: self.vol_id = params.get('vol_id')
Line 107: self.generation = params.get('generation')
We need to find a way to eliminate this boilerplate - currently we verify in 
init that all arguments are initialized, we can instead initialize all 
arguments and raise if required arguments are missing in params (not related to 
this patch).
Line 108: self._host_id = host_id
Line 109: self._writable = writable
Line 110: self._vol = None
Line 111: 


-- 
To view, visit https://gerrit.ovirt.org/64488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I701e220f5c275dccaa3767768e2d1433fe033839
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Support generation id in sdm.copy_data

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Support generation id in sdm.copy_data
..


Patch Set 2:

(2 comments)

Test is probably failing because of using generation_id instead of generation

https://gerrit.ovirt.org/#/c/64488/2/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 249: 
Line 250: self.assertEqual(sc.LEGAL_VOL, dst_vol.getLegality())
Line 251: source = dict(endpoint_type='div', sd_id=src_vol.sdUUID,
Line 252:   img_id=src_vol.imgUUID, 
vol_id=src_vol.volUUID,
Line 253:   generation_id=0)
generation_id?
Line 254: dest = dict(endpoint_type='div', sd_id=dst_vol.sdUUID,
Line 255: img_id=dst_vol.imgUUID, 
vol_id=dst_vol.volUUID,
Line 256: generation_id=gen_id)
Line 257: fake_convert = FakeQemuConvertChecker(src_vol, dst_vol, 
cmd)


Line 252:   img_id=src_vol.imgUUID, 
vol_id=src_vol.volUUID,
Line 253:   generation_id=0)
Line 254: dest = dict(endpoint_type='div', sd_id=dst_vol.sdUUID,
Line 255: img_id=dst_vol.imgUUID, 
vol_id=dst_vol.volUUID,
Line 256: generation_id=gen_id)
generation_id?
Line 257: fake_convert = FakeQemuConvertChecker(src_vol, dst_vol, 
cmd)
Line 258: with MonkeyPatchScope([(qemuimg, 'convert', 
fake_convert)]):
Line 259: job = storage.sdm.api.copy_data.Job(job_id, 0, 
source, dest)
Line 260: job.run()


-- 
To view, visit https://gerrit.ovirt.org/64488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I701e220f5c275dccaa3767768e2d1433fe033839
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Increment generation id when completing operation

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Increment generation id when completing operation
..


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/64487/2/tests/storage_volume_test.py
File tests/storage_volume_test.py:

Line 139: vol = env.sd_manifest.produceVolume(img_id, vol_id)
Line 140: vol.setMetaParam(sc.GENERATION, 100)
Line 141: with vol.operation(generation):
Line 142: pass
Line 143: self.assertEqual(generation + 1, 
vol.getMetaParam(sc.GENERATION))
This test is good enough for increasing the generation...
Line 144: 
Line 145: @permutations(((100, 99), (100, 101)))
Line 146: def test_operation_invalid_generation_raises(self, 
actual_generation,
Line 147:  
requested_generation):


Line 170: vol.setMetaParam(sc.GENERATION, generation)
Line 171: self.assertEqual(generation, vol.getInfo()['generation'])
Line 172: 
Line 173: @permutations((
Line 174: (sc.MAX_GENERATION, 0),
I think we need only this test for wrapping, previous test verified increasing 
it.
Line 175: (sc.MAX_GENERATION - 1, sc.MAX_GENERATION),
Line 176: (0, 1),
Line 177: (1, 2),
Line 178: ))


https://gerrit.ovirt.org/#/c/64487/2/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 55: # domains) we do not need to use the image dir reference anymore.
Line 56: return volUUID
Line 57: 
Line 58: 
Line 59: def next_generation(current_generation):
Do we need it public?
Line 60: # Increment a generation value and wrap to 0 after MAX_GENERATION
Line 61: return (current_generation + 1) % (sc.MAX_GENERATION + 1)
Line 62: 
Line 63: 


-- 
To view, visit https://gerrit.ovirt.org/64487
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9a62289378b11c3b2f2f520c894336fc89c1fdc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Validate generation id in volume.operation context

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Validate generation id in volume.operation context
..


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/64486/2/tests/storage_volume_test.py
File tests/storage_volume_test.py:

Line 142: pass
Line 143: 
Line 144: @permutations(((100, 99), (100, 101)))
Line 145: def test_operation_invalid_generation_raises(self, 
actual_generation,
Line 146:  
requested_generation):
test_operation_generation_mismatch?

I think the arguments are reversed - 100 is the requested generation, and 99 
and 101 are the actual generation.
Line 147: img_id = gen_uuid()
Line 148: vol_id = gen_uuid()
Line 149: 
Line 150: with fake_env('file') as env:


https://gerrit.ovirt.org/#/c/64486/2/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 507: marked ILLEGAL prior to the first modification of data and 
subsequently
Line 508: marked LEGAL again once the operation has completed.  Thus, 
if an
Line 509: interruption occurs the volume will remain in an ILLEGAL 
state.
Line 510: 
Line 511: If generation is provided we check that the volume's 
generation matches
Missing period at the end.
Line 512: """
Line 513: actual_gen = self.getMetaParam(sc.GENERATION)
Line 514: if requested_gen is not None and actual_gen != requested_gen:
Line 515: raise se.GenerationMismatch(requested_gen, actual_gen)


-- 
To view, visit https://gerrit.ovirt.org/64486
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77d9c6cb46053ab32c59c77599b7c1366e1c8196
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Report generation id in volume.getInfo

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Report generation id in volume.getInfo
..


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/64485/2/tests/storage_volume_test.py
File tests/storage_volume_test.py:

Line 138: vol = env.sd_manifest.produceVolume(img_id, vol_id)
Line 139: vol.getLeaseStatus = lambda: 'unused'
Line 140: vol.setMetaParam(sc.GENERATION, generation)
Line 141: self.assertEqual(generation, vol.getInfo()['generation'])
Line 142: 
Do we need a test for volume without generation?
Line 143: 
Line 144: class CountedInstanceMethod(object):
Line 145: def __init__(self, method):
Line 146: self._method = method


https://gerrit.ovirt.org/#/c/64485/2/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 215
Line 216
Line 217
Line 218
Line 219
This always uses VolumeMetadata, right?


Line 205: "image": self.getImage(),
Line 206: "ctime": meta.get(sc.CTIME, ""),
Line 207: "mtime": "0",
Line 208: "legality": meta.get(sc.LEGALITY, ""),
Line 209: "generation": meta.get(sc.GENERATION, 
sc.DEFAULT_GENERATION)
This should work, but since we always add a default generation in 
VolumeMetadata, do we expect to have no GEN key?

If we expect to have the key, we should not use get(),  and let the code fail 
if your expectation is wrong.
Line 210: }
Line 211: 
Line 212: def getInfo(self):
Line 213: """


-- 
To view, visit https://gerrit.ovirt.org/64485
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62a6bb44c5f789acf3c63953f4b87c72585becc1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for generation to VolumeMetadata

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Add support for generation to VolumeMetadata
..


Patch Set 2: Code-Review-1

(4 comments)

https://gerrit.ovirt.org/#/c/64484/2//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2016-09-27 15:19:01 -0400
Line 6: 
Line 7: storage: Add support for generation to VolumeMetadata
Line 8: 
Line 9: We would like to add support for a new generation id key in the volume
remove id.

Please update also all the other commit messages.
Line 10: metadata.  GEN is a monotonically increasing integer that can be used
Line 11: to determine whether certain operations have been completed on a volume
Line 12: and to prevent two hosts from sequentially performing the same 
operation
Line 13: in the event of double scheduling.


https://gerrit.ovirt.org/#/c/64484/2/lib/vdsm/storage/constants.py
File lib/vdsm/storage/constants.py:

Line 161
Line 162
Line 163
Line 164
Line 165
Lets separate DESCRIPTION_SIZE from the generation constants, and maybe add a 
comment explaining these constants?


Line 124: IMAGE = "IMAGE"
Line 125: DESCRIPTION = "DESCRIPTION"
Line 126: LEGALITY = "LEGALITY"
Line 127: MTIME = "MTIME"
Line 128: GENERATION = "GEN"
Lets add a comment:

# Added in 4.1
Line 129: POOL = MDK_POOLS  # Deprecated
Line 130: 
Line 131: # In block storage, metadata size is limited to BLOCK_SIZE (512), to
Line 132: # ensure that metadata is written atomically. This is big enough for 
the


https://gerrit.ovirt.org/#/c/64484/2/tests/storage_volume_metadata_test.py
File tests/storage_volume_metadata_test.py:

Line 188: 
Line 189: def test_generation_default(self):
Line 190: data = make_md_dict()
Line 191: lines = make_lines(generation=sc.DEFAULT_GENERATION + 1, 
**data)
Line 192: lines.remove("{}={}".format(sc.GENERATION, 
sc.DEFAULT_GENERATION + 1))
Why not:

data = make_md_dict()
del data[sc.GENERATION]
lines = make_lines(**data)
Line 193: md = volume.VolumeMetadata.from_lines(lines)


-- 
To view, visit https://gerrit.ovirt.org/64484
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb71e1fc78f6c1e411e725b26c48411ffd04d0b6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: API: modernize VM methods

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: API: modernize VM methods
..


Patch Set 18:

(2 comments)

I think this patch is too big, lets change first the easy places where 
replacing the duplicate code with the new getter does not change the semantics.

https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py
File vdsm/API.py:

Line 346
Line 347
Line 348
Line 349
Line 350
This changed the semantics - before we would raise before we run the hook, now 
we would run the hook when no vm is running, and then fail in getStats()


Line 263: """
Line 264: Lock user session in guest operating system using guest agent.
Line 265: """
Line 266: self.vm.guestAgent.desktopLock()
Line 267: if self.vm.guestAgent.isResponsive():
> +1
If you create a variable, I would do:

   ga = self.vm.guestAgent
   ga.desktopLock()
   if ga.isResponsive():
   ...

But I think the version Francesco submitted is more readable. We so such 
optimizations for tight loops since accessing local variables is much faster 
then globals or objects attributes.
Line 268: return {'status': doneCode}
Line 269: else:
Line 270: return errCode['nonresp']
Line 271: 


-- 
To view, visit https://gerrit.ovirt.org/61475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2e238fc632df97b63f7bb2a6293fe1c392a842
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: qemuimg: Add qcow_compat optional parameter.
..


Patch Set 27: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Teardown volume on HSM after live merge

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Live Merge: Teardown volume on HSM after live merge
..


Patch Set 6:

(2 comments)

Did you verify the current code with both top layer merge and internal layer 
merge, or you just copied the verified flag from a previous version?

https://gerrit.ovirt.org/#/c/64301/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4779:  "(job %s)", self.job['jobID'])
Line 4780: self.vm._syncVolumeChain(self.drive)
Line 4781: if self.doPivot:
Line 4782: self.vm.enableDriveMonitor()
Line 4783: self.teardown_top_volume()
How is this needed only after pivot?

We need to teardown the volume after any merge, not only top layer merge.

I think I suggested to add teardown in this line, but not inside the if block.
Line 4784: self.success = True
Line 4785: self.vm.log.info("Synchronization completed (job %s)",
Line 4786:  self.job['jobID'])
Line 4787: # At this point, merge has succesfully completed and the top 
volume is


Line 4788: # not part of the chain.  Now, we want to teardown the top 
volume. Note
Line 4789: # that if volume deactivation fails, we don't want to fail 
the merge
Line 4790: # whole operation as the VM is running without issues.  It 
is worth to
Line 4791: # note that if volume deactivation fails, chances are high 
that the
Line 4792: # environment is severely damaged.
This comment conflict with the code now.
Line 4793: 
Line 4794: def isSuccessful(self):
Line 4795: """
Line 4796: Returns True if this phase completed successfully.


-- 
To view, visit https://gerrit.ovirt.org/64301
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Teardown volume on HSM after live merge

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Live Merge: Teardown volume on HSM after live merge
..


Patch Set 6: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/64301
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Use Volume.operation in SDM.copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Use Volume.operation in SDM.copy_data
..


Patch Set 2:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I574cea3387ab5b99368e0317aed73683d398a596
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Remove TODO for SDM.copy_data abort before copy test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Remove TODO for SDM.copy_data abort before copy test
..


Patch Set 3:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64480
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26e724560e9cb485fd4766ebcc04f644ad6431e4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for generation to VolumeMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Add support for generation to VolumeMetadata
..


Patch Set 2:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64484
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb71e1fc78f6c1e411e725b26c48411ffd04d0b6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Support generation id in sdm.copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Support generation id in sdm.copy_data
..


Patch Set 2:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I701e220f5c275dccaa3767768e2d1433fe033839
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: SDM.copy_data test for abort while copying

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: SDM.copy_data test for abort while copying
..


Patch Set 3:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I740d9ba42e3bd70865eadcb024ce6d9d8da0af95
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Support generation id in sdm.copy_data

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Support generation id in sdm.copy_data
..


Patch Set 2: Verified-1

Still investigating a test failure.

-- 
To view, visit https://gerrit.ovirt.org/64488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I701e220f5c275dccaa3767768e2d1433fe033839
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: GenerationMismatch exception

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: GenerationMismatch exception
..


Patch Set 1:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2eb9ffb326f343d89fa17af462c3bbfb18697a04
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Add gen_uuid test helper

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add gen_uuid test helper
..


Patch Set 1:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I622928911c3f07739fd61f61a58cee2e692c7eeb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Validate generation id in volume.operation context

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Validate generation id in volume.operation context
..


Patch Set 2:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64486
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77d9c6cb46053ab32c59c77599b7c1366e1c8196
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce VolumeManifest.operation context

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Introduce VolumeManifest.operation context
..


Patch Set 3:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30a3ac2971411778d24e007aac9fcb3009edb4c4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Report generation id in volume.getInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Report generation id in volume.getInfo
..


Patch Set 2:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64485
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62a6bb44c5f789acf3c63953f4b87c72585becc1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Increment generation id when completing operation

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Increment generation id when completing operation
..


Patch Set 2:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64487
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9a62289378b11c3b2f2f520c894336fc89c1fdc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Add gen_uuid test helper

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: Add gen_uuid test helper
..

tests: Add gen_uuid test helper

The test code is sprinkled with lots of boilerplate code to generate
UUIDs in the proper format.  Add a helper to testlib so we can reduce
this duplicated logic in tests.

Change-Id: I622928911c3f07739fd61f61a58cee2e692c7eeb
Signed-off-by: Adam Litke 
---
M tests/testlib.py
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/64542/1

diff --git a/tests/testlib.py b/tests/testlib.py
index c341c24..b75e7a2 100644
--- a/tests/testlib.py
+++ b/tests/testlib.py
@@ -28,6 +28,7 @@
 import pickle
 import platform
 import unittest
+import uuid
 from functools import wraps
 import shutil
 import sys
@@ -588,3 +589,10 @@
 """
 while job.active:
 time.sleep(1)
+
+
+def gen_uuid():
+"""
+Return a new UUID in the format used for all vdsm APIs that accept UUIDs.
+"""
+return str(uuid.uuid4())


-- 
To view, visit https://gerrit.ovirt.org/64542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I622928911c3f07739fd61f61a58cee2e692c7eeb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: GenerationMismatch exception

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage: GenerationMismatch exception
..

storage: GenerationMismatch exception

Introduce a new exception with a public error code for generation
mismatch errors.  SDM verbs involving datapath operations will accept a
generation parameter which will be compared against the operative
entity's (eg. Volume) current generation.  If the generation values
match then the operation can proceed.  Otherwise GenerationMismatch will
be raised and the caller must resync against the actual storage state to
determine how to proceed.

Change-Id: I2eb9ffb326f343d89fa17af462c3bbfb18697a04
Signed-off-by: Adam Litke 
---
M lib/vdsm/storage/exception.py
1 file changed, 9 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/64543/1

diff --git a/lib/vdsm/storage/exception.py b/lib/vdsm/storage/exception.py
index dcd2922..ee56673 100644
--- a/lib/vdsm/storage/exception.py
+++ b/lib/vdsm/storage/exception.py
@@ -1777,7 +1777,7 @@
 
 #
 #  SDM Errors
-#  Range: 909-910
+#  Range: 910-919
 #
 
 class DomainHasGarbage(StorageException):
@@ -1786,3 +1786,11 @@
 
 def __init__(self, reason):
 self.value = reason
+
+
+class GenerationMismatch(StorageException):
+code = 911
+message = "The provided generation does not match the actual generation."
+
+def __init__(self, requested, actual):
+self.value = "requested=%s, actual=%s" % (requested, actual)


-- 
To view, visit https://gerrit.ovirt.org/64543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2eb9ffb326f343d89fa17af462c3bbfb18697a04
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: API: modernize VM methods

[ahadas]

Arik Hadas has posted comments on this change.

Change subject: API: modernize VM methods
..


Patch Set 18:

(1 comment)

https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py
File vdsm/API.py:

Line 263: """
Line 264: Lock user session in guest operating system using guest agent.
Line 265: """
Line 266: self.vm.guestAgent.desktopLock()
Line 267: if self.vm.guestAgent.isResponsive():
> Would using a variable really make the code less readable? Not that importa
+1
I personally find:

vm = self.vm
vm.guestAgent.desktopLock()
if vm.guestAgent.isResponsive():

to be as easy to read as lines 266-267 above and less confusing since calling 
vm() twice could make people wonder "why the hell do they query the VM twice? 
can the VM change in the middle?"
but I don't really mind - it is really not that important here..
Line 268: return {'status': doneCode}
Line 269: else:
Line 270: return errCode['nonresp']
Line 271: 


-- 
To view, visit https://gerrit.ovirt.org/61475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2e238fc632df97b63f7bb2a6293fe1c392a842
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Support generation id in sdm.copy_data

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Support generation id in sdm.copy_data
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64488/1/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py:

Line 96: class CopyDataDivEndpoint(properties.Owner):
Line 97: sd_id = properties.UUID(required=True)
Line 98: img_id = properties.UUID(required=True)
Line 99: vol_id = properties.UUID(required=True)
Line 100: generation_id = properties.Integer(required=False, minval=0)
> Done
maxval=sc.MAX_GENERATION even better :-)
Line 101: 
Line 102: def __init__(self, params, host_id, writable):
Line 103: self.sd_id = params.get('sd_id')
Line 104: self.img_id = params.get('img_id')


-- 
To view, visit https://gerrit.ovirt.org/64488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I701e220f5c275dccaa3767768e2d1433fe033839
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sd: Select qcow2_compat by storage domain version

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: sd: Select qcow2_compat by storage domain version
..


sd: Select qcow2_compat by storage domain version

Add a method that will return the qcow compatibility version
based on the storage domain's version.

The method should return the value "1.1" if the storage domain
version is 4 and later, and the default format for older domains,
which is "0.10" with default configuration.

Change-Id: I946d8a0d142187bef4e50d583003e2f5b848d678
Signed-off-by: Maor Lipchuk 
Reviewed-on: https://gerrit.ovirt.org/64244
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M tests/sdm_indirection_tests.py
M vdsm/storage/sd.py
2 files changed, 14 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/64244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I946d8a0d142187bef4e50d583003e2f5b848d678
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sd: Select qcow2_compat by storage domain version

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sd: Select qcow2_compat by storage domain version
..


Patch Set 19:

* update_tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/64244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I946d8a0d142187bef4e50d583003e2f5b848d678
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Add qcow_compat optional parameter.
..


Patch Set 27:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sd: Select qcow2_compat by storage domain version

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sd: Select qcow2_compat by storage domain version
..


Patch Set 18: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I946d8a0d142187bef4e50d583003e2f5b848d678
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: qemuimg: Add qcow_compat optional parameter.
..


Patch Set 27: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: qemuimg: Add qcow_compat optional parameter.
..


Patch Set 26: Verified+1

Tests pass, looks verified to me.

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Add qcow_compat optional parameter.
..


Patch Set 26:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: qemuimg: Add qcow_compat optional parameter.
..


Patch Set 25:

(1 comment)

https://gerrit.ovirt.org/#/c/64169/25/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 326: 
Line 327: def _validate_qcow2_compat(value):
Line 328: if value is None:
Line 329: value = default_qcow2_compat()
Line 330: return value
Better:

if value is None:
return default_qcow2_compat()
Line 331: if value not in _QCOW2_COMPAT_SUPPORTED:
Line 332: raise ValueError("Invalid compat version '%r'" % value)


-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: file_volume: Add qcow2_compat on create

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
..


Patch Set 15: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81fd3a6e263980c1eabeea7f619c9a6b48991938
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Support generation id in sdm.copy_data

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Support generation id in sdm.copy_data
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/64488/1/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py:

Line 96: class CopyDataDivEndpoint(properties.Owner):
Line 97: sd_id = properties.UUID(required=True)
Line 98: img_id = properties.UUID(required=True)
Line 99: vol_id = properties.UUID(required=True)
Line 100: generation_id = properties.Integer(required=False, minval=0)
> - generation
Done
Line 101: 
Line 102: def __init__(self, params, host_id, writable):
Line 103: self.sd_id = params.get('sd_id')
Line 104: self.img_id = params.get('img_id')


Line 146: return sc.fmt2str(parent_vol.getFormat())
Line 147: 
Line 148: @property
Line 149: def volume_operation(self):
Line 150: return partial(self._vol.operation, self.generation_id)
> Can we simplify to:
Done
Line 151: 
Line 152: @contextmanager
Line 153: def prepare(self):
Line 154: dom = sdCache.produce_manifest(self.sd_id)


-- 
To view, visit https://gerrit.ovirt.org/64488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I701e220f5c275dccaa3767768e2d1433fe033839
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Validate generation id in volume.operation context

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Validate generation id in volume.operation context
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64486/1/tests/storage_volume_test.py
File tests/storage_volume_test.py:

Line 134: vol_id = str(uuid.uuid4())
Line 135: generation = 100
Line 136: 
Line 137: with fake_env('file') as env:
Line 138: env.make_volume(MB, img_id, vol_id)
> Most tests don't care about the generation.  Let's leave it for now as we c
Sure, most test do not care about generation, but they may need other metadata. 
If we can create a volume with certain metadata in a trivial way, it can be 
useful.

If we have only couple of test that needs to change metadata, we should 
probably use the volume api like you did here.
Line 139: vol = env.sd_manifest.produceVolume(img_id, vol_id)
Line 140: vol.setMetaParam(sc.GENERATION, 100)
Line 141: with vol.operation(generation):
Line 142: pass


-- 
To view, visit https://gerrit.ovirt.org/64486
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77d9c6cb46053ab32c59c77599b7c1366e1c8196
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for generation id to VolumeMetadata

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Add support for generation id to VolumeMetadata
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64484/1/tests/storage_volume_metadata_test.py
File tests/storage_volume_metadata_test.py:

Line 98: PUUID=params['puuid'],
Line 99: SIZE=str(params['size']),
Line 100: TYPE=params['type'],
Line 101: VOLTYPE=params['voltype'],
Line 102: GENID=params['generation'])
> Not sure if we really want to do this.
OK
Line 103: 
Line 104: with MonkeyPatchScope([[time, 'time', lambda: FAKE_TIME]]):
Line 105: info = volume.VolumeMetadata(**params).legacy_info()
Line 106: self.assertEqual(expected, info)


-- 
To view, visit https://gerrit.ovirt.org/64484
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb71e1fc78f6c1e411e725b26c48411ffd04d0b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: image: Pass compat version.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: image: Pass compat version.
..


Patch Set 18: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64293
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56e01923aba982e20bda72af61db83df50373127
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Increment generation id when completing operation

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Increment generation id when completing operation
..


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/64487/1/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 510: the volume is legal we want to call volume.getInfo to 
determine if this
Line 511: operation has not been started or has finished successfully.  
We enable
Line 512: this by incrementing the generation id after the operation 
completes.
Line 513: Note that legality and generation id must be updated in the 
same write
Line 514: operation.
> The last note is not interesting to the users of this api. It should be rig
Done
Line 515: 
Line 516: If generation is provided we check that the volume's 
generation matches
Line 517: """
Line 518: real_gen_id = self.getMetaParam(sc.GENERATION)


Line 520: raise se.InvalidGeneration(requested_gen_id, real_gen_id)
Line 521: self.setLegality(sc.ILLEGAL_VOL)
Line 522: yield
Line 523: 
Line 524: # Update the generation id and legality in one write
> Lets replace this with the sentence from the docstring, with a IMPORTANT: p
Done
Line 525: metadata = self.getMetadata()
Line 526: metadata[sc.LEGALITY] = sc.LEGAL_VOL
Line 527: metadata[sc.GENERATION] = real_gen_id + 1
Line 528: self.setMetadata(metadata)


Line 523: 
Line 524: # Update the generation id and legality in one write
Line 525: metadata = self.getMetadata()
Line 526: metadata[sc.LEGALITY] = sc.LEGAL_VOL
Line 527: metadata[sc.GENERATION] = real_gen_id + 1
> We need to wrap around, or assert, we cannot use unlimited value:
Done
Line 528: self.setMetadata(metadata)
Line 529: 
Line 530: 
Line 531: class Volume(object):


-- 
To view, visit https://gerrit.ovirt.org/64487
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9a62289378b11c3b2f2f520c894336fc89c1fdc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Validate generation id in volume.operation context

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Validate generation id in volume.operation context
..


Patch Set 1:

(11 comments)

https://gerrit.ovirt.org/#/c/64486/1/lib/vdsm/storage/exception.py
File lib/vdsm/storage/exception.py:

Line 1776: 
Line 1777: 
Line 1778: #
Line 1779: #  SDM Errors
Line 1780: #  Range: 910-919
> Can you submit this separately? (we can merge this quickly)
sure.
Line 1781: #
Line 1782: 
Line 1783: class DomainHasGarbage(StorageException):
Line 1784: code = 910


Line 1787: def __init__(self, reason):
Line 1788: self.value = reason
Line 1789: 
Line 1790: 
Line 1791: class InvalidGeneration(StorageException):
> GenerationMismatch?
Done
Line 1792: code = 911
Line 1793: message = "The provided Generation ID is not valid for this 
Volume"
Line 1794: 
Line 1795: def __init__(self, requested_id, real_id):


Line 1789: 
Line 1790: 
Line 1791: class InvalidGeneration(StorageException):
Line 1792: code = 911
Line 1793: message = "The provided Generation ID is not valid for this 
Volume"
> The provided generation does match the actual volume generation.
Done
Line 1794: 
Line 1795: def __init__(self, requested_id, real_id):


Line 1791: class InvalidGeneration(StorageException):
Line 1792: code = 911
Line 1793: message = "The provided Generation ID is not valid for this 
Volume"
Line 1794: 
Line 1795: def __init__(self, requested_id, real_id):
> requested_generation, real_generation
Done


Line 1792: code = 911
Line 1793: message = "The provided Generation ID is not valid for this 
Volume"
Line 1794: 
Line 1795: def __init__(self, requested_id, real_id):
Line 1796: self.value = "requested id:%i, actual_id:%i" % 
(requested_id, real_id)
> requested=%s, actual=%s?
Done


https://gerrit.ovirt.org/#/c/64486/1/tests/storage_volume_test.py
File tests/storage_volume_test.py:

Line 134: vol_id = str(uuid.uuid4())
Line 135: generation = 100
Line 136: 
Line 137: with fake_env('file') as env:
Line 138: env.make_volume(MB, img_id, vol_id)
> Add generation parameter here? This would make lot of tests easier later.
Most tests don't care about the generation.  Let's leave it for now as we can 
always change it later.
Line 139: vol = env.sd_manifest.produceVolume(img_id, vol_id)
Line 140: vol.setMetaParam(sc.GENERATION, 100)
Line 141: with vol.operation(generation):
Line 142: pass


Line 151: vol = env.sd_manifest.produceVolume(img_id, vol_id)
Line 152: vol.setMetaParam(sc.GENERATION, generation)
Line 153: with self.assertRaises(se.InvalidGeneration):
Line 154: with vol.operation(generation + 1):
Line 155: pass
> Lets test also genration - 1
Done
Line 156: 
Line 157: def test_get_info_generation_id(self):
Line 158: img_id = str(uuid.uuid4())
Line 159: vol_id = str(uuid.uuid4())


https://gerrit.ovirt.org/#/c/64486/1/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 498: """
Line 499: pass
Line 500: 
Line 501: @contextmanager
Line 502: def operation(self, requested_gen_id=None):
> requested_generation
Done
Line 503: """
Line 504: Must be called with the Volume Lease held.
Line 505: 
Line 506: In order to detect interrupted datapath operations a volume 
should be


Line 509: interruption occurs the volume will remain in an ILLEGAL 
state.
Line 510: 
Line 511: If generation is provided we check that the volume's 
generation matches
Line 512: """
Line 513: real_gen_id = self.getMetaParam(sc.GENERATION)
> real_generation
actual_gen
Line 514: if requested_gen_id is not None and real_gen_id != 
requested_gen_id:
Line 515: raise se.InvalidGeneration(requested_gen_id, real_gen_id)
Line 516: self.setLegality(sc.ILLEGAL_VOL)
Line 517: yield


Line 511: If generation is provided we check that the volume's 
generation matches
Line 512: """
Line 513: real_gen_id = self.getMetaParam(sc.GENERATION)
Line 514: if requested_gen_id is not None and real_gen_id != 
requested_gen_id:
Line 515: raise se.InvalidGeneration(requested_gen_id, real_gen_id)
> The _id suffix not only incorrect but make the code harder to read.
Done
Line 516: self.setLegality(sc.ILLEGAL_VOL)
Line 517: yield
Line 518: self.setLegality(sc.LEGAL_VOL)
Line 519: 


Line 517: yield
Line 518: self.setLegality(sc.LEGAL_VOL)
Line 519: 
Line 520: 
Line 521: 
> Unintended I guess?
Done
Line 522: class Volume(object):
Line 523: log = logging.getLogger('storage.Volume')
Line 524: manifestClass = VolumeManifest
Line 

Change in vdsm[master]: storage: Add support for generation id to VolumeMetadata

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Add support for generation id to VolumeMetadata
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64484/1/lib/vdsm/storage/volumemetadata.py
File lib/vdsm/storage/volumemetadata.py:

Line 148: constants.DESCRIPTION: self.description,
Line 149: constants.PUUID: self.puuid,
Line 150: constants.MTIME: str(self.mtime),
Line 151: constants.LEGALITY: self.legality,
Line 152: constants.GENERATION: self.generation,
> Having this volume-related code change behavior based on storage domain ver
If you think it is less work to check old code, why not.


-- 
To view, visit https://gerrit.ovirt.org/64484
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb71e1fc78f6c1e411e725b26c48411ffd04d0b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: copy_data: Add qcow2_compat on convert.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: copy_data: Add qcow2_compat on convert.
..


Patch Set 15:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26e5dcba6fc493b32ea7764889df2918c4dfdd3
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: file_volume: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
..


Patch Set 15:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81fd3a6e263980c1eabeea7f619c9a6b48991938
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: image: Pass compat version.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: image: Pass compat version.
..


Patch Set 18:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64293
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56e01923aba982e20bda72af61db83df50373127
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: volume_artifacts: Add qcow2_compat on create.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: volume_artifacts: Add qcow2_compat on create.
..


Patch Set 15:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd2d53fba0dd69cdb4f60e152cf6d254cfb863a
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Add qcow_compat optional parameter.
..


Patch Set 25:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: volume: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: volume: Add qcow2_compat on create
..


Patch Set 15:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64375
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8655be6da0b4cbd1c286b0c40288681a991aff19
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: Add qcow2_compat on create
..


Patch Set 15:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I331eee6a12853c2fa65e62f42c51504f88723538
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: blockVolume: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: blockVolume: Add qcow2_compat on create
..


Patch Set 15:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64376
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9fe6bf59b76b68ed8f0e60f66057c07b56d2d942
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: qemuimg: Add qcow_compat optional parameter.
..


Patch Set 25: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sd: Select qcow2_compat by storage domain version

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sd: Select qcow2_compat by storage domain version
..


Patch Set 18:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I946d8a0d142187bef4e50d583003e2f5b848d678
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Add qcow_compat optional parameter.
..


Patch Set 24:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: docs: add README about logging configuration

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64515
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: API: modernize VM methods

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: API: modernize VM methods
..


Patch Set 18: Code-Review-1

(6 comments)

Nice change, but we should be careful and double check. I'm afraid there are 
some oversights.

https://gerrit.ovirt.org/#/c/61475/18//COMMIT_MSG
Commit Message:

PS18, Line 9: all
Actually not all.


https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py
File vdsm/API.py:

Line 125: 
Line 126: @property
Line 127: def vm(self):
Line 128: v = self._cif.vmContainer.get(self._UUID)
Line 129: if not v:
if v is not None: ?
Line 130: raise exception.NoSuchVM()
Line 131: return v
Line 132: 
Line 133: @api.method


Line 139: :type vmId: UUID
Line 140: :param driveSpec: specification of the new CD image. Either an
Line 141: image path or a `storage`-centric quartet.
Line 142: """
Line 143: self.vm.changeCD(driveSpec)
No return value?
Line 144: 
Line 145: @api.method
Line 146: def changeFloppy(self, driveSpec):
Line 147: """


Line 151: :type vmId: UUID
Line 152: :param driveSpec: specification of the new CD image. Either an
Line 153: image path or a `storage`-centric quartet.
Line 154: """
Line 155: self.vm.changeFloppy(driveSpec)
No return value?
Line 156: 
Line 157: @api.method
Line 158: def cont(self):
Line 159: return self.vm.cont()


Line 263: """
Line 264: Lock user session in guest operating system using guest agent.
Line 265: """
Line 266: self.vm.guestAgent.desktopLock()
Line 267: if self.vm.guestAgent.isResponsive():
> If we have a tight loop, yes for this code readability is most important.
Would using a variable really make the code less readable? Not that important 
here, just wondering.
Line 268: return {'status': doneCode}
Line 269: else:
Line 270: return errCode['nonresp']
Line 271: 


Line 333: """
Line 334: return self._getStats()
Line 335: 
Line 336: def _getStats(self, runHooks=True):
Line 337: if runHooks:
Nothing to do when runHooks is false?
Line 338: try:
Line 339: hooks.before_get_vm_stats()
Line 340: except exception.HookError as e:
Line 341: return response.error('hookError',


-- 
To view, visit https://gerrit.ovirt.org/61475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2e238fc632df97b63f7bb2a6293fe1c392a842
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Fix calling convention.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Fix calling convention.
..


Patch Set 3:

* update_tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/64522
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87968b101ec74b08b8b049e4ed4cd83adf4aa404
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: SDM.copy_data test for abort while copying

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: SDM.copy_data test for abort while copying
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64479/1/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 232
Line 233
Line 234
Line 235
Line 236
> I did that originally but it makes the test output lines too long.  The onl
We can wrap long line, still easier to understand compared with actual logic.


-- 
To view, visit https://gerrit.ovirt.org/64479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I740d9ba42e3bd70865eadcb024ce6d9d8da0af95
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Report generation id in volume.getInfo

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Report generation id in volume.getInfo
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64485/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 6964: type: *VolumeLeaseStatus
Line 6965: 
Line 6966: -   description: A monotonically increasing generation id
Line 6967: name: generation
Line 6968: type: uint
> these are keywords in the schema.  I don't think we have anything more spec
We want to use signed value to make it easier for Java (no unsigned integers). 
If we don't have anything else we can use long - already used in some verb.
Line 6969: type: object
Line 6970: 
Line 6971: VolumeSizeInfo: 
Line 6972: added: '3.1'


-- 
To view, visit https://gerrit.ovirt.org/64485
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62a6bb44c5f789acf3c63953f4b87c72585becc1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Fix calling convention.

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: qemuimg: Fix calling convention.
..


qemuimg: Fix calling convention.

Use kwarg calling stype for qemuimg API calls.

Change-Id: I87968b101ec74b08b8b049e4ed4cd83adf4aa404
Signed-off-by: Maor Lipchuk 
Reviewed-on: https://gerrit.ovirt.org/64522
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
---
M vdsm/storage/blockVolume.py
M vdsm/storage/fileVolume.py
M vdsm/storage/sdm/volume_artifacts.py
3 files changed, 9 insertions(+), 4 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved; Passed CI tests
  Maor Lipchuk: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64522
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I87968b101ec74b08b8b049e4ed4cd83adf4aa404
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: qemuimg: Add qcow_compat optional parameter.
..


Patch Set 23:

(1 comment)

https://gerrit.ovirt.org/#/c/64169/23/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 323: raise ValueError("not a JSON object")
Line 324: return obj
Line 325: 
Line 326: 
Line 327: def _validate_qcow2_compat(qcow2_value):
Can you rename qcow2_value to value?

This a helper to validate specific value, the name make it very clear. In the 
context of this 6 line helper, there is only one value, we don't have to give 
it a specific name.
Line 328: if qcow2_value is None:
Line 329: qcow2_value = default_qcow2_compat()
Line 330: return qcow2_value
Line 331: if qcow2_value not in _QCOW2_COMPAT_SUPPORTED:


-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Fix calling convention.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: qemuimg: Fix calling convention.
..


Patch Set 2: Continuous-Integration+1

Network tests again

-- 
To view, visit https://gerrit.ovirt.org/64522
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87968b101ec74b08b8b049e4ed4cd83adf4aa404
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: API: modernize VM methods

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: API: modernize VM methods
..


Patch Set 18:

(1 comment)

https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py
File vdsm/API.py:

Line 263: """
Line 264: Lock user session in guest operating system using guest agent.
Line 265: """
Line 266: self.vm.guestAgent.desktopLock()
Line 267: if self.vm.guestAgent.isResponsive():
> when self.vm is called twice within the same method, would it be better to 
If we have a tight loop, yes for this code readability is most important.
Line 268: return {'status': doneCode}
Line 269: else:
Line 270: return errCode['nonresp']
Line 271: 


-- 
To view, visit https://gerrit.ovirt.org/61475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2e238fc632df97b63f7bb2a6293fe1c392a842
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: StorageDomain.getInfo - report lvm metadata device for block sd

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..


Patch Set 4:

(6 comments)

https://gerrit.ovirt.org/#/c/64433/4/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:

Line 556: pvs.update(reloaded)
Line 557: return pvs.values()
Line 558: 
Line 559: def getVgPvNames(self, vgName):
Line 560: return self.getVg(vgName).pv_name
I don't think we need this helper, getting a vg and accessing pv.name is 
perfect.
Line 561: 
Line 562: def getVgPvs(self, vgName):
Line 563: stalepvs = []
Line 564: vgpvs = []


Line 563: stalepvs = []
Line 564: vgpvs = []
Line 565: for pvName in self.getVgPvNames(vgName):
Line 566: pv = self._pvs.get(pvName)
Line 567: if pv is None or isinstance(pv, Stub):
Need to check what is the difference between None and Stub - do we need to 
reload in both case?
Line 568: stalepvs.append(pvName)
Line 569: else:
Line 570: vgpvs.append(pv)
Line 571: 


Line 568: stalepvs.append(pvName)
Line 569: else:
Line 570: vgpvs.append(pv)
Line 571: 
Line 572: vgpvs.extend(self._reloadpvs(pvName=stalepvs).values())
This line is doing too much, this style is a recipe for bugs, lets write 
simpler code like:

reloadedpvs =  self._reloadpvs(pvName=stalepvs)
vgcps.extend(reloadedpv.values())
Line 573: return vgpvs
Line 574: 
Line 575: def getVg(self, vgName):
Line 576: # Get specific VG


Line 1340: for pv in pvs:
Line 1341: try:
Line 1342: if _isMetadataPv(pv):
Line 1343: return pv
Line 1344: except AttributeError:
This code is trying to ignore unreadable pv, assuming that unreadable pv does 
not have the attribute we check in _isMetadataPv. This is very bad for two 
reasons:

- fragile, will break when someone adds this attribute to the unreadable class
- does not reveal your intent, reader has to read the underlying code to 
understand what are you trying to do.

The code should do something like:

if type(pv) is Unreadable:
# handle it...

If PV was a real class, we should do a nicer check:

if not pv.is_readable():
...

But PV is a namedtuple, a stupid readonly struct without any behavior.
Line 1345: pass
Line 1346: 
Line 1347: raise se.CannotGetVGMetadataPV(vgName)
Line 1348: 


Line 1341: try:
Line 1342: if _isMetadataPv(pv):
Line 1343: return pv
Line 1344: except AttributeError:
Line 1345: pass
This should work when the vg is ok, but if some other code or lvm itself will 
enable the metadata area on another pv, this code will silently hide this 
issue.  I prefer that abnormal configuration will fail loudly in this case.

So we can do something like:

mdpavs = [pv for pv in pvs if isMetadataPv(vg)]

And then we can fail:

if len(mdpvs) != 1):
raise InvalidVG...

return mdpvs[0]

Now we should also think what is the best solution when one of the pvs is 
unreadable. If the unreadable pv is was the metadata pv, we will fail with no 
metadata pv. If some other pv is not readable, we can return the metadata pv, 
assuming that we should have only one, or fail since we cannot read all pvs.

If we fail when one pv is unreadable, we are safer, so I tend to prefer to fail 
fast with (probably existing) UnreachablePhysicalVolume.

I don't think we want to do touch a vg with missing pv, the user has to fix 
this issue.
Line 1346: 
Line 1347: raise se.CannotGetVGMetadataPV(vgName)
Line 1348: 
Line 1349: 


Line 1346: 
Line 1347: raise se.CannotGetVGMetadataPV(vgName)
Line 1348: 
Line 1349: 
Line 1350: def _isMetadataPv(pv):
Please add docstring explaining this and referring to the place configuring pvs 
in such way.

This is also the place to fail with UnreachablePhysicalVolume if this pv is 
unreadable.
Line 1351: return pv.mda_used_count == '2'
Line 1352: 
Line 1353: 
Line 1354: def listPVNames(vgName):


-- 
To view, visit https://gerrit.ovirt.org/64433
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a7763d2ab7d796be633ecd69f661cba96e29dde
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Report generation id in volume.getInfo

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Report generation id in volume.getInfo
..


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/64485/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 6962: -   description: The status of the Volume lease
Line 6963: name: lease
Line 6964: type: *VolumeLeaseStatus
Line 6965: 
Line 6966: -   description: A monotonically increasing generation id
> How about:
Done
Line 6967: name: generation
Line 6968: type: uint
Line 6969: type: object
Line 6970: 


Line 6964: type: *VolumeLeaseStatus
Line 6965: 
Line 6966: -   description: A monotonically increasing generation id
Line 6967: name: generation
Line 6968: type: uint
> long long? int64_t?
these are keywords in the schema.  I don't think we have anything more specific 
than uint.  Java can use int64_t if it wants to use it.
Line 6969: type: object
Line 6970: 
Line 6971: VolumeSizeInfo: 
Line 6972: added: '3.1'


https://gerrit.ovirt.org/#/c/64485/1/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 205: "image": self.getImage(),
Line 206: "ctime": meta.get(sc.CTIME, ""),
Line 207: "mtime": "0",
Line 208: "legality": meta.get(sc.LEGALITY, ""),
Line 209: "generation": meta.get(sc.GENERATION, 0)
> We have this in several places, maybe we need a DEFAULT_GENERATION constant
ok.  Will add to an earlier patch.
Line 210: }
Line 211: 
Line 212: def getInfo(self):
Line 213: """


-- 
To view, visit https://gerrit.ovirt.org/64485
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62a6bb44c5f789acf3c63953f4b87c72585becc1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for generation id to VolumeMetadata

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Add support for generation id to VolumeMetadata
..


Patch Set 1:

(10 comments)

https://gerrit.ovirt.org/#/c/64484/1/lib/vdsm/storage/constants.py
File lib/vdsm/storage/constants.py:

Line 151
Line 152
Line 153
Line 154
Line 155
> Please add the new GEN line to this table.
Done


Line 154
Line 155
Line 156
Line 157
Line 158
> Please update the values after this change.
Done


Line 124: IMAGE = "IMAGE"
Line 125: DESCRIPTION = "DESCRIPTION"
Line 126: LEGALITY = "LEGALITY"
Line 127: MTIME = "MTIME"
Line 128: GENERATION = "GENID"
> GENID is not correct, id is used to identify stuff, and is usually unique, 
Done
Line 129: POOL = MDK_POOLS  # Deprecated
Line 130: 
Line 131: # In block storage, metadata size is limited to BLOCK_SIZE (512), to
Line 132: # ensure that metadata is written atomically. This is big enough for 
the


https://gerrit.ovirt.org/#/c/64484/1/lib/vdsm/storage/volumemetadata.py
File lib/vdsm/storage/volumemetadata.py:

Line 33: 
Line 34: def __init__(self, domain, image, puuid, size, format,
Line 35:  type, voltype, disktype, description="",
Line 36:  legality=constants.ILLEGAL_VOL, ctime=None, 
mtime=None,
Line 37:  generation=None):
> Why not use 0 as default value?
Done
Line 38: assert(isinstance(size, int))
Line 39: assert(ctime is None or isinstance(ctime, int))
Line 40: assert(mtime is None or isinstance(mtime, int))
Line 41: assert(generation is None or isinstance(generation, int))


Line 37:  generation=None):
Line 38: assert(isinstance(size, int))
Line 39: assert(ctime is None or isinstance(ctime, int))
Line 40: assert(mtime is None or isinstance(mtime, int))
Line 41: assert(generation is None or isinstance(generation, int))
> Using 0 as default would eliminate this
Keeping the isinstance check
Line 42: 
Line 43: # Storage domain UUID
Line 44: self.domain = domain
Line 45: # Image UUID


Line 64: self.ctime = int(time.time()) if ctime is None else ctime
Line 65: # Volume modification time (unused and should be zero)
Line 66: self.mtime = 0 if mtime is None else mtime
Line 67: # Generation ID increments each time certain operations 
complete
Line 68: self.generation = 0 if generation is None else generation
> And simplify this
Done
Line 69: 
Line 70: @classmethod
Line 71: def from_lines(cls, lines):
Line 72: md = {}


Line 89:disktype=md[constants.DISKTYPE],
Line 90:description=md[constants.DESCRIPTION],
Line 91:legality=md[constants.LEGALITY],
Line 92:ctime=int(md[constants.CTIME]),
Line 93:mtime=int(md[constants.MTIME]),
> Maybe comment here why generation may not be available.
Done
Line 94:generation=int(md.get(constants.GENERATION, 0)))
Line 95: except KeyError as e:
Line 96: raise exception.MetaDataKeyNotFoundError(
Line 97: "Missing metadata key: %s: found: %s" % (e, md))


Line 148: constants.DESCRIPTION: self.description,
Line 149: constants.PUUID: self.puuid,
Line 150: constants.MTIME: str(self.mtime),
Line 151: constants.LEGALITY: self.legality,
Line 152: constants.GENERATION: self.generation,
> This will add generation key and value to legacy storage domain - we have t
Having this volume-related code change behavior based on storage domain version 
will add its own set of complexities.  For example, we'll have to find a nice 
way of passing around the storage domain version of a volume.  Can't we just 
validate the currently released and supported versions of vdsm for their 
ability to handle unknown keys gracefully?


https://gerrit.ovirt.org/#/c/64484/1/tests/storage_volume_metadata_test.py
File tests/storage_volume_metadata_test.py:

Line 98: PUUID=params['puuid'],
Line 99: SIZE=str(params['size']),
Line 100: TYPE=params['type'],
Line 101: VOLTYPE=params['voltype'],
Line 102: GENID=params['generation'])
> If we support this only on domain version 4, we need to have a test for not
Not sure if we really want to do this.
Line 103: 
Line 104: with MonkeyPatchScope([[time, 'time', lambda: FAKE_TIME]]):
Line 105: info = volume.VolumeMetadata(**params).legacy_info()
Line 106: self.assertEqual(expected, info)


Line 187: self.assertEqual(int(data[sc.GENERATION]), md.generation)
Line 188: 
Line 189: def test_generation_default(self):
Line 190: data = make_md_dict()
Line 191: lines = make_lines(generation=None, **data)
> Do we want to support generation=None? better accept only 

Change in vdsm[master]: copy_data: Add qcow2_compat on convert.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: copy_data: Add qcow2_compat on convert.
..


Patch Set 14:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26e5dcba6fc493b32ea7764889df2918c4dfdd3
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: volume_artifacts: Add qcow2_compat on create.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: volume_artifacts: Add qcow2_compat on create.
..


Patch Set 14:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd2d53fba0dd69cdb4f60e152cf6d254cfb863a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: file_volume: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
..


Patch Set 14:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81fd3a6e263980c1eabeea7f619c9a6b48991938
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: image: Pass compat version.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: image: Pass compat version.
..


Patch Set 17:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64293
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56e01923aba982e20bda72af61db83df50373127
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: volume: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: volume: Add qcow2_compat on create
..


Patch Set 14:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64375
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8655be6da0b4cbd1c286b0c40288681a991aff19
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: Add qcow2_compat on create
..


Patch Set 14:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I331eee6a12853c2fa65e62f42c51504f88723538
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: blockVolume: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: blockVolume: Add qcow2_compat on create
..


Patch Set 14:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64376
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9fe6bf59b76b68ed8f0e60f66057c07b56d2d942
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: implementing SDM.reduce_domain_device

[automation]

gerrit-hooks has posted comments on this change.

Change subject: implementing SDM.reduce_domain_device
..


Patch Set 2:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64521
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5d3f93da11edcb626c2f050d4ce2856aa8faca0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Define the SDM.reduce_domain_device API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Define the SDM.reduce_domain_device API
..


Patch Set 11:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: implementing SDM.move_domain_device

[automation]

gerrit-hooks has posted comments on this change.

Change subject: implementing SDM.move_domain_device
..


Patch Set 8:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63270
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74183d13061d114a59da23874c86186457046e94
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: StorageDomain.getInfo - report lvm metadata device for block sd

[automation]

gerrit-hooks has posted comments on this change.

Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..


Patch Set 4:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64433
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a7763d2ab7d796be633ecd69f661cba96e29dde
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Define the SDM.move_domain_device API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Define the SDM.move_domain_device API
..


Patch Set 4:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64434
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6dce392d4cf157c42a47f70e972fa5d1d9dbdc2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: fileUtils: drop redundant warning

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: fileUtils: drop redundant warning
..


Patch Set 2:

* update_tracker: OK
* Set MODIFIED::bug 1369822#1369822OK

-- 
To view, visit https://gerrit.ovirt.org/64514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: docs: add README about logging configuration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64515
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: docs: add README about logging configuration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 2: -Code-Review

-- 
To view, visit https://gerrit.ovirt.org/64515
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: fileUtils: drop redundant warning

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: storage: fileUtils: drop redundant warning
..


storage: fileUtils: drop redundant warning

The usage of warnings.warn in the fileUtils
looks redundant, since we log the same information
in the line before.
So this patch just drops it.

Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Related-To: https://bugzilla.redhat.com/1364149
Bug-Url: https://bugzilla.redhat.com/1369822
Backport-To: 4.0
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/62208
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/64514
---
M lib/vdsm/storage/fileUtils.py
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/64514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: fileUtils: drop redundant warning

[fromani]

Francesco Romani has posted comments on this change.

Change subject: storage: fileUtils: drop redundant warning
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: logging: add and use new devel logger

[fromani]

Francesco Romani has posted comments on this change.

Change subject: logging: add and use new devel logger
..


Patch Set 3: Verified+1

verified the same way as master, with and without logging enabled

-- 
To view, visit https://gerrit.ovirt.org/64516
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: vdsm: drop the warnings module configuration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vdsm: drop the warnings module configuration
..


Patch Set 3: Verified+1

tests runs ok, so does Vdsm.

-- 
To view, visit https://gerrit.ovirt.org/64517
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I791882a2dd8ba2dda9135b087bca33610db8a20d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: fileUtils: drop redundant warning

[fromani]

Francesco Romani has posted comments on this change.

Change subject: storage: fileUtils: drop redundant warning
..


Patch Set 1: Verified+1

verified on-branch the same way as master; it is a trivial removal, I did some 
basic virt flows, as well as explicit SPM selection, without issues.

-- 
To view, visit https://gerrit.ovirt.org/64514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org