Martin Polednik has posted comments on this change.
Change subject: vm: reformat setUnresponsiveIfTimeout
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65812
To unsubscribe, visit https://gerrit.ovir
Martin Polednik has posted comments on this change.
Change subject: vm: rename statsAge parameter
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65813
To unsubscribe, visit https://gerrit.ovirt.org/se
Martin Polednik has posted comments on this change.
Change subject: network: devices: properly initialize attributes
..
Patch Set 1: Code-Review+1
Failures are caused by previous patch in the series.
--
To view, visit https:/
Martin Polednik has abandoned this change.
Change subject: caps: report nested virtualization capabilities
..
Abandoned
Actually merged (incl. Piotr's fix) with the last patch.
--
To view, visit https://gerrit.ovirt.org/65717
Martin Polednik has posted comments on this change.
Change subject: caps: return kernelArgs
..
Patch Set 1: Verified+1
I fully agree... we definitely need some "complex caps test"...
--
To view, visit https://gerrit.ovirt.org
Martin Polednik has uploaded a new change for review.
Change subject: caps: return kernelArgs
..
caps: return kernelArgs
989a73f5 accidentaly removed kernelArgs from caps with a bad rebase.
We still want to report it.
Change-Id
Martin Polednik has posted comments on this change.
Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes.
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65565
To unsubscribe, visit https:
Martin Polednik has posted comments on this change.
Change subject: vmstats: user proper way to detect host devices
..
Patch Set 1: Code-Review-1
Jenkins failure is relevant:
15:47:23 Traceback (most recent call last):
15:47:2
Martin Polednik has posted comments on this change.
Change subject: osinfo: memoize runtime_kernel_flags
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/65716
To unsubscribe, visit https://gerrit.ovirt.or
Martin Polednik has posted comments on this change.
Change subject: caps: report realtime kernel status
..
Patch Set 3: Verified+1
Tested on both RT and non-RT kernels. The check itself is not anywhere near
"robust", but it se
Martin Polednik has posted comments on this change.
Change subject: caps: report realtime kernel status
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65715/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
PS2, Lin
Martin Polednik has posted comments on this change.
Change subject: vm: introduce a `monitorable' attribute
..
Patch Set 8: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/65590/8/tests/periodicTests.py
File tests/perio
Martin Polednik has posted comments on this change.
Change subject: vm: rename statsAge parameter
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit https://gerrit.ovirt.org/se
Martin Polednik has posted comments on this change.
Change subject: vm: reformat setUnresponsiveIfTimeout
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit https://gerrit.ovir
Martin Polednik has posted comments on this change.
Change subject: caps: report realtime kernel status
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/65715/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
PS1, Li
Martin Polednik has posted comments on this change.
Change subject: vm: ignore more errors in isDomainReadyForCommands
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65131
To unsubscribe, visit https
Martin Polednik has posted comments on this change.
Change subject: vm: check stats timeout only for monitorable VMs
..
Patch Set 4:
(1 comment)
Please consider the comment just as an unfortunate remark. :) Postponing rating
Martin Polednik has posted comments on this change.
Change subject: vm: introduce a `monitorable' attribute
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/65590/7/tests/periodicTests.py
File tests/periodicTests.py:
Martin Polednik has posted comments on this change.
Change subject: vm: rename statsAge parameter
..
Patch Set 8: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/65508/8//COMMIT_MSG
Commit Message:
PS8, Line 10: and it
Martin Polednik has posted comments on this change.
Change subject: vm: reformat setUnresponsiveIfTimeout
..
Patch Set 8: Code-Review+1
I don't think there is really a need for this, but it doesn't hurt either.
Agree with Mila
Martin Polednik has uploaded a new change for review.
Change subject: caps: report nested virtualization capabilities
..
caps: report nested virtualization capabilities
Nested virtualization capability can be easily queried with
Martin Polednik has uploaded a new change for review.
Change subject: caps: report realtime kernel status
..
caps: report realtime kernel status
Determining whether system is suitable for RT operation is complex
task consisting
Martin Polednik has uploaded a new change for review.
Change subject: osinfo: memoize runtime_kernel_flags
..
osinfo: memoize runtime_kernel_flags
Unless magic is involved, we don't expect the underlying kernel to
change. Memoiz
Martin Polednik has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 51:
(1 comment)
https://gerrit.ovirt.org/#/c/54998/51/lib/vdsm/containerslib.py
File lib/vdsm/co
Martin Polednik has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 51:
(3 comments)
Slight concern regarding setup_network not in the followup patch + should
(imh
Martin Polednik has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 30:
(1 comment)
(quite important) question only, otherwise good to go
https://gerrit.ovirt.org/#/c/60481/30/vds
Martin Polednik has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 58:
(11 comments)
I believe the code is ready, just leaving some food for thought in comments.
https:
Martin Polednik has posted comments on this change.
Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65562
To unsubscribe,
Martin Polednik has posted comments on this change.
Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65562/2/lib/vdsm/numa.py
File lib/vdsm
Martin Polednik has posted comments on this change.
Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65562
To unsubscribe,
Martin Polednik has posted comments on this change.
Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..
Patch Set 1:
(2 comments)
Missing some description of behavior what is happening within engi
Martin Polednik has posted comments on this change.
Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes.
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65565
To unsubscribe, visit https:
Martin Polednik has posted comments on this change.
Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes.
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/65565/6/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py
Martin Polednik has posted comments on this change.
Change subject: virt.vmdevices.core: Add Lease device
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/65465/4/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/c
Martin Polednik has posted comments on this change.
Change subject: vm: ignore more errors in isDomainReadyForCommands
..
Patch Set 2: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/65131/2//COMMIT_MSG
Commit Message:
Martin Polednik has posted comments on this change.
Change subject: vm: a Down domain is not ready for commands
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65130
To unsubscribe, visit https://gerri
Martin Polednik has posted comments on this change.
Change subject: virt.vmdevices.core: Add Lease device
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/65465/4/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/c
Martin Polednik has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 51:
(1 comment)
https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containerslib.py
File lib/vdsm/containe
Martin Polednik has posted comments on this change.
Change subject: config: add tunables for container support
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64243
To unsubscribe, visit https://gerrit
Martin Polednik has posted comments on this change.
Change subject: osinfo: un-nest kernel version gathering function
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65379/1/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py:
Martin Polednik has posted comments on this change.
Change subject: osinfo: drop package buildtime
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/65059
To unsubscribe, visit https://gerrit.ovirt.org/sett
Martin Polednik has posted comments on this change.
Change subject: static: move man under static
..
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/62549/5/static/Makefile.am
File static/Makefile.am:
PS5, Line 24: usr
Martin Polednik has posted comments on this change.
Change subject: static: move vdsm bonding defaults under static
..
Patch Set 6:
(1 comment)
No path was hardcoded during the creation of this patch. :)
https://gerrit.ovirt.
Martin Polednik has posted comments on this change.
Change subject: osinfo: un-nest kernel version gathering function
..
Patch Set 1: Verified+1
network test failures...
--
To view, visit https://gerrit.ovirt.org/65379
To uns
Martin Polednik has posted comments on this change.
Change subject: osinfo: drop package buildtime
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/65059
To unsubscribe, visit https://gerrit.ovirt.org/sett
Martin Polednik has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 33:
(11 comments)
https://gerrit.ovirt.org/#/c/59824/33/lib/vdsm/virt/containers/command.py
Fi
Martin Polednik has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 44:
The code is somewhat fine considering the TODOs, but question remains: if I
install vdsm-con
Martin Polednik has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 51: Code-Review-1
(9 comments)
https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containersconnection.py
Martin Polednik has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 31: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56491
To unsubscribe, visit https://gerrit.ovirt
Martin Polednik has posted comments on this change.
Change subject: config: add tunables for container support
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/64243/2//COMMIT_MSG
Commit Message:
Line 5:
Martin Polednik has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 23: Code-Review-1
(6 comments)
https://gerrit.ovirt.org/#/c/60481/23/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Martin Polednik has uploaded a new change for review.
Change subject: osinfo: un-nest kernel version gathering function
..
osinfo: un-nest kernel version gathering function
Previous function, kernelDict, had unclear naming and w
Martin Polednik has posted comments on this change.
Change subject: osinfo: properly parse kernel compile time
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65059/2/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py:
Line
Martin Polednik has posted comments on this change.
Change subject: osinfo: properly parse kernel compile time
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65059/2/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py:
Line
Martin Polednik has posted comments on this change.
Change subject: osinfo: properly parse kernel compile time
..
Patch Set 2: Verified+1
Tested on standard & RT kernel -- reports correct build time for both.
--
To view, visi
Martin Polednik has uploaded a new change for review.
Change subject: osinfo: remove kernel compile time
..
osinfo: remove kernel compile time
The field is not user within newer engines and shouldn't be depended
upon as the code
Martin Polednik has posted comments on this change.
Change subject: static: move vdsm bonding defaults under static
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/62537
To unsubscribe, visit https://gerr
Martin Polednik has posted comments on this change.
Change subject: static: move man under static
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/62549
To unsubscribe, visit https://gerrit.ovirt.org/setti
Martin Polednik has posted comments on this change.
Change subject: vmxml: move condition from appendNumaTune to buildDomainXML
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/61929
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: hostdev: properly set is_hostdevice
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/62064
To unsubscribe, visit https://gerrit.ovirt.org
Martin Polednik has posted comments on this change.
Change subject: hostdev: report device MMIO numa node
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/60637
To unsubscribe, visit https://gerrit.ovirt.
Martin Polednik has posted comments on this change.
Change subject: devices: add is_hostdevice attribute
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/62063
To unsubscribe, visit https://gerrit.ovirt.or
Martin Polednik has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 17: Verified+1
jenkins false negative on networking tests
--
To view, visit https://gerrit.ovirt
Martin Polednik has posted comments on this change.
Change subject: hostdev: expose numa_node in host device
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/60638
To unsubscribe, visit https://gerrit.ovi
Martin Polednik has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/64515/3/README.logging
File README.logging:
PS3, Line 1
Martin Polednik has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/60640/16/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS16
Martin Polednik has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 15:
(2 comments)
https://gerrit.ovirt.org/#/c/60640/15/lib/vdsm/config.py.in
File lib/vdsm/config
Martin Polednik has posted comments on this change.
Change subject: build: Don't use fixed path to systemd directory
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63687
To unsubscribe, visit https://
Martin Polednik has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://ger
Martin Polednik has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 10:
The patch itself is libvirt version agnostic, it's up to 4.1 engine.
--
To view, visit https
Martin Polednik has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 9:
Jenkins failure unrelated.
--
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, v
Martin Polednik has posted comments on this change.
Change subject: tests: introducting broken_on_ci decorator
..
Patch Set 14: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63407
To unsubscribe, visit https://gerri
Martin Polednik has posted comments on this change.
Change subject: virt: migration: rename classes
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/62588/3//COMMIT_MSG
Commit Message:
PS3, Line 10: their
Martin Polednik has posted comments on this change.
Change subject: virt: sampling: add is_empty() method to StatsSample
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62417
To unsubscribe, visit http
Martin Polednik has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62418
To unsubscribe, visit https://gerrit.ovir
Martin Polednik has uploaded a new change for review.
Change subject: static: move man
..
static: move man
Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490
Signed-off-by: Martin Polednik
---
M static/Makefile.am
R static/us
Martin Polednik has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/59031/7/lib/vdsm/host/rngsources.py
File lib/vdsm/hos
Martin Polednik has posted comments on this change.
Change subject: static: move vdsm bonding defaults under static
..
Patch Set 1: Verified-1
breaks tests, similar to mom (but better handled)
--
To view, visit https://gerrit
Martin Polednik has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/59031/7/lib/vdsm/host/rngsources.py
File lib/vdsm/hos
Martin Polednik has uploaded a new change for review.
Change subject: static: move vdsm bonding defaults under static
..
static: move vdsm bonding defaults under static
Part of the move of static files to new directory. The file
Martin Polednik has posted comments on this change.
Change subject: configs: move logrotate to static
..
Patch Set 14:
Rebased again.
--
To view, visit https://gerrit.ovirt.org/61616
To unsubscribe, visit https://gerrit.ovirt
Martin Polednik has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61822
To unsubscribe, visit https://gerrit.ovir
Martin Polednik has posted comments on this change.
Change subject: virt: sampling: add is_empty() method to StatsSample
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61821
To unsubscribe, visit http
Martin Polednik has posted comments on this change.
Change subject: tests: sampling: add FakeClock helper
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61820
To unsubscribe, visit https://gerrit.ovir
Martin Polednik has posted comments on this change.
Change subject: configs: move limits to static
..
Patch Set 14: Verified+1
--
To view, visit https://gerrit.ovirt.org/61605
To unsubscribe, visit https://gerrit.ovirt.org/set
Martin Polednik has posted comments on this change.
Change subject: configs: move systemd service files to static
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/61763
To unsubscribe, visit https://gerri
Martin Polednik has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 1: Code-Review-1
Agree with Piotr, why is this needed? (I have a feeling that vhostmd is
required on ppc?)
-
Martin Polednik has uploaded a new change for review.
Change subject: devices: add is_hostdevice attribute
..
devices: add is_hostdevice attribute
is_hostdevice attribute is currently used to determine whether given
device is so
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: properly set is_hostdevice
..
hostdev: properly set is_hostdevice
Since we added is_hostdevice attribute to all devices, and the
attribute defaults t
Martin Polednik has abandoned this change.
Change subject: vmxml: add appendNumaTune return value
..
Abandoned
Not needed
--
To view, visit https://gerrit.ovirt.org/61106
To unsubscribe, visit https://gerrit.ovirt.org/setting
Martin Polednik has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/60640/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1
Martin Polednik has posted comments on this change.
Change subject: configs: move modprobe files loading to static
..
Patch Set 9: Verified+1
Verified as before, only commit message update & rebase.
--
To view, visit https://
Martin Polednik has posted comments on this change.
Change subject: configs: move sysctl to static
..
Patch Set 12: Verified+1
Verified as before, only commit message update & rebase.
--
To view, visit https://gerrit.ovirt.or
Martin Polednik has posted comments on this change.
Change subject: configs: move limits to static
..
Patch Set 12: Verified+1
Verified as before, only commit message update & rebase.
--
To view, visit https://gerrit.ovirt.or
Martin Polednik has posted comments on this change.
Change subject: configs: move kernel module loading to static
..
Patch Set 11: Verified+1
Verified as before, only commit message update & rebase.
--
To view, visit https://
Martin Polednik has posted comments on this change.
Change subject: configs: move systemd service files to static
..
Patch Set 10: Verified+1
Verified as before, only commit message update & rebase.
--
To view, visit https://
Martin Polednik has posted comments on this change.
Change subject: configs: move logrotate to static
..
Patch Set 11: Verified+1
Verified as before, only commit message update & rebase.
--
To view, visit https://gerrit.ovirt
Martin Polednik has posted comments on this change.
Change subject: configs: move rwtab to static
..
Patch Set 11: Verified+1
Verified as before, only commit message update & rebase.
--
To view, visit https://gerrit.ovirt.org
Martin Polednik has posted comments on this change.
Change subject: configs: move logger to static
..
Patch Set 9: Verified+1
Verified as before, only commit message update & rebase.
--
To view, visit https://gerrit.ovirt.org
Martin Polednik has posted comments on this change.
Change subject: configs: move sudoers to static
..
Patch Set 12: Verified+1
Verified as before, only commit message update & rebase.
--
To view, visit https://gerrit.ovirt.o
1 - 100 of 1562 matches
Mail list logo
