date:20190701

[webkit-changes] [246964] trunk/Source

2019-07-01 Thread carlosgc

Title: [246964] trunk/Source








Revision 246964
Author carlo...@webkit.org
Date 2019-07-01 01:09:46 -0700 (Mon, 01 Jul 2019)


Log Message
WebSockets: add support for sending blob messages when using web sockets platform APIs
https://bugs.webkit.org/show_bug.cgi?id=199189

Reviewed by Youenn Fablet.

Source/WebCore:

* Headers.cmake: Add missing headers.

Source/WebKit:

Add helper private class BlobLoader that uses FileReaderLoader to load the blobs. Since blob loads are
asynchronous, the messages are queued using another helper internal class PendingMessage.

* WebProcess/Network/WebSocketChannel.cpp:
(WebKit::WebSocketChannel::increaseBufferedAmount): Increase the buffered amount checking we don't overlofw.
(WebKit::WebSocketChannel::decreaseBufferedAmount): Decrease the buffered amount.
(WebKit::WebSocketChannel::sendMessage): Helper class to send message to the network process and decrease the
buffered amount when done.
(WebKit::WebSocketChannel::send): Queue the message in pending queue if there are pending messages in the queue
for text and binary messages. For blobs, always queue the message unless it's an empty blob that we can handle
as empty binary data directly.
(WebKit::PendingMessage::PendingMessage): Helper class to queue message requests.
(WebKit::PendingMessage::type const): Type of message: Text, Binary, Blob.
(WebKit::PendingMessage::textMessage const): The text message.
(WebKit::PendingMessage::binaryData const): The binary data.
(WebKit::PendingMessage::blobLoader const): The blob loader.
(WebKit::WebSocketChannel::fail): Notify the client about the error to ensure onclose is emitted.
(WebKit::WebSocketChannel::disconnect): Clear the pending messages queue.
* WebProcess/Network/WebSocketChannel.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/fileapi/FileReaderLoader.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Network/WebSocketChannel.cpp
trunk/Source/WebKit/WebProcess/Network/WebSocketChannel.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (246963 => 246964)

--- trunk/Source/WebCore/ChangeLog	2019-07-01 08:01:19 UTC (rev 246963)
+++ trunk/Source/WebCore/ChangeLog	2019-07-01 08:09:46 UTC (rev 246964)
@@ -1,3 +1,12 @@
+2019-07-01  Carlos Garcia Campos  
+
+WebSockets: add support for sending blob messages when using web sockets platform APIs
+https://bugs.webkit.org/show_bug.cgi?id=199189
+
+Reviewed by Youenn Fablet.
+
+* Headers.cmake: Add missing headers.
+
 2019-07-01  Miguel Gomez  
 
 [WPE][GTK] Content disappearing when using CSS transforms


Modified: trunk/Source/WebCore/Headers.cmake (246963 => 246964)

--- trunk/Source/WebCore/Headers.cmake	2019-07-01 08:01:19 UTC (rev 246963)
+++ trunk/Source/WebCore/Headers.cmake	2019-07-01 08:09:46 UTC (rev 246964)
@@ -515,7 +515,9 @@
 fileapi/BlobLineEndings.h
 fileapi/BlobPropertyBag.h
 fileapi/File.h
+fileapi/FileError.h
 fileapi/FileList.h
+fileapi/FileReaderLoader.h
 fileapi/FileReaderLoaderClient.h
 
 history/BackForwardClient.h
@@ -1168,6 +1170,7 @@
 platform/network/BlobPart.h
 platform/network/BlobRegistry.h
 platform/network/BlobRegistryImpl.h
+platform/network/BlobResourceHandle.h
 platform/network/CacheValidation.h
 platform/network/CertificateInfoBase.h
 platform/network/CookieRequestHeaderFieldProxy.h


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (246963 => 246964)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2019-07-01 08:01:19 UTC (rev 246963)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2019-07-01 08:09:46 UTC (rev 246964)
@@ -857,12 +857,12 @@
 		2E4346510F546A8200B0F1BA /* WorkerObjectProxy.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E43463F0F546A8200B0F1BA /* WorkerObjectProxy.h */; };
 		2E4346530F546A8200B0F1BA /* WorkerRunLoop.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E4346410F546A8200B0F1BA /* WorkerRunLoop.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		2E4346550F546A8200B0F1BA /* WorkerThread.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E4346430F546A8200B0F1BA /* WorkerThread.h */; settings = {ATTRIBUTES = (Private, ); }; };
-		2E75841E12779ADA0062628B /* FileReaderLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E75841B12779ADA0062628B /* FileReaderLoader.h */; };
+		2E75841E12779ADA0062628B /* FileReaderLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E75841B12779ADA0062628B /* FileReaderLoader.h */; settings = {ATTRIBUTES = (Private, ); };};
 		2E75841F12779ADA0062628B /* FileReaderLoaderClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E75841C12779ADA0062628B /* FileReaderLoaderClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		2E94F43C119207DA00B7F75D /* JSFileReader.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E94F43A119207DA00B7F75D /* JSFileReader.h */; };

[webkit-changes] [246968] releases/WebKitGTK/webkit-2.24/Source/WebCore

2019-07-01 Thread carlosgc

Title: [246968] releases/WebKitGTK/webkit-2.24/Source/WebCore








Revision 246968
Author carlo...@webkit.org
Date 2019-07-01 01:53:03 -0700 (Mon, 01 Jul 2019)


Log Message
Merge r246399 - [GStreamer] HLS stream slow start
https://bugs.webkit.org/show_bug.cgi?id=198377

Reviewed by Xabier Rodriguez-Calvar.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcCreate): Cut down the adapter condition to 200 ms to
improve start-up times for HLS playback.

Modified Paths

releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog (246967 => 246968)

--- releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog	2019-07-01 08:52:59 UTC (rev 246967)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog	2019-07-01 08:53:03 UTC (rev 246968)
@@ -1,3 +1,14 @@
+2019-06-13  Philippe Normand  
+
+[GStreamer] HLS stream slow start
+https://bugs.webkit.org/show_bug.cgi?id=198377
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+(webKitWebSrcCreate): Cut down the adapter condition to 200 ms to
+improve start-up times for HLS playback.
+
 2019-05-28  Yacine Bandou  
 
 [MSE][GStreamer] update the readyState correctly in MediaPlayerPrivateGStreamerMSE


Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (246967 => 246968)

--- releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp	2019-07-01 08:52:59 UTC (rev 246967)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp	2019-07-01 08:53:03 UTC (rev 246968)
@@ -389,7 +389,9 @@
 unsigned retries = 0;
 size_t available = gst_adapter_available_fast(priv->adapter.get());
 while (available < size && !isAdapterDrained) {
-priv->adapterCondition.waitFor(priv->adapterLock, Seconds(1));
+priv->adapterCondition.waitFor(priv->adapterLock, 200_ms, [&] {
+return gst_adapter_available_fast(priv->adapter.get()) >= size;
+});
 retries++;
 available = gst_adapter_available_fast(priv->adapter.get());
 if (available && available < size)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [246971] releases/WebKitGTK/webkit-2.24/Source/WebCore

2019-07-01 Thread carlosgc

Title: [246971] releases/WebKitGTK/webkit-2.24/Source/WebCore








Revision 246971
Author carlo...@webkit.org
Date 2019-07-01 01:53:14 -0700 (Mon, 01 Jul 2019)


Log Message
Merge r246731 - [GStreamer][MSE] Pausing video sometimes causes skip to finish
https://bugs.webkit.org/show_bug.cgi?id=197355

Reviewed by Philippe Normand.

Covered by existing tests.

* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::currentMediaTime const):
Assuming that when m_eosPending is on and we're paused() that the
network resource is fully loaded and the end is reached is clearly
wrong. Whether this is now correct is unclear...

Modified Paths

releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog (246970 => 246971)

--- releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog	2019-07-01 08:53:10 UTC (rev 246970)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog	2019-07-01 08:53:14 UTC (rev 246971)
@@ -1,5 +1,20 @@
 2019-06-24  Charlie Turner  
 
+[GStreamer][MSE] Pausing video sometimes causes skip to finish
+https://bugs.webkit.org/show_bug.cgi?id=197355
+
+Reviewed by Philippe Normand.
+
+Covered by existing tests.
+
+* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
+(WebCore::MediaPlayerPrivateGStreamerMSE::currentMediaTime const):
+Assuming that when m_eosPending is on and we're paused() that the
+network resource is fully loaded and the end is reached is clearly
+wrong. Whether this is now correct is unclear...
+
+2019-06-24  Charlie Turner  
+
 [GStreamer] Volume level sometimes changes inappropriately
 https://bugs.webkit.org/show_bug.cgi?id=197358
 


Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp (246970 => 246971)

--- releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp	2019-07-01 08:53:10 UTC (rev 246970)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp	2019-07-01 08:53:14 UTC (rev 246971)
@@ -758,7 +758,7 @@
 {
 MediaTime position = MediaPlayerPrivateGStreamer::currentMediaTime();
 
-if (m_eosPending && (paused() || (position >= durationMediaTime( {
+if (m_eosPending && position >= durationMediaTime()) {
 if (m_networkState != MediaPlayer::Loaded) {
 m_networkState = MediaPlayer::Loaded;
 m_player->networkStateChanged();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [246967] releases/WebKitGTK/webkit-2.24

2019-07-01 Thread carlosgc

Title: [246967] releases/WebKitGTK/webkit-2.24








Revision 246967
Author carlo...@webkit.org
Date 2019-07-01 01:52:59 -0700 (Mon, 01 Jul 2019)


Log Message
Merge r246353 - [WPE][GTK] Deprecate WebSQL APIs
https://bugs.webkit.org/show_bug.cgi?id=195011

Reviewed by Carlos Garcia Campos.

Source/WebKit:

* UIProcess/API/glib/WebKitSettings.cpp:
(webkit_settings_class_init):
* UIProcess/API/glib/WebKitWebContext.cpp:
(webkitWebContextConstructed):
* UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
(webkitWebsiteDataManagerGetProperty):
(webkit_website_data_manager_class_init):
* UIProcess/API/gtk/WebKitWebsiteData.h:
* UIProcess/API/gtk/WebKitWebsiteDataManager.h:
* UIProcess/API/wpe/WebKitWebsiteData.h:
* UIProcess/API/wpe/WebKitWebsiteDataManager.h:

Tools:

* MiniBrowser/gtk/main.c:
(gotWebsiteDataCallback):
* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataConfiguration):
(testWebsiteDataEphemeral):
(testWebsiteDataDatabases):

Modified Paths

releases/WebKitGTK/webkit-2.24/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.24/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
releases/WebKitGTK/webkit-2.24/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp
releases/WebKitGTK/webkit-2.24/Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp
releases/WebKitGTK/webkit-2.24/Source/WebKit/UIProcess/API/gtk/WebKitWebsiteData.h
releases/WebKitGTK/webkit-2.24/Source/WebKit/UIProcess/API/gtk/WebKitWebsiteDataManager.h
releases/WebKitGTK/webkit-2.24/Source/WebKit/UIProcess/API/wpe/WebKitWebsiteData.h
releases/WebKitGTK/webkit-2.24/Source/WebKit/UIProcess/API/wpe/WebKitWebsiteDataManager.h
releases/WebKitGTK/webkit-2.24/Tools/ChangeLog
releases/WebKitGTK/webkit-2.24/Tools/MiniBrowser/gtk/main.c
releases/WebKitGTK/webkit-2.24/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.24/Source/WebKit/ChangeLog (246966 => 246967)

--- releases/WebKitGTK/webkit-2.24/Source/WebKit/ChangeLog	2019-07-01 08:52:52 UTC (rev 246966)
+++ releases/WebKitGTK/webkit-2.24/Source/WebKit/ChangeLog	2019-07-01 08:52:59 UTC (rev 246967)
@@ -1,3 +1,22 @@
+2019-06-12  Michael Catanzaro  
+
+[WPE][GTK] Deprecate WebSQL APIs
+https://bugs.webkit.org/show_bug.cgi?id=195011
+
+Reviewed by Carlos Garcia Campos.
+
+* UIProcess/API/glib/WebKitSettings.cpp:
+(webkit_settings_class_init):
+* UIProcess/API/glib/WebKitWebContext.cpp:
+(webkitWebContextConstructed):
+* UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
+(webkitWebsiteDataManagerGetProperty):
+(webkit_website_data_manager_class_init):
+* UIProcess/API/gtk/WebKitWebsiteData.h:
+* UIProcess/API/gtk/WebKitWebsiteDataManager.h:
+* UIProcess/API/wpe/WebKitWebsiteData.h:
+* UIProcess/API/wpe/WebKitWebsiteDataManager.h:
+
 2019-05-23  Adrian Perez de Castro  
 
 [WPE] Build fails with ENABLE_VIDEO=OFF and ENABLE_WEB_AUDIO=OFF


Modified: releases/WebKitGTK/webkit-2.24/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp (246966 => 246967)

--- releases/WebKitGTK/webkit-2.24/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp	2019-07-01 08:52:52 UTC (rev 246966)
+++ releases/WebKitGTK/webkit-2.24/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp	2019-07-01 08:52:59 UTC (rev 246967)
@@ -674,12 +674,7 @@
 /**
  * WebKitSettings:enable-html5-database:
  *
- * Whether to enable HTML5 client-side SQL database support. Client-side
- * SQL database allows web pages to store structured data and be able to
- * use SQL to manipulate that data asynchronously.
- *
- * HTML5 database specification is available at
- * http://www.w3.org/TR/webdatabase/.
+ * Whether to enable HTML5 client-side SQL database support (IndexedDB).
  */
 g_object_class_install_property(gObjectClass,
 PROP_ENABLE_HTML5_DATABASE,
@@ -1715,7 +1710,7 @@
  *
  * Get the #WebKitSettings:enable-html5-database property.
  *
- * Returns: %TRUE If HTML5 database support is enabled or %FALSE otherwise.
+ * Returns: %TRUE if IndexedDB support is enabled or %FALSE otherwise.
  */
 gboolean webkit_settings_get_enable_html5_database(WebKitSettings* settings)
 {


Modified: releases/WebKitGTK/webkit-2.24/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp (246966 => 246967)

--- releases/WebKitGTK/webkit-2.24/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp	2019-07-01 08:52:52 UTC (rev 246966)
+++ releases/WebKitGTK/webkit-2.24/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp	2019-07-01 08:52:59 UTC (rev 246967)
@@ -344,7 +344,9 @@
 configuration.setDiskCacheDirectory(FileSystem::pathByAppendingComponent(FileSystem::stringFromFileSystemRepresentation(webkit_website_data_manager_get_disk_cache_directory(priv->websiteDataManager.get())), networkCacheSubdirectory));

[webkit-changes] [246969] releases/WebKitGTK/webkit-2.24/Source/WebCore

2019-07-01 Thread carlosgc

Title: [246969] releases/WebKitGTK/webkit-2.24/Source/WebCore








Revision 246969
Author carlo...@webkit.org
Date 2019-07-01 01:53:06 -0700 (Mon, 01 Jul 2019)


Log Message
Merge r246710 - webkitgtk 2.24.2 fails to build w/gstreamer 1.12.5
https://bugs.webkit.org/show_bug.cgi?id=198080

Patch by Mike Gorse  on 2019-06-22
Reviewed by Philippe Normand.

No new tests (build fix only).

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
Move includes of gst/gl/gl.h and epoxy/gl.h into
MediaPlayerPrivateGStreamerBase.h.

Modified Paths

releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h




Diff

Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog (246968 => 246969)

--- releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog	2019-07-01 08:53:03 UTC (rev 246968)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog	2019-07-01 08:53:06 UTC (rev 246969)
@@ -1,3 +1,17 @@
+2019-06-22  Mike Gorse  
+
+webkitgtk 2.24.2 fails to build w/gstreamer 1.12.5
+https://bugs.webkit.org/show_bug.cgi?id=198080
+
+Reviewed by Philippe Normand.
+
+No new tests (build fix only).
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
+Move includes of gst/gl/gl.h and epoxy/gl.h into
+MediaPlayerPrivateGStreamerBase.h.
+
 2019-06-13  Philippe Normand  
 
 [GStreamer] HLS stream slow start


Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (246968 => 246969)

--- releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp	2019-07-01 08:53:03 UTC (rev 246968)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp	2019-07-01 08:53:06 UTC (rev 246969)
@@ -66,25 +66,7 @@
 
 #include 
 
-#if USE(LIBEPOXY)
-// Include the  header before .
-#include 
 
-// Workaround build issue with RPi userland GLESv2 headers and libepoxy 
-#if !GST_CHECK_VERSION(1, 14, 0)
-#include 
-#if defined(GST_GL_HAVE_WINDOW_DISPMANX) && GST_GL_HAVE_WINDOW_DISPMANX
-#define __gl2_h_
-#undef GST_GL_HAVE_GLSYNC
-#define GST_GL_HAVE_GLSYNC 1
-#endif
-#endif // !GST_CHECK_VERSION(1, 14, 0)
-#endif // USE(LIBEPOXY)
-
-#define GST_USE_UNSTABLE_API
-#include 
-#undef GST_USE_UNSTABLE_API
-
 #include "GLContext.h"
 #if USE(GLX)
 #include "GLContextGLX.h"


Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h (246968 => 246969)

--- releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h	2019-07-01 08:53:03 UTC (rev 246968)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h	2019-07-01 08:53:06 UTC (rev 246969)
@@ -37,6 +37,25 @@
 #include 
 #include 
 
+#if USE(LIBEPOXY)
+// Include the  header before .
+#include 
+
+// Workaround build issue with RPi userland GLESv2 headers and libepoxy 
+#if !GST_CHECK_VERSION(1, 14, 0)
+#include 
+#if defined(GST_GL_HAVE_WINDOW_DISPMANX) && GST_GL_HAVE_WINDOW_DISPMANX
+#define __gl2_h_
+#undef GST_GL_HAVE_GLSYNC
+#define GST_GL_HAVE_GLSYNC 1
+#endif
+#endif // !GST_CHECK_VERSION(1, 14, 0)
+#endif // USE(LIBEPOXY)
+
+#define GST_USE_UNSTABLE_API
+#include 
+#undef GST_USE_UNSTABLE_API
+
 #if USE(TEXTURE_MAPPER_GL)
 #include "TextureMapperGL.h"
 #if USE(NICOSIA)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [246979] releases/WebKitGTK/webkit-2.24

2019-07-01 Thread carlosgc

Title: [246979] releases/WebKitGTK/webkit-2.24








Revision 246979
Author carlo...@webkit.org
Date 2019-07-01 02:21:40 -0700 (Mon, 01 Jul 2019)


Log Message
Merge r246309 - [cairo][SVG] Putting multiple path elements in clippath causes rendering artifacts
https://bugs.webkit.org/show_bug.cgi?id=198701

Source/WebCore:

PlatformContextCairo::pushImageMask blits wrong position of the
surface to the background of masking objects. And, I don't know
the reason why this blitting is needed. Removed the blitting.

Reviewed by Carlos Garcia Campos.

Tests: svg/clip-path/clip-opacity.html
   svg/clip-path/svg-in-html.html

* platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::pushImageMask): Don't blit the
surface to the background.

LayoutTests:

Reviewed by Carlos Garcia Campos.

* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:
Unskipped svg/gradients/spreadMethodDiagonal3.svg and svg/gradients/spreadMethodDiagonal4.svg.

* svg/clip-path/clip-opacity-expected.html: Added.
* svg/clip-path/clip-opacity.html: Added.
* svg/clip-path/svg-in-html-expected.html: Added.
* svg/clip-path/svg-in-html.html: Added.

Modified Paths

releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.24/LayoutTests/platform/gtk/TestExpectations
releases/WebKitGTK/webkit-2.24/LayoutTests/platform/wpe/TestExpectations
releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp


Added Paths

releases/WebKitGTK/webkit-2.24/LayoutTests/svg/clip-path/clip-opacity-expected.html
releases/WebKitGTK/webkit-2.24/LayoutTests/svg/clip-path/clip-opacity.html
releases/WebKitGTK/webkit-2.24/LayoutTests/svg/clip-path/svg-in-html-expected.html
releases/WebKitGTK/webkit-2.24/LayoutTests/svg/clip-path/svg-in-html.html




Diff

Modified: releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog (246978 => 246979)

--- releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog	2019-07-01 08:53:43 UTC (rev 246978)
+++ releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog	2019-07-01 09:21:40 UTC (rev 246979)
@@ -1,3 +1,19 @@
+2019-06-11  Fujii Hironori  
+
+[cairo][SVG] Putting multiple path elements in clippath causes rendering artifacts
+https://bugs.webkit.org/show_bug.cgi?id=198701
+
+Reviewed by Carlos Garcia Campos.
+
+* platform/gtk/TestExpectations:
+* platform/wpe/TestExpectations:
+Unskipped svg/gradients/spreadMethodDiagonal3.svg and svg/gradients/spreadMethodDiagonal4.svg.
+
+* svg/clip-path/clip-opacity-expected.html: Added.
+* svg/clip-path/clip-opacity.html: Added.
+* svg/clip-path/svg-in-html-expected.html: Added.
+* svg/clip-path/svg-in-html.html: Added.
+
 2019-06-18  Zan Dobersek  
 
 [WebGL] Extensions3DOpenGLES::bindVertexArrayOES() should allow zero array object


Modified: releases/WebKitGTK/webkit-2.24/LayoutTests/platform/gtk/TestExpectations (246978 => 246979)

--- releases/WebKitGTK/webkit-2.24/LayoutTests/platform/gtk/TestExpectations	2019-07-01 08:53:43 UTC (rev 246978)
+++ releases/WebKitGTK/webkit-2.24/LayoutTests/platform/gtk/TestExpectations	2019-07-01 09:21:40 UTC (rev 246979)
@@ -3572,8 +3572,6 @@
 webkit.org/b/189737 editing/pasteboard/4930986-3-paste-as-quotation.html [ Failure ]
 
 webkit.org/b/189739 svg/gradients/spreadMethodClose2.svg [ ImageOnlyFailure ]
-webkit.org/b/189739 svg/gradients/spreadMethodDiagonal3.svg [ ImageOnlyFailure ]
-webkit.org/b/189739 svg/gradients/spreadMethodDiagonal4.svg [ ImageOnlyFailure ]
 
 webkit.org/b/189994 fast/files/xhr-response-blob.html [ Failure ]
 


Modified: releases/WebKitGTK/webkit-2.24/LayoutTests/platform/wpe/TestExpectations (246978 => 246979)

--- releases/WebKitGTK/webkit-2.24/LayoutTests/platform/wpe/TestExpectations	2019-07-01 08:53:43 UTC (rev 246978)
+++ releases/WebKitGTK/webkit-2.24/LayoutTests/platform/wpe/TestExpectations	2019-07-01 09:21:40 UTC (rev 246979)
@@ -1319,8 +1319,6 @@
 webkit.org/b/160137 svg/custom/non-scaling-stroke-update.svg [ ImageOnlyFailure Pass ]
 webkit.org/b/112228 svg/custom/resources-css-scaled.html [ ImageOnlyFailure ]
 webkit.org/b/189739 svg/gradients/spreadMethodClose2.svg [ ImageOnlyFailure ]
-webkit.org/b/189739 svg/gradients/spreadMethodDiagonal3.svg [ ImageOnlyFailure ]
-webkit.org/b/189739 svg/gradients/spreadMethodDiagonal4.svg [ ImageOnlyFailure ]
 webkit.org/b/115440 svg/stroke/animated-non-scaling-stroke.html [ ImageOnlyFailure Pass ]
 webkit.org/b/88230 svg/stroke/non-scaling-stroke-pattern.svg [ ImageOnlyFailure Pass ]
 webkit.org/b/137096 svg/text/alt-glyph-for-surrogate-pair.svg [ ImageOnlyFailure ]


Added: releases/WebKitGTK/webkit-2.24/LayoutTests/svg/clip-path/clip-opacity-expected.html (0 => 246979)

--- releases/WebKitGTK/webkit-2.24/LayoutTests/svg/clip-path/clip-opacity-expected.html	(rev 0)
+++

[webkit-changes] [247000] releases/WebKitGTK/webkit-2.24

2019-07-01 Thread carlosgc

Title: [247000] releases/WebKitGTK/webkit-2.24








Revision 247000
Author carlo...@webkit.org
Date 2019-07-01 04:04:11 -0700 (Mon, 01 Jul 2019)


Log Message
Merge r242114 - wasmToJS() should purify incoming NaNs.
https://bugs.webkit.org/show_bug.cgi?id=194807


Reviewed by Saam Barati.

JSTests:

* wasm/regress/wasmToJS-should-purify-NaNs.js: Added.

Source/_javascript_Core:

* runtime/JSCJSValue.h:
(JSC::jsNumber):
* runtime/TypedArrayAdaptors.h:
(JSC::IntegralTypedArrayAdaptor::toJSValue):
* wasm/js/WasmToJS.cpp:
(JSC::Wasm::wasmToJS):

Modified Paths

releases/WebKitGTK/webkit-2.24/JSTests/ChangeLog
releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog




Diff

Modified: releases/WebKitGTK/webkit-2.24/JSTests/ChangeLog (246999 => 247000)

--- releases/WebKitGTK/webkit-2.24/JSTests/ChangeLog	2019-07-01 11:04:08 UTC (rev 246999)
+++ releases/WebKitGTK/webkit-2.24/JSTests/ChangeLog	2019-07-01 11:04:11 UTC (rev 247000)
@@ -1,3 +1,13 @@
+2019-02-26  Mark Lam  
+
+wasmToJS() should purify incoming NaNs.
+https://bugs.webkit.org/show_bug.cgi?id=194807
+
+
+Reviewed by Saam Barati.
+
+* wasm/regress/wasmToJS-should-purify-NaNs.js: Added.
+
 2019-06-04  Tadeu Zagallo  
 
 Argument elimination should check for negative indices in GetByVal


Modified: releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog (246999 => 247000)

--- releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog	2019-07-01 11:04:08 UTC (rev 246999)
+++ releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog	2019-07-01 11:04:11 UTC (rev 247000)
@@ -1,3 +1,18 @@
+2019-02-26  Mark Lam  
+
+wasmToJS() should purify incoming NaNs.
+https://bugs.webkit.org/show_bug.cgi?id=194807
+
+
+Reviewed by Saam Barati.
+
+* runtime/JSCJSValue.h:
+(JSC::jsNumber):
+* runtime/TypedArrayAdaptors.h:
+(JSC::IntegralTypedArrayAdaptor::toJSValue):
+* wasm/js/WasmToJS.cpp:
+(JSC::Wasm::wasmToJS):
+
 2019-06-04  Tadeu Zagallo  
 
 Argument elimination should check for negative indices in GetByVal






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [246998] releases/WebKitGTK/webkit-2.24

2019-07-01 Thread carlosgc

Title: [246998] releases/WebKitGTK/webkit-2.24








Revision 246998
Author carlo...@webkit.org
Date 2019-07-01 04:04:03 -0700 (Mon, 01 Jul 2019)


Log Message
Merge r246332 - AI BitURShift's result should not be unsigned
https://bugs.webkit.org/show_bug.cgi?id=198689


Reviewed by Saam Barati.

JSTests:

* stress/urshift-int32-overflow.js: Added.
(foo.):
(foo):

Source/_javascript_Core:

Treating BitURShift's result as unsigned in the abstract interpreter incorrectly overflows it.
This breaks the DFG and FTL, since they assume that BitURShift's result is an int32 value, but
get a double constant from AI. Since the result will be converted to unsigned by UInt32ToNumber,
all we have to do is store the result as a signed int32.

* dfg/DFGAbstractInterpreterInlines.h:

Modified Paths

releases/WebKitGTK/webkit-2.24/JSTests/ChangeLog
releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h


Added Paths

releases/WebKitGTK/webkit-2.24/JSTests/stress/urshift-int32-overflow.js




Diff

Modified: releases/WebKitGTK/webkit-2.24/JSTests/ChangeLog (246997 => 246998)

--- releases/WebKitGTK/webkit-2.24/JSTests/ChangeLog	2019-07-01 11:04:00 UTC (rev 246997)
+++ releases/WebKitGTK/webkit-2.24/JSTests/ChangeLog	2019-07-01 11:04:03 UTC (rev 246998)
@@ -1,3 +1,15 @@
+2019-06-10  Tadeu Zagallo  
+
+AI BitURShift's result should not be unsigned
+https://bugs.webkit.org/show_bug.cgi?id=198689
+
+
+Reviewed by Saam Barati.
+
+* stress/urshift-int32-overflow.js: Added.
+(foo.):
+(foo):
+
 2019-05-07  Yusuke Suzuki  
 
 [JSC] DFG_ASSERT failed in lowInt52


Added: releases/WebKitGTK/webkit-2.24/JSTests/stress/urshift-int32-overflow.js (0 => 246998)

--- releases/WebKitGTK/webkit-2.24/JSTests/stress/urshift-int32-overflow.js	(rev 0)
+++ releases/WebKitGTK/webkit-2.24/JSTests/stress/urshift-int32-overflow.js	2019-07-01 11:04:03 UTC (rev 246998)
@@ -0,0 +1,18 @@
+//@ requireOptions("--forceEagerCompilation=1")
+
+function foo() {
+const v22 = [];
+for (let i = 0; i < 3; i++) {
+for (let j = 0; j < 8; j++) {
+({x: -766834598 >>> !v22});
+}
+(function v31(v32) { })();
+}
+return {};
+}
+
+const v2 = [];
+const proxy = new Proxy(Array, { getPrototypeOf: foo });
+for (let i = 0; i < 1000; i++) {
+v2.__proto__ = proxy;
+}


Modified: releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog (246997 => 246998)

--- releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog	2019-07-01 11:04:00 UTC (rev 246997)
+++ releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog	2019-07-01 11:04:03 UTC (rev 246998)
@@ -1,3 +1,18 @@
+2019-06-10  Tadeu Zagallo  
+
+AI BitURShift's result should not be unsigned
+https://bugs.webkit.org/show_bug.cgi?id=198689
+
+
+Reviewed by Saam Barati.
+
+Treating BitURShift's result as unsigned in the abstract interpreter incorrectly overflows it.
+This breaks the DFG and FTL, since they assume that BitURShift's result is an int32 value, but
+get a double constant from AI. Since the result will be converted to unsigned by UInt32ToNumber,
+all we have to do is store the result as a signed int32.
+
+* dfg/DFGAbstractInterpreterInlines.h:
+
 2019-06-06  Michael Catanzaro  
 
 aarch64: ‘JSC::ARM64Assembler::LinkRecordRealTypes::m_compareRegister’ is too small to hold all values of ‘JSC::ARM64Assembler::RegisterID’ {aka ‘enum JSC::ARM64Registers::RegisterID’}


Modified: releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h (246997 => 246998)

--- releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h	2019-07-01 11:04:00 UTC (rev 246997)
+++ releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h	2019-07-01 11:04:03 UTC (rev 246998)
@@ -433,13 +433,13 @@
 setConstant(node, JSValue(a ^ b));
 break;
 case BitRShift:
-setConstant(node, JSValue(a >> static_cast(b)));
+setConstant(node, JSValue(a >> (static_cast(b) & 0x1f)));
 break;
 case BitLShift:
-setConstant(node, JSValue(a << static_cast(b)));
+setConstant(node, JSValue(a << (static_cast(b) & 0x1f)));
 break;
 case BitURShift:
-setConstant(node, JSValue(static_cast(a) >> static_cast(b)));
+setConstant(node, JSValue(static_cast(static_cast(a) >> (static_cast(b) & 0x1f;
 break;
 default:
 RELEASE_ASSERT_NOT_REACHED();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [246997] releases/WebKitGTK/webkit-2.24/LayoutTests

2019-07-01 Thread carlosgc

Title: [246997] releases/WebKitGTK/webkit-2.24/LayoutTests








Revision 246997
Author carlo...@webkit.org
Date 2019-07-01 04:04:00 -0700 (Mon, 01 Jul 2019)


Log Message
Merge r246287 - [CSP] Blob URLs should inherit their CSP policy
https://bugs.webkit.org/show_bug.cgi?id=198579


Reviewed by Brent Fulgham.

Actually add the tests that I inadvertently omitted from r246277.

* http/tests/security/contentSecurityPolicy/navigate-self-to-blob-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/navigate-self-to-blob.html: Added.
* http/tests/security/contentSecurityPolicy/navigate-self-to-data-url-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/navigate-self-to-data-url.html: Added.

Modified Paths

releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog


Added Paths

releases/WebKitGTK/webkit-2.24/LayoutTests/http/tests/security/contentSecurityPolicy/navigate-self-to-blob-expected.txt
releases/WebKitGTK/webkit-2.24/LayoutTests/http/tests/security/contentSecurityPolicy/navigate-self-to-blob.html
releases/WebKitGTK/webkit-2.24/LayoutTests/http/tests/security/contentSecurityPolicy/navigate-self-to-data-url-expected.txt
releases/WebKitGTK/webkit-2.24/LayoutTests/http/tests/security/contentSecurityPolicy/navigate-self-to-data-url.html




Diff

Modified: releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog (246996 => 246997)

--- releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog	2019-07-01 11:03:55 UTC (rev 246996)
+++ releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog	2019-07-01 11:04:00 UTC (rev 246997)
@@ -6,6 +6,21 @@
 
 Reviewed by Brent Fulgham.
 
+Actually add the tests that I inadvertently omitted from r246277.
+
+* http/tests/security/contentSecurityPolicy/navigate-self-to-blob-expected.txt: Added.
+* http/tests/security/contentSecurityPolicy/navigate-self-to-blob.html: Added.
+* http/tests/security/contentSecurityPolicy/navigate-self-to-data-url-expected.txt: Added.
+* http/tests/security/contentSecurityPolicy/navigate-self-to-data-url.html: Added.
+
+2019-06-10  Daniel Bates  
+
+[CSP] Blob URLs should inherit their CSP policy
+https://bugs.webkit.org/show_bug.cgi?id=198579
+
+
+Reviewed by Brent Fulgham.
+
 Add tests to ensure that a self navigation to a Blob or Data URL inherits its CSP policy from
 its parent document.
 


Added: releases/WebKitGTK/webkit-2.24/LayoutTests/http/tests/security/contentSecurityPolicy/navigate-self-to-blob-expected.txt (0 => 246997)

--- releases/WebKitGTK/webkit-2.24/LayoutTests/http/tests/security/contentSecurityPolicy/navigate-self-to-blob-expected.txt	(rev 0)
+++ releases/WebKitGTK/webkit-2.24/LayoutTests/http/tests/security/contentSecurityPolicy/navigate-self-to-blob-expected.txt	2019-07-01 11:04:00 UTC (rev 246997)
@@ -0,0 +1,2 @@
+CONSOLE MESSAGE: line 1: Refused to execute a script because its hash, its nonce, or 'unsafe-inline' does not appear in the script-src directive of the Content Security Policy.
+Blob page


Added: releases/WebKitGTK/webkit-2.24/LayoutTests/http/tests/security/contentSecurityPolicy/navigate-self-to-blob.html (0 => 246997)

--- releases/WebKitGTK/webkit-2.24/LayoutTests/http/tests/security/contentSecurityPolicy/navigate-self-to-blob.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.24/LayoutTests/http/tests/security/contentSecurityPolicy/navigate-self-to-blob.html	2019-07-01 11:04:00 UTC (rev 246997)
@@ -0,0 +1,17 @@
+
+
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+let blob = new Blob(["