[webkit-changes] [240426] branches/safari-607-branch
Title: [240426] branches/safari-607-branch Revision 240426 Author alanc...@apple.com Date 2019-01-23 22:42:58 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240327. rdar://problem/47494707 REGRESSION(r239612) Crash at runtime due to broken DFG assumption https://bugs.webkit.org/show_bug.cgi?id=193709 Unreviewed, rollout to watch the tests. JSTests: * stress/object-tostring-changed-proto.js: Removed. * stress/object-tostring-changed.js: Removed. * stress/object-tostring-misc.js: Removed. * stress/object-tostring-other.js: Removed. * stress/object-tostring-untyped.js: Removed. Source/_javascript_Core: * _javascript_Core.xcodeproj/project.pbxproj: * dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter::executeEffects): * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handleIntrinsicCall): * dfg/DFGClobberize.h: (JSC::DFG::clobberize): * dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC): * dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): (JSC::DFG::FixupPhase::fixupObjectToString): Deleted. * dfg/DFGNodeType.h: * dfg/DFGOperations.cpp: * dfg/DFGOperations.h: * dfg/DFGPredictionPropagationPhase.cpp: * dfg/DFGSafeToExecute.h: (JSC::DFG::safeToExecute): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileObjectToString): Deleted. * dfg/DFGSpeculativeJIT.h: * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): * ftl/FTLAbstractHeapRepository.h: * ftl/FTLCapabilities.cpp: (JSC::FTL::canCompile): * ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileNode): (JSC::FTL::DFG::LowerDFGToB3::compileToStringOrCallStringConstructorOrStringValueOf): (JSC::FTL::DFG::LowerDFGToB3::compileObjectToString): Deleted. * runtime/Intrinsic.cpp: (JSC::intrinsicName): * runtime/Intrinsic.h: * runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::finishCreation): (JSC::objectProtoFuncToString): * runtime/ObjectPrototype.h: * runtime/ObjectPrototypeInlines.h: Removed. * runtime/StructureRareData.h: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240327 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/JSTests/ChangeLog branches/safari-607-branch/Source/_javascript_Core/ChangeLog branches/safari-607-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj branches/safari-607-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h branches/safari-607-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp branches/safari-607-branch/Source/_javascript_Core/dfg/DFGClobberize.h branches/safari-607-branch/Source/_javascript_Core/dfg/DFGDoesGC.cpp branches/safari-607-branch/Source/_javascript_Core/dfg/DFGFixupPhase.cpp branches/safari-607-branch/Source/_javascript_Core/dfg/DFGNodeType.h branches/safari-607-branch/Source/_javascript_Core/dfg/DFGOperations.cpp branches/safari-607-branch/Source/_javascript_Core/dfg/DFGOperations.h branches/safari-607-branch/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp branches/safari-607-branch/Source/_javascript_Core/dfg/DFGSafeToExecute.h branches/safari-607-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp branches/safari-607-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h branches/safari-607-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp branches/safari-607-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp branches/safari-607-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h branches/safari-607-branch/Source/_javascript_Core/ftl/FTLCapabilities.cpp branches/safari-607-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp branches/safari-607-branch/Source/_javascript_Core/runtime/Intrinsic.cpp branches/safari-607-branch/Source/_javascript_Core/runtime/Intrinsic.h branches/safari-607-branch/Source/_javascript_Core/runtime/ObjectPrototype.cpp branches/safari-607-branch/Source/_javascript_Core/runtime/ObjectPrototype.h branches/safari-607-branch/Source/_javascript_Core/runtime/StructureRareData.h Removed Paths branches/safari-607-branch/JSTests/stress/object-tostring-changed-proto.js branches/safari-607-branch/JSTests/stress/object-tostring-changed.js branches/safari-607-branch/JSTests/stress/object-tostring-misc.js branches/safari-607-branch/JSTests/stress/object-tostring-other.js branches/safari-607-branch/JSTests/stress/object-tostring-untyped.js branches/safari-607-branch/Source/_javascript_Core/runtime/ObjectPrototypeInlines.h Diff Modified: branches/safari-607-branch/JSTests/ChangeLog (240425 => 240426) --- branches/safari-607-branch/JSTests/ChangeLog 2019-01-24 06:42:49 UTC (rev 240425) +++ branches/safari-607-branch/JSTests/ChangeLog 2019-01-24 06:42:58 UTC (rev 240426) @@ -1,5 +1,83 @@ 2019-01-23 Alan Coon
[webkit-changes] [240425] branches/safari-607-branch/Source/WebKit
Title: [240425] branches/safari-607-branch/Source/WebKit Revision 240425 Author alanc...@apple.com Date 2019-01-23 22:42:49 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240325. rdar://problem/47494727 Regression(r240178) Some API tests are crashing https://bugs.webkit.org/show_bug.cgi?id=193680 Reviewed by Alex Christensen. r240178 made sure that userScripts / scriptMessageHandlers / contentExtensions are always properly populated in the WebPageCreationParameters. This was needed in case we need to reconstruct the WebUserContentController on the WebProcess side. However, this caused a regression in the case we reuse a process where the WebUserContentController still exists (because it was kept alive, e.g. by the WebPageGroup). In that case, we would add duplicate entries to the existing WebUserContentController instance because its "add" methods did not have duplicate checks. To address the issue, this patch adds duplicate checks to the WebUserContentController "add" methods. * WebProcess/UserContent/WebUserContentController.cpp: (WebKit::WebUserContentController::addUserScriptMessageHandlerInternal): (WebKit::WebUserContentController::removeUserScriptMessageHandlerInternal): (WebKit::WebUserContentController::addUserScriptInternal): (WebKit::WebUserContentController::removeUserScriptInternal): (WebKit::WebUserContentController::addUserStyleSheetInternal): (WebKit::WebUserContentController::removeUserStyleSheetInternal): (WebKit::WebUserContentController::forEachUserMessageHandler const): * WebProcess/UserContent/WebUserContentController.h: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240325 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/WebKit/ChangeLog branches/safari-607-branch/Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp branches/safari-607-branch/Source/WebKit/WebProcess/UserContent/WebUserContentController.h Diff Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240424 => 240425) --- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 06:42:46 UTC (rev 240424) +++ branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 06:42:49 UTC (rev 240425) @@ -1,5 +1,61 @@ 2019-01-23 Alan Coon +Cherry-pick r240325. rdar://problem/47494727 + +Regression(r240178) Some API tests are crashing +https://bugs.webkit.org/show_bug.cgi?id=193680 + +Reviewed by Alex Christensen. + +r240178 made sure that userScripts / scriptMessageHandlers / contentExtensions are always +properly populated in the WebPageCreationParameters. This was needed in case we need to +reconstruct the WebUserContentController on the WebProcess side. However, this caused a +regression in the case we reuse a process where the WebUserContentController still exists +(because it was kept alive, e.g. by the WebPageGroup). In that case, we would add duplicate +entries to the existing WebUserContentController instance because its "add" methods did not +have duplicate checks. To address the issue, this patch adds duplicate checks to the +WebUserContentController "add" methods. + +* WebProcess/UserContent/WebUserContentController.cpp: +(WebKit::WebUserContentController::addUserScriptMessageHandlerInternal): +(WebKit::WebUserContentController::removeUserScriptMessageHandlerInternal): +(WebKit::WebUserContentController::addUserScriptInternal): +(WebKit::WebUserContentController::removeUserScriptInternal): +(WebKit::WebUserContentController::addUserStyleSheetInternal): +(WebKit::WebUserContentController::removeUserStyleSheetInternal): +(WebKit::WebUserContentController::forEachUserMessageHandler const): +* WebProcess/UserContent/WebUserContentController.h: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240325 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-22 Chris Dumez + +Regression(r240178) Some API tests are crashing +https://bugs.webkit.org/show_bug.cgi?id=193680 + +Reviewed by Alex Christensen. + +r240178 made sure that userScripts / scriptMessageHandlers / contentExtensions are always +properly populated in the WebPageCreationParameters. This was needed in case we need to +reconstruct the WebUserContentController on the WebProcess side. However, this caused a +regression in the case we reuse a process where the WebUserContentController still exists +(because it was kept alive, e.g. by the WebPageGroup). In that case, we would add duplicate +entries to the existing WebUserContentController instance because its "add" methods did not +have duplicate checks. To address the issue, this patch adds duplicate checks to the +WebUserContentController "add" methods. + +*
[webkit-changes] [240421] branches/safari-607-branch
Title: [240421] branches/safari-607-branch
Revision 240421
Author alanc...@apple.com
Date 2019-01-23 22:42:32 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r240206. rdar://problem/47357218
Reviewed by Eric Carlson.
If there is a deviceId constraint, remove any empty string from ideal/exact string list.
This will make the device selection be solely based on other constraints.
An improvement might be for 'exact' constraint to pick the default device.
There is currently no such notion of a default device.
Picking the best fitting device seems a good tradeoff.
Covered by updated test.
* platform/mediastream/MediaConstraints.cpp:
(WebCore::MediaTrackConstraintSetMap::set):
* platform/mediastream/MediaConstraints.h:
(WebCore::StringConstraint::removeEmptyStringConstraint):
Modified Paths
branches/safari-607-branch/LayoutTests/fast/mediastream/get-user-media-device-id-expected.txt
branches/safari-607-branch/LayoutTests/fast/mediastream/get-user-media-device-id.html
branches/safari-607-branch/Source/WebCore/ChangeLog
branches/safari-607-branch/Source/WebCore/platform/mediastream/MediaConstraints.cpp
branches/safari-607-branch/Source/WebCore/platform/mediastream/MediaConstraints.h
Diff
Modified: branches/safari-607-branch/LayoutTests/fast/mediastream/get-user-media-device-id-expected.txt (240420 => 240421)
--- branches/safari-607-branch/LayoutTests/fast/mediastream/get-user-media-device-id-expected.txt 2019-01-24 06:42:28 UTC (rev 240420)
+++ branches/safari-607-branch/LayoutTests/fast/mediastream/get-user-media-device-id-expected.txt 2019-01-24 06:42:32 UTC (rev 240421)
@@ -3,4 +3,5 @@
PASS Collect device IDs
PASS Pass device IDs as exact constraints
PASS Pass device IDs as optional constraints
+PASS Exact device IDs with special values: empty string, null, undefined
Modified: branches/safari-607-branch/LayoutTests/fast/mediastream/get-user-media-device-id.html (240420 => 240421)
--- branches/safari-607-branch/LayoutTests/fast/mediastream/get-user-media-device-id.html 2019-01-24 06:42:28 UTC (rev 240420)
+++ branches/safari-607-branch/LayoutTests/fast/mediastream/get-user-media-device-id.html 2019-01-24 06:42:32 UTC (rev 240421)
@@ -70,6 +70,15 @@
}, "Pass device IDs as optional constraints");
+promise_test(async (test) => {
+await navigator.mediaDevices.getUserMedia({ audio: {deviceId: {exact: ""}}});
+await navigator.mediaDevices.getUserMedia({ video: {deviceId: {exact: [""]}}});
+await navigator.mediaDevices.getUserMedia({ audio: {deviceId: {exact: undefined}}});
+
+await navigator.mediaDevices.getUserMedia({ audio: {deviceId: {exact: null}}}).then(assert_unreached, () => { });
+await navigator.mediaDevices.getUserMedia({ audio: {deviceId: {exact: "test"}}}).then(assert_unreached, () => { });
+}, "Exact device IDs with special values: empty string, null, undefined");
+
Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (240420 => 240421)
--- branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 06:42:28 UTC (rev 240420)
+++ branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 06:42:32 UTC (rev 240421)
@@ -1,3 +1,25 @@
+2019-01-19 Youenn Fablet
+
+Cherry-pick r240206. rdar://problem/47357218
+
+getUserMedia with a deviceId exact constraint with an empty string value should succeed
+https://bugs.webkit.org/show_bug.cgi?id=193541
+
+
+Reviewed by Eric Carlson.
+
+If there is a deviceId constraint, remove any empty string from ideal/exact string list.
+This will make the device selection be solely based on other constraints.
+An improvement might be for 'exact' constraint to pick the default device.
+There is currently no such notion of a default device.
+Picking the best fitting device seems a good tradeoff.
+Covered by updated test.
+
+* platform/mediastream/MediaConstraints.cpp:
+(WebCore::MediaTrackConstraintSetMap::set):
+* platform/mediastream/MediaConstraints.h:
+(WebCore::StringConstraint::removeEmptyStringConstraint):
+
2019-01-23 Alan Coon
Cherry-pick r239965. rdar://problem/47295360
Modified: branches/safari-607-branch/Source/WebCore/platform/mediastream/MediaConstraints.cpp (240420 => 240421)
--- branches/safari-607-branch/Source/WebCore/platform/mediastream/MediaConstraints.cpp 2019-01-24 06:42:28 UTC (rev 240420)
+++ branches/safari-607-branch/Source/WebCore/platform/mediastream/MediaConstraints.cpp 2019-01-24 06:42:32 UTC (rev 240421)
@@ -315,6 +315,8 @@
m_facingMode = WTFMove(constraint);
break;
case MediaConstraintType::DeviceId:
+if (constraint)
+constraint->removeEmptyStringConstraint();
m_deviceId = WTFMove(constraint);
break;
case MediaConstraintType::GroupId:
Modified: branches/safari-607-branch/Source/WebCore/platform/mediastream/MediaConstraints.h
[webkit-changes] [240420] branches/safari-607-branch/Source/WebCore/PAL
Title: [240420] branches/safari-607-branch/Source/WebCore/PAL Revision 240420 Author alanc...@apple.com Date 2019-01-23 22:42:28 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240184. rdar://problem/47484242 Follow-up: Override the session configuration for cookieAcceptPolicy Discussed with John Wilander. * pal/spi/cf/CFNetworkSPI.h: Declare new SPI for the internal macOS 10.12 Sierra SDK since it will never appear in those headers. This fixes the build for trunk WebKit on Sierra. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240184 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/WebCore/PAL/ChangeLog branches/safari-607-branch/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h Diff Modified: branches/safari-607-branch/Source/WebCore/PAL/ChangeLog (240419 => 240420) --- branches/safari-607-branch/Source/WebCore/PAL/ChangeLog 2019-01-24 06:42:26 UTC (rev 240419) +++ branches/safari-607-branch/Source/WebCore/PAL/ChangeLog 2019-01-24 06:42:28 UTC (rev 240420) @@ -1,5 +1,33 @@ 2019-01-23 Alan Coon +Cherry-pick r240184. rdar://problem/47484242 + +Follow-up: Override the session configuration for cookieAcceptPolicy + + + +Discussed with John Wilander. + +* pal/spi/cf/CFNetworkSPI.h: Declare new SPI for the internal +macOS 10.12 Sierra SDK since it will never appear in those +headers. This fixes the build for trunk WebKit on Sierra. + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240184 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-18 David Kilzer + +Follow-up: Override the session configuration for cookieAcceptPolicy + + + +Discussed with John Wilander. + +* pal/spi/cf/CFNetworkSPI.h: Declare new SPI for the internal +macOS 10.12 Sierra SDK since it will never appear in those +headers. This fixes the build for trunk WebKit on Sierra. + +2019-01-23 Alan Coon + Cherry-pick r239947. rdar://problem/47295371 Re-enable ability to build --cloop builds. Modified: branches/safari-607-branch/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h (240419 => 240420) --- branches/safari-607-branch/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2019-01-24 06:42:26 UTC (rev 240419) +++ branches/safari-607-branch/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2019-01-24 06:42:28 UTC (rev 240420) @@ -62,6 +62,15 @@ #import #endif +// This only needs to be declared on macOS 10.12 Sierra because +// it will never appear in those SDK headers. See also +// HAVE(CFNETWORK_OVERRIDE_SESSION_COOKIE_ACCEPT_POLICY). +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED == 101200 +@interface NSHTTPCookieStorage () +@property (nonatomic, readwrite) BOOL _overrideSessionCookieAcceptPolicy; +@end +#endif + #else // !PLATFORM(WIN) && !USE(APPLE_INTERNAL_SDK) typedef CF_ENUM(int64_t, _TimingDataOptions) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240427] branches/safari-607-branch/Source/JavaScriptCore/dfg/ DFGByteCodeParser.cpp
Title: [240427] branches/safari-607-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp Revision 240427 Author alanc...@apple.com Date 2019-01-23 22:43:01 -0800 (Wed, 23 Jan 2019) Log Message Unreviewed build fix. rdar://problem/47458234 Modified Paths branches/safari-607-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp Diff Modified: branches/safari-607-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (240426 => 240427) --- branches/safari-607-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2019-01-24 06:42:58 UTC (rev 240426) +++ branches/safari-607-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2019-01-24 06:43:01 UTC (rev 240427) @@ -4928,9 +4928,9 @@ Node* op1 = get(bytecode.m_lhs); Node* op2 = get(bytecode.m_rhs); if (isInt32Speculation(getPrediction())) -set(bytecode.dst, addToGraph(ArithBitAnd, op1, op2)); +set(bytecode.m_dst, addToGraph(ArithBitAnd, op1, op2)); else -set(bytecode.dst, addToGraph(ValueBitAnd, op1, op2)); +set(bytecode.m_dst, addToGraph(ValueBitAnd, op1, op2)); NEXT_OPCODE(op_bitand); } @@ -4939,9 +4939,9 @@ Node* op1 = get(bytecode.m_lhs); Node* op2 = get(bytecode.m_rhs); if (isInt32Speculation(getPrediction())) -set(bytecode.dst, addToGraph(ArithBitOr, op1, op2)); +set(bytecode.m_dst, addToGraph(ArithBitOr, op1, op2)); else -set(bytecode.dst, addToGraph(ValueBitOr, op1, op2)); +set(bytecode.m_dst, addToGraph(ValueBitOr, op1, op2)); NEXT_OPCODE(op_bitor); } @@ -4950,9 +4950,9 @@ Node* op1 = get(bytecode.m_lhs); Node* op2 = get(bytecode.m_rhs); if (isInt32Speculation(getPrediction())) -set(bytecode.dst, addToGraph(ArithBitXor, op1, op2)); +set(bytecode.m_dst, addToGraph(ArithBitXor, op1, op2)); else -set(bytecode.dst, addToGraph(ValueBitXor, op1, op2)); +set(bytecode.m_dst, addToGraph(ValueBitXor, op1, op2)); NEXT_OPCODE(op_bitor); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240419] branches/safari-607-branch
Title: [240419] branches/safari-607-branch Revision 240419 Author alanc...@apple.com Date 2019-01-23 22:42:26 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240178. rdar://problem/47494727 Regression(PSON) Content blockers are sometimes lost on back navigation cross-site https://bugs.webkit.org/show_bug.cgi?id=193588 Reviewed by Alex Christensen. Source/WebKit: When the WebPageProxy needs to create initialization parameters for its WebPage in the WebContent process, it calls WebProcessProxy::addWebUserContentControllerProxy() which calls WebUserContentControllerProxy::addProcess(). This last call is supposed to register the WebProcessProxy with the WebUserContentControllerProxy and adding the contentRuleLists to the WebPageCreationParameters. The issue is that if the WebUserContentControllerProxy already knows about this WebProcessProxy, it would return early and not populate the WebPageCreationParameters. In PSON world, when navigating back to a page that failed to enter page cache, we reuse the process where we previously loaded the page but re-create a new WebPage on the WebContent process site. When this happens, WebUserContentControllerProxy would not add the contentRuleLists to the WebPageCreationParameters and the new WebPage in the previously-suspended process would be missing them. * UIProcess/UserContent/WebUserContentControllerProxy.cpp: (WebKit::WebUserContentControllerProxy::addProcess): Tools: Add layout test coverage. * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240178 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/WebKit/ChangeLog branches/safari-607-branch/Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp branches/safari-607-branch/Tools/ChangeLog branches/safari-607-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Diff Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240418 => 240419) --- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 06:42:22 UTC (rev 240418) +++ branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 06:42:26 UTC (rev 240419) @@ -1,5 +1,67 @@ 2019-01-23 Alan Coon +Cherry-pick r240178. rdar://problem/47494727 + +Regression(PSON) Content blockers are sometimes lost on back navigation cross-site +https://bugs.webkit.org/show_bug.cgi?id=193588 + + +Reviewed by Alex Christensen. + +Source/WebKit: + +When the WebPageProxy needs to create initialization parameters for its WebPage in the +WebContent process, it calls WebProcessProxy::addWebUserContentControllerProxy() +which calls WebUserContentControllerProxy::addProcess(). This last call is supposed to +register the WebProcessProxy with the WebUserContentControllerProxy and adding the +contentRuleLists to the WebPageCreationParameters. The issue is that if the +WebUserContentControllerProxy already knows about this WebProcessProxy, it would return +early and not populate the WebPageCreationParameters. + +In PSON world, when navigating back to a page that failed to enter page cache, we reuse +the process where we previously loaded the page but re-create a new WebPage on the +WebContent process site. When this happens, WebUserContentControllerProxy would not +add the contentRuleLists to the WebPageCreationParameters and the new WebPage in the +previously-suspended process would be missing them. + +* UIProcess/UserContent/WebUserContentControllerProxy.cpp: +(WebKit::WebUserContentControllerProxy::addProcess): + +Tools: + +Add layout test coverage. + +* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240178 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-18 Chris Dumez + +Regression(PSON) Content blockers are sometimes lost on back navigation cross-site +https://bugs.webkit.org/show_bug.cgi?id=193588 + + +Reviewed by Alex Christensen. + +When the WebPageProxy needs to create initialization parameters for its WebPage in the +WebContent process, it calls WebProcessProxy::addWebUserContentControllerProxy() +which calls WebUserContentControllerProxy::addProcess(). This last call is supposed to +register the WebProcessProxy with the WebUserContentControllerProxy and adding the +contentRuleLists to the WebPageCreationParameters. The issue is that if the +WebUserContentControllerProxy already knows about this WebProcessProxy, it would return +early and not populate the WebPageCreationParameters. + +In PSON world, when navigating back to a page that failed to enter
[webkit-changes] [240422] branches/safari-607-branch/Source/WebInspectorUI
Title: [240422] branches/safari-607-branch/Source/WebInspectorUI
Revision 240422
Author alanc...@apple.com
Date 2019-01-23 22:42:35 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r240290. rdar://problem/47494764
Web Inspector: Network Table appears broken after filter - rows look collapsed
https://bugs.webkit.org/show_bug.cgi?id=192730
Patch by Joseph Pecoraro on 2019-01-22
Reviewed by Devin Rousso.
* UserInterface/Views/Table.js:
(WI.Table.prototype._applyColumnWidthsToColumnsIfNeeded):
Affect the filler row like the other applyColumnWidths calls since this
now may be the initial call to size visible columns.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/Source/WebInspectorUI/ChangeLog
branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/Table.js
Diff
Modified: branches/safari-607-branch/Source/WebInspectorUI/ChangeLog (240421 => 240422)
--- branches/safari-607-branch/Source/WebInspectorUI/ChangeLog 2019-01-24 06:42:32 UTC (rev 240421)
+++ branches/safari-607-branch/Source/WebInspectorUI/ChangeLog 2019-01-24 06:42:35 UTC (rev 240422)
@@ -1,5 +1,36 @@
2019-01-23 Alan Coon
+Cherry-pick r240290. rdar://problem/47494764
+
+Web Inspector: Network Table appears broken after filter - rows look collapsed
+https://bugs.webkit.org/show_bug.cgi?id=192730
+
+
+Patch by Joseph Pecoraro on 2019-01-22
+Reviewed by Devin Rousso.
+
+* UserInterface/Views/Table.js:
+(WI.Table.prototype._applyColumnWidthsToColumnsIfNeeded):
+Affect the filler row like the other applyColumnWidths calls since this
+now may be the initial call to size visible columns.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-22 Joseph Pecoraro
+
+Web Inspector: Network Table appears broken after filter - rows look collapsed
+https://bugs.webkit.org/show_bug.cgi?id=192730
+
+
+Reviewed by Devin Rousso.
+
+* UserInterface/Views/Table.js:
+(WI.Table.prototype._applyColumnWidthsToColumnsIfNeeded):
+Affect the filler row like the other applyColumnWidths calls since this
+now may be the initial call to size visible columns.
+
+2019-01-23 Alan Coon
+
Cherry-pick r239935. rdar://problem/47295382
Web Inspector: Styles: pressing Down key on empty value field shouldn't discard completion popover
Modified: branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/Table.js (240421 => 240422)
--- branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/Table.js 2019-01-24 06:42:32 UTC (rev 240421)
+++ branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/Table.js 2019-01-24 06:42:35 UTC (rev 240422)
@@ -1153,11 +1153,13 @@
{
// Apply and create missing cells only if row needs a width update.
for (let row of this._listElement.children) {
-if (row.__widthGeneration !== this._widthGeneration && row !== this._fillerRow) {
+if (row.__widthGeneration !== this._widthGeneration) {
for (let i = 0; i < row.children.length; ++i)
row.children[i].style.width = this._columnWidths[i] + "px";
-if (row.children.length !== this._visibleColumns.length)
-this._populateRow(row);
+if (row !== this._fillerRow) {
+if (row.children.length !== this._visibleColumns.length)
+this._populateRow(row);
+}
row.__widthGeneration = this._widthGeneration;
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240417] branches/safari-607-branch/LayoutTests
Title: [240417] branches/safari-607-branch/LayoutTests Revision 240417 Author alanc...@apple.com Date 2019-01-23 22:42:19 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r239966. rdar://problem/47295366 Restructure http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html to address flakiness https://bugs.webkit.org/show_bug.cgi?id=191211 Unreviewed test gardening. This test is flaky on the MacOS WK2 bot. The patch avoids a page navigation and redirect which may avoid the code that changed in https://trac.webkit.org/changeset/237735/webkit and made the test more flaky. * http/tests/resourceLoadStatistics/remove-blocking-in-redirect-expected.txt: * http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239966 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/LayoutTests/ChangeLog branches/safari-607-branch/LayoutTests/http/tests/resourceLoadStatistics/remove-blocking-in-redirect-expected.txt branches/safari-607-branch/LayoutTests/http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html Diff Modified: branches/safari-607-branch/LayoutTests/ChangeLog (240416 => 240417) --- branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-24 06:42:16 UTC (rev 240416) +++ branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-24 06:42:19 UTC (rev 240417) @@ -1,5 +1,41 @@ 2019-01-23 Alan Coon +Cherry-pick r239966. rdar://problem/47295366 + +Restructure http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html to address flakiness +https://bugs.webkit.org/show_bug.cgi?id=191211 + + +Unreviewed test gardening. + +This test is flaky on the MacOS WK2 bot. The patch avoids a page navigation and +redirect which may avoid the code that changed in +https://trac.webkit.org/changeset/237735/webkit and made the test more flaky. + + +* http/tests/resourceLoadStatistics/remove-blocking-in-redirect-expected.txt: +* http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239966 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-14 John Wilander + +Restructure http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html to address flakiness +https://bugs.webkit.org/show_bug.cgi?id=191211 + + +Unreviewed test gardening. + +This test is flaky on the MacOS WK2 bot. The patch avoids a page navigation and +redirect which may avoid the code that changed in +https://trac.webkit.org/changeset/237735/webkit and made the test more flaky. + +* http/tests/resourceLoadStatistics/remove-blocking-in-redirect-expected.txt: +* http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html: + +2019-01-23 Alan Coon + Cherry-pick r239965. rdar://problem/47295360 Animation and other code is too aggressive about invalidating layer composition Modified: branches/safari-607-branch/LayoutTests/http/tests/resourceLoadStatistics/remove-blocking-in-redirect-expected.txt (240416 => 240417) --- branches/safari-607-branch/LayoutTests/http/tests/resourceLoadStatistics/remove-blocking-in-redirect-expected.txt 2019-01-24 06:42:16 UTC (rev 240416) +++ branches/safari-607-branch/LayoutTests/http/tests/resourceLoadStatistics/remove-blocking-in-redirect-expected.txt 2019-01-24 06:42:19 UTC (rev 240417) @@ -11,6 +11,12 @@ Frame: '' +Set cookie. + + + +Frame: '' + Should receive first-party cookie. Received cookie named 'firstPartyCookie'. Did not receive cookie named 'partitionedCookie'. @@ -17,7 +23,7 @@ Client-side document.cookie: firstPartyCookie=value -Frame: '' +Frame: '' Redirect case 1, should receive first-party cookie for 127.0.0.1. Received cookie named 'firstPartyCookie'. @@ -25,13 +31,13 @@ Client-side document.cookie: firstPartyCookie=127.0.0.1 -Frame: '' +Frame: '' Try to set third-party cookie in blocked mode. -Frame: '' +Frame: '' Should receive no cookie. Did not receive cookie named 'firstPartyCookie'. @@ -39,7 +45,7 @@ Client-side document.cookie: -Frame: '' +Frame: '' Redirect case 2, should receive first-party cookie for 127.0.0.1. Received cookie named 'firstPartyCookie'. Modified: branches/safari-607-branch/LayoutTests/http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html (240416 => 240417) --- branches/safari-607-branch/LayoutTests/http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html 2019-01-24 06:42:16 UTC (rev 240416) +++ branches/safari-607-branch/LayoutTests/http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html 2019-01-24 06:42:19 UTC (rev 240417) @@ -18,7 +18,6 @@ const
[webkit-changes] [240413] branches/safari-607-branch/Source/WebCore
Title: [240413] branches/safari-607-branch/Source/WebCore
Revision 240413
Author alanc...@apple.com
Date 2019-01-23 22:41:57 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r239946. rdar://problem/47295375
https://bugs.webkit.org/show_bug.cgi?id=193403
Continue fix in r239711 by using WeakPtr in SourceBufferPrivateAVFObjC.
Reviewed by Eric Carlson.
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::setCDMSession):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/Source/WebCore/ChangeLog
branches/safari-607-branch/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h
branches/safari-607-branch/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
Diff
Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (240412 => 240413)
--- branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 06:41:54 UTC (rev 240412)
+++ branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 06:41:57 UTC (rev 240413)
@@ -1,5 +1,35 @@
2019-01-23 Alan Coon
+Cherry-pick r239946. rdar://problem/47295375
+
+https://bugs.webkit.org/show_bug.cgi?id=193403
+
+
+Continue fix in r239711 by using WeakPtr in SourceBufferPrivateAVFObjC.
+
+Reviewed by Eric Carlson.
+
+* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
+* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
+(WebCore::SourceBufferPrivateAVFObjC::setCDMSession):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-14 Jer Noble
+
+https://bugs.webkit.org/show_bug.cgi?id=193403
+
+
+Continue fix in r239711 by using WeakPtr in SourceBufferPrivateAVFObjC.
+
+Reviewed by Eric Carlson.
+
+* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
+* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
+(WebCore::SourceBufferPrivateAVFObjC::setCDMSession):
+
+2019-01-23 Alan Coon
+
Cherry-pick r239927. rdar://problem/47295363
DOMCacheStorage: use-after-move in doSequentialMatch()
Modified: branches/safari-607-branch/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h (240412 => 240413)
--- branches/safari-607-branch/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h 2019-01-24 06:41:54 UTC (rev 240412)
+++ branches/safari-607-branch/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h 2019-01-24 06:41:57 UTC (rev 240413)
@@ -180,7 +180,7 @@
MediaSourcePrivateAVFObjC* m_mediaSource;
SourceBufferPrivateClient* m_client { nullptr };
#if ENABLE(LEGACY_ENCRYPTED_MEDIA)
-CDMSessionMediaSourceAVFObjC* m_session { nullptr };
+WeakPtr m_session { nullptr };
#endif
#if ENABLE(ENCRYPTED_MEDIA) && HAVE(AVCONTENTKEYSESSION)
RefPtr m_cdmInstance;
Modified: branches/safari-607-branch/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm (240412 => 240413)
--- branches/safari-607-branch/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm 2019-01-24 06:41:54 UTC (rev 240412)
+++ branches/safari-607-branch/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm 2019-01-24 06:41:57 UTC (rev 240413)
@@ -908,7 +908,7 @@
if (m_session)
m_session->removeSourceBuffer(this);
-m_session = session;
+m_session = makeWeakPtr(session);
if (m_session) {
m_session->addSourceBuffer(this);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240424] branches/safari-607-branch
Title: [240424] branches/safari-607-branch Revision 240424 Author alanc...@apple.com Date 2019-01-23 22:42:46 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240320. rdar://problem/47494587 Resync libwebrtc with latest M72 branch https://bugs.webkit.org/show_bug.cgi?id=193693 LayoutTests/imported/w3c: Reviewed by Eric Carlson. * web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt: Source/ThirdParty/libwebrtc: Reviewed by Eric Carlson. Update libwebrtc up to latest M72 branch to fix some identified issues: - Bad bandwidth estimation in case of multiple transceivers - mid handling for legacy endpoints - msid handling for updating mediastreams accordingly. * Source/webrtc/modules/congestion_controller/goog_cc/delay_based_bwe.cc: * Source/webrtc/modules/congestion_controller/goog_cc/delay_based_bwe.h: * Source/webrtc/modules/congestion_controller/goog_cc/goog_cc_network_control.cc: * Source/webrtc/modules/congestion_controller/goog_cc/goog_cc_network_control_unittest.cc: * Source/webrtc/modules/congestion_controller/send_side_congestion_controller_unittest.cc: * Source/webrtc/pc/jsepsessiondescription_unittest.cc: * Source/webrtc/pc/mediasession.cc: * Source/webrtc/pc/mediasession_unittest.cc: * Source/webrtc/pc/peerconnection.cc: * Source/webrtc/pc/peerconnection.h: * Source/webrtc/pc/peerconnection_jsep_unittest.cc: * Source/webrtc/pc/peerconnection_media_unittest.cc: * Source/webrtc/pc/peerconnection_rtp_unittest.cc: * Source/webrtc/pc/sessiondescription.cc: * Source/webrtc/pc/sessiondescription.h: * Source/webrtc/pc/webrtcsdp.cc: * Source/webrtc/pc/webrtcsdp_unittest.cc: * Source/webrtc/system_wrappers/include/metrics.h: * Source/webrtc/video/BUILD.gn: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240320 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/LayoutTests/imported/w3c/ChangeLog branches/safari-607-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt branches/safari-607-branch/Source/ThirdParty/libwebrtc/ChangeLog branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/modules/congestion_controller/goog_cc/delay_based_bwe.cc branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/modules/congestion_controller/goog_cc/delay_based_bwe.h branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/modules/congestion_controller/goog_cc/goog_cc_network_control.cc branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/modules/congestion_controller/goog_cc/goog_cc_network_control_unittest.cc branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/modules/congestion_controller/send_side_congestion_controller_unittest.cc branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/pc/jsepsessiondescription_unittest.cc branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/pc/mediasession.cc branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/pc/mediasession_unittest.cc branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/pc/peerconnection.cc branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/pc/peerconnection.h branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/pc/peerconnection_jsep_unittest.cc branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/pc/peerconnection_media_unittest.cc branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/pc/peerconnection_rtp_unittest.cc branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/pc/sessiondescription.cc branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/pc/sessiondescription.h branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/pc/webrtcsdp.cc branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/pc/webrtcsdp_unittest.cc branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/system_wrappers/include/metrics.h branches/safari-607-branch/Source/ThirdParty/libwebrtc/Source/webrtc/video/BUILD.gn Diff Modified: branches/safari-607-branch/LayoutTests/imported/w3c/ChangeLog (240423 => 240424) --- branches/safari-607-branch/LayoutTests/imported/w3c/ChangeLog 2019-01-24 06:42:38 UTC (rev 240423) +++ branches/safari-607-branch/LayoutTests/imported/w3c/ChangeLog 2019-01-24 06:42:46 UTC (rev 240424) @@ -1,5 +1,60 @@ 2019-01-23 Alan Coon +Cherry-pick r240320. rdar://problem/47494587 + +Resync libwebrtc with latest M72 branch +https://bugs.webkit.org/show_bug.cgi?id=193693 +LayoutTests/imported/w3c: + + + +Reviewed by Eric Carlson. + +* web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt: + +Source/ThirdParty/libwebrtc: + +Reviewed by Eric Carlson. + +Update libwebrtc up to latest M72
[webkit-changes] [240416] branches/safari-607-branch
Title: [240416] branches/safari-607-branch Revision 240416 Author alanc...@apple.com Date 2019-01-23 22:42:16 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r239965. rdar://problem/47295360 Animation and other code is too aggressive about invalidating layer composition https://bugs.webkit.org/show_bug.cgi?id=193343 Reviewed by Antoine Quint. Source/WebCore: We used to have the concept of a "SyntheticStyleChange", which was used to trigger style updates for animation, and also to get compositing updated. That morphed into a call to Element::invalidateStyleAndLayerComposition(), which causes a style update to result in a "RecompositeLayer" diff, which in turn triggers compositing work, and dirties DOM touch event regions (which can be expensive to update). However, not all the callers of Element::invalidateStyleAndLayerComposition() need to trigger compositing, and doing so from animations caused excessive touch event regions on yahoo.com, which has several visibility:hidden elements with background-position animation. So fix callers of invalidateStyleAndLayerComposition() which don't care about compositing to instead call just invalidateStyle(). Also fix KeyframeAnimation::animate to correctly return true when animation state changes—it failed to do so, because fireAnimationEventsIfNeeded() can run the state machine and change state. * animation/KeyframeEffect.cpp: (WebCore::invalidateElement): * page/animation/AnimationBase.cpp: (WebCore::AnimationBase::setNeedsStyleRecalc): * page/animation/CSSAnimationController.cpp: (WebCore::CSSAnimationControllerPrivate::updateAnimations): (WebCore::CSSAnimationControllerPrivate::fireEventsAndUpdateStyle): (WebCore::CSSAnimationControllerPrivate::pauseAnimationAtTime): (WebCore::CSSAnimationControllerPrivate::pauseTransitionAtTime): (WebCore::CSSAnimationController::cancelAnimations): * page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate): * rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects const): * rendering/svg/SVGResourcesCache.cpp: (WebCore::SVGResourcesCache::clientStyleChanged): * style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::createAnimatedElementUpdate): * svg/SVGAnimateElementBase.cpp: (WebCore::applyCSSPropertyToTarget): (WebCore::removeCSSPropertyFromTarget): LayoutTests: This test was clobbering the 'box' class on the animating element and therefore making it disappear. * legacy-animation-engine/compositing/animation/animation-compositing.html: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239965 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/LayoutTests/ChangeLog branches/safari-607-branch/LayoutTests/legacy-animation-engine/compositing/animation/animation-compositing.html branches/safari-607-branch/Source/WebCore/ChangeLog branches/safari-607-branch/Source/WebCore/animation/KeyframeEffect.cpp branches/safari-607-branch/Source/WebCore/page/animation/AnimationBase.cpp branches/safari-607-branch/Source/WebCore/page/animation/CSSAnimationController.cpp branches/safari-607-branch/Source/WebCore/page/animation/KeyframeAnimation.cpp branches/safari-607-branch/Source/WebCore/rendering/RenderImage.cpp branches/safari-607-branch/Source/WebCore/rendering/RenderLayer.cpp branches/safari-607-branch/Source/WebCore/rendering/svg/SVGResourcesCache.cpp branches/safari-607-branch/Source/WebCore/style/StyleTreeResolver.cpp branches/safari-607-branch/Source/WebCore/svg/SVGAnimateElementBase.cpp Diff Modified: branches/safari-607-branch/LayoutTests/ChangeLog (240415 => 240416) --- branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-24 06:42:10 UTC (rev 240415) +++ branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-24 06:42:16 UTC (rev 240416) @@ -1,5 +1,76 @@ 2019-01-23 Alan Coon +Cherry-pick r239965. rdar://problem/47295360 + +Animation and other code is too aggressive about invalidating layer composition +https://bugs.webkit.org/show_bug.cgi?id=193343 + +Reviewed by Antoine Quint. + +Source/WebCore: + +We used to have the concept of a "SyntheticStyleChange", which was used to trigger +style updates for animation, and also to get compositing updated. + +That morphed into a call to Element::invalidateStyleAndLayerComposition(), which causes +a style update to result in a "RecompositeLayer" diff, which in turn triggers compositing work, +and dirties DOM touch event regions (which can be expensive to update). + +However, not all the callers of Element::invalidateStyleAndLayerComposition() need to trigger +compositing, and doing so from animations caused excessive touch event regions on yahoo.com, +which has several
[webkit-changes] [240423] branches/safari-607-branch/Source/WebKit
Title: [240423] branches/safari-607-branch/Source/WebKit Revision 240423 Author alanc...@apple.com Date 2019-01-23 22:42:38 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240298. rdar://problem/47494772 [iOS] Flash when swiping back to Google search result page https://bugs.webkit.org/show_bug.cgi?id=193668 Reviewed by Simon Fraser. If the google page is scrolled, there is sometimes a short flash. When restoring the page state we also restore exposedContentRect which is used to determine which part of the page to create layers for. Scroll position is restored by the UI process later so we rely on this to get the right layers for the initial view update. A viewport configuration update may sometimes trample over the restored exposedContentRect, moving it to top left. In this case the initial layer tree unfreeze commit may not have layers to cover the actual visible view position. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didCommitLoad): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::restorePageState): Set a bit to indicate we have already restored the exposedContentRect. (WebKit::WebPage::viewportConfigurationChanged): Only reset exposedContentRect if wasn't already set by restorePageState. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240298 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/WebKit/ChangeLog branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/WebPage.h branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm Diff Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240422 => 240423) --- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 06:42:35 UTC (rev 240422) +++ branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 06:42:38 UTC (rev 240423) @@ -1,5 +1,70 @@ 2019-01-23 Alan Coon +Cherry-pick r240298. rdar://problem/47494772 + +[iOS] Flash when swiping back to Google search result page +https://bugs.webkit.org/show_bug.cgi?id=193668 + + +Reviewed by Simon Fraser. + +If the google page is scrolled, there is sometimes a short flash. + +When restoring the page state we also restore exposedContentRect which is used to determine +which part of the page to create layers for. Scroll position is restored by the UI process +later so we rely on this to get the right layers for the initial view update. + +A viewport configuration update may sometimes trample over the restored exposedContentRect, +moving it to top left. In this case the initial layer tree unfreeze commit may not have +layers to cover the actual visible view position. + +* WebProcess/WebPage/WebPage.cpp: +(WebKit::WebPage::didCommitLoad): +* WebProcess/WebPage/WebPage.h: +* WebProcess/WebPage/ios/WebPageIOS.mm: +(WebKit::WebPage::restorePageState): + +Set a bit to indicate we have already restored the exposedContentRect. + +(WebKit::WebPage::viewportConfigurationChanged): + +Only reset exposedContentRect if wasn't already set by restorePageState. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240298 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-22 Antti Koivisto + +[iOS] Flash when swiping back to Google search result page +https://bugs.webkit.org/show_bug.cgi?id=193668 + + +Reviewed by Simon Fraser. + +If the google page is scrolled, there is sometimes a short flash. + +When restoring the page state we also restore exposedContentRect which is used to determine +which part of the page to create layers for. Scroll position is restored by the UI process +later so we rely on this to get the right layers for the initial view update. + +A viewport configuration update may sometimes trample over the restored exposedContentRect, +moving it to top left. In this case the initial layer tree unfreeze commit may not have +layers to cover the actual visible view position. + +* WebProcess/WebPage/WebPage.cpp: +(WebKit::WebPage::didCommitLoad): +* WebProcess/WebPage/WebPage.h: +* WebProcess/WebPage/ios/WebPageIOS.mm: +(WebKit::WebPage::restorePageState): + +Set a bit to indicate we have already restored the exposedContentRect. + +(WebKit::WebPage::viewportConfigurationChanged): + +Only reset exposedContentRect if wasn't already set by restorePageState. + +2019-01-23 Alan Coon + Cherry-pick r240178. rdar://problem/47494727 Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
[webkit-changes] [240418] branches/safari-607-branch/Source/WebKit
Title: [240418] branches/safari-607-branch/Source/WebKit Revision 240418 Author alanc...@apple.com Date 2019-01-23 22:42:22 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r239994. rdar://problem/47295338 Add allow directive for MTLCompilerService.xpc to PluginProcess and WebContent https://bugs.webkit.org/show_bug.cgi?id=193453 Reviewed by Brent Fulgham. * PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in: * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: * WebProcess/com.apple.WebProcess.sb.in: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239994 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/WebKit/ChangeLog branches/safari-607-branch/Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in branches/safari-607-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb branches/safari-607-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240417 => 240418) --- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 06:42:19 UTC (rev 240417) +++ branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 06:42:22 UTC (rev 240418) @@ -1,5 +1,33 @@ 2019-01-23 Alan Coon +Cherry-pick r239994. rdar://problem/47295338 + +Add allow directive for MTLCompilerService.xpc to PluginProcess and WebContent +https://bugs.webkit.org/show_bug.cgi?id=193453 + + +Reviewed by Brent Fulgham. + +* PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in: +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: +* WebProcess/com.apple.WebProcess.sb.in: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239994 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-15 Per Arne Vollan + +Add allow directive for MTLCompilerService.xpc to PluginProcess and WebContent +https://bugs.webkit.org/show_bug.cgi?id=193453 + + +Reviewed by Brent Fulgham. + +* PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in: +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: +* WebProcess/com.apple.WebProcess.sb.in: + +2019-01-23 Alan Coon + Cherry-pick r239947. rdar://problem/47295371 Re-enable ability to build --cloop builds. Modified: branches/safari-607-branch/Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in (240417 => 240418) --- branches/safari-607-branch/Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in 2019-01-24 06:42:19 UTC (rev 240417) +++ branches/safari-607-branch/Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in 2019-01-24 06:42:22 UTC (rev 240418) @@ -160,6 +160,9 @@ ) #endif +;; +(allow mach-lookup (xpc-service-name "com.apple.MTLCompilerService")) + ;; Utility functions (define (home-literal home-relative-literal) (literal (string-append (param "HOME_DIR") home-relative-literal))) Modified: branches/safari-607-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (240417 => 240418) --- branches/safari-607-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2019-01-24 06:42:19 UTC (rev 240417) +++ branches/safari-607-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2019-01-24 06:42:22 UTC (rev 240418) @@ -189,6 +189,9 @@ (global-name "com.apple.frontboard.workspace") (global-name "com.apple.frontboard.systemappservices")) +;; +(allow mach-lookup (xpc-service-name "com.apple.MTLCompilerService")) + (allow-preferences-common) ;; CoreMotion Modified: branches/safari-607-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (240417 => 240418) --- branches/safari-607-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2019-01-24 06:42:19 UTC (rev 240417) +++ branches/safari-607-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2019-01-24 06:42:22 UTC (rev 240418) @@ -608,35 +608,8 @@ #endif ) -(allow mach-lookup (with report) -(global-name "com.apple.FileCoordination") -(global-name "com.apple.FontObjectsServer") -(global-name "com.apple.GSSCred") -(global-name "com.apple.SystemConfiguration.PPPController") -(global-name "com.apple.audio.SystemSoundServer-OSX") -(global-name "com.apple.audio.coreaudiod") -(global-name "com.apple.cfnetwork.AuthBrokerAgent") -; "com.apple.coremedia.endpointpicker.xpc" can be removed when is resolved. -(global-name "com.apple.coremedia.endpointpicker.xpc") -(global-name "com.apple.coremedia.endpointplaybacksession.xpc") -(global-name "com.apple.dock.server") -(global-name "com.apple.dyld.closured") -;; OpenGL memory debugging -(global-name "com.apple.gpumemd.source") -(global-name
[webkit-changes] [240412] branches/safari-607-branch/Source/WebInspectorUI
Title: [240412] branches/safari-607-branch/Source/WebInspectorUI Revision 240412 Author alanc...@apple.com Date 2019-01-23 22:41:54 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r239935. rdar://problem/47295382 Web Inspector: Styles: pressing Down key on empty value field shouldn't discard completion popover https://bugs.webkit.org/show_bug.cgi?id=193098 Reviewed by Devin Rousso. Hide CompletionSuggestionsView when SpreadsheetTextField moves, e.g. by scrolling or resizing the sidebar. Update CompletionSuggestionsView position after pressing Up or Down key, because SpreadsheetTextField may move from wrapping text. * UserInterface/Views/CompletionSuggestionsView.js: (WI.CompletionSuggestionsView.prototype.hide): (WI.CompletionSuggestionsView.prototype.show): (WI.CompletionSuggestionsView.prototype.showUntilAnchorMoves): Removed. (WI.CompletionSuggestionsView.prototype.hideWhenElementMoves): Added. (WI.CompletionSuggestionsView.prototype._stopMoveTimer): Added. (WI.CompletionSuggestionsView): * UserInterface/Views/SpreadsheetTextField.js: (WI.SpreadsheetTextField.prototype.set suggestionHint): (WI.SpreadsheetTextField.prototype.completionSuggestionsSelectedCompletion): (WI.SpreadsheetTextField.prototype._handleKeyDownForSuggestionView): (WI.SpreadsheetTextField.prototype._updateCompletions): (WI.SpreadsheetTextField.prototype._showSuggestionsView): Added. (WI.SpreadsheetTextField.prototype._reAttachSuggestionHint): Drive-by: abstract out repeating code into a private method. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239935 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/WebInspectorUI/ChangeLog branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js Diff Modified: branches/safari-607-branch/Source/WebInspectorUI/ChangeLog (240411 => 240412) --- branches/safari-607-branch/Source/WebInspectorUI/ChangeLog 2019-01-24 06:41:51 UTC (rev 240411) +++ branches/safari-607-branch/Source/WebInspectorUI/ChangeLog 2019-01-24 06:41:54 UTC (rev 240412) @@ -1,5 +1,70 @@ 2019-01-23 Alan Coon +Cherry-pick r239935. rdar://problem/47295382 + +Web Inspector: Styles: pressing Down key on empty value field shouldn't discard completion popover +https://bugs.webkit.org/show_bug.cgi?id=193098 + + +Reviewed by Devin Rousso. + +Hide CompletionSuggestionsView when SpreadsheetTextField moves, e.g. by scrolling or resizing the sidebar. +Update CompletionSuggestionsView position after pressing Up or Down key, because SpreadsheetTextField may +move from wrapping text. + +* UserInterface/Views/CompletionSuggestionsView.js: +(WI.CompletionSuggestionsView.prototype.hide): +(WI.CompletionSuggestionsView.prototype.show): +(WI.CompletionSuggestionsView.prototype.showUntilAnchorMoves): Removed. +(WI.CompletionSuggestionsView.prototype.hideWhenElementMoves): Added. +(WI.CompletionSuggestionsView.prototype._stopMoveTimer): Added. +(WI.CompletionSuggestionsView): + +* UserInterface/Views/SpreadsheetTextField.js: +(WI.SpreadsheetTextField.prototype.set suggestionHint): +(WI.SpreadsheetTextField.prototype.completionSuggestionsSelectedCompletion): +(WI.SpreadsheetTextField.prototype._handleKeyDownForSuggestionView): +(WI.SpreadsheetTextField.prototype._updateCompletions): +(WI.SpreadsheetTextField.prototype._showSuggestionsView): Added. + +(WI.SpreadsheetTextField.prototype._reAttachSuggestionHint): +Drive-by: abstract out repeating code into a private method. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239935 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-14 Nikita Vasilyev + +Web Inspector: Styles: pressing Down key on empty value field shouldn't discard completion popover +https://bugs.webkit.org/show_bug.cgi?id=193098 + + +Reviewed by Devin Rousso. + +Hide CompletionSuggestionsView when SpreadsheetTextField moves, e.g. by scrolling or resizing the sidebar. +Update CompletionSuggestionsView position after pressing Up or Down key, because SpreadsheetTextField may +move from wrapping text. + +* UserInterface/Views/CompletionSuggestionsView.js: +(WI.CompletionSuggestionsView.prototype.hide): +(WI.CompletionSuggestionsView.prototype.show): +(WI.CompletionSuggestionsView.prototype.showUntilAnchorMoves): Removed. +(WI.CompletionSuggestionsView.prototype.hideWhenElementMoves): Added. +(WI.CompletionSuggestionsView.prototype._stopMoveTimer): Added. +(WI.CompletionSuggestionsView): + +*
[webkit-changes] [240415] branches/safari-607-branch
Title: [240415] branches/safari-607-branch Revision 240415 Author alanc...@apple.com Date 2019-01-23 22:42:10 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r239951. rdar://problem/47295353 [JSC] Do not use asArrayModes() with Structures because it discards TypedArray information https://bugs.webkit.org/show_bug.cgi?id=193372 Reviewed by Saam Barati. JSTests: * stress/typed-array-array-modes-profile.js: Added. (foo): Source/_javascript_Core: When RegisteredStructureSet is filtered with AbstractValue, we use structure, SpeculationType, and ArrayModes. However, we use asArrayModes() function with IndexingMode to compute the ArrayModes in AbstractValue. This is wrong since this discards TypedArray ArrayModes. As a result, if RegisteredStructureSet with TypedArrays is filtered with ArrayModes of AbstractValue populated from TypedArrays, we filter all the structures out since AbstractValue's ArrayModes become NonArray, which is wrong with the TypedArrays' ArrayModes. This leads to incorrect FTL code generation with MultiGetByOffset etc. nodes because, 1. AI think that this MultiGetByOffset never succeeds since all the values of RegisteredStructureSet are filtered out by the AbstractValue. 2. AI says the state of MultiGetByOffset is invalid since AI think it never succeeds. 3. So subsequent code becomes FTL crash code since AI think the execution should do OSR exit. 4. Then, FTL emits the code for MultiGetByOffset, and emits crash after that. 5. But in reality, the incoming value can match to the one of the RegisteredStructureSet value since (1)'s structures are incorrectly filtered by the incorrect ArrayModes. 6. Then, the execution goes on, and falls into the FTL crash. This patch fixes the incorrect ArrayModes calculation by the following changes 1. Rename asArrayModes to asArrayModesIgnoringTypedArrays. 2. Fix incorrect asArrayModesIgnoringTypedArrays use in our code. Use arrayModesFromStructure instead. 3. Fix OSR exit code which stores incorrect ArrayModes to the profiles. * bytecode/ArrayProfile.cpp: (JSC::dumpArrayModes): (JSC::ArrayProfile::computeUpdatedPrediction): * bytecode/ArrayProfile.h: (JSC::asArrayModesIgnoringTypedArrays): (JSC::arrayModesFromStructure): (JSC::arrayModesIncludeIgnoringTypedArrays): (JSC::shouldUseSlowPutArrayStorage): (JSC::shouldUseFastArrayStorage): (JSC::shouldUseContiguous): (JSC::shouldUseDouble): (JSC::shouldUseInt32): (JSC::asArrayModes): Deleted. (JSC::arrayModeFromStructure): Deleted. (JSC::arrayModesInclude): Deleted. * dfg/DFGAbstractValue.cpp: (JSC::DFG::AbstractValue::observeTransitions): (JSC::DFG::AbstractValue::set): (JSC::DFG::AbstractValue::mergeOSREntryValue): (JSC::DFG::AbstractValue::contains const): * dfg/DFGAbstractValue.h: (JSC::DFG::AbstractValue::observeTransition): (JSC::DFG::AbstractValue::validate const): (JSC::DFG::AbstractValue::observeIndexingTypeTransition): * dfg/DFGArrayMode.cpp: (JSC::DFG::ArrayMode::fromObserved): (JSC::DFG::ArrayMode::alreadyChecked const): * dfg/DFGArrayMode.h: (JSC::DFG::ArrayMode::structureWouldPassArrayModeFiltering): (JSC::DFG::ArrayMode::arrayModesThatPassFiltering const): (JSC::DFG::ArrayMode::arrayModesWithIndexingShape const): * dfg/DFGOSRExit.cpp: (JSC::DFG::OSRExit::executeOSRExit): (JSC::DFG::OSRExit::compileExit): * dfg/DFGRegisteredStructureSet.cpp: (JSC::DFG::RegisteredStructureSet::filterArrayModes): (JSC::DFG::RegisteredStructureSet::arrayModesFromStructures const): * ftl/FTLOSRExitCompiler.cpp: (JSC::FTL::compileStub): * jit/JITInlines.h: (JSC::JIT::chooseArrayMode): (JSC::arrayProfileSaw): Deleted. * runtime/JSType.h: (JSC::isTypedArrayType): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239951 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/JSTests/ChangeLog branches/safari-607-branch/Source/_javascript_Core/ChangeLog branches/safari-607-branch/Source/_javascript_Core/bytecode/ArrayProfile.cpp branches/safari-607-branch/Source/_javascript_Core/bytecode/ArrayProfile.h branches/safari-607-branch/Source/_javascript_Core/dfg/DFGAbstractValue.cpp branches/safari-607-branch/Source/_javascript_Core/dfg/DFGAbstractValue.h branches/safari-607-branch/Source/_javascript_Core/dfg/DFGArrayMode.cpp branches/safari-607-branch/Source/_javascript_Core/dfg/DFGArrayMode.h branches/safari-607-branch/Source/_javascript_Core/dfg/DFGOSRExit.cpp branches/safari-607-branch/Source/_javascript_Core/dfg/DFGRegisteredStructureSet.cpp branches/safari-607-branch/Source/_javascript_Core/ftl/FTLOSRExitCompiler.cpp branches/safari-607-branch/Source/_javascript_Core/jit/JITInlines.h branches/safari-607-branch/Source/_javascript_Core/runtime/JSType.h Added Paths
[webkit-changes] [240410] branches/safari-607-branch/Source/WebCore
Title: [240410] branches/safari-607-branch/Source/WebCore
Revision 240410
Author alanc...@apple.com
Date 2019-01-23 22:41:48 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r239927. rdar://problem/47295363
DOMCacheStorage: use-after-move in doSequentialMatch()
https://bugs.webkit.org/show_bug.cgi?id=193396
Reviewed by Youenn Fablet.
Depending on the platform- and compiler-specific calling conventions,
the doSequentialMatch() code can move out the Vector>
object into the callback lambda before the DOMCache object at the
specified index is retrieved for the DOMCache::doMatch() invocation.
This problem is now avoided by retrieving reference to the target
DOMCache object in an earlier _expression_.
* Modules/cache/DOMCacheStorage.cpp:
(WebCore::doSequentialMatch):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/Source/WebCore/ChangeLog
branches/safari-607-branch/Source/WebCore/Modules/cache/DOMCacheStorage.cpp
Diff
Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (240409 => 240410)
--- branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 06:41:46 UTC (rev 240409)
+++ branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 06:41:48 UTC (rev 240410)
@@ -1,5 +1,46 @@
2019-01-23 Alan Coon
+Cherry-pick r239927. rdar://problem/47295363
+
+DOMCacheStorage: use-after-move in doSequentialMatch()
+https://bugs.webkit.org/show_bug.cgi?id=193396
+
+Reviewed by Youenn Fablet.
+
+Depending on the platform- and compiler-specific calling conventions,
+the doSequentialMatch() code can move out the Vector>
+object into the callback lambda before the DOMCache object at the
+specified index is retrieved for the DOMCache::doMatch() invocation.
+
+This problem is now avoided by retrieving reference to the target
+DOMCache object in an earlier _expression_.
+
+* Modules/cache/DOMCacheStorage.cpp:
+(WebCore::doSequentialMatch):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-14 Zan Dobersek
+
+DOMCacheStorage: use-after-move in doSequentialMatch()
+https://bugs.webkit.org/show_bug.cgi?id=193396
+
+Reviewed by Youenn Fablet.
+
+Depending on the platform- and compiler-specific calling conventions,
+the doSequentialMatch() code can move out the Vector>
+object into the callback lambda before the DOMCache object at the
+specified index is retrieved for the DOMCache::doMatch() invocation.
+
+This problem is now avoided by retrieving reference to the target
+DOMCache object in an earlier _expression_.
+
+* Modules/cache/DOMCacheStorage.cpp:
+(WebCore::doSequentialMatch):
+
+2019-01-23 Alan Coon
+
Cherry-pick r239905. rdar://problem/47494732
Release assert with in shadow tree
Modified: branches/safari-607-branch/Source/WebCore/Modules/cache/DOMCacheStorage.cpp (240409 => 240410)
--- branches/safari-607-branch/Source/WebCore/Modules/cache/DOMCacheStorage.cpp 2019-01-24 06:41:46 UTC (rev 240409)
+++ branches/safari-607-branch/Source/WebCore/Modules/cache/DOMCacheStorage.cpp 2019-01-24 06:41:48 UTC (rev 240410)
@@ -59,7 +59,8 @@
return;
}
-caches[index]->doMatch(WTFMove(info), WTFMove(options), [caches = WTFMove(caches), info, options, completionHandler = WTFMove(completionHandler), index](ExceptionOr&& result) mutable {
+auto& cache = caches[index].get();
+cache.doMatch(WTFMove(info), WTFMove(options), [caches = WTFMove(caches), info, options, completionHandler = WTFMove(completionHandler), index](ExceptionOr&& result) mutable {
if (result.hasException()) {
completionHandler(result.releaseException());
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240411] branches/safari-607-branch/Source/JavaScriptCore
Title: [240411] branches/safari-607-branch/Source/_javascript_Core
Revision 240411
Author alanc...@apple.com
Date 2019-01-23 22:41:51 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r239929. rdar://problem/47295348
Fix property access on ARM with the baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=193393
Reviewed by Yusuke Suzuki.
Code was still using currentInstruction[4] to access the instruction's metadata.
Updated to use metadata.getPutInfo and metadata.resolveType.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/Source/_javascript_Core/ChangeLog
branches/safari-607-branch/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp
Diff
Modified: branches/safari-607-branch/Source/_javascript_Core/ChangeLog (240410 => 240411)
--- branches/safari-607-branch/Source/_javascript_Core/ChangeLog 2019-01-24 06:41:48 UTC (rev 240410)
+++ branches/safari-607-branch/Source/_javascript_Core/ChangeLog 2019-01-24 06:41:51 UTC (rev 240411)
@@ -1,5 +1,40 @@
2019-01-23 Alan Coon
+Cherry-pick r239929. rdar://problem/47295348
+
+Fix property access on ARM with the baseline JIT
+https://bugs.webkit.org/show_bug.cgi?id=193393
+
+Reviewed by Yusuke Suzuki.
+
+Code was still using currentInstruction[4] to access the instruction's metadata.
+Updated to use metadata.getPutInfo and metadata.resolveType.
+
+* jit/JITPropertyAccess32_64.cpp:
+(JSC::JIT::emit_op_resolve_scope):
+(JSC::JIT::emit_op_get_from_scope):
+(JSC::JIT::emit_op_put_to_scope):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-14 Dominik Infuehr
+
+Fix property access on ARM with the baseline JIT
+https://bugs.webkit.org/show_bug.cgi?id=193393
+
+Reviewed by Yusuke Suzuki.
+
+Code was still using currentInstruction[4] to access the instruction's metadata.
+Updated to use metadata.getPutInfo and metadata.resolveType.
+
+* jit/JITPropertyAccess32_64.cpp:
+(JSC::JIT::emit_op_resolve_scope):
+(JSC::JIT::emit_op_get_from_scope):
+(JSC::JIT::emit_op_put_to_scope):
+
+2019-01-23 Alan Coon
+
Cherry-pick r240254. rdar://problem/47458354
[JSC] Invalidate old scope operations using global lexical binding epoch
Modified: branches/safari-607-branch/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp (240410 => 240411)
--- branches/safari-607-branch/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp 2019-01-24 06:41:48 UTC (rev 240410)
+++ branches/safari-607-branch/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp 2019-01-24 06:41:51 UTC (rev 240411)
@@ -830,7 +830,7 @@
case UnresolvedProperty:
case UnresolvedPropertyWithVarInjectionChecks: {
JumpList skipToEnd;
-load32([4], regT0);
+load32(, regT0);
Jump notGlobalProperty = branch32(NotEqual, regT0, TrustedImm32(GlobalProperty));
emitCode(GlobalProperty);
@@ -955,7 +955,7 @@
case GlobalProperty:
case GlobalPropertyWithVarInjectionChecks: {
JumpList skipToEnd;
-load32([4], regT0);
+load32(, regT0);
and32(TrustedImm32(GetPutInfo::typeBits), regT0); // Load ResolveType into T0
Jump isNotGlobalProperty = branch32(NotEqual, regT0, TrustedImm32(resolveType));
@@ -970,7 +970,7 @@
case UnresolvedProperty:
case UnresolvedPropertyWithVarInjectionChecks: {
JumpList skipToEnd;
-load32([4], regT0);
+load32(, regT0);
and32(TrustedImm32(GetPutInfo::typeBits), regT0); // Load ResolveType into T0
Jump isGlobalProperty = branch32(Equal, regT0, TrustedImm32(GlobalProperty));
@@ -1110,7 +1110,7 @@
case GlobalProperty:
case GlobalPropertyWithVarInjectionChecks: {
JumpList skipToEnd;
-load32([4], regT0);
+load32(, regT0);
and32(TrustedImm32(GetPutInfo::typeBits), regT0); // Load ResolveType into T0
Jump isGlobalProperty = branch32(Equal, regT0, TrustedImm32(resolveType));
@@ -1129,7 +1129,7 @@
case UnresolvedProperty:
case UnresolvedPropertyWithVarInjectionChecks: {
JumpList skipToEnd;
-load32([4], regT0);
+load32(, regT0);
and32(TrustedImm32(GetPutInfo::typeBits), regT0); // Load ResolveType into T0
Jump isGlobalProperty = branch32(Equal, regT0, TrustedImm32(GlobalProperty));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240408] branches/safari-607-branch/Source/WebKit
Title: [240408] branches/safari-607-branch/Source/WebKit Revision 240408 Author alanc...@apple.com Date 2019-01-23 22:41:41 -0800 (Wed, 23 Jan 2019) Log Message Revert r239619. rdar://problem/47465051 Modified Paths branches/safari-607-branch/Source/WebKit/ChangeLog branches/safari-607-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb Diff Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240407 => 240408) --- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 06:10:54 UTC (rev 240407) +++ branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 06:41:41 UTC (rev 240408) @@ -1,3 +1,7 @@ +2019-01-23 Alan Coon + +Revert r239619. rdar://problem/47465051 + 2019-01-23 Kocsen Chung Cherry-pick r240010. rdar://problem/47457965 Modified: branches/safari-607-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (240407 => 240408) --- branches/safari-607-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2019-01-24 06:10:54 UTC (rev 240407) +++ branches/safari-607-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2019-01-24 06:41:41 UTC (rev 240408) @@ -443,113 +443,3 @@ (global-name "com.apple.coremedia.compressionsession") (global-name "com.apple.coremedia.decompressionsession") (global-name "com.apple.coremedia.videoqueue")) - -(allow mach-lookup (with report) -(global-name "com.apple.AGXCompilerService") -(global-name "com.apple.CoreAuthentication.daemon.libxpc") -(global-name "com.apple.FileCoordination") -(global-name "com.apple.FileProvider") -(global-name "com.apple.Honeybee.event-notify") -(global-name "com.apple.KeyboardServices.TextReplacementService") -(global-name "com.apple.MediaPlayer.RemotePlayerService") -(global-name "com.apple.ReportCrash.SimulateCrash") -(global-name "com.apple.TextInput.emoji") -(global-name "com.apple.TextInput.image-cache-server") -(global-name "com.apple.TextInput.lexicon-server") -(global-name "com.apple.TextInput.preferences") -(global-name "com.apple.TextInput.rdt") -(global-name "com.apple.TextInput.shortcuts") -(global-name "com.apple.UIKit.KeyboardManagement") -(global-name "com.apple.UIKit.KeyboardManagement.hosted") -(global-name "com.apple.accessibility.AXBackBoardServer") -(global-name "com.apple.accessibility.AccessibilityUIServer") -(global-name "com.apple.accessibility.heard") -(global-name "com.apple.accountsd.accountmanager") -(global-name "com.apple.analyticsd") -(global-name "com.apple.app-sandbox.mach") -(global-name "com.apple.appsupport.cplogd") -(global-name "com.apple.assertiond.applicationstateconnection") -(global-name "com.apple.assertiond.expiration") -(global-name "com.apple.assertiond.processassertionconnection") -(global-name "com.apple.assertiond.processinfoservice") -(global-name "com.apple.audio.AURemoteIOServer") -(global-name "com.apple.audio.AudioComponentPrefs") -(global-name "com.apple.audio.AudioQueueServer") -(global-name "com.apple.audio.SystemSoundServer-iOS") -(global-name "com.apple.audio.audiohald") -(global-name "com.apple.audio.reporting.xpc") -(global-name "com.apple.avkit.SharedPreferences") -(global-name "com.apple.awdd") -(global-name "com.apple.backboard.TouchDeliveryPolicyServer") -(global-name "com.apple.backboard.animation-fence-arbiter") -(global-name "com.apple.backboard.display.services") -(global-name "com.apple.backboard.hid.focus") -(global-name "com.apple.backboard.hid.services") -(global-name "com.apple.bird") -(global-name "com.apple.bird.token") -(global-name "com.apple.cfprefsd.agent") -(global-name "com.apple.containermanagerd") -(global-name "com.apple.coremedia.assetcacheinspector") -(global-name "com.apple.coremedia.audiodeviceclock") -(global-name "com.apple.coremedia.audioprocessingtap.xpc") -(global-name "com.apple.coremedia.capturesession") -(global-name "com.apple.coremedia.capturesource") -(global-name "com.apple.coremedia.compressionsession") -(global-name "com.apple.coremedia.endpoint.xpc") -(global-name "com.apple.coremedia.endpointplaybacksession.xpc") -(global-name "com.apple.coremedia.endpointremotecontrolsession.xpc") -(global-name "com.apple.coremedia.figcontentkeysession.xpc") -(global-name "com.apple.coremedia.figcpecryptor") -(global-name "com.apple.coremedia.remotequeue") -(global-name "com.apple.coremedia.samplebufferaudiorenderer.xpc") -(global-name "com.apple.coremedia.samplebufferrendersynchronizer.xpc") -(global-name "com.apple.coremedia.sandboxserver") -(global-name "com.apple.coremedia.videocompositor") -(global-name "com.apple.coremedia.visualcontext.xpc") -(global-name "com.apple.coreservices.lsuseractivitymanager.xpc") -
[webkit-changes] [240409] branches/safari-607-branch
Title: [240409] branches/safari-607-branch
Revision 240409
Author alanc...@apple.com
Date 2019-01-23 22:41:46 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r239905. rdar://problem/47494732
Release assert with in shadow tree
https://bugs.webkit.org/show_bug.cgi?id=193378
Reviewed by Ryosuke Niwa.
Source/WebCore:
When a shadow host that has in the shadow tree is removed from the document, we try
to remove the map from the scope of the host.
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::insertedIntoAncestor):
(WebCore::HTMLImageElement::removedFromAncestor):
Tree scope changes are relevant, not the connection to the document.
LayoutTests:
* fast/shadow-dom/image-map-tree-scope.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/LayoutTests/ChangeLog
branches/safari-607-branch/LayoutTests/fast/shadow-dom/image-map-tree-scope-expected.txt
branches/safari-607-branch/LayoutTests/fast/shadow-dom/image-map-tree-scope.html
branches/safari-607-branch/Source/WebCore/ChangeLog
branches/safari-607-branch/Source/WebCore/html/HTMLImageElement.cpp
Diff
Modified: branches/safari-607-branch/LayoutTests/ChangeLog (240408 => 240409)
--- branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-24 06:41:41 UTC (rev 240408)
+++ branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-24 06:41:46 UTC (rev 240409)
@@ -1,5 +1,42 @@
2019-01-23 Alan Coon
+Cherry-pick r239905. rdar://problem/47494732
+
+Release assert with in shadow tree
+https://bugs.webkit.org/show_bug.cgi?id=193378
+
+Reviewed by Ryosuke Niwa.
+
+Source/WebCore:
+
+When a shadow host that has in the shadow tree is removed from the document, we try
+to remove the map from the scope of the host.
+
+* html/HTMLImageElement.cpp:
+(WebCore::HTMLImageElement::parseAttribute):
+(WebCore::HTMLImageElement::insertedIntoAncestor):
+(WebCore::HTMLImageElement::removedFromAncestor):
+
+Tree scope changes are relevant, not the connection to the document.
+
+LayoutTests:
+
+* fast/shadow-dom/image-map-tree-scope.html:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-13 Antti Koivisto
+
+Release assert with in shadow tree
+https://bugs.webkit.org/show_bug.cgi?id=193378
+
+Reviewed by Ryosuke Niwa.
+
+* fast/shadow-dom/image-map-tree-scope.html:
+
+2019-01-23 Alan Coon
+
Cherry-pick r240158. rdar://problem/47458281
FetchResponse::url should return the empty string for tainted responses
Modified: branches/safari-607-branch/LayoutTests/fast/shadow-dom/image-map-tree-scope-expected.txt (240408 => 240409)
--- branches/safari-607-branch/LayoutTests/fast/shadow-dom/image-map-tree-scope-expected.txt 2019-01-24 06:41:41 UTC (rev 240408)
+++ branches/safari-607-branch/LayoutTests/fast/shadow-dom/image-map-tree-scope-expected.txt 2019-01-24 06:41:46 UTC (rev 240409)
@@ -1 +1 @@
-This test passes if it doesn't crash.
+This test passes if it doesn't crash.
Modified: branches/safari-607-branch/LayoutTests/fast/shadow-dom/image-map-tree-scope.html (240408 => 240409)
--- branches/safari-607-branch/LayoutTests/fast/shadow-dom/image-map-tree-scope.html 2019-01-24 06:41:41 UTC (rev 240408)
+++ branches/safari-607-branch/LayoutTests/fast/shadow-dom/image-map-tree-scope.html 2019-01-24 06:41:46 UTC (rev 240409)
@@ -6,7 +6,7 @@
function test() {
var shadow = host.attachShadow({mode: "open"});
-shadow.innerHTML = '';
+shadow.innerHTML = ' host.remove();
}
@@ -14,6 +14,7 @@
This test passes if it doesn't crash.
+
Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (240408 => 240409)
--- branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 06:41:41 UTC (rev 240408)
+++ branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 06:41:46 UTC (rev 240409)
@@ -1,3 +1,48 @@
+2019-01-23 Alan Coon
+
+Cherry-pick r239905. rdar://problem/47494732
+
+Release assert with in shadow tree
+https://bugs.webkit.org/show_bug.cgi?id=193378
+
+Reviewed by Ryosuke Niwa.
+
+Source/WebCore:
+
+When a shadow host that has in the shadow tree is removed from the document, we try
+to remove the map from the scope of the host.
+
+* html/HTMLImageElement.cpp:
+(WebCore::HTMLImageElement::parseAttribute):
+(WebCore::HTMLImageElement::insertedIntoAncestor):
+(WebCore::HTMLImageElement::removedFromAncestor):
+
+Tree scope changes are relevant, not the connection to the document.
+
+LayoutTests:
+
+* fast/shadow-dom/image-map-tree-scope.html:
+
+
+git-svn-id:
[webkit-changes] [240414] branches/safari-607-branch
Title: [240414] branches/safari-607-branch Revision 240414 Author alanc...@apple.com Date 2019-01-23 22:42:04 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r239947. rdar://problem/47295371 Re-enable ability to build --cloop builds. https://bugs.webkit.org/show_bug.cgi?id=192955 Source/_javascript_Core: Reviewed by Saam barati and Keith Miller. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Reviewed by Saam barati and Keith Miller. * Configurations/FeatureDefines.xcconfig: Source/WebCore/PAL: Reviewed by Saam barati and Keith Miller. * Configurations/FeatureDefines.xcconfig: Source/WebKit: Reviewed by Saam barati and Keith Miller. * Configurations/FeatureDefines.xcconfig: Source/WebKitLegacy/mac: Reviewed by Saam barati and Keith Miller. * Configurations/FeatureDefines.xcconfig: Tools: Reviewed by Saam barati and Keith Miller. The --cloop build option was being ignored this whole time since r236381. This patch makes it possible to build CLoop builds again. * Scripts/build-jsc: * Scripts/webkitperl/FeatureList.pm: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239947 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/_javascript_Core/ChangeLog branches/safari-607-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig branches/safari-607-branch/Source/WebCore/ChangeLog branches/safari-607-branch/Source/WebCore/Configurations/FeatureDefines.xcconfig branches/safari-607-branch/Source/WebCore/PAL/ChangeLog branches/safari-607-branch/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig branches/safari-607-branch/Source/WebKit/ChangeLog branches/safari-607-branch/Source/WebKit/Configurations/FeatureDefines.xcconfig branches/safari-607-branch/Source/WebKitLegacy/mac/ChangeLog branches/safari-607-branch/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig branches/safari-607-branch/Tools/ChangeLog branches/safari-607-branch/Tools/Scripts/build-jsc branches/safari-607-branch/Tools/Scripts/webkitperl/FeatureList.pm branches/safari-607-branch/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig Diff Modified: branches/safari-607-branch/Source/_javascript_Core/ChangeLog (240413 => 240414) --- branches/safari-607-branch/Source/_javascript_Core/ChangeLog 2019-01-24 06:41:57 UTC (rev 240413) +++ branches/safari-607-branch/Source/_javascript_Core/ChangeLog 2019-01-24 06:42:04 UTC (rev 240414) @@ -1,5 +1,77 @@ 2019-01-23 Alan Coon +Cherry-pick r239947. rdar://problem/47295371 + +Re-enable ability to build --cloop builds. +https://bugs.webkit.org/show_bug.cgi?id=192955 +Source/_javascript_Core: + + + +Reviewed by Saam barati and Keith Miller. + +* Configurations/FeatureDefines.xcconfig: + +Source/WebCore: + + +Reviewed by Saam barati and Keith Miller. + +* Configurations/FeatureDefines.xcconfig: + +Source/WebCore/PAL: + + + +Reviewed by Saam barati and Keith Miller. + +* Configurations/FeatureDefines.xcconfig: + +Source/WebKit: + + + +Reviewed by Saam barati and Keith Miller. + +* Configurations/FeatureDefines.xcconfig: + +Source/WebKitLegacy/mac: + + + +Reviewed by Saam barati and Keith Miller. + +* Configurations/FeatureDefines.xcconfig: + +Tools: + + + +Reviewed by Saam barati and Keith Miller. + +The --cloop build option was being ignored this whole time since r236381. +This patch makes it possible to build CLoop builds again. + +* Scripts/build-jsc: +* Scripts/webkitperl/FeatureList.pm: +* TestWebKitAPI/Configurations/FeatureDefines.xcconfig: + + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239947 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-14 Mark Lam + +Re-enable ability to build --cloop builds. +https://bugs.webkit.org/show_bug.cgi?id=192955 + + +Reviewed by Saam barati and Keith Miller. + +* Configurations/FeatureDefines.xcconfig: + +2019-01-23 Alan Coon + Cherry-pick r239929. rdar://problem/47295348 Fix property access on ARM with the baseline JIT Modified: branches/safari-607-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (240413 => 240414) --- branches/safari-607-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2019-01-24 06:41:57 UTC (rev 240413) +++ branches/safari-607-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2019-01-24 06:42:04 UTC (rev 240414) @@ -402,4 +402,4 @@ ENABLE_XSLT = ENABLE_XSLT; -FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS)
[webkit-changes] [240407] trunk/Source/WebCore
Title: [240407] trunk/Source/WebCore
Revision 240407
Author simon.fra...@apple.com
Date 2019-01-23 22:10:54 -0800 (Wed, 23 Jan 2019)
Log Message
Change some RenderLayerCompositor functions to use references
https://bugs.webkit.org/show_bug.cgi?id=193760
Reviewed by Zalan Bujtas.
RenderWidget* -> RenderWidget&
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAfterWidgetResize):
(WebCore::RenderLayerBacking::updateConfiguration):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::frameContentsCompositor):
(WebCore::RenderLayerCompositor::parentFrameContentLayers):
* rendering/RenderLayerCompositor.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (240406 => 240407)
--- trunk/Source/WebCore/ChangeLog 2019-01-24 05:29:36 UTC (rev 240406)
+++ trunk/Source/WebCore/ChangeLog 2019-01-24 06:10:54 UTC (rev 240407)
@@ -1,3 +1,22 @@
+2019-01-23 Simon Fraser
+
+Change some RenderLayerCompositor functions to use references
+https://bugs.webkit.org/show_bug.cgi?id=193760
+
+Reviewed by Zalan Bujtas.
+
+RenderWidget* -> RenderWidget&
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::updateAfterWidgetResize):
+(WebCore::RenderLayerBacking::updateConfiguration):
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):
+(WebCore::RenderLayerCompositor::updateBacking):
+(WebCore::RenderLayerCompositor::frameContentsCompositor):
+(WebCore::RenderLayerCompositor::parentFrameContentLayers):
+* rendering/RenderLayerCompositor.h:
+
2019-01-23 Benjamin Poulain
Revert workaround AVPlayer.setMuted bug on macOS
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (240406 => 240407)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2019-01-24 05:29:36 UTC (rev 240406)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2019-01-24 06:10:54 UTC (rev 240407)
@@ -634,7 +634,7 @@
if (!is(renderer()))
return;
-if (auto* innerCompositor = RenderLayerCompositor::frameContentsCompositor((renderer( {
+if (auto* innerCompositor = RenderLayerCompositor::frameContentsCompositor(downcast(renderer( {
innerCompositor->frameViewDidChangeSize();
innerCompositor->frameViewDidChangeLocation(flooredIntPoint(contentsBox().location()));
}
@@ -783,7 +783,7 @@
layerConfigChanged = true;
}
#endif
-if (is(renderer()) && RenderLayerCompositor::parentFrameContentLayers((renderer( {
+if (is(renderer()) && RenderLayerCompositor::parentFrameContentLayers(downcast(renderer( {
m_owningLayer.setNeedsCompositingGeometryUpdate();
layerConfigChanged = true;
}
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (240406 => 240407)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2019-01-24 05:29:36 UTC (rev 240406)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2019-01-24 06:10:54 UTC (rev 240407)
@@ -1194,7 +1194,7 @@
if (requireDescendantTraversal || requiresChildRebuild) {
bool parented = false;
if (is(layer.renderer()))
-parented = parentFrameContentLayers((layer.renderer()));
+parented = parentFrameContentLayers(downcast(layer.renderer()));
if (!parented)
layerBacking->parentForSublayers()->setChildren(WTFMove(layerChildren));
@@ -1557,7 +1557,7 @@
#endif
if (layerChanged && is(layer.renderer())) {
-auto* innerCompositor = frameContentsCompositor((layer.renderer()));
+auto* innerCompositor = frameContentsCompositor(downcast(layer.renderer()));
if (innerCompositor && innerCompositor->usesCompositing())
innerCompositor->updateRootLayerAttachment();
}
@@ -1928,9 +1928,9 @@
return layerTreeText;
}
-RenderLayerCompositor* RenderLayerCompositor::frameContentsCompositor(RenderWidget* renderer)
+RenderLayerCompositor* RenderLayerCompositor::frameContentsCompositor(RenderWidget& renderer)
{
-if (auto* contentDocument = renderer->frameOwnerElement().contentDocument()) {
+if (auto* contentDocument = renderer.frameOwnerElement().contentDocument()) {
if (auto* view = contentDocument->renderView())
return >compositor();
}
@@ -1937,13 +1937,13 @@
return nullptr;
}
-bool RenderLayerCompositor::parentFrameContentLayers(RenderWidget* renderer)
+bool RenderLayerCompositor::parentFrameContentLayers(RenderWidget& renderer)
{
auto*
[webkit-changes] [240406] releases/Apple
Title: [240406] releases/Apple Revision 240406 Author m...@apple.com Date 2019-01-23 21:29:36 -0800 (Wed, 23 Jan 2019) Log Message Added a tag for Safari Technology Preview release 74. Added Paths releases/Apple/Safari Technology Preview 74/ releases/Apple/Safari Technology Preview 74/ANGLE/ releases/Apple/Safari Technology Preview 74/_javascript_Core/ releases/Apple/Safari Technology Preview 74/WTF/ releases/Apple/Safari Technology Preview 74/WebCore/ releases/Apple/Safari Technology Preview 74/WebInspectorUI/ releases/Apple/Safari Technology Preview 74/WebKit/ releases/Apple/Safari Technology Preview 74/WebKitLegacy/ releases/Apple/Safari Technology Preview 74/bmalloc/ releases/Apple/Safari Technology Preview 74/libwebrtc/ Diff Index: releases/Apple/Safari Technology Preview 74/ANGLE === --- tags/Safari-608.1.1.1/Source/ThirdParty/ANGLE 2019-01-24 04:46:01 UTC (rev 240405) +++ releases/Apple/Safari Technology Preview 74/ANGLE 2019-01-24 05:29:36 UTC (rev 240406) Property changes: releases/Apple/Safari Technology Preview 74/ANGLE Added: allow-tabs +true \ No newline at end of property Added: svn:mergeinfo +/trunk/Source/ThirdParty/ANGLE:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview 74/_javascript_Core === --- tags/Safari-608.1.1.1/Source/_javascript_Core 2019-01-24 04:46:01 UTC (rev 240405) +++ releases/Apple/Safari Technology Preview 74/_javascript_Core 2019-01-24 05:29:36 UTC (rev 240406) Property changes: releases/Apple/Safari Technology Preview 74/_javascript_Core Added: svn:mergeinfo +/trunk/Source/_javascript_Core:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview 74/WTF === --- tags/Safari-608.1.1.1/Source/WTF 2019-01-24 04:46:01 UTC (rev 240405) +++ releases/Apple/Safari Technology Preview 74/WTF 2019-01-24 05:29:36 UTC (rev 240406) Property changes: releases/Apple/Safari Technology Preview 74/WTF Added: svn:mergeinfo +/trunk/Source/WTF:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview 74/WebInspectorUI === --- tags/Safari-608.1.1.1/Source/WebInspectorUI 2019-01-24 04:46:01 UTC (rev 240405) +++ releases/Apple/Safari Technology Preview 74/WebInspectorUI 2019-01-24 05:29:36 UTC (rev 240406) Property changes: releases/Apple/Safari Technology Preview 74/WebInspectorUI Added: svn:mergeinfo +/trunk/Source/WebInspectorUI:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview 74/bmalloc === --- tags/Safari-608.1.1.1/Source/bmalloc 2019-01-24 04:46:01 UTC (rev 240405) +++ releases/Apple/Safari Technology Preview 74/bmalloc 2019-01-24 05:29:36 UTC (rev 240406) Property changes: releases/Apple/Safari Technology Preview 74/bmalloc Added: svn:mergeinfo +/trunk/Source/bmalloc:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview 74/libwebrtc === --- tags/Safari-608.1.1.1/Source/ThirdParty/libwebrtc 2019-01-24 04:46:01 UTC (rev 240405) +++ releases/Apple/Safari Technology Preview 74/libwebrtc 2019-01-24 05:29:36 UTC (rev 240406) Property changes: releases/Apple/Safari Technology Preview 74/libwebrtc Added: svn:mergeinfo +/trunk/Source/ThirdParty/libwebrtc:53455 \ No newline at end of property ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240405] trunk/Source
Title: [240405] trunk/Source
Revision 240405
Author ross.kirsl...@sony.com
Date 2019-01-23 20:46:01 -0800 (Wed, 23 Jan 2019)
Log Message
[Curl] Unreviewed build fix for r240292 and friends.
WinCairo test stability must be restored in subsequent patch.
Source/WebKit:
* NetworkProcess/curl/NetworkProcessCurl.cpp:
(WebKit::NetworkProcess::platformCreateDefaultStorageSession const):
(WebKit::NetworkProcess::setNetworkProxySettings):
Source/WebKitLegacy:
* WebCoreSupport/NetworkStorageSessionMap.cpp:
(NetworkStorageSessionMap::defaultStorageSession):
(NetworkStorageSessionMap::switchToNewTestingSession):
(NetworkStorageSessionMap::ensureSession):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp
trunk/Source/WebKitLegacy/ChangeLog
trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (240404 => 240405)
--- trunk/Source/WebKit/ChangeLog 2019-01-24 04:31:37 UTC (rev 240404)
+++ trunk/Source/WebKit/ChangeLog 2019-01-24 04:46:01 UTC (rev 240405)
@@ -1,3 +1,13 @@
+2019-01-23 Ross Kirsling
+
+[Curl] Unreviewed build fix for r240292 and friends.
+
+WinCairo test stability must be restored in subsequent patch.
+
+* NetworkProcess/curl/NetworkProcessCurl.cpp:
+(WebKit::NetworkProcess::platformCreateDefaultStorageSession const):
+(WebKit::NetworkProcess::setNetworkProxySettings):
+
2019-01-23 Commit Queue
Unreviewed, rolling out r240403.
Modified: trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp (240404 => 240405)
--- trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp 2019-01-24 04:31:37 UTC (rev 240404)
+++ trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp 2019-01-24 04:46:01 UTC (rev 240405)
@@ -41,7 +41,7 @@
std::unique_ptr NetworkProcess::platformCreateDefaultStorageSession() const
{
-return std::make_unique(PAL::SessionID::defaultSessionID(), CurlContext::singleton());
+return std::make_unique(PAL::SessionID::defaultSessionID(), nullptr);
}
void NetworkProcess::allowSpecificHTTPSCertificateForHost(const CertificateInfo& certificateInfo, const String& host)
@@ -88,7 +88,7 @@
void NetworkProcess::setNetworkProxySettings(PAL::SessionID sessionID, WebCore::CurlProxySettings&& settings)
{
-if (auto* networkStorageSession = NetworkStorageSession::storageSession(sessionID))
+if (auto* networkStorageSession = storageSession(sessionID))
networkStorageSession->setProxySettings(WTFMove(settings));
else
ASSERT_NOT_REACHED();
Modified: trunk/Source/WebKitLegacy/ChangeLog (240404 => 240405)
--- trunk/Source/WebKitLegacy/ChangeLog 2019-01-24 04:31:37 UTC (rev 240404)
+++ trunk/Source/WebKitLegacy/ChangeLog 2019-01-24 04:46:01 UTC (rev 240405)
@@ -1,3 +1,14 @@
+2019-01-23 Ross Kirsling
+
+[Curl] Unreviewed build fix for r240292 and friends.
+
+WinCairo test stability must be restored in subsequent patch.
+
+* WebCoreSupport/NetworkStorageSessionMap.cpp:
+(NetworkStorageSessionMap::defaultStorageSession):
+(NetworkStorageSessionMap::switchToNewTestingSession):
+(NetworkStorageSessionMap::ensureSession):
+
2019-01-23 Commit Queue
Unreviewed, rolling out r240403.
Modified: trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp (240404 => 240405)
--- trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp 2019-01-24 04:31:37 UTC (rev 240404)
+++ trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp 2019-01-24 04:46:01 UTC (rev 240405)
@@ -53,13 +53,19 @@
WebCore::NetworkStorageSession& NetworkStorageSessionMap::defaultStorageSession()
{
-if (!defaultNetworkStorageSession())
+if (!defaultNetworkStorageSession()) {
+#if USE(CURL)
+defaultNetworkStorageSession() = std::make_unique(PAL::SessionID::defaultSessionID(), nullptr);
+#else
defaultNetworkStorageSession() = std::make_unique(PAL::SessionID::defaultSessionID());
+#endif
+}
return *defaultNetworkStorageSession();
}
void NetworkStorageSessionMap::switchToNewTestingSession()
{
+#if PLATFORM(COCOA) || USE(CFURLCONNECTION)
// Session name should be short enough for shared memory region name to be under the limit, otehrwise sandbox rules won't work (see ).
String sessionName = String::format("WebKit Test-%u", static_cast(getCurrentProcessID()));
@@ -73,10 +79,12 @@
}
defaultNetworkStorageSession() = std::make_unique(PAL::SessionID::defaultSessionID(), WTFMove(session), WTFMove(cookieStorage));
+#endif
}
void NetworkStorageSessionMap::ensureSession(const PAL::SessionID& sessionID, const String& identifierBase)
{
+#if PLATFORM(COCOA) || USE(CFURLCONNECTION)
auto addResult = globalSessionMap().add(sessionID, nullptr);
if (!addResult.isNewEntry)
return;
@@ -97,6 +105,7 @@
}
[webkit-changes] [240404] trunk/Source
Title: [240404] trunk/Source
Revision 240404
Author commit-qu...@webkit.org
Date 2019-01-23 20:31:37 -0800 (Wed, 23 Jan 2019)
Log Message
Unreviewed, rolling out r240403.
https://bugs.webkit.org/show_bug.cgi?id=193757
"Causes multiple crashes on macOS port (probably used wrong
ENABLE macro)" (Requested by ddkilzer on #webkit).
Reverted changeset:
"[Curl] Unreviewed build fix for r240292 and friends."
https://trac.webkit.org/changeset/240403
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp
trunk/Source/WebKitLegacy/ChangeLog
trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (240403 => 240404)
--- trunk/Source/WebKit/ChangeLog 2019-01-24 02:50:13 UTC (rev 240403)
+++ trunk/Source/WebKit/ChangeLog 2019-01-24 04:31:37 UTC (rev 240404)
@@ -1,3 +1,16 @@
+2019-01-23 Commit Queue
+
+Unreviewed, rolling out r240403.
+https://bugs.webkit.org/show_bug.cgi?id=193757
+
+"Causes multiple crashes on macOS port (probably used wrong
+ENABLE macro)" (Requested by ddkilzer on #webkit).
+
+Reverted changeset:
+
+"[Curl] Unreviewed build fix for r240292 and friends."
+https://trac.webkit.org/changeset/240403
+
2019-01-23 Ross Kirsling
[Curl] Unreviewed build fix for r240292 and friends.
Modified: trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp (240403 => 240404)
--- trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp 2019-01-24 02:50:13 UTC (rev 240403)
+++ trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp 2019-01-24 04:31:37 UTC (rev 240404)
@@ -41,7 +41,7 @@
std::unique_ptr NetworkProcess::platformCreateDefaultStorageSession() const
{
-return std::make_unique(PAL::SessionID::defaultSessionID(), nullptr);
+return std::make_unique(PAL::SessionID::defaultSessionID(), CurlContext::singleton());
}
void NetworkProcess::allowSpecificHTTPSCertificateForHost(const CertificateInfo& certificateInfo, const String& host)
@@ -88,7 +88,7 @@
void NetworkProcess::setNetworkProxySettings(PAL::SessionID sessionID, WebCore::CurlProxySettings&& settings)
{
-if (auto* networkStorageSession = storageSession(sessionID))
+if (auto* networkStorageSession = NetworkStorageSession::storageSession(sessionID))
networkStorageSession->setProxySettings(WTFMove(settings));
else
ASSERT_NOT_REACHED();
Modified: trunk/Source/WebKitLegacy/ChangeLog (240403 => 240404)
--- trunk/Source/WebKitLegacy/ChangeLog 2019-01-24 02:50:13 UTC (rev 240403)
+++ trunk/Source/WebKitLegacy/ChangeLog 2019-01-24 04:31:37 UTC (rev 240404)
@@ -1,3 +1,16 @@
+2019-01-23 Commit Queue
+
+Unreviewed, rolling out r240403.
+https://bugs.webkit.org/show_bug.cgi?id=193757
+
+"Causes multiple crashes on macOS port (probably used wrong
+ENABLE macro)" (Requested by ddkilzer on #webkit).
+
+Reverted changeset:
+
+"[Curl] Unreviewed build fix for r240292 and friends."
+https://trac.webkit.org/changeset/240403
+
2019-01-23 Ross Kirsling
[Curl] Unreviewed build fix for r240292 and friends.
Modified: trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp (240403 => 240404)
--- trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp 2019-01-24 02:50:13 UTC (rev 240403)
+++ trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp 2019-01-24 04:31:37 UTC (rev 240404)
@@ -53,19 +53,13 @@
WebCore::NetworkStorageSession& NetworkStorageSessionMap::defaultStorageSession()
{
-if (!defaultNetworkStorageSession()) {
-#if USE(CURL)
-defaultNetworkStorageSession() = std::make_unique(PAL::SessionID::defaultSessionID(), nullptr);
-#else
+if (!defaultNetworkStorageSession())
defaultNetworkStorageSession() = std::make_unique(PAL::SessionID::defaultSessionID());
-#endif
-}
return *defaultNetworkStorageSession();
}
void NetworkStorageSessionMap::switchToNewTestingSession()
{
-#if USE(CFURLCONNECTION)
// Session name should be short enough for shared memory region name to be under the limit, otehrwise sandbox rules won't work (see ).
String sessionName = String::format("WebKit Test-%u", static_cast(getCurrentProcessID()));
@@ -79,12 +73,10 @@
}
defaultNetworkStorageSession() = std::make_unique(PAL::SessionID::defaultSessionID(), WTFMove(session), WTFMove(cookieStorage));
-#endif
}
void NetworkStorageSessionMap::ensureSession(const PAL::SessionID& sessionID, const String& identifierBase)
{
-#if USE(CFURLCONNECTION)
auto addResult = globalSessionMap().add(sessionID, nullptr);
if (!addResult.isNewEntry)
return;
@@ -105,7 +97,6 @@
}
addResult.iterator->value = std::make_unique(sessionID, WTFMove(storageSession), WTFMove(cookieStorage));
-#endif
}
void
[webkit-changes] [240403] trunk/Source
Title: [240403] trunk/Source
Revision 240403
Author ross.kirsl...@sony.com
Date 2019-01-23 18:50:13 -0800 (Wed, 23 Jan 2019)
Log Message
[Curl] Unreviewed build fix for r240292 and friends.
WinCairo test stability must be restored in subsequent patch.
Source/WebKit:
* NetworkProcess/curl/NetworkProcessCurl.cpp:
(WebKit::NetworkProcess::platformCreateDefaultStorageSession const):
(WebKit::NetworkProcess::setNetworkProxySettings):
Source/WebKitLegacy:
* WebCoreSupport/NetworkStorageSessionMap.cpp:
(NetworkStorageSessionMap::defaultStorageSession):
(NetworkStorageSessionMap::switchToNewTestingSession):
(NetworkStorageSessionMap::ensureSession):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp
trunk/Source/WebKitLegacy/ChangeLog
trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (240402 => 240403)
--- trunk/Source/WebKit/ChangeLog 2019-01-24 02:47:53 UTC (rev 240402)
+++ trunk/Source/WebKit/ChangeLog 2019-01-24 02:50:13 UTC (rev 240403)
@@ -1,3 +1,13 @@
+2019-01-23 Ross Kirsling
+
+[Curl] Unreviewed build fix for r240292 and friends.
+
+WinCairo test stability must be restored in subsequent patch.
+
+* NetworkProcess/curl/NetworkProcessCurl.cpp:
+(WebKit::NetworkProcess::platformCreateDefaultStorageSession const):
+(WebKit::NetworkProcess::setNetworkProxySettings):
+
2019-01-23 Alex Christensen
Stop using NetworkProcess::singleton
Modified: trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp (240402 => 240403)
--- trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp 2019-01-24 02:47:53 UTC (rev 240402)
+++ trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp 2019-01-24 02:50:13 UTC (rev 240403)
@@ -41,7 +41,7 @@
std::unique_ptr NetworkProcess::platformCreateDefaultStorageSession() const
{
-return std::make_unique(PAL::SessionID::defaultSessionID(), CurlContext::singleton());
+return std::make_unique(PAL::SessionID::defaultSessionID(), nullptr);
}
void NetworkProcess::allowSpecificHTTPSCertificateForHost(const CertificateInfo& certificateInfo, const String& host)
@@ -88,7 +88,7 @@
void NetworkProcess::setNetworkProxySettings(PAL::SessionID sessionID, WebCore::CurlProxySettings&& settings)
{
-if (auto* networkStorageSession = NetworkStorageSession::storageSession(sessionID))
+if (auto* networkStorageSession = storageSession(sessionID))
networkStorageSession->setProxySettings(WTFMove(settings));
else
ASSERT_NOT_REACHED();
Modified: trunk/Source/WebKitLegacy/ChangeLog (240402 => 240403)
--- trunk/Source/WebKitLegacy/ChangeLog 2019-01-24 02:47:53 UTC (rev 240402)
+++ trunk/Source/WebKitLegacy/ChangeLog 2019-01-24 02:50:13 UTC (rev 240403)
@@ -1,3 +1,14 @@
+2019-01-23 Ross Kirsling
+
+[Curl] Unreviewed build fix for r240292 and friends.
+
+WinCairo test stability must be restored in subsequent patch.
+
+* WebCoreSupport/NetworkStorageSessionMap.cpp:
+(NetworkStorageSessionMap::defaultStorageSession):
+(NetworkStorageSessionMap::switchToNewTestingSession):
+(NetworkStorageSessionMap::ensureSession):
+
2019-01-22 Alex Christensen
Fix some builds after r240292
Modified: trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp (240402 => 240403)
--- trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp 2019-01-24 02:47:53 UTC (rev 240402)
+++ trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp 2019-01-24 02:50:13 UTC (rev 240403)
@@ -53,13 +53,19 @@
WebCore::NetworkStorageSession& NetworkStorageSessionMap::defaultStorageSession()
{
-if (!defaultNetworkStorageSession())
+if (!defaultNetworkStorageSession()) {
+#if USE(CURL)
+defaultNetworkStorageSession() = std::make_unique(PAL::SessionID::defaultSessionID(), nullptr);
+#else
defaultNetworkStorageSession() = std::make_unique(PAL::SessionID::defaultSessionID());
+#endif
+}
return *defaultNetworkStorageSession();
}
void NetworkStorageSessionMap::switchToNewTestingSession()
{
+#if USE(CFURLCONNECTION)
// Session name should be short enough for shared memory region name to be under the limit, otehrwise sandbox rules won't work (see ).
String sessionName = String::format("WebKit Test-%u", static_cast(getCurrentProcessID()));
@@ -73,10 +79,12 @@
}
defaultNetworkStorageSession() = std::make_unique(PAL::SessionID::defaultSessionID(), WTFMove(session), WTFMove(cookieStorage));
+#endif
}
void NetworkStorageSessionMap::ensureSession(const PAL::SessionID& sessionID, const String& identifierBase)
{
+#if USE(CFURLCONNECTION)
auto addResult = globalSessionMap().add(sessionID, nullptr);
if (!addResult.isNewEntry)
return;
@@ -97,6 +105,7 @@
}
addResult.iterator->value =
[webkit-changes] [240402] trunk/Tools
Title: [240402] trunk/Tools
Revision 240402
Author ddkil...@apple.com
Date 2019-01-23 18:47:53 -0800 (Wed, 23 Jan 2019)
Log Message
check-webkit-style should warn when using soft-linking macros in a header
Reviewed by Darin Adler.
* Scripts/webkitpy/style/checkers/cpp.py:
(check_language): Add softlink/header check by refactoring the
softlink/framework check.
(CppChecker): Enable softlink/header check by default.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_softlink_framework): Rename from
CppStyleTest.test_softlink() and change test framework name in
case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
files. Set file_name for macros that only appear in headers.
(CppStyleTest.test_softlink_header): Add tests for using
soft-link macros in headers.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (240401 => 240402)
--- trunk/Tools/ChangeLog 2019-01-24 01:43:58 UTC (rev 240401)
+++ trunk/Tools/ChangeLog 2019-01-24 02:47:53 UTC (rev 240402)
@@ -1,3 +1,22 @@
+2019-01-23 David Kilzer
+
+check-webkit-style should warn when using soft-linking macros in a header
+
+
+Reviewed by Darin Adler.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+(check_language): Add softlink/header check by refactoring the
+softlink/framework check.
+(CppChecker): Enable softlink/header check by default.
+* Scripts/webkitpy/style/checkers/cpp_unittest.py:
+(CppStyleTest.test_softlink_framework): Rename from
+CppStyleTest.test_softlink() and change test framework name in
+case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
+files. Set file_name for macros that only appear in headers.
+(CppStyleTest.test_softlink_header): Add tests for using
+soft-link macros in headers.
+
2019-01-23 Chris Dumez
Deprecate API to limit the maximum number of WebProcesses
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (240401 => 240402)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2019-01-24 01:43:58 UTC (rev 240401)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2019-01-24 02:47:53 UTC (rev 240402)
@@ -3332,11 +3332,15 @@
'RetainPtr<> should never contain a type with \'*\'. Correct: RetainPtr, RetainPtr.')
break
-frameworks_with_soft_links = ['CoreMedia', 'CoreVideo', 'DataDetectorsCore', 'MediaAccessibility', 'MediaRemote', 'PassKit', 'QuickLook', 'UIKit', 'VideoToolbox']
-matched = re.compile('^\s*SOFT_LINK_FRAMEWORK.*\(({})\)'.format('|'.join(frameworks_with_soft_links))).search(line)
+matched = re.compile('^\s*SOFT_LINK_(PRIVATE_)?FRAMEWORK.*\((\S+)\)').search(line)
if matched:
-framework_name = matched.group(1)
-if not re.compile('^\s*SOFT_LINK_FRAMEWORK_FOR_(HEADER|SOURCE)(_WITH_EXPORT)?\({}\)'.format(framework_name)).search(line):
+framework_name = matched.group(2)
+if file_extension == 'h' and not search(r'^\s*SOFT_LINK_(PRIVATE_)?FRAMEWORK_FOR_HEADER.*\(', line):
+error(line_number, 'softlink/header', 5,
+ 'Never soft-link frameworks in headers. Put the soft-link macros in a source file, or create {framework}SoftLink.{{cpp,mm}} instead.'.format(framework=framework_name))
+
+frameworks_with_soft_links = ['CoreMedia', 'CoreVideo', 'DataDetectorsCore', 'MediaAccessibility', 'MediaRemote', 'PassKit', 'QuickLook', 'UIKit', 'VideoToolbox']
+if framework_name in frameworks_with_soft_links and not re.compile('^\s*SOFT_LINK_(PRIVATE_)?FRAMEWORK_FOR_(HEADER|SOURCE)(_WITH_EXPORT)?\({}\)'.format(framework_name)).search(line):
error(line_number, 'softlink/framework', 5,
'Use {framework}SoftLink.{{cpp,h,mm}} to soft-link to {framework}.framework.'.format(framework=framework_name))
@@ -4093,6 +4097,7 @@
'security/printf',
'security/temp_file',
'softlink/framework',
+'softlink/header',
'whitespace/blank_line',
'whitespace/braces',
'whitespace/brackets',
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (240401 => 240402)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2019-01-24 01:43:58 UTC (rev 240401)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2019-01-24 02:47:53 UTC (rev 240402)
@@ -1688,25 +1688,36 @@
' [runtime/retainptr] [5]')
self.assert_lint('''RetainPtr>> dictionary;''', '')
-def test_softlink(self):
+def test_softlink_framework(self):
self.assert_lint(
-'''SOFT_LINK_FRAMEWORK(AVFoundation)''',
+'''SOFT_LINK_FRAMEWORK(Foundation)''',
'')
self.assert_lint(
-'''SOFT_LINK_FRAMEWORK_OPTIONAL(AVFoundation)''',
+
[webkit-changes] [240401] trunk/Source/WebCore
Title: [240401] trunk/Source/WebCore
Revision 240401
Author benja...@webkit.org
Date 2019-01-23 17:43:58 -0800 (Wed, 23 Jan 2019)
Log Message
Revert workaround AVPlayer.setMuted bug on macOS
https://bugs.webkit.org/show_bug.cgi?id=193742
Reviewed by Eric Carlson.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
The original bug was fixed, see radar: rdar://problem/27686430
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (240400 => 240401)
--- trunk/Source/WebCore/ChangeLog 2019-01-24 01:23:03 UTC (rev 240400)
+++ trunk/Source/WebCore/ChangeLog 2019-01-24 01:43:58 UTC (rev 240401)
@@ -1,3 +1,13 @@
+2019-01-23 Benjamin Poulain
+
+ Revert workaround AVPlayer.setMuted bug on macOS
+https://bugs.webkit.org/show_bug.cgi?id=193742
+
+Reviewed by Eric Carlson.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
+The original bug was fixed, see radar: rdar://problem/27686430
+
2019-01-23 Sihui Liu
Clean up IndexedDB files between tests
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h (240400 => 240401)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h 2019-01-24 01:23:03 UTC (rev 240400)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h 2019-01-24 01:43:58 UTC (rev 240401)
@@ -170,9 +170,7 @@
bool platformPaused() const override;
MediaTime currentMediaTime() const override;
void setVolume(float) override;
-#if PLATFORM(IOS_FAMILY)
bool supportsMuting() const override { return true; }
-#endif
void setMuted(bool) override;
void setClosedCaptionsVisible(bool) override;
void paint(GraphicsContext&, const FloatRect&) override;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240400] branches/safari-607-branch
Title: [240400] branches/safari-607-branch
Revision 240400
Author alanc...@apple.com
Date 2019-01-23 17:23:03 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r240254. rdar://problem/47458354
[JSC] Invalidate old scope operations using global lexical binding epoch
https://bugs.webkit.org/show_bug.cgi?id=193603
Patch by Yusuke Suzuki on 2019-01-22
Reviewed by Saam Barati.
JSTests:
* stress/let-lexical-binding-shadow-existing-global-property-ftl.js:
* stress/scope-operation-cache-global-property-before-deleting.js: Added.
(shouldThrow):
(bar):
* stress/scope-operation-cache-global-property-bump-counter.js: Added.
(shouldBe):
(get1):
(get2):
(get1If):
(get2If):
* stress/scope-operation-cache-global-property-even-if-it-fails.js: Added.
(shouldThrow):
(foo):
Source/_javascript_Core:
Even if the global lexical binding does not shadow the global property at that time, we need to clear the cached information in
scope related operations since we may have a global property previously. Consider the following example,
foo = 0;
function get() { return foo; }
print(get()); // 0
print(get()); // 0
delete globalThis.foo;
$.evalScript(`const foo = 42;`);
print(get()); // Should be 42, but it returns 0 if the cached information in get() is not cleared.
To invalidate the cache easily, we introduce global lexical binding epoch. It is bumped every time we introduce a new lexical binding
into JSGlobalLexicalEnvironment, since that name could shadow the global property name previously. In op_resolve_scope, we first check
the epoch stored in the metadata, and go to slow path if it is not equal to the current epoch. Our slow path code convert the scope
operation to the appropriate one even if the resolve type is not UnresolvedProperty type. After updating the resolve type of the bytecode,
we update the cached epoch to the current one, so that we can use the cached information as long as we stay in the same epoch.
In op_get_from_scope and op_put_to_scope, we do not use this epoch since Structure check can do the same thing instead. If op_resolve_type
is updated by the epoch, and if it starts returning JSGlobalLexicalEnvironment instead JSGlobalObject, obviously the structure check fails.
And in the slow path, we update op_get_from_scope and op_put_to_scope appropriately.
So, the metadata for scope related bytecodes are eventually updated to the appropriate one. In DFG and FTL, we use the watchpoint based approach.
In DFG and FTL, we concurrently attempt to get the watchpoint for the lexical binding and look into it by using `isStillValid()` to avoid
infinite compile-and-fail loop.
When the global lexical binding epoch overflows we iterate all the live CodeBlock and update the op_resolve_scope's epoch. Even if the shadowing
happens, it is OK if we bump the epoch, since op_resolve_scope will return JSGlobalLexicalEnvironment instead of JSGlobalObject, and following
structure check in op_put_to_scope and op_get_from_scope fail. We do not need to update op_get_from_scope and op_put_to_scope because of the same
reason.
* bytecode/BytecodeList.rb:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::notifyLexicalBindingUpdate):
(JSC::CodeBlock::notifyLexicalBindingShadowing): Deleted.
* bytecode/CodeBlock.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGDesiredGlobalProperties.cpp:
(JSC::DFG::DesiredGlobalProperties::isStillValidOnMainThread):
* dfg/DFGDesiredGlobalProperties.h:
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::watchGlobalProperty):
* dfg/DFGGraph.h:
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::isStillValidOnMainThread):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_resolve_scope):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_resolve_scope):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
(JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::bumpGlobalLexicalBindingEpoch):
(JSC::JSGlobalObject::getReferencedPropertyWatchpointSet):
(JSC::JSGlobalObject::ensureReferencedPropertyWatchpointSet):
(JSC::JSGlobalObject::notifyLexicalBindingShadowing): Deleted.
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::globalLexicalBindingEpoch const):
(JSC::JSGlobalObject::globalLexicalBindingEpochOffset):
(JSC::JSGlobalObject::addressOfGlobalLexicalBindingEpoch):
* runtime/Options.cpp:
(JSC::correctOptions):
(JSC::Options::initialize):
(JSC::Options::setOptions):
(JSC::Options::setOptionWithoutAlias):
[webkit-changes] [240396] branches/safari-607-branch
Title: [240396] branches/safari-607-branch Revision 240396 Author alanc...@apple.com Date 2019-01-23 17:22:34 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240010. rdar://problem/47457965 Cannot tab out of WKWebView on macOS https://bugs.webkit.org/show_bug.cgi?id=161448 Reviewed by Dean Jackson. Source/WebCore/PAL: * pal/spi/mac/NSViewSPI.h: * pal/spi/mac/NSWindowSPI.h: Move some SPI declarations in here from WebKitLegacy. Source/WebKit: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::takeFocus): If the UIDelegate doesn't implement takeFocus, provide a simple default implementation that just uses AppKit's key view loop to move the focus. * UIProcess/API/APIUIClient.h: (API::UIClient::takeFocus): * UIProcess/API/C/WKPage.cpp: (WKPageSetPageUIClient): * UIProcess/Cocoa/UIDelegate.h: * UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::UIClient::takeFocus): Make API::UIClient's takeFocus return a bool indicating whether the client implements it or not. * UIProcess/PageClient.h: * UIProcess/mac/PageClientImplMac.h: * UIProcess/mac/PageClientImplMac.mm: (WebKit::PageClientImpl::takeFocus): Plumb takeFocus to WebViewImpl. * UIProcess/Cocoa/WebViewImpl.h: * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::takeFocus): Borrow the relevant portion of WebKitLegacy's implementation of takeFocus, shifting focus to the next/previous key view in the window. Source/WebKitLegacy/mac: * WebCoreSupport/WebChromeClient.mm: * WebView/WebView.mm: Make use of SPI headers. Tools: Add a test that tabbing into and out of WKWebView works correctly. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm: (WebKit2_CommandBackForwardTest::SetUp): (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted. (-[CommandBackForwardOffscreenWindow isVisible]): Deleted. * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added. (-[FocusableView canBecomeKeyView]): (TEST): * TestWebKitAPI/mac/OffscreenWindow.h: Added. * TestWebKitAPI/mac/OffscreenWindow.mm: Added. (-[OffscreenWindow initWithSize:]): (-[OffscreenWindow isKeyWindow]): (-[OffscreenWindow isVisible]): * TestWebKitAPI/mac/PlatformWebViewMac.mm: (TestWebKitAPI::PlatformWebView::initialize): (-[ActiveOffscreenWindow isKeyWindow]): Deleted. (-[ActiveOffscreenWindow isVisible]): Deleted. Factor ActiveOffscreenWindow out into OffscreenWindow and share it. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240010 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/WebCore/PAL/ChangeLog branches/safari-607-branch/Source/WebCore/PAL/pal/spi/mac/NSViewSPI.h branches/safari-607-branch/Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h branches/safari-607-branch/Source/WebKit/ChangeLog branches/safari-607-branch/Source/WebKit/UIProcess/API/APIUIClient.h branches/safari-607-branch/Source/WebKit/UIProcess/API/C/WKPage.cpp branches/safari-607-branch/Source/WebKit/UIProcess/Cocoa/UIDelegate.h branches/safari-607-branch/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm branches/safari-607-branch/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h branches/safari-607-branch/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm branches/safari-607-branch/Source/WebKit/UIProcess/PageClient.h branches/safari-607-branch/Source/WebKit/UIProcess/WebPageProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/mac/PageClientImplMac.h branches/safari-607-branch/Source/WebKit/UIProcess/mac/PageClientImplMac.mm branches/safari-607-branch/Source/WebKitLegacy/mac/ChangeLog branches/safari-607-branch/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm branches/safari-607-branch/Source/WebKitLegacy/mac/WebView/WebView.mm branches/safari-607-branch/Tools/ChangeLog branches/safari-607-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj branches/safari-607-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm branches/safari-607-branch/Tools/TestWebKitAPI/mac/PlatformWebViewMac.mm Added Paths branches/safari-607-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm branches/safari-607-branch/Tools/TestWebKitAPI/mac/OffscreenWindow.h branches/safari-607-branch/Tools/TestWebKitAPI/mac/OffscreenWindow.mm Diff Modified: branches/safari-607-branch/Source/WebCore/PAL/ChangeLog (240395 => 240396) --- branches/safari-607-branch/Source/WebCore/PAL/ChangeLog 2019-01-24 01:22:26 UTC (rev 240395) +++ branches/safari-607-branch/Source/WebCore/PAL/ChangeLog 2019-01-24 01:22:34 UTC (rev 240396) @@ -1,3 +1,91 @@ +2019-01-23 Kocsen Chung + +Cherry-pick r240010. rdar://problem/47457965 + +Cannot tab out of WKWebView on macOS +https://bugs.webkit.org/show_bug.cgi?id=161448 + + +Reviewed by Dean Jackson. +
[webkit-changes] [240395] branches/safari-607-branch/Source
Title: [240395] branches/safari-607-branch/Source
Revision 240395
Author alanc...@apple.com
Date 2019-01-23 17:22:26 -0800 (Wed, 23 Jan 2019)
Log Message
Revert r238815. rdar://problem/47457960
Modified Paths
branches/safari-607-branch/Source/WebCore/ChangeLog
branches/safari-607-branch/Source/WebCore/PlatformMac.cmake
branches/safari-607-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp
branches/safari-607-branch/Source/WebKitLegacy/ChangeLog
branches/safari-607-branch/Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj
branches/safari-607-branch/Source/WebKitLegacy/mac/ChangeLog
branches/safari-607-branch/Source/WebKitLegacy/mac/WebView/WebView.mm
Added Paths
branches/safari-607-branch/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.h
branches/safari-607-branch/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm
branches/safari-607-branch/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.h
branches/safari-607-branch/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.mm
Diff
Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (240394 => 240395)
--- branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 01:22:21 UTC (rev 240394)
+++ branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 01:22:26 UTC (rev 240395)
@@ -1,3 +1,7 @@
+2019-01-23 Kocsen Chung
+
+Revert r238815. rdar://problem/47457960
+
2019-01-23 Alan Coon
Cherry-pick r240158. rdar://problem/47458281
Modified: branches/safari-607-branch/Source/WebCore/PlatformMac.cmake (240394 => 240395)
--- branches/safari-607-branch/Source/WebCore/PlatformMac.cmake 2019-01-24 01:22:21 UTC (rev 240394)
+++ branches/safari-607-branch/Source/WebCore/PlatformMac.cmake 2019-01-24 01:22:26 UTC (rev 240395)
@@ -381,6 +381,9 @@
platform/mac/WebCoreObjCExtras.mm
platform/mac/WebGLBlacklist.mm
platform/mac/WebNSAttributedStringExtras.mm
+platform/mac/WebVideoFullscreenController.mm
+platform/mac/WebVideoFullscreenHUDWindowController.mm
+platform/mac/WebWindowAnimation.mm
platform/mac/WidgetMac.mm
platform/mediastream/mac/MockRealtimeVideoSourceMac.mm
Modified: branches/safari-607-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (240394 => 240395)
--- branches/safari-607-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2019-01-24 01:22:21 UTC (rev 240394)
+++ branches/safari-607-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2019-01-24 01:22:26 UTC (rev 240395)
@@ -458,11 +458,14 @@
{
#if ENABLE(FULLSCREEN_API)
return true;
-#elif PLATFORM(IOS_FAMILY)
+#else
+// FIXME: WebVideoFullscreenController assumes a QTKit/QuickTime media engine
+#if PLATFORM(IOS_FAMILY)
if (DeprecatedGlobalSettings::avKitEnabled())
return true;
#endif
return false;
+#endif
}
bool MediaPlayerPrivateAVFoundation::hasSingleSecurityOrigin() const
Modified: branches/safari-607-branch/Source/WebKitLegacy/ChangeLog (240394 => 240395)
--- branches/safari-607-branch/Source/WebKitLegacy/ChangeLog 2019-01-24 01:22:21 UTC (rev 240394)
+++ branches/safari-607-branch/Source/WebKitLegacy/ChangeLog 2019-01-24 01:22:26 UTC (rev 240395)
@@ -1,3 +1,7 @@
+2019-01-23 Kocsen Chung
+
+Revert r238815. rdar://problem/47457960
+
2019-01-04 Youenn Fablet
CSP violation reports should bypass CSP checks
Modified: branches/safari-607-branch/Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj (240394 => 240395)
--- branches/safari-607-branch/Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj 2019-01-24 01:22:21 UTC (rev 240394)
+++ branches/safari-607-branch/Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj 2019-01-24 01:22:26 UTC (rev 240395)
@@ -774,6 +774,8 @@
C0C5B3EF1177A4A0002B0AEF /* WebUserContentURLPattern.mm in Sources */ = {isa = PBXBuildFile; fileRef = C0C5B3ED1177A4A0002B0AEF /* WebUserContentURLPattern.mm */; };
C11EBF4121419CCE00D659E7 /* WebSwitchingGPUClient.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C11EBF3F21419CCE00D659E7 /* WebSwitchingGPUClient.cpp */; };
C11EBF4221419CCE00D659E7 /* WebSwitchingGPUClient.h in Headers */ = {isa = PBXBuildFile; fileRef = C11EBF4021419CCE00D659E7 /* WebSwitchingGPUClient.h */; };
+ C1D81128202CD8EE74F9 /* WebVideoFullscreenController.mm in Sources */ = {isa = PBXBuildFile; fileRef = C1D81127202CD8EE74F9 /* WebVideoFullscreenController.mm */; };
+ C1D8112B202CDCC400EE74F9 /* WebVideoFullscreenHUDWindowController.mm in Sources */ = {isa = PBXBuildFile; fileRef = C1D81129202CDCC200EE74F9 /* WebVideoFullscreenHUDWindowController.mm */; };
C1D8112E202CED0800EE74F9 /* WebWindowAnimation.mm in Sources */ = {isa = PBXBuildFile; fileRef = C1D8112D202CED0700EE74F9 /* WebWindowAnimation.mm */; };
CD8BFCE715531224005AFB25 /*
[webkit-changes] [240392] branches/safari-607-branch/Source/bmalloc
Title: [240392] branches/safari-607-branch/Source/bmalloc
Revision 240392
Author alanc...@apple.com
Date 2019-01-23 17:22:15 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r240193. rdar://problem/47458146
gigacage slide should randomize both start and end
https://bugs.webkit.org/show_bug.cgi?id=193601
Reviewed by Yusuke Suzuki.
This patch makes it so that the gigacade slide has an arbitrary
distance from the end as well as the start. This is done by
picking a random size then based on that size picking an random
starting offset.
* bmalloc/Gigacage.h:
* bmalloc/Heap.cpp:
(bmalloc::Heap::Heap):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/Source/bmalloc/ChangeLog
branches/safari-607-branch/Source/bmalloc/bmalloc/Algorithm.h
branches/safari-607-branch/Source/bmalloc/bmalloc/Gigacage.h
branches/safari-607-branch/Source/bmalloc/bmalloc/Heap.cpp
Diff
Modified: branches/safari-607-branch/Source/bmalloc/ChangeLog (240391 => 240392)
--- branches/safari-607-branch/Source/bmalloc/ChangeLog 2019-01-24 01:22:12 UTC (rev 240391)
+++ branches/safari-607-branch/Source/bmalloc/ChangeLog 2019-01-24 01:22:15 UTC (rev 240392)
@@ -1,5 +1,41 @@
2019-01-23 Alan Coon
+Cherry-pick r240193. rdar://problem/47458146
+
+gigacage slide should randomize both start and end
+https://bugs.webkit.org/show_bug.cgi?id=193601
+
+Reviewed by Yusuke Suzuki.
+
+This patch makes it so that the gigacade slide has an arbitrary
+distance from the end as well as the start. This is done by
+picking a random size then based on that size picking an random
+starting offset.
+
+* bmalloc/Gigacage.h:
+* bmalloc/Heap.cpp:
+(bmalloc::Heap::Heap):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-18 Keith Miller
+
+gigacage slide should randomize both start and end
+https://bugs.webkit.org/show_bug.cgi?id=193601
+
+Reviewed by Yusuke Suzuki.
+
+This patch makes it so that the gigacade slide has an arbitrary
+distance from the end as well as the start. This is done by
+picking a random size then based on that size picking an random
+starting offset.
+
+* bmalloc/Gigacage.h:
+* bmalloc/Heap.cpp:
+(bmalloc::Heap::Heap):
+
+2019-01-23 Alan Coon
+
Cherry-pick r240175. rdar://problem/47458146
Gigacages should start allocations from a slide
Modified: branches/safari-607-branch/Source/bmalloc/bmalloc/Algorithm.h (240391 => 240392)
--- branches/safari-607-branch/Source/bmalloc/bmalloc/Algorithm.h 2019-01-24 01:22:12 UTC (rev 240391)
+++ branches/safari-607-branch/Source/bmalloc/bmalloc/Algorithm.h 2019-01-24 01:22:15 UTC (rev 240392)
@@ -99,9 +99,16 @@
template inline T roundDownToMultipleOf(size_t divisor, T x)
{
BASSERT(isPowerOfTwo(divisor));
-return reinterpret_cast(mask(reinterpret_cast(x), ~(divisor - 1ul)));
+static_assert(sizeof(T) == sizeof(uintptr_t), "sizeof(T) must be equal to sizeof(uintptr_t).");
+return static_cast(mask(static_cast(x), ~(divisor - 1ul)));
}
+template inline T* roundDownToMultipleOf(size_t divisor, T* x)
+{
+BASSERT(isPowerOfTwo(divisor));
+return reinterpret_cast(mask(reinterpret_cast(x), ~(divisor - 1ul)));
+}
+
template constexpr T roundDownToMultipleOf(T x)
{
static_assert(isPowerOfTwo(divisor), "'divisor' must be a power of two.");
Modified: branches/safari-607-branch/Source/bmalloc/bmalloc/Gigacage.h (240391 => 240392)
--- branches/safari-607-branch/Source/bmalloc/bmalloc/Gigacage.h 2019-01-24 01:22:12 UTC (rev 240391)
+++ branches/safari-607-branch/Source/bmalloc/bmalloc/Gigacage.h 2019-01-24 01:22:15 UTC (rev 240392)
@@ -70,13 +70,13 @@
constexpr size_t primitiveGigacageSize = 2 * bmalloc::Sizes::GB;
constexpr size_t jsValueGigacageSize = 1 * bmalloc::Sizes::GB;
constexpr size_t gigacageBasePtrsSize = 16 * bmalloc::Sizes::kB;
-constexpr size_t minimumCageSizeAfterSlide = bmalloc::Sizes::GB / 2;
+constexpr size_t maximumCageSizeReductionForSlide = bmalloc::Sizes::GB / 2;
#define GIGACAGE_ALLOCATION_CAN_FAIL 1
#else
constexpr size_t primitiveGigacageSize = 32 * bmalloc::Sizes::GB;
constexpr size_t jsValueGigacageSize = 16 * bmalloc::Sizes::GB;
constexpr size_t gigacageBasePtrsSize = 4 * bmalloc::Sizes::kB;
-constexpr size_t minimumCageSizeAfterSlide = 4 * bmalloc::Sizes::GB;
+constexpr size_t maximumCageSizeReductionForSlide = 4 * bmalloc::Sizes::GB;
#define GIGACAGE_ALLOCATION_CAN_FAIL 0
#endif
@@ -90,8 +90,8 @@
static_assert(bmalloc::isPowerOfTwo(primitiveGigacageSize), "");
static_assert(bmalloc::isPowerOfTwo(jsValueGigacageSize), "");
-static_assert(primitiveGigacageSize > minimumCageSizeAfterSlide, "");
[webkit-changes] [240389] branches/safari-607-branch
Title: [240389] branches/safari-607-branch Revision 240389 Author alanc...@apple.com Date 2019-01-23 17:22:05 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240161. rdar://problem/47458286 Regression(PSON) Scroll position is not always restored properly when navigating back https://bugs.webkit.org/show_bug.cgi?id=193578 Reviewed by Tim Horton. Source/WebKit: Fix issues causing the scroll position to not be restored at all (or incorrectly) when navigating back cross-site with PSON enabled. Also make sure that the swipe gesture snapshot really stays up until we've restored the scroll position. Note that even after those changes, I can still sometimes reproduce a white flash when swiping back to Google search results (scroll position being correct now). This is tracked by and happens even if I disable PSON entirely. * Shared/SessionState.cpp: (WebKit::FrameState::encode const): (WebKit::FrameState::decode): * Shared/SessionState.h: * WebProcess/WebCoreSupport/SessionStateConversion.cpp: (WebKit::toFrameState): (WebKit::applyFrameState): obscuredInsets is present on the HistoryItem in the WebProcess but was never passed to or stored by the UIProcess on the WebBackForwardListItem. obscuredInsets is needed to properly restore the scrollPosition (position was 70px off on my iPad without this). With PSON enabled, if you swipe back cross-process and the previous page was not put into PageCache, then the HistoryItem is gone on the WebProcess side. What happens is that the UIProcess sends its WebBackForwardListItem to the WebProcess, which restores the HistoryItem there, and then asks it to load it. The obscuredInsets was getting lost in the process since the UIProcess never knew about it. * UIProcess/Cocoa/ViewGestureController.cpp: (WebKit::ViewGestureController::didReachMainFrameLoadTerminalState): Drop logic that was causing the ViewGestureController to not wait for the scroll position to be restored before taking down the snapshot, when UI-side compositing is enabled. If you look at the comment above the code, you'll see that the code in question was meant to impact only the non-UI side compositing code path. As a matter of fact, when the code was reviewed at https://bugs.webkit.org/show_bug.cgi?id=151224, it was protected by a #if PLATFORM(MAC), before getting modified the wrong way before landing. In practice, we would have often restored the scroll position by the time the load is finished so it would not cause a flash in most cases. However, with PSON enabled and the layer tree freezing we do on process-swap, the first post-scroll restoration layer tree commit may now occur a little bit later and we would lose the race more often. * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::updateBackForwardItem): * UIProcess/WebProcessProxy.h: When adding PageCache support to PSON, we used to navigate the "suspended" page to about:blank. This would lead to unwanted WebProcessProxy::updateBackForwardItem() calls from the WebProcess which we wanted to ignore. We thus added logic to ignore updateBackForwardItem() IPC from the old WebProcess after a swap. The issue with this is that we sometimes miss/ignore legit updates to the HistoryItem from the old process, in particular with regards to the scroll position and the pageScaleFactor. So if you swiped and then quickly enough did a cross-site navigation, the UIProcess' WebBackForwardList would not get updated with the latest scroll position and we would thus fail to restore it later on. To address the issue, we now stop ignoring updates from the old WebProcess after a swap. This logic is no longer needed since we no longer navigate the old page to about:blank after a swap, we merely suspend it "in place". Tools: Add API test coverage. * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240161 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/WebKit/ChangeLog branches/safari-607-branch/Source/WebKit/Shared/SessionState.cpp branches/safari-607-branch/Source/WebKit/Shared/SessionState.h branches/safari-607-branch/Source/WebKit/UIProcess/Cocoa/ViewGestureController.cpp branches/safari-607-branch/Source/WebKit/UIProcess/WebProcessProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/WebProcessProxy.h branches/safari-607-branch/Source/WebKit/WebProcess/WebCoreSupport/SessionStateConversion.cpp branches/safari-607-branch/Tools/ChangeLog branches/safari-607-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Diff Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240388 => 240389) --- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 01:22:00 UTC (rev 240388) +++
[webkit-changes] [240393] branches/safari-607-branch/Source/JavaScriptCore
Title: [240393] branches/safari-607-branch/Source/_javascript_Core
Revision 240393
Author alanc...@apple.com
Date 2019-01-23 17:22:17 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r240225. rdar://problem/47458257
Unreviewed, fix -Wint-in-bool-context warning
https://bugs.webkit.org/show_bug.cgi?id=193483
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::addCheckStructureForOriginalStringObjectUse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/Source/_javascript_Core/ChangeLog
branches/safari-607-branch/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
Diff
Modified: branches/safari-607-branch/Source/_javascript_Core/ChangeLog (240392 => 240393)
--- branches/safari-607-branch/Source/_javascript_Core/ChangeLog 2019-01-24 01:22:15 UTC (rev 240392)
+++ branches/safari-607-branch/Source/_javascript_Core/ChangeLog 2019-01-24 01:22:17 UTC (rev 240393)
@@ -1,5 +1,27 @@
2019-01-23 Alan Coon
+Cherry-pick r240225. rdar://problem/47458257
+
+Unreviewed, fix -Wint-in-bool-context warning
+https://bugs.webkit.org/show_bug.cgi?id=193483
+
+
+* dfg/DFGFixupPhase.cpp:
+(JSC::DFG::FixupPhase::addCheckStructureForOriginalStringObjectUse):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-20 Michael Catanzaro
+
+Unreviewed, fix -Wint-in-bool-context warning
+https://bugs.webkit.org/show_bug.cgi?id=193483
+
+
+* dfg/DFGFixupPhase.cpp:
+(JSC::DFG::FixupPhase::addCheckStructureForOriginalStringObjectUse):
+
+2019-01-23 Alan Coon
+
Cherry-pick r240186. rdar://problem/47458146
Follow-up: Gigacages should start allocations from a slide
Modified: branches/safari-607-branch/Source/_javascript_Core/dfg/DFGFixupPhase.cpp (240392 => 240393)
--- branches/safari-607-branch/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2019-01-24 01:22:15 UTC (rev 240392)
+++ branches/safari-607-branch/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2019-01-24 01:22:17 UTC (rev 240393)
@@ -2456,7 +2456,7 @@
void addCheckStructureForOriginalStringObjectUse(UseKind useKind, const NodeOrigin& origin, Node* node)
{
-RELEASE_ASSERT(useKind == StringObjectUse || StringOrStringObjectUse);
+RELEASE_ASSERT(useKind == StringObjectUse || useKind == StringOrStringObjectUse);
StructureSet set;
set.add(m_graph.globalObjectFor(node->origin.semantic)->stringObjectStructure());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240398] branches/safari-607-branch
Title: [240398] branches/safari-607-branch
Revision 240398
Author alanc...@apple.com
Date 2019-01-23 17:22:48 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r240106. rdar://problem/47458403
[JSC] ToThis omission in DFGByteCodeParser is wrong
https://bugs.webkit.org/show_bug.cgi?id=193513
Reviewed by Saam Barati.
JSTests:
* stress/to-this-omission-with-different-strict-modes.js: Added.
(thisA):
(thisAStrictWrapper):
Source/_javascript_Core:
DFGByteCodeParser omitted ToThis node when we have `ToThis(ToThis(value))`. This semantics is wrong if ToThis has different semantics
in the sloppy mode and the strict mode. If we convert `ToThisInSloppyMode(ToThisInStrictMode(boolean))` to `ToThisInStrictMode(boolean)`,
we get boolean instead of BooleanObject.
This optimization is introduced more than 7 years ago, and from that, we have several optimizations that can remove such ToThis nodes
in BytecodeParser, AI, and Fixup. Furthermore, this optimization is simply wrong since `toThis()` function of JSCell can be defined
as they want. Before ensuring all the toThis function is safe, we should not fold `ToThis(ToThis(value))` => `ToThis(value)`.
This patch just removes the problematic optimization. The performance numbers look neutral.
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/JSTests/ChangeLog
branches/safari-607-branch/Source/_javascript_Core/ChangeLog
branches/safari-607-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
branches/safari-607-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
Added Paths
branches/safari-607-branch/JSTests/stress/to-this-omission-with-different-strict-modes.js
Diff
Modified: branches/safari-607-branch/JSTests/ChangeLog (240397 => 240398)
--- branches/safari-607-branch/JSTests/ChangeLog 2019-01-24 01:22:44 UTC (rev 240397)
+++ branches/safari-607-branch/JSTests/ChangeLog 2019-01-24 01:22:48 UTC (rev 240398)
@@ -1,5 +1,52 @@
2019-01-23 Alan Coon
+Cherry-pick r240106. rdar://problem/47458403
+
+[JSC] ToThis omission in DFGByteCodeParser is wrong
+https://bugs.webkit.org/show_bug.cgi?id=193513
+
+
+Reviewed by Saam Barati.
+
+JSTests:
+
+* stress/to-this-omission-with-different-strict-modes.js: Added.
+(thisA):
+(thisAStrictWrapper):
+
+Source/_javascript_Core:
+
+DFGByteCodeParser omitted ToThis node when we have `ToThis(ToThis(value))`. This semantics is wrong if ToThis has different semantics
+in the sloppy mode and the strict mode. If we convert `ToThisInSloppyMode(ToThisInStrictMode(boolean))` to `ToThisInStrictMode(boolean)`,
+we get boolean instead of BooleanObject.
+
+This optimization is introduced more than 7 years ago, and from that, we have several optimizations that can remove such ToThis nodes
+in BytecodeParser, AI, and Fixup. Furthermore, this optimization is simply wrong since `toThis()` function of JSCell can be defined
+as they want. Before ensuring all the toThis function is safe, we should not fold `ToThis(ToThis(value))` => `ToThis(value)`.
+This patch just removes the problematic optimization. The performance numbers look neutral.
+
+* dfg/DFGAbstractInterpreterInlines.h:
+(JSC::DFG::AbstractInterpreter::executeEffects):
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::parseBlock):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-17 Yusuke Suzuki
+
+[JSC] ToThis omission in DFGByteCodeParser is wrong
+https://bugs.webkit.org/show_bug.cgi?id=193513
+
+
+Reviewed by Saam Barati.
+
+* stress/to-this-omission-with-different-strict-modes.js: Added.
+(thisA):
+(thisAStrictWrapper):
+
+2019-01-23 Alan Coon
+
Cherry-pick r240229. rdar://problem/47458326
DFG: When inlining DataView set* intrinsics we need to set undefined as our result
Added: branches/safari-607-branch/JSTests/stress/to-this-omission-with-different-strict-modes.js (0 => 240398)
--- branches/safari-607-branch/JSTests/stress/to-this-omission-with-different-strict-modes.js (rev 0)
+++ branches/safari-607-branch/JSTests/stress/to-this-omission-with-different-strict-modes.js 2019-01-24 01:22:48 UTC (rev 240398)
@@ -0,0 +1,10 @@
+function thisA() {
+return this.a
+}
+function thisAStrictWrapper() {
+'use strict';
+thisA.apply(this);
+}
+let x = false;
+for (let j=0; j<1e4; j++)
+thisAStrictWrapper.call(x);
Modified:
[webkit-changes] [240385] branches/safari-607-branch/Source/WebCore
Title: [240385] branches/safari-607-branch/Source/WebCore Revision 240385 Author alanc...@apple.com Date 2019-01-23 17:21:50 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240122. rdar://problem/47458135 [Mac] Add a new quirk to HTMLFormControlElement::isMouseFocusable https://bugs.webkit.org/show_bug.cgi?id=193478 Reviewed by Brent Fulgham. By default in macOS, submit buttons (controls) are not focusable. WebKit follows this system convention as suggested by the spec: https://html.spec.whatwg.org/multipage/interaction.html#focusable-area. This is also the convention Firefox respects. However, Chrome doesn't. ceac.state.gov is by far the only website that assumes submit buttons are focusable, and will prohibit users from completing immigration forms, such as DS160 if buttons are not. To help immigrations, we decide to add a new quirk to HTMLFormControlElement::isMouseFocusable such that submit buttons are mouse focusable. This quirk is for ceac.state.gov specifically, and therefore no tests. * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isMouseFocusable const): (WebCore::HTMLFormControlElement::needsSiteSpecificQuirks const): * html/HTMLFormControlElement.h: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240122 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/WebCore/ChangeLog branches/safari-607-branch/Source/WebCore/html/HTMLFormControlElement.cpp branches/safari-607-branch/Source/WebCore/html/HTMLFormControlElement.h Diff Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (240384 => 240385) --- branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 01:21:46 UTC (rev 240384) +++ branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 01:21:50 UTC (rev 240385) @@ -1,5 +1,54 @@ 2019-01-23 Alan Coon +Cherry-pick r240122. rdar://problem/47458135 + +[Mac] Add a new quirk to HTMLFormControlElement::isMouseFocusable +https://bugs.webkit.org/show_bug.cgi?id=193478 + + +Reviewed by Brent Fulgham. + +By default in macOS, submit buttons (controls) are not focusable. WebKit follows this system convention +as suggested by the spec: https://html.spec.whatwg.org/multipage/interaction.html#focusable-area. This +is also the convention Firefox respects. However, Chrome doesn't. ceac.state.gov is by far the only +website that assumes submit buttons are focusable, and will prohibit users from completing immigration +forms, such as DS160 if buttons are not. To help immigrations, we decide to add a new quirk to +HTMLFormControlElement::isMouseFocusable such that submit buttons are mouse focusable. + +This quirk is for ceac.state.gov specifically, and therefore no tests. + +* html/HTMLFormControlElement.cpp: +(WebCore::HTMLFormControlElement::isMouseFocusable const): +(WebCore::HTMLFormControlElement::needsSiteSpecificQuirks const): +* html/HTMLFormControlElement.h: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240122 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-17 Jiewen Tan + +[Mac] Add a new quirk to HTMLFormControlElement::isMouseFocusable +https://bugs.webkit.org/show_bug.cgi?id=193478 + + +Reviewed by Brent Fulgham. + +By default in macOS, submit buttons (controls) are not focusable. WebKit follows this system convention +as suggested by the spec: https://html.spec.whatwg.org/multipage/interaction.html#focusable-area. This +is also the convention Firefox respects. However, Chrome doesn't. ceac.state.gov is by far the only +website that assumes submit buttons are focusable, and will prohibit users from completing immigration +forms, such as DS160 if buttons are not. To help immigrations, we decide to add a new quirk to +HTMLFormControlElement::isMouseFocusable such that submit buttons are mouse focusable. + +This quirk is for ceac.state.gov specifically, and therefore no tests. + +* html/HTMLFormControlElement.cpp: +(WebCore::HTMLFormControlElement::isMouseFocusable const): +(WebCore::HTMLFormControlElement::needsSiteSpecificQuirks const): +* html/HTMLFormControlElement.h: + +2019-01-23 Alan Coon + Cherry-pick r240112. rdar://problem/47458291 [EME] Remove Amazon Prime Video from quirks list Modified: branches/safari-607-branch/Source/WebCore/html/HTMLFormControlElement.cpp (240384 => 240385) --- branches/safari-607-branch/Source/WebCore/html/HTMLFormControlElement.cpp 2019-01-24 01:21:46 UTC (rev 240384) +++ branches/safari-607-branch/Source/WebCore/html/HTMLFormControlElement.cpp 2019-01-24 01:21:50 UTC (rev 240385) @@ -40,6 +40,7 @@ #include "HTMLTextAreaElement.h" #include "RenderBox.h" #include
[webkit-changes] [240390] branches/safari-607-branch/Source
Title: [240390] branches/safari-607-branch/Source Revision 240390 Author alanc...@apple.com Date 2019-01-23 17:22:09 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240175. rdar://problem/47458146 Gigacages should start allocations from a slide https://bugs.webkit.org/show_bug.cgi?id=193523 Reviewed by Mark Lam. Source/bmalloc: This patch makes it so that Gigacage Heaps slide the start of the cage by some random amount. We still ensure that there is always at least 4/2GB, on MacOS/iOS respectively, of VA space available for allocation. Also, this patch changes some macros into constants since macros are the devil. * bmalloc/Gigacage.cpp: (Gigacage::bmalloc::protectGigacageBasePtrs): (Gigacage::bmalloc::unprotectGigacageBasePtrs): (Gigacage::bmalloc::runwaySize): (Gigacage::ensureGigacage): (Gigacage::shouldBeEnabled): * bmalloc/Gigacage.h: (Gigacage::name): (Gigacage::gigacageSizeToMask): (Gigacage::size): (Gigacage::mask): (Gigacage::basePtr): (Gigacage::ensureGigacage): (Gigacage::wasEnabled): (Gigacage::isCaged): (Gigacage::isEnabled): (Gigacage::caged): (Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled): (Gigacage::canPrimitiveGigacageBeDisabled): (Gigacage::disablePrimitiveGigacage): (Gigacage::addPrimitiveDisableCallback): (Gigacage::removePrimitiveDisableCallback): * bmalloc/Heap.cpp: (bmalloc::Heap::Heap): * bmalloc/Sizes.h: (bmalloc::Sizes::maskSizeClass): (bmalloc::Sizes::maskObjectSize): (bmalloc::Sizes::logSizeClass): (bmalloc::Sizes::logObjectSize): (bmalloc::Sizes::sizeClass): (bmalloc::Sizes::objectSize): (bmalloc::Sizes::pageSize): Source/_javascript_Core: This patch changes some macros into constants since macros are the devil. * ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::caged): * llint/LowLevelInterpreter64.asm: Source/WTF: This patch changes some macros into constants since macros are the devil. * wtf/Gigacage.cpp: * wtf/Gigacage.h: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240175 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/_javascript_Core/ChangeLog branches/safari-607-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp branches/safari-607-branch/Source/_javascript_Core/llint/LowLevelInterpreter64.asm branches/safari-607-branch/Source/WTF/ChangeLog branches/safari-607-branch/Source/WTF/wtf/Gigacage.cpp branches/safari-607-branch/Source/WTF/wtf/Gigacage.h branches/safari-607-branch/Source/bmalloc/ChangeLog branches/safari-607-branch/Source/bmalloc/bmalloc/Gigacage.cpp branches/safari-607-branch/Source/bmalloc/bmalloc/Gigacage.h branches/safari-607-branch/Source/bmalloc/bmalloc/Heap.cpp branches/safari-607-branch/Source/bmalloc/bmalloc/Sizes.h Diff Modified: branches/safari-607-branch/Source/_javascript_Core/ChangeLog (240389 => 240390) --- branches/safari-607-branch/Source/_javascript_Core/ChangeLog 2019-01-24 01:22:05 UTC (rev 240389) +++ branches/safari-607-branch/Source/_javascript_Core/ChangeLog 2019-01-24 01:22:09 UTC (rev 240390) @@ -1,5 +1,90 @@ 2019-01-23 Alan Coon +Cherry-pick r240175. rdar://problem/47458146 + +Gigacages should start allocations from a slide +https://bugs.webkit.org/show_bug.cgi?id=193523 + +Reviewed by Mark Lam. + +Source/bmalloc: + +This patch makes it so that Gigacage Heaps slide the start of the +cage by some random amount. We still ensure that there is always +at least 4/2GB, on MacOS/iOS respectively, of VA space available +for allocation. + +Also, this patch changes some macros into constants since macros +are the devil. + +* bmalloc/Gigacage.cpp: +(Gigacage::bmalloc::protectGigacageBasePtrs): +(Gigacage::bmalloc::unprotectGigacageBasePtrs): +(Gigacage::bmalloc::runwaySize): +(Gigacage::ensureGigacage): +(Gigacage::shouldBeEnabled): +* bmalloc/Gigacage.h: +(Gigacage::name): +(Gigacage::gigacageSizeToMask): +(Gigacage::size): +(Gigacage::mask): +(Gigacage::basePtr): +(Gigacage::ensureGigacage): +(Gigacage::wasEnabled): +(Gigacage::isCaged): +(Gigacage::isEnabled): +(Gigacage::caged): +(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled): +(Gigacage::canPrimitiveGigacageBeDisabled): +(Gigacage::disablePrimitiveGigacage): +(Gigacage::addPrimitiveDisableCallback): +(Gigacage::removePrimitiveDisableCallback): +* bmalloc/Heap.cpp: +(bmalloc::Heap::Heap): +* bmalloc/Sizes.h: +(bmalloc::Sizes::maskSizeClass): +(bmalloc::Sizes::maskObjectSize): +(bmalloc::Sizes::logSizeClass): +(bmalloc::Sizes::logObjectSize): +(bmalloc::Sizes::sizeClass): +(bmalloc::Sizes::objectSize): +(bmalloc::Sizes::pageSize): + +
[webkit-changes] [240391] branches/safari-607-branch/Source/JavaScriptCore
Title: [240391] branches/safari-607-branch/Source/_javascript_Core Revision 240391 Author alanc...@apple.com Date 2019-01-23 17:22:12 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240186. rdar://problem/47458146 Follow-up: Gigacages should start allocations from a slide * ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::caged): Add UNUSED_PARAM(kind) to fix the build. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240186 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/_javascript_Core/ChangeLog branches/safari-607-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp Diff Modified: branches/safari-607-branch/Source/_javascript_Core/ChangeLog (240390 => 240391) --- branches/safari-607-branch/Source/_javascript_Core/ChangeLog 2019-01-24 01:22:09 UTC (rev 240390) +++ branches/safari-607-branch/Source/_javascript_Core/ChangeLog 2019-01-24 01:22:12 UTC (rev 240391) @@ -1,5 +1,29 @@ 2019-01-23 Alan Coon +Cherry-pick r240186. rdar://problem/47458146 + +Follow-up: Gigacages should start allocations from a slide + + + +* ftl/FTLLowerDFGToB3.cpp: +(JSC::FTL::DFG::LowerDFGToB3::caged): Add UNUSED_PARAM(kind) to +fix the build. + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240186 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-18 David Kilzer + +Follow-up: Gigacages should start allocations from a slide + + + +* ftl/FTLLowerDFGToB3.cpp: +(JSC::FTL::DFG::LowerDFGToB3::caged): Add UNUSED_PARAM(kind) to +fix the build. + +2019-01-23 Alan Coon + Cherry-pick r240175. rdar://problem/47458146 Gigacages should start allocations from a slide Modified: branches/safari-607-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (240390 => 240391) --- branches/safari-607-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp 2019-01-24 01:22:09 UTC (rev 240390) +++ branches/safari-607-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp 2019-01-24 01:22:12 UTC (rev 240391) @@ -13874,6 +13874,7 @@ // https://bugs.webkit.org/show_bug.cgi?id=175493 return m_out.opaque(result); #else +UNUSED_PARAM(kind); return ptr; #endif } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240388] branches/safari-607-branch
Title: [240388] branches/safari-607-branch Revision 240388 Author alanc...@apple.com Date 2019-01-23 17:22:00 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240158. rdar://problem/47458281 FetchResponse::url should return the empty string for tainted responses https://bugs.webkit.org/show_bug.cgi?id=193553 Reviewed by Youenn Fablet. LayoutTests/imported/w3c: * web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js: (fetchNoCors): Source/WebCore: Check whether the response is tainted in FetchResponse::url, to match the behavior described in https://fetch.spec.whatwg.org/#concept-filtered-response-opaque. * Modules/fetch/FetchResponse.cpp: (WebCore::FetchResponse::url const): LayoutTests: * http/wpt/fetch/response-opaque-clone.html: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240158 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/LayoutTests/ChangeLog branches/safari-607-branch/LayoutTests/http/wpt/fetch/response-opaque-clone.html branches/safari-607-branch/LayoutTests/imported/w3c/ChangeLog branches/safari-607-branch/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.js branches/safari-607-branch/Source/WebCore/ChangeLog branches/safari-607-branch/Source/WebCore/Modules/fetch/FetchResponse.cpp Diff Modified: branches/safari-607-branch/LayoutTests/ChangeLog (240387 => 240388) --- branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-24 01:21:56 UTC (rev 240387) +++ branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-24 01:22:00 UTC (rev 240388) @@ -1,5 +1,42 @@ 2019-01-23 Alan Coon +Cherry-pick r240158. rdar://problem/47458281 + +FetchResponse::url should return the empty string for tainted responses +https://bugs.webkit.org/show_bug.cgi?id=193553 + +Reviewed by Youenn Fablet. + +LayoutTests/imported/w3c: + +* web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js: +(fetchNoCors): + +Source/WebCore: + +Check whether the response is tainted in FetchResponse::url, to match +the behavior described in https://fetch.spec.whatwg.org/#concept-filtered-response-opaque. + +* Modules/fetch/FetchResponse.cpp: +(WebCore::FetchResponse::url const): + +LayoutTests: + +* http/wpt/fetch/response-opaque-clone.html: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240158 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-18 Ali Juma + +FetchResponse::url should return the empty string for tainted responses +https://bugs.webkit.org/show_bug.cgi?id=193553 + +Reviewed by Youenn Fablet. + +* http/wpt/fetch/response-opaque-clone.html: + +2019-01-23 Alan Coon + Cherry-pick r240152. rdar://problem/47458242 A track source should be unmuted whenever reenabled after setDirection changes Modified: branches/safari-607-branch/LayoutTests/http/wpt/fetch/response-opaque-clone.html (240387 => 240388) --- branches/safari-607-branch/LayoutTests/http/wpt/fetch/response-opaque-clone.html 2019-01-24 01:21:56 UTC (rev 240387) +++ branches/safari-607-branch/LayoutTests/http/wpt/fetch/response-opaque-clone.html 2019-01-24 01:22:00 UTC (rev 240388) @@ -16,6 +16,7 @@ assert_equals(response.type, "opaque", testName + " type"); assert_equals(response.status, 0, testName + " status"); assert_equals(response.statusText, "", testName + " statusText"); +assert_equals(response.url, "", testName + " url"); assert_false(response.redirected, testName + " redirected"); assert_true(response.headers.values().next().done, testName + " headers"); assert_equals(response.body, null, testName + " opaque response body should be null"); Modified: branches/safari-607-branch/LayoutTests/imported/w3c/ChangeLog (240387 => 240388) --- branches/safari-607-branch/LayoutTests/imported/w3c/ChangeLog 2019-01-24 01:21:56 UTC (rev 240387) +++ branches/safari-607-branch/LayoutTests/imported/w3c/ChangeLog 2019-01-24 01:22:00 UTC (rev 240388) @@ -1,3 +1,41 @@ +2019-01-23 Alan Coon + +Cherry-pick r240158. rdar://problem/47458281 + +FetchResponse::url should return the empty string for tainted responses +https://bugs.webkit.org/show_bug.cgi?id=193553 + +Reviewed by Youenn Fablet. + +LayoutTests/imported/w3c: + +* web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js: +(fetchNoCors): + +Source/WebCore: + +Check whether the response is tainted in FetchResponse::url, to match +the behavior described in https://fetch.spec.whatwg.org/#concept-filtered-response-opaque. + +* Modules/fetch/FetchResponse.cpp: +(WebCore::FetchResponse::url const): + +LayoutTests: + +* http/wpt/fetch/response-opaque-clone.html: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240158
[webkit-changes] [240386] branches/safari-607-branch/Source/WebKitLegacy/win
Title: [240386] branches/safari-607-branch/Source/WebKitLegacy/win
Revision 240386
Author alanc...@apple.com
Date 2019-01-23 17:21:52 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r240131. rdar://problem/47458219
[Win][HighDPI] Repaint glitches when scrolling.
https://bugs.webkit.org/show_bug.cgi?id=173152
Reviewed by Brent Fulgham.
Non-integral device scale factors are causing repaint glitches, because the computation of the scroll
delta in pixel coordinates from the scroll delta in logical coordinates will not always be correct.
Instead of blitting the scroll rectangle, repaint the entire region affected by scrolling.
* WebView.cpp:
(WebView::scrollBackingStore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/Source/WebKitLegacy/win/ChangeLog
branches/safari-607-branch/Source/WebKitLegacy/win/WebView.cpp
Diff
Modified: branches/safari-607-branch/Source/WebKitLegacy/win/ChangeLog (240385 => 240386)
--- branches/safari-607-branch/Source/WebKitLegacy/win/ChangeLog 2019-01-24 01:21:50 UTC (rev 240385)
+++ branches/safari-607-branch/Source/WebKitLegacy/win/ChangeLog 2019-01-24 01:21:52 UTC (rev 240386)
@@ -1,3 +1,38 @@
+2019-01-23 Alan Coon
+
+Cherry-pick r240131. rdar://problem/47458219
+
+[Win][HighDPI] Repaint glitches when scrolling.
+https://bugs.webkit.org/show_bug.cgi?id=173152
+
+
+Reviewed by Brent Fulgham.
+
+Non-integral device scale factors are causing repaint glitches, because the computation of the scroll
+delta in pixel coordinates from the scroll delta in logical coordinates will not always be correct.
+Instead of blitting the scroll rectangle, repaint the entire region affected by scrolling.
+
+* WebView.cpp:
+(WebView::scrollBackingStore):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-17 Per Arne Vollan
+
+[Win][HighDPI] Repaint glitches when scrolling.
+https://bugs.webkit.org/show_bug.cgi?id=173152
+
+
+Reviewed by Brent Fulgham.
+
+Non-integral device scale factors are causing repaint glitches, because the computation of the scroll
+delta in pixel coordinates from the scroll delta in logical coordinates will not always be correct.
+Instead of blitting the scroll rectangle, repaint the entire region affected by scrolling.
+
+* WebView.cpp:
+(WebView::scrollBackingStore):
+
2018-12-24 Fujii Hironori
Remove "using namespace std;"
Modified: branches/safari-607-branch/Source/WebKitLegacy/win/WebView.cpp (240385 => 240386)
--- branches/safari-607-branch/Source/WebKitLegacy/win/WebView.cpp 2019-01-24 01:21:50 UTC (rev 240385)
+++ branches/safari-607-branch/Source/WebKitLegacy/win/WebView.cpp 2019-01-24 01:21:52 UTC (rev 240386)
@@ -951,6 +951,19 @@
void WebView::scrollBackingStore(FrameView* frameView, int logicalDx, int logicalDy, const IntRect& logicalScrollViewRect, const IntRect& logicalClipRect)
{
+if (deviceScaleFactor() != static_cast(deviceScaleFactor())) {
+// Non-integral device scale factors are causing repaint glitches, because the computation of the scroll
+// delta in pixel coordinates from the scroll delta in logical coordinates will not always be correct.
+// Instead of blitting the scroll rectangle, repaint the entire region affected by scrolling.
+// FIXME: This is inefficient, we should be able to blit the scroll rectangle in this case as well,
+// see https://bugs.webkit.org/show_bug.cgi?id=193542.
+IntRect repaintRect = logicalScrollViewRect;
+repaintRect.move(logicalDx, logicalDy);
+repaintRect.unite(logicalScrollViewRect);
+repaint(repaintRect, true);
+return;
+}
+
m_needsDisplay = true;
// Dimensions passed to us from WebCore are in logical units. We must convert to pixels:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240387] branches/safari-607-branch
Title: [240387] branches/safari-607-branch Revision 240387 Author alanc...@apple.com Date 2019-01-23 17:21:56 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240152. rdar://problem/47458242 A track source should be unmuted whenever reenabled after setDirection changes https://bugs.webkit.org/show_bug.cgi?id=193554 Reviewed by Eric Carlson. Source/WebCore: Ensure that track gets unmuted after being fired as part of track event. Test is triggering some existing issues with MediaPlayerPrivateMediaStreamAVFObjC. Given the enqueuing of samples happens in a different frame than the thread used to update media stream and the active video track, some enqueued samples might not be from the right active video track or there might be no active video track. Test: webrtc/video-setDirection.html * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::fireTrackEvent): * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSample): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::requestNotificationWhenReadyForVideoData): LayoutTests: * webrtc/video-setDirection-expected.txt: Added. * webrtc/video-setDirection.html: Added. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240152 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/LayoutTests/ChangeLog branches/safari-607-branch/Source/WebCore/ChangeLog branches/safari-607-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp branches/safari-607-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h branches/safari-607-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm Added Paths branches/safari-607-branch/LayoutTests/webrtc/video-setDirection-expected.txt branches/safari-607-branch/LayoutTests/webrtc/video-setDirection.html Diff Modified: branches/safari-607-branch/LayoutTests/ChangeLog (240386 => 240387) --- branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-24 01:21:52 UTC (rev 240386) +++ branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-24 01:21:56 UTC (rev 240387) @@ -1,3 +1,48 @@ +2019-01-23 Alan Coon + +Cherry-pick r240152. rdar://problem/47458242 + +A track source should be unmuted whenever reenabled after setDirection changes +https://bugs.webkit.org/show_bug.cgi?id=193554 + + +Reviewed by Eric Carlson. + +Source/WebCore: + +Ensure that track gets unmuted after being fired as part of track event. +Test is triggering some existing issues with MediaPlayerPrivateMediaStreamAVFObjC. +Given the enqueuing of samples happens in a different frame than the thread used to update media stream and the active video track, +some enqueued samples might not be from the right active video track or there might be no active video track. + +Test: webrtc/video-setDirection.html + +* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: +(WebCore::LibWebRTCMediaEndpoint::fireTrackEvent): +* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h: +* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: +(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSample): +(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::requestNotificationWhenReadyForVideoData): + +LayoutTests: + +* webrtc/video-setDirection-expected.txt: Added. +* webrtc/video-setDirection.html: Added. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240152 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-18 Youenn Fablet + +A track source should be unmuted whenever reenabled after setDirection changes +https://bugs.webkit.org/show_bug.cgi?id=193554 + + +Reviewed by Eric Carlson. + +* webrtc/video-setDirection-expected.txt: Added. +* webrtc/video-setDirection.html: Added. + 2019-01-22 Alan Coon Cherry-pick r240046. rdar://problem/47099573 Added: branches/safari-607-branch/LayoutTests/webrtc/video-setDirection-expected.txt (0 => 240387) --- branches/safari-607-branch/LayoutTests/webrtc/video-setDirection-expected.txt (rev 0) +++ branches/safari-607-branch/LayoutTests/webrtc/video-setDirection-expected.txt 2019-01-24 01:21:56 UTC (rev 240387) @@ -0,0 +1,5 @@ + + +PASS Going from sendrecv to inactive and back to sendrecv +FAIL The MediaStream should remain the same assert_equals: expected object "[object MediaStream]" but got object "[object MediaStream]" + Added: branches/safari-607-branch/LayoutTests/webrtc/video-setDirection.html (0 => 240387) ---
[webkit-changes] [240394] branches/safari-607-branch
Title: [240394] branches/safari-607-branch
Revision 240394
Author alanc...@apple.com
Date 2019-01-23 17:22:21 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r240229. rdar://problem/47458326
DFG: When inlining DataView set* intrinsics we need to set undefined as our result
https://bugs.webkit.org/show_bug.cgi?id=193644
Reviewed by Yusuke Suzuki.
JSTests:
* stress/data-view-set-intrinsic-undefined-result-2.js: Added.
(foo):
* stress/data-view-set-intrinsic-undefined-result.js: Added.
(foo):
(bar):
Source/_javascript_Core:
This patch also makes it so we fail fast when we make this mistake.
I've made this mistake more than once.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/JSTests/ChangeLog
branches/safari-607-branch/Source/_javascript_Core/ChangeLog
branches/safari-607-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
Added Paths
branches/safari-607-branch/JSTests/stress/data-view-set-intrinsic-undefined-result-2.js
branches/safari-607-branch/JSTests/stress/data-view-set-intrinsic-undefined-result.js
Diff
Modified: branches/safari-607-branch/JSTests/ChangeLog (240393 => 240394)
--- branches/safari-607-branch/JSTests/ChangeLog 2019-01-24 01:22:17 UTC (rev 240393)
+++ branches/safari-607-branch/JSTests/ChangeLog 2019-01-24 01:22:21 UTC (rev 240394)
@@ -1,5 +1,48 @@
2019-01-23 Alan Coon
+Cherry-pick r240229. rdar://problem/47458326
+
+DFG: When inlining DataView set* intrinsics we need to set undefined as our result
+https://bugs.webkit.org/show_bug.cgi?id=193644
+
+
+Reviewed by Yusuke Suzuki.
+
+JSTests:
+
+* stress/data-view-set-intrinsic-undefined-result-2.js: Added.
+(foo):
+* stress/data-view-set-intrinsic-undefined-result.js: Added.
+(foo):
+(bar):
+
+Source/_javascript_Core:
+
+This patch also makes it so we fail fast when we make this mistake.
+I've made this mistake more than once.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-20 Saam Barati
+
+DFG: When inlining DataView set* intrinsics we need to set undefined as our result
+https://bugs.webkit.org/show_bug.cgi?id=193644
+
+
+Reviewed by Yusuke Suzuki.
+
+* stress/data-view-set-intrinsic-undefined-result-2.js: Added.
+(foo):
+* stress/data-view-set-intrinsic-undefined-result.js: Added.
+(foo):
+(bar):
+
+2019-01-23 Alan Coon
+
Cherry-pick r240114. rdar://problem/47458257
StringObjectUse should not be a structure check for the original string object structure
Added: branches/safari-607-branch/JSTests/stress/data-view-set-intrinsic-undefined-result-2.js (0 => 240394)
--- branches/safari-607-branch/JSTests/stress/data-view-set-intrinsic-undefined-result-2.js (rev 0)
+++ branches/safari-607-branch/JSTests/stress/data-view-set-intrinsic-undefined-result-2.js 2019-01-24 01:22:21 UTC (rev 240394)
@@ -0,0 +1,11 @@
+function foo(view) {
+return view.setInt8(0, 0);
+}
+noInline(foo);
+
+let a = new Int8Array(10);
+let dataView = new DataView(a.buffer);
+for (let i = 0; i < 1; ++i) {
+if (foo(dataView) !== undefined)
+throw new Error("Bad!")
+}
Added: branches/safari-607-branch/JSTests/stress/data-view-set-intrinsic-undefined-result.js (0 => 240394)
--- branches/safari-607-branch/JSTests/stress/data-view-set-intrinsic-undefined-result.js (rev 0)
+++ branches/safari-607-branch/JSTests/stress/data-view-set-intrinsic-undefined-result.js 2019-01-24 01:22:21 UTC (rev 240394)
@@ -0,0 +1,20 @@
+let setInt8 = DataView.prototype.setInt8;
+
+function foo() {
+ new bar();
+ xyz(setInt8(0, 0));
+}
+
+function bar(a) {
+ if (a) {
+return;
+ }
+ if (0 === undefined) {
+ }
+ a = + String(0);
+ foo(0);
+}
+
+try {
+foo();
+} catch { }
Modified: branches/safari-607-branch/Source/_javascript_Core/ChangeLog (240393 => 240394)
--- branches/safari-607-branch/Source/_javascript_Core/ChangeLog 2019-01-24 01:22:17 UTC (rev 240393)
+++ branches/safari-607-branch/Source/_javascript_Core/ChangeLog 2019-01-24 01:22:21 UTC (rev 240394)
@@ -1,5 +1,48 @@
2019-01-23 Alan Coon
+Cherry-pick r240229. rdar://problem/47458326
+
+DFG: When inlining DataView set* intrinsics we need to set undefined as our result
+https://bugs.webkit.org/show_bug.cgi?id=193644
+
+
+Reviewed by Yusuke Suzuki.
+
+JSTests:
+
+* stress/data-view-set-intrinsic-undefined-result-2.js: Added.
+(foo):
+*
[webkit-changes] [240383] branches/safari-607-branch/Source/WebCore
Title: [240383] branches/safari-607-branch/Source/WebCore
Revision 240383
Author alanc...@apple.com
Date 2019-01-23 17:21:40 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r240112. rdar://problem/47458291
[EME] Remove Amazon Prime Video from quirks list
https://bugs.webkit.org/show_bug.cgi?id=193514
rdar://problem/47295330
Reviewed by Jer Noble.
* page/Quirks.cpp:
(WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/Source/WebCore/ChangeLog
branches/safari-607-branch/Source/WebCore/page/Quirks.cpp
Diff
Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (240382 => 240383)
--- branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 01:21:37 UTC (rev 240382)
+++ branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 01:21:40 UTC (rev 240383)
@@ -1,5 +1,32 @@
2019-01-23 Alan Coon
+Cherry-pick r240112. rdar://problem/47458291
+
+[EME] Remove Amazon Prime Video from quirks list
+https://bugs.webkit.org/show_bug.cgi?id=193514
+rdar://problem/47295330
+
+Reviewed by Jer Noble.
+
+* page/Quirks.cpp:
+(WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-17 Jon Lee
+
+[EME] Remove Amazon Prime Video from quirks list
+https://bugs.webkit.org/show_bug.cgi?id=193514
+rdar://problem/47295330
+
+Reviewed by Jer Noble.
+
+* page/Quirks.cpp:
+(WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):
+
+2019-01-23 Alan Coon
+
Cherry-pick r240049. rdar://problem/47458184
ServiceWorkerContainer is leaking due to a ref cycle
Modified: branches/safari-607-branch/Source/WebCore/page/Quirks.cpp (240382 => 240383)
--- branches/safari-607-branch/Source/WebCore/page/Quirks.cpp 2019-01-24 01:21:37 UTC (rev 240382)
+++ branches/safari-607-branch/Source/WebCore/page/Quirks.cpp 2019-01-24 01:21:40 UTC (rev 240383)
@@ -48,11 +48,7 @@
auto domain = m_document->securityOrigin().domain().convertToASCIILowercase();
-m_hasBrokenEncryptedMediaAPISupportQuirk = domain == "amazon.com"
-|| domain.endsWith(".amazon.com")
-|| domain == "primevideo.com"
-|| domain.endsWith(".primevideo.com")
-|| domain == "starz.com"
+m_hasBrokenEncryptedMediaAPISupportQuirk = domain == "starz.com"
|| domain.endsWith(".starz.com")
|| domain == "hulu.com"
|| domain.endsWith("hulu.com");
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240380] branches/safari-607-branch/Source/WebCore
Title: [240380] branches/safari-607-branch/Source/WebCore Revision 240380 Author alanc...@apple.com Date 2019-01-23 17:21:32 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240049. rdar://problem/47458184 ServiceWorkerContainer is leaking due to a ref cycle https://bugs.webkit.org/show_bug.cgi?id=193462 Reviewed by Brady Eidson. ServiceWorkerContainer keeps a reference to its ready promise. The ready promise keeps a ref to its value which is a ServiceWorkerRegistration. ServiceWorkerRegistration keeps a ref to ServiceWorkerContainer. To break the reference cycle, set the ready promise to zero when ServiceWorkerContainer is stopped. Covered by imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html no longer leaking. * workers/service/ServiceWorkerContainer.cpp: (WebCore::ServiceWorkerContainer::stop): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240049 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/WebCore/ChangeLog branches/safari-607-branch/Source/WebCore/workers/service/ServiceWorkerContainer.cpp Diff Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (240379 => 240380) --- branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 01:21:29 UTC (rev 240379) +++ branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 01:21:32 UTC (rev 240380) @@ -1,5 +1,48 @@ 2019-01-23 Alan Coon +Cherry-pick r240049. rdar://problem/47458184 + +ServiceWorkerContainer is leaking due to a ref cycle +https://bugs.webkit.org/show_bug.cgi?id=193462 + + +Reviewed by Brady Eidson. + +ServiceWorkerContainer keeps a reference to its ready promise. +The ready promise keeps a ref to its value which is a ServiceWorkerRegistration. +ServiceWorkerRegistration keeps a ref to ServiceWorkerContainer. + +To break the reference cycle, set the ready promise to zero when ServiceWorkerContainer is stopped. + +Covered by imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html no longer leaking. + +* workers/service/ServiceWorkerContainer.cpp: +(WebCore::ServiceWorkerContainer::stop): + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240049 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-16 Youenn Fablet + +ServiceWorkerContainer is leaking due to a ref cycle +https://bugs.webkit.org/show_bug.cgi?id=193462 + + +Reviewed by Brady Eidson. + +ServiceWorkerContainer keeps a reference to its ready promise. +The ready promise keeps a ref to its value which is a ServiceWorkerRegistration. +ServiceWorkerRegistration keeps a ref to ServiceWorkerContainer. + +To break the reference cycle, set the ready promise to zero when ServiceWorkerContainer is stopped. + +Covered by imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html no longer leaking. + +* workers/service/ServiceWorkerContainer.cpp: +(WebCore::ServiceWorkerContainer::stop): + +2019-01-23 Alan Coon + Cherry-pick r240037. rdar://problem/47458128 Add more assertions to find root cause for release assert hit in StyleResolver Modified: branches/safari-607-branch/Source/WebCore/workers/service/ServiceWorkerContainer.cpp (240379 => 240380) --- branches/safari-607-branch/Source/WebCore/workers/service/ServiceWorkerContainer.cpp 2019-01-24 01:21:29 UTC (rev 240379) +++ branches/safari-607-branch/Source/WebCore/workers/service/ServiceWorkerContainer.cpp 2019-01-24 01:21:32 UTC (rev 240380) @@ -632,6 +632,7 @@ m_isStopped = true; removeAllEventListeners(); m_pendingPromises.clear(); +m_readyPromise = nullptr; for (auto& job : m_jobMap.values()) job->cancelPendingLoad(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240384] branches/safari-607-branch
Title: [240384] branches/safari-607-branch
Revision 240384
Author alanc...@apple.com
Date 2019-01-23 17:21:46 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r240114. rdar://problem/47458257
StringObjectUse should not be a structure check for the original string object structure
https://bugs.webkit.org/show_bug.cgi?id=193483
Reviewed by Yusuke Suzuki.
JSTests:
* stress/cant-eliminate-string-object-structure-check-when-string-object-is-proven.js: Added.
(foo):
(a.valueOf.0):
Source/_javascript_Core:
Prior to this patch, the use kind for StringObjectUse implied that we
do a StructureCheck on the input operand for the *original* StringObject
structure. This is generally not how we use UseKinds, so it's no surprise
that this is buggy. A UseKind should map to a set of SpeculatedTypes, not an
actual set of structures. This patch changes the meaning of StringObjectUse
to mean an object where jsDynamicCast would succeed.
This patch also fixes a bug that was caused by the old and weird usage of the
UseKind to mean StructureCheck. Consider a program like this:
```
S1 = Original StringObject structure
S2 = Original StringObject structure with the field "f" added
a: GetLocal()
b: CheckStructure(@a, {S2})
c: ToString(StringObject:@a)
```
According to AI, in the above program, we would exit at @c, since
StringObject:@a implies a structure check of {S1}, and the intersection
of {S1} and {S2} is {}. So, we'd convert the program to be:
```
a: GetLocal()
b: CheckStructure(@a, {S2})
c: Check(StringObject:@a)
d: Unreachable
```
However, AI would set the proof status of the StringObject:@a edge
to be proven, since the SpeculatedType for @a is SpecStringObject.
This was incorrect of AI to do because the SpeculatedType itself
didn't capture the full power of StringObjectUse. However, having
a UseKind mean CheckStructure is weird precisely because what AI was
doing is a natural fit to how we typically we think about UseKinds.
So the above program would then incorrectly be converted to this, and
we'd crash when reaching the Unreachable node:
```
a: GetLocal()
b: CheckStructure(@a, {S2})
d: Unreachable
```
This patch makes it so that StringObjectUse just means that the object that
filters through a StringObjectUse check must !!jsDynamicCast.
This is now in line with all other UseKinds. It also lets us simplify a bunch
of other code that had weird checks for the StringObjectUse UseKind.
This patch also makes it so that anywhere where we used to rely on
StringObjectUse implying a structure check we actually emit an explicit
CheckStructure node.
* _javascript_Core.xcodeproj/project.pbxproj:
* bytecode/ExitKind.cpp:
(JSC::exitKindToString):
* bytecode/ExitKind.h:
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGCSEPhase.cpp:
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGEdgeUsesStructure.h: Removed.
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::attemptToForceStringArrayModeByToStringConversion):
(JSC::DFG::FixupPhase::addCheckStructureForOriginalStringObjectUse):
(JSC::DFG::FixupPhase::fixupToPrimitive):
(JSC::DFG::FixupPhase::fixupToStringOrCallStringConstructor):
(JSC::DFG::FixupPhase::attemptToMakeFastStringAdd):
(JSC::DFG::FixupPhase::isStringObjectUse): Deleted.
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::canOptimizeStringObjectAccess):
* dfg/DFGMayExit.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileToStringOrCallStringConstructorOrStringValueOf):
(JSC::DFG::SpeculativeJIT::speculateStringObject):
(JSC::DFG::SpeculativeJIT::speculateStringOrStringObject):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure): Deleted.
* dfg/DFGUseKind.h:
(JSC::DFG::alreadyChecked):
(JSC::DFG::usesStructure): Deleted.
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileToStringOrCallStringConstructorOrStringValueOf):
(JSC::FTL::DFG::LowerDFGToB3::speculateStringObject):
(JSC::FTL::DFG::LowerDFGToB3::speculateStringOrStringObject):
(JSC::FTL::DFG::LowerDFGToB3::speculateStringObjectForCell):
(JSC::FTL::DFG::LowerDFGToB3::speculateStringObjectForStructureID): Deleted.
* runtime/JSType.cpp:
(WTF::printInternal):
* runtime/JSType.h:
* runtime/StringObject.h:
(JSC::StringObject::createStructure):
* runtime/StringPrototype.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/JSTests/ChangeLog
branches/safari-607-branch/Source/_javascript_Core/ChangeLog
[webkit-changes] [240378] branches/safari-607-branch
Title: [240378] branches/safari-607-branch Revision 240378 Author alanc...@apple.com Date 2019-01-23 17:21:26 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240040. rdar://problem/47458365 JSFunction::canUseAllocationProfile() should account for builtin functions with no own prototypes. https://bugs.webkit.org/show_bug.cgi?id=193423 Reviewed by Saam Barati. JSTests: * microbenchmarks/sinkable-new-object-with-builtin-constructor.js: Added. * stress/constructing-builtin-functions-with-getter-prototype-should-only-call-getter-once-per-new-1.js: Added. * stress/constructing-builtin-functions-with-getter-prototype-should-only-call-getter-once-per-new-2.js: Added. * stress/jsfunction-cannot-use-allocation-profile-with-builtin-functions-with-no-prototype.js: Added. Source/_javascript_Core: JSFunction::canUseAllocationProfile() should return false for most builtins because the majority of them have no prototype property. The only exception to this is the few builtin functions that are explicitly used as constructors. For these builtin constructors, JSFunction::canUseAllocationProfile() should also return false if the prototype property is a getter or custom getter because getting the prototype would then be effectful. * dfg/DFGOperations.cpp: * runtime/CommonSlowPaths.cpp: (JSC::SLOW_PATH_DECL): * runtime/JSFunctionInlines.h: (JSC::JSFunction::canUseAllocationProfile): * runtime/PropertySlot.h: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240040 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/JSTests/ChangeLog branches/safari-607-branch/Source/_javascript_Core/ChangeLog branches/safari-607-branch/Source/_javascript_Core/dfg/DFGOperations.cpp branches/safari-607-branch/Source/_javascript_Core/runtime/CommonSlowPaths.cpp branches/safari-607-branch/Source/_javascript_Core/runtime/JSFunctionInlines.h branches/safari-607-branch/Source/_javascript_Core/runtime/PropertySlot.h Added Paths branches/safari-607-branch/JSTests/microbenchmarks/sinkable-new-object-with-builtin-constructor.js branches/safari-607-branch/JSTests/stress/constructing-builtin-functions-with-getter-prototype-should-only-call-getter-once-per-new-1.js branches/safari-607-branch/JSTests/stress/constructing-builtin-functions-with-getter-prototype-should-only-call-getter-once-per-new-2.js branches/safari-607-branch/JSTests/stress/jsfunction-cannot-use-allocation-profile-with-builtin-functions-with-no-prototype.js Diff Modified: branches/safari-607-branch/JSTests/ChangeLog (240377 => 240378) --- branches/safari-607-branch/JSTests/ChangeLog 2019-01-24 01:21:22 UTC (rev 240377) +++ branches/safari-607-branch/JSTests/ChangeLog 2019-01-24 01:21:26 UTC (rev 240378) @@ -1,5 +1,56 @@ 2019-01-23 Alan Coon +Cherry-pick r240040. rdar://problem/47458365 + +JSFunction::canUseAllocationProfile() should account for builtin functions with no own prototypes. +https://bugs.webkit.org/show_bug.cgi?id=193423 + + +Reviewed by Saam Barati. + +JSTests: + +* microbenchmarks/sinkable-new-object-with-builtin-constructor.js: Added. +* stress/constructing-builtin-functions-with-getter-prototype-should-only-call-getter-once-per-new-1.js: Added. +* stress/constructing-builtin-functions-with-getter-prototype-should-only-call-getter-once-per-new-2.js: Added. +* stress/jsfunction-cannot-use-allocation-profile-with-builtin-functions-with-no-prototype.js: Added. + +Source/_javascript_Core: + +JSFunction::canUseAllocationProfile() should return false for most builtins +because the majority of them have no prototype property. The only exception to +this is the few builtin functions that are explicitly used as constructors. + +For these builtin constructors, JSFunction::canUseAllocationProfile() should also +return false if the prototype property is a getter or custom getter because +getting the prototype would then be effectful. + +* dfg/DFGOperations.cpp: +* runtime/CommonSlowPaths.cpp: +(JSC::SLOW_PATH_DECL): +* runtime/JSFunctionInlines.h: +(JSC::JSFunction::canUseAllocationProfile): +* runtime/PropertySlot.h: + + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240040 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-15 Mark Lam + +JSFunction::canUseAllocationProfile() should account for builtin functions with no own prototypes. +https://bugs.webkit.org/show_bug.cgi?id=193423 + + +Reviewed by Saam Barati. + +* microbenchmarks/sinkable-new-object-with-builtin-constructor.js: Added. +* stress/constructing-builtin-functions-with-getter-prototype-should-only-call-getter-once-per-new-1.js: Added. +*
[webkit-changes] [240379] branches/safari-607-branch/Source/WebKit
Title: [240379] branches/safari-607-branch/Source/WebKit Revision 240379 Author alanc...@apple.com Date 2019-01-23 17:21:29 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240045. rdar://problem/47458249 Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded() https://bugs.webkit.org/show_bug.cgi?id=193468 Reviewed by Zalan Bujtas. * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded): Adjust the null-check a bit; Zalan pointed out that the layout could be responsible for the Frame/RenderView going away, so we should bail *after* layout, not before. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240045 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/WebKit/ChangeLog branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm Diff Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240378 => 240379) --- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 01:21:26 UTC (rev 240378) +++ branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 01:21:29 UTC (rev 240379) @@ -1,5 +1,38 @@ 2019-01-23 Alan Coon +Cherry-pick r240045. rdar://problem/47458249 + +Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded() +https://bugs.webkit.org/show_bug.cgi?id=193468 + + +Reviewed by Zalan Bujtas. + +* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: +(WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded): +Adjust the null-check a bit; Zalan pointed out that the layout could +be responsible for the Frame/RenderView going away, so we should bail +*after* layout, not before. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240045 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-16 Tim Horton + +Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded() +https://bugs.webkit.org/show_bug.cgi?id=193468 + + +Reviewed by Zalan Bujtas. + +* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: +(WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded): +Adjust the null-check a bit; Zalan pointed out that the layout could +be responsible for the Frame/RenderView going away, so we should bail +*after* layout, not before. + +2019-01-23 Alan Coon + Cherry-pick r240016. rdar://problem/47458249 Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded() Modified: branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (240378 => 240379) --- branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2019-01-24 01:21:26 UTC (rev 240378) +++ branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2019-01-24 01:21:29 UTC (rev 240379) @@ -312,12 +312,12 @@ if (!m_shouldScaleViewToFitDocument) return; -if (!m_webPage.mainFrameView()->renderView()) -return; - LOG(Resize, "TiledCoreAnimationDrawingArea %p scaleViewToFitDocumentIfNeeded", this); m_webPage.layoutIfNeeded(); +if (!m_webPage.mainFrameView() || !m_webPage.mainFrameView()->renderView()) +return; + int viewWidth = m_webPage.size().width(); int documentWidth = m_webPage.mainFrameView()->renderView()->unscaledDocumentRect().width(); @@ -364,6 +364,9 @@ m_webPage.setUseFixedLayout(false); m_webPage.layoutIfNeeded(); +if (!m_webPage.mainFrameView() || !m_webPage.mainFrameView()->renderView()) +return; + IntSize documentSize = m_webPage.mainFrameView()->renderView()->unscaledDocumentRect().size(); m_lastViewSizeForScaleToFit = m_webPage.size(); m_lastDocumentSizeForScaleToFit = documentSize; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240382] branches/safari-607-branch/Source/WebKit
Title: [240382] branches/safari-607-branch/Source/WebKit Revision 240382 Author alanc...@apple.com Date 2019-01-23 17:21:37 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240087. rdar://problem/47458394 Revert r239938 https://bugs.webkit.org/show_bug.cgi?id=193267 * Configurations/WebContent-iOS.entitlements: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240087 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/WebKit/ChangeLog branches/safari-607-branch/Source/WebKit/Configurations/WebContent-iOS.entitlements Diff Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240381 => 240382) --- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 01:21:35 UTC (rev 240381) +++ branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 01:21:37 UTC (rev 240382) @@ -1,5 +1,27 @@ 2019-01-23 Alan Coon +Cherry-pick r240087. rdar://problem/47458394 + +Revert r239938 +https://bugs.webkit.org/show_bug.cgi?id=193267 + + +* Configurations/WebContent-iOS.entitlements: + + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240087 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-16 Alex Christensen + +Revert r239938 +https://bugs.webkit.org/show_bug.cgi?id=193267 + + +* Configurations/WebContent-iOS.entitlements: + +2019-01-23 Alan Coon + Cherry-pick r240045. rdar://problem/47458249 Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded() Modified: branches/safari-607-branch/Source/WebKit/Configurations/WebContent-iOS.entitlements (240381 => 240382) --- branches/safari-607-branch/Source/WebKit/Configurations/WebContent-iOS.entitlements 2019-01-24 01:21:35 UTC (rev 240381) +++ branches/safari-607-branch/Source/WebKit/Configurations/WebContent-iOS.entitlements 2019-01-24 01:21:37 UTC (rev 240382) @@ -2,6 +2,8 @@ + com.apple.private.network.socket-delegate + com.apple.private.allow-explicit-graphics-priority com.apple.private.network.socket-delegate ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240373] branches/safari-607-branch/Source/WebCore
Title: [240373] branches/safari-607-branch/Source/WebCore
Revision 240373
Author alanc...@apple.com
Date 2019-01-23 17:20:59 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r24. rdar://problem/47457985
Correctly handle rotation for local video playback
https://bugs.webkit.org/show_bug.cgi?id=193412
Reviewed by Eric Carlson.
Update AVVideoCaptureSource to compute the size given to settings after rotating the sample.
This ensures computing the size of video elements appropriately.
Also makes sure to notify observers of size change whenever rotation happens as settings() call will provide a different size.
Covered by manual testing as we do not have yet emulation of local capture with rotation.
* platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::setIntrinsicSize):
* platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::settings):
(WebCore::AVVideoCaptureSource::computeSampleRotation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/Source/WebCore/ChangeLog
branches/safari-607-branch/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
branches/safari-607-branch/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
Diff
Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (240372 => 240373)
--- branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 01:20:56 UTC (rev 240372)
+++ branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 01:20:59 UTC (rev 240373)
@@ -1,5 +1,46 @@
2019-01-23 Alan Coon
+Cherry-pick r24. rdar://problem/47457985
+
+Correctly handle rotation for local video playback
+https://bugs.webkit.org/show_bug.cgi?id=193412
+
+Reviewed by Eric Carlson.
+
+Update AVVideoCaptureSource to compute the size given to settings after rotating the sample.
+This ensures computing the size of video elements appropriately.
+Also makes sure to notify observers of size change whenever rotation happens as settings() call will provide a different size.
+Covered by manual testing as we do not have yet emulation of local capture with rotation.
+
+* platform/mediastream/RealtimeMediaSource.cpp:
+(WebCore::RealtimeMediaSource::setIntrinsicSize):
+* platform/mediastream/mac/AVVideoCaptureSource.mm:
+(WebCore::AVVideoCaptureSource::settings):
+(WebCore::AVVideoCaptureSource::computeSampleRotation):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-15 Youenn Fablet
+
+Correctly handle rotation for local video playback
+https://bugs.webkit.org/show_bug.cgi?id=193412
+
+Reviewed by Eric Carlson.
+
+Update AVVideoCaptureSource to compute the size given to settings after rotating the sample.
+This ensures computing the size of video elements appropriately.
+Also makes sure to notify observers of size change whenever rotation happens as settings() call will provide a different size.
+Covered by manual testing as we do not have yet emulation of local capture with rotation.
+
+* platform/mediastream/RealtimeMediaSource.cpp:
+(WebCore::RealtimeMediaSource::setIntrinsicSize):
+* platform/mediastream/mac/AVVideoCaptureSource.mm:
+(WebCore::AVVideoCaptureSource::settings):
+(WebCore::AVVideoCaptureSource::computeSampleRotation):
+
+2019-01-23 Alan Coon
+
Cherry-pick r239971. rdar://problem/47458229
Only run the node comparison code in FrameSelection::respondToNodeModification() for range selections
Modified: branches/safari-607-branch/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp (240372 => 240373)
--- branches/safari-607-branch/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp 2019-01-24 01:20:56 UTC (rev 240372)
+++ branches/safari-607-branch/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp 2019-01-24 01:20:59 UTC (rev 240373)
@@ -890,9 +890,10 @@
if (m_intrinsicSize == size)
return;
+auto currentSize = this->size();
m_intrinsicSize = size;
-if (m_intrinsicSize != m_size)
+if (currentSize != this->size())
notifySettingsDidChangeObservers({ RealtimeMediaSourceSettings::Flag::Width, RealtimeMediaSourceSettings::Flag::Height });
}
Modified: branches/safari-607-branch/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm (240372 => 240373)
--- branches/safari-607-branch/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm 2019-01-24 01:20:56 UTC (rev 240372)
+++ branches/safari-607-branch/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm 2019-01-24 01:20:59 UTC (rev 240373)
@@ -260,7 +260,11 @@
[webkit-changes] [240381] branches/safari-607-branch/Source/WebInspectorUI
Title: [240381] branches/safari-607-branch/Source/WebInspectorUI
Revision 240381
Author alanc...@apple.com
Date 2019-01-23 17:21:35 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r240051. rdar://problem/47458262
Web Inspector: Fix TreeOutline TypeError: this._indexesForSubtree is not a function
https://bugs.webkit.org/show_bug.cgi?id=193501
Reviewed by Joseph Pecoraro.
* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype.removeChildAtIndex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/Source/WebInspectorUI/ChangeLog
branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
Diff
Modified: branches/safari-607-branch/Source/WebInspectorUI/ChangeLog (240380 => 240381)
--- branches/safari-607-branch/Source/WebInspectorUI/ChangeLog 2019-01-24 01:21:32 UTC (rev 240380)
+++ branches/safari-607-branch/Source/WebInspectorUI/ChangeLog 2019-01-24 01:21:35 UTC (rev 240381)
@@ -1,3 +1,30 @@
+2019-01-23 Alan Coon
+
+Cherry-pick r240051. rdar://problem/47458262
+
+Web Inspector: Fix TreeOutline TypeError: this._indexesForSubtree is not a function
+https://bugs.webkit.org/show_bug.cgi?id=193501
+
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/TreeOutline.js:
+(WI.TreeOutline.prototype.removeChildAtIndex):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-16 Matt Baker
+
+Web Inspector: Fix TreeOutline TypeError: this._indexesForSubtree is not a function
+https://bugs.webkit.org/show_bug.cgi?id=193501
+
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/TreeOutline.js:
+(WI.TreeOutline.prototype.removeChildAtIndex):
+
2019-01-15 Alan Coon
Cherry-pick r239870. rdar://problem/47260266
Modified: branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (240380 => 240381)
--- branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2019-01-24 01:21:32 UTC (rev 240380)
+++ branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2019-01-24 01:21:35 UTC (rev 240381)
@@ -323,14 +323,15 @@
parent.select(true, false);
}
+let removedIndexes = null;
+
let treeOutline = child.treeOutline;
if (treeOutline) {
treeOutline._forgetTreeElement(child);
treeOutline._forgetChildrenRecursive(child);
+removedIndexes = treeOutline._indexesForSubtree(child);
}
-let removedIndexes = this._indexesForSubtree(child);
-
if (child.previousSibling)
child.previousSibling.nextSibling = child.nextSibling;
if (child.nextSibling)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240376] branches/safari-607-branch
Title: [240376] branches/safari-607-branch Revision 240376 Author alanc...@apple.com Date 2019-01-23 17:21:18 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240024. rdar://problem/47458299 [JSC] Use KnownStringUse for GetByVal(Array::String) since AI would offer wider type information and offer non-string type after removing Check(String) https://bugs.webkit.org/show_bug.cgi?id=193438 Reviewed by Saam Barati and Keith Miller. JSTests: Under the heavy load (like, compiling WebKit), AI in this code can broaden type information after the 1st run. Then, GetByVal(String) crashed. * stress/string-get-by-val-lowering.js: Added. (shouldBe): (test): * stress/type-for-get-by-val-can-be-widen-after-ai.js: Added. (Hello): (foo): Source/_javascript_Core: GetByVal(Array::String) emits Check(String) before that. But AI can broaden type constraint in the second run. After the first run removes Check(String), it would happen that AI starts saying the type of 1st child is not String. To claim that it *is* a String type, we should use KnownStringUse here. * dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): StringCharAt and GetByVal(Array::String) share the underlying compiler code. We should change StringUse => KnownStringUse for StringCharAt too. And StringCharAt and StringCharCodeAt potentially have the same problem. This patch fixes it too. * dfg/DFGSSALoweringPhase.cpp: (JSC::DFG::SSALoweringPhase::lowerBoundsCheck): * ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt): (JSC::FTL::DFG::LowerDFGToB3::compileStringCharCodeAt): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240024 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/JSTests/ChangeLog branches/safari-607-branch/Source/_javascript_Core/ChangeLog branches/safari-607-branch/Source/_javascript_Core/dfg/DFGFixupPhase.cpp branches/safari-607-branch/Source/_javascript_Core/dfg/DFGSSALoweringPhase.cpp branches/safari-607-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp Added Paths branches/safari-607-branch/JSTests/stress/string-get-by-val-lowering.js branches/safari-607-branch/JSTests/stress/type-for-get-by-val-can-be-widen-after-ai.js Diff Modified: branches/safari-607-branch/JSTests/ChangeLog (240375 => 240376) --- branches/safari-607-branch/JSTests/ChangeLog 2019-01-24 01:21:14 UTC (rev 240375) +++ branches/safari-607-branch/JSTests/ChangeLog 2019-01-24 01:21:18 UTC (rev 240376) @@ -1,5 +1,63 @@ 2019-01-23 Alan Coon +Cherry-pick r240024. rdar://problem/47458299 + +[JSC] Use KnownStringUse for GetByVal(Array::String) since AI would offer wider type information and offer non-string type after removing Check(String) +https://bugs.webkit.org/show_bug.cgi?id=193438 + + +Reviewed by Saam Barati and Keith Miller. + +JSTests: + +Under the heavy load (like, compiling WebKit), AI in this code can broaden type information after the 1st run. +Then, GetByVal(String) crashed. + +* stress/string-get-by-val-lowering.js: Added. +(shouldBe): +(test): +* stress/type-for-get-by-val-can-be-widen-after-ai.js: Added. +(Hello): +(foo): + +Source/_javascript_Core: + +GetByVal(Array::String) emits Check(String) before that. But AI can broaden type constraint in the second run. +After the first run removes Check(String), it would happen that AI starts saying the type of 1st child is not String. +To claim that it *is* a String type, we should use KnownStringUse here. + +* dfg/DFGFixupPhase.cpp: +(JSC::DFG::FixupPhase::fixupNode): StringCharAt and GetByVal(Array::String) share the underlying compiler code. We should +change StringUse => KnownStringUse for StringCharAt too. And StringCharAt and StringCharCodeAt potentially have the same +problem. This patch fixes it too. +* dfg/DFGSSALoweringPhase.cpp: +(JSC::DFG::SSALoweringPhase::lowerBoundsCheck): +* ftl/FTLLowerDFGToB3.cpp: +(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt): +(JSC::FTL::DFG::LowerDFGToB3::compileStringCharCodeAt): + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240024 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-15 Yusuke Suzuki + +[JSC] Use KnownStringUse for GetByVal(Array::String) since AI would offer wider type information and offer non-string type after removing Check(String) +https://bugs.webkit.org/show_bug.cgi?id=193438 + + +Reviewed by Saam Barati and Keith Miller. + +Under the heavy load (like, compiling WebKit), AI in this code can broaden type information after the 1st run. +Then, GetByVal(String) crashed. + +* stress/string-get-by-val-lowering.js: Added. +(shouldBe): +(test): +*
[webkit-changes] [240377] branches/safari-607-branch/Source/WebCore
Title: [240377] branches/safari-607-branch/Source/WebCore
Revision 240377
Author alanc...@apple.com
Date 2019-01-23 17:21:22 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r240037. rdar://problem/47458128
Add more assertions to find root cause for release assert hit in StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=193488
Reviewed by Zalan Bujtas.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::~StyleResolver):
Release assert we are not resolving tree style.
* dom/Document.cpp:
(WebCore::Document::setIsResolvingTreeStyle):
* dom/Document.h:
(WebCore::Document::isResolvingTreeStyle const):
* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::Scope::Scope):
(WebCore::Style::TreeResolver::Scope::~Scope):
Set isResolvingTreeStyle bit when we have a tree resolver scope.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/Source/WebCore/ChangeLog
branches/safari-607-branch/Source/WebCore/css/StyleResolver.cpp
branches/safari-607-branch/Source/WebCore/dom/Document.cpp
branches/safari-607-branch/Source/WebCore/dom/Document.h
branches/safari-607-branch/Source/WebCore/style/StyleTreeResolver.cpp
Diff
Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (240376 => 240377)
--- branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 01:21:18 UTC (rev 240376)
+++ branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 01:21:22 UTC (rev 240377)
@@ -1,5 +1,56 @@
2019-01-23 Alan Coon
+Cherry-pick r240037. rdar://problem/47458128
+
+Add more assertions to find root cause for release assert hit in StyleResolver
+https://bugs.webkit.org/show_bug.cgi?id=193488
+
+
+Reviewed by Zalan Bujtas.
+
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::~StyleResolver):
+
+Release assert we are not resolving tree style.
+
+* dom/Document.cpp:
+(WebCore::Document::setIsResolvingTreeStyle):
+* dom/Document.h:
+(WebCore::Document::isResolvingTreeStyle const):
+* style/StyleTreeResolver.cpp:
+(WebCore::Style::TreeResolver::Scope::Scope):
+(WebCore::Style::TreeResolver::Scope::~Scope):
+
+Set isResolvingTreeStyle bit when we have a tree resolver scope.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-16 Antti Koivisto
+
+Add more assertions to find root cause for release assert hit in StyleResolver
+https://bugs.webkit.org/show_bug.cgi?id=193488
+
+
+Reviewed by Zalan Bujtas.
+
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::~StyleResolver):
+
+Release assert we are not resolving tree style.
+
+* dom/Document.cpp:
+(WebCore::Document::setIsResolvingTreeStyle):
+* dom/Document.h:
+(WebCore::Document::isResolvingTreeStyle const):
+* style/StyleTreeResolver.cpp:
+(WebCore::Style::TreeResolver::Scope::Scope):
+(WebCore::Style::TreeResolver::Scope::~Scope):
+
+Set isResolvingTreeStyle bit when we have a tree resolver scope.
+
+2019-01-23 Alan Coon
+
Cherry-pick r24. rdar://problem/47457985
Correctly handle rotation for local video playback
Modified: branches/safari-607-branch/Source/WebCore/css/StyleResolver.cpp (240376 => 240377)
--- branches/safari-607-branch/Source/WebCore/css/StyleResolver.cpp 2019-01-24 01:21:18 UTC (rev 240376)
+++ branches/safari-607-branch/Source/WebCore/css/StyleResolver.cpp 2019-01-24 01:21:22 UTC (rev 240377)
@@ -267,6 +267,7 @@
StyleResolver::~StyleResolver()
{
+RELEASE_ASSERT(!m_document.isResolvingTreeStyle());
RELEASE_ASSERT(!m_isDeleted);
m_isDeleted = true;
Modified: branches/safari-607-branch/Source/WebCore/dom/Document.cpp (240376 => 240377)
--- branches/safari-607-branch/Source/WebCore/dom/Document.cpp 2019-01-24 01:21:18 UTC (rev 240376)
+++ branches/safari-607-branch/Source/WebCore/dom/Document.cpp 2019-01-24 01:21:22 UTC (rev 240377)
@@ -2324,6 +2324,12 @@
m_userAgentShadowTreeStyleResolver = nullptr;
}
+void Document::setIsResolvingTreeStyle(bool value)
+{
+RELEASE_ASSERT(value != m_isResolvingTreeStyle);
+m_isResolvingTreeStyle = value;
+}
+
void Document::createRenderTree()
{
ASSERT(!renderView());
Modified: branches/safari-607-branch/Source/WebCore/dom/Document.h (240376 => 240377)
--- branches/safari-607-branch/Source/WebCore/dom/Document.h 2019-01-24 01:21:18 UTC (rev 240376)
+++ branches/safari-607-branch/Source/WebCore/dom/Document.h 2019-01-24 01:21:22 UTC (rev 240377)
@@ -1330,6 +1330,8 @@
bool inStyleRecalc() const { return m_inStyleRecalc; }
bool inRenderTreeUpdate() const { return m_inRenderTreeUpdate; }
+bool
[webkit-changes] [240372] branches/safari-607-branch/Source/WebCore
Title: [240372] branches/safari-607-branch/Source/WebCore
Revision 240372
Author alanc...@apple.com
Date 2019-01-23 17:20:56 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r239971. rdar://problem/47458229
Only run the node comparison code in FrameSelection::respondToNodeModification() for range selections
https://bugs.webkit.org/show_bug.cgi?id=193416
Reviewed by Wenson Hsieh.
The code inside the m_selection.firstRange() clause needs to only run for non-collapsed selections, and
it shows up on Speedometer profiles so optimize to only run this code if we have a selection range.
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::respondToNodeModification):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/Source/WebCore/ChangeLog
branches/safari-607-branch/Source/WebCore/editing/FrameSelection.cpp
Diff
Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (240371 => 240372)
--- branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 01:20:52 UTC (rev 240371)
+++ branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-24 01:20:56 UTC (rev 240372)
@@ -1,3 +1,34 @@
+2019-01-23 Alan Coon
+
+Cherry-pick r239971. rdar://problem/47458229
+
+Only run the node comparison code in FrameSelection::respondToNodeModification() for range selections
+https://bugs.webkit.org/show_bug.cgi?id=193416
+
+Reviewed by Wenson Hsieh.
+
+The code inside the m_selection.firstRange() clause needs to only run for non-collapsed selections, and
+it shows up on Speedometer profiles so optimize to only run this code if we have a selection range.
+
+* editing/FrameSelection.cpp:
+(WebCore::FrameSelection::respondToNodeModification):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-14 Simon Fraser
+
+Only run the node comparison code in FrameSelection::respondToNodeModification() for range selections
+https://bugs.webkit.org/show_bug.cgi?id=193416
+
+Reviewed by Wenson Hsieh.
+
+The code inside the m_selection.firstRange() clause needs to only run for non-collapsed selections, and
+it shows up on Speedometer profiles so optimize to only run this code if we have a selection range.
+
+* editing/FrameSelection.cpp:
+(WebCore::FrameSelection::respondToNodeModification):
+
2019-01-22 Alan Coon
Cherry-pick r240046. rdar://problem/47099573
Modified: branches/safari-607-branch/Source/WebCore/editing/FrameSelection.cpp (240371 => 240372)
--- branches/safari-607-branch/Source/WebCore/editing/FrameSelection.cpp 2019-01-24 01:20:52 UTC (rev 240371)
+++ branches/safari-607-branch/Source/WebCore/editing/FrameSelection.cpp 2019-01-24 01:20:56 UTC (rev 240372)
@@ -513,16 +513,18 @@
m_selection.setWithoutValidation(m_selection.start(), m_selection.end());
else
m_selection.setWithoutValidation(m_selection.end(), m_selection.start());
-} else if (RefPtr range = m_selection.firstRange()) {
-auto compareNodeResult = range->compareNode(node);
-if (!compareNodeResult.hasException()) {
-auto compareResult = compareNodeResult.releaseReturnValue();
-if (compareResult == Range::NODE_BEFORE_AND_AFTER || compareResult == Range::NODE_INSIDE) {
-// If we did nothing here, when this node's renderer was destroyed, the rect that it
-// occupied would be invalidated, but, selection gaps that change as a result of
-// the removal wouldn't be invalidated.
-// FIXME: Don't do so much unnecessary invalidation.
-clearRenderTreeSelection = true;
+} else if (isRange()) {
+if (RefPtr range = m_selection.firstRange()) {
+auto compareNodeResult = range->compareNode(node);
+if (!compareNodeResult.hasException()) {
+auto compareResult = compareNodeResult.releaseReturnValue();
+if (compareResult == Range::NODE_BEFORE_AND_AFTER || compareResult == Range::NODE_INSIDE) {
+// If we did nothing here, when this node's renderer was destroyed, the rect that it
+// occupied would be invalidated, but, selection gaps that change as a result of
+// the removal wouldn't be invalidated.
+// FIXME: Don't do so much unnecessary invalidation.
+clearRenderTreeSelection = true;
+}
}
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240371] branches/safari-607-branch
Title: [240371] branches/safari-607-branch
Revision 240371
Author alanc...@apple.com
Date 2019-01-23 17:20:52 -0800 (Wed, 23 Jan 2019)
Log Message
Cherry-pick r239961. rdar://problem/47458424
[BigInt] Literal parsing is crashing when used inside a Object Literal
https://bugs.webkit.org/show_bug.cgi?id=193404
Reviewed by Yusuke Suzuki.
JSTests:
* stress/big-int-literal-inside-literal-object.js: Added.
Source/_javascript_Core:
Former implementation was relying into token.m_data.radix after the
call of `next()` into Parser.cpp. This is not safe because next
clobbers token.m_data.radix in some cases (e.g is CLOSEBRACE).
Now we get radix value before calling `next()` into parser and store
in a local variable.
* parser/Parser.cpp:
(JSC::Parser::parsePrimaryExpression):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/JSTests/ChangeLog
branches/safari-607-branch/Source/_javascript_Core/ChangeLog
branches/safari-607-branch/Source/_javascript_Core/parser/Parser.cpp
Added Paths
branches/safari-607-branch/JSTests/stress/big-int-literal-inside-literal-object.js
Diff
Modified: branches/safari-607-branch/JSTests/ChangeLog (240370 => 240371)
--- branches/safari-607-branch/JSTests/ChangeLog 2019-01-24 01:17:46 UTC (rev 240370)
+++ branches/safari-607-branch/JSTests/ChangeLog 2019-01-24 01:20:52 UTC (rev 240371)
@@ -1,3 +1,39 @@
+2019-01-23 Alan Coon
+
+Cherry-pick r239961. rdar://problem/47458424
+
+[BigInt] Literal parsing is crashing when used inside a Object Literal
+https://bugs.webkit.org/show_bug.cgi?id=193404
+
+Reviewed by Yusuke Suzuki.
+
+JSTests:
+
+* stress/big-int-literal-inside-literal-object.js: Added.
+
+Source/_javascript_Core:
+
+Former implementation was relying into token.m_data.radix after the
+call of `next()` into Parser.cpp. This is not safe because next
+clobbers token.m_data.radix in some cases (e.g is CLOSEBRACE).
+Now we get radix value before calling `next()` into parser and store
+in a local variable.
+
+* parser/Parser.cpp:
+(JSC::Parser::parsePrimaryExpression):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-14 Caio Lima
+
+[BigInt] Literal parsing is crashing when used inside a Object Literal
+https://bugs.webkit.org/show_bug.cgi?id=193404
+
+Reviewed by Yusuke Suzuki.
+
+* stress/big-int-literal-inside-literal-object.js: Added.
+
2019-01-15 Alan Coon
Cherry-pick r239882. rdar://problem/47260361
Added: branches/safari-607-branch/JSTests/stress/big-int-literal-inside-literal-object.js (0 => 240371)
--- branches/safari-607-branch/JSTests/stress/big-int-literal-inside-literal-object.js (rev 0)
+++ branches/safari-607-branch/JSTests/stress/big-int-literal-inside-literal-object.js 2019-01-24 01:20:52 UTC (rev 240371)
@@ -0,0 +1,21 @@
+//@ runBigIntEnabled
+
+var assert = {
+sameValue: function (input, expected) {
+if (input !== expected)
+throw new Error('Expected: ' + expected + ' but got: ' + input);
+}
+};
+
+var x = {y:1n}
+assert.sameValue(x.y, 1n);
+
+x = {y:{z:1n}};
+assert.sameValue(x.y.z, 1n);
+
+x = {y:-1212n}
+assert.sameValue(x.y, -1212n);
+
+x = {y:{z:-22312n}};
+assert.sameValue(x.y.z, -22312n);
+
Modified: branches/safari-607-branch/Source/_javascript_Core/ChangeLog (240370 => 240371)
--- branches/safari-607-branch/Source/_javascript_Core/ChangeLog 2019-01-24 01:17:46 UTC (rev 240370)
+++ branches/safari-607-branch/Source/_javascript_Core/ChangeLog 2019-01-24 01:20:52 UTC (rev 240371)
@@ -1,3 +1,46 @@
+2019-01-23 Alan Coon
+
+Cherry-pick r239961. rdar://problem/47458424
+
+[BigInt] Literal parsing is crashing when used inside a Object Literal
+https://bugs.webkit.org/show_bug.cgi?id=193404
+
+Reviewed by Yusuke Suzuki.
+
+JSTests:
+
+* stress/big-int-literal-inside-literal-object.js: Added.
+
+Source/_javascript_Core:
+
+Former implementation was relying into token.m_data.radix after the
+call of `next()` into Parser.cpp. This is not safe because next
+clobbers token.m_data.radix in some cases (e.g is CLOSEBRACE).
+Now we get radix value before calling `next()` into parser and store
+in a local variable.
+
+* parser/Parser.cpp:
+(JSC::Parser::parsePrimaryExpression):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-14 Caio Lima
+
+[BigInt] Literal parsing is crashing when used inside a Object Literal
+https://bugs.webkit.org/show_bug.cgi?id=193404
+
+Reviewed by Yusuke Suzuki.
+
+Former
[webkit-changes] [240374] branches/safari-607-branch/Source/WebKit
Title: [240374] branches/safari-607-branch/Source/WebKit Revision 240374 Author alanc...@apple.com Date 2019-01-23 17:21:01 -0800 (Wed, 23 Jan 2019) Log Message Cherry-pick r240016. rdar://problem/47458249 Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded() https://bugs.webkit.org/show_bug.cgi?id=193468 Reviewed by Beth Dakin. * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded): I'm not sure why this got *worse*, but we should null-check RenderView. It's OK to bail from scaleViewToFitDocumentIfNeeded, we'll re-do it the next time we paint (which will surely happen if we gain a RenderView). git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240016 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/WebKit/ChangeLog branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm Diff Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240373 => 240374) --- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 01:20:59 UTC (rev 240373) +++ branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-24 01:21:01 UTC (rev 240374) @@ -1,3 +1,36 @@ +2019-01-23 Alan Coon + +Cherry-pick r240016. rdar://problem/47458249 + +Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded() +https://bugs.webkit.org/show_bug.cgi?id=193468 + + +Reviewed by Beth Dakin. + +* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: +(WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded): +I'm not sure why this got *worse*, but we should null-check RenderView. +It's OK to bail from scaleViewToFitDocumentIfNeeded, we'll re-do it +the next time we paint (which will surely happen if we gain a RenderView). + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240016 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-15 Tim Horton + +Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded() +https://bugs.webkit.org/show_bug.cgi?id=193468 + + +Reviewed by Beth Dakin. + +* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: +(WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded): +I'm not sure why this got *worse*, but we should null-check RenderView. +It's OK to bail from scaleViewToFitDocumentIfNeeded, we'll re-do it +the next time we paint (which will surely happen if we gain a RenderView). + 2019-01-22 Alan Coon Cherry-pick r240055. rdar://problem/47099573 Modified: branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (240373 => 240374) --- branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2019-01-24 01:20:59 UTC (rev 240373) +++ branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2019-01-24 01:21:01 UTC (rev 240374) @@ -312,6 +312,9 @@ if (!m_shouldScaleViewToFitDocument) return; +if (!m_webPage.mainFrameView()->renderView()) +return; + LOG(Resize, "TiledCoreAnimationDrawingArea %p scaleViewToFitDocumentIfNeeded", this); m_webPage.layoutIfNeeded(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240370] trunk/Source
Title: [240370] trunk/Source
Revision 240370
Author mark@apple.com
Date 2019-01-23 17:17:46 -0800 (Wed, 23 Jan 2019)
Log Message
ARM64E should not ENABLE(SEPARATED_WX_HEAP).
https://bugs.webkit.org/show_bug.cgi?id=193744
Reviewed by Saam Barati.
Source/_javascript_Core:
* assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::copyCompactAndLinkCode):
Source/WTF:
* wtf/Platform.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/LinkBuffer.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (240369 => 240370)
--- trunk/Source/_javascript_Core/ChangeLog 2019-01-24 01:08:31 UTC (rev 240369)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-01-24 01:17:46 UTC (rev 240370)
@@ -1,3 +1,14 @@
+2019-01-23 Mark Lam
+
+ARM64E should not ENABLE(SEPARATED_WX_HEAP).
+https://bugs.webkit.org/show_bug.cgi?id=193744
+
+
+Reviewed by Saam Barati.
+
+* assembler/LinkBuffer.cpp:
+(JSC::LinkBuffer::copyCompactAndLinkCode):
+
2019-01-23 Yusuke Suzuki
[DFG] AvailabilityMap::pruneByLiveness should make non-live operands Availability::unavailable instead of Availability()
Modified: trunk/Source/_javascript_Core/assembler/LinkBuffer.cpp (240369 => 240370)
--- trunk/Source/_javascript_Core/assembler/LinkBuffer.cpp 2019-01-24 01:08:31 UTC (rev 240369)
+++ trunk/Source/_javascript_Core/assembler/LinkBuffer.cpp 2019-01-24 01:17:46 UTC (rev 240370)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012-2018 Apple Inc. All rights reserved.
+ * Copyright (C) 2012-2019 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -41,10 +41,6 @@
namespace JSC {
-#if ENABLE(SEPARATED_WX_HEAP)
-extern JS_EXPORT_PRIVATE bool useFastPermisionsJITCopy;
-#endif // ENABLE(SEPARATED_WX_HEAP)
-
bool shouldDumpDisassemblyFor(CodeBlock* codeBlock)
{
if (codeBlock && JITCode::isOptimizingJIT(codeBlock->jitType()) && Options::dumpDFGDisassembly())
@@ -120,14 +116,6 @@
template
void LinkBuffer::copyCompactAndLinkCode(MacroAssembler& macroAssembler, void* ownerUID, JITCompilationEffort effort)
{
-#if CPU(ARM64E) && ENABLE(FAST_JIT_PERMISSIONS)
-#if ENABLE(SEPARATED_WX_HEAP)
-const bool isUsingFastPermissionsJITCopy = useFastPermisionsJITCopy;
-#else
-const bool isUsingFastPermissionsJITCopy = true;
-#endif
-#endif
-
allocate(macroAssembler, ownerUID, effort);
const size_t initialSize = macroAssembler.m_assembler.codeSize();
if (didFailToAllocate())
@@ -142,11 +130,6 @@
const uint32_t expectedFinalHash = macroAssembler.m_assembler.buffer().hash().finalHash();
ARM64EHash verifyUncompactedHash;
uint8_t* outData = codeOutData;
-#if ENABLE(SEPARATED_WX_HEAP)
-AssemblerData outBuffer(m_size);
-if (!isUsingFastPermissionsJITCopy)
-outData = reinterpret_cast(outBuffer.buffer());
-#endif // ENABLE(SEPARATED_WX_HEAP)
#else
AssemblerData outBuffer(m_size);
uint8_t* outData = reinterpret_cast(outBuffer.buffer());
@@ -161,8 +144,7 @@
unsigned jumpCount = jumpsToLink.size();
#if CPU(ARM64E) && ENABLE(FAST_JIT_PERMISSIONS)
-if (isUsingFastPermissionsJITCopy)
-os_thread_self_restrict_rwx_to_rw();
+os_thread_self_restrict_rwx_to_rw();
#endif
if (m_shouldPerformBranchCompaction) {
@@ -249,8 +231,6 @@
for (unsigned i = 0; i < jumpCount; ++i) {
#if CPU(ARM64E) && ENABLE(FAST_JIT_PERMISSIONS)
auto memcpyFunction = memcpy;
-if (!isUsingFastPermissionsJITCopy)
-memcpyFunction = performJITMemcpy;
#else
auto memcpyFunction = performJITMemcpy;
#endif
@@ -267,8 +247,7 @@
}
#if CPU(ARM64E) && ENABLE(FAST_JIT_PERMISSIONS)
-if (isUsingFastPermissionsJITCopy)
-os_thread_self_restrict_rwx_to_rx();
+os_thread_self_restrict_rwx_to_rx();
#endif
if (m_executableMemory) {
@@ -280,12 +259,7 @@
ASSERT(codeOutData != outData);
performJITMemcpy(codeOutData, outData, m_size);
#else
-if (isUsingFastPermissionsJITCopy)
-ASSERT(codeOutData == outData);
-else {
-ASSERT(codeOutData != outData);
-performJITMemcpy(codeOutData, outData, m_size);
-}
+ASSERT(codeOutData == outData);
#endif
jumpsToLink.clear();
Modified: trunk/Source/WTF/ChangeLog (240369 => 240370)
--- trunk/Source/WTF/ChangeLog 2019-01-24 01:08:31 UTC (rev 240369)
+++ trunk/Source/WTF/ChangeLog 2019-01-24 01:17:46 UTC (rev 240370)
@@ -1,3 +1,13 @@
+2019-01-23 Mark Lam
+
+ARM64E should not ENABLE(SEPARATED_WX_HEAP).
+https://bugs.webkit.org/show_bug.cgi?id=193744
+
+
+Reviewed by Saam Barati.
+
+* wtf/Platform.h:
+
2019-01-23 David Kilzer
Switch remaining CoreMedia soft-linking in WebKit over to CoreMediaSoftLink.{cpp,h}
Modified:
[webkit-changes] [240369] trunk/Source/WebKitLegacy/mac
Title: [240369] trunk/Source/WebKitLegacy/mac Revision 240369 Author conrad_shu...@apple.com Date 2019-01-23 17:08:31 -0800 (Wed, 23 Jan 2019) Log Message Fix the Apple Internal build. See . Rubber-stamped by Tim Horton. * WebCoreSupport/WebFrameLoaderClient.mm: Modified Paths trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm Diff Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (240368 => 240369) --- trunk/Source/WebKitLegacy/mac/ChangeLog 2019-01-24 00:59:12 UTC (rev 240368) +++ trunk/Source/WebKitLegacy/mac/ChangeLog 2019-01-24 01:08:31 UTC (rev 240369) @@ -1,3 +1,11 @@ +2019-01-23 Conrad Shultz + +Fix the Apple Internal build. See . + +Rubber-stamped by Tim Horton. + +* WebCoreSupport/WebFrameLoaderClient.mm: + 2019-01-22 Conrad Shultz Clean up USE(WEB_THREAD) Modified: trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm (240368 => 240369) --- trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm 2019-01-24 00:59:12 UTC (rev 240368) +++ trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm 2019-01-24 01:08:31 UTC (rev 240369) @@ -132,6 +132,10 @@ #import #import +#if USE(APPLE_INTERNAL_SDK) +#import +#endif + #if USE(PLUGIN_HOST_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API) #import "NetscapePluginHostManager.h" #import "WebHostedNetscapePluginView.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240368] trunk/Source/WebInspectorUI
Title: [240368] trunk/Source/WebInspectorUI
Revision 240368
Author nvasil...@apple.com
Date 2019-01-23 16:59:12 -0800 (Wed, 23 Jan 2019)
Log Message
Web Inspector: Refactor WI.CSSStyleDeclaration.prototype.update
https://bugs.webkit.org/show_bug.cgi?id=193737
Reviewed by Matt Baker.
Remove unused event data from the WI.CSSStyleDeclaration.Event.PropertiesChanged event.
* UserInterface/Models/CSSStyleDeclaration.js:
(WI.CSSStyleDeclaration.prototype.update):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240367 => 240368)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-01-24 00:57:59 UTC (rev 240367)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-01-24 00:59:12 UTC (rev 240368)
@@ -1,3 +1,15 @@
+2019-01-23 Nikita Vasilyev
+
+Web Inspector: Refactor WI.CSSStyleDeclaration.prototype.update
+https://bugs.webkit.org/show_bug.cgi?id=193737
+
+Reviewed by Matt Baker.
+
+Remove unused event data from the WI.CSSStyleDeclaration.Event.PropertiesChanged event.
+
+* UserInterface/Models/CSSStyleDeclaration.js:
+(WI.CSSStyleDeclaration.prototype.update):
+
2019-01-23 Devin Rousso
WebInspector: Confusingly nested events in the timeline for Mutation Observers
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js (240367 => 240368)
--- trunk/Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js 2019-01-24 00:57:59 UTC (rev 240367)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js 2019-01-24 00:59:12 UTC (rev 240368)
@@ -111,8 +111,8 @@
text = text || "";
properties = properties || [];
-var oldProperties = this._properties || [];
-var oldText = this._text;
+let oldProperties = this._properties || [];
+let oldText = this._text;
this._text = text;
this._properties = properties;
@@ -123,7 +123,7 @@
this._visibleProperties = null;
-var editable = this.editable;
+let editable = this.editable;
for (let property of this._properties) {
property.ownerStyle = this;
@@ -140,46 +140,29 @@
}
}
-var removedProperties = [];
-for (var i = 0; i < oldProperties.length; ++i) {
-var oldProperty = oldProperties[i];
+for (let oldProperty of oldProperties) {
+if (this._enabledProperties.includes(oldProperty))
+continue;
-if (!this._enabledProperties.includes(oldProperty)) {
-// Clear the index, since it is no longer valid.
-oldProperty.index = NaN;
+// Clear the index, since it is no longer valid.
+oldProperty.index = NaN;
-removedProperties.push(oldProperty);
-
-// Keep around old properties in pending in case they
-// are needed again during editing.
-if (editable)
-this._pendingProperties.push(oldProperty);
-}
+// Keep around old properties in pending in case they
+// are needed again during editing.
+if (editable)
+this._pendingProperties.push(oldProperty);
}
if (dontFireEvents)
return;
-var addedProperties = [];
-for (var i = 0; i < this._enabledProperties.length; ++i) {
-if (!oldProperties.includes(this._enabledProperties[i]))
-addedProperties.push(this._enabledProperties[i]);
-}
-
// Don't fire the event if there is text and it hasn't changed.
-if (oldText && this._text && oldText === this._text) {
-if (!this._locked || suppressLock) {
-// We shouldn't have any added or removed properties in this case.
-console.assert(!addedProperties.length && !removedProperties.length);
-}
+if (oldText && this._text && oldText === this._text)
+return;
-if (!addedProperties.length && !removedProperties.length)
-return;
-}
-
function delayed()
{
-this.dispatchEventToListeners(WI.CSSStyleDeclaration.Event.PropertiesChanged, {addedProperties, removedProperties});
+this.dispatchEventToListeners(WI.CSSStyleDeclaration.Event.PropertiesChanged);
}
// Delay firing the PropertiesChanged event so DOMNodeStyles has a chance to mark overridden and associated properties.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240367] tags/Safari-608.1.2/
Title: [240367] tags/Safari-608.1.2/ Revision 240367 Author alanc...@apple.com Date 2019-01-23 16:57:59 -0800 (Wed, 23 Jan 2019) Log Message Tag Safari-608.1.2. Added Paths tags/Safari-608.1.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240366] trunk/Source/WebKit
Title: [240366] trunk/Source/WebKit
Revision 240366
Author achristen...@apple.com
Date 2019-01-23 16:29:48 -0800 (Wed, 23 Jan 2019)
Log Message
Stop using NetworkProcess::singleton
https://bugs.webkit.org/show_bug.cgi?id=193700
Reviewed by Don Olmstead.
This replaces it with a NeverDestroyed and paves the way for more interesting things.
* NetworkProcess/CustomProtocols/soup/LegacyCustomProtocolManagerSoup.cpp:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm:
(WebKit::initializeChildProcess):
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::singleton): Deleted.
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/soup/NetworkProcessMainSoup.cpp:
(WebKit::initializeChildProcess):
* NetworkProcess/win/NetworkProcessMainWin.cpp:
(WebKit::initializeChildProcess):
* Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::initializeChildProcess):
(WebKit::XPCServiceInitializer):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/CustomProtocols/soup/LegacyCustomProtocolManagerSoup.cpp
trunk/Source/WebKit/NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessMainSoup.cpp
trunk/Source/WebKit/NetworkProcess/win/NetworkProcessMainWin.cpp
trunk/Source/WebKit/Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h
trunk/Source/WebKit/Shared/unix/ChildProcessMain.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (240365 => 240366)
--- trunk/Source/WebKit/ChangeLog 2019-01-24 00:23:52 UTC (rev 240365)
+++ trunk/Source/WebKit/ChangeLog 2019-01-24 00:29:48 UTC (rev 240366)
@@ -1,3 +1,27 @@
+2019-01-23 Alex Christensen
+
+Stop using NetworkProcess::singleton
+https://bugs.webkit.org/show_bug.cgi?id=193700
+
+Reviewed by Don Olmstead.
+
+This replaces it with a NeverDestroyed and paves the way for more interesting things.
+
+* NetworkProcess/CustomProtocols/soup/LegacyCustomProtocolManagerSoup.cpp:
+* NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm:
+(WebKit::initializeChildProcess):
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::NetworkProcess):
+(WebKit::NetworkProcess::singleton): Deleted.
+* NetworkProcess/NetworkProcess.h:
+* NetworkProcess/soup/NetworkProcessMainSoup.cpp:
+(WebKit::initializeChildProcess):
+* NetworkProcess/win/NetworkProcessMainWin.cpp:
+(WebKit::initializeChildProcess):
+* Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
+(WebKit::initializeChildProcess):
+(WebKit::XPCServiceInitializer):
+
2019-01-23 Ryan Haddad
Unreviewed, rolling out r240343.
Modified: trunk/Source/WebKit/NetworkProcess/CustomProtocols/soup/LegacyCustomProtocolManagerSoup.cpp (240365 => 240366)
--- trunk/Source/WebKit/NetworkProcess/CustomProtocols/soup/LegacyCustomProtocolManagerSoup.cpp 2019-01-24 00:23:52 UTC (rev 240365)
+++ trunk/Source/WebKit/NetworkProcess/CustomProtocols/soup/LegacyCustomProtocolManagerSoup.cpp 2019-01-24 00:29:48 UTC (rev 240366)
@@ -74,7 +74,7 @@
void startRequest(GRefPtr&& task) override
{
WebKitSoupRequestGeneric* request = WEBKIT_SOUP_REQUEST_GENERIC(g_task_get_source_object(task.get()));
-auto* customProtocolManager = NetworkProcess::singleton().supplement();
+auto* customProtocolManager = lastCreatedNetworkProcess()->supplement();
if (!customProtocolManager)
return;
Modified: trunk/Source/WebKit/NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm (240365 => 240366)
--- trunk/Source/WebKit/NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm 2019-01-24 00:23:52 UTC (rev 240365)
+++ trunk/Source/WebKit/NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm 2019-01-24 00:29:48 UTC (rev 240366)
@@ -40,6 +40,12 @@
}
};
+template<>
+void initializeChildProcess(ChildProcessInitializationParameters&& parameters)
+{
+static NeverDestroyed networkProcess(WTFMove(parameters));
+}
+
} // namespace WebKit
using namespace WebKit;
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (240365 => 240366)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2019-01-24 00:23:52 UTC (rev 240365)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2019-01-24 00:29:48 UTC (rev 240366)
@@ -124,28 +124,11 @@
});
}
-NetworkProcess& NetworkProcess::singleton()
-{
-static NeverDestroyed> networkProcess(adoptRef(*new NetworkProcess));
-return networkProcess.get();
-}
-
-NetworkProcess::NetworkProcess()
-: m_hasSetCacheModel(false)
-, m_cacheModel(CacheModel::DocumentViewer)
-, m_diskCacheIsDisabledForTesting(false)
[webkit-changes] [240365] trunk/Source/WebKit
Title: [240365] trunk/Source/WebKit
Revision 240365
Author ryanhad...@apple.com
Date 2019-01-23 16:23:52 -0800 (Wed, 23 Jan 2019)
Log Message
Unreviewed, rolling out r240343.
Caused 4 PSON API test failures.
Reverted changeset:
"[PSON] Flash on back navigation on Mac"
https://bugs.webkit.org/show_bug.cgi?id=193716
https://trac.webkit.org/changeset/240343
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (240364 => 240365)
--- trunk/Source/WebKit/ChangeLog 2019-01-24 00:17:15 UTC (rev 240364)
+++ trunk/Source/WebKit/ChangeLog 2019-01-24 00:23:52 UTC (rev 240365)
@@ -1,3 +1,15 @@
+2019-01-23 Ryan Haddad
+
+Unreviewed, rolling out r240343.
+
+Caused 4 PSON API test failures.
+
+Reverted changeset:
+
+"[PSON] Flash on back navigation on Mac"
+https://bugs.webkit.org/show_bug.cgi?id=193716
+https://trac.webkit.org/changeset/240343
+
2019-01-23 Chris Dumez
Deprecate API to limit the maximum number of WebProcesses
Modified: trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp (240364 => 240365)
--- trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp 2019-01-24 00:17:15 UTC (rev 240364)
+++ trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp 2019-01-24 00:23:52 UTC (rev 240365)
@@ -26,7 +26,6 @@
#include "config.h"
#include "SuspendedPageProxy.h"
-#include "DrawingAreaProxy.h"
#include "Logging.h"
#include "WebPageMessages.h"
#include "WebPageProxy.h"
@@ -155,19 +154,6 @@
m_process->removeMessageReceiver(Messages::WebPageProxy::messageReceiverName(), m_page.pageID());
-bool shouldKeepOnFailure = false;
-#if PLATFORM(MAC)
-// With web process side tiles, we need to keep the suspended page around on failure to avoid flashing.
-// It is removed by WebPageProxy::enterAcceleratedCompositingMode when the target page is ready.
-shouldKeepOnFailure = m_page.drawingArea() && m_page.drawingArea()->type() == DrawingAreaTypeTiledCoreAnimation;
-#endif
-if (newSuspensionState == SuspensionState::FailedToSuspend && !shouldKeepOnFailure) {
-RunLoop::main().dispatch([weakProcessPool = makeWeakPtr(m_process->processPool()), weakThis = makeWeakPtr(*this)] {
-if (weakProcessPool && weakThis)
-weakProcessPool->removeSuspendedPage(*weakThis);
-});
-}
-
if (m_readyToUnsuspendHandler)
m_readyToUnsuspendHandler(this);
}
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (240364 => 240365)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-01-24 00:17:15 UTC (rev 240364)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-01-24 00:23:52 UTC (rev 240365)
@@ -6847,12 +6847,7 @@
void WebPageProxy::enterAcceleratedCompositingMode(const LayerTreeContext& layerTreeContext)
{
-#if PLATFORM(MAC)
-ASSERT(m_drawingArea->type() == DrawingAreaTypeTiledCoreAnimation);
-#endif
pageClient().enterAcceleratedCompositingMode(layerTreeContext);
-// We needed the failed suspended page to stay alive to avoid flashing. Now we can get rid of it.
-m_process->processPool().removeFailedSuspendedPagesForPage(*this);
}
void WebPageProxy::exitAcceleratedCompositingMode()
Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (240364 => 240365)
--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2019-01-24 00:17:15 UTC (rev 240364)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2019-01-24 00:23:52 UTC (rev 240365)
@@ -2262,13 +2262,6 @@
});
}
-void WebProcessPool::removeFailedSuspendedPagesForPage(WebPageProxy& page)
-{
-m_suspendedPages.removeAllMatching([](auto& suspendedPage) {
-return >page() == && suspendedPage->failedToSuspend();
-});
-}
-
std::unique_ptr WebProcessPool::takeSuspendedPage(SuspendedPageProxy& suspendedPage)
{
return m_suspendedPages.takeFirst([](auto& item) {
Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.h (240364 => 240365)
--- trunk/Source/WebKit/UIProcess/WebProcessPool.h 2019-01-24 00:17:15 UTC (rev 240364)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.h 2019-01-24 00:23:52 UTC (rev 240365)
@@ -447,7 +447,6 @@
// SuspendedPageProxy management.
void addSuspendedPage(std::unique_ptr&&);
void removeAllSuspendedPagesForPage(WebPageProxy&);
-void removeFailedSuspendedPagesForPage(WebPageProxy&);
std::unique_ptr takeSuspendedPage(SuspendedPageProxy&);
void removeSuspendedPage(SuspendedPageProxy&);
bool hasSuspendedPageFor(WebProcessProxy&) const;
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (240364 => 240365)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2019-01-24 00:17:15 UTC (rev 240364)
+++
[webkit-changes] [240364] trunk
Title: [240364] trunk
Revision 240364
Author ysuz...@apple.com
Date 2019-01-23 16:17:15 -0800 (Wed, 23 Jan 2019)
Log Message
[DFG] AvailabilityMap::pruneByLiveness should make non-live operands Availability::unavailable instead of Availability()
https://bugs.webkit.org/show_bug.cgi?id=193711
Reviewed by Saam Barati.
JSTests:
* stress/availability-was-cleared-when-locals-are-not-live.js: Added.
(shouldBe):
(foo):
(bar):
(baz):
Source/_javascript_Core:
When pruning OSR Availability based on bytecode liveness, we accidentally clear the Availability (making it DeadFlush) instead of
making it Availability::unavailable() (Making it ConflictingFlush). In OSRAvailabilityAnalysisPhase, we perform forward analysis.
We first clear all the availability of basic blocks DeadFlush, which is an empty set. And then, we set operands in the root block
ConflictingFlush. In this forward analysis, DeadFlush is BOTTOM, and ConflictingFlush is TOP. Then, we propagate information by
merging availability until we reach to the fixed-point. As an optimization, we perform "pruning" of the availability in the head
of the basic blocks. We remove availabilities of operands which are not live in the bytecode liveness at the head of the basic block.
The problem is, when removing availabilities, we set DeadFlush for them instead of ConflictingFlush. Basically, it means that we set
BOTTOM (an empty set) instead of TOP. Let's consider the following simple example. We have 6 basic blocks, and they are connected
as follows.
BB0 -> BB1 -> BB2 -> BB4
|\^
v > BB3 /
BB5
And consider about loc1 in FTL, which is required to be recovered in BB4's OSR exit.
BB0 does nothing
head: loc1 is dead
tail: loc1 is dead
BB1 has MovHint @1, loc1
head: loc1 is dead
tail: loc1 is live
BB2 does nothing
head: loc1 is live
tail: loc1 is live
BB3 has PutStack @1, loc1
head: loc1 is live
tail: loc1 is live
BB4 has OSR exit using loc1
head: loc1 is live
tail: loc1 is live (in bytecode)
BB5 does nothing
head: loc1 is dead
tail: loc1 is dead
In our OSR Availability analysis, we always prune loc1 result in BB1's head since its head says "loc1 is dead".
But at that time, we clear the availability for loc1, which makes it DeadFlush, instead of making it ConflictingFlush.
So, the flush format of loc1 in each tail of BB is like this.
BB0
ConflictingFlush (because all the local operands are initialized with ConflictingFlush)
BB1
DeadFlush+@1 (pruning clears it)
BB2
DeadFlush+@1 (since it is propagated from BB1)
BB3
FlushedJSValue+@1 with loc1 (since it has PutStack)
BB4
FlushedJSValue+@1 with loc1 (since MERGE(DeadFlush, FlushedJSValue) = FlushedJSValue)
BB5
DeadFlush (pruning clears it)
Then, if we go the path BB0->BB1->BB2->BB4, we read the value from the stack while it is not flushed.
The correct fix is making availability "unavailable" when pruning based on bytecode liveness.
* dfg/DFGAvailabilityMap.cpp:
(JSC::DFG::AvailabilityMap::pruneByLiveness): When pruning availability, we first set all the operands Availability::unavailable(),
and copy the calculated value from the current availability map.
* dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
(JSC::DFG::OSRAvailabilityAnalysisPhase::run): Add logging things for debugging.
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAvailabilityMap.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRAvailabilityAnalysisPhase.cpp
Added Paths
trunk/JSTests/stress/availability-was-cleared-when-locals-are-not-live.js
Diff
Modified: trunk/JSTests/ChangeLog (240363 => 240364)
--- trunk/JSTests/ChangeLog 2019-01-23 23:34:22 UTC (rev 240363)
+++ trunk/JSTests/ChangeLog 2019-01-24 00:17:15 UTC (rev 240364)
@@ -1,3 +1,17 @@
+2019-01-23 Yusuke Suzuki
+
+[DFG] AvailabilityMap::pruneByLiveness should make non-live operands Availability::unavailable instead of Availability()
+https://bugs.webkit.org/show_bug.cgi?id=193711
+
+
+Reviewed by Saam Barati.
+
+* stress/availability-was-cleared-when-locals-are-not-live.js: Added.
+(shouldBe):
+(foo):
+(bar):
+(baz):
+
2019-01-22 Yusuke Suzuki
Unreviewed, fix initial global lexical binding epoch
Added: trunk/JSTests/stress/availability-was-cleared-when-locals-are-not-live.js (0 => 240364)
--- trunk/JSTests/stress/availability-was-cleared-when-locals-are-not-live.js (rev 0)
+++ trunk/JSTests/stress/availability-was-cleared-when-locals-are-not-live.js 2019-01-24 00:17:15 UTC (rev 240364)
@@ -0,0 +1,37 @@
+//@ runDefault("--jitPolicyScale=0", "--useConcurrentJIT=false")
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error('bad
[webkit-changes] [240363] trunk
Title: [240363] trunk Revision 240363 Author cdu...@apple.com Date 2019-01-23 15:34:22 -0800 (Wed, 23 Jan 2019) Log Message Deprecate API to limit the maximum number of WebProcesses https://bugs.webkit.org/show_bug.cgi?id=193725 Reviewed by Geoff Garen. Source/WebKit: Deprecate API to limit the maximum number of WebProcesses and make it a no-op. It adds complexity and is not safe (conflicts with PSON). Add a new usesSingleWebProcess SPI to _WKProcessPoolConfiguration to be used by Minibrowser / Safari in order to disable process per tab (can be useful for debugging). Note that enabling the single WebProcess mode will disable PSON and process prewarming. * UIProcess/API/APIProcessPoolConfiguration.cpp: (API::ProcessPoolConfiguration::createWithLegacyOptions): (API::ProcessPoolConfiguration::copy): * UIProcess/API/APIProcessPoolConfiguration.h: * UIProcess/API/C/WKContext.cpp: (WKContextSetMaximumNumberOfProcesses): (WKContextGetMaximumNumberOfProcesses): * UIProcess/API/C/WKContext.h: * UIProcess/API/Cocoa/WKProcessPool.mm: * UIProcess/API/Cocoa/WKProcessPoolPrivate.h: * UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h: * UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm: (-[_WKProcessPoolConfiguration maximumProcessCount]): (-[_WKProcessPoolConfiguration setMaximumProcessCount:]): (-[_WKProcessPoolConfiguration usesSingleWebProcess]): (-[_WKProcessPoolConfiguration setUsesSingleWebProcess:]): (-[_WKProcessPoolConfiguration description]): * UIProcess/API/glib/WebKitWebContext.cpp: (webkitWebContextConstructed): (webkit_web_context_set_process_model): (webkit_web_context_set_web_process_count_limit): * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::createNewWebProcessRespectingProcessCountLimit): (WebKit::WebProcessPool::didReachGoodTimeToPrewarm): (WebKit::WebProcessPool::processForNavigationInternal): * UIProcess/WebProcessPool.h: Tools: Update existing API tests to stop using deprecated API. * MiniBrowser/mac/AppDelegate.m: (defaultConfiguration): * TestWebKitAPI/Tests/WebKit/UserMedia.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm: (TEST): * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: (TEST): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h trunk/Source/WebKit/UIProcess/API/C/WKContext.cpp trunk/Source/WebKit/UIProcess/API/C/WKContext.h trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h trunk/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h trunk/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm trunk/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp trunk/Source/WebKit/UIProcess/WebProcessPool.cpp trunk/Source/WebKit/UIProcess/WebProcessPool.h trunk/Tools/ChangeLog trunk/Tools/MiniBrowser/mac/AppDelegate.m trunk/Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm Diff Modified: trunk/Source/WebKit/ChangeLog (240362 => 240363) --- trunk/Source/WebKit/ChangeLog 2019-01-23 22:15:54 UTC (rev 240362) +++ trunk/Source/WebKit/ChangeLog 2019-01-23 23:34:22 UTC (rev 240363) @@ -1,3 +1,45 @@ +2019-01-23 Chris Dumez + +Deprecate API to limit the maximum number of WebProcesses +https://bugs.webkit.org/show_bug.cgi?id=193725 + + +Reviewed by Geoff Garen. + +Deprecate API to limit the maximum number of WebProcesses and make it a no-op. It adds +complexity and is not safe (conflicts with PSON). + +Add a new usesSingleWebProcess SPI to _WKProcessPoolConfiguration to be used by +Minibrowser / Safari in order to disable process per tab (can be useful for debugging). +Note that enabling the single WebProcess mode will disable PSON and process prewarming. + +* UIProcess/API/APIProcessPoolConfiguration.cpp: +(API::ProcessPoolConfiguration::createWithLegacyOptions): +(API::ProcessPoolConfiguration::copy): +* UIProcess/API/APIProcessPoolConfiguration.h: +* UIProcess/API/C/WKContext.cpp: +(WKContextSetMaximumNumberOfProcesses): +(WKContextGetMaximumNumberOfProcesses): +* UIProcess/API/C/WKContext.h: +* UIProcess/API/Cocoa/WKProcessPool.mm: +* UIProcess/API/Cocoa/WKProcessPoolPrivate.h: +* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h: +* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm: +(-[_WKProcessPoolConfiguration
[webkit-changes] [240362] trunk/LayoutTests
Title: [240362] trunk/LayoutTests Revision 240362 Author commit-qu...@webkit.org Date 2019-01-23 14:15:54 -0800 (Wed, 23 Jan 2019) Log Message Allow failures in flaky tests from bug 193657 https://bugs.webkit.org/show_bug.cgi?id=193736 Unreviewed test gardening. Patch by Oriol Brufau on 2019-01-23 * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (240361 => 240362) --- trunk/LayoutTests/ChangeLog 2019-01-23 21:58:47 UTC (rev 240361) +++ trunk/LayoutTests/ChangeLog 2019-01-23 22:15:54 UTC (rev 240362) @@ -1,3 +1,12 @@ +2019-01-23 Oriol Brufau + +Allow failures in flaky tests from bug 193657 +https://bugs.webkit.org/show_bug.cgi?id=193736 + +Unreviewed test gardening. + +* TestExpectations: + 2019-01-23 Eric Liang AX: [GTK] Layout test accessibility/set-selected-editable.html is failing Modified: trunk/LayoutTests/TestExpectations (240361 => 240362) --- trunk/LayoutTests/TestExpectations 2019-01-23 21:58:47 UTC (rev 240361) +++ trunk/LayoutTests/TestExpectations 2019-01-23 22:15:54 UTC (rev 240362) @@ -620,6 +620,9 @@ webkit.org/b/169271 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001.html [ ImageOnlyFailure ] webkit.org/b/191465 imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-changing-containing-block-001.html [ ImageOnlyFailure ] webkit.org/b/191465 imported/w3c/web-platform-tests/css/css-grid/abspos/grid-item-absolute-positioning-dynamic-001.html [ ImageOnlyFailure ] +imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-010.html [ Pass Failure ] +imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-013.html [ Pass Failure ] +imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-015.html [ Pass Failure ] webkit.org/b/191365 imported/w3c/web-platform-tests/css/css-grid/grid-items/item-with-table-with-infinite-max-intrinsic-width.html [ ImageOnlyFailure ] webkit.org/b/191365 imported/w3c/web-platform-tests/css/css-grid/grid-items/table-with-infinite-max-intrinsic-width.html [ ImageOnlyFailure ] webkit.org/b/191367 imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-ignores-first-letter-002.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240361] trunk/Tools
Title: [240361] trunk/Tools
Revision 240361
Author aakash_j...@apple.com
Date 2019-01-23 13:58:47 -0800 (Wed, 23 Jan 2019)
Log Message
[ews-app] Rename ews model buildermappings to buildermapping
https://bugs.webkit.org/show_bug.cgi?id=193729
Reviewed by Lucas Forschler.
* BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
(BuilderMapping): Renamed BuildMappings to BuilderMapping.
* BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
Modified Paths
trunk/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py
trunk/Tools/ChangeLog
Added Paths
trunk/Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py
Removed Paths
trunk/Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py (240360 => 240361)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py 2019-01-23 21:55:47 UTC (rev 240360)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py 2019-01-23 21:58:47 UTC (rev 240361)
@@ -1,4 +1,4 @@
-from buildermappings import *
+from buildermapping import *
from build import *
from patch import *
from step import *
Copied: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py (from rev 240359, trunk/Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py) (0 => 240361)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py (rev 0)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py 2019-01-23 21:58:47 UTC (rev 240361)
@@ -0,0 +1,33 @@
+# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+from __future__ import unicode_literals
+
+from django.db import models
+
+
+class BuilderMapping(models.Model):
+builderid = models.IntegerField(primary_key=True)
+name = models.TextField()
+
+def __str__(self):
+return "{}: {}".format(self.builderid, self.name)
Deleted: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py (240360 => 240361)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py 2019-01-23 21:55:47 UTC (rev 240360)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py 2019-01-23 21:58:47 UTC (rev 240361)
@@ -1,33 +0,0 @@
-# Copyright (C) 2018 Apple Inc. All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-# 1. Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer.
-# 2. Redistributions in binary form must reproduce the above copyright
-# notice, this list of conditions and the following disclaimer in the
-# documentation and/or other materials provided with the distribution.
-#
-# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
-# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
-# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
-# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
-# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
-# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
-# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
-# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
-# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-from __future__
[webkit-changes] [240359] trunk/Tools
Title: [240359] trunk/Tools Revision 240359 Author aakash_j...@apple.com Date 2019-01-23 13:52:34 -0800 (Wed, 23 Jan 2019) Log Message [ews-app] Rename ews model steps to step https://bugs.webkit.org/show_bug.cgi?id=193697 Reviewed by Lucas Forschler. * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py. (Step): Renamed Steps to Step. Modified Paths trunk/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py trunk/Tools/ChangeLog Added Paths trunk/Tools/BuildSlaveSupport/ews-app/ews/models/step.py Removed Paths trunk/Tools/BuildSlaveSupport/ews-app/ews/models/steps.py Diff Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py (240358 => 240359) --- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py 2019-01-23 21:39:19 UTC (rev 240358) +++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py 2019-01-23 21:52:34 UTC (rev 240359) @@ -1,4 +1,4 @@ from buildermappings import * from build import * from patch import * -from steps import * +from step import * Copied: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/step.py (from rev 240358, trunk/Tools/BuildSlaveSupport/ews-app/ews/models/steps.py) (0 => 240359) --- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/step.py (rev 0) +++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/step.py 2019-01-23 21:52:34 UTC (rev 240359) @@ -0,0 +1,40 @@ +# Copyright (C) 2018-2019 Apple Inc. All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# 1. Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# 2. Redistributions in binary form must reproduce the above copyright +# notice, this list of conditions and the following disclaimer in the +# documentation and/or other materials provided with the distribution. +# +# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND +# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED +# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE +# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR +# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL +# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR +# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER +# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, +# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +from __future__ import unicode_literals + +from django.db import models +from ews.models.build import Build + + +class Step(models.Model): +stepid = models.IntegerField(primary_key=True) +build = models.ForeignKey(Build, _on_delete_=models.CASCADE) +result = models.IntegerField() +state_string = models.TextField() +started_at = models.IntegerField() +complete_at = models.IntegerField() +created = models.DateTimeField(auto_now_add=True) +modified = models.DateTimeField(auto_now=True) + +def __str__(self): +return str(self.stepid) Deleted: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/steps.py (240358 => 240359) --- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/steps.py 2019-01-23 21:39:19 UTC (rev 240358) +++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/steps.py 2019-01-23 21:52:34 UTC (rev 240359) @@ -1,40 +0,0 @@ -# Copyright (C) 2018 Apple Inc. All rights reserved. -# -# Redistribution and use in source and binary forms, with or without -# modification, are permitted provided that the following conditions -# are met: -# 1. Redistributions of source code must retain the above copyright -# notice, this list of conditions and the following disclaimer. -# 2. Redistributions in binary form must reproduce the above copyright -# notice, this list of conditions and the following disclaimer in the -# documentation and/or other materials provided with the distribution. -# -# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND -# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED -# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE -# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR -# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL -# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR -# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER -# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, -# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE -# OF THIS SOFTWARE,
[webkit-changes] [240358] trunk
Title: [240358] trunk
Revision 240358
Author sihui_...@apple.com
Date 2019-01-23 13:39:19 -0800 (Wed, 23 Jan 2019)
Log Message
Clean up IndexedDB files between tests
https://bugs.webkit.org/show_bug.cgi?id=192796
Reviewed by Geoffrey Garen.
Source/WebCore:
We should clean up the IndexedDB files between tests to make sure each IDB test is independent of others.
* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::didDeleteBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::transactionCompleted):
Source/WebKit:
* UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreRemoveAllIndexedDatabases):
* UIProcess/API/C/WKWebsiteDataStoreRef.h:
Tools:
* DumpRenderTree/mac/DumpRenderTree.mm:
(runTest):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
(WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
(WTR::RemoveAllIndexedDatabasesCallback):
(WTR::TestController::ClearIndexedDatabases):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp
trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/TestController.h
trunk/Tools/WebKitTestRunner/TestInvocation.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (240357 => 240358)
--- trunk/Source/WebCore/ChangeLog 2019-01-23 21:37:30 UTC (rev 240357)
+++ trunk/Source/WebCore/ChangeLog 2019-01-23 21:39:19 UTC (rev 240358)
@@ -1,3 +1,17 @@
+2019-01-23 Sihui Liu
+
+Clean up IndexedDB files between tests
+https://bugs.webkit.org/show_bug.cgi?id=192796
+
+
+Reviewed by Geoffrey Garen.
+
+We should clean up the IndexedDB files between tests to make sure each IDB test is independent of others.
+
+* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+(WebCore::IDBServer::UniqueIDBDatabase::didDeleteBackingStore):
+(WebCore::IDBServer::UniqueIDBDatabase::transactionCompleted):
+
2019-01-23 Oriol Brufau
Add CSS Logical spec to features.json
Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (240357 => 240358)
--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2019-01-23 21:37:30 UTC (rev 240357)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2019-01-23 21:39:19 UTC (rev 240358)
@@ -337,6 +337,10 @@
}
m_deleteBackingStoreInProgress = false;
+
+if (m_hardClosedForUserDelete)
+return;
+
invokeOperationAndTransactionTimer();
}
@@ -634,6 +638,9 @@
ASSERT(m_isOpeningBackingStore);
m_isOpeningBackingStore = false;
+if (m_hardClosedForUserDelete)
+return;
+
handleDatabaseOperations();
}
@@ -1708,7 +1715,7 @@
for (auto objectStore : transaction->objectStoreIdentifiers()) {
if (!transaction->isReadOnly()) {
m_objectStoreWriteTransactions.remove(objectStore);
-ASSERT(m_objectStoreTransactionCounts.count(objectStore) == 1);
+ASSERT(m_objectStoreTransactionCounts.count(objectStore) == 1 || m_hardClosedForUserDelete);
}
m_objectStoreTransactionCounts.remove(objectStore);
}
Modified: trunk/Source/WebKit/ChangeLog (240357 => 240358)
--- trunk/Source/WebKit/ChangeLog 2019-01-23 21:37:30 UTC (rev 240357)
+++ trunk/Source/WebKit/ChangeLog 2019-01-23 21:39:19 UTC (rev 240358)
@@ -1,3 +1,15 @@
+2019-01-23 Sihui Liu
+
+Clean up IndexedDB files between tests
+https://bugs.webkit.org/show_bug.cgi?id=192796
+
+
+Reviewed by Geoffrey Garen.
+
+* UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
+(WKWebsiteDataStoreRemoveAllIndexedDatabases):
+* UIProcess/API/C/WKWebsiteDataStoreRef.h:
+
2019-01-23 Wenson Hsieh
[iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
Modified: trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp (240357 => 240358)
--- trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp 2019-01-23 21:37:30 UTC (rev 240357)
+++ trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp 2019-01-23 21:39:19 UTC (rev 240358)
@@ -448,10 +448,13 @@
});
}
-void WKWebsiteDataStoreRemoveAllIndexedDatabases(WKWebsiteDataStoreRef dataStoreRef)
+void WKWebsiteDataStoreRemoveAllIndexedDatabases(WKWebsiteDataStoreRef dataStoreRef, void* context, WKWebsiteDataStoreRemoveAllIndexedDatabasesCallback callback)
{
OptionSet dataTypes = WebKit::WebsiteDataType::IndexedDBDatabases;
-
[webkit-changes] [240357] trunk/Tools
Title: [240357] trunk/Tools Revision 240357 Author aakash_j...@apple.com Date 2019-01-23 13:37:30 -0800 (Wed, 23 Jan 2019) Log Message [ews-app] Rename ews model Builds to Build https://bugs.webkit.org/show_bug.cgi?id=193695 Reviewed by Lucas Forschler. * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py. (Build): Renamed Builds to Build. Modified Paths trunk/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py trunk/Tools/BuildSlaveSupport/ews-app/ews/models/steps.py trunk/Tools/ChangeLog Added Paths trunk/Tools/BuildSlaveSupport/ews-app/ews/models/build.py Removed Paths trunk/Tools/BuildSlaveSupport/ews-app/ews/models/builds.py Diff Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py (240356 => 240357) --- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py 2019-01-23 21:28:35 UTC (rev 240356) +++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py 2019-01-23 21:37:30 UTC (rev 240357) @@ -1,4 +1,4 @@ from buildermappings import * -from builds import * +from build import * from patch import * from steps import * Copied: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/build.py (from rev 240356, trunk/Tools/BuildSlaveSupport/ews-app/ews/models/builds.py) (0 => 240357) --- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/build.py (rev 0) +++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/build.py 2019-01-23 21:37:30 UTC (rev 240357) @@ -0,0 +1,42 @@ +# Copyright (C) 2018 Apple Inc. All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# 1. Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# 2. Redistributions in binary form must reproduce the above copyright +# notice, this list of conditions and the following disclaimer in the +# documentation and/or other materials provided with the distribution. +# +# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND +# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED +# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE +# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR +# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL +# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR +# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER +# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, +# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +from __future__ import unicode_literals + +from django.db import models +from ews.models.patch import Patch + + +class Build(models.Model): +patch = models.ForeignKey(Patch, _on_delete_=models.CASCADE) +buildid = models.IntegerField(primary_key=True) +builderid = models.IntegerField() +number = models.IntegerField() +result = models.IntegerField() +state_string = models.TextField() +started_at = models.IntegerField() +complete_at = models.IntegerField() +created = models.DateTimeField(auto_now_add=True) +modified = models.DateTimeField(auto_now=True) + +def __str__(self): +return str(self.buildid) Deleted: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/builds.py (240356 => 240357) --- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/builds.py 2019-01-23 21:28:35 UTC (rev 240356) +++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/builds.py 2019-01-23 21:37:30 UTC (rev 240357) @@ -1,42 +0,0 @@ -# Copyright (C) 2018 Apple Inc. All rights reserved. -# -# Redistribution and use in source and binary forms, with or without -# modification, are permitted provided that the following conditions -# are met: -# 1. Redistributions of source code must retain the above copyright -# notice, this list of conditions and the following disclaimer. -# 2. Redistributions in binary form must reproduce the above copyright -# notice, this list of conditions and the following disclaimer in the -# documentation and/or other materials provided with the distribution. -# -# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND -# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED -# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE -# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR -# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL -# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR -# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER -# CAUSED AND ON ANY THEORY OF
[webkit-changes] [240356] trunk/Tools
Title: [240356] trunk/Tools
Revision 240356
Author jbed...@apple.com
Date 2019-01-23 13:28:35 -0800 (Wed, 23 Jan 2019)
Log Message
webkitpy: Wait longer when launching WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=193734
Reviewed by Aakash Jain.
* Scripts/webkitpy/port/simulator_process.py:
(SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/simulator_process.py
Diff
Modified: trunk/Tools/ChangeLog (240355 => 240356)
--- trunk/Tools/ChangeLog 2019-01-23 21:03:32 UTC (rev 240355)
+++ trunk/Tools/ChangeLog 2019-01-23 21:28:35 UTC (rev 240356)
@@ -1,3 +1,13 @@
+2019-01-23 Jonathan Bedard
+
+webkitpy: Wait longer when launching WebKitTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=193734
+
+Reviewed by Aakash Jain.
+
+* Scripts/webkitpy/port/simulator_process.py:
+(SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
+
2019-01-23 Wenson Hsieh
[iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
Modified: trunk/Tools/Scripts/webkitpy/port/simulator_process.py (240355 => 240356)
--- trunk/Tools/Scripts/webkitpy/port/simulator_process.py 2019-01-23 21:03:32 UTC (rev 240355)
+++ trunk/Tools/Scripts/webkitpy/port/simulator_process.py 2019-01-23 21:28:35 UTC (rev 240356)
@@ -1,4 +1,4 @@
-# Copyright (C) 2017 Apple Inc. All rights reserved.
+# Copyright (C) 2017-2019 Apple Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
@@ -95,7 +95,7 @@
self._target_host.listening_socket.listen(3)
self._pid = self._target_host.launch_app(self._bundle_id, self._cmd[1:], env=self._env)
-with Timeout(6, RuntimeError('Timed out waiting for pid {} to connect at port {}'.format(self._pid, self._target_host.listening_port(:
+with Timeout(15, RuntimeError('Timed out waiting for pid {} to connect at port {}'.format(self._pid, self._target_host.listening_port(:
stdin = None
stdout = None
stderr = None
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240355] trunk/Source
Title: [240355] trunk/Source
Revision 240355
Author conrad_shu...@apple.com
Date 2019-01-23 13:03:32 -0800 (Wed, 23 Jan 2019)
Log Message
Unreviewed; Revert "Clean up USE(WEB_THREAD)"
This reverts commit 24ba8bb9e1dad8679b492d9a2d47da619be85789.
https://bugs.webkit.org/show_bug.cgi?id=193698
Modified Paths
trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp
trunk/Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp
trunk/Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm
trunk/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm
trunk/Source/WebCore/platform/ios/LegacyTileCache.mm
trunk/Source/WebCore/platform/ios/WebCoreMotionManager.mm
trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
trunk/Source/WebCore/platform/ios/wak/WAKWindow.mm
trunk/Source/WebCore/platform/network/ios/NetworkStateNotifierIOS.mm
trunk/Source/WebCore/rendering/RenderThemeIOS.mm
trunk/Source/WebKitLegacy/ios/Misc/WebGeolocationProviderIOS.mm
trunk/Source/WebKitLegacy/ios/WebCoreSupport/WebFixedPositionContent.mm
trunk/Source/WebKitLegacy/mac/Misc/WebCache.mm
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebGeolocationClient.mm
trunk/Source/WebKitLegacy/mac/WebView/WebFrame.mm
trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
Diff
Modified: trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp (240354 => 240355)
--- trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp 2019-01-23 20:54:30 UTC (rev 240354)
+++ trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp 2019-01-23 21:03:32 UTC (rev 240355)
@@ -97,7 +97,7 @@
#if HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK)
static void userCaptionPreferencesChangedNotificationCallback(CFNotificationCenterRef, void* observer, CFStringRef, const void *, CFDictionaryRef)
{
-#if !USE(WEB_THREAD)
+#if !PLATFORM(IOS_FAMILY)
static_cast(observer)->captionPreferencesChanged();
#else
WebThreadRun(^{
Modified: trunk/Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp (240354 => 240355)
--- trunk/Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp 2019-01-23 20:54:30 UTC (rev 240354)
+++ trunk/Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp 2019-01-23 21:03:32 UTC (rev 240355)
@@ -46,13 +46,9 @@
#if PLATFORM(IOS_FAMILY)
static void applicationDidBecomeActive(CFNotificationCenterRef, void*, CFStringRef, const void*, CFDictionaryRef)
{
-#if USE(WEB_THREAD)
WebThreadRun(^{
restartSharedTimer();
});
-#else
-restartSharedTimer();
-#endif
}
#endif
Modified: trunk/Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm (240354 => 240355)
--- trunk/Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm 2019-01-23 20:54:30 UTC (rev 240354)
+++ trunk/Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm 2019-01-23 21:03:32 UTC (rev 240355)
@@ -144,7 +144,7 @@
static inline void dispatchToMainThread(void (^block)())
{
dispatch_async(dispatch_get_main_queue(), ^{
-#if USE(WEB_THREAD)
+#if PLATFORM(IOS_FAMILY)
WebThreadRun(block);
#else
block();
Modified: trunk/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm (240354 => 240355)
--- trunk/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm 2019-01-23 20:54:30 UTC (rev 240354)
+++ trunk/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm 2019-01-23 21:03:32 UTC (rev 240355)
@@ -85,7 +85,7 @@
{
UNUSED_PARAM(change);
UNUSED_PARAM(context);
-#if USE(WEB_THREAD)
+#if PLATFORM(IOS_FAMILY)
WebThreadRun(^{
if (_parent && [keyPath isEqual:@"bounds"] && object == _parent->platformLayer())
_parent->client().textTrackRepresentationBoundsChanged(_parent->bounds());
Modified: trunk/Source/WebCore/platform/ios/LegacyTileCache.mm (240354 => 240355)
--- trunk/Source/WebCore/platform/ios/LegacyTileCache.mm 2019-01-23 20:54:30 UTC (rev 240354)
+++ trunk/Source/WebCore/platform/ios/LegacyTileCache.mm 2019-01-23 21:03:32 UTC (rev 240355)
@@ -277,16 +277,12 @@
m_hasPendingLayoutTiles = true;
LegacyTileCacheTombstone *tombstone = m_tombstone.get();
-#if USE(WEB_THREAD)
WebThreadRun(^{
-#endif
if ([tombstone isDead])
return;
m_hasPendingLayoutTiles = false;
doLayoutTiles();
-#if USE(WEB_THREAD)
});
-#endif
}
void LegacyTileCache::layoutTilesNow()
@@ -720,16 +716,12 @@
m_hasPendingUpdateTilingMode = true;
LegacyTileCacheTombstone *tombstone = m_tombstone.get();
-#if USE(WEB_THREAD)
WebThreadRun(^{
-#endif
if ([tombstone isDead])
return;
m_hasPendingUpdateTilingMode = false;
updateTilingMode();
-#if USE(WEB_THREAD)
});
-#endif
}
void LegacyTileCache::setTilingDirection(TilingDirection tilingDirection)
Modified:
[webkit-changes] [240354] trunk/Source/WebCore
Title: [240354] trunk/Source/WebCore
Revision 240354
Author commit-qu...@webkit.org
Date 2019-01-23 12:54:30 -0800 (Wed, 23 Jan 2019)
Log Message
Add CSS Logical spec to features.json
https://bugs.webkit.org/show_bug.cgi?id=193717
Patch by Oriol Brufau on 2019-01-23
Reviewed by Manuel Rego Casasnovas.
* features.json:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/features.json
Diff
Modified: trunk/Source/WebCore/ChangeLog (240353 => 240354)
--- trunk/Source/WebCore/ChangeLog 2019-01-23 20:36:37 UTC (rev 240353)
+++ trunk/Source/WebCore/ChangeLog 2019-01-23 20:54:30 UTC (rev 240354)
@@ -1,3 +1,12 @@
+2019-01-23 Oriol Brufau
+
+Add CSS Logical spec to features.json
+https://bugs.webkit.org/show_bug.cgi?id=193717
+
+Reviewed by Manuel Rego Casasnovas.
+
+* features.json:
+
2019-01-22 Conrad Shultz
Clean up USE(WEB_THREAD)
Modified: trunk/Source/WebCore/features.json (240353 => 240354)
--- trunk/Source/WebCore/features.json 2019-01-23 20:36:37 UTC (rev 240353)
+++ trunk/Source/WebCore/features.json 2019-01-23 20:54:30 UTC (rev 240354)
@@ -126,6 +126,19 @@
"category": "css"
},
{
+"name": "CSS Logical Properties and Values Level 1",
+"status": {
+"status": "In Development"
+},
+"url": "https://drafts.csswg.org/css-logical/",
+"keywords": ["css", "css-logical", "flow-relative", "logical"],
+"category": "css",
+"contact": {
+"name": "Oriol Brufau",
+"email": "obru...@igalia.com"
+}
+},
+{
"name": "CSS Media Queries Level 4",
"url": "http://dev.w3.org/csswg/mediaqueries-4/",
"keywords": ["css media queries", "media queries"],
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240353] trunk/Source
Title: [240353] trunk/Source Revision 240353 Author conrad_shu...@apple.com Date 2019-01-23 12:36:37 -0800 (Wed, 23 Jan 2019) Log Message Clean up USE(WEB_THREAD) https://bugs.webkit.org/show_bug.cgi?id=193698 Rubber-stamped by Tim Horton. WebCore: * page/CaptionUserPreferencesMediaAF.cpp: (WebCore::userCaptionPreferencesChangedNotificationCallback): * platform/cf/MainThreadSharedTimerCF.cpp: (WebCore::applicationDidBecomeActive): * platform/cocoa/ContentFilterUnblockHandlerCocoa.mm: (WebCore::dispatchToMainThread): * platform/graphics/cocoa/TextTrackRepresentationCocoa.mm: (-[WebCoreTextTrackRepresentationCocoaHelper observeValueForKeyPath:ofObject:change:context:]): * platform/ios/LegacyTileCache.mm: (WebCore::LegacyTileCache::layoutTiles): (WebCore::LegacyTileCache::setTilingMode): * platform/ios/WebCoreMotionManager.mm: (-[WebCoreMotionManager sendAccelerometerData:]): (-[WebCoreMotionManager sendMotionData:withHeading:]): * platform/ios/WebVideoFullscreenControllerAVKit.mm: (VideoFullscreenControllerContext::requestUpdateInlineRect): (VideoFullscreenControllerContext::requestVideoContentLayer): (VideoFullscreenControllerContext::returnVideoContentLayer): (VideoFullscreenControllerContext::didSetupFullscreen): (VideoFullscreenControllerContext::willExitFullscreen): (VideoFullscreenControllerContext::didExitFullscreen): (VideoFullscreenControllerContext::didCleanupFullscreen): (VideoFullscreenControllerContext::fullscreenMayReturnToInline): (VideoFullscreenControllerContext::requestFullscreenMode): (VideoFullscreenControllerContext::setVideoLayerFrame): (VideoFullscreenControllerContext::setVideoLayerGravity): (VideoFullscreenControllerContext::fullscreenModeChanged): (VideoFullscreenControllerContext::play): (VideoFullscreenControllerContext::pause): (VideoFullscreenControllerContext::togglePlayState): (VideoFullscreenControllerContext::toggleMuted): (VideoFullscreenControllerContext::setMuted): (VideoFullscreenControllerContext::setVolume): (VideoFullscreenControllerContext::setPlayingOnSecondScreen): (VideoFullscreenControllerContext::beginScrubbing): (VideoFullscreenControllerContext::endScrubbing): (VideoFullscreenControllerContext::seekToTime): (VideoFullscreenControllerContext::fastSeek): (VideoFullscreenControllerContext::beginScanningForward): (VideoFullscreenControllerContext::beginScanningBackward): (VideoFullscreenControllerContext::endScanning): (VideoFullscreenControllerContext::selectAudioMediaOption): (VideoFullscreenControllerContext::selectLegibleMediaOption): (VideoFullscreenControllerContext::duration const): (VideoFullscreenControllerContext::currentTime const): (VideoFullscreenControllerContext::bufferedTime const): (VideoFullscreenControllerContext::isPlaying const): (VideoFullscreenControllerContext::playbackRate const): (VideoFullscreenControllerContext::seekableRanges const): (VideoFullscreenControllerContext::seekableTimeRangesLastModifiedTime const): (VideoFullscreenControllerContext::liveUpdateInterval const): (VideoFullscreenControllerContext::canPlayFastReverse const): (VideoFullscreenControllerContext::audioMediaSelectionOptions const): (VideoFullscreenControllerContext::audioMediaSelectedIndex const): (VideoFullscreenControllerContext::legibleMediaSelectionOptions const): (VideoFullscreenControllerContext::legibleMediaSelectedIndex const): (VideoFullscreenControllerContext::externalPlaybackEnabled const): (VideoFullscreenControllerContext::externalPlaybackTargetType const): (VideoFullscreenControllerContext::externalPlaybackLocalizedDeviceName const): (VideoFullscreenControllerContext::wirelessVideoPlaybackDisabled const): (VideoFullscreenControllerContext::setUpFullscreen): (VideoFullscreenControllerContext::exitFullscreen): (VideoFullscreenControllerContext::requestHideAndExitFullscreen): (-[WebVideoFullscreenController enterFullscreen:mode:]): (-[WebVideoFullscreenController exitFullscreen]): (-[WebVideoFullscreenController requestHideAndExitFullscreen]): * platform/ios/wak/WAKWindow.mm: (-[WAKWindow setVisible:]): (-[WAKWindow setScreenScale:]): (-[WAKWindow sendEvent:]): (-[WAKWindow sendMouseMoveEvent:contentChange:]): * platform/network/ios/NetworkStateNotifierIOS.mm: (WebCore::NetworkStateNotifier::startObserving): * rendering/RenderThemeIOS.mm: (WebCore::contentSizeCategoryDidChange): WebKitLegacy: * Misc/WebGeolocationProviderIOS.mm: (-[_WebCoreLocationUpdateThreadingProxy geolocationAuthorizationGranted]): (-[_WebCoreLocationUpdateThreadingProxy geolocationAuthorizationDenied]): (-[_WebCoreLocationUpdateThreadingProxy positionChanged:]): (-[_WebCoreLocationUpdateThreadingProxy errorOccurred:]):
[webkit-changes] [240352] trunk
Title: [240352] trunk
Revision 240352
Author wenson_hs...@apple.com
Date 2019-01-23 12:09:54 -0800 (Wed, 23 Jan 2019)
Log Message
[iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
https://bugs.webkit.org/show_bug.cgi?id=193182
Reviewed by Tim Horton.
Source/WebKit:
Fix an existing bug where blurring an element doesn't always un-suppress text interactions.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _elementDidBlur]):
Tools:
This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
preventing later tests from recognizing gestures.
* WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformResetStateToConsistentValues):
Cancel all touches in the UIApplication when resetting to a consistent state between tests.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (240351 => 240352)
--- trunk/Source/WebKit/ChangeLog 2019-01-23 19:29:18 UTC (rev 240351)
+++ trunk/Source/WebKit/ChangeLog 2019-01-23 20:09:54 UTC (rev 240352)
@@ -1,3 +1,16 @@
+2019-01-23 Wenson Hsieh
+
+[iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
+https://bugs.webkit.org/show_bug.cgi?id=193182
+
+
+Reviewed by Tim Horton.
+
+Fix an existing bug where blurring an element doesn't always un-suppress text interactions.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _elementDidBlur]):
+
2019-01-23 Michael Catanzaro
Minor improvements to NetworkProcess
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (240351 => 240352)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-01-23 19:29:18 UTC (rev 240351)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-01-23 20:09:54 UTC (rev 240352)
@@ -4660,6 +4660,7 @@
if (!_isChangingFocus) {
[self _stopSuppressingSelectionAssistantForReason:WebKit::FocusedElementIsTransparentOrFullyClipped];
+[self _stopSuppressingSelectionAssistantForReason:WebKit::FocusedElementIsTooSmall];
_didAccessoryTabInitiateFocus = NO;
}
}
Modified: trunk/Tools/ChangeLog (240351 => 240352)
--- trunk/Tools/ChangeLog 2019-01-23 19:29:18 UTC (rev 240351)
+++ trunk/Tools/ChangeLog 2019-01-23 20:09:54 UTC (rev 240352)
@@ -1,3 +1,23 @@
+2019-01-23 Wenson Hsieh
+
+[iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
+https://bugs.webkit.org/show_bug.cgi?id=193182
+
+
+Reviewed by Tim Horton.
+
+This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
+long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
+recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
+
+To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
+preventing later tests from recognizing gestures.
+
+* WebKitTestRunner/ios/TestControllerIOS.mm:
+(WTR::TestController::platformResetStateToConsistentValues):
+
+Cancel all touches in the UIApplication when resetting to a consistent state between tests.
+
2019-01-23 Jonathan Bedard
webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
Modified: trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm (240351 => 240352)
--- trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm 2019-01-23 19:29:18 UTC (rev 240351)
+++ trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm 2019-01-23 20:09:54 UTC (rev 240352)
@@ -115,6 +115,7 @@
{
cocoaResetStateToConsistentValues(options);
+[[UIApplication sharedApplication] _cancelAllTouches];
[[UIDevice currentDevice] setOrientation:UIDeviceOrientationPortrait animated:NO];
m_inputModeSwizzlers.clear();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240351] trunk/Source/WebInspectorUI
Title: [240351] trunk/Source/WebInspectorUI
Revision 240351
Author drou...@apple.com
Date 2019-01-23 11:29:18 -0800 (Wed, 23 Jan 2019)
Log Message
WebInspector: Confusingly nested events in the timeline for Mutation Observers
https://bugs.webkit.org/show_bug.cgi?id=192884
Reviewed by Joseph Pecoraro.
If a microtask event (e.g. `ObserverCallback`) is contained within a `EvaluatedScript`
event, move that microtask event to be a sibling of the `EvaluateScript`, subtracting the
microtask's time taken from the `EvaluateScript`'s time. If there are no other children
after this move, then remove the `EvaluateScript` altogether.
* UserInterface/Controllers/TimelineManager.js:
(WI.TimelineManager.prototype.eventRecorded.fixMicrotaskPlacement): Added.
(WI.TimelineManager.prototype.eventRecorded):
(WI.TimelineManager.prototype._mergeScriptProfileRecords):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240350 => 240351)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-01-23 19:18:59 UTC (rev 240350)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-01-23 19:29:18 UTC (rev 240351)
@@ -1,3 +1,21 @@
+2019-01-23 Devin Rousso
+
+WebInspector: Confusingly nested events in the timeline for Mutation Observers
+https://bugs.webkit.org/show_bug.cgi?id=192884
+
+
+Reviewed by Joseph Pecoraro.
+
+If a microtask event (e.g. `ObserverCallback`) is contained within a `EvaluatedScript`
+event, move that microtask event to be a sibling of the `EvaluateScript`, subtracting the
+microtask's time taken from the `EvaluateScript`'s time. If there are no other children
+after this move, then remove the `EvaluateScript` altogether.
+
+* UserInterface/Controllers/TimelineManager.js:
+(WI.TimelineManager.prototype.eventRecorded.fixMicrotaskPlacement): Added.
+(WI.TimelineManager.prototype.eventRecorded):
+(WI.TimelineManager.prototype._mergeScriptProfileRecords):
+
2019-01-23 Joseph Pecoraro
Web Inspector: Network Waterfall column should redraw when adding/removing new columns
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js (240350 => 240351)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2019-01-23 19:18:59 UTC (rev 240350)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2019-01-23 19:29:18 UTC (rev 240351)
@@ -356,6 +356,28 @@
if (!this._isCapturing)
return;
+function fixMicrotaskPlacement(children)
+{
+let newChildren = [];
+for (let child of children) {
+if (child.type === TimelineAgent.EventType.EvaluateScript) {
+let [microtasks, events] = child.children.partition((grandchild) => {
+return grandchild.type === TimelineAgent.EventType.ObserverCallback;
+});
+
+if (events.length) {
+child.children = events;
+child.endTime = events.lastValue.endTime;
+newChildren.push(child);
+}
+
+newChildren = newChildren.concat(microtasks);
+} else
+newChildren.push(child);
+}
+return newChildren;
+}
+
var records = [];
// Iterate over the records tree using a stack. Doing this recursively has
@@ -376,7 +398,7 @@
}
if (recordPayload.children && recordPayload.children.length)
-stack.push({array: recordPayload.children, parent: recordPayload, parentRecord: record || entry.parentRecord, index: 0});
+stack.push({array: fixMicrotaskPlacement(recordPayload.children), parent: recordPayload, parentRecord: record || entry.parentRecord, index: 0});
++entry.index;
} else
stack.pop();
@@ -1055,15 +1077,23 @@
webRecord.profilePayload = profilerRecord.profilePayload;
profilerRecord = nextScriptProfilerRecord();
+let firstProfilerRecordForWebRecord = null;
+
// If there are more script profile records in the same time interval, add them
// as individual script evaluated records with profiles. This can happen with
// web microtask checkpoints that are technically inside of other web records.
// FIXME: Web Inspector: Timeline Cleanup: Better Timeline Record for Microtask Checkpoints
while (profilerRecord && recordEnclosesRecord(webRecord, profilerRecord)) {
+if (!firstProfilerRecordForWebRecord)
+firstProfilerRecordForWebRecord = profilerRecord;
+
[webkit-changes] [240350] trunk/Source/WebKit
Title: [240350] trunk/Source/WebKit
Revision 240350
Author mcatanz...@igalia.com
Date 2019-01-23 11:18:59 -0800 (Wed, 23 Jan 2019)
Log Message
Minor improvements to NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=193708
Reviewed by Alex Christensen.
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::switchToNewTestingSession): Fix a spelling error.
(WebKit::NetworkProcess::ensureSession): Add useful assertion.
(WebKit::NetworkProcess::defaultStorageSession const): Split into platform functions.
(WebKit::NetworkProcess::destroySession): Add useful assertion.
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformCreateDefaultStorageSession const):
* NetworkProcess/curl/NetworkProcessCurl.cpp:
(WebKit::NetworkProcess::platformCreateDefaultStorageSession const):
* NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::platformCreateDefaultStorageSession const):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp
trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (240349 => 240350)
--- trunk/Source/WebKit/ChangeLog 2019-01-23 19:14:55 UTC (rev 240349)
+++ trunk/Source/WebKit/ChangeLog 2019-01-23 19:18:59 UTC (rev 240350)
@@ -1,3 +1,23 @@
+2019-01-23 Michael Catanzaro
+
+Minor improvements to NetworkProcess
+https://bugs.webkit.org/show_bug.cgi?id=193708
+
+Reviewed by Alex Christensen.
+
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::switchToNewTestingSession): Fix a spelling error.
+(WebKit::NetworkProcess::ensureSession): Add useful assertion.
+(WebKit::NetworkProcess::defaultStorageSession const): Split into platform functions.
+(WebKit::NetworkProcess::destroySession): Add useful assertion.
+* NetworkProcess/NetworkProcess.h:
+* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+(WebKit::NetworkProcess::platformCreateDefaultStorageSession const):
+* NetworkProcess/curl/NetworkProcessCurl.cpp:
+(WebKit::NetworkProcess::platformCreateDefaultStorageSession const):
+* NetworkProcess/soup/NetworkProcessSoup.cpp:
+(WebKit::NetworkProcess::platformCreateDefaultStorageSession const):
+
2019-01-23 Daniel Bates
Fix the Apple Internal build. See .
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (240349 => 240350)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2019-01-23 19:14:55 UTC (rev 240349)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2019-01-23 19:18:59 UTC (rev 240350)
@@ -475,7 +475,7 @@
void NetworkProcess::switchToNewTestingSession()
{
#if PLATFORM(COCOA)
-// Session name should be short enough for shared memory region name to be under the limit, otehrwise sandbox rules won't work (see ).
+// Session name should be short enough for shared memory region name to be under the limit, otherwise sandbox rules won't work (see ).
String sessionName = String::format("WebKit Test-%u", static_cast(getCurrentProcessID()));
auto session = adoptCF(WebCore::createPrivateStorageSession(sessionName.createCFString().get()));
@@ -499,6 +499,8 @@
void NetworkProcess::ensureSession(const PAL::SessionID& sessionID, const String& identifierBase)
#endif
{
+ASSERT(sessionID != PAL::SessionID::defaultSessionID());
+
auto addResult = m_networkStorageSessions.add(sessionID, nullptr);
if (!addResult.isNewEntry)
return;
@@ -532,19 +534,8 @@
WebCore::NetworkStorageSession& NetworkProcess::defaultStorageSession() const
{
-if (m_defaultNetworkStorageSession)
- return *m_defaultNetworkStorageSession;
-
-#if PLATFORM(COCOA)
-m_defaultNetworkStorageSession = std::make_unique(PAL::SessionID::defaultSessionID());
-#elif USE(SOUP)
-m_defaultNetworkStorageSession = std::make_unique(PAL::SessionID::defaultSessionID(), std::make_unique(PAL::SessionID::defaultSessionID()));
-#elif USE(CURL)
-m_defaultNetworkStorageSession = std::make_unique(PAL::SessionID::defaultSessionID(), CurlContext::singleton());
-#else
-#error Implement me
-#endif
-
+if (!m_defaultNetworkStorageSession)
+m_defaultNetworkStorageSession = platformCreateDefaultStorageSession();
return *m_defaultNetworkStorageSession;
}
@@ -567,6 +558,8 @@
void NetworkProcess::destroySession(const PAL::SessionID& sessionID)
{
+ASSERT(sessionID != PAL::SessionID::defaultSessionID());
+
if (auto session = m_networkSessions.take(sessionID))
session->get().invalidateAndCancel();
m_networkStorageSessions.remove(sessionID);
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.h (240349 => 240350)
[webkit-changes] [240349] trunk/Source/WebKit
Title: [240349] trunk/Source/WebKit Revision 240349 Author dba...@webkit.org Date 2019-01-23 11:14:55 -0800 (Wed, 23 Jan 2019) Log Message Fix the Apple Internal build. See . * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView dropInteraction:previewForDroppingItem:withDefault:]): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Diff Modified: trunk/Source/WebKit/ChangeLog (240348 => 240349) --- trunk/Source/WebKit/ChangeLog 2019-01-23 19:13:44 UTC (rev 240348) +++ trunk/Source/WebKit/ChangeLog 2019-01-23 19:14:55 UTC (rev 240349) @@ -1,3 +1,10 @@ +2019-01-23 Daniel Bates + +Fix the Apple Internal build. See . + +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKContentView dropInteraction:previewForDroppingItem:withDefault:]): + 2019-01-23 Per Arne Vollan [macOS] Sandbox fails to compile Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (240348 => 240349) --- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-01-23 19:13:44 UTC (rev 240348) +++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-01-23 19:14:55 UTC (rev 240349) @@ -6108,6 +6108,7 @@ if (CGRectIsEmpty(caretRect)) return nil; +ALLOW_DEPRECATED_DECLARATIONS_BEGIN // FIXME: [WK2] Performing an edit drag should transition from the initial drag preview to the final drop preview // This is blocked on UIKit support, since we aren't able to update the text clipping rects of a UITargetedDragPreview mid-flight. For now, // just zoom to the center of the caret rect while shrinking the drop preview. @@ -6114,6 +6115,7 @@ auto caretRectInWindowCoordinates = [self convertRect:caretRect toView:[UITextEffectsWindow sharedTextEffectsWindow]]; auto caretCenterInWindowCoordinates = CGPointMake(CGRectGetMidX(caretRectInWindowCoordinates), CGRectGetMidY(caretRectInWindowCoordinates)); auto target = adoptNS([[UIDragPreviewTarget alloc] initWithContainer:[UITextEffectsWindow sharedTextEffectsWindow] center:caretCenterInWindowCoordinates transform:CGAffineTransformMakeScale(0, 0)]); +ALLOW_DEPRECATED_DECLARATIONS_END return [defaultPreview retargetedPreviewWithTarget:target.get()]; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240348] trunk/Source/WebKit
Title: [240348] trunk/Source/WebKit Revision 240348 Author pvol...@apple.com Date 2019-01-23 11:13:44 -0800 (Wed, 23 Jan 2019) Log Message [macOS] Sandbox fails to compile https://bugs.webkit.org/show_bug.cgi?id=193727 Reviewed by Brent Fulgham. Use '(with send-signal SIGKILL)' instead of '(with termination)'. * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (240347 => 240348) --- trunk/Source/WebKit/ChangeLog 2019-01-23 18:46:56 UTC (rev 240347) +++ trunk/Source/WebKit/ChangeLog 2019-01-23 19:13:44 UTC (rev 240348) @@ -1,3 +1,15 @@ +2019-01-23 Per Arne Vollan + +[macOS] Sandbox fails to compile +https://bugs.webkit.org/show_bug.cgi?id=193727 + + +Reviewed by Brent Fulgham. + +Use '(with send-signal SIGKILL)' instead of '(with termination)'. + +* WebProcess/com.apple.WebProcess.sb.in: + 2019-01-23 Brent Fulgham REGRESSION (r240243): CrashTracer: WebKitTestRunnerApp at com.apple.WebKit: WebKit::WebResourceLoadStatisticsStore::sendDiagnosticMessageWithValue const + 32 Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (240347 => 240348) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2019-01-23 18:46:56 UTC (rev 240347) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2019-01-23 19:13:44 UTC (rev 240348) @@ -825,7 +825,7 @@ #endif // PLATFORM(MAC) (when (defined? 'syscall-unix) -(deny syscall-unix (with termination)) +(deny syscall-unix (with send-signal SIGKILL)) (allow syscall-unix (syscall-number SYS_exit) (syscall-number SYS_read) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240347] trunk/Source/WebInspectorUI
Title: [240347] trunk/Source/WebInspectorUI
Revision 240347
Author commit-qu...@webkit.org
Date 2019-01-23 10:46:56 -0800 (Wed, 23 Jan 2019)
Log Message
Web Inspector: Network Waterfall column should redraw when adding/removing new columns
https://bugs.webkit.org/show_bug.cgi?id=193696
Patch by Joseph Pecoraro on 2019-01-23
Reviewed by Devin Rousso.
* UserInterface/Views/TableColumn.js:
(WI.TableColumn.prototype.get needsReloadOnResize):
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype.initialLayout):
Mark the waterfall column as sensitive to any resizes.
* UserInterface/Views/Table.js:
(WI.Table.prototype.showColumn):
(WI.Table.prototype.hideColumn):
Update column widths and reload any columns that may be sensitive to resizes.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/Table.js
trunk/Source/WebInspectorUI/UserInterface/Views/TableColumn.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240346 => 240347)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-01-23 18:44:34 UTC (rev 240346)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-01-23 18:46:56 UTC (rev 240347)
@@ -1,3 +1,22 @@
+2019-01-23 Joseph Pecoraro
+
+Web Inspector: Network Waterfall column should redraw when adding/removing new columns
+https://bugs.webkit.org/show_bug.cgi?id=193696
+
+
+Reviewed by Devin Rousso.
+
+* UserInterface/Views/TableColumn.js:
+(WI.TableColumn.prototype.get needsReloadOnResize):
+* UserInterface/Views/NetworkTableContentView.js:
+(WI.NetworkTableContentView.prototype.initialLayout):
+Mark the waterfall column as sensitive to any resizes.
+
+* UserInterface/Views/Table.js:
+(WI.Table.prototype.showColumn):
+(WI.Table.prototype.hideColumn):
+Update column widths and reload any columns that may be sensitive to resizes.
+
2019-01-22 Devin Rousso
Web Inspector: InspectorInstrumentation::willEvaluateScript should include column number
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (240346 => 240347)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2019-01-23 18:44:34 UTC (rev 240346)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2019-01-23 18:46:56 UTC (rev 240347)
@@ -1070,6 +1070,7 @@
this._waterfallColumn = new WI.TableColumn("waterfall", WI.UIString("Waterfall"), {
minWidth: 230,
headerView: this._waterfallTimelineRuler,
+needsReloadOnResize: true,
});
this._nameColumn.addEventListener(WI.TableColumn.Event.WidthDidChange, this._tableNameColumnDidChangeWidth, this);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Table.js (240346 => 240347)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2019-01-23 18:44:34 UTC (rev 240346)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2019-01-23 18:46:56 UTC (rev 240347)
@@ -483,6 +483,7 @@
}
// Re-layout all columns to make space.
+this._widthGeneration++;
this._columnWidths = null;
this._resizeColumnsAndFiller();
@@ -489,6 +490,14 @@
// Now populate only the new cells for this column.
for (let cell of cellsToPopulate)
this._delegate.tablePopulateCell(this, cell, column, cell.parentElement.__index);
+
+// Now populate columns that may be sensitive to resizes.
+for (let visibleColumn of this._visibleColumns) {
+if (visibleColumn !== column) {
+if (visibleColumn.needsReloadOnResize)
+this.reloadVisibleColumnCells(visibleColumn);
+}
+}
}
hideColumn(column)
@@ -533,14 +542,21 @@
if (!this._columnWidths)
return;
-this._columnWidths.splice(columnIndex, 1);
-
for (let row of this._listElement.children) {
if (row !== this._fillerRow)
row.removeChild(row.children[columnIndex]);
}
-this.needsLayout();
+// Re-layout all columns to make space.
+this._widthGeneration++;
+this._columnWidths = null;
+this._resizeColumnsAndFiller();
+
+// Now populate columns that may be sensitive to resizes.
+for (let visibleColumn of this._visibleColumns) {
+if (visibleColumn.needsReloadOnResize)
+this.reloadVisibleColumnCells(visibleColumn);
+}
}
restoreScrollPosition()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TableColumn.js (240346 => 240347)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TableColumn.js 2019-01-23 18:44:34 UTC (rev 240346)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TableColumn.js
[webkit-changes] [240346] trunk/Source/WebKit
Title: [240346] trunk/Source/WebKit
Revision 240346
Author bfulg...@apple.com
Date 2019-01-23 10:44:34 -0800 (Wed, 23 Jan 2019)
Log Message
REGRESSION (r240243): CrashTracer: WebKitTestRunnerApp at com.apple.WebKit: WebKit::WebResourceLoadStatisticsStore::sendDiagnosticMessageWithValue const + 32
https://bugs.webkit.org/show_bug.cgi?id=193723
Reviewed by David Kilzer.
The new code added in r240243 could attempt to submit telemetry after the relevant
WebResourceLoadStatisticsStore was destroyed. We should guard against this possibility.
* NetworkProcess/Classifier/WebResourceLoadStatisticsTelemetry.cpp:
(WebKit::WebResourceLoadStatisticsTelemetry::calculateAndSubmit):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsTelemetry.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (240345 => 240346)
--- trunk/Source/WebKit/ChangeLog 2019-01-23 18:39:37 UTC (rev 240345)
+++ trunk/Source/WebKit/ChangeLog 2019-01-23 18:44:34 UTC (rev 240346)
@@ -1,3 +1,17 @@
+2019-01-23 Brent Fulgham
+
+REGRESSION (r240243): CrashTracer: WebKitTestRunnerApp at com.apple.WebKit: WebKit::WebResourceLoadStatisticsStore::sendDiagnosticMessageWithValue const + 32
+https://bugs.webkit.org/show_bug.cgi?id=193723
+
+
+Reviewed by David Kilzer.
+
+The new code added in r240243 could attempt to submit telemetry after the relevant
+WebResourceLoadStatisticsStore was destroyed. We should guard against this possibility.
+
+* NetworkProcess/Classifier/WebResourceLoadStatisticsTelemetry.cpp:
+(WebKit::WebResourceLoadStatisticsTelemetry::calculateAndSubmit):
+
2019-01-23 Antti Koivisto
[PSON] Flash on back navigation on Mac
Modified: trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsTelemetry.cpp (240345 => 240346)
--- trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsTelemetry.cpp 2019-01-23 18:39:37 UTC (rev 240345)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsTelemetry.cpp 2019-01-23 18:44:34 UTC (rev 240346)
@@ -241,16 +241,19 @@
}
// Dispatch on the main thread to make sure the WebPageProxy we're using doesn't go away.
-RunLoop::main().dispatch([sortedPrevalentResources = WTFMove(sortedPrevalentResources), sortedPrevalentResourcesWithoutUserInteraction = WTFMove(sortedPrevalentResourcesWithoutUserInteraction), prevalentResourcesDaysSinceUserInteraction = WTFMove(prevalentResourcesDaysSinceUserInteraction), ] () {
+RunLoop::main().dispatch([sortedPrevalentResources = WTFMove(sortedPrevalentResources), sortedPrevalentResourcesWithoutUserInteraction = WTFMove(sortedPrevalentResourcesWithoutUserInteraction), prevalentResourcesDaysSinceUserInteraction = WTFMove(prevalentResourcesDaysSinceUserInteraction), resourceLoadStatisticsStore = makeWeakPtr(resourceLoadStatisticsStore)] () {
+if (!resourceLoadStatisticsStore)
+return;
+
auto webPageProxy = WebPageProxy::nonEphemeralWebPageProxy();
if (!webPageProxy) {
if (notifyPagesWhenTelemetryWasCaptured)
-notifyPages(0, 0, 0, resourceLoadStatisticsStore.store());
+notifyPages(0, 0, 0, resourceLoadStatisticsStore->store());
return;
}
if (notifyPagesWhenTelemetryWasCaptured) {
-notifyPages(sortedPrevalentResources, sortedPrevalentResourcesWithoutUserInteraction, prevalentResourcesDaysSinceUserInteraction.size(), resourceLoadStatisticsStore.store());
+notifyPages(sortedPrevalentResources, sortedPrevalentResourcesWithoutUserInteraction, prevalentResourcesDaysSinceUserInteraction.size(), resourceLoadStatisticsStore->store());
// The notify pages function is for testing so we don't need to do an actual submission.
return;
}
@@ -263,7 +266,7 @@
if (prevalentResourcesDaysSinceUserInteraction.size() > 1)
webPageProxy->logDiagnosticMessageWithValue(DiagnosticLoggingKeys::resourceLoadStatisticsTelemetryKey(), "medianPrevalentResourcesWithUserInteractionDaysSinceUserInteraction"_s, median(prevalentResourcesDaysSinceUserInteraction), significantFiguresForLoggedValues, ShouldSample::No);
-submitTopLists(sortedPrevalentResources, sortedPrevalentResourcesWithoutUserInteraction, resourceLoadStatisticsStore.store());
+submitTopLists(sortedPrevalentResources, sortedPrevalentResourcesWithoutUserInteraction, resourceLoadStatisticsStore->store());
});
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240345] trunk/Source/WebCore
Title: [240345] trunk/Source/WebCore
Revision 240345
Author ddkil...@apple.com
Date 2019-01-23 10:39:37 -0800 (Wed, 23 Jan 2019)
Log Message
REGRESSION (r240292): Attempt to fix WinCairo build
* platform/network/curl/CurlResourceHandleDelegate.cpp:
(WebCore::handleCookieHeaders): Remove argument to
NetworkingContext::storageSession().
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (240344 => 240345)
--- trunk/Source/WebCore/ChangeLog 2019-01-23 18:00:18 UTC (rev 240344)
+++ trunk/Source/WebCore/ChangeLog 2019-01-23 18:39:37 UTC (rev 240345)
@@ -1,3 +1,11 @@
+2019-01-23 David Kilzer
+
+REGRESSION (r240292): Attempt to fix WinCairo build
+
+* platform/network/curl/CurlResourceHandleDelegate.cpp:
+(WebCore::handleCookieHeaders): Remove argument to
+NetworkingContext::storageSession().
+
2019-01-23 Wenson Hsieh
Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
Modified: trunk/Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.cpp (240344 => 240345)
--- trunk/Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.cpp 2019-01-23 18:00:18 UTC (rev 240344)
+++ trunk/Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.cpp 2019-01-23 18:39:37 UTC (rev 240345)
@@ -89,7 +89,7 @@
{
static const auto setCookieHeader = "set-cookie: ";
-const auto& storageSession = *d->m_context->storageSession(PAL::SessionID::defaultSessionID());
+const auto& storageSession = *d->m_context->storageSession();
const auto& cookieJar = storageSession.cookieStorage();
for (const auto& header : response.headers) {
if (header.startsWithIgnoringASCIICase(setCookieHeader)) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240344] trunk/LayoutTests
Title: [240344] trunk/LayoutTests Revision 240344 Author commit-qu...@webkit.org Date 2019-01-23 10:00:18 -0800 (Wed, 23 Jan 2019) Log Message AX: [GTK] Layout test accessibility/set-selected-editable.html is failing https://bugs.webkit.org/show_bug.cgi?id=193623 Patch by Eric Liang on 2019-01-23 Reviewed by Michael Catanzaro. AXSelected attribute behavior on GTK is different. Skipped. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (240343 => 240344) --- trunk/LayoutTests/ChangeLog 2019-01-23 17:43:02 UTC (rev 240343) +++ trunk/LayoutTests/ChangeLog 2019-01-23 18:00:18 UTC (rev 240344) @@ -1,3 +1,14 @@ +2019-01-23 Eric Liang + +AX: [GTK] Layout test accessibility/set-selected-editable.html is failing +https://bugs.webkit.org/show_bug.cgi?id=193623 + +Reviewed by Michael Catanzaro. + +AXSelected attribute behavior on GTK is different. Skipped. + +* platform/gtk/TestExpectations: + 2019-01-22 Simon Fraser Compositing updates need to reparent scrolling tree nodes with a changed ancestor Modified: trunk/LayoutTests/platform/gtk/TestExpectations (240343 => 240344) --- trunk/LayoutTests/platform/gtk/TestExpectations 2019-01-23 17:43:02 UTC (rev 240343) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2019-01-23 18:00:18 UTC (rev 240344) @@ -100,6 +100,7 @@ webkit.org/b/98348 accessibility/radio-button-group-members.html [ Skip ] webkit.org/b/141074 accessibility/auto-filled-value.html [ Skip ] webkit.org/b/156045 accessibility/attachment-element.html [ Skip ] +webkit.org/b/193623 accessibility/set-selected-editable.html [ Skip ] # Feature disabled, see: https://bugs.webkit.org/show_bug.cgi?id=85425 webkit.org/b/98925 fast/viewport/viewport-legacy-handheldfriendly.html [ Skip ] @@ -2937,7 +2938,7 @@ webkit.org/b/103926 media/track/opera/interfaces/TextTrackCue/text.html [ Skip ] webkit.org/b/103926 media/track/opera/interfaces/TextTrackCue/vertical.html [ Skip ] webkit.org/b/103926 media/track/opera/track/webvtt/parsing/001.html [ Skip ] -webkit.org/b/103926 media/track/opera/track/webvtt/parsing-cue-data/tests/entities.html [ Skip ] +webkit.org/b/103926 media/track/opera/track/webvtt/parsing-cue-data/tests/entities.html [ Skip ] webkit.org/b/103926 media/track/opera/track/webvtt/parsing-cue-data/tests/tags.html [ Skip ] webkit.org/b/103926 media/track/opera/track/webvtt/rendering/adhoc/12345_timestamps.html [ Skip ] webkit.org/b/103926 media/track/opera/track/webvtt/parsing-cue-data/tests/timestamps.html [ Skip ] @@ -3679,8 +3680,6 @@ webkit.org/b/193518 imported/w3c/web-platform-tests/fetch/range/general.window.html [ Failure ] -webkit.org/b/193623 accessibility/set-selected-editable.html [ Failure ] - webkit.org/b/193627 editing/spelling/spelling-dots-position.html [ ImageOnlyFailure ] webkit.org/b/193628 fast/css/content-counter-010.htm [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240343] trunk/Source/WebKit
Title: [240343] trunk/Source/WebKit
Revision 240343
Author an...@apple.com
Date 2019-01-23 09:43:02 -0800 (Wed, 23 Jan 2019)
Log Message
[PSON] Flash on back navigation on Mac
https://bugs.webkit.org/show_bug.cgi?id=193716
Reviewed by Chris Dumez.
We close the page immediately if we fail to suspend. Layers disappear and we get a flash.
* UIProcess/SuspendedPageProxy.cpp:
(WebKit::SuspendedPageProxy::didProcessRequestToSuspend):
Remove the suspended page (so closing it on web process side) if the suspension fails.
Skip this if we are using web process side compositing on Mac.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::enterAcceleratedCompositingMode):
On Mac, remove failed SuspendedPageProxy when entering compositing mode. At this point we don't need it to keep layers alive.
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::removeFailedSuspendedPagesForPage):
* UIProcess/WebProcessPool.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::suspendForProcessSwap):
Don't close the page on suspension failure.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (240342 => 240343)
--- trunk/Source/WebKit/ChangeLog 2019-01-23 17:30:05 UTC (rev 240342)
+++ trunk/Source/WebKit/ChangeLog 2019-01-23 17:43:02 UTC (rev 240343)
@@ -1,3 +1,32 @@
+2019-01-23 Antti Koivisto
+
+[PSON] Flash on back navigation on Mac
+https://bugs.webkit.org/show_bug.cgi?id=193716
+
+
+Reviewed by Chris Dumez.
+
+We close the page immediately if we fail to suspend. Layers disappear and we get a flash.
+
+* UIProcess/SuspendedPageProxy.cpp:
+(WebKit::SuspendedPageProxy::didProcessRequestToSuspend):
+
+Remove the suspended page (so closing it on web process side) if the suspension fails.
+Skip this if we are using web process side compositing on Mac.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::enterAcceleratedCompositingMode):
+
+On Mac, remove failed SuspendedPageProxy when entering compositing mode. At this point we don't need it to keep layers alive.
+
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::removeFailedSuspendedPagesForPage):
+* UIProcess/WebProcessPool.h:
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::suspendForProcessSwap):
+
+Don't close the page on suspension failure.
+
2019-01-23 Wenson Hsieh
Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
Modified: trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp (240342 => 240343)
--- trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp 2019-01-23 17:30:05 UTC (rev 240342)
+++ trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp 2019-01-23 17:43:02 UTC (rev 240343)
@@ -26,6 +26,7 @@
#include "config.h"
#include "SuspendedPageProxy.h"
+#include "DrawingAreaProxy.h"
#include "Logging.h"
#include "WebPageMessages.h"
#include "WebPageProxy.h"
@@ -154,6 +155,19 @@
m_process->removeMessageReceiver(Messages::WebPageProxy::messageReceiverName(), m_page.pageID());
+bool shouldKeepOnFailure = false;
+#if PLATFORM(MAC)
+// With web process side tiles, we need to keep the suspended page around on failure to avoid flashing.
+// It is removed by WebPageProxy::enterAcceleratedCompositingMode when the target page is ready.
+shouldKeepOnFailure = m_page.drawingArea() && m_page.drawingArea()->type() == DrawingAreaTypeTiledCoreAnimation;
+#endif
+if (newSuspensionState == SuspensionState::FailedToSuspend && !shouldKeepOnFailure) {
+RunLoop::main().dispatch([weakProcessPool = makeWeakPtr(m_process->processPool()), weakThis = makeWeakPtr(*this)] {
+if (weakProcessPool && weakThis)
+weakProcessPool->removeSuspendedPage(*weakThis);
+});
+}
+
if (m_readyToUnsuspendHandler)
m_readyToUnsuspendHandler(this);
}
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (240342 => 240343)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-01-23 17:30:05 UTC (rev 240342)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-01-23 17:43:02 UTC (rev 240343)
@@ -6847,7 +6847,12 @@
void WebPageProxy::enterAcceleratedCompositingMode(const LayerTreeContext& layerTreeContext)
{
+#if PLATFORM(MAC)
+ASSERT(m_drawingArea->type() == DrawingAreaTypeTiledCoreAnimation);
+#endif
pageClient().enterAcceleratedCompositingMode(layerTreeContext);
+// We needed the failed suspended page to stay alive to avoid flashing. Now we can get rid of it.
+m_process->processPool().removeFailedSuspendedPagesForPage(*this);
}
void WebPageProxy::exitAcceleratedCompositingMode()
[webkit-changes] [240342] trunk/Source
Title: [240342] trunk/Source Revision 240342 Author wenson_hs...@apple.com Date 2019-01-23 09:30:05 -0800 (Wed, 23 Jan 2019) Log Message Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit https://bugs.webkit.org/show_bug.cgi?id=193706 Reviewed by Ryosuke Niwa. Source/WebCore: Refactors some existing logic when registering undoable actions, such that we propagate the undoable action's label string instead of the EditAction to the client layer. This will help make handling of CustomUndoStep's undo/redo label simpler, as the client layer won't need to worry about managing an EditAction and undo/redo label simultaneously. There should be no change in behavior. * editing/CompositeEditCommand.cpp: (WebCore::EditCommandComposition::label const): * editing/CompositeEditCommand.h: * editing/CustomUndoStep.cpp: (WebCore::CustomUndoStep::label const): * editing/CustomUndoStep.h: * editing/EditAction.cpp: (WebCore::undoRedoLabel): (WebCore::nameForUndoRedo): Deleted. * editing/EditAction.h: Rename nameForUndoRedo to undoRedoLabel, and remove the WEBCORE_EXPORT since it's no longer needed in WebKit or WebKitLegacy. * editing/UndoStep.h: Add UndoStep::label(). While EditCommandComposition implements this by mapping its EditAction to a localized string, CustomUndoStep implements this by returning the undoable action label provided by script. Source/WebKit: * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::registerEditCommand): * UIProcess/WebEditCommandProxy.cpp: (WebKit::WebEditCommandProxy::WebEditCommandProxy): * UIProcess/WebEditCommandProxy.h: Drive-by tweak: make WebEditCommandProxy's backpointer to its WebPageProxy a WeakPtr instead of a raw pointer. Additionally, call clear() instead of setting m_page to 0 upon invalidation. Also, turn the WebPageProxy* argument into a WebPageProxy&, since the WebPageProxy must exist when it creates a new WebEditCommandProxy. (WebKit::WebEditCommandProxy::create): (WebKit::WebEditCommandProxy::label const): (WebKit::WebEditCommandProxy::invalidate): (WebKit::WebEditCommandProxy::editAction const): Deleted. Adjust UI-side logic to just handle the undo/redo label, rather than map the edit action to a localized string. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::registerEditCommandForUndo): (WebKit::WebPageProxy::resetState): Tweak this to use std::exchange instead of copying all the WebEditCommandProxy RefPtrs into a separate Vector and then iterating over the Vector. * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: Adjust this so that we only send the undo/redo label over IPC, rather than the edit action type. * UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::registerEditCommand): * WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::registerUndoStep): Source/WebKitLegacy/mac: Use UndoStep::label(). * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (-[WebUndoStep initWithUndoStep:]): (+[WebUndoStep stepWithUndoStep:]): (WebEditorClient::registerUndoOrRedoStep): (WebEditorClient::registerUndoStep): (WebEditorClient::registerRedoStep): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/CompositeEditCommand.cpp trunk/Source/WebCore/editing/CompositeEditCommand.h trunk/Source/WebCore/editing/CustomUndoStep.cpp trunk/Source/WebCore/editing/CustomUndoStep.h trunk/Source/WebCore/editing/EditAction.cpp trunk/Source/WebCore/editing/EditAction.h trunk/Source/WebCore/editing/UndoStep.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm trunk/Source/WebKit/UIProcess/WebEditCommandProxy.cpp trunk/Source/WebKit/UIProcess/WebEditCommandProxy.h trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm trunk/Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm Diff Modified: trunk/Source/WebCore/ChangeLog (240341 => 240342) --- trunk/Source/WebCore/ChangeLog 2019-01-23 17:26:50 UTC (rev 240341) +++ trunk/Source/WebCore/ChangeLog 2019-01-23 17:30:05 UTC (rev 240342) @@ -1,3 +1,35 @@ +2019-01-23 Wenson Hsieh + +Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit +https://bugs.webkit.org/show_bug.cgi?id=193706 + + +Reviewed by Ryosuke Niwa. + +Refactors some existing logic when registering undoable actions, such that we propagate the undoable action's +label string instead of the EditAction to the client layer. This will help make handling of CustomUndoStep's +undo/redo label simpler, as the client layer won't need to worry about managing an EditAction and undo/redo +label simultaneously. There should be no change in behavior. + +* editing/CompositeEditCommand.cpp:
[webkit-changes] [240341] trunk/Source/WebKit
Title: [240341] trunk/Source/WebKit Revision 240341 Author mcatanz...@igalia.com Date 2019-01-23 09:26:50 -0800 (Wed, 23 Jan 2019) Log Message [SOUP] Remove libsoup cruft from WebProcess https://bugs.webkit.org/show_bug.cgi?id=193710 Reviewed by Carlos Garcia Campos. SoupNetworkSession is no longer accessible from the web process because it's owned (indirectly) by NetworkProcess after r240292. It doesn't make sense to have any libsoup code under WebProcess anymore. The current libsoup code consists of (a) unused stuff to be removed, (b) stuff unrelated to libsoup, which should move to a WebProcessGLib.cpp, and (c) WebKitSoupRequestInputStream, which is only used by NetworkProcess and should move there * NetworkProcess/soup/WebKitSoupRequestInputStream.cpp: Renamed from Source/WebKit/WebProcess/soup/WebKitSoupRequestInputStream.cpp. (AsyncReadData::AsyncReadData): (webkitSoupRequestInputStreamReadAsyncResultComplete): (webkitSoupRequestInputStreamPendingReadAsyncComplete): (webkitSoupRequestInputStreamHasDataToRead): (webkitSoupRequestInputStreamIsWaitingForData): (webkitSoupRequestInputStreamReadAsync): (webkitSoupRequestInputStreamReadFinish): (webkitSoupRequestInputStreamFinalize): (webkit_soup_request_input_stream_init): (webkit_soup_request_input_stream_class_init): (webkitSoupRequestInputStreamNew): (webkitSoupRequestInputStreamAddData): (webkitSoupRequestInputStreamDidFailWithError): (webkitSoupRequestInputStreamFinished): * NetworkProcess/soup/WebKitSoupRequestInputStream.h: Renamed from Source/WebKit/WebProcess/soup/WebKitSoupRequestInputStream.h. * SourcesGTK.txt: * SourcesWPE.txt: * UIProcess/soup/WebProcessPoolSoup.cpp: (WebKit::WebProcessPool::setNetworkProxySettings): Don't send message to web processes. * WebProcess/WebProcess.h: * WebProcess/WebProcess.messages.in: * WebProcess/glib/WebProcessGLib.cpp: Renamed from Source/WebKit/WebProcess/soup/WebProcessSoup.cpp. (WebKit::WebProcess::platformSetCacheModel): (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformTerminate): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/SourcesGTK.txt trunk/Source/WebKit/SourcesWPE.txt trunk/Source/WebKit/UIProcess/soup/WebProcessPoolSoup.cpp trunk/Source/WebKit/WebProcess/WebProcess.h trunk/Source/WebKit/WebProcess/WebProcess.messages.in Added Paths trunk/Source/WebKit/NetworkProcess/soup/WebKitSoupRequestInputStream.cpp trunk/Source/WebKit/NetworkProcess/soup/WebKitSoupRequestInputStream.h trunk/Source/WebKit/WebProcess/glib/ trunk/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp Removed Paths trunk/Source/WebKit/WebProcess/soup/ Diff Modified: trunk/Source/WebKit/ChangeLog (240340 => 240341) --- trunk/Source/WebKit/ChangeLog 2019-01-23 17:24:19 UTC (rev 240340) +++ trunk/Source/WebKit/ChangeLog 2019-01-23 17:26:50 UTC (rev 240341) @@ -1,5 +1,45 @@ 2019-01-23 Michael Catanzaro +[SOUP] Remove libsoup cruft from WebProcess +https://bugs.webkit.org/show_bug.cgi?id=193710 + +Reviewed by Carlos Garcia Campos. + +SoupNetworkSession is no longer accessible from the web process because it's owned +(indirectly) by NetworkProcess after r240292. It doesn't make sense to have any libsoup +code under WebProcess anymore. The current libsoup code consists of (a) unused stuff to be +removed, (b) stuff unrelated to libsoup, which should move to a WebProcessGLib.cpp, and (c) +WebKitSoupRequestInputStream, which is only used by NetworkProcess and should move there + +* NetworkProcess/soup/WebKitSoupRequestInputStream.cpp: Renamed from Source/WebKit/WebProcess/soup/WebKitSoupRequestInputStream.cpp. +(AsyncReadData::AsyncReadData): +(webkitSoupRequestInputStreamReadAsyncResultComplete): +(webkitSoupRequestInputStreamPendingReadAsyncComplete): +(webkitSoupRequestInputStreamHasDataToRead): +(webkitSoupRequestInputStreamIsWaitingForData): +(webkitSoupRequestInputStreamReadAsync): +(webkitSoupRequestInputStreamReadFinish): +(webkitSoupRequestInputStreamFinalize): +(webkit_soup_request_input_stream_init): +(webkit_soup_request_input_stream_class_init): +(webkitSoupRequestInputStreamNew): +(webkitSoupRequestInputStreamAddData): +(webkitSoupRequestInputStreamDidFailWithError): +(webkitSoupRequestInputStreamFinished): +* NetworkProcess/soup/WebKitSoupRequestInputStream.h: Renamed from Source/WebKit/WebProcess/soup/WebKitSoupRequestInputStream.h. +* SourcesGTK.txt: +* SourcesWPE.txt: +* UIProcess/soup/WebProcessPoolSoup.cpp: +(WebKit::WebProcessPool::setNetworkProxySettings): Don't send message to web processes. +* WebProcess/WebProcess.h: +* WebProcess/WebProcess.messages.in: +* WebProcess/glib/WebProcessGLib.cpp: Renamed from Source/WebKit/WebProcess/soup/WebProcessSoup.cpp. +
[webkit-changes] [240340] trunk/Source
Title: [240340] trunk/Source Revision 240340 Author mcatanz...@igalia.com Date 2019-01-23 09:24:19 -0800 (Wed, 23 Jan 2019) Log Message [SOUP] Clean up NetworkStorageSession https://bugs.webkit.org/show_bug.cgi?id=193707 Reviewed by Carlos Garcia Campos. Source/WebCore: A NetworkStorageSession now always has a SoupNetworkSession, so we can remove a lot of complexity that is no longer needed. getOrCreateSoupNetworkSession can go away because we know the session has always already been created. The soupNetworkSession getter can now return a reference rather than a pointer, because it will never be NULL except after it has been cleared with clearSoupNetworkSession (renamed), and that should only happen immediately before process termination after nothing else is using it. Cookie jar syncing can also go away; the NetworkStorageSession can now rely on the SoupNetworkSession to exist and just use its cookie jar. * platform/network/NetworkStorageSession.h: (WebCore::NetworkStorageSession::soupNetworkSession const): Deleted. * platform/network/soup/DNSResolveQueueSoup.cpp: (WebCore::DNSResolveQueueSoup::updateIsUsingProxy): (WebCore::DNSResolveQueueSoup::platformResolve): (WebCore::DNSResolveQueueSoup::resolve): * platform/network/soup/NetworkStorageSessionSoup.cpp: (WebCore::NetworkStorageSession::NetworkStorageSession): (WebCore::NetworkStorageSession::~NetworkStorageSession): (WebCore::NetworkStorageSession::soupNetworkSession const): (WebCore::NetworkStorageSession::clearSoupNetworkSession): (WebCore::NetworkStorageSession::cookieStorage const): (WebCore::NetworkStorageSession::setCookieStorage): (WebCore::NetworkStorageSession::getOrCreateSoupNetworkSession const): Deleted. (WebCore::NetworkStorageSession::clearSoupNetworkSessionAndCookieStorage): Deleted. * platform/network/soup/SocketStreamHandleImplSoup.cpp: (WebCore::SocketStreamHandleImpl::create): Source/WebKit: Restore an important call to clearSoupNetworkSession that was removed in r240292. Also, adapt to NetworkStorageSessions API changes. * NetworkProcess/CustomProtocols/soup/LegacyCustomProtocolManagerSoup.cpp: (WebKit::LegacyCustomProtocolManager::registerScheme): * NetworkProcess/soup/NetworkProcessMainSoup.cpp: * NetworkProcess/soup/NetworkProcessSoup.cpp: (WebKit::NetworkProcess::userPreferredLanguagesChanged): (WebKit::NetworkProcess::setNetworkProxySettings): * NetworkProcess/soup/NetworkSessionSoup.cpp: (WebKit::NetworkSessionSoup::soupSession const): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/NetworkStorageSession.h trunk/Source/WebCore/platform/network/soup/DNSResolveQueueSoup.cpp trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp trunk/Source/WebCore/platform/network/soup/SocketStreamHandleImplSoup.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/CustomProtocols/soup/LegacyCustomProtocolManagerSoup.cpp trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessMainSoup.cpp trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp trunk/Source/WebKit/NetworkProcess/soup/NetworkSessionSoup.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (240339 => 240340) --- trunk/Source/WebCore/ChangeLog 2019-01-23 17:23:29 UTC (rev 240339) +++ trunk/Source/WebCore/ChangeLog 2019-01-23 17:24:19 UTC (rev 240340) @@ -1,3 +1,37 @@ +2019-01-23 Michael Catanzaro + +[SOUP] Clean up NetworkStorageSession +https://bugs.webkit.org/show_bug.cgi?id=193707 + +Reviewed by Carlos Garcia Campos. + +A NetworkStorageSession now always has a SoupNetworkSession, so we can remove a lot of +complexity that is no longer needed. getOrCreateSoupNetworkSession can go away because we +know the session has always already been created. The soupNetworkSession getter can now +return a reference rather than a pointer, because it will never be NULL except after it has +been cleared with clearSoupNetworkSession (renamed), and that should only happen immediately +before process termination after nothing else is using it. Cookie jar syncing can also go +away; the NetworkStorageSession can now rely on the SoupNetworkSession to exist and just +use its cookie jar. + +* platform/network/NetworkStorageSession.h: +(WebCore::NetworkStorageSession::soupNetworkSession const): Deleted. +* platform/network/soup/DNSResolveQueueSoup.cpp: +(WebCore::DNSResolveQueueSoup::updateIsUsingProxy): +(WebCore::DNSResolveQueueSoup::platformResolve): +(WebCore::DNSResolveQueueSoup::resolve): +* platform/network/soup/NetworkStorageSessionSoup.cpp: +(WebCore::NetworkStorageSession::NetworkStorageSession): +(WebCore::NetworkStorageSession::~NetworkStorageSession): +(WebCore::NetworkStorageSession::soupNetworkSession const): +(WebCore::NetworkStorageSession::clearSoupNetworkSession): +
[webkit-changes] [240339] trunk/Tools
Title: [240339] trunk/Tools Revision 240339 Author jbed...@apple.com Date 2019-01-23 09:23:29 -0800 (Wed, 23 Jan 2019) Log Message webkitpy: Use correct config for --iphone-simulator and --ipad-simulator https://bugs.webkit.org/show_bug.cgi?id=193722 Reviewed by Lucas Forschler. iPhone and iPad ports should both use the iOS config. * Scripts/webkitpy/port/ios_simulator.py: (IPhoneSimulatorPort.__init__): (IPadSimulatorPort.__init__): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/port/ios_simulator.py Diff Modified: trunk/Tools/ChangeLog (240338 => 240339) --- trunk/Tools/ChangeLog 2019-01-23 16:48:04 UTC (rev 240338) +++ trunk/Tools/ChangeLog 2019-01-23 17:23:29 UTC (rev 240339) @@ -1,3 +1,17 @@ +2019-01-23 Jonathan Bedard + +webkitpy: Use correct config for --iphone-simulator and --ipad-simulator +https://bugs.webkit.org/show_bug.cgi?id=193722 + + +Reviewed by Lucas Forschler. + +iPhone and iPad ports should both use the iOS config. + +* Scripts/webkitpy/port/ios_simulator.py: +(IPhoneSimulatorPort.__init__): +(IPadSimulatorPort.__init__): + 2019-01-23 Rob Buis Update MIME type parser Modified: trunk/Tools/Scripts/webkitpy/port/ios_simulator.py (240338 => 240339) --- trunk/Tools/Scripts/webkitpy/port/ios_simulator.py 2019-01-23 16:48:04 UTC (rev 240338) +++ trunk/Tools/Scripts/webkitpy/port/ios_simulator.py 2019-01-23 17:23:29 UTC (rev 240339) @@ -24,7 +24,7 @@ from webkitpy.common.memoized import memoized from webkitpy.common.version import Version -from webkitpy.port.config import apple_additions +from webkitpy.port.config import apple_additions, Config from webkitpy.port.ios import IOSPort from webkitpy.xcode.device_type import DeviceType from webkitpy.xcode.simulated_device import SimulatedDeviceManager @@ -120,9 +120,17 @@ DeviceType(hardware_family='iPhone', hardware_type='7'), ] +def __init__(self, *args, **kwargs): +super(IPhoneSimulatorPort, self).__init__(*args, **kwargs) +self._config = Config(self._executive, self._filesystem, IOSSimulatorPort.port_name) + class IPadSimulatorPort(IOSSimulatorPort): port_name = 'ipad-simulator' DEVICE_TYPE = DeviceType(hardware_family='iPad') DEFAULT_DEVICE_TYPES = [DeviceType(hardware_family='iPad', hardware_type='(5th generation)')] + +def __init__(self, *args, **kwargs): +super(IPadSimulatorPort, self).__init__(*args, **kwargs) +self._config = Config(self._executive, self._filesystem, IOSSimulatorPort.port_name) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240338] trunk/Source/WebKit
Title: [240338] trunk/Source/WebKit
Revision 240338
Author ph...@webkit.org
Date 2019-01-23 08:48:04 -0800 (Wed, 23 Jan 2019)
Log Message
[GTK] Crash when browsing inspector:// uri without port set
https://bugs.webkit.org/show_bug.cgi?id=193721
Reviewed by Michael Catanzaro.
* UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:
(WebKit::RemoteInspectorProtocolHandler::handleRequest): Return
back to caller after setting the error, if no port was provided
along with the inspector URL.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (240337 => 240338)
--- trunk/Source/WebKit/ChangeLog 2019-01-23 16:29:53 UTC (rev 240337)
+++ trunk/Source/WebKit/ChangeLog 2019-01-23 16:48:04 UTC (rev 240338)
@@ -1,3 +1,15 @@
+2019-01-23 Philippe Normand
+
+[GTK] Crash when browsing inspector:// uri without port set
+https://bugs.webkit.org/show_bug.cgi?id=193721
+
+Reviewed by Michael Catanzaro.
+
+* UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:
+(WebKit::RemoteInspectorProtocolHandler::handleRequest): Return
+back to caller after setting the error, if no port was provided
+along with the inspector URL.
+
2019-01-23 David Kilzer
Switch remaining CoreMedia soft-linking in WebKit over to CoreMediaSoftLink.{cpp,h}
Modified: trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp (240337 => 240338)
--- trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp 2019-01-23 16:29:53 UTC (rev 240337)
+++ trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp 2019-01-23 16:48:04 UTC (rev 240338)
@@ -92,6 +92,7 @@
if (!requestURL.port()) {
GUniquePtr error(g_error_new_literal(WEBKIT_POLICY_ERROR, WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI, "Cannot show inspector URL: no port provided"));
webkit_uri_scheme_request_finish_error(request, error.get());
+return;
}
auto* webView = webkit_uri_scheme_request_get_web_view(request);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240337] trunk/Source/WebCore
Title: [240337] trunk/Source/WebCore Revision 240337 Author za...@apple.com Date 2019-01-23 08:29:53 -0800 (Wed, 23 Jan 2019) Log Message [LFC][BFC] computeStaticPosition should include estimated computation as well. https://bugs.webkit.org/show_bug.cgi?id=193719 Reviewed by Antti Koivisto. Consolidate all static position (non-estimated, estimated) computation in BlockFormattingContext::computeStaticPosition. It requires to compute width/horizontal margin first, since vertical top estimation needs valid horizontal widths (margin-top: 5% is computed using the containing block's width). This is also in preparation for moving 'clear' positioning to computeStaticPosition. * layout/blockformatting/BlockFormattingContext.cpp: (WebCore::Layout::BlockFormattingContext::layout const): (WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const): (WebCore::Layout::BlockFormattingContext::computeStaticPosition const): (WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPosition const): (WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForAncestors const): (WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForFormattingRoot const): (WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForFloatClear const): (WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const): (WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const): (WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const): (WebCore::Layout::BlockFormattingContext::adjustedVerticalPositionAfterMarginCollapsing const): (WebCore::Layout::BlockFormattingContext::computeEstimatedMarginBefore const): Deleted. (WebCore::Layout::BlockFormattingContext::computeEstimatedMarginBeforeForAncestors const): Deleted. (WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForFormattingRootIfNeeded const): Deleted. * layout/blockformatting/BlockFormattingContext.h: * layout/blockformatting/BlockFormattingContextGeometry.cpp: (WebCore::Layout::BlockFormattingContext::Geometry::staticPosition): * layout/blockformatting/BlockMarginCollapse.cpp: (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithFirstInFlowChildMarginBefore): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.h trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp trunk/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (240336 => 240337) --- trunk/Source/WebCore/ChangeLog 2019-01-23 16:11:50 UTC (rev 240336) +++ trunk/Source/WebCore/ChangeLog 2019-01-23 16:29:53 UTC (rev 240337) @@ -1,3 +1,36 @@ +2019-01-23 Zalan Bujtas + +[LFC][BFC] computeStaticPosition should include estimated computation as well. +https://bugs.webkit.org/show_bug.cgi?id=193719 + +Reviewed by Antti Koivisto. + +Consolidate all static position (non-estimated, estimated) computation in BlockFormattingContext::computeStaticPosition. +It requires to compute width/horizontal margin first, since vertical top estimation needs valid horizontal widths (margin-top: 5% is computed using +the containing block's width). +This is also in preparation for moving 'clear' positioning to computeStaticPosition. + +* layout/blockformatting/BlockFormattingContext.cpp: +(WebCore::Layout::BlockFormattingContext::layout const): +(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const): +(WebCore::Layout::BlockFormattingContext::computeStaticPosition const): +(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPosition const): +(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForAncestors const): +(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForFormattingRoot const): +(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForFloatClear const): +(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const): +(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const): +(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const): +(WebCore::Layout::BlockFormattingContext::adjustedVerticalPositionAfterMarginCollapsing const): +(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginBefore const): Deleted. +(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginBeforeForAncestors const): Deleted. +(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForFormattingRootIfNeeded const): Deleted. +* layout/blockformatting/BlockFormattingContext.h: +*
[webkit-changes] [240336] trunk
Title: [240336] trunk Revision 240336 Author simon.fra...@apple.com Date 2019-01-23 08:11:50 -0800 (Wed, 23 Jan 2019) Log Message Compositing updates need to reparent scrolling tree nodes with a changed ancestor https://bugs.webkit.org/show_bug.cgi?id=193699 Reviewed by Frédéric Wang. Source/WebCore: Now that compositing updates are incremental and may not do a full layer walk, we need to ensure that when a scrolling tree node is removed, we traverse to all descendant layers whose scrolling tree nodes refer to the removed node as their parent. To achieve this, add a RenderLayer dirty bit for "NeedsScrollingTreeUpdate" which ensures that the updateBackingAndHierarchy part of the compositing update traverses layers with the bit set. Adjust the compositing logging to make the legend easier to read. Tests: scrollingcoordinator/reparent-across-compositing-layers.html scrollingcoordinator/reparent-with-layer-removal.html * page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::childrenOfNode const): * page/scrolling/AsyncScrollingCoordinator.h: * page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::childrenOfNode const): * rendering/RenderLayer.cpp: (WebCore::outputPaintOrderTreeLegend): (WebCore::outputPaintOrderTreeRecursive): * rendering/RenderLayer.h: * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBackingAndHierarchy): (WebCore::RenderLayerCompositor::detachScrollCoordinatedLayer): LayoutTests: * platform/ios-wk2/scrollingcoordinator/reparent-across-compositing-layers-expected.txt: Added. * platform/ios-wk2/scrollingcoordinator/reparent-with-layer-removal-expected.txt: Added. * scrollingcoordinator/reparent-across-compositing-layers-expected.txt: Added. * scrollingcoordinator/reparent-across-compositing-layers.html: Added. * scrollingcoordinator/reparent-with-layer-removal-expected.txt: Added. * scrollingcoordinator/reparent-with-layer-removal.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderLayer.h trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp Added Paths trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/ trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/reparent-across-compositing-layers-expected.txt trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/reparent-with-layer-removal-expected.txt trunk/LayoutTests/scrollingcoordinator/reparent-across-compositing-layers-expected.txt trunk/LayoutTests/scrollingcoordinator/reparent-across-compositing-layers.html trunk/LayoutTests/scrollingcoordinator/reparent-with-layer-removal-expected.txt trunk/LayoutTests/scrollingcoordinator/reparent-with-layer-removal.html Diff Modified: trunk/LayoutTests/ChangeLog (240335 => 240336) --- trunk/LayoutTests/ChangeLog 2019-01-23 15:40:55 UTC (rev 240335) +++ trunk/LayoutTests/ChangeLog 2019-01-23 16:11:50 UTC (rev 240336) @@ -1,3 +1,17 @@ +2019-01-22 Simon Fraser + +Compositing updates need to reparent scrolling tree nodes with a changed ancestor +https://bugs.webkit.org/show_bug.cgi?id=193699 + +Reviewed by Frédéric Wang. + +* platform/ios-wk2/scrollingcoordinator/reparent-across-compositing-layers-expected.txt: Added. +* platform/ios-wk2/scrollingcoordinator/reparent-with-layer-removal-expected.txt: Added. +* scrollingcoordinator/reparent-across-compositing-layers-expected.txt: Added. +* scrollingcoordinator/reparent-across-compositing-layers.html: Added. +* scrollingcoordinator/reparent-with-layer-removal-expected.txt: Added. +* scrollingcoordinator/reparent-with-layer-removal.html: Added. + 2019-01-23 Oriol Brufau [css-logical] Implement flow-relative inset properties Added: trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/reparent-across-compositing-layers-expected.txt (0 => 240336) --- trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/reparent-across-compositing-layers-expected.txt (rev 0) +++ trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/reparent-across-compositing-layers-expected.txt 2019-01-23 16:11:50 UTC (rev 240336) @@ -0,0 +1,22 @@ +Scrolling content +Intermediate +Inner scrolling content + +(Frame scrolling node + (scrollable area size 800 600) + (contents size 800 600) + (scrollable area parameters +(horizontal scroll elasticity 1) +(vertical scroll elasticity 1) +(horizontal scrollbar mode 0) +(vertical scrollbar mode 0)) + (visual viewport enabled 1) + (layout viewport at (0,0) size 800x600) + (min layout viewport origin (0,0)) + (max layout viewport origin (0,0)) + (behavior for fixed 0) + (children 0 +
[webkit-changes] [240335] trunk/Source/JavaScriptCore
Title: [240335] trunk/Source/_javascript_Core
Revision 240335
Author ddkil...@apple.com
Date 2019-01-23 07:40:55 -0800 (Wed, 23 Jan 2019)
Log Message
[JSC] Duplicate global variables: JSC::opcodeLengths
Reviewed by Mark Lam.
* bytecode/Opcode.cpp:
(JSC::opcodeLengths): Move array implementation here and mark
const.
* bytecode/Opcode.h:
(JSC::opcodeLengths): Change to extern declaration.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/Opcode.cpp
trunk/Source/_javascript_Core/bytecode/Opcode.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (240334 => 240335)
--- trunk/Source/_javascript_Core/ChangeLog 2019-01-23 15:04:50 UTC (rev 240334)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-01-23 15:40:55 UTC (rev 240335)
@@ -1,3 +1,17 @@
+2019-01-23 David Kilzer
+
+[JSC] Duplicate global variables: JSC::opcodeLengths
+
+
+
+Reviewed by Mark Lam.
+
+* bytecode/Opcode.cpp:
+(JSC::opcodeLengths): Move array implementation here and mark
+const.
+* bytecode/Opcode.h:
+(JSC::opcodeLengths): Change to extern declaration.
+
2019-01-23 Carlos Garcia Campos
[GLIB] Remote Inspector: no data displayed
Modified: trunk/Source/_javascript_Core/bytecode/Opcode.cpp (240334 => 240335)
--- trunk/Source/_javascript_Core/bytecode/Opcode.cpp 2019-01-23 15:04:50 UTC (rev 240334)
+++ trunk/Source/_javascript_Core/bytecode/Opcode.cpp 2019-01-23 15:40:55 UTC (rev 240335)
@@ -40,6 +40,12 @@
namespace JSC {
+const unsigned opcodeLengths[] = {
+#define OPCODE_LENGTH(opcode, length) length,
+FOR_EACH_OPCODE_ID(OPCODE_LENGTH)
+#undef OPCODE_LENGTH
+};
+
const char* const opcodeNames[] = {
#define OPCODE_NAME_ENTRY(opcode, size) #opcode,
FOR_EACH_OPCODE_ID(OPCODE_NAME_ENTRY)
Modified: trunk/Source/_javascript_Core/bytecode/Opcode.h (240334 => 240335)
--- trunk/Source/_javascript_Core/bytecode/Opcode.h 2019-01-23 15:04:50 UTC (rev 240334)
+++ trunk/Source/_javascript_Core/bytecode/Opcode.h 2019-01-23 15:40:55 UTC (rev 240335)
@@ -71,16 +71,8 @@
#undef OPCODE_ID_ENUM
#endif
-IGNORE_WARNINGS_BEGIN("unused-variable")
+extern const unsigned opcodeLengths[];
-#define OPCODE_LENGTH(opcode, length) length,
-static unsigned opcodeLengths[] = {
-FOR_EACH_OPCODE_ID(OPCODE_LENGTH)
-};
-#undef OPCODE_LENGTH
-
-IGNORE_WARNINGS_END
-
#define OPCODE_ID_LENGTHS(id, length) const int id##_length = length;
FOR_EACH_OPCODE_ID(OPCODE_ID_LENGTHS);
#undef OPCODE_ID_LENGTHS
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240334] trunk
Title: [240334] trunk Revision 240334 Author commit-qu...@webkit.org Date 2019-01-23 07:04:50 -0800 (Wed, 23 Jan 2019) Log Message [css-logical] Implement flow-relative inset properties https://bugs.webkit.org/show_bug.cgi?id=189441 Patch by Oriol Brufau on 2019-01-23 Reviewed by Dean Jackson. LayoutTests/imported/w3c: Enable the CSSLogicalEnabled flag in the test for logical insets, and update its expectations. It still has some failures because sideways writing modes have not been implemented yet (https://bugs.webkit.org/show_bug.cgi?id=166941). * web-platform-tests/css/css-logical/logical-box-inset-expected.txt: * web-platform-tests/css/css-logical/logical-box-inset.html: Source/WebCore: Implement 'inset', 'inset-block', 'inset-block-start', 'inset-block-end', 'inset-inline', 'inset-inline-start' and 'inset-inline-end' CSS properties behind the CSSLogicalEnabled runtime flag. Tests: imported/w3c/web-platform-tests/css/css-logical/logical-box-inset.html webexposed/css-properties-behind-flags.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::isLayoutDependent): (WebCore::ComputedStyleExtractor::valueForPropertyinStyle): * css/CSSProperties.json: * css/CSSProperty.cpp: (WebCore::CSSProperty::resolveDirectionAwareProperty): (WebCore::CSSProperty::isDirectionAwareProperty): * css/StyleProperties.cpp: (WebCore::StyleProperties::getPropertyValue const): (WebCore::StyleProperties::asText const): * css/parser/CSSParserFastPaths.cpp: (WebCore::isSimpleLengthPropertyID): * css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::CSSPropertyParser::parseShorthand): LayoutTests: Check that the new CSS properties are disabled behind runtime flags and are not exposed. * webexposed/css-properties-behind-flags-expected.txt: * webexposed/css-properties-behind-flags.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-logical/logical-box-inset-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-logical/logical-box-inset.html trunk/LayoutTests/webexposed/css-properties-behind-flags-expected.txt trunk/LayoutTests/webexposed/css-properties-behind-flags.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/CSSProperties.json trunk/Source/WebCore/css/CSSProperty.cpp trunk/Source/WebCore/css/StyleProperties.cpp trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp Diff Modified: trunk/LayoutTests/ChangeLog (240333 => 240334) --- trunk/LayoutTests/ChangeLog 2019-01-23 12:44:49 UTC (rev 240333) +++ trunk/LayoutTests/ChangeLog 2019-01-23 15:04:50 UTC (rev 240334) @@ -1,3 +1,16 @@ +2019-01-23 Oriol Brufau + +[css-logical] Implement flow-relative inset properties +https://bugs.webkit.org/show_bug.cgi?id=189441 + +Reviewed by Dean Jackson. + +Check that the new CSS properties are disabled behind runtime flags +and are not exposed. + +* webexposed/css-properties-behind-flags-expected.txt: +* webexposed/css-properties-behind-flags.html: + 2019-01-23 Rob Buis Update MIME type parser Modified: trunk/LayoutTests/imported/w3c/ChangeLog (240333 => 240334) --- trunk/LayoutTests/imported/w3c/ChangeLog 2019-01-23 12:44:49 UTC (rev 240333) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-01-23 15:04:50 UTC (rev 240334) @@ -1,5 +1,20 @@ 2019-01-23 Oriol Brufau +[css-logical] Implement flow-relative inset properties +https://bugs.webkit.org/show_bug.cgi?id=189441 + +Reviewed by Dean Jackson. + +Enable the CSSLogicalEnabled flag in the test for logical insets, and +update its expectations. It still has some failures because sideways +writing modes have not been implemented yet +(https://bugs.webkit.org/show_bug.cgi?id=166941). + +* web-platform-tests/css/css-logical/logical-box-inset-expected.txt: +* web-platform-tests/css/css-logical/logical-box-inset.html: + +2019-01-23 Oriol Brufau + [css-grid] Properly handle static positions of abspos inside grid items https://bugs.webkit.org/show_bug.cgi?id=193657 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-logical/logical-box-inset-expected.txt (240333 => 240334) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-logical/logical-box-inset-expected.txt 2019-01-23 12:44:49 UTC (rev 240333) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-logical/logical-box-inset-expected.txt 2019-01-23 15:04:50 UTC (rev 240334) @@ -1,46 +1,46 @@ -FAIL Test that logical inset-* properties are supported. assert_equals: logical properties in inline style, inset-inline-start expected "1px" but got "" -FAIL Test that inset-inline shorthand sets longhands and serializes correctly. assert_equals:
[webkit-changes] [240332] trunk/Source
Title: [240332] trunk/Source
Revision 240332
Author ddkil...@apple.com
Date 2019-01-23 03:58:15 -0800 (Wed, 23 Jan 2019)
Log Message
Switch remaining CoreMedia soft-linking in WebKit over to CoreMediaSoftLink.{cpp,h}
Reviewed by Tim Horton.
Source/WebCore/PAL:
* pal/cf/CoreMediaSoftLink.cpp:
- Export kCMTimeZero soft-link.
* pal/cf/CoreMediaSoftLink.h:
- Update kCMTimeZero macro to use PAL namespace for use in
WebKit.framework.
Source/WebKit:
* Shared/ios/WebIconUtilities.mm:
- Switch to using CoreMediaSoftLink.{h,mm} in PAL.
Source/WTF:
* wtf/win/SoftLinking.h:
(SOFT_LINK_CONSTANT_FOR_SOURCE_WITH_EXPORT):
- Implement for Windows.
(SOFT_LINK_CONSTANT_FOR_SOURCE):
- Define using SOFT_LINK_CONSTANT_FOR_SOURCE_WITH_EXPORT().
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/win/SoftLinking.h
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp
trunk/Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/ios/WebIconUtilities.mm
Diff
Modified: trunk/Source/WTF/ChangeLog (240331 => 240332)
--- trunk/Source/WTF/ChangeLog 2019-01-23 11:32:55 UTC (rev 240331)
+++ trunk/Source/WTF/ChangeLog 2019-01-23 11:58:15 UTC (rev 240332)
@@ -1,3 +1,17 @@
+2019-01-23 David Kilzer
+
+Switch remaining CoreMedia soft-linking in WebKit over to CoreMediaSoftLink.{cpp,h}
+
+
+
+Reviewed by Tim Horton.
+
+* wtf/win/SoftLinking.h:
+(SOFT_LINK_CONSTANT_FOR_SOURCE_WITH_EXPORT):
+- Implement for Windows.
+(SOFT_LINK_CONSTANT_FOR_SOURCE):
+- Define using SOFT_LINK_CONSTANT_FOR_SOURCE_WITH_EXPORT().
+
2019-01-22 Tadeu Zagallo
Cache bytecode to disk
Modified: trunk/Source/WTF/wtf/win/SoftLinking.h (240331 => 240332)
--- trunk/Source/WTF/wtf/win/SoftLinking.h 2019-01-23 11:32:55 UTC (rev 240331)
+++ trunk/Source/WTF/wtf/win/SoftLinking.h 2019-01-23 11:58:15 UTC (rev 240332)
@@ -192,7 +192,7 @@
variableType get_##framework##_##variableName(); \
}
-#define SOFT_LINK_CONSTANT_FOR_SOURCE(functionNamespace, framework, variableName, variableType) \
+#define SOFT_LINK_CONSTANT_FOR_SOURCE_WITH_EXPORT(functionNamespace, framework, variableName, variableType, export) \
namespace functionNamespace { \
static void init##framework##variableName(void* context) { \
variableType* ptr = reinterpret_cast(SOFT_LINK_GETPROCADDRESS(framework##Library(), #variableName)); \
@@ -199,7 +199,7 @@
RELEASE_ASSERT(ptr); \
*static_cast(context) = *ptr; \
} \
-variableType get_##framework##_##variableName(); \
+export variableType get_##framework##_##variableName(); \
variableType get_##framework##_##variableName() \
{ \
static variableType constant##framework##variableName; \
@@ -209,6 +209,9 @@
} \
}
+#define SOFT_LINK_CONSTANT_FOR_SOURCE(functionNamespace, framework, variableName, variableType) \
+SOFT_LINK_CONSTANT_FOR_SOURCE_WITH_EXPORT(functionNamespace, framework, variableName, variableType, )
+
#define SOFT_LINK_CONSTANT_MAY_FAIL_FOR_HEADER(functionNamespace, framework, variableName, variableType) \
namespace functionNamespace { \
bool canLoad_##framework##_##variableName(); \
Modified: trunk/Source/WebCore/PAL/ChangeLog (240331 => 240332)
--- trunk/Source/WebCore/PAL/ChangeLog 2019-01-23 11:32:55 UTC (rev 240331)
+++ trunk/Source/WebCore/PAL/ChangeLog 2019-01-23 11:58:15 UTC (rev 240332)
@@ -1,3 +1,17 @@
+2019-01-23 David Kilzer
+
+Switch remaining CoreMedia soft-linking in WebKit over to CoreMediaSoftLink.{cpp,h}
+
+
+
+Reviewed by Tim Horton.
+
+* pal/cf/CoreMediaSoftLink.cpp:
+- Export kCMTimeZero soft-link.
+* pal/cf/CoreMediaSoftLink.h:
+- Update kCMTimeZero macro to use PAL namespace for use in
+ WebKit.framework.
+
2019-01-22 David Kilzer
Switch remaining QuickLook soft-linking in WebCore, WebKit over to QuickLookSoftLink.{cpp,h}
Modified: trunk/Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp (240331 => 240332)
--- trunk/Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp 2019-01-23 11:32:55 UTC (rev 240331)
+++ trunk/Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp 2019-01-23 11:58:15 UTC (rev 240332)
@@ -83,7 +83,7 @@
SOFT_LINK_CONSTANT_FOR_SOURCE(PAL, CoreMedia, kCMTextVerticalLayout_LeftToRight, CFStringRef)
SOFT_LINK_CONSTANT_FOR_SOURCE(PAL, CoreMedia, kCMTextVerticalLayout_RightToLeft, CFStringRef)
SOFT_LINK_CONSTANT_FOR_SOURCE(PAL, CoreMedia, kCMTimeInvalid, CMTime)
-SOFT_LINK_CONSTANT_FOR_SOURCE(PAL, CoreMedia, kCMTimeZero, CMTime)
+SOFT_LINK_CONSTANT_FOR_SOURCE_WITH_EXPORT(PAL, CoreMedia, kCMTimeZero, CMTime, PAL_EXPORT)
SOFT_LINK_CONSTANT_FOR_SOURCE(PAL, CoreMedia, kCMTimePositiveInfinity, CMTime)
SOFT_LINK_CONSTANT_FOR_SOURCE(PAL, CoreMedia, kCMTimeRangeInvalid, CMTimeRange);
Modified:
[webkit-changes] [240331] trunk
Title: [240331] trunk Revision 240331 Author commit-qu...@webkit.org Date 2019-01-23 03:32:55 -0800 (Wed, 23 Jan 2019) Log Message Update MIME type parser https://bugs.webkit.org/show_bug.cgi?id=180526 Patch by Rob Buis on 2019-01-23 Reviewed by Frédéric Wang. LayoutTests/imported/w3c: Update improved test expectations. * web-platform-tests/xhr/overridemimetype-blob-expected.txt: Source/WebCore: Add an enum to allow two modes of MIME type parsing, one mode to keep supporting RFC2045 as before, and one mode to support the updated MIME parser from mimesniff [1]. Mimesniff support brings the following changes: - allows parameter names without matching =value. - skips whitespace after subtype, parameter value and before parameter name. - lower cases MIME type and parameter name. - parameter names parsed before are discarded. The old mode is still used by CDM.cpp and MIMEHeader.cpp. [1] https://mimesniff.spec.whatwg.org/ * Modules/encryptedmedia/CDM.cpp: (WebCore::CDM::getSupportedCapabilitiesForAudioVideoType): * platform/network/MIMEHeader.cpp: (WebCore::MIMEHeader::parseHeader): * platform/network/ParsedContentType.cpp: (WebCore::DummyParsedContentType::setContentType const): (WebCore::DummyParsedContentType::setContentTypeParameter const): (WebCore::isQuotedStringTokenCharacter): (WebCore::isTokenCharacter): (WebCore::parseToken): (WebCore::containsNonTokenCharacters): (WebCore::parseQuotedString): (WebCore::isNotForwardSlash): (WebCore::isNotSemicolon): (WebCore::isNotSemicolonOrEqualSign): (WebCore::parseContentType): (WebCore::isValidContentType): (WebCore::ParsedContentType::ParsedContentType): (WebCore::ParsedContentType::setContentType): (WebCore::isNonTokenCharacter): (WebCore::isNonQuotedStringTokenCharacter): (WebCore::ParsedContentType::setContentTypeParameter): * platform/network/ParsedContentType.h: Test: web-platform-tests/xhr/overridemimetype-blob.html Tools: Add unit tests for both parse modes of ParsedContentType. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added. (TestWebKitAPI::TEST): LayoutTests: Adjust test expectation. * http/tests/xmlhttprequest/post-blob-content-type-async-expected.txt: * http/tests/xmlhttprequest/post-blob-content-type-sync-expected.txt: * http/tests/xmlhttprequest/post-blob-content-type-tests.js: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/xmlhttprequest/post-blob-content-type-async-expected.txt trunk/LayoutTests/http/tests/xmlhttprequest/post-blob-content-type-sync-expected.txt trunk/LayoutTests/http/tests/xmlhttprequest/post-blob-content-type-tests.js trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/overridemimetype-blob-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/encryptedmedia/CDM.cpp trunk/Source/WebCore/platform/network/MIMEHeader.cpp trunk/Source/WebCore/platform/network/ParsedContentType.cpp trunk/Source/WebCore/platform/network/ParsedContentType.h trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj Added Paths trunk/Tools/TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp Diff Modified: trunk/LayoutTests/ChangeLog (240330 => 240331) --- trunk/LayoutTests/ChangeLog 2019-01-23 10:12:56 UTC (rev 240330) +++ trunk/LayoutTests/ChangeLog 2019-01-23 11:32:55 UTC (rev 240331) @@ -1,3 +1,16 @@ +2019-01-23 Rob Buis + +Update MIME type parser +https://bugs.webkit.org/show_bug.cgi?id=180526 + +Reviewed by Frédéric Wang. + +Adjust test expectation. + +* http/tests/xmlhttprequest/post-blob-content-type-async-expected.txt: +* http/tests/xmlhttprequest/post-blob-content-type-sync-expected.txt: +* http/tests/xmlhttprequest/post-blob-content-type-tests.js: + 2019-01-22 Simon Fraser Adding a child to a ScrollingStateNode needs to trigger a tree state commit Modified: trunk/LayoutTests/http/tests/xmlhttprequest/post-blob-content-type-async-expected.txt (240330 => 240331) --- trunk/LayoutTests/http/tests/xmlhttprequest/post-blob-content-type-async-expected.txt 2019-01-23 10:12:56 UTC (rev 240330) +++ trunk/LayoutTests/http/tests/xmlhttprequest/post-blob-content-type-async-expected.txt 2019-01-23 11:32:55 UTC (rev 240331) @@ -12,7 +12,7 @@ PASS expectedMimeType is "" PASS expectedMimeType is "" PASS expectedMimeType is "" -PASS expectedMimeType is "" +PASS expectedMimeType is "multipart/mixed;boundary=\"--blob-boundary" PASS expectedMimeType is "multipart/mixed;boundary=\"--blob-boundary\"" PASS expectedMimeType is "" PASS expectedMimeType is "" Modified: trunk/LayoutTests/http/tests/xmlhttprequest/post-blob-content-type-sync-expected.txt (240330 => 240331) --- trunk/LayoutTests/http/tests/xmlhttprequest/post-blob-content-type-sync-expected.txt 2019-01-23 10:12:56 UTC (rev 240330) +++
[webkit-changes] [240330] trunk/Source/JavaScriptCore
Title: [240330] trunk/Source/_javascript_Core
Revision 240330
Author carlo...@webkit.org
Date 2019-01-23 02:12:56 -0800 (Wed, 23 Jan 2019)
Log Message
[GLIB] Remote Inspector: no data displayed
https://bugs.webkit.org/show_bug.cgi?id=193569
Reviewed by Michael Catanzaro.
Release the remote inspector mutex before using RemoteConnectionToTarget in RemoteInspector::setup() to avoid a
deadlock.
* inspector/remote/glib/RemoteInspectorGlib.cpp:
(Inspector::RemoteInspector::receivedSetupMessage):
(Inspector::RemoteInspector::setup):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorGlib.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (240329 => 240330)
--- trunk/Source/_javascript_Core/ChangeLog 2019-01-23 06:21:41 UTC (rev 240329)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-01-23 10:12:56 UTC (rev 240330)
@@ -1,3 +1,17 @@
+2019-01-23 Carlos Garcia Campos
+
+[GLIB] Remote Inspector: no data displayed
+https://bugs.webkit.org/show_bug.cgi?id=193569
+
+Reviewed by Michael Catanzaro.
+
+Release the remote inspector mutex before using RemoteConnectionToTarget in RemoteInspector::setup() to avoid a
+deadlock.
+
+* inspector/remote/glib/RemoteInspectorGlib.cpp:
+(Inspector::RemoteInspector::receivedSetupMessage):
+(Inspector::RemoteInspector::setup):
+
2019-01-22 Yusuke Suzuki
Unreviewed, fix initial global lexical binding epoch
Modified: trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorGlib.cpp (240329 => 240330)
--- trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorGlib.cpp 2019-01-23 06:21:41 UTC (rev 240329)
+++ trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorGlib.cpp 2019-01-23 10:12:56 UTC (rev 240330)
@@ -293,7 +293,6 @@
void RemoteInspector::receivedSetupMessage(unsigned targetIdentifier)
{
-std::lock_guard lock(m_mutex);
setup(targetIdentifier);
}
@@ -328,9 +327,13 @@
void RemoteInspector::setup(unsigned targetIdentifier)
{
-RemoteControllableTarget* target = m_targetMap.get(targetIdentifier);
-if (!target)
-return;
+RemoteControllableTarget* target;
+{
+std::lock_guard lock(m_mutex);
+target = m_targetMap.get(targetIdentifier);
+if (!target)
+return;
+}
auto connectionToTarget = adoptRef(*new RemoteConnectionToTarget(*target));
ASSERT(is(target) || is(target));
@@ -338,6 +341,8 @@
connectionToTarget->close();
return;
}
+
+std::lock_guard lock(m_mutex);
m_targetConnectionMap.set(targetIdentifier, WTFMove(connectionToTarget));
updateHasActiveDebugSession();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
