[webkit-changes] [222981] trunk/Source/JavaScriptCore

2017-10-06 Thread rmorisset
Title: [222981] trunk/Source/_javascript_Core Revision 222981 Author rmoris...@apple.com Date 2017-10-06 09:33:42 -0700 (Fri, 06 Oct 2017) Log Message Avoid integer overflow in DFGStrengthReduction.cpp https://bugs.webkit.org/show_bug.cgi?id=177944 Reviewed by Saam Barati. The check

[webkit-changes] [223047] trunk/Source

2017-10-09 Thread rmorisset
Title: [223047] trunk/Source Revision 223047 Author rmoris...@apple.com Date 2017-10-09 09:49:13 -0700 (Mon, 09 Oct 2017) Log Message Source/_javascript_Core: Make the names of the options consistent https://bugs.webkit.org/show_bug.cgi?id=177933 Reviewed by Saam Barati. I added an

[webkit-changes] [221862] trunk/Tools

2017-09-11 Thread rmorisset
"Robin Morisset" : { + "emails" : [ + "rmoris...@apple.com", + "robin.moris...@normalesup.org" + ], + "nicks" : [ + "rmorisset" + ], + "status" : "committer" + },

[webkit-changes] [223086] trunk/Source/JavaScriptCore

2017-10-09 Thread rmorisset
Title: [223086] trunk/Source/_javascript_Core Revision 223086 Author rmoris...@apple.com Date 2017-10-09 16:55:25 -0700 (Mon, 09 Oct 2017) Log Message Refactor the inliner to simplify block linking https://bugs.webkit.org/show_bug.cgi?id=177922 Reviewed by Saam Barati. The biggest

[webkit-changes] [223112] trunk/Source/JavaScriptCore

2017-10-09 Thread rmorisset
Title: [223112] trunk/Source/_javascript_Core Revision 223112 Author rmoris...@apple.com Date 2017-10-09 18:30:02 -0700 (Mon, 09 Oct 2017) Log Message Evaluate the benefit of skipping dead code in the DFGByteCodeParser when a function returns in its first block

[webkit-changes] [223159] trunk/Source/JavaScriptCore

2017-10-10 Thread rmorisset
Title: [223159] trunk/Source/_javascript_Core Revision 223159 Author rmoris...@apple.com Date 2017-10-10 17:09:20 -0700 (Tue, 10 Oct 2017) Log Message Avoid allocating useless landingBlocks in DFGByteCodeParser::handleInlining() https://bugs.webkit.org/show_bug.cgi?id=177926 Reviewed by

[webkit-changes] [225212] trunk/Source/JavaScriptCore

2017-11-28 Thread rmorisset
Title: [225212] trunk/Source/_javascript_Core Revision 225212 Author rmoris...@apple.com Date 2017-11-28 05:11:32 -0800 (Tue, 28 Nov 2017) Log Message Support recursive tail call optimization for polymorphic calls https://bugs.webkit.org/show_bug.cgi?id=178390 Reviewed by Saam Barati.

[webkit-changes] [225170] trunk/Source/JavaScriptCore

2017-11-27 Thread rmorisset
Title: [225170] trunk/Source/_javascript_Core Revision 225170 Author rmoris...@apple.com Date 2017-11-27 08:22:54 -0800 (Mon, 27 Nov 2017) Log Message Update DFGSafeToExecute to be aware that ArrayPush is now a varargs node https://bugs.webkit.org/show_bug.cgi?id=179821 Reviewed by Saam

[webkit-changes] [225270] trunk

2017-11-29 Thread rmorisset
Title: [225270] trunk Revision 225270 Author rmoris...@apple.com Date 2017-11-29 09:31:54 -0800 (Wed, 29 Nov 2017) Log Message The recursive tail call optimisation is wrong on closures https://bugs.webkit.org/show_bug.cgi?id=179835 Reviewed by Saam Barati. JSTests: *

[webkit-changes] [224915] trunk

2017-11-16 Thread rmorisset
Title: [224915] trunk Revision 224915 Author rmoris...@apple.com Date 2017-11-16 07:04:37 -0800 (Thu, 16 Nov 2017) Log Message REGRESSION (r224592): oss-fuzz: jsc: Null-dereference READ in JSC::JSCell::isObject (4216) https://bugs.webkit.org/show_bug.cgi?id=179763 Reviewed by Keith

[webkit-changes] [224918] trunk/Source/JavaScriptCore

2017-11-16 Thread rmorisset
Title: [224918] trunk/Source/_javascript_Core Revision 224918 Author rmoris...@apple.com Date 2017-11-16 07:48:11 -0800 (Thu, 16 Nov 2017) Log Message Provide a runtime option for disabling the optimization of recursive tail calls https://bugs.webkit.org/show_bug.cgi?id=179765 Reviewed

[webkit-changes] [224916] trunk/Source/JavaScriptCore

2017-11-16 Thread rmorisset
Title: [224916] trunk/Source/_javascript_Core Revision 224916 Author rmoris...@apple.com Date 2017-11-16 07:08:10 -0800 (Thu, 16 Nov 2017) Log Message Fix null pointer dereference in bytecodeDumper https://bugs.webkit.org/show_bug.cgi?id=179764 Reviewed by Mark Lam. The problem was

[webkit-changes] [224689] trunk/Source/JavaScriptCore

2017-11-10 Thread rmorisset
Title: [224689] trunk/Source/_javascript_Core Revision 224689 Author rmoris...@apple.com Date 2017-11-10 09:39:55 -0800 (Fri, 10 Nov 2017) Log Message The memory consumption of DFG::BasicBlock can be easily reduced a bit https://bugs.webkit.org/show_bug.cgi?id=179528 Reviewed by Saam

[webkit-changes] [224592] trunk

2017-11-08 Thread rmorisset
Title: [224592] trunk Revision 224592 Author rmoris...@apple.com Date 2017-11-08 12:42:15 -0800 (Wed, 08 Nov 2017) Log Message Turn recursive tail calls into loops https://bugs.webkit.org/show_bug.cgi?id=176601 Reviewed by Saam Barati. Relanding after

[webkit-changes] [224491] trunk/Source/JavaScriptCore

2017-11-06 Thread rmorisset
Title: [224491] trunk/Source/_javascript_Core Revision 224491 Author rmoris...@apple.com Date 2017-11-06 06:55:31 -0800 (Mon, 06 Nov 2017) Log Message CodeBlock::usesOpcode() is dead code https://bugs.webkit.org/show_bug.cgi?id=179316 Reviewed by Yusuke Suzuki. Remove

[webkit-changes] [224485] trunk/PerformanceTests

2017-11-06 Thread rmorisset
Title: [224485] trunk/PerformanceTests Revision 224485 Author rmoris...@apple.com Date 2017-11-06 04:56:51 -0800 (Mon, 06 Nov 2017) Log Message PerformanceTests/TailBench9000/merge-sort.js does not actually sort any of the large arrays it allocates

[webkit-changes] [224486] trunk

2017-11-06 Thread rmorisset
Title: [224486] trunk Revision 224486 Author rmoris...@apple.com Date 2017-11-06 04:58:42 -0800 (Mon, 06 Nov 2017) Log Message Add a third benchmark to TailBench https://bugs.webkit.org/show_bug.cgi?id=178815 Reviewed by Saam Barati. Add a new benchmark to TailBench: a BF interpreter

[webkit-changes] [223956] trunk

2017-10-25 Thread rmorisset
Title: [223956] trunk Revision 223956 Author rmoris...@apple.com Date 2017-10-25 09:58:57 -0700 (Wed, 25 Oct 2017) Log Message Support the TailBench9000 benchmark in run-jsc-benchmarks https://bugs.webkit.org/show_bug.cgi?id=178451 Reviewed by Saam Barati. PerformanceTests: The

[webkit-changes] [232514] trunk/Tools

2018-06-05 Thread rmorisset
Title: [232514] trunk/Tools Revision 232514 Author rmoris...@apple.com Date 2018-06-05 11:06:53 -0700 (Tue, 05 Jun 2018) Log Message Add a grammar (in antlr4 format) to the WSL spec. https://bugs.webkit.org/show_bug.cgi?id=186310 Rubberstamped by Filip Pizlo It is just the raw rules,

[webkit-changes] [233254] trunk/Tools

2018-06-27 Thread rmorisset
Title: [233254] trunk/Tools Revision 233254 Author rmoris...@apple.com Date 2018-06-27 08:04:07 -0700 (Wed, 27 Jun 2018) Log Message [WSL] Put the full grammar in the Sphinx document https://bugs.webkit.org/show_bug.cgi?id=186310 Rubberstamped by Filip Pizlo. Put the grammar's

[webkit-changes] [233256] trunk/Tools

2018-06-27 Thread rmorisset
Title: [233256] trunk/Tools Revision 233256 Author rmoris...@apple.com Date 2018-06-27 08:14:45 -0700 (Wed, 27 Jun 2018) Log Message [WSL] Fix minor formatting issues in the grammar section https://bugs.webkit.org/show_bug.cgi?id=186310 Rubberstamped by Filip Pizlo. Modified Paths

[webkit-changes] [233262] trunk/Tools

2018-06-27 Thread rmorisset
Title: [233262] trunk/Tools Revision 233262 Author rmoris...@apple.com Date 2018-06-27 10:01:33 -0700 (Wed, 27 Jun 2018) Log Message [WSL] Add a control-flow stack to the execution rules in WSL.ott https://bugs.webkit.org/show_bug.cgi?id=186310 Rubberstamped by Filip Pizlo. The goal of

[webkit-changes] [233146] trunk/Tools

2018-06-25 Thread rmorisset
Title: [233146] trunk/Tools Revision 233146 Author rmoris...@apple.com Date 2018-06-25 08:15:03 -0700 (Mon, 25 Jun 2018) Log Message [WSL] Start writing the Sphinx document https://bugs.webkit.org/show_bug.cgi?id=186310 Rubberstamped by Filip Pizlo. Very early work, just has the lexer

[webkit-changes] [233013] trunk/Tools

2018-06-20 Thread rmorisset
Title: [233013] trunk/Tools Revision 233013 Author rmoris...@apple.com Date 2018-06-20 10:07:43 -0700 (Wed, 20 Jun 2018) Log Message [WSL] Add details to the sphinx outline https://bugs.webkit.org/show_bug.cgi?id=186310 Rubberstamped by Filip Pizlo. Mostly improving the sphinx outline.

[webkit-changes] [231229] trunk

2018-05-02 Thread rmorisset
Title: [231229] trunk Revision 231229 Author rmoris...@apple.com Date 2018-05-02 04:21:28 -0700 (Wed, 02 May 2018) Log Message emitCodeToGetArgumentsArrayLength should not crash on PhantomNewArrayWithSpread https://bugs.webkit.org/show_bug.cgi?id=183172 Reviewed by Filip Pizlo.

[webkit-changes] [231196] trunk

2018-05-01 Thread rmorisset
Title: [231196] trunk Revision 231196 Author rmoris...@apple.com Date 2018-05-01 08:47:29 -0700 (Tue, 01 May 2018) Log Message IntlObject.cpp::removeUnicodeLocaleExtension() should not touch locales that end in '-u' https://bugs.webkit.org/show_bug.cgi?id=185162 Reviewed by Filip Pizlo.

[webkit-changes] [231197] trunk

2018-05-01 Thread rmorisset
Title: [231197] trunk Revision 231197 Author rmoris...@apple.com Date 2018-05-01 09:01:25 -0700 (Tue, 01 May 2018) Log Message Correctly detect string overflow when using the 'Function' constructor https://bugs.webkit.org/show_bug.cgi?id=184883 Reviewed by Filip Pizlo. JSTests: I put

[webkit-changes] [231198] trunk/Source/JavaScriptCore

2018-05-01 Thread rmorisset
Title: [231198] trunk/Source/_javascript_Core Revision 231198 Author rmoris...@apple.com Date 2018-05-01 09:03:54 -0700 (Tue, 01 May 2018) Log Message Use CheckedArithmetic for length computation in JSArray::unshiftCountWithAnyIndexingType https://bugs.webkit.org/show_bug.cgi?id=184772

[webkit-changes] [223691] trunk

2017-10-19 Thread rmorisset
Title: [223691] trunk Revision 223691 Author rmoris...@apple.com Date 2017-10-19 09:27:44 -0700 (Thu, 19 Oct 2017) Log Message Turn recursive tail calls into loops https://bugs.webkit.org/show_bug.cgi?id=176601 Reviewed by Saam Barati. JSTests: Add some simple test that computes

[webkit-changes] [226362] trunk

2018-01-03 Thread rmorisset
Title: [226362] trunk Revision 226362 Author rmoris...@apple.com Date 2018-01-03 09:35:35 -0800 (Wed, 03 Jan 2018) Log Message Inlining of a function that ends in op_unreachable crashes https://bugs.webkit.org/show_bug.cgi?id=181027 Reviewed by Filip Pizlo. JSTests: *

[webkit-changes] [233041] trunk/Tools

2018-06-21 Thread rmorisset
Title: [233041] trunk/Tools Revision 233041 Author rmoris...@apple.com Date 2018-06-21 09:44:07 -0700 (Thu, 21 Jun 2018) Log Message [WSL] Merge WSL_type.ott and WSL_exec.ott https://bugs.webkit.org/show_bug.cgi?id=186310 Rubberstamped by Filip Pizlo. I moved the execution rules into

[webkit-changes] [232955] trunk/Tools

2018-06-19 Thread rmorisset
Title: [232955] trunk/Tools Revision 232955 Author rmoris...@apple.com Date 2018-06-19 00:14:49 -0700 (Tue, 19 Jun 2018) Log Message [WSL] Snapshot of the elements of the spec Rubberstamped by Filip Pizlo. Modified Paths trunk/Tools/ChangeLog

[webkit-changes] [232957] trunk/Tools

2018-06-19 Thread rmorisset
Title: [232957] trunk/Tools Revision 232957 Author rmoris...@apple.com Date 2018-06-19 03:35:15 -0700 (Tue, 19 Jun 2018) Log Message [WSL] Improving the typing rules Rubberstamped by Filip Pizlo. Modified Paths trunk/Tools/ChangeLog

[webkit-changes] [233733] trunk/Tools

2018-07-11 Thread rmorisset
Title: [233733] trunk/Tools Revision 233733 Author rmoris...@apple.com Date 2018-07-11 10:29:31 -0700 (Wed, 11 Jul 2018) Log Message [WSL] WIP, some work on the spec. Modified Paths trunk/Tools/ChangeLog trunk/Tools/WebGPUShadingLanguageRI/SpecWork/WSL.ott

[webkit-changes] [227435] trunk/Source/JavaScriptCore

2018-01-23 Thread rmorisset
Title: [227435] trunk/Source/_javascript_Core Revision 227435 Author rmoris...@apple.com Date 2018-01-23 12:49:26 -0800 (Tue, 23 Jan 2018) Log Message Rollout r219636 https://bugs.webkit.org/show_bug.cgi?id=181997 Unreviewed, as it is a rollout. * dfg/DFGSpeculativeJIT.cpp:

[webkit-changes] [227410] trunk

2018-01-23 Thread rmorisset
Title: [227410] trunk Revision 227410 Author rmoris...@apple.com Date 2018-01-23 06:28:10 -0800 (Tue, 23 Jan 2018) Log Message Update the argument count in DFGByteCodeParser::handleRecursiveCall https://bugs.webkit.org/show_bug.cgi?id=181739 Reviewed by Saam Barati. JSTests: *

[webkit-changes] [230026] trunk

2018-03-28 Thread rmorisset
Title: [230026] trunk Revision 230026 Author rmoris...@apple.com Date 2018-03-28 02:36:44 -0700 (Wed, 28 Mar 2018) Log Message appendQuotedJSONString stops on arithmetic overflow instead of propagating it upwards https://bugs.webkit.org/show_bug.cgi?id=183894 Reviewed by Saam Barati.

[webkit-changes] [230101] trunk

2018-03-30 Thread rmorisset
Title: [230101] trunk Revision 230101 Author rmoris...@apple.com Date 2018-03-30 05:05:34 -0700 (Fri, 30 Mar 2018) Log Message Out-of-bounds accesses due to a missing check for MAX_STORAGE_VECTOR_LENGTH in unshiftCountForAnyIndexingType https://bugs.webkit.org/show_bug.cgi?id=183657

[webkit-changes] [230102] trunk

2018-03-30 Thread rmorisset
Title: [230102] trunk Revision 230102 Author rmoris...@apple.com Date 2018-03-30 05:39:43 -0700 (Fri, 30 Mar 2018) Log Message A stack overflow in the parsing of a builtin (called by createExecutable) cause a crash instead of a catchable js exception

[webkit-changes] [230103] trunk

2018-03-30 Thread rmorisset
Title: [230103] trunk Revision 230103 Author rmoris...@apple.com Date 2018-03-30 07:03:10 -0700 (Fri, 30 Mar 2018) Log Message Inlining of a function that ends in op_unreachable in a non-tail position triggers an ASSERT https://bugs.webkit.org/show_bug.cgi?id=183812 Reviewed by Keith

[webkit-changes] [231034] trunk

2018-04-25 Thread rmorisset
Title: [231034] trunk Revision 231034 Author rmoris...@apple.com Date 2018-04-25 16:32:58 -0700 (Wed, 25 Apr 2018) Log Message In FTLLowerDFGToB3.cpp::compileCreateRest, always use a contiguous array as the indexing type when under isWatchingHavingABadTimeWatchpoint

[webkit-changes] [233007] trunk/Tools

2018-06-20 Thread rmorisset
Title: [233007] trunk/Tools Revision 233007 Author rmoris...@apple.com Date 2018-06-20 03:55:53 -0700 (Wed, 20 Jun 2018) Log Message [WSL] Make the typing rules explicit about resolving type syntax Rubberstamped by Filip Pizlo. Modified Paths trunk/Tools/ChangeLog

[webkit-changes] [243851] trunk

2019-04-03 Thread rmorisset
Title: [243851] trunk Revision 243851 Author rmoris...@apple.com Date 2019-04-03 20:37:23 -0700 (Wed, 03 Apr 2019) Log Message B3 should use associativity to optimize _expression_ trees https://bugs.webkit.org/show_bug.cgi?id=194081 Reviewed by Filip Pizlo. JSTests: Added three

[webkit-changes] [243918] trunk/Source/JavaScriptCore

2019-04-04 Thread rmorisset
Title: [243918] trunk/Source/_javascript_Core Revision 243918 Author rmoris...@apple.com Date 2019-04-04 17:08:31 -0700 (Thu, 04 Apr 2019) Log Message B3ReduceStrength should know that Mul distributes over Add and Sub https://bugs.webkit.org/show_bug.cgi?id=196325 Reviewed by Saam

[webkit-changes] [243670] trunk/Source/JavaScriptCore

2019-03-29 Thread rmorisset
Title: [243670] trunk/Source/_javascript_Core Revision 243670 Author rmoris...@apple.com Date 2019-03-29 17:21:38 -0700 (Fri, 29 Mar 2019) Log Message B3ReduceStrength should know that Mul distributes over Add and Sub https://bugs.webkit.org/show_bug.cgi?id=196325 Reviewed by Michael

[webkit-changes] [242011] trunk/Source/JavaScriptCore

2019-02-23 Thread rmorisset
Title: [242011] trunk/Source/_javascript_Core Revision 242011 Author rmoris...@apple.com Date 2019-02-23 19:18:33 -0800 (Sat, 23 Feb 2019) Log Message Remove dead code: AdjacencyList::justOneChild() https://bugs.webkit.org/show_bug.cgi?id=194965 Reviewed by Sam Weinig. *

[webkit-changes] [242276] trunk

2019-03-01 Thread rmorisset
Title: [242276] trunk Revision 242276 Author rmoris...@apple.com Date 2019-03-01 11:24:08 -0800 (Fri, 01 Mar 2019) Log Message DFG: Loop-invariant code motion (LICM) should not hoist dead code https://bugs.webkit.org/show_bug.cgi?id=194945 Reviewed by Saam Barati. *

[webkit-changes] [241968] trunk

2019-02-22 Thread rmorisset
Title: [241968] trunk Revision 241968 Author rmoris...@apple.com Date 2019-02-22 16:05:11 -0800 (Fri, 22 Feb 2019) Log Message DFGBytecodeParser should not declare that a node won't clobberExit if DFGFixupPhase can later declare it does clobberExit

[webkit-changes] [241964] trunk/Source/JavaScriptCore

2019-02-22 Thread rmorisset
Title: [241964] trunk/Source/_javascript_Core Revision 241964 Author rmoris...@apple.com Date 2019-02-22 14:54:23 -0800 (Fri, 22 Feb 2019) Log Message B3ReduceStrength: missing peephole optimizations for binary operations https://bugs.webkit.org/show_bug.cgi?id=194252 Reviewed by Saam

[webkit-changes] [242944] trunk/Source/JavaScriptCore

2019-03-14 Thread rmorisset
Title: [242944] trunk/Source/_javascript_Core Revision 242944 Author rmoris...@apple.com Date 2019-03-14 09:41:50 -0700 (Thu, 14 Mar 2019) Log Message DFG::Worklist can be shrunk by 16 bytes https://bugs.webkit.org/show_bug.cgi?id=195490 Reviewed by Darin Adler. * dfg/DFGWorklist.cpp:

[webkit-changes] [243053] trunk/Source/JavaScriptCore

2019-03-17 Thread rmorisset
Title: [243053] trunk/Source/_javascript_Core Revision 243053 Author rmoris...@apple.com Date 2019-03-17 16:45:23 -0700 (Sun, 17 Mar 2019) Log Message ParserError can be shrunk by 8 bytes https://bugs.webkit.org/show_bug.cgi?id=195496 Reviewed by Mark Lam. * parser/ParserError.h:

[webkit-changes] [242659] trunk/Source/JavaScriptCore

2019-03-08 Thread rmorisset
Title: [242659] trunk/Source/_javascript_Core Revision 242659 Author rmoris...@apple.com Date 2019-03-08 15:24:25 -0800 (Fri, 08 Mar 2019) Log Message GetByIdStatus can be shrunk by 16 bytes https://bugs.webkit.org/show_bug.cgi?id=195480 Reviewed by Saam Barati. 8 bytes from reordering

[webkit-changes] [242657] trunk/Source/JavaScriptCore

2019-03-08 Thread rmorisset
Title: [242657] trunk/Source/_javascript_Core Revision 242657 Author rmoris...@apple.com Date 2019-03-08 15:19:27 -0800 (Fri, 08 Mar 2019) Log Message PutByIdVariant can be shrunk by 8 bytes https://bugs.webkit.org/show_bug.cgi?id=195482 Reviewed by Mark Lam. *

[webkit-changes] [242660] trunk/Source/JavaScriptCore

2019-03-08 Thread rmorisset
Title: [242660] trunk/Source/_javascript_Core Revision 242660 Author rmoris...@apple.com Date 2019-03-08 15:31:38 -0800 (Fri, 08 Mar 2019) Log Message TypeLocation can be shrunk by 8 bytes https://bugs.webkit.org/show_bug.cgi?id=195483 Reviewed by Mark Lam. * bytecode/TypeLocation.h:

[webkit-changes] [242663] trunk/Source/JavaScriptCore

2019-03-08 Thread rmorisset
Title: [242663] trunk/Source/_javascript_Core Revision 242663 Author rmoris...@apple.com Date 2019-03-08 16:17:37 -0800 (Fri, 08 Mar 2019) Log Message IntegerCheckCombiningPhase::Range can be shrunk by 8 bytes https://bugs.webkit.org/show_bug.cgi?id=195487 Reviewed by Saam Barati. *

[webkit-changes] [242672] trunk/Source/JavaScriptCore

2019-03-09 Thread rmorisset
Title: [242672] trunk/Source/_javascript_Core Revision 242672 Author rmoris...@apple.com Date 2019-03-09 09:24:16 -0800 (Sat, 09 Mar 2019) Log Message AsyncStackTrace can be shrunk by 8 bytes https://bugs.webkit.org/show_bug.cgi?id=195491 Reviewed by Mark Lam. *

[webkit-changes] [242673] trunk/Source/JavaScriptCore

2019-03-09 Thread rmorisset
Title: [242673] trunk/Source/_javascript_Core Revision 242673 Author rmoris...@apple.com Date 2019-03-09 09:25:11 -0800 (Sat, 09 Mar 2019) Log Message BinarySwitch can be shrunk by 8 bytes https://bugs.webkit.org/show_bug.cgi?id=195493 Reviewed by Mark Lam. * jit/BinarySwitch.cpp:

[webkit-changes] [242674] trunk/Source/JavaScriptCore

2019-03-09 Thread rmorisset
Title: [242674] trunk/Source/_javascript_Core Revision 242674 Author rmoris...@apple.com Date 2019-03-09 09:29:35 -0800 (Sat, 09 Mar 2019) Log Message Compilation can be shrunk by 8 bytes https://bugs.webkit.org/show_bug.cgi?id=195500 Reviewed by Mark Lam. *

[webkit-changes] [243065] trunk/Source/JavaScriptCore

2019-03-18 Thread rmorisset
Title: [243065] trunk/Source/_javascript_Core Revision 243065 Author rmoris...@apple.com Date 2019-03-18 08:29:10 -0700 (Mon, 18 Mar 2019) Log Message B3 should reduce Shl(Shr(@x, @const), @const) to BitAnd(@x, -(1<<@const)) https://bugs.webkit.org/show_bug.cgi?id=152164 Reviewed by

[webkit-changes] [243088] trunk/Source/JavaScriptCore

2019-03-18 Thread rmorisset
Title: [243088] trunk/Source/_javascript_Core Revision 243088 Author rmoris...@apple.com Date 2019-03-18 12:03:32 -0700 (Mon, 18 Mar 2019) Log Message Remove the inline capacity of Operands https://bugs.webkit.org/show_bug.cgi?id=195898 Reviewed by Yusuke Suzuki. Operands currently has

[webkit-changes] [242802] trunk/Source/JavaScriptCore

2019-03-12 Thread rmorisset
Title: [242802] trunk/Source/_javascript_Core Revision 242802 Author rmoris...@apple.com Date 2019-03-12 10:42:42 -0700 (Tue, 12 Mar 2019) Log Message blocksInPreOrder and blocksInPostOrder should reserve the right capacity for their result vector

[webkit-changes] [242812] trunk/Source

2019-03-12 Thread rmorisset
Title: [242812] trunk/Source Revision 242812 Author rmoris...@apple.com Date 2019-03-12 12:07:04 -0700 (Tue, 12 Mar 2019) Log Message A lot more classes have padding that can be reduced by reordering their fields https://bugs.webkit.org/show_bug.cgi?id=195579 Reviewed by Mark Lam.

[webkit-changes] [242825] trunk/Tools

2019-03-12 Thread rmorisset
Title: [242825] trunk/Tools Revision 242825 Author rmoris...@apple.com Date 2019-03-12 13:55:49 -0700 (Tue, 12 Mar 2019) Log Message Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding https://bugs.webkit.org/show_bug.cgi?id=195573 Reviewed by

[webkit-changes] [242717] trunk/Source/JavaScriptCore

2019-03-11 Thread rmorisset
Title: [242717] trunk/Source/_javascript_Core Revision 242717 Author rmoris...@apple.com Date 2019-03-11 10:39:35 -0700 (Mon, 11 Mar 2019) Log Message IntlCollator can be shrunk by 16 bytes https://bugs.webkit.org/show_bug.cgi?id=195503 Reviewed by Darin Adler. *

[webkit-changes] [242718] trunk/Source/JavaScriptCore

2019-03-11 Thread rmorisset
Title: [242718] trunk/Source/_javascript_Core Revision 242718 Author rmoris...@apple.com Date 2019-03-11 10:54:59 -0700 (Mon, 11 Mar 2019) Log Message IntlDateTimeFormat can be shrunk by 32 bytes https://bugs.webkit.org/show_bug.cgi?id=195504 Reviewed by Darin Adler. *

[webkit-changes] [242716] trunk/Source/JavaScriptCore

2019-03-11 Thread rmorisset
Title: [242716] trunk/Source/_javascript_Core Revision 242716 Author rmoris...@apple.com Date 2019-03-11 10:27:47 -0700 (Mon, 11 Mar 2019) Log Message IntlNumberFormat can be shrunk by 16 bytes https://bugs.webkit.org/show_bug.cgi?id=195505 Reviewed by Darin Adler. *

[webkit-changes] [243330] trunk/Source/JavaScriptCore

2019-03-21 Thread rmorisset
Title: [243330] trunk/Source/_javascript_Core Revision 243330 Author rmoris...@apple.com Date 2019-03-21 14:36:26 -0700 (Thu, 21 Mar 2019) Log Message B3::Opcode can fit in a single byte, shrinking B3Value by 8 bytes https://bugs.webkit.org/show_bug.cgi?id=196014 Reviewed by Keith

[webkit-changes] [243236] trunk/Source/JavaScriptCore

2019-03-20 Thread rmorisset
Title: [243236] trunk/Source/_javascript_Core Revision 243236 Author rmoris...@apple.com Date 2019-03-20 13:37:01 -0700 (Wed, 20 Mar 2019) Log Message DFGNodeAllocator.h is dead code https://bugs.webkit.org/show_bug.cgi?id=196019 Reviewed by Yusuke Suzuki. As explained by Yusuke on

[webkit-changes] [241126] trunk/Source/JavaScriptCore

2019-02-07 Thread rmorisset
Title: [241126] trunk/Source/_javascript_Core Revision 241126 Author rmoris...@apple.com Date 2019-02-07 10:36:36 -0800 (Thu, 07 Feb 2019) Log Message B3ReduceStrength: missing peephole optimizations for Neg and Sub https://bugs.webkit.org/show_bug.cgi?id=194250 Reviewed by Saam Barati.

[webkit-changes] [241176] trunk/Source/JavaScriptCore

2019-02-07 Thread rmorisset
Title: [241176] trunk/Source/_javascript_Core Revision 241176 Author rmoris...@apple.com Date 2019-02-07 17:01:38 -0800 (Thu, 07 Feb 2019) Log Message Fix Abs(Neg(x)) -> Abs(x) optimization in B3ReduceStrength https://bugs.webkit.org/show_bug.cgi?id=194420 Reviewed by Saam Barati. In

[webkit-changes] [241217] trunk/Source/JavaScriptCore

2019-02-08 Thread rmorisset
Title: [241217] trunk/Source/_javascript_Core Revision 241217 Author rmoris...@apple.com Date 2019-02-08 16:21:56 -0800 (Fri, 08 Feb 2019) Log Message B3LowerMacros wrongly sets m_changed to true in the case of AtomicWeakCAS on x86 https://bugs.webkit.org/show_bug.cgi?id=194460 Reviewed

[webkit-changes] [241335] trunk/Source/JavaScriptCore

2019-02-12 Thread rmorisset
Title: [241335] trunk/Source/_javascript_Core Revision 241335 Author rmoris...@apple.com Date 2019-02-12 18:30:13 -0800 (Tue, 12 Feb 2019) Log Message Make B3Value::returnsBool() more precise https://bugs.webkit.org/show_bug.cgi?id=194457 Reviewed by Saam Barati. It is currently used

[webkit-changes] [241613] trunk

2019-02-15 Thread rmorisset
Title: [241613] trunk Revision 241613 Author rmoris...@apple.com Date 2019-02-15 13:34:19 -0800 (Fri, 15 Feb 2019) Log Message [JSC] CodeBlock::jettison should clear related watchpoints https://bugs.webkit.org/show_bug.cgi?id=194544 Reviewed by Mark Lam. * bytecode/CodeBlock.cpp:

[webkit-changes] [241781] trunk/Source/JavaScriptCore

2019-02-19 Thread rmorisset
Title: [241781] trunk/Source/_javascript_Core Revision 241781 Author rmoris...@apple.com Date 2019-02-19 15:17:17 -0800 (Tue, 19 Feb 2019) Log Message CachedCall should not consider it UNLIKELY that it will not stack overflow https://bugs.webkit.org/show_bug.cgi?id=194831 Reviewed by

[webkit-changes] [241783] trunk/Source/JavaScriptCore

2019-02-19 Thread rmorisset
Title: [241783] trunk/Source/_javascript_Core Revision 241783 Author rmoris...@apple.com Date 2019-02-19 15:27:16 -0800 (Tue, 19 Feb 2019) Log Message B3-O2 incorrectly optimizes this subtest https://bugs.webkit.org/show_bug.cgi?id=194625 Reviewed by Saam Barati. Trivial fix. Instead

[webkit-changes] [241768] trunk/Source/JavaScriptCore

2019-02-19 Thread rmorisset
Title: [241768] trunk/Source/_javascript_Core Revision 241768 Author rmoris...@apple.com Date 2019-02-19 12:01:42 -0800 (Tue, 19 Feb 2019) Log Message B3ReduceStrength::simplifyCFG() could do a lot more on each iteration https://bugs.webkit.org/show_bug.cgi?id=194475 Reviewed by Saam

[webkit-changes] [240740] trunk

2019-01-30 Thread rmorisset
Title: [240740] trunk Revision 240740 Author rmoris...@apple.com Date 2019-01-30 16:49:26 -0800 (Wed, 30 Jan 2019) Log Message Object.keys can now lead to a PhantomNewArrayBuffer, OSR exit from the FTL should know how to materialize a NewArrayBuffer in that case

[webkit-changes] [240959] trunk

2019-02-04 Thread rmorisset
Title: [240959] trunk Revision 240959 Author rmoris...@apple.com Date 2019-02-04 17:36:28 -0800 (Mon, 04 Feb 2019) Log Message when lowering AssertNotEmpty, create the value before creating the patchpoint https://bugs.webkit.org/show_bug.cgi?id=194231 Reviewed by Saam Barati. JSTests:

[webkit-changes] [244222] trunk/Source/JavaScriptCore

2019-04-12 Thread rmorisset
Title: [244222] trunk/Source/_javascript_Core Revision 244222 Author rmoris...@apple.com Date 2019-04-12 11:02:20 -0700 (Fri, 12 Apr 2019) Log Message Use padding at end of ArrayBuffer https://bugs.webkit.org/show_bug.cgi?id=196823 Reviewed by Filip Pizlo. * runtime/ArrayBuffer.h:

[webkit-changes] [244286] trunk/Source/JavaScriptCore

2019-04-15 Thread rmorisset
Title: [244286] trunk/Source/_javascript_Core Revision 244286 Author rmoris...@apple.com Date 2019-04-15 13:39:11 -0700 (Mon, 15 Apr 2019) Log Message Several structures and enums in the Yarr interpreter can be shrunk https://bugs.webkit.org/show_bug.cgi?id=196923 Reviewed by Saam

[webkit-changes] [244298] trunk/Source/JavaScriptCore

2019-04-15 Thread rmorisset
Title: [244298] trunk/Source/_javascript_Core Revision 244298 Author rmoris...@apple.com Date 2019-04-15 15:06:21 -0700 (Mon, 15 Apr 2019) Log Message MarkedSpace.cpp is not in the Xcode workspace https://bugs.webkit.org/show_bug.cgi?id=196928 Reviewed by Saam Barati. *

[webkit-changes] [244309] trunk/Source/JavaScriptCore

2019-04-15 Thread rmorisset
Title: [244309] trunk/Source/_javascript_Core Revision 244309 Author rmoris...@apple.com Date 2019-04-15 16:53:23 -0700 (Mon, 15 Apr 2019) Log Message B3::Value should have different kinds of adjacency lists https://bugs.webkit.org/show_bug.cgi?id=196091 Reviewed by Filip Pizlo. The

[webkit-changes] [244313] trunk

2019-04-15 Thread rmorisset
Title: [244313] trunk Revision 244313 Author rmoris...@apple.com Date 2019-04-15 17:28:47 -0700 (Mon, 15 Apr 2019) Log Message DFG should be able to constant fold Object.create() with a constant prototype operand https://bugs.webkit.org/show_bug.cgi?id=196886 Reviewed by Yusuke Suzuki.

[webkit-changes] [244352] trunk/Source

2019-04-16 Thread rmorisset
Title: [244352] trunk/Source Revision 244352 Author rmoris...@apple.com Date 2019-04-16 12:46:27 -0700 (Tue, 16 Apr 2019) Log Message [WTF] holdLock should be marked WARN_UNUSED_RETURN https://bugs.webkit.org/show_bug.cgi?id=196922 Reviewed by Keith Miller. Source/_javascript_Core:

[webkit-changes] [246524] trunk/Source/WebCore

2019-06-17 Thread rmorisset
Title: [246524] trunk/Source/WebCore Revision 246524 Author rmoris...@apple.com Date 2019-06-17 17:06:17 -0700 (Mon, 17 Jun 2019) Log Message [WHLSL] The name resolver does not deal with nativeFunctionDeclaration https://bugs.webkit.org/show_bug.cgi?id=198306 Reviewed by Saam Barati.

[webkit-changes] [246520] trunk/Source/WebCore

2019-06-17 Thread rmorisset
Title: [246520] trunk/Source/WebCore Revision 246520 Author rmoris...@apple.com Date 2019-06-17 16:07:32 -0700 (Mon, 17 Jun 2019) Log Message [WHLSL] Remove backtracking from parseAttributeBlock https://bugs.webkit.org/show_bug.cgi?id=198934 Reviewed by Myles C. Maxfield. No functional

[webkit-changes] [245192] trunk/Source/JavaScriptCore

2019-05-10 Thread rmorisset
Title: [245192] trunk/Source/_javascript_Core Revision 245192 Author rmoris...@apple.com Date 2019-05-10 13:37:07 -0700 (Fri, 10 May 2019) Log Message testb3 failing with crash in JSC::B3::BasicBlock::appendNonTerminal https://bugs.webkit.org/show_bug.cgi?id=197756 Reviewed by Saam

[webkit-changes] [245302] trunk/Source/WebCore

2019-05-14 Thread rmorisset
Title: [245302] trunk/Source/WebCore Revision 245302 Author rmoris...@apple.com Date 2019-05-14 13:35:32 -0700 (Tue, 14 May 2019) Log Message [WHLSL] parseEffectfulAssignment should not call parseCallExpression directly https://bugs.webkit.org/show_bug.cgi?id=197890 Reviewed by Myles

[webkit-changes] [245271] trunk/Source/WTF

2019-05-13 Thread rmorisset
Title: [245271] trunk/Source/WTF Revision 245271 Author rmoris...@apple.com Date 2019-05-13 20:38:13 -0700 (Mon, 13 May 2019) Log Message IndexSet::isEmpty should use BitVector::isEmpty() instead of size() https://bugs.webkit.org/show_bug.cgi?id=197857 Reviewed by Darin Adler. *

[webkit-changes] [245312] trunk/Source/WebCore

2019-05-14 Thread rmorisset
Title: [245312] trunk/Source/WebCore Revision 245312 Author rmoris...@apple.com Date 2019-05-14 14:49:54 -0700 (Tue, 14 May 2019) Log Message [WHLSL] parseEffectfulSuffix() is never called https://bugs.webkit.org/show_bug.cgi?id=195864 Reviewed by Myles C. Maxfield. The fix is

[webkit-changes] [244708] trunk

2019-04-26 Thread rmorisset
Title: [244708] trunk Revision 244708 Author rmoris...@apple.com Date 2019-04-26 15:21:25 -0700 (Fri, 26 Apr 2019) Log Message All prototypes should call didBecomePrototype() https://bugs.webkit.org/show_bug.cgi?id=196315 Reviewed by Saam Barati. JSTests: *

[webkit-changes] [245035] trunk/Source/JavaScriptCore

2019-05-07 Thread rmorisset
Title: [245035] trunk/Source/_javascript_Core Revision 245035 Author rmoris...@apple.com Date 2019-05-07 14:28:38 -0700 (Tue, 07 May 2019) Log Message [B3] Constants should be hoisted to the root block until moveConstants https://bugs.webkit.org/show_bug.cgi?id=197265 Reviewed by Saam

[webkit-changes] [245030] trunk/Source

2019-05-07 Thread rmorisset
Title: [245030] trunk/Source Revision 245030 Author rmoris...@apple.com Date 2019-05-07 13:46:43 -0700 (Tue, 07 May 2019) Log Message WTF::BitVector should have an isEmpty() method https://bugs.webkit.org/show_bug.cgi?id=197637 Reviewed by Keith Miller. Source/_javascript_Core: Just

[webkit-changes] [245031] trunk

2019-05-07 Thread rmorisset
Title: [245031] trunk Revision 245031 Author rmoris...@apple.com Date 2019-05-07 13:59:44 -0700 (Tue, 07 May 2019) Log Message All prototypes should call didBecomePrototype() https://bugs.webkit.org/show_bug.cgi?id=196315 Reviewed by Saam Barati. JSTests: *

[webkit-changes] [245061] trunk/Source/WTF

2019-05-08 Thread rmorisset
Title: [245061] trunk/Source/WTF Revision 245061 Author rmoris...@apple.com Date 2019-05-08 11:18:42 -0700 (Wed, 08 May 2019) Log Message WTF::TimingScope should show the total duration and not just the mean https://bugs.webkit.org/show_bug.cgi?id=197672 Reviewed by Alex Christensen. *

[webkit-changes] [247170] trunk/Source/WebCore

2019-07-05 Thread rmorisset
Title: [247170] trunk/Source/WebCore Revision 247170 Author rmoris...@apple.com Date 2019-07-05 13:09:39 -0700 (Fri, 05 Jul 2019) Log Message [WHLSL] Remove the phase resolveCallsInFunctions https://bugs.webkit.org/show_bug.cgi?id=199474 Reviewed by Myles Maxfield. This pass only

[webkit-changes] [247171] trunk/Source/WebCore

2019-07-05 Thread rmorisset
Title: [247171] trunk/Source/WebCore Revision 247171 Author rmoris...@apple.com Date 2019-07-05 13:10:36 -0700 (Fri, 05 Jul 2019) Log Message [WHLSL] Optimize the lexer https://bugs.webkit.org/show_bug.cgi?id=199520 Reviewed by Myles Maxfield. This patch includes a number of small

[webkit-changes] [247189] trunk/Source/WebCore

2019-07-05 Thread rmorisset
Title: [247189] trunk/Source/WebCore Revision 247189 Author rmoris...@apple.com Date 2019-07-05 17:33:01 -0700 (Fri, 05 Jul 2019) Log Message [WHLSL] The checker does not need to keep a separate m_typeAnnotations map https://bugs.webkit.org/show_bug.cgi?id=199537 Reviewed by Myles C.

[webkit-changes] [247339] trunk/Source/WebCore

2019-07-10 Thread rmorisset
Title: [247339] trunk/Source/WebCore Revision 247339 Author rmoris...@apple.com Date 2019-07-10 18:18:14 -0700 (Wed, 10 Jul 2019) Log Message [WHLSL] The recursion checker should not have quadratic complexity https://bugs.webkit.org/show_bug.cgi?id=199688 Reviewed by Saam Barati. I fix

[webkit-changes] [247341] trunk/Source/WebCore

2019-07-10 Thread rmorisset
Title: [247341] trunk/Source/WebCore Revision 247341 Author rmoris...@apple.com Date 2019-07-10 19:09:52 -0700 (Wed, 10 Jul 2019) Log Message [WHLSL] Optional> -> std::unique_ptr in Return/IfStatement/ForLoop https://bugs.webkit.org/show_bug.cgi?id=199695 Reviewed by Dean Jackson.

  1   2   >