Re: [webkit-dev] maybe_unused vs UNUSED_PARAM

s of attributes like [[noreturn]], [[fallthrough]], and >> [[likely]]? Are we gonna start writing them directly in code, or are we >> gonna continue to use macros? >> >> - R. NIwa >> >>> On Jan 24, 2024, at 9:49 AM, Chris Dumez via webkit-dev >>> w

Re: [webkit-dev] maybe_unused vs UNUSED_PARAM

Hi, Thanks for starting this discussion. I personally think it would be nice for us to switch to [[maybe_unused]] since it is now part of the language and it seems to fit our needs. However, I do think we should be consistent and stop using UNUSED_PARAM() / ASSERT_UNUSED() in new code

[webkit-dev] Stricter type checking in downcast<>()

in our codebase is when using a switch statement based on the type: ``` switch (node.nodeType()) { case Node::DOCUMENT_TYPE_NODE: uncheckedDowncast(node)->foo(); ``` Please let me know if you have any concerns / questions. Cheers, Chris

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

> On Nov 28, 2023, at 4:06 PM, Jean-Yves Avenard > wrote: > > Hi > >> On 29 Nov 2023, at 9:44 am, Chris Dumez via webkit-dev >> wrote: >> >> FYI, our official documentation on WebKit.org <http://webkit.org/> says: >> ``` >&g

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

t; On Nov 28, 2023, at 1:58 PM, Michael Catanzaro wrote: > > On Tue, Nov 28 2023 at 01:23:12 PM -0800, Chris Dumez via webkit-dev > wrote: >> I´m on board if it also cancels PR rejections from non-reviewers, not just >> approvals. I don´t see how approvals differ from rej

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

> On Nov 28, 2023, at 11:51 AM, Michael Catanzaro wrote: > > On Tue, Nov 28 2023 at 10:27:41 AM -0800, Chris Dumez via webkit-dev > wrote: >> The reason I would like us to make enforce this rule is that I find it >> confusing. We have a lot of new comers in the pro

[webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

know. What do you think? Thanks, Chris Dumez. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Removal of trailing whitespace

y has been to not do this: >>> https://lists.webkit.org/pipermail/webkit-dev/2009-August/009665.html >>> >>> I don’t think we should change that. >>> >>> - R. Niwa >>> >>>> On Apr 12, 2023, at 9:17 AM, Chris Dumez via webkit

Re: [webkit-dev] Removal of trailing whitespace

I am against this because it adds a lot of noise to patches I am trying to review. I have seen PRs where white space changes account for more than half the patch I am trying to review. Dropping trailing spaces on the lines you’re modifying is OK but in the whole file is too noisy IMO. Chris.

Re: [webkit-dev] Unsigned to avoid negative values

Hi, What’s the benefit? I don’t think we should be changing our long-time coding practices unless there are clear benefits from doing so. From your email, it is not yet clear to me what those benefits would be. Chris. > On Jan 24, 2023, at 6:58 AM, Michael Catanzaro via webkit-dev > wrote: >

Re: [webkit-dev] Style guide: enforce `while (true)` over `for (; ; )`

Sounds good to me.Chris DumezOn Oct 5, 2022, at 9:04 PM, Kirsling, Ross via webkit-dev wrote: I've always kind of liked that `for (;;)` doesn't involve an explicit constant, but I too like consistency even more. :) From: Ryosuke Niwa via webkit-dev Sent: Thursday, October 6, 2022 1:01:01

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

> On Jun 2, 2022, at 6:29 PM, Michael Catanzaro wrote: > > > > On Thu, Jun 2 2022 at 04:06:42 PM -0700, Chris Dumez via webkit-dev > wrote: >> I am concerned by this proposal given how slow EWS and the merge queue are >> these days. > > Hopefull

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

with the move to GitHub and development speed will suffer as a result. Chris Dumez > On Jun 2, 2022, at 3:41 PM, Geoffrey Garen via webkit-dev > wrote: > >  >> As we move to GitHub, I would like to propose we strengthen our protections >> on `main` by making MergeQueue a

Re: [webkit-dev] Add CODEOWNERS to WebKit

I’m kind of ambivalent/neutral about this. One question though: When adopting CODEOWNERS, will our existing watchlists get ported, or will each contributor have to modify CODEOWNERS themselves to match whatever was in the watchlists for them? Thanks, Chris. > On Jun 2, 2022, at 1:12 PM,

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

> On May 11, 2022, at 11:56 AM, Jonathan Bedard via webkit-dev > wrote: > > Trying to embed previous replies is going to get messy, will be referencing > those replies but not embedding them. > > Unsafe-Merge-Queue should be very fast, I haven’t seen anything take longer > than 10 minutes

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

> On May 11, 2022, at 12:13 AM, Ryosuke Niwa via webkit-dev > wrote: > > On Tue, May 10, 2022 at 9:27 PM Ryosuke Niwa wrote: >> >> >> On Tue, May 10, 2022 at 20:36 Chris Dumez wrote: >>> >>> [Not sure why Apple Mail sent Ryosuke’s repli

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

[Not sure why Apple Mail sent Ryosuke’s replies to the Junk folder but I finally noticed.] > On May 10, 2022, at 3:04 PM, Ryosuke Niwa via webkit-dev > wrote: > > On Tue, May 10, 2022 at 3:01 PM Jonathan Bedard via webkit-dev > wrote: >> >>> On May 10, 2022, at 2:46 PM, Geoffrey Garen

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

Hi, I think this is a step in the right direction. I hope concerns from other contributors about change log reviews can be addressed in the near future. However, I don’t think it should prevent us from moving away from ChangeLog files, given that commenting on commit logs is still possible in

Re: [webkit-dev] ChangeLog Deprecation Plans

message a bit easier on GitHub. I support Yusuke’s proposal. It is a bit more flexible and it still means that separate full/history ChangeLog files would be a thing of the past. --  Chris Dumez > On Apr 22, 2022, at 2:10 PM, Chris Dumez via webkit-dev > wrote: > > I am stron

Re: [webkit-dev] ChangeLog Deprecation Plans

`, it will upload to the wrong bugzilla bug. If people really still want to maintain separate ChangeLog files, I am hoping this can be generated from my commit messages and done automatically for me upon committing. I really don’t want that as part of my patch/PR. --  Chris Dumez > On Apr

Re: [webkit-dev] How to make changes to website?

Jon Davis is probably the right contact for Webkit.org <http://webkit.org/>. --  Chris Dumez > On Feb 16, 2022, at 2:01 PM, Michael Catanzaro via webkit-dev > wrote: > > Hi, > > I want to make a modification to: > > https://webkit.org/contributing-co

Re: [webkit-dev] How to set up Intellisense-ish code completion/suggestions for editing WebKit sources on macOS?

may take a couple of minutes). --  Chris Dumez > On Nov 11, 2021, at 7:49 AM, Patrick Griffis via webkit-dev > wrote: > > On 2021-11-11 02:48, Michael[tm] Smith via webkit-dev wrote: >> Can anyone recommend a combination of text-editor/IDE, plugins/tooling >> (e.g

[webkit-dev] Removal of makeRef() / makeRefPtr()

d when they try to use makeRef() / makeRefPtr() in new code. --  Chris Dumez ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Request for position: Cryptographically secure random UUIDs

I forgot to follow-up on this email, sorry. Support for this landed via https://bugs.webkit.org/show_bug.cgi?id=229240 <https://bugs.webkit.org/show_bug.cgi?id=229240>. --  Chris Dumez > On Apr 10, 2021, at 7:00 PM, Benjamin Coe via webkit-dev > wrote: > >

Re: [webkit-dev] Request for position on self.reportError()

It doesn’t seem like a controversial feature to me and it is indeed a fairly small amount of work to support. I am working on it via Bug 228316 <https://bugs.webkit.org/show_bug.cgi?id=228316>. --  Chris Dumez > On Aug 27, 2021, at 1:58 PM, Domenic Denicola via webkit-dev

Re: [webkit-dev] Moving from WTF::Optional to std::optional

make sure to use std::exchange() instead of WTFMove() if you want to leave to std::optional in a clean state for reuse later. Chris Dumez > On Jun 1, 2021, at 8:54 PM, Darin Adler via webkit-dev > wrote: > > Hi folks. > > We’re getting rid of the WTF::Optional class templat

Re: [webkit-dev] Clang Thread Safety Analysis

Hi, Just a quick follow-up to let you know that both CheckedLock/CheckedCondition and UncheckedLock/UncheckedCondition have been removed from the tree. The whole codebase has been ported to Lock/Condition, which have the thread safety analysis annotations. --  Chris Dumez > On May

[webkit-dev] Clang Thread Safety Analysis

its to Kimmo for introducing the checked Lock to WebKit and helping with the adoption! Big thanks to everyone who helped with reviews and feedback as well. --  Chris Dumez ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

> On Nov 2, 2019, at 7:38 PM, Ryosuke Niwa wrote: > >  > >> On Sat, Nov 2, 2019 at 1:23 AM Antti Koivisto wrote: >> >>> On Sat, Nov 2, 2019 at 1:38 AM Ryosuke Niwa wrote: On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro wrote: >>> On Fri, Nov 1, 2019 at 11:19 am,

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

I mildly prefer without the space :) --  Chris Dumez > On Nov 1, 2019, at 11:19 AM, Ryosuke Niwa wrote: > > Hi all, > > There seems to be inconsistency in our coding style with regards to spacing > in lambdas. > > Namely, some people wri

Re: [webkit-dev] 2019 WebKit Contributors Meeting - Registration is Open

Did not work for me either, got a page with text “None” shortly after logging in. --  Chris Dumez > On Sep 18, 2019, at 2:12 PM, > wrote: > > Seems like the login form isn't working—I see: > > MultipleObjectsReturned at /auth/wlogin/ > get() returned

Re: [webkit-dev] IPC implementation help in haiku's webkit port

Alex is likely right that you are ending up with some kind of IPC deadlock since the IPC is synchronous. But also, > On May 27, 2019, at 11:49 PM, Rajagopalan Gangadharan > wrote: > > > Please check the source references for more info: > NetworkProcessProxy: [ >

Re: [webkit-dev] Crash When Running run-safari

Bug 196777 <https://bugs.webkit.org/show_bug.cgi?id=196777> will fix this. --  Chris Dumez > On Apr 10, 2019, at 10:54 AM, Chris Dumez wrote: > > Yes, this commit broke it: http://trac.webkit.org/r243320 > <http://trac.webkit.org/r243320> > > -- >  Chr

Re: [webkit-dev] Crash When Running run-safari

Yes, this commit broke it: http://trac.webkit.org/r243320 <http://trac.webkit.org/r243320> --  Chris Dumez > On Apr 10, 2019, at 10:47 AM, Assaf Inbal wrote: > > Thanks for the update! > Since I don’t really need the bleeding-edge, can you tell me which tag/commit >

Re: [webkit-dev] Crash When Running run-safari

Oh, I am responsible for this. This is due to an incompatibility between the very recent WebKit you built and the older system’s Safari. I will look into fixing this shortly, thanks for letting me know. --  Chris Dumez > On Apr 10, 2019, at 4:44 AM, Assaf Inbal wrote: > > Hey,

Re: [webkit-dev] Code Style: Opinion on returning void

0, 2019, at 7:48 AM, Daniel Bates >> <mailto:dba...@webkit.org>> wrote: >>> >>> Thanks for the opinion! >>> >>> Dan >>> >>> On Feb 20, 2019, at 7:26 AM, Saam Barati >> <mailto:sbar...@apple.com>> wrote: >>> &g

Re: [webkit-dev] Code Style: Opinion on returning void

that we should not allow this pattern. Therefore, I was also surprised by your email saying that we’d reached a consensus. > > Dan > > On Feb 20, 2019, at 6:58 AM, Chris Dumez <mailto:cdu...@apple.com>> wrote: > >> I also prefer allowed returning void. >&g

Re: [webkit-dev] Code Style: Opinion on returning void

I also prefer allowed returning void. Chris Dumez > On Feb 19, 2019, at 10:35 PM, Daniel Bates wrote: > > > >> On Feb 19, 2019, at 9:42 PM, Ryosuke Niwa wrote: >> >>> On Tue, Feb 19, 2019 at 8:59 PM Daniel Bates wrote: >> >>> &g

Re: [webkit-dev] Code Style: Opinion on returning void

Same here, I used it in PSON code with completion handlers. I liked the more concise code but I also do not feel strongly about it. The extra return line often would have meant adding curly brackets for if statements leading to early returns. Chris Dumez > On Feb 7, 2019, at 8:23 PM, Za

Re: [webkit-dev] Rename AtomicString to AtomString

Fine by me. --  Chris Dumez > On Jan 30, 2019, at 9:35 AM, Antti Koivisto wrote: > > Sounds good to me. > > > antti > > On Wed, Jan 30, 2019 at 6:33 PM Darin Adler <mailto:da...@apple.com>> wrote: > So, did we reach consensus that we shou

Re: [webkit-dev] the name "AtomicString"

> On Dec 19, 2018, at 9:41 PM, Chris Dumez wrote: > >> >> On Dec 19, 2018, at 9:17 PM, Maciej Stachowiak > <mailto:m...@apple.com>> wrote: >> >> >> >>> On Dec 19, 2018, at 8:06 PM, Ryosuke Niwa >> <mailto:rn...@webkit.

Re: [webkit-dev] the name "AtomicString"

> On Dec 19, 2018, at 9:17 PM, Maciej Stachowiak wrote: > > > >> On Dec 19, 2018, at 8:06 PM, Ryosuke Niwa > > wrote: >> >> On Wed, Dec 19, 2018 at 1:13 PM Simon Fraser > > wrote: >> > On Dec 19, 2018, at 12:33 PM, Michael Catanzaro > >

Re: [webkit-dev] Watch out for std::optional's move constructor

;> On Dec 17, 2018, at 12:50 PM, Alex Christensen >> <mailto:achristen...@apple.com>> wrote: >>> >>> This one and the many others like it are fragile, relying on undefined >>> behavior, and should be replaced by std::exchange. Such a change was made

Re: [webkit-dev] Watch out for std::optional's move constructor

> On Dec 17, 2018, at 11:10 AM, Chris Dumez wrote: > > > >> On Dec 17, 2018, at 10:27 AM, Alex Christensen > <mailto:achristen...@apple.com>> wrote: >> >>>>>> On Dec 14, 2018, at 1:37 PM, Chris Dumez >>>>> <mail

Re: [webkit-dev] Watch out for std::optional's move constructor

> On Dec 17, 2018, at 10:27 AM, Alex Christensen wrote: > >>>>> On Dec 14, 2018, at 1:37 PM, Chris Dumez >>>> <mailto:cdu...@apple.com>> wrote: >>>> >>>>> >>>>> As far as I know, our convention in WebKit s

Re: [webkit-dev] Watch out for std::optional's move constructor

> On Dec 16, 2018, at 7:43 PM, Fujii Hironori wrote: > > I don't like the proposal because it encourages misuse of move. > We can use move only for values about to be destroyed. Just for reference, there are close to 400 matches for "WTFMove(m_” in our code base. People do seem to rely on the

Re: [webkit-dev] Watch out for std::optional's move constructor

So to be clear, it is often not truly about using the value after it is moved. It is about expecting that the variable / member has been nulled out after moving it. If I WTFMove() out a data member m_dataMember, I expect later on `if (m_dataMember)` to be false. --  Chris Dumez > On

Re: [webkit-dev] Watch out for std::optional's move constructor

> On Dec 14, 2018, at 3:39 PM, Fujii Hironori wrote: > > > On Sat, Dec 15, 2018 at 6:38 AM Chris Dumez <mailto:cdu...@apple.com>> wrote: > > I have now been caught twice by std::optional’s move constructor. > > I don't understand how this could be use

Re: [webkit-dev] Watch out for std::optional's move constructor

> On Dec 14, 2018, at 1:56 PM, Saam Barati wrote: > > > >> On Dec 14, 2018, at 1:54 PM, Saam Barati > <mailto:sbar...@apple.com>> wrote: >> >> >> >>> On Dec 14, 2018, at 1:37 PM, Chris Dumez >> <mailto:cdu...@apple.com&

[webkit-dev] Watch out for std::optional's move constructor

“empty” state. As such, I find that std::optional’s move constructor behavior is error-prone. I’d like to know how do other feel about this behavior? If enough people agree this is error-prone, would we consider having our own optional type in WTF which resets the engaged flag (and ne

Re: [webkit-dev] PSA: String shouldn't be a member of a ThreadSafeRefCounted class

m_impl ? m_impl->isolatedCopy() : String { }; } The isolatedCopy() optimization (i.e. isSafeToSendToAnotherThread) can only be used if the String is a temporary. If you example, m_name is not a temporary and will be deep copied. --  Chris Dumez > On Feb 23, 2018, at 11:45 PM, Ryosuke Niwa <

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

> On Nov 17, 2017, at 9:18 AM, youenn fablet wrote: > > Chris recently noticed that some heavily used files (testharness*) were > cacheable through Apache but not WPT. Wasn’t me. Alexey reported this via Description

Re: [webkit-dev] buildbot / ios-sim failing on serviceworket tests?

These are likely flaky tests, unrelated to your change. --  Chris Dumez > On Nov 6, 2017, at 5:38 AM, Colin Bendell | +1.613.914.3387 > <co...@bendell.ca> wrote: > > Can someone provide guidance on how I should interpret serviceworker > failures on the ios-sim que

Re: [webkit-dev] Get rid of RefPtr, replace with std::optional?

ould be a nice way to do so. Finally, the storage space argument from Maciej is a good one. --  Chris Dumez > On Sep 1, 2017, at 9:46 AM, Maciej Stachowiak <m...@apple.com> wrote: > > > >> On Sep 1, 2017, at 9:30 AM, Brady Eidson <beid...@apple.com> wrote: >

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

ifferent behavior because we end up calling a different overload. This would seem very risky for a big project such as WebKit. --  Chris Dumez ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

-resolving dependencies so much. --  Chris Dumez > On Aug 29, 2017, at 9:05 AM, Darin Adler <da...@apple.com> wrote: > >> On Aug 28, 2017, at 8:34 PM, Ryosuke Niwa <rn...@webkit.org >> <mailto:rn...@webkit.org>> wrote: >> >>> Wherever po

Re: [webkit-dev] Unified source builds: A new rule for static variables

I indeed think this will require “using” statements or explicit namespace at call sites. I don’t think anonymous namespaces are suitable for resolving naming conflicts due to unity builds since the functions and up in the same compilation unit. --  Chris Dumez > On Aug 29, 2017, at 9

Re: [webkit-dev] How we enable template functions

I personally prefer std::enable_if<>. For e.g. template::value> Class Foo { } I don’t like that something inside the body of a class / function would cause a template to be enabled or not. --  Chris Dumez > On Aug 22, 2017, at 8:34 PM, Keith Miller <keith_mil...@a

Re: [webkit-dev] Does someone know how to fix WTF::Function on Windows

I seem to remember I fixed it last time by calling the WTF::Function constructor explicitly. Chris Dumez > On Jul 15, 2017, at 9:14 AM, Yusuke SUZUKI <utatane@gmail.com> wrote: > > I'm not 100% confident, but can you try it `` instead? > > Regards, > Yusuke Suz

Re: [webkit-dev] Should we ever use std::function instead of WTF::Function?

subclass that just asserts that it has been called >> once. That would’ve prevented some bugs, too, but not every use of >> WTF::Function has such a requirement. >> >>> On Jun 13, 2017, at 12:31 PM, Chris Dumez <cdu...@apple.com >>> <mailto:cdu

Re: [webkit-dev] Should we ever use std::function instead of WTF::Function?

We already have BlockPtr for passing a Function as a lambda block. Chris Dumez > On Jun 13, 2017, at 12:29 PM, Alex Christensen <achristen...@apple.com> wrote: > > std::function, c++ lambda, and objc blocks are all interchangeable. > WTF::Functions cannot be used as o

Re: [webkit-dev] Should we ever use std::function instead of WTF::Function?

in WebCore since we actually very rarely need copying (either it just builds or the code can be refactored very slightly to avoid the copying). --  Chris Dumez > On Jun 13, 2017, at 9:34 AM, Filip Pizlo <fpi...@apple.com> wrote: > > We should have a better story here. Right now t

Re: [webkit-dev] Should we ever use std::function instead of WTF::Function?

base but there are still a lot of uses of std::function. --  Chris Dumez > On Jun 13, 2017, at 9:24 AM, Darin Adler <da...@apple.com> wrote: > > I’ve noticed many patches switching us from std::function to WTF::Function > recently, to fix problems with copying and thread saf

Re: [webkit-dev] "ReflectOnly" IDL equivalent

> On Jun 9, 2017, at 11:47 AM, Sam Weinig <wei...@apple.com> wrote: > > > >> On Jun 2, 2017, at 11:32 AM, Ryosuke Niwa <rn...@webkit.org> wrote: >> >> On Fri, Jun 2, 2017 at 9:18 AM, Chris Dumez <cdu...@apple.com> wrote: >>> Hi,

Re: [webkit-dev] "ReflectOnly" IDL equivalent

could also consider adding support for something like ReflectOnly in our bindings generator considering that this seems to be used quite a bit in the HTML specification and it would decrease code complexity a little. I’d actually be in favor of that. --  Chris Dumez > On Jun 1, 2017, at

Re: [webkit-dev] Another WPT bite

ones) and it is not necessarily obvious just by looking at the test. --  Chris Dumez > On May 12, 2017, at 2:10 PM, Simon Fraser <simon.fra...@apple.com> wrote: > >> >> On May 12, 2017, at 12:04 PM, Alexey Proskuryakov <a...@webkit.org >> <mailto:a...@we

Re: [webkit-dev] Another WPT bite

> On May 8, 2017, at 9:44 PM, Geoffrey Garen wrote: > >> Is it time to make testharness.js the recommended way of writing LayoutTests? > > What are the costs and benefits of testharness.js? Benefit: - Tests would be more easily upstreamable to web-platform-tests, which are

Re: [webkit-dev] !!Tests for equality comparison

sEmpty()) looks even better :) --  Chris Dumez ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] !!Tests for equality comparison

I also do not like this rule when it comes to integers. I personally think JF’s proposal to allow == 0 sounds nice. I don’t think JF was suggesting rewriting existing code (which would indeed cause a lot of churn). --  Chris Dumez > On Apr 27, 2017, at 4:30 PM, Geoffrey Garen &

Re: [webkit-dev] bugs.webkit.org - Maintenance: 10.00 - 11.00am

Any update? It’s been a few minutes :) --  Chris Dumez > On Mar 30, 2017, at 9:55 AM, Ling Ho <lin...@apple.com> wrote: > > Hello WebKit developers, > > We are flipping a switch to restart bugs.webkit.org on a new server between > 10-11am this morning. There shou

[webkit-dev] Bugzilla down?

Bugzilla seems down for me. I am getting certificate errors: --  Chris Dumez ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] SVN trouble

It also seems bugzilla mail notifications may be down. Chris Dumez > On Feb 25, 2017, at 8:40 AM, Simon Fraser <simon.fra...@apple.com> wrote: > > EWS is still down. Do we have an ETA? > > Simon > >>> On Feb 24, 2017, at 10:25 PM, Alexey Proskuryakov <a...

Re: [webkit-dev] SVN trouble

like EWS is still down. Did it break again or is it just not fixed yet? --  Chris Dumez ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] SVN trouble

ow is that > someone committed to trunk, and thus invoked post-commit hooks. Yes, I confirm manual commits work now :) --  Chris Dumez ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Upstreaming Tests from WebKit to Web Platform Tests

not advocating we use testharness.js for everything (although I would be OK with this). I propose we make it opt-in. We have a lot of tests that are not necessarily interesting to upstream. However, the ones that are, using testharness.js makes a lot of sense. Chris Dumez > On Feb 5, 2017, at 5

Re: [webkit-dev] [webkit-reviewers] usage of auto

in the case where maximum() returns an integer but checks if the value is set in the case the function returns an std::optional. Chris Dumez On Jan 10, 2017, at 9:51 PM, Darin Adler <da...@apple.com> wrote: >> On Jan 10, 2017, at 9:49 PM, Darin Adler <da...@apple.com> wrote: >&

[webkit-dev] Can no longer commit manually or via CQ?

e --skip" instead. To check out the original branch and stop rebasing, run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2661. Kr, --  Chris Dumez _

Re: [webkit-dev] Removing ENABLE(DATA_TRANSFER_ITEMS)

work on enabling this feature rather than removing it? Kr, --  Chris Dumez > On Dec 21, 2015, at 10:02 PM, Gyuyoung Kim <gyuyoung@webkit.org> wrote: > > Hello, > > It looks like no ports have used a data transfer items feature. Even the > feature hasn't been updat

[webkit-dev] [Proposal] Remove support for 'multipart/x-mixed-replace' main resources

://src.chromium.org/viewvc/blink?view=revisionrevision=152363 Kr, --  Chris Dumez - Apple Inc. - Cupertino, CA ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Safari browser on Mac OSX complains AudioContext.createMediaStreamSource is undefined !

Jer or Eric would know more about this but AudioContext.createMediaStreamSource() is behind a MEDIA_STREAM compile-time flag. It appears the mac port does not turn this flag on so Safari does not currently support the Media Stream API. Kr, --  Chris Dumez - Apple Inc. - Cupertino, CA

[webkit-dev] run-webkit-tests and run-perf-tests scripts now use WebKitTestRunner by default

to these scripts. Kr, --  Chris Dumez - Apple Inc. - Cupertino, CA [1] https://trac.webkit.org/r181093 https://trac.webkit.org/r181093___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Pattern for singleton classes instance getters

Hi, I made the changes in: http://trac.webkit.org/changeset/179401 http://trac.webkit.org/changeset/179409 Kr, -- Chris Dumez - Apple Inc. Cupertino, CA On Jan 29, 2015, at 10:23 AM, Chris Dumez cdu...@apple.com wrote: Hi all, Thanks for the feedback. I submitted a coding style

Re: [webkit-dev] Pattern for singleton classes instance getters

code unless there is any objection. Kr, -- Chris Dumez - Apple Inc. Cupertino, CA On Jan 28, 2015, at 9:26 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Jan 28, 2015 at 9:19 PM, Maciej Stachowiak m...@apple.com mailto:m...@apple.com wrote: This may be a question of what jargon we’ve

Re: [webkit-dev] Pattern for singleton classes instance getters

Yes, instance() is what I’ve seen mostly outside WebKit as well. This would be my preference. Kr, -- Chris Dumez - Apple Inc. Cupertino, CA On Jan 28, 2015, at 8:44 PM, Michael Catanzaro mcatanz...@igalia.com wrote: On Wed, Jan 28, 2015 at 8:11 PM, Maciej Stachowiak m...@apple.com wrote

Re: [webkit-dev] Pattern for singleton classes instance getters

Fair enough, singleton() is very explicit indeed. I would be happy with this naming too. -- Chris Dumez - Apple Inc. Cupertino, CA On Jan 28, 2015, at 9:19 PM, Maciej Stachowiak m...@apple.com wrote: This may be a question of what jargon we’ve encountered, but to me, “singleton clearly

[webkit-dev] Pattern for singleton classes instance getters

thought I would email webkit-dev to make sure this is actually the case and make sure we agree on a given pattern (one way or another) for current and future code. We could then maybe document this as part of our coding style. Any feedback on this matter? Kr, -- Chris Dumez - Apple Inc. Cupertino

Re: [webkit-dev] EFL EWS bot failures

FYI, this still seems to be happening: https://webkit-queues.appspot.com/results/6182699735711744 Kr, -- Chris Dumez - Apple Inc. Cupertino, CA On Jan 9, 2015, at 6:55 AM, Gyuyoung Kim gyuyoung@webkit.org wrote: Hello Ossy, Now I'm running two machines for EFL EWS and buildbot

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

The corresponding Blink bug did contain some performance data: CrBug#229226 https://code.google.com/p/chromium/issues/detail?id=229226 Kr, -- Chris Dumez - Apple Inc. Cupertino, CA On Nov 20, 2014, at 11:32 AM, Geoffrey Garen gga...@apple.com wrote: I wonder what the downsides

[webkit-dev] size_t vs unsigned in WTF::Vector API ?

that this change was controversial, but now that it seems it is, I thought I would raise the question on webkit-dev to see what people think about this. Kr, -- Chris Dumez - Apple Inc. Cupertino, CA [1] http://trac.webkit.org/changeset/176275 http://trac.webkit.org/changeset/176275 [2] http

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

Hi, I believe the Vector class is already checking for overflows. I looked quickly and it seems that when trying to allocate / reallocate the Vector buffer, we will call CRASH() if: (newCapacity std::numeric_limitsunsigned::max() / sizeof(T)) Kr, -- Chris Dumez - Apple Inc. Cupertino, CA

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

If we don’t want to crash on overflow, the callers can use the try*() API I believe (e.g. tryAppend()). This returns false (and does not resize the vector) instead of crashing, when we reach the size limit. Kr, -- Chris Dumez - Apple Inc. Cupertino, CA On Nov 19, 2014, at 2:58 PM, Alexey

[webkit-dev] Transition to is() / downcast() is complete

be nice IMHO. Kr, -- Chris Dumez - Apple Inc. Cupertino, CA ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Behavior change: is(T*) is now doing a null check on the pointer argument

build error (instead of the obscure linking error we would get previously). Kr, -- Chris Dumez - Apple Inc. Cupertino, CA [1] http://trac.webkit.org/changeset/174225 http://trac.webkit.org/changeset/174225___ webkit-dev mailing list webkit-dev

[webkit-dev] Type checking / casting helpers

type check” / “Unnecessary type cast” static assertion. Also note that the plan is to get rid of TYPE_CAST_BASE() macro entirely and extend is() / downcast() to all types, not just Nodes. Kr, -- Chris Dumez - Apple Inc. Cupertino, CA ___ webkit-dev