Re: [webkit-dev] JIT probe mechanism soon required for DFG and FTL OSR Exit

2017-07-19 Thread Konstantin Tokarev
19.07.2017, 02:49, "Mark Lam" : > FYI, I’m looking into making OSR exits work in a more memory efficient way > using the JIT probe mechanism.  Once we make this transition, the DFG and FTL > will not work for any CPU targets that don’t support the JIT probe mechanism. >  The API to the JIT pro

Re: [webkit-dev] WebKit build

2017-07-14 Thread Konstantin Tokarev
14.07.2017, 17:00, "Nagendra K" : > Hi All > > Is it possible to build WebKit without any port? No. > I want to add custom port above that step by step and check. > I saw the build-webkit Script which gives "--only -webkit build" option, but > this is not working. > > Thanks and Regards, > Nag

Re: [webkit-dev] Pthread

2017-07-07 Thread Konstantin Tokarev
07.07.2017, 15:01, "Nagendra K" : > Hi All, > > When building JavaScriptCore I am not able to link pthread calls. > Is there a way we can specify the CMakeLists.txt with option to include > pthread. > > I am using Ubuntu machine to build. You need to link ${CMAKE_THREAD_LIBS_INIT}, see https:/

Re: [webkit-dev] Layout test

2017-06-29 Thread Konstantin Tokarev
l files in your browser.Also you can run unit tests (Tools/TestWebKitAPI) For running LayoutTests, you can copy implementation of other port (e.g. gtk.py, or restore efl.py before it was removed), and adjust paths and settings to your port   Thanks,Nagendra On 29 Jun 2017 8:50 p.m., "Konstantin

Re: [webkit-dev] Layout test

2017-06-29 Thread Konstantin Tokarev
29.06.2017, 18:18, "Nagendra K" : > Hi, > > I have a requirement to check if a particular WebKit or latest WebKit works > on the embedded platform. They have custom port which is complex, so plan to > build the new WebKit as a separate process to check build works fine and then > bring their c

Re: [webkit-dev] WebKit Build dependencies

2017-06-22 Thread Konstantin Tokarev
22.06.2017, 14:52, "Adrian Perez de Castro" : > On Thu, 22 Jun 2017 15:41:26 +0530, Nagendra K wrote: > >>  To build WebKit alone for a cross platform embedded device, want to know >>  the list of dependencies/packages required to build on host(Ubuntu) and >>  dependencies to run on host other t

Re: [webkit-dev] Should we ever use std::function instead of WTF::Function?

2017-06-13 Thread Konstantin Tokarev
13.06.2017, 20:08, "Maciej Stachowiak" : > In case it turns out not to be possible to reduce the number of concepts > (besides eliminating std::function), maybe it would help to change the names > and behaviors of these classes to match better. Function, SharedFunction and > ScopedFunction wou

Re: [webkit-dev] Where do we put WPT tests to be exported

2017-05-16 Thread Konstantin Tokarev
16.05.2017, 17:54, "Michael Catanzaro" : > On Mon, May 15, 2017 at 11:01 PM, Ryosuke Niwa wrote: >>  Hi all, >> >>  Youenn is working on a patch to automatically create a GitHub PR to >>  export tests from a WebKit patch which includes changes to >>  web-platform-tests [1]. >> >>  That raises a

Re: [webkit-dev] Fwd: Port WebKit to GNUstep

2017-05-12 Thread Konstantin Tokarev
12.05.2017, 18:14, "Daniel Ferreira (theiostream)" : > On Fri, May 12, 2017 at 11:17 AM, Konstantin Tokarev > wrote: >>  Choice of the correct MemoryPressureHandler implementation can be done >>  in your Platform*.cmake >> >>  Note that you don't

Re: [webkit-dev] Fwd: Port WebKit to GNUstep

2017-05-12 Thread Konstantin Tokarev
12.05.2017, 17:03, "Daniel Ferreira (theiostream)" : > On Thu, May 11, 2017 at 11:58 PM, Ryosuke Niwa wrote: >>  Are you intending to maintain this port going forward? The bar for >>  introducing a new port in the WebKit repository is pretty high due to >>  the maintenance cost it incurs to all

Re: [webkit-dev] Idiom for functions with all return values in a switch case

2017-05-11 Thread Konstantin Tokarev
11.05.2017, 11:18, "Osztrogonác Csaba" : > Hi, > > On 2017.05.11. 0:32, Andy Estes wrote: >>>  On May 10, 2017, at 3:17 PM, Michael Catanzaro >>> wrote: >>> >>>  On Tue, May 9, 2017 at 2:57 PM, Ryosuke Niwa wrote:  One annoying thing is that I've seen clang complaining about that  re

Re: [webkit-dev] Performance Difference between Webkit and Wekit2 API's

2017-05-10 Thread Konstantin Tokarev
10.05.2017, 16:20, "Rodney Dowdall" : > Hello > > We currently have a port of WebKit that uses the WebKit API.  It works well, > but the performance isn't quite at the level of some other WebKit ports. > > I was wondering if there would be an expected performance gain by using the > Webkit2 API

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Konstantin Tokarev
10.05.2017, 12:42, "Ryosuke Niwa" : > On Wed, May 10, 2017 at 2:14 AM, Ryosuke Niwa wrote: >>  On Wed, May 10, 2017 at 12:02 AM, Maciej Stachowiak wrote: >>>  IntegrationTests doesn't distinguish them from performance tests, or API >>>  tests. And most test integration only incidentally. Functi

Re: [webkit-dev] User agent woes

2017-05-09 Thread Konstantin Tokarev
08.05.2017, 06:12, "Michael Catanzaro" : > Hi Maciej, > > I agree with basically everything you wrote, except I recommend not > using OS X as the operating system string in the default user agent > except when actually running on macOS. We tried this for about a year > and got tons of complaints.

Re: [webkit-dev] Clang tidy

2017-05-04 Thread Konstantin Tokarev
04.05.2017, 04:31, "Olmstead, Don" : > I took some time today to see how clang-tidy can be run on WebKit code and > opened https://bugs.webkit.org/show_bug.cgi?id=171632 with some examples on > how to run things. I also attached some output from the modernizer fixes that > can be applied. I t

[webkit-dev] Heads up: ICU source compatibility breakage in 59.1 release

2017-05-02 Thread Konstantin Tokarev
Hello, ICU 59.1 release came out recently, featuring major source compatibility break. Notably, they've changed type of UChar to be char16_t, which does not allow automatic type conversion from unsigned short in C++ code. Possible compilation fix is patch [1], however it changes definitions of

Re: [webkit-dev] Compile time increase over time

2017-04-25 Thread Konstantin Tokarev
25.04.2017, 01:45, "Carlos Alberto Lopez Perez" : > On 24/04/17 21:02, Konstantin Tokarev wrote: >>  24.04.2017, 21:10, "Alex Christensen" : >>>  Thanks for the data, Carlos! This is a growing problem that is hurting >>> productivity. We’ve disc

Re: [webkit-dev] Compile time increase over time

2017-04-24 Thread Konstantin Tokarev
24.04.2017, 21:10, "Alex Christensen" : > Thanks for the data, Carlos! This is a growing problem that is hurting > productivity. We’ve discussed it a bit and haven’t done enough about it. Here > are some of the ideas I’ve heard: > > 1) Reduce #includes by doing more forward declaring and less i

Re: [webkit-dev] Introduce WebKit Android port

2017-03-17 Thread Konstantin Tokarev
17.03.2017, 21:04, "장대웅" : > Hi. > > It is not just a code drop and I will continue maintain it. Actually, I’d > like to code > together with anyone who is interested in it. I think WebKit is a really > great project and > I hope Android port make WebKit more widely used and encourage Android

Re: [webkit-dev] Introduce WebKit Android port

2017-03-12 Thread Konstantin Tokarev
12.03.2017, 12:36, "Yusuke SUZUKI" : > Interesting. > Can JSCOnly port accepts the Android porting things into JSC? > I think this should be small enough. That would be great indeed! > > On Sun, Mar 12, 2017 at 9:21 장대웅 wrote: >> Hello, >> >> I'd like to let you know: WebKit Android port is av

Re: [webkit-dev] Unicode issues when trying to build for Android

2017-03-08 Thread Konstantin Tokarev
  08.03.2017, 02:58, "Patrick Wright" :I wanted to show log messages received when trying to build _javascript_core. Its mainly due to unicode. But I am not sure how to solve these. I read what may be happening is that it is using the unicode on my machine, Ubuntu 14 64bit,  and referencing them fo

Re: [webkit-dev] Webkit port to ppc64le.

2017-02-22 Thread Konstantin Tokarev
rchitecture-specific LLInt implementation is to provide interpreter with the same calling convention as JIT, not to make interpreter faster on its own. See also https://trac.webkit.org/wiki/JavaScriptCore > On Wed, Feb 22, 2017 at 4:11 PM, Konstantin Tokarev wrote: > >> 22.02.2017, 13:15, &

Re: [webkit-dev] Webkit port to ppc64le.

2017-02-22 Thread Konstantin Tokarev
22.02.2017, 13:15, "Atul Sowani" : > Hi, > > This is not specific to any particular branch/version of WebKit. I was > browsing the code with ppc64le porting in mind. By default JIT is not > available on ppc64le, so the CLoop code is used instead. > > I see there is low level interpreter code in

Re: [webkit-dev] ReadMe.md on Github

2017-02-21 Thread Konstantin Tokarev
  22.02.2017, 10:18, "Brian Burg" : On Feb 21, 2017, at 10:53 PM, Ryosuke Niwa wrote: Hi, I recently added ReadMe.md file to WebKit's top-level directory for the convenience of Github users: https://github.com/WebKit/webkit I've added a very abridged instruction on how to checkou

Re: [webkit-dev] CSS Parse error in element.

2017-02-17 Thread Konstantin Tokarev
reach us on IRC. > > On Wed, Feb 15, 2017 at 2:18 PM, Konstantin Tokarev wrote: >> 15.02.2017, 11:40, "Atul Sowani" : >>> Hi, >>> >>> I am wondering about the behavioural difference of the same code on two >>> different platforms, under s

Re: [webkit-dev] EFL port?

2017-02-16 Thread Konstantin Tokarev
len/webkit/wiki/Releasing  Gyuyoung.  On Thu, Feb 16, 2017 at 12:18 AM, Gustavo Sverzut Barbieri <barbi...@profusion.mobi> wrote:On Wed, Feb 15, 2017 at 12:48 PM, Konstantin Tokarev <annu...@yandex.ru> wrote:>>> 15.02.2017, 17:18, "Gustavo Sverzut Barbieri" <barbi...@p

Re: [webkit-dev] EFL port?

2017-02-15 Thread Konstantin Tokarev
15.02.2017, 17:18, "Gustavo Sverzut Barbieri" : > On Wed, Feb 15, 2017 at 3:19 AM, Gyuyoung Kim wrote: >>  Hi, >> >>  If there is no other active maintainer for EFL port, unfortunately I have to >>  agree to drop EFL port in mainline >>  because EFL port should not be an obstacle. I will maintai

Re: [webkit-dev] CSS Parse error in element.

2017-02-15 Thread Konstantin Tokarev
relieving to know that those were known issues and have been fixed in later version of QtWebKit. I will work with PhantomJS maintainers to get the QtWebKit version upgraded in the latest PhantomJS version. Thanks! On Mon, Feb 13, 2017 at 3:41 PM, Konstantin Tokarev <annu...@yandex.ru> wrote:

Re: [webkit-dev] CSS Parse error in element.

2017-02-13 Thread Konstantin Tokarev
xpression valid one? >>> >>> Best regards, >>> Atul. >>> >>> On Thu, Feb 9, 2017 at 2:17 PM, Atul Sowani wrote: >>>> @Konstantin thanks for the suggestions. I disabled CSS JIT on x85 but >>>> there was no negative impact on the result

Re: [webkit-dev] CSS Parse error in element.

2017-02-07 Thread Konstantin Tokarev
07.02.2017, 12:55, "Atul Sowani" : > Thanks Geoffrey, Alex, Yoav for the debugging pointer. I am debugging the > issue further using this information and will most likely need some more help > in immediate future as well. > > Unfortunately, I don't have a stand-alone test case which can be test

Re: [webkit-dev] WebCore/platform standalone library

2017-01-14 Thread Konstantin Tokarev
14.01.2017, 17:16, "Fujii Hironori" : > On Sat, Jan 14, 2017 at 1:34 AM, Konstantin Tokarev wrote: >>  Static library is just an (indexed) archive of object files, symbol >> dependencies are not resolved when it is created. Instead this happens when >> stati

Re: [webkit-dev] WebCore/platform standalone library

2017-01-13 Thread Konstantin Tokarev
13.01.2017, 19:26, "Michael Catanzaro" : > On Fri, 2017-01-13 at 11:39 -0200, Gustavo Sverzut Barbieri wrote: >>  On Thu, Jan 12, 2017 at 7:11 PM, Alex Christensen >>   wrote: >>  > If PAL were a shared library in a CMake build, then it wouldn’t >>  > build successfully if there were layering vio

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-12 Thread Konstantin Tokarev
12.01.2017, 19:54, "Brady Eidson" : > My take-away from this discussion so far is that there is actually very > little consensus on usage of auto, which means there’s probably very little > room for actual style guideline rules. > > I think there are two very limited rules that are probably not

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-12 Thread Konstantin Tokarev
12.01.2017, 19:54, "Brady Eidson" : > My take-away from this discussion so far is that there is actually very > little consensus on usage of auto, which means there’s probably very little > room for actual style guideline rules. > > I think there are two very limited rules that are probably not

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-11 Thread Konstantin Tokarev
11.01.2017, 21:55, "Geoffrey Garen" : > I’m open to auto, but skeptical. > > (1) Research-ability. I read a lot of code that is new to me, that I have > never written. I find type statements to be useful as documentation for where > to look for more information about how data structures and alg

Re: [webkit-dev] update GCC version?

2017-01-09 Thread Konstantin Tokarev
09.01.2017, 20:53, "Michael Catanzaro" : > On Mon, 2017-01-09 at 16:56 +0100, Carlos Alberto Lopez Perez wrote: >>  Can you please explain how you reach that conclusion? >>  Do you have any data to back up such claim? > > No, I don't have data, but it seems extremely naive to assume that any > si

Re: [webkit-dev] update GCC version?

2017-01-09 Thread Konstantin Tokarev
09.01.2017, 18:47, "Michael Catanzaro" : > On Mon, 2017-01-09 at 16:39 +0100, Carlos Alberto Lopez Perez wrote: >>  I strongly oppose to do (a). Also, it is false that Debian doesn't >>  take >>  our updates. They take our updates in the backports repository for >>  stable. > > Nobody uses that.

Re: [webkit-dev] update GCC version?

2017-01-07 Thread Konstantin Tokarev
07.01.2017, 22:30, "Alex Christensen" : > We are looking into using more C++14 features in WebKit, which would require > increasing the minimum supported compiler versions.  For example, Yusuke’s > patch in https://bugs.webkit.org/show_bug.cgi?id=165093 compiles successfully > in clang and I v

Re: [webkit-dev] WebKit build failed

2016-12-14 Thread Konstantin Tokarev
14.12.2016, 12:22, "Plamen Dimitrov" : > Hi all, > > if  WinCairo build is OK why I cann't build it? > > I've still cannot generated a lot of files. > It seems that DerivedSources.make has not been invoked. CMake build does not use DerivedSources.make > How I can generate the files manually?  p

Re: [webkit-dev] WebKit build failed

2016-12-12 Thread Konstantin Tokarev
Context.h > JSWebGLRenderingContextBase.h MathMLNames.h SVGNames.h Can I generate these > files? This files should be automatically generated during build process. Rules are defined in cmake files. > > On Mon, Dec 12, 2016 at 2:30 PM, Konstantin Tokarev wrote: >> 12.12.2016, 12:25,

Re: [webkit-dev] WebKit build failed

2016-12-12 Thread Konstantin Tokarev
12.12.2016, 12:25, "Plamen Dimitrov" : > Hi all, I am trying to build webkit wincairo 1) I've done 2, 3, 4, 5, 6, 7, > 8, 9,10 and 13 from this list: > https://webkit.org/webkit-on-windows/#installing-developer-tools 2) I've > installed Ruby 2.0.0-p648 and DevKit-mingw64 from here: > http://r

Re: [webkit-dev] WebKit GPU rendering possibility

2016-11-03 Thread Konstantin Tokarev
03.11.2016, 22:18, "Rogovin, Kevin" : > Hi, > >  What are some good 2D UI graphics benchmarks that are cross-platform-ish? > I'd think I need to port them to Fast UI Draw, but that is possible. > >  I am very confident that Fast UI Draw will perform at the top by a large > margin. The more comp

Re: [webkit-dev] WinCairo Maintainers

2016-09-26 Thread Konstantin Tokarev
e modules.   > Some companies also have policies that they can only distribute software that > they built completely from source. conan.io allows to build everything from sources as well >> On Sep 26, 2016, at 11:54 AM, Konstantin Tokarev wrote: >> >> 26.09.2016, 21:46, "Alex

Re: [webkit-dev] WinCairo Maintainers

2016-09-26 Thread Konstantin Tokarev
26.09.2016, 21:46, "Alex Christensen" : > Right now https://github.com/peavo/WinCairoRequirements is the best > maintained repository containing all the requirements, even if Per isn’t > maintaining it any more.  If you fork it and add fixes, then yours would > become the best maintained repos

Re: [webkit-dev] [CMake] Bumping cmake_minimum_required

2016-09-23 Thread Konstantin Tokarev
23.09.2016, 00:59, "Alex Christensen" : > Requiring CMake 3.0 would not cause us a problem. Looks like anyone is fine with updating CMake to 3.0, however Fujii Hironori is asking about CMake 3.2, and AFAIU updating to 3.0 won't help for his patch. . >>  On Sep 21, 2016, at 5:06 AM, Michael Cat

Re: [webkit-dev] [CMake] Bumping cmake_minimum_required

2016-09-20 Thread Konstantin Tokarev
20.09.2016, 12:36, "Fujii Hironori" : > I'm interested in bumping cmake_minimum_required for > . > Which version of CMake is minimum version to be supported? Now minimum supported version is 2.8.12. What version do you need? Supporting 2.8.12 allows building on more

Re: [webkit-dev] Point within WebKit API to extract Bitmaps

2016-09-09 Thread Konstantin Tokarev
09.09.2016, 17:46, "Mark Gilbert" : > Hi Folks > > We have code which extracts RGB+A bitmaps from WebKit pages in real time. > Currently we do this via an OSX WebKit View in a window and by requesting the > bitmap through the OSX View mechanism (not directly from WebKit). It works > well and w

Re: [webkit-dev] Incorrect expectation for fast/forms/range/slider-delete-while-dragging-thumb.html

2016-07-27 Thread Konstantin Tokarev
semove mousedown +input deleting slider > > On Wed, Jul 27, 2016 at 7:32 AM, Konstantin Tokarev wrote: >>  Hello, >> >>  Test fast/forms/range/slider-delete-while-dragging-thumb.html is marked as >> [ Failure ] on many platforms. >> >>  Attached expected res

[webkit-dev] Are fast/viewport/viewport-legacy-* obsolete?

2016-07-27 Thread Konstantin Tokarev
Hello, It seems like fast/viewport/viewport-legacy-* tests belong to LEGACY_VIEWPORT_ADAPTION feature, which was removed in r163238. Should these tests be removed? -- Regards, Konstantin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https:/

[webkit-dev] Incorrect expectation for fast/forms/range/slider-delete-while-dragging-thumb.html

2016-07-27 Thread Konstantin Tokarev
Hello, Test fast/forms/range/slider-delete-while-dragging-thumb.html is marked as [ Failure ] on many platforms. Attached expected result passes on GTK and Qt ports. Would it be correct to replace contents of LayoutTests/fast/forms/range/slider-delete-while-dragging-thumb-expected.txt with th

[webkit-dev] Tests in fast/dom/custom

2016-07-26 Thread Konstantin Tokarev
Hello, There is a number of tests in fast/dom/custom which were added for old CUSTOM_ELEMENTS implementation (which used document.webkitRegister). However, old implementation of CUSTOM_ELEMENTS was removed in r157363, and new implementation is using tests under fast/custom-elements. Should fas

Re: [webkit-dev] "Fake" ref-tests

2016-07-24 Thread Konstantin Tokarev
23.07.2016, 07:57, "Darin Adler" : >>   On Jul 22, 2016, at 4:14 PM, Konstantin Tokarev wrote: >> >>   What is the right way to deal with tests like these? > >  I think we should move the tests into platform/mac. I don't think this is a good solution, b

[webkit-dev] Strange result in fast/backgrounds/mask-composite.html

2016-07-22 Thread Konstantin Tokarev
Hello, I'm getting attached result for fast/backgrounds/mask-composite.html, while in the tree expected result looks like https://trac.webkit.org/browser/trunk/LayoutTests/platform/gtk/fast/backgrounds/mask-composite-expected.png https://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/fas

[webkit-dev] "Fake" ref-tests

2016-07-22 Thread Konstantin Tokarev
Hello, I've stumbled upon two ref-tests: fast/borders/border-painting-correctness-dashed.html fast/borders/border-painting-correctness-dotted.html Their references have a form of body { margin: 0px; } where img represents correct rendering of borders in mac port. As a result, th

Re: [webkit-dev] "No red pixels below" automation

2016-07-20 Thread Konstantin Tokarev
16.07.2016, 23:56, "Darin Adler" : >>  On Jul 16, 2016, at 10:21 AM, Konstantin Tokarev wrote: >> >>  Yet another example: fast/layers/scroll-with-transform-composited-layer.html >> >>  "All the boxes should only contain green content.” > > Tha

Re: [webkit-dev] webkit not remembering or asking to remember passwords

2016-07-20 Thread Konstantin Tokarev
20.07.2016, 15:28, "Mark Davis" : > Hi, > I have just installed webkit onto my g5 powermac. It is working well, > however does not send the usual message about remembering password > details after logging into my accounts. Which port are you using? If you've managed to install trunk (or at least

Re: [webkit-dev] "No red pixels below" automation

2016-07-16 Thread Konstantin Tokarev
Yet another example: fast/layers/scroll-with-transform-composited-layer.html "All the boxes should only contain green content." Such tests would be harder to grep. 16.07.2016, 19:30, "Konstantin Tokarev" : > 16.07.2016, 18:56, "Darin Adler" : >>>

Re: [webkit-dev] "No red pixels below" automation

2016-07-16 Thread Konstantin Tokarev
16.07.2016, 18:56, "Darin Adler" : >>  On Jul 16, 2016, at 8:45 AM, Konstantin Tokarev wrote: >> >>  For example, I'm looking at fast/canvas/shadow-offset-* now. They are pixel >> tests now. > > The simplest efficient way to turn these into referen

Re: [webkit-dev] "No red pixels below" automation

2016-07-16 Thread Konstantin Tokarev
16.07.2016, 18:39, "Darin Adler" : >>  On Jul 16, 2016, at 8:19 AM, Konstantin Tokarev wrote: >> >>  There is a number of layout tests which are expected not to have red pixels >> in case of pass. Some of them are purely pixel tests, which are not checked &

[webkit-dev] "No red pixels below" automation

2016-07-16 Thread Konstantin Tokarev
Hello, There is a number of layout tests which are expected not to have red pixels in case of pass. Some of them are purely pixel tests, which are not checked by bots (and not often by humans), others have render trees dumps, but there many cases when render tree dump is right but end result is

Re: [webkit-dev] Is anyone here interested in improving rebaseline-server?

2016-07-14 Thread Konstantin Tokarev
14.07.2016, 18:44, "Michael Catanzaro" : > On Thu, 2016-07-14 at 18:03 +0300, Konstantin Tokarev wrote: >>  Is anybody here using rebaseline-server as well, or everyone is using >>  garden-o-matic? > > Hm, I didn't know about these tools; is there documentatio

[webkit-dev] Is anyone here interested in improving rebaseline-server?

2016-07-14 Thread Konstantin Tokarev
Hello, Recently I was using rebaseline-server a lot to do large-scale local rebaseline, and I've collected a list of glitches and inconveniences in its UI which make work less effecive than it could be, and would be nice to get fixed. Is anybody here using rebaseline-server as well, or everyone

[webkit-dev] Rounded dots in dotted border

2016-07-14 Thread Konstantin Tokarev
Hello, Document [1] says defines "dotted" style as "a series of round dots", however CG and Cairo implementations draw dots as squares. Are there any plans to implement rounded dots? [1] https://www.w3.org/TR/css3-background/#border-style - P.S. Some context in case anyone is interested:

Re: [webkit-dev] Does anybody need LayoutTests/fast/css/style-scoped?

2016-06-24 Thread Konstantin Tokarev
25.06.2016, 00:38, "Benjamin Poulain" : > On 6/24/16 8:49 AM, Konstantin Tokarev wrote: >>  Hello, >> >>  If I understand correctly, support for 'scoped' attribute of

[webkit-dev] Does anybody need LayoutTests/fast/css/style-scoped?

2016-06-24 Thread Konstantin Tokarev
Hello, If I understand correctly, support for 'scoped' attribute of

Re: [webkit-dev] REQUEST_ANIMATION_FRAME on all ports?

2016-06-08 Thread Konstantin Tokarev
08.06.2016, 23:59, "Dean Jackson" : > Do the EFL and GTK ports always enable this feature? If so, I'm going to > remove the compile flag. While I'm not opposed to this change, it looks like its maintenance cost is near zero. Last time I was building with it disabled it was not broken, though

Re: [webkit-dev] WebKit render tree

2016-06-01 Thread Konstantin Tokarev
01.06.2016, 09:19, "Andy Somogyi" : > Hi, > > I’m a programming language researcher, and we are working on a new visual > programming language. > > I’m investigating using WebCore as the rendering component of our language > editing/visualization system. > > Essentially what I’d like to be able

Re: [webkit-dev] Are there any plans to upgrade SVN server on svn.webkit.org?

2016-05-28 Thread Konstantin Tokarev
> - Alexey > >>  27 апр. 2016 г., в 5:13, Konstantin Tokarev написал(а): >> >>  Hello, >> >>  According to [1], currently svn.webkit.org runs severely outdated >> Subversion 1.6.11. Since then, there were 3 significant releases of >> Subversion, whic

[webkit-dev] KeyedEncoding: are decodeBytes() and encodeBytes() really needed?

2016-04-28 Thread Konstantin Tokarev
Hello, It looks like that KeyedDecoder::decodeBytes() and KeyedEncoder::encodeBytes() are not used anywhere in codebase. Are these methods a dead code, or they exist for the sake of completeness? Are there any plans to use them in future? -- Regards, Konstantin

[webkit-dev] Are there any plans to upgrade SVN server on svn.webkit.org?

2016-04-27 Thread Konstantin Tokarev
Hello, According to [1], currently svn.webkit.org runs severely outdated Subversion 1.6.11. Since then, there were 3 significant releases of Subversion, which brought lots of performance improvements, most importantly brand new HTTP protocol [3] and storage format improvements [4]. Also, since

Re: [webkit-dev] [ANN] JSCOnly port becomes dependency-free (except for ICU)

2016-04-21 Thread Konstantin Tokarev
21.04.2016, 19:30, "Yusuke SUZUKI" : > On Thu, Apr 21, 2016 at 3:12 AM, Eric Wing wrote: >> On 4/18/16, Yusuke SUZUKI wrote: >>> Hi folks, >>> >>> Thanks to Konstantin Tokavev and GTK guys, JSCOnly port becomes quickly >>> mature. >>> As of now, finally, JSCOnly port becomes completely dependen

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

2016-04-19 Thread Konstantin Tokarev
19.04.2016, 18:23, "Filip Pizło" : >>  On Apr 19, 2016, at 5:50 AM, Carlos Alberto Lopez Perez >> wrote: >> >>>  On 18/04/16 21:50, Filip Pizlo wrote: >>>  I don't want a buildbot for MIPS. It's not a relevant architecture >>>  anymore. I don't think that JSC developers should have to expend >>

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

2016-04-19 Thread Konstantin Tokarev
19.04.2016, 22:22, "Anders Carlsson" : >> On Apr 19, 2016, at 12:21 PM, Konstantin Tokarev wrote: >> >> 19.04.2016, 22:11, "Anders Carlsson" : >>>>  On Apr 19, 2016, at 12:09 PM, Konstantin Tokarev >>>> wrote: >>>> >

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

2016-04-19 Thread Konstantin Tokarev
19.04.2016, 22:11, "Anders Carlsson" : >>  On Apr 19, 2016, at 12:09 PM, Konstantin Tokarev wrote: >> >>  19.04.2016, 21:38, "Anders Carlsson" : >>>  I’d like us to switch over to using C++14 in WebKit2 so we can get the new >>> generaliz

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

2016-04-19 Thread Konstantin Tokarev
19.04.2016, 21:38, "Anders Carlsson" : > I’d like us to switch over to using C++14 in WebKit2 so we can get the new > generalized lambda capture (https://isocpp.org/files/papers/N3648.html), so > we can capture move-only types in lambdas. According to  > https://gcc.gnu.org/projects/cxx-status.

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

2016-04-19 Thread Konstantin Tokarev
19.04.2016, 21:34, "Filip Pizlo" : >> On Apr 19, 2016, at 11:33 AM, Konstantin Tokarev wrote: >> >> 19.04.2016, 21:15, "Filip Pizlo" : >>> I did a quick look over the trac query of GCC 4.8 changes that you >>> provided. None of the ones

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

2016-04-19 Thread Konstantin Tokarev
19.04.2016, 21:15, "Filip Pizlo" : > I did a quick look over the trac query of GCC 4.8 changes that you provided. > None of the ones I looked at were scary but they were annoying. They seemed > to be things like: > > - Sometimes saying { } to initialize a variable doesn’t work. > - Sometimes yo

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS [WARNING - NOT VIRUS SCANNED]

2016-04-19 Thread Konstantin Tokarev
> br, > Ossy > > Filip Pizlo írta: >>  I don't want a buildbot for MIPS. It's not a relevant architecture anymore. >> I don't think that JSC developers should have to expend effort towards >> keeping this architecture working. >> >>  -Filip &

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

2016-04-18 Thread Konstantin Tokarev
18.04.2016, 22:56, "Geoffrey Garen" : >>>   Are there any objections for lowering GCC requirement from 4.9.0 to 4.8.4 >>> (only for JavaScriptCore without B3)? I'm going to fix arising compilation >>> errors myself. > >  Yes. > >  We want to move forward in C++ language support, not backward. >

[webkit-dev] Build slave for JSCOnly Linux MIPS

2016-04-18 Thread Konstantin Tokarev
Hello, I'd like to run build slave for MIPS port of JSC (with JSCOnly port on Linux). On the first iteration it will just ensure that compilation is not broken, afterwards I'm planning to add running tests on target. However, I'm planning to use cross-toolchain based on GCC 4.8.4 (for now, the

Re: [webkit-dev] Mac CMake

2016-04-05 Thread Konstantin Tokarev
18.03.2016, 21:27, "Geoffrey Garen" : >>  Just out of curiosity, is there any chance that Apple Mac WebKit >>  will be migrated to cmake within the foreseeable future? > > Based on initial experiments, I'm interested in CMake. If so, are you planning to add PerformanceTests/MallocBench to CMake

Re: [webkit-dev] Is someone going to fix Windows EWS?

2016-03-30 Thread Konstantin Tokarev
s. > > Yesterday was a rough day for the CMake ports because I made WebCore more > than one static library.  I think I know what’s wrong with the headers in > clean builds and I’ll fix it soon. >> On Mar 30, 2016, at 10:06 AM, Konstantin Tokarev wrote: >> >> 30

Re: [webkit-dev] Is someone going to fix Windows EWS?

2016-03-30 Thread Konstantin Tokarev
30.03.2016, 19:47, "Brent Fulgham" : > This is happening because “Font.h” is referring to > “”, which doesn’t always exist on Windows at the > time the file is compiled. The CoreGraphicsSPI.h file lives in > “WebCore/platform/spi/cg/CoreGraphicsSPI.h”, and can be found with a normal > ‘#inclu

Re: [webkit-dev] WebInspectorUI cannot find RuntimeAgent

2016-03-24 Thread Konstantin Tokarev
24.03.2016, 19:22, "Konstantin Tokarev" : > Hello, > > I'm porting old code of Inspector integration to current WebKit trunk. Now > when I activate Inspector, I get following error: > > ReferenceError: Can't find variable: RuntimeAgent (at RuntimeManager

[webkit-dev] WebInspectorUI cannot find RuntimeAgent

2016-03-24 Thread Konstantin Tokarev
Hello, I'm porting old code of Inspector integration to current WebKit trunk. Now when I activate Inspector, I get following error: ReferenceError: Can't find variable: RuntimeAgent (at RuntimeManager.js:33:21) I'm loading page Source/WebInspectorUI/UserInterface/Main.html, InspectorInstrument

Re: [webkit-dev] Proposal: Use #pragma once instead of header guards

2016-03-19 Thread Konstantin Tokarev
10.03.2016, 05:07, "Brent Fulgham" : >>  On Mar 9, 2016, at 5:27 PM, Anders Carlsson wrote: >> >>  I propose that we instead start using >> >>  #pragma once > > +1 Here is a script which apparently can be used to convert whole code base to new style: https://github.com/cgmb/guardonce -- Reg

Re: [webkit-dev] Fonts for WebKit tests on OS X?

2016-03-14 Thread Konstantin Tokarev
14.03.2016, 11:00, "Frédéric WANG" : > Le 13/03/2016 20:57, Darin Adler a écrit : >>  I don’t think the size of the font files in the repository is a significant >> issue; are the sizes particularly huge compared to the total size of all the >> layout tests including expected results? If this w

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-04 Thread Konstantin Tokarev
04.03.2016, 21:32, "Darin Adler" : > Here are three other loose ends I am thinking about: > > - Style guide should say that in a class marked final, virtual functions > should all be marked final, not override and certainly not virtual. Agreed? I agree about virtual, but not sure about override

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-04 Thread Konstantin Tokarev
04.03.2016, 20:06, "Konstantin Tokarev" : > 04.03.2016, 16:21, "Konstantin Tokarev" : >>  03.03.2016, 22:35, "Darin Adler" : >>>   OK! >>> >>>   Do we have volunteers to: >>> >>>   1) update the style guide web

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-04 Thread Konstantin Tokarev
04.03.2016, 16:21, "Konstantin Tokarev" : > 03.03.2016, 22:35, "Darin Adler" : >>  OK! >> >>  Do we have volunteers to: >> >>  1) update the style guide webpage >>  2) update check-webkit-style >>  3) physically restrain me from tu

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-04 Thread Konstantin Tokarev
04.03.2016, 19:47, "Darin Adler" : >>  On Mar 4, 2016, at 6:54 AM, Konstantin Tokarev wrote: >> >>  I have WebCore patch ready for upload. > > Yes, I had already done this last night > <https://bugs.webkit.org/show_bug.cgi?id=155005>. Just haven’t l

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-04 Thread Konstantin Tokarev
04.03.2016, 17:53, "Michael Catanzaro" : > On Thu, 2016-03-03 at 11:38 -0800, Geoffrey Garen wrote: >>  I volunteer for any future needs in the physical restraint department >>  -- but in this case, I think (3) sounds like a good idea. > > Allowing Darin to perform (3) sounds good to me, what cou

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-04 Thread Konstantin Tokarev
03.03.2016, 22:35, "Darin Adler" : > OK! > > Do we have volunteers to: > > 1) update the style guide webpage > 2) update check-webkit-style > 3) physically restrain me from turning do-webcore-rename into a perl script > that does this all the code in the entire source tree all at one go, since

[webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-03 Thread Konstantin Tokarev
Hello, Right now there is a lot of code which uses both 'virtual' and 'override' on overridden methods, but there is also code (e.g., in B3) which uses only 'override'. check-webkit-style accepts both styles. Which style is preferred in new code? -- Regards, Konstantin ___

[webkit-dev] Which bugzilla component should be used for bmalloc?

2016-02-22 Thread Konstantin Tokarev
Hello, It seems like there is no appropriate bugzilla component for bmalloc. In my understanding, closest one is JavaScriptCore since it is mostly work on by the same folks who work on JSC, but technically they are very different components. I think we need to create new component "Bmalloc" (or

Re: [webkit-dev] JSCOnly port

2016-02-21 Thread Konstantin Tokarev
hat is desireble. BTW, reportedly B3 works on Win64 (run-layout-jsc passes 634 tests of 646) > > Regards, > Yusuke Suzuki > > On Sun, Feb 21, 2016 at 10:41 PM, Konstantin Tokarev > wrote: >> Hello, >> >> Following the discussion in "Thought about Nix JavaScriptC

[webkit-dev] JSCOnly port

2016-02-21 Thread Konstantin Tokarev
Hello, Following the discussion in "Thought about Nix JavaScriptCore port", I'm proposing patch [1] that adds new port named "JSCOnly". It is based on patch proposed by Yusuke Suzuki in [2], where you can also find justification. As the name suggests, this port builds only JSC library and execu

[webkit-dev] Is MIMETypeRegistry::canShowMIMEType supposed to accept lowercase or unknown case?

2016-02-12 Thread Konstantin Tokarev
Hello, In WebProcess/WebPage/WebPage.cpp MIMETypeRegistry::canShowMIMEType seems to be called with argument of unknown case (the same string is then looked up in ASCIICaseInsensitiveHash). However, MIMETypeRegistry::canShowMIMEType does a case-sensitive startsWith("text/"). Should MIMETypeReg

Re: [webkit-dev] [cmake] Proposal: Move commonly used platform-dependent files in WebCore to .cmake include files.

2016-02-10 Thread Konstantin Tokarev
09.02.2016, 22:19, "Alex Christensen" : >  Let’s go for it. Less duplication is a good thing. The only downside is the > occasional “Which CMake file do I add this to?” but that should be just as > straightforward as adding the file to multiple platform cmake files, if not > more. That's a re

Re: [webkit-dev] Thought about Nix JavaScriptCore port

2016-02-10 Thread Konstantin Tokarev
10.02.2016, 20:10, "Filip Pizło" : >>  On Feb 10, 2016, at 1:40 AM, Konstantin Tokarev wrote: >> >>  10.02.2016, 05:41, "Eric Wing" : >>>>  On 2/7/16, Konstantin Tokarev wrote: >>>>   Please try updated version of my b

<    1   2   3   >