Re: [webkit-dev] Deployment of new EWS Non-Unified builder

hrough PRs to look for this EWS failure in order to narrow down on which patches (and therefore possible includes) to focus on. Of course, this is assuming that our EWS visibility problem on PRs in the current GitHub world gets fixed. Mark > > — Darin > _

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

I forgot to add ... > On Jun 24, 2020, at 10:26 AM, Mark Lam wrote: > > Based on all the feedback given so far, it looks like we can move forward > with the following plan: > 1. JSC Debug test bots will build their own local jsc with O3 before running > the tests. 1.5 JSC

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

JSC test bot functional again. Thanks. Mark > On Jun 19, 2020, at 2:58 PM, Alexey Proskuryakov wrote: > > > >> 19 июня 2020 г., в 1:11 PM, Mark Lam > <mailto:mark@apple.com>> написал(а): >> >> >> >>> On Jun 19, 2020, at 10:

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

n but I don’t think we’ll have any other reason to keep the build artifacts around. While today’s post-commit test script for Debug JSC tests uses common build artifacts, why can’t we change the steps for this test to work like the EWS bot and just build locally? In terms of total run time

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

is a timeout due to the master bot not seeing any output from the tester bot for more than 20 minutes. I’ve not been able to reproduce this yet. But with a Debug build test run taking 4+ hours, it can only be a progression to switch the Debug JSC test bots to O3. Mark > >>&g

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

> On Jun 19, 2020, at 10:02 AM, Alexey Proskuryakov wrote: > > > >> 19 июня 2020 г., в 9:59 AM, Mark Lam > <mailto:mark@apple.com>> написал(а): >> >> >> >>> On Jun 19, 2020, at 9:53 AM, Alexey Proskuryakov >> <mailto:a.

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

re do we stand on understanding and > adopting that? I tried -Og last time after your suggestion, and I remember thinking that the perf was not acceptable back then. I’ll collect the data again and report back with real number later today. Mark > > - Alexey > >> - Some race condit

[webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

would like to apply this change to all Debug build and test bots, not just the JSC ones. Does anyone strongly object to this change? Thanks. Cheers, Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/

[webkit-dev] PSA: on make targets "testing" and "release+assert", ASSERT_ENABLED, and NDEBUG

elease. This is similar to how "set-webkit-configuration --asan” works. Alternatively, you can also do "set-webkit-configuration —reset” to clear all configurations set using set-webkit-configuration. If typing “--force-optimization-level” is too long a

Re: [webkit-dev] CI builds fail on all platforms with "ReferenceError: Can't find variable: WebAssembly"

I’m about to move it into JSTests/wasm/stress. See https://bugs.webkit.org/show_bug.cgi?id=201551 . > On Sep 6, 2019, at 11:31 AM, Saam Barati wrote: > > Those tests should be checking if WebAssembly is enabled at all before > running the

Re: [webkit-dev] Code Style: Opinion on returning void

such a template will be a pain if not impossible. Mark > On Feb 20, 2019, at 7:26 AM, Saam Barati wrote: > > I prefer it as well. > > - Saam > > On Feb 20, 2019, at 6:58 AM, Chris Dumez <mailto:cdu...@apple.com>> wrote: > >> I also prefer allowed returning voi

Re: [webkit-dev] Exciting JS features (class fields) in need of review :)

, the feature can be disabled by default but still receive testing. Mark > On Feb 14, 2019, at 9:27 AM, Maciej Stachowiak wrote: > > > >> On Feb 14, 2019, at 1:37 AM, Xan Lopez > <mailto:x...@gnome.org>> wrote: >> >> Hi Maciej, >> >> the f

Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp

, Mark Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp On Jan 16, 2019, at 20:56, Salisbury, Mark mailto:mark.salisb...@hp.com>> wrote: Hello, Hello! I’m working on rebasing our downstream webkit port; I just pulled down recent

[webkit-dev] Compile error in WebGL2RenderingContext.cpp

could not be invoked without enabling WEBGL 2. Am I looking at unfinished code that magically compiles with gcc/llvm/etc. (non Visual Studio)? Thanks, Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/li

[webkit-dev] wpt.fyi survey

it out and make your voice heard! Thanks! //Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] WTFCrash()

() if that works better for linux folks. BTW, CRASH() is what you want to define/redirect. WTFCrash() is only one implementation of CRASH(). No client should be calling WTFCrash() directly. Mark > Michael > > [1] https://bugs.webkit.org/show_bug.cgi?id=153996 > [2] https://bu

[webkit-dev] Javier Fernandez is now a WebKit reviewer

, congratulations. Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] unified sources build + forwarding headers that are copies

e compiler once. #pragma once says "Include this header file (at this location)" one time only. -Mark -Original Message- From: Konstantin Tokarev [mailto:annu...@yandex.ru] Sent: Friday, November 17, 2017 9:16 PM To: Salisbury, Mark <mark.salisb...@hp.com>; webkit-dev@li

Re: [webkit-dev] unified sources build + forwarding headers that are copies

Thanks for the replies Alex, Michael, Konstantin. I've submitted a bug with proposed patch here: https://bugs.webkit.org/show_bug.cgi?id=179814 -Mark -Original Message- From: achristen...@apple.com [mailto:achristen...@apple.com] Sent: Tuesday, November 14, 2017 12:25 PM To: Salisbury

[webkit-dev] Frédéric Wang is now a WebKit reviewer

. Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] How we enable template functions

e a solution for this. Mark > On Aug 22, 2017, at 11:14 PM, Keith Miller <keith_mil...@apple.com> wrote: > >> On Aug 22, 2017, at 9:17 PM, JF Bastien <j...@chromium.org >> <mailto:j...@chromium.org>> wrote: >> >> I'd suggest considering what i

Re: [webkit-dev] JIT probe mechanism soon required for DFG and FTL OSR Exit

org/show_bug.cgi?id=175446>). As a consequence, I’ll be disabling the DFG for the MIPS port in this patch. Mark > On Jul 19, 2017, at 9:52 AM, Mark Lam <mark@apple.com> wrote: > > > >> On Jul 19, 2017, at 9:49 AM, Konstantin Tokarev <annu...@yandex.ru> wrote: >

Re: [webkit-dev] JIT probe mechanism soon required for DFG and FTL OSR Exit

> On Jul 19, 2017, at 9:49 AM, Konstantin Tokarev <annu...@yandex.ru> wrote: > > > > 19.07.2017, 02:49, "Mark Lam" <mark@apple.com>: >> FYI, I’m looking into making OSR exits work in a more memory efficient way >> using the JIT probe

[webkit-dev] JIT probe mechanism soon required for DFG and FTL OSR Exit

if you have questions regarding the probe mechanism. This work will be tracked in https://bugs.webkit.org/show_bug.cgi?id=174645 <https://bugs.webkit.org/show_bug.cgi?id=174645>. Thanks. Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org

[webkit-dev] Jiewen Tan is now a WebKit reviewer

Hi everyone, I would like to announce that Jiewen Tan (jiewen on #webkit) is now a WebKit reviewer. Jiewen usually works on the WebCrypto API. Please join me in congratulating Jiewen, and send him some patches to review. Jiewen, congratulations. Mark

[webkit-dev] Konstantin Tokarev is now a WebKit reviewer

of applications that depend on QtWebKit will soon be able to receive updated versions of WebKit. Please join me in congratulating Konstantin, and send him some patches to review. Konstantin, congratulations. Mark ___ webkit-dev mailing list webkit-dev

Re: [webkit-dev] JF Bastien is now a WebKit reviewer

Oops, I have sticky fingers today. My apologies to JF. The title should have been "JF Bastien is now a WebKit reviewer”. > On Apr 4, 2017, at 3:57 PM, Mark Lam <mark@apple.com> wrote: > > Hi everyone, > > I would like to announce that JF Bastien (jfbastien on #

[webkit-dev] JS Bastien is now a WebKit reviewer

in congratulating JF, and send him some patches to review. JF, congratulations. Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Carlos Alberto Lopez Perez is now a WebKit Reviewer

to review. Carlos, congratulations. Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Proposal to limit the size of the captured exception stack

not familiar with? Geoff, It just occurred to me that the developer does have one recourse: he/she can use break on exception thrown / on uncaught exception, and inspect the full stack via the debugger. Mark > On Mar 28, 2017, at 9:08 PM, Mark Lam <mark@apple.com> wrote: > > Cur

Re: [webkit-dev] Proposal to limit the size of the captured exception stack

Currently, there’s no way for the developer to change this. We can certainly make it an option that the Inspector can change if desired. Mark > On Mar 28, 2017, at 7:35 PM, Matt Baker <matthew_a_ba...@apple.com> wrote: > >> On Mar 28, 2017, at 4:23 PM, Geoffrey Garen

Re: [webkit-dev] Proposal to limit the size of the captured exception stack

Error.stack which is captured at the time of instantiation of the Error object). exceptionStackTraceLimit is also limited to 100 by default. Mark > On Mar 17, 2017, at 1:04 PM, Mark Lam <mark@apple.com> wrote: > > @Geoff, my testing shows that we can do 200 frames

Re: [webkit-dev] Proposal to limit the size of the captured exception stack

gt; wrote: > >> >> On Mar 17, 2017, at 11:09 AM, Mark Lam <mark@apple.com >> <mailto:mark@apple.com>> wrote: >> >> Thanks for the reminder to back observations up with data. I was previously >> running some tests that throws StackOverflo

Re: [webkit-dev] Proposal to limit the size of the captured exception stack

Does anyone object to us adopting Error.stackTraceLimit and setting the default to 10 to match Chrome? Mark > On Mar 16, 2017, at 11:29 PM, Geoffrey Garen <gga...@apple.com> wrote: > > Can you be more specific about the motivation here? > > Do we have any motivating exampl

[webkit-dev] Proposal to limit the size of the captured exception stack

and render the ellipses. Does anyone object to doing this or have a compelling reason why this should not be done? Thanks. Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Devin Rousso is now a WebKit reviewer

Hi everyone, I would like to announce that Devin Rousso (dcrousso on #webkit) is now a WebKit reviewer. Devin has been contributing to Web Inspector for nearly two years. Please join me in congratulating Devin, and send him some patches to review. Devin, congratulations. Mark

Re: [webkit-dev] VM::setExclusiveThread()

doing less work). I’ll put up a patch to remove the use of exclusive thread status. This will simplify the code and make it easier to move forward with new features. Mark > On Feb 24, 2017, at 9:01 PM, Filip Pizlo <fpi...@apple.com> wrote: > > Seems like if the relevant benchmar

[webkit-dev] VM::setExclusiveThread()

(something I would like to be able to do for something new I’m working on). Does anyone see a reason why we can’t remove the concept of the exclusiveThread? Thanks. Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org

Re: [webkit-dev] Why does RELEASE_ASSERT not have an error message?

To give an update: I plan to experiment and get some size and perf numbers and report back later. But since this is not a high priority task for me, it may be a while before I get back to this. Mark > On Feb 22, 2017, at 1:25 PM, Ryosuke Niwa <rn...@webkit.org> wrote: > >

Re: [webkit-dev] Why does RELEASE_ASSERT not have an error message?

> On Feb 22, 2017, at 12:46 PM, Filip Pizlo <fpi...@apple.com> wrote: > >> >> On Feb 22, 2017, at 12:41 PM, Mark Lam <mark@apple.com >> <mailto:mark@apple.com>> wrote: >> >>> >>> On Feb 22, 2017, at 12:35 PM, F

Re: [webkit-dev] Why does RELEASE_ASSERT not have an error message?

> On Feb 22, 2017, at 12:35 PM, Filip Pizlo <fpi...@apple.com> wrote: > >> >> On Feb 22, 2017, at 12:33 PM, Mark Lam <mark@apple.com >> <mailto:mark@apple.com>> wrote: >> >> >>> On Feb 22, 2017, at 12:16 PM, Fili

Re: [webkit-dev] Why does RELEASE_ASSERT not have an error message?

by inline asm, the C++ compiler has less ability to determine that the crash sites have the same code (probably because it doesn’t bother comparing what’s in the inline asm blobs). Mark > On Feb 22, 2017, at 12:33 PM, Mark Lam <mark@apple.com> wrote: > >> >> On F

Re: [webkit-dev] Why does RELEASE_ASSERT not have an error message?

work is that it increases the code size for each RELEASE_ASSERT site. This is probably insignificant in total. Performance-wise, it should be neutral-ish because the __builtin_unreachable() in the CRASH() macro + the UNLIKELY() macro would tell the compiler to put this in a slow path aw

Re: [webkit-dev] Why does RELEASE_ASSERT not have an error message?

> I thought the main point of moving to SIGTRAP was to preserve register state? > > That said, there are probably places where we care more about the message > than the registers. > > - Saam > >> On Feb 21, 2017, at 5:43 PM, Mark Lam <mark@apple.com> wrote

[webkit-dev] Why does RELEASE_ASSERT not have an error message?

crash debugging. Any thoughts? Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Reducing the use of EncodedJSValue and use JSValue directly instead.

...@apple.com>> wrote: >> >> I think that this is great! >> >> I agree with the policy that we should use JSValue everywhere that it would >> give us the same codegen/ABI (args in registers, return in registers, etc). >> >> -Filip >> >&g

[webkit-dev] Reducing the use of EncodedJSValue and use JSValue directly instead.

Over the holiday period, I looked into the possibility of giving EncodedJSValue a default constructor (because I didn’t like having to return encodedJSValue() instead of { } in lots of places), and learned why we had EncodedJSValue in the first place (i.e. for C linkage). This led me to

[webkit-dev] Said Abou-Hallawa is now a WebKit reviewer

Hi everyone, I would like to announce that Said Abou-Hallawa is now a WebKit reviewer. Said’s expertise is on SVG/graphics and image decoders. You may now ask Said to help review your code. Said, congratulations. Mark ___ webkit-dev mailing list

[webkit-dev] Wenson Hsieh is now a WebKit reviewer

Hi everyone, I would like to announce that Wenson Hsieh is now a WebKit reviewer. Wenson has worked on CSS Scroll Snapping, HTML forms, iOS gesture code, HTML editing, media, and more. You may now ask Wenson to help review your code. Wenson, congratulations. Mark

[webkit-dev] Point within WebKit API to extract Bitmaps

Hi Folks We have code which extracts RGB+A bitmaps from WebKit pages in real time. Currently we do this via an OSX WebKit View in a window and by requesting the bitmap through the OSX View mechanism (not directly from WebKit). It works well and we get clean RGB+A in real time from the WebKit

[webkit-dev] Manuel Rego Casasnovas is now a WebKit Reviewer

Hi everyone, I just want to announce that Manuel Rego Casasnovas <r...@igalia.com> (aka rego) is now a WebKit Reviewer. He has expertise in CSS, layout, selection, and the GTK port. You may now ping him for reviews. Congratulations, Rego. Cheers

[webkit-dev] webkit not remembering or asking to remember passwords

. Any ideas? cheers Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Jon Lee is now a WebKit Reviewer

FYI, I just want to announce that Jon Lee is now a WebKit reviewer. You may now send him patches to review. Jon, congratulations. Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Keith Miller is now a WebKit reviewer

Hi everyone, Just want to announce that Keith Miller is now a reviewer. Keith primarily works on JavaScriptCore. Feel free to ask him for reviews. Congratulations, Keith. Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https

[webkit-dev] Joanmarie Diggs is now a WebKit reviewer

Hi everyone, Just want to announce that Joanmarie Diggs is now a reviewer. Joanmarie primarily works on GTK accessibility and is a current editor of the ARIA spec (https://www.w3.org/TR/wai-aria-1.1/ ). Congratulations, Joanmarie.

Re: [webkit-dev] Sukolsak Sakshuwong is now a WebKit Reviewer

Turns out Sukolsak wasn’t on webkit-dev earlier. But he is now. Sokol, Filip also says congrats, but was not on the thread below. Mark > On Mar 8, 2016, at 7:26 PM, Saam barati <sbar...@apple.com> wrote: > > Congrats Sukol! > > Saam > >> On Mar 8, 2016, at 6

[webkit-dev] Sukolsak Sakshuwong is now a WebKit Reviewer

Hi everyone, Just want to announce that Sukolsak Sakshuwong is now a reviewer. Congratulations, Sukolsak. Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] PSA: Distinguishing between failed release assertions and other crashes

of invalid address 0xbbadbeef. Again, this change will only apply to OS(DARWIN) builds. I’m leaving it up to the linux folks to decide if they also want to adopt this behavior on linux. Thanks. Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] PSA: Distinguishing between failed release assertions and other crashes

FYI, the change has landed in r196397: <http://trac.webkit.org/r196397>. > On Feb 10, 2016, at 3:01 PM, Mark Lam <mark@apple.com> wrote: > > As I shared in a previous email, I’ll be changing the implementation of > WTFCrash() for non-debug OS(DARWIN) builds to use

Re: [webkit-dev] Change WTFCrash to not trash the crash site register state.

of the 0xbbadbeef address. Mark > On Feb 8, 2016, at 12:14 PM, Filip Pizlo <fpi...@apple.com> wrote: > > I like this idea. I’ve wanted this for a while. > > Can you explain why your approach doesn’t inline a store to 0xbbadbeef, so > that this aspect of the current behavior i

[webkit-dev] Change WTFCrash to not trash the crash site register state.

with the existing WTFCrash() implementation and behavior. Does anyone have any opinion / feedback on this change? Thanks. Regards, Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Xabier Rodriguez-Calvar and Michael Catanzaro are now WebKit reviewers

Hi everyone, With pleasure, I would like to announce that Xabier Rodriguez-Calvar and Michael Catanzaro are now WebKit reviewers. Congratulations to Xabier and Michael. Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https

[webkit-dev] Youenn Fablet is now a WebKit reviewer

Hello everyone, I would like to announce that Youenn Fablet is now a WebKit reviewer. Please send him your congratulations, and some requests for patch reviews too. :-) Youenn, congratulations. Mark ___ webkit-dev mailing list webkit-dev

[webkit-dev] Lucas Forschler is now a WebKit reviewer

Hi everyone, Just want to announce that Lucas Forschler is now a reviewer. Congratulations, Lucas. Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Infinite JavaScript loop blocks the MiniBrowser

JSContextGroupSetExecutionTimeLimit() again. Hence, you’re probably not resetting the watchdog after a time out. Regards, Mark On Jul 29, 2015, at 9:54 AM, Mark Lam mark@apple.com wrote: Pascal, You can take a look at ExecutionTimeLimitTest.cpp for examples of the watchdog in action

Re: [webkit-dev] Infinite JavaScript loop blocks the MiniBrowser

. Regards, Mark On Jul 28, 2015, at 11:14 AM, Geoffrey Garen gga...@apple.com wrote: Mark, do you know how to restart JavaScript after it has reached a watchdog time limit? Geoff On Jul 28, 2015, at 9:09 AM, Pascal Jacquemart p.jacquem...@samsung.com mailto:p.jacquem...@samsung.com wrote

Re: [webkit-dev] If you like writing memory smashers, you'll love this

://trac.webkit.org/changeset/153767 http://trac.webkit.org/changeset/153767. It’s somewhat academic though since bmalloc is what is in use on tip of tree. Do we intend to move the remaining ports over to bmalloc so we can remove TCMalloc from the tree? - Mark

Re: [webkit-dev] If you like writing memory smashers, you'll love this

in WebKit nightly builds, spade builds, and release builds. Is this in reference to bmalloc? Instruments allocation tracking, leaks, and heap were supported with TCMalloc-based FastMalloc for quite some time. - Mark ___ webkit-dev mailing list webkit-dev

Re: [webkit-dev] Downtime for Bugzilla upgrade on Thursday, October 16 from 8-10 AM PDT

where it is! - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Using OfflineAsm

Loop LLINT if you don’t want to tackle the ASM LLINT. The C Loop LLINT is intended to be simple and not intended to be super optimized, but any improvements that does not come at the cost of too much added complexity is welcomed. Regards, Mark Thanks for any feedback Chris Vienneau

Re: [webkit-dev] Using OfflineAsm

On Sep 5, 2014, at 4:05 PM, Mark Lam mark@apple.com wrote: 4) Should I actually expect a performance increase compared to the “C LOOP”? Yes. The ASM LLINT should be faster than the C LOOP LLINT. To clarify, the C LOOP LLINT emulated a CPU’s behavior using emitted C instructions

Re: [webkit-dev] Mac WK1 EWS bots having issues

builds every so often while the buildbots don’t. - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Mac WK1 EWS bots having issues

On Aug 15, 2014, at 09:22, Mark Rowe mr...@apple.com wrote: On Aug 15, 2014, at 02:10, Osztrogonác Csaba o...@inf.u-szeged.hu mailto:o...@inf.u-szeged.hu wrote: Hi, it seems the Apple Mac WK1 EWS bots have problems: http://webkit-queues.appspot.com/queue-status/mac-ews http

Re: [webkit-dev] ftlopt merge - basically done

Ossy, Filip is on vacation. I’m keeping an eye on this issue, and will see what we can do about it. It may take some time. Just letting you know that we’re not ignoring it. Thanks. Mark On Aug 8, 2014, at 12:59 AM, Osztrogonác Csaba o...@inf.u-szeged.hu wrote: Hi Filip, the latest

Re: [webkit-dev] FeatureDefines.h and .xcconfig

Xcode project has script phases that do different work depending on whether or not ENABLE_FTL_JIT is set. It’s not sure this can be avoided. - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit

Re: [webkit-dev] Style proposal for branch style for macros

argument in favor of this change I’m firmly against it. - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Style proposal for branch style for macros

On Apr 20, 2014, at 13:08, Filip Pizlo fpi...@apple.com wrote: On Apr 20, 2014, at 12:56 PM, Mark Rowe mr...@apple.com wrote: On Apr 19, 2014, at 13:09, Filip Pizlo fpi...@apple.com wrote: Hey everyone, When guarding code with macros that are always defined

Re: [webkit-dev] Style proposal for branch style for macros

()), node-structure()); m_jit.breakpoint(); isOK.link(m_jit); } else speculateCell(node-child1()); I disagree with your assertion that the latter is clearer. It’s certainly different, but how is it an improvement? - Mark

Re: [webkit-dev] Style proposal for branch style for macros

On Apr 20, 2014, at 13:19, Mark Rowe mr...@apple.com wrote: On Apr 20, 2014, at 13:08, Filip Pizlo fpi...@apple.com wrote: On Apr 20, 2014, at 12:56 PM, Mark Rowe mr...@apple.com wrote: On Apr 19, 2014, at 13:09, Filip Pizlo fpi...@apple.com wrote: Hey everyone, When

Re: [webkit-dev] Style proposal for branch style for macros

branches of an if will compile. - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Style proposal for branch style for macros

On Apr 20, 2014, at 14:50, Filip Pizlo fpi...@apple.com wrote: On Apr 20, 2014, at 2:43 PM, Mark Rowe mr...@apple.com wrote: On Apr 20, 2014, at 14:02, Filip Pizlo fpi...@apple.com wrote: The #if means that the code being guarded isn't indented. I believe that indenting control

Re: [webkit-dev] Support for 10.8.5

about the nature of the problem you’re seeing. For what it’s worth, the Mountain Lion build bots (e.g., http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20%28Build%29) appear to be building successfully. - Mark ___ webkit-dev mailing list

Re: [webkit-dev] Questions about JSC CLoop crashes on ppc64

cc’ing webkit dev because there may be other folks who might be interested in this information, and/or may also be able to help. On Apr 1, 2014, at 6:57 AM, Tomas Popela tpop...@redhat.com wrote: Hi Mark, if you don't mind I have some questions for you regarding to https://bugs.webkit.org

Re: [webkit-dev] *.webkit.org downtime Tuesday, 3/11

I’ve just fixed both trac.webkit.org and git.webkit.org. Please let us know if you notice any further issues. Thanks, - Mark On Mar 11, 2014, at 23:53, Osztrogonác Csaba o...@inf.u-szeged.hu wrote: Additionally git.webkit.org is stucked too on r165452. Osztrogonác Csaba írta: Hi

Re: [webkit-dev] Seeking help/guidance with ParserError::StackOverflow porting JavaScriptCore to Android

is that you will get an uninformative StackOverflowError where the JS stack trace may not contain useful info. If your total stack is that small, you will need to work with smaller N_min and N_exception values. Regards, Mark On Feb 21, 2014, at 6:05 PM, Eric Wing ewmail...@gmail.com wrote

Re: [webkit-dev] How did Apple build libicucore.dylib?

named libicucore.dylib here. - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] C stack direction

growing stack? I’m wondering whether to drop support for upward growing stacks altogether. Our JITs already don’t support it. Any opinions? Thanks. Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo

Re: [webkit-dev] Minimum supported Xcode version is changing

able to reproduce this error myself. The WebKit nightly builds have been built with Xcode 5 for the last week or two now without problems. If you can email me your entire output of build-webkit off-list I’ll see if I can spot what’s going awry. - Mark

[webkit-dev] Minimum supported Xcode version is changing

should upgrade directly to Xcode 5 via the App Store. Please let me know if you have any questions or concerns. - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Minimum supported Xcode version is changing

On 2013-09-20, at 1:01 PM, Mark Rowe mr...@apple.com wrote: On 2013-09-20, at 12:59 PM, Bem Jones-Bey bjone...@adobe.com wrote: Did you fix it so that the build works on Mountain Lion when running Xcode 5? As of yesterday, the tree didn't build on Mountain Lion with Xcode 5

Re: [webkit-dev] TimerWindowWndProc and dangling page instances

to see if the window is still a tool tip window before deleting it. I don't know if anyone wants to see a patch land for either of these problems, they're confined to embedded WebKit on Windows under .NET... Mark From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-boun...@lists.webkit.org

Re: [webkit-dev] Moving LayoutTests/fast/js to LayoutTests/js

FYI, the move has been completed. On Sep 6, 2013, at 5:06 PM, Mark Lam mark@apple.com wrote: This is a courtesy notice: FYI, I’m in the process of moving LayoutTests/fast/js to LayoutTests/js for https://bugs.webkit.org/show_bug.cgi?id=120899. This change will touch many files

[webkit-dev] Moving LayoutTests/fast/js to LayoutTests/js

This is a courtesy notice: FYI, I’m in the process of moving LayoutTests/fast/js to LayoutTests/js for https://bugs.webkit.org/show_bug.cgi?id=120899. This change will touch many files in the test files and in Tools/Scripts to update the paths that expect fast/js to look for js instead. Mark

Re: [webkit-dev] ChangeLog format

://bugs.webkit.org/show_bug.cgi?id=119872 What benefit does duplicating the bug number in the first line provide? It’s just yet another thing to have to add when writing the ChangeLog entry. - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https

Re: [webkit-dev] ChangeLog format

On 2013-08-22, at 12:46 AM, Carlos Garcia Campos carlo...@webkit.org wrote: El jue, 22-08-2013 a las 00:41 -0700, Mark Rowe escribió: On 2013-08-21, at 11:11 PM, Carlos Garcia Campos carlo...@webkit.org wrote: I see, I thought ChangeLog parser was used everywhere. So, I guess the solution

Re: [webkit-dev] Upcoming changes to WebKit's logging functionality

On 2013-08-02, at 4:39 PM, Mark Rowe mr...@apple.com wrote: As part of improving WebKit's logging subsystem on OS X (https://webkit.org/b/119031) I'm refactoring the code in WebCore, WebKit and WebKit2 that initializes logging channels. I'm doing this to reduce the need to touch several

[webkit-dev] Mavericks Nightly

Hi Folks. Any news on when we can get a nightly build to run on Mavericks ? ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Mavericks Nightly

On 2013-06-19, at 10:12 AM, Mark Gilbert web...@gallery.co.uk wrote: Hi Folks. Any news on when we can get a nightly build to run on Mavericks ? After it is released. - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https

Re: [webkit-dev] compact ICU unicode

out huge features like memory inspector / shadow DOM that are not unmaintained...) Mark -Original Message- From: Thomas Fletcher [mailto:tho...@cranksoftware.com] Sent: Thursday, June 13, 2013 7:38 PM To: Glenn Adams Cc: Salisbury, Mark; WebKit Development (webkit-dev@lists.webkit.org

[webkit-dev] compact ICU unicode

, call it what you like - BASIC_ICU_UNICODE, ICU_LITE_UNICODE, COMPACT_ICU_UNICODE, etc.. I think it might be valuable for other ports that are size conscious - the up and coming NIX port comes to mind. Thanks, Mark Background: After rebasing my WinCE port of webkit, I ran into an ASSERT

  1   2   3   4   5   >