Re: [Wikitech-l] RfC update: LESS stylesheet support in core

2013-09-22 Thread Krinkle
On Sep 19, 2013, at 11:19 PM, C. Scott Ananian canan...@wikimedia.org wrote: @dan: the particular less isn't very powerful issues I'm concerned about are the ones solved by compass. As is well-known, there is no equivalent to compass for less, and is not likely every to be, since less can not

[Wikitech-l] New! mw.Title reborn

2013-10-07 Thread Krinkle
Hey all, Last Friday, the mw.Title rewrite landed in master. Here's a brief summary of the changes. TL:DR; * New static constructor mw.Title.newFromText (returns mw.Title or null). * New internal title parser (uses wgLegalTitleChars and mirrors most of Title::secureAndSplit). * Bugs like

Re: [Wikitech-l] MediaWiki core code coverage report

2013-10-18 Thread Krinkle
the covering detection. It's more like a filter to to keep everything else out. Great :) -- Krinkle On 2013-10-18, at 18:38, Erik Bernhardson ebernhard...@wikimedia.org wrote: different definitions of test ;-) code touched seems like a much less useful metric than code specifically tested, but i

[Wikitech-l] First round of loggable javascript deprecations

2013-10-30 Thread Krinkle
, deprecation notices or other messages and try to address them soon (or report it to the maintainers of the gadgets triggering them). -- Krinkle [1] https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.log-method-deprecate ___ Wikitech-l mailing list

[Wikitech-l] Tip for Sublime Text editors: DocBlockr plugin and conf for JSDuck

2013-11-19 Thread Krinkle
in Subllime the easy way using Package Control[6], or check out the plugin page[2] for manual installation. -- Krinkle [1] http://www.sublimetext.com/ [2] https://github.com/spadgos/sublime-jsdocs [3] Type /** followed by tab to insert the template, then tab trough placeholders to fill them in [4

Re: [Wikitech-l] New collapsible elements behavior or more option for mw-collapsible

2013-11-28 Thread Krinkle
supports this already (by using the header itself as a custom toggle). However, depending on how your custom toggle is styled, there should imho be a separate toggle or other kind of user interface component to indicate collapsibility. -- Krinkle

Re: [Wikitech-l] Re-evaluating MediaWiki ResourceLoader's debug mode

2013-12-17 Thread Krinkle
due to the slowness in debug=true, it simply didn’t provide anything I already had. — Krinkle [1] http://www.html5rocks.com/en/tutorials/developertools/sourcemaps/ ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org

Re: [Wikitech-l] chrome new version alway tips event.returnValue

2013-12-17 Thread Krinkle
to false (it is a boolean property after all) it would look at e.returnValue. * They are now using (jQuery v1.11.0-pre, latest upstream master): e.defaultPrevented ( … ) e.defaultPrevented === undefined e.returnValue === false -- Krinkle

Re: [Wikitech-l] SpecialPage::getTitle deprecated?!

2014-03-03 Thread Krinkle
with the MediaWiki core release they are associated with and you can move on in the master branch to react to changes in latest master. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo

Re: [Wikitech-l] CSS Regressions

2014-03-14 Thread Krinkle
See also: https://bugzilla.wikimedia.org/show_bug.cgi?id=62633 -- Krinkle On 10 Mar 2014, at 22:04, Jon Robson jdlrob...@gmail.com wrote: I just wondered if anyone doing MediaWiki development had any experience in catching CSS regressions? We have had a few issues recently in mobile land

[Wikitech-l] Continuous integration updates

2014-04-11 Thread Krinkle
• https://github.com/jshint/jshint/releases • http://jshint.com/blog/new-in-jshint-oct-2013/ • http://jshint.com/blog/new-in-jshint-dec-2013/ — Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https

Re: [Wikitech-l] Callback for mw.toolbar.addButton() executes on edit view load instead of on click

2014-04-23 Thread Krinkle
-method-addButton If you need a callback, I'd recommend you re-enable the WikiEditor toolbar instead of the legacy classic toolbar, and use its API to add a button instead. The WikiEditor API provides a wide range of features, including a callback. — Krinkle

Re: [Wikitech-l] Callback for mw.toolbar.addButton() executes on edit view load instead of on click

2014-04-23 Thread Krinkle
a dependency, but because you don't want to trigger a load of this module (you merely want to hook into it if the toolbar is there, you don't want to load another toolbar which is what adding a dependency would do). — Krinkle On 23 Apr 2014, at 14:21, Justin Folvarcik jfolvar...@gmail.com wrote: Am I

Re: [Wikitech-l] jquery.accessKeyLabel broke mobile

2014-04-27 Thread Krinkle
The module was split out of mediawiki.util, nothing new, no need for any special treatment here. It should've been given the same target definition as mediawiki.util. — Krinkle On 27 Apr 2014, at 19:37, Jon Robson jdlrob...@gmail.com wrote: Looks like jquery.accessKeyLabel now seems

[Wikitech-l] Upcoming jQuery upgrade (breaking change)

2014-05-07 Thread Krinkle
features. For example, jQuery released v1.11 and v2.1 together[4][5]. -- Krinkle [1] http://blog.jquery.com/2013/01/15/jquery-1-9-final-jquery-2-0-beta-migrate- final-released/ [2] http://jquery.com/upgrade-guide/1.9/ [3] http://blog.jquery.com/2013/04/18/jquery-2-0-released/ [4] http

Re: [Wikitech-l] Change the installer to make Project: the default option for meta namespace name

2014-05-13 Thread Krinkle
/wiki/Wikipedia_ discusión:X — Krinkle On 11 May 2014, at 16:15, Matthew Flaschen mflasc...@wikimedia.org wrote: On 05/04/2014 05:08 AM, Max Semenik wrote: This proposal makes no sense: all these namespaces _are_ dependent on wiki language, so even if you force Project down the throats of non

Re: [Wikitech-l] Upcoming jQuery upgrade (breaking change)

2014-05-14 Thread Krinkle
there are no deprecation notices being fired when using them. In addition, (to see if maybe you missed any) you could perform a few grep/ack searches if you want to be extra sure (manually, so that you can mentally exclude false positives). — Krinkle On 7 May 2014, at 19:27, Siebrand Mazeland siebr

Re: [Wikitech-l] Upcoming jQuery upgrade (breaking change)

2014-05-14 Thread Krinkle
().stack } ); }; } I might set up some tracking for it at Wikimedia as well, but I'm not sure if that'll work properly. — Krinkle [1] https://github.com/wikimedia/mediawiki-core/blob/wmf/1.24wmf4/resources/src/mediawiki/mediawiki.js#L567 [2] https://github.com/wikimedia/mediawiki-core/blob/wmf

Re: [Wikitech-l] Upcoming jQuery upgrade (breaking change)

2014-05-23 Thread Krinkle
On 23 May 2014, at 03:11, Gergo Tisza gti...@wikimedia.org wrote: On Wed, May 7, 2014 at 9:29 AM, Krinkle krinklem...@gmail.com wrote: A rough timeline: * 12 May 2014 (1.24wmf4 [9]): Phase 1 – Instrumentation and logging starts. This will run for 4 weeks (until June 9). * 19 May 2014

Re: [Wikitech-l] What should be the recommended / supported way to do skins? (A proposal.)

2014-05-25 Thread Krinkle
. anywhere HTML is displayed, whenever it is used inside an message) - Defined by msg key skinnname-{skin} — Krinkle On 25 May 2014, at 18:02, Bartosz Dziewoński matma@gmail.com wrote: On Sun, 25 May 2014 00:11:28 +0200, Daniel Friesen dan...@nadir-seen-fire.com wrote: However

Re: [Wikitech-l] Accessing current template information on wiki commons description page

2014-06-03 Thread Krinkle
://commons.wikimedia.org/wiki/Commons:Commons_API https://tools.wmflabs.org/magnus-toolserver/commonsapi.php https://tools.wmflabs.org/magnus-toolserver/commonsapi.php?image=Van%20Gogh%20-%20Starry%20Night%20-%20Google%20Art%20Project.jpgmeta — Krinkle On 3 Jun 2014, at 14:11, Derk-Jan Hartman

[Wikitech-l] [BREAKING CHANGE] Upcoming jQuery upgrade: Removing jQuery Migrate

2014-06-03 Thread Krinkle
these legacy features are aware of this so they may patch the code accordingly (using the upgrade guide[4] and my earlier announcement [5]). When MediaWiki 1.24 is released, we will switch off jQuery Migrate for Wikimedia wikis. — Krinkle [1] https://bugzilla.wikimedia.org/show_bug.cgi?id=44740

Re: [Wikitech-l] enwiki display issues

2014-06-04 Thread Krinkle
://wikitech.wikimedia.org/w/index.php?title=Server_Admin_Logdiff=113204oldid=113199 I documented the incident just now: https://wikitech.wikimedia.org/wiki/Incident_documentation/20140517-bits — Krinkle On 1 Jun 2014, at 17:22, Helder . helder.w...@gmail.com wrote: On Sat, May 31, 2014 at 1

Re: [Wikitech-l] LiquidThreads - how do we kill it?

2014-06-08 Thread Krinkle
On 8 Jun 2014, at 17:22, James Forrester jforres...@wikimedia.org wrote: — Krinkle On Sunday, June 8, 2014, Martijn Hoekstra martijnhoeks...@gmail.com wrote: On Sun, Jun 8, 2014 at 1:18 AM, Martijn Hoekstra martijnhoeks...@gmail.com javascript:; wrote: Flow stores the comments

Re: [Wikitech-l] Making a plain MW core git clone not be installable

2014-06-11 Thread Krinkle
depended on any PEAR packages. We either shipped them (Services_JSON), provided a fallback or made the feature optional / in an extension. -- Krinkle [1] Easier to instal because it requires less permissions since it uses local directory. Easier to deploy because of this. And managed with a manifest

Re: [Wikitech-l] LiquidThreads - how do we kill it?

2014-06-11 Thread Krinkle
. -- Krinkle [1] Would've roughly looked like this: http://i.imgur.com/fK1NV2G.png ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Best practices for loading large, pre-minified JavaScript modules?

2014-07-13 Thread Krinkle
use modules=my.module.nameonly=scriptsdebug=true. Like all unversioned requests, this is only cached for 5 to 30 minutes (depending on mediawiki configuration). -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https

Re: [Wikitech-l] logging out on one device logs user out everywhere

2014-07-23 Thread Krinkle
have a section Trusted Browsers which is slightly different in that it lists sessions that are of the Remember me type and also lists authenticated devices that won't ask for two-step verification again. And the ability to revoke any of them. — Krinkle [1] E.g. not expectation based on previous

Re: [Wikitech-l] jQuery UI 1.10.4 and IE6 support

2014-07-26 Thread Krinkle
to a version that drops support for an API after we first upgrade to a version that provides the new API.[4] — Krinkle [1] http://jqueryui.com/download/ and their source repository continues to maintain jQuery UI 1.11.x, 1.10.x and 1.9.x [2] http://blog.jqueryui.com/2013/01/jquery-ui-1-10-0/ [3] http

Re: [Wikitech-l] jQuery UI 1.10.4 and IE6 support

2014-07-26 Thread Krinkle
to throw an exception in an older browser per se, in case of jQuery UI it's quite simple. We can only upgrade to jQuery 1.10 when we drop IE6 support for Grade A. And when we do, IE6 will become javascriptless[1] and jQuery UI will no longer be relevant as problem in IE6. — Krinkle [1] https

Re: [Wikitech-l] Policy on browser support

2014-07-27 Thread Krinkle
On 26 Jul 2014, at 22:32, Steven Walling steven.wall...@gmail.com wrote: This seems really reasonable. Are we still agreed that Grade A means anything over 1% of readership? If so, we should reconfirm what our browser share is really like, because last time I checked, IE6 was less than 1%

Re: [Wikitech-l] jQuery UI 1.10.4 and IE6 support

2014-07-28 Thread Krinkle
Support can mean either depending on the context. Most of this is uncontroversial, but I found it useful to think through and sum up. From a platform perspective to support a browser means that the user experience is considered acceptable, tested against, and we're committed to keeping it that

Re: [Wikitech-l] Moving Vector and MonoBook to separate repositories and what it means for you

2014-07-29 Thread Krinkle
of simplicity and compatibility. Breaking things can be good, but I haven't seen any short or long term benefits so far that would justify it. — Krinkle On 28 Jul 2014, at 23:02, John phoenixoverr...@gmail.com wrote: I use a standard git checkout. Moving these to their own separate location is going

Re: [Wikitech-l] Disabling JS support in additional browsers

2014-08-24 Thread Krinkle
enough to just give it everything (Grade X instead of Grade B) per a Village Pump thread requesting it.[3] — Krinkle [1] https://jquery.com/browser-support/ [2] https://www.mediawiki.org/w/index.php?title=Compatibilityoldid=1119439#Browser_support_matrix [3] https://github.com/wikimedia

Re: [Wikitech-l] Disabling JS support in additional browsers

2014-08-26 Thread Krinkle
restrictions related to site performance (changing the banners without purging every single article on every wiki from cache, js seems the only way to project changed content separately). -- Krinkle Interesting read: http://www.theverge.com/2014/8/19/6044679/the-six-lawsuits-that-shaped

Re: [Wikitech-l] AJAX mw.util.wikiscript with POST

2014-09-05 Thread Krinkle
://api.jquery.com/jQuery.post/ https://api.jquery.com/jQuery.ajax/ — Krinkle PS: Please use the Promise interface, not the callback parameters. Don't forget to handle errors, either. PS2: While this will help you get the request over POST, the underlying subsystem you're communicating with (action=ajax

Re: [Wikitech-l] Standardizing highest priority in Bugzilla

2012-11-27 Thread Krinkle
clarity instead of adding more options that represent a multiple of values in other fields which then also need to be set separately (Commons categories comes to mind, like Category:Blue objects made of recycled glass hanging upside-down in Amsterdam, Netherlands). -- Krinkle

Re: [Wikitech-l] WMF's webpage

2012-11-28 Thread Krinkle
are deployed globally and site-wide within 5 minutes. Whereas the html isn't for another 2 weeks. This is why client resources must always be backwards compatible. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https

Re: [Wikitech-l] Really Fast Merges

2012-12-05 Thread Krinkle
scores. Submission in turn only has to be restricted to CR+2. But yeah, we need to either whitelist L10n-bot from this restriction or make those commits auto-merge in a different way. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

Re: [Wikitech-l] Really Fast Merges

2012-12-05 Thread Krinkle
that. That was the reason it was brought up, and the reason it was subsequently reverted again. Nothing personal and not (directly) related to the contents of the commit itself. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https

Re: [Wikitech-l] Bugzilla upgrade [was: bugzilla.wikimedia.org downtime: Now.]

2012-12-11 Thread Krinkle
, wikibugs-l is configured as globalwatcher. The proposal Andre makes here sounds confusing, How is that different from the current situation? What problem is it supposed to address? -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

Re: [Wikitech-l] Bugzilla: Waiting for merge status when patch is in Gerrit?

2012-12-12 Thread Krinkle
details just open the bug and read it. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Bugzilla upgrade [was: bugzilla.wikimedia.org downtime: Now.]

2012-12-14 Thread Krinkle
removed from bugs when someone assigns a bug or otherwise ends up removing it for some reason). -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Clarification on unit tests requiring CR+2

2012-12-19 Thread Krinkle
Hello, We would like to clarify the reason we changed Jenkins to no longer run unit tests on patch submission. We had to defer code execution to after CR+2 for security reasons. If unit tests were ran on submission that meant anyone with a labs account could effectively get shell access on the

Re: [Wikitech-l] Small tweak to Gerrit Verified category - tomorrow

2012-12-19 Thread Krinkle
. Now that everything is in place we can elaborate on this. Antoine and I sent out a mai to wikitech-l just now: http://lists.wikimedia.org/pipermail/wikitech-l/2012-December/065202.html -- Krinkle ___ Wikitech-l mailing list Wikitech-l

Re: [Wikitech-l] Gerrit code review guidelines

2012-12-31 Thread Krinkle
On Dec 27, 2012, at 7:18 PM, Juliusz Gonera jgon...@wikimedia.org wrote: Hi, I'm a bit confused when it comes to various options I have in gerrit and it seems the docs are not up to date on that. * What is the difference between Verified and Code Review? When would I put +1 in one of

Re: [Wikitech-l] Adding support for Twitter Cards

2012-12-31 Thread Krinkle
is Twitter card? and what this extension do? https://www.google.com/search?q=twitter+cardsbtnI=1 -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Generating documentation from JavaScript doc comments

2013-01-04 Thread Krinkle
from the cronjob on svn.wikimedia.org?). -- Krinkle [1] Perfectionist alert, this commit does more than just the necessary tweaks: https://gerrit.wikimedia.org/r/42221/ ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https

Re: [Wikitech-l] Krenair for core

2013-01-06 Thread Krinkle
://gerrit.wikimedia.org/r/#/c/38258/: where Bsitu did CR+1 and Alex no review on the final version but is in the reviewer/CC list. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Rewriting ExtensionDistributor

2013-01-07 Thread Krinkle
already use: REL1_20 etc. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Disable module mediawiki.searchSuggest in MW 1.20+

2013-01-16 Thread Krinkle
to this feature? Most of this module is pretty trivial and only wraps around other features that have elaborate hooks and toggles (such as PrefixIndex and the API). -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https

Re: [Wikitech-l] Disable module mediawiki.searchSuggest in MW 1.20+

2013-01-18 Thread Krinkle
On Jan 17, 2013, at 10:05 AM, Robert Vogel vo...@hallowelt.biz wrote: @Krinkle: I've written a custom API module that returns categorized results. I wanted to have a categorized output like in this demo: http://jqueryui.com/autocomplete/#categories My first approach was to override some

Re: [Wikitech-l] varying ResourceLoader module dependencies

2013-01-28 Thread Krinkle
the extension is disabled and also swap the front-end client for a no-op. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] URLs for autogenerated documentation

2013-02-08 Thread Krinkle
be confusing, decentralising and depending on the implementation, it would encourage using multiple urls for the same thing. Might as well stick with one canonical url. Best, -- Krinkle [1] https://gerrit.wikimedia.org/r/39212 ___ Wikitech-l mailing list

Re: [Wikitech-l] Revoking +2 (Re: who can merge into core/master?)

2013-02-14 Thread Krinkle
. These 2 cases (and maybe more, such as i18n-bot) were the reasons that a few weeks/months back we didn't make the change in Gerrit to make self-merging no longer an option (e.g. reject merge attempts by the author of the change). -- Krinkle ___ Wikitech

Re: [Wikitech-l] When to automerge (Re: Revoking +2 (Re: who can merge into core/master?))

2013-02-15 Thread Krinkle
explain) not approve it. And for the same reason, when that reviewer backports himself, he wouldn't self-merge. Or rather, he wouldn't draft such a change in the first place. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https

Re: [Wikitech-l] Mediawiki's access points and mw-config

2013-02-18 Thread Krinkle
with having a directory? -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Code Review Dashboards of other users in gerrit

2013-02-19 Thread Krinkle
by simply clicking the username on any page where it is mentioned. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Who is responsible for accepting backported patch sets for maintained versions?

2013-02-21 Thread Krinkle
to approve the merge instead of self-merging right away. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Caching Discussion: Dealing with old (deleted) wmf branches

2013-02-22 Thread Krinkle
On Feb 22, 2013, at 6:33 PM, Greg Grossmeier g...@wikimedia.org wrote: Hello all, Background and longer/more detailed discussion on this issue is in bug 44570: https://bugzilla.wikimedia.org/show_bug.cgi?id=44570 Summary: As w e delete old -wmfX branches there appears to be cached

Re: [Wikitech-l] LQT and MediaWiki

2013-02-24 Thread Krinkle
extensions after every release and provide them as options in the extension distributor. https://www.mediawiki.org/wiki/Special:ExtensionDistributor/LiquidThreads -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https

[Wikitech-l] QUnit testing in Jenkins

2013-03-04 Thread Krinkle
for the QUnit job. Happy testing, -- Krinkle [1] https://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing [2] PhantomJS: http://phantomjs.org/ [3] node-phantomjs (npm wrapper with nom-install hook) https://github.com/Obvious/phantomjs [4] grunt-contrib-qunit https://github.com/gruntjs/grunt-contrib

Re: [Wikitech-l] Extensions meta repo problem with MaintenanceShell

2013-03-05 Thread Krinkle
the normal way? I did a one-time import of the original history, replacing the empty repository. After that I merged 3 changes via Gerrit[1] and there have been no forced pushes since. -- Krinkle [1] as indicated by the pink ref/changes labels: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki

Re: [Wikitech-l] QUnit testing in Jenkins

2013-03-05 Thread Krinkle
and you'll see the same data in your browser's console (e.g. Chrome Dev Tools). -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Seemingly proprietary Javascript

2013-03-05 Thread Krinkle
well that analogy flies, -- Krinkle [1] https://upload.wikimedia.org/wikipedia/commons/thumb/e/eb/Baantjegracht_Dokkum_2010.jpg/160px-Baantjegracht_Dokkum_2010.jpg [2] https://upload.wikimedia.org/wikipedia/commons/e/eb/Baantjegracht_Dokkum_2010.jpg

Re: [Wikitech-l] Github/Gerrit mirroring

2013-03-05 Thread Krinkle
it and submit it to Gerrit. The only minor detail is closing the PR. When that happens and who that does. The who is clear, someone with write access to the Wikimedia GitHub account. The when, could be when it is taken to Gerrit, could be when it lands in master. -- Krinkle [1] Squash because

Re: [Wikitech-l] Global user CSS and JS

2013-03-05 Thread Krinkle
the global script instead of from local preferences, which are rather annoying to maintain imho. if ( dbname == wikidatawiki || .. ) { return; } -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-13 Thread Krinkle
core) If not on displayed in Gerrit, then from git-cli via a web tool (how does that grep perform, is it fast enough?) Ofcourse, changing would still go from cli (not w/ the web tool). -- Krinkle On 14 mrt. 2013, at 00:07, Christian Aistleitner christ...@quelltextlich.at wrote: Hi, On Tue

Re: [Wikitech-l] Reminder about the best way to link to bugs in commits

2013-03-21 Thread Krinkle
and always lowercase by convention. The footer being clickable is done independently. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] RFC: New approach to release notes

2013-05-02 Thread Krinkle
this on for the near future. However I'm convinced we have enough people who care and will filter the incoming stream on the wiki page. Simply look at the git history of release notes files (I expect at least Reedy and hexmode will naturally be drawn to this). -- Krinkle [1] Other reasons include

Re: [Wikitech-l] RFC: New approach to release notes

2013-05-03 Thread Krinkle
On May 2, 2013, at 7:41 PM, Brad Jorsch bjor...@wikimedia.org wrote: I like the idea of not having to mess with RELEASE-NOTES-#.## merge conflicts. But I'm not entirely sure about everything in the proposal. On Thu, May 2, 2013 at 12:30 PM, Krinkle krinklem...@gmail.com wrote: For more

Re: [Wikitech-l] Extensions History in enwiki

2013-05-04 Thread Krinkle
be able to determine exactly when and for how long an extension was deployed. -- Krinkle PS: The public mediawiki-config.git only dates back to 24 Feb 2012. Before that date the information was in a non-public svn repository inside the wmf-production cluster

Re: [Wikitech-l] RFC: New approach to release notes

2013-05-06 Thread Krinkle
On May 3, 2013, at 9:33 PM, Anomie wrote: On Fri, May 3, 2013 at 1:02 PM, Krinkle wrote: First of all, I think a lot of our commit subjects are poorly written, even for a commit message. Having said that, a good commit subject is also a good release note (that is, if the change itself

Re: [Wikitech-l] RFC: New approach to release notes

2013-05-07 Thread Krinkle
On May 7, 2013, at 5:52 PM, Brad Jorsch bjor...@wikimedia.org wrote: On Mon, May 6, 2013 at 10:09 PM, Krinkle krinklem...@gmail.com wrote: On May 3, 2013, at 9:33 PM, Anomie wrote: Taking a recent example[1], please tell me how to compress the following into 62 characters: (in the New

Re: [Wikitech-l] RFC: New approach to release notes

2013-05-08 Thread Krinkle
On May 7, 2013, at 8:56 PM, Bartosz Dziewoński matma@gmail.com wrote: On Tue, 07 May 2013 20:51:07 +0200, Krinkle krinklem...@gmail.com wrote: It is the duty of repository co-owners to make wise decisions beyond just code quality. About what changes go in what release (if at all

[Wikitech-l] Coding style: Language construct spacing

2013-05-08 Thread Krinkle
to disable the rule, thus not catching the ones we do use. See pending change in gerrit that does a quick pass of (most of) these in mediawiki/core: https://gerrit.wikimedia.org/r/62753 -- Krinkle [1] Or whatever the reason is the author originally wrote it like this. Perhaps PHP was different back

Re: [Wikitech-l] Coding style: Language construct spacing

2013-05-14 Thread Krinkle
On May 10, 2013, at 3:22 AM, Tim Starling tstarl...@wikimedia.org wrote: On 09/05/13 10:26, Krinkle wrote: I'm obviously biased, but I think the same goes for require_once (and include, require etc.). Right now this is causing quite a few warnings in our php-checkstyle report. include

Re: [Wikitech-l] [Wikitech-] ResourceLoader loading extension CSS dynamically?

2013-06-05 Thread Krinkle
() to load it from the top. That should fix the flash of unstyled content. -- Krinkle [1] http://www.mediawiki.org/wiki/Manual:$wgResourceModules [2] http://www.mediawiki.org/wiki/ResourceLoader/Features ___ Wikitech-l mailing list Wikitech-l

Re: [Wikitech-l] Why isn't hotcat an extension?

2013-07-18 Thread Krinkle
? -- Yuvi Panda T http://yuvi.in/blog https://www.mediawiki.org/wiki/Extension:InlineCategorizer -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] RFC: LESS support in MediaWiki core

2013-08-22 Thread Krinkle
. -- Krinkle [1] https://www.mediawiki.org/wiki/Extension:Less [2] https://github.com/wikimedia/mediawiki-extensions-Less ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] ResourceLoader support question: how to construct a value in CSS from PHP

2013-08-25 Thread Krinkle
part of a request that also includes other stylesheets and scripts. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Re-introducing UNCONFIRMED state to bugzilla

2012-03-15 Thread Krinkle
? -- Krinkle [1] The difference between a confirmed bug having an assignee and status ASSIGNED, is that ASSIGNED means someone has it on his agenda to actively work on. Whereas the assignee in general is just whoever is currently watching over it. ASSIGNED and IN_PROGRESS are basically there same

[Wikitech-l] Continuous integration workflow post-Git migration

2012-03-17 Thread Krinkle
/Continuous_integration/Workflow so feel free to edit it as you would any other wiki page. -- Krinkle [1] https://www.mediawiki.org/wiki/Talk:Continuous_integration#Proposal_for_continuous_integration_.28post-Git_migration.29_13216 ___ Wikitech-l mailing list Wikitech-l

Re: [Wikitech-l] Auto-created gerrit accounts for users that had enough info in USERINFO

2012-03-17 Thread Krinkle
know bots do look through Not to mention the public archives of lists.wikimedia.org :-) --Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Using prototypical inheritance in dynamically loaded ResourceLoader modules

2012-03-19 Thread Krinkle
MediaWiki inherently does not support that either), so a plain for-in loop over an object (excluding array objects) is perfectly fine according to our conventions. See also http://stackoverflow.com/a/1198447/319266 but so much for the good (and bad, evil) parts of javascript :D -- Krinkle

Re: [Wikitech-l] Using prototypical inheritance in dynamically loaded ResourceLoader modules

2012-03-19 Thread Krinkle
offtopic On Mon, Mar 19, 2012 at 2:23 PM, Krinkle krinklem...@gmail.com wrote: On Mon, Mar 19, 2012 at 9:35 AM, Daniel Friesen li...@nadir-seen-fire.com wrote: On Mon, 19 Mar 2012 00:40:54 -0700, Dmitriy Sintsov ques...@rambler.ru wrote: var jqgmap = []; for ( var mapIndex in jqgmap

Re: [Wikitech-l] JS Iteration (was: Using prototypical inheritance in dynamically loaded ResourceLoader modules)

2012-03-19 Thread Krinkle
ontopic :) On Mon, Mar 19, 2012 at 3:03 PM, Dmitriy Sintsov ques...@rambler.ru wrote: On 19.03.2012 17:23, Krinkle wrote: On Mon, Mar 19, 2012 at 9:35 AM, Daniel Friesen li...@nadir-seen-fire.com**wrote: On Mon, 19 Mar 2012 00:40:54 -0700, Dmitriy Sintsovques...@rambler.ru wrote: var

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-29 Thread Krinkle
+1 for There is a problem with this patchset (without , please improve). I think that keeps it more neutral without saying anything the user doesn't intend to say. It also keeps free ambiguity in the intention (to be disambiguated in a comment) between 'wontfix' and 'fixme'. -- Krinkle On Mar

Re: [Wikitech-l] Email addresses for wikimedians

2012-03-29 Thread Krinkle
is visible. In which case there is no advantage to using an alias over simply using [[Special:EmailUser]], which is effectively also an alias for the first mail. -- Krinkle On Mar 29, 2012, at 9:41 PM, Petr Bena wrote: Hi, Lot of volunteers are using email to communicate when they discuss

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-30 Thread Krinkle
for themselves? -- Krinkle On Mar 29, 2012, at 11:23 PM, Krinkle wrote: +1 for There is a problem with this patchset (without , please improve). I think that keeps it more neutral without saying anything the user doesn't intend to say. It also keeps free ambiguity in the intention

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-30 Thread Krinkle
On Mar 30, 2012, at 3:07 PM, Chad wrote: On Fri, Mar 30, 2012 at 8:49 AM, Krinkle krinklem...@gmail.com wrote: Can we just set it to an empty string and let the numbers and hand-written comment speak for themselves? I think this will be more confusing. You need some text for the radio

Re: [Wikitech-l] jQuery update policy

2012-03-30 Thread Krinkle
On Mar 30, 2012, at 10:14 AM, Amir E. Aharoni wrote: Hi, I made a little localization fix to the jQuery.ui datepicker, which is used by the Upload Wizard. I submitted it upstream through GitHub and it was merged there. Krinkle says that jQuery is supposed to be only modified upstream

Re: [Wikitech-l] GSOC proposal: Native application uploader

2012-04-06 Thread Krinkle
on is that of AIR (uses WebKit). With AIR it still has most desktop application possibilities such as caching files locally, updating the application periodically, storing preferences, accessing the file system, details I/O and up/download uploading/progress meters etc. -- Krinkle [1

Re: [Wikitech-l] You are invited to join the wikiHow source code cleanup project

2012-04-07 Thread Krinkle
on top of MediaWiki core master instead of the latest release so that if you need any additional hooks in MediaWiki core (which likely will be the case on several occasions), you (or someone else) can propose them and after they're reviewed/merged into core you can use them right away. -- Krinkle

Re: [Wikitech-l] MediaWiki.org syntaxhighlight and div of syntaxhighlight lang=php broken

2012-04-14 Thread Krinkle
Bug dupe of https://bugzilla.wikimedia.org/show_bug.cgi?id=35875 Fixed, awaiting review / deployment. -- Krinkle On Sat, Apr 14, 2012 at 8:15 AM, Thomas Gries m...@tgries.de wrote: Has someone recently changed something with the source lang=php extension, style ? Layout is broken filed

Re: [Wikitech-l] Policy for one ore more new database tables for extensions

2012-04-17 Thread Krinkle
, I'd say it's better two tables (say, 'group' and 'item', where item.it_group refers to group.gr_id). So that you don't have to repeat all information about the group in each item-row, and if the group has to change, no need to change all item-rows. -- Krinkle

Re: [Wikitech-l] Wikimedia skins directory

2012-04-17 Thread Krinkle
, and MediaWiki itself has the module definition of it that contians what it needs and from where. This also makes the load module effecient because it is minified (whereas loading main.css directly is just a raw file). -- Krinkle ___ Wikitech-l mailing list

Re: [Wikitech-l] Policy for one ore more new database tables for extensions

2012-04-17 Thread Krinkle
On Wed, Apr 18, 2012 at 12:16 AM, Roan Kattouw roan.katt...@gmail.com wrote: On Tue, Apr 17, 2012 at 5:37 PM, Martijn Hoekstra martijnhoeks...@gmail.com wrote: On Tue, Apr 17, 2012 at 10:51 PM, Krinkle krinklem...@gmail.com wrote: On Apr 17, 2012, at 9:05 AM, Thomas Gries wrote: My

Re: [Wikitech-l] Abstract schema work

2012-04-18 Thread Krinkle
to centralize the concept for further collaboration and feedback. Discussion sometimes continues on wikitech-l, and sometimes on the wiki talk page of the RFC. -- Krinkle [1] https://www.mediawiki.org/wiki/RFC ___ Wikitech-l mailing list Wikitech-l

Re: [Wikitech-l] Commits IDs, change IDs, legacy change IDs, oh my!

2012-04-25 Thread Krinkle
://gerrit.wikimedia.org/r/#q,8d6b19d8c2ed041443b9433298aa08a187ad1d83,n,z * https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git;a=commit;h=8d6b19d8c2ed041443b9433298aa08a187ad1d83 - Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

  1   2   3   4   >