[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369765#comment-15369765
]
Hudson commented on YARN-3044:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584551#comment-14584551
]
Naganarasimha G R commented on YARN-3044:
-
thanks for testing [~zjshen], and yes i
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584775#comment-14584775
]
Naganarasimha G R commented on YARN-3044:
-
Thanks for reviewing and committing the
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584763#comment-14584763
]
Zhijie Shen commented on YARN-3044:
---
Thanks, will commit the patch.
bq. Probably you
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584073#comment-14584073
]
Naganarasimha G R commented on YARN-3044:
-
hi [~zjshen], i have already checked it,
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584034#comment-14584034
]
Zhijie Shen commented on YARN-3044:
---
[~Naganarasimha], thanks for fixing the race, but
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584189#comment-14584189
]
Zhijie Shen commented on YARN-3044:
---
Interesting. Is it an intermittent test failure? I
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14580378#comment-14580378
]
Hadoop QA commented on YARN-3044:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14580508#comment-14580508
]
Naganarasimha G R commented on YARN-3044:
-
[~zjshen],
Seems like many of the test
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14580253#comment-14580253
]
Naganarasimha G R commented on YARN-3044:
-
Hi [~zjshen],
Have taken care of
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573515#comment-14573515
]
Zhijie Shen commented on YARN-3044:
---
I'm not sure because as far as I can tell, NM's impl
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14571732#comment-14571732
]
Zhijie Shen commented on YARN-3044:
---
[~Naganarasimha], thanks for updating the patch. It
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14571685#comment-14571685
]
Hadoop QA commented on YARN-3044:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14571925#comment-14571925
]
Naganarasimha G R commented on YARN-3044:
-
Hi [~zjshen],
bq. It not caused by this
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570171#comment-14570171
]
Zhijie Shen commented on YARN-3044:
---
[~Naganarasimha], I'm fine with the last patch. Will
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565108#comment-14565108
]
Naganarasimha G R commented on YARN-3044:
-
Thanks [~vrushali] for clarifying, But
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565111#comment-14565111
]
Naganarasimha G R commented on YARN-3044:
-
Thanks [~vrushali] for confirming that
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564006#comment-14564006
]
Naganarasimha G R commented on YARN-3044:
-
Hi [~zjshen],
Seems like test case
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564014#comment-14564014
]
Vrushali C commented on YARN-3044:
--
Hi [~Naganarasimha Garla]
bq. Test code failure in
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562253#comment-14562253
]
Hadoop QA commented on YARN-3044:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560416#comment-14560416
]
Zhijie Shen commented on YARN-3044:
---
Naga, sorry for late reply. The new patch looks much
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14547113#comment-14547113
]
Hadoop QA commented on YARN-3044:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14540511#comment-14540511
]
Naganarasimha G R commented on YARN-3044:
-
bq. Sorry to put my comments at last
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14540783#comment-14540783
]
Zhijie Shen commented on YARN-3044:
---
bq. Well i had raised config related queries earlier
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538058#comment-14538058
]
Junping Du commented on YARN-3044:
--
Sorry for coming late on this. Latest patch LGTM too.
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538437#comment-14538437
]
Zhijie Shen commented on YARN-3044:
---
Sorry to put my comments at last minute:
1. I'm
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538146#comment-14538146
]
Zhijie Shen commented on YARN-3044:
---
[~sjlee0], would you mind holding the commit for a
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538152#comment-14538152
]
Sangjin Lee commented on YARN-3044:
---
No problem. Take your time.
[~djp], I'll file a
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538160#comment-14538160
]
Sangjin Lee commented on YARN-3044:
---
YARN-3616 filed.
[Event producers] Implement RM
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533942#comment-14533942
]
Sangjin Lee commented on YARN-3044:
---
Overall it looks good. I think it's real close. I
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14532150#comment-14532150
]
Hadoop QA commented on YARN-3044:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533697#comment-14533697
]
Sangjin Lee commented on YARN-3044:
---
Sorry Naga it's taking a while. I'm going to review
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533378#comment-14533378
]
Hadoop QA commented on YARN-3044:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531957#comment-14531957
]
Hadoop QA commented on YARN-3044:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526147#comment-14526147
]
Hadoop QA commented on YARN-3044:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523390#comment-14523390
]
Naganarasimha G R commented on YARN-3044:
-
Hi [~vinodkv],
bq. But it's really about
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522790#comment-14522790
]
Vinod Kumar Vavilapalli commented on YARN-3044:
---
Apologies for dropping off
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518761#comment-14518761
]
Sangjin Lee commented on YARN-3044:
---
[~zjshen], sorry I missed your comment earlier...
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518760#comment-14518760
]
Sangjin Lee commented on YARN-3044:
---
It looks like some of the issues reported by the
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519906#comment-14519906
]
Naganarasimha G R commented on YARN-3044:
-
Thanks for the review [~djp] [~sjlee0]
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519792#comment-14519792
]
Sangjin Lee commented on YARN-3044:
---
Yes that's kind of what I'm wondering about. So
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520322#comment-14520322
]
Sangjin Lee commented on YARN-3044:
---
{quote}
Some might be but many(findbugs and
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519471#comment-14519471
]
Junping Du commented on YARN-3044:
--
bq. l.179: curious, we could add them to the entity as
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518486#comment-14518486
]
Sangjin Lee commented on YARN-3044:
---
Sorry Naga for falling back on the review. I'll take
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518738#comment-14518738
]
Hadoop QA commented on YARN-3044:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518653#comment-14518653
]
Hadoop QA commented on YARN-3044:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14501026#comment-14501026
]
Junping Du commented on YARN-3044:
--
Thanks [~Naganarasimha] for updating the patch!
Looks
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14497669#comment-14497669
]
Hadoop QA commented on YARN-3044:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14497673#comment-14497673
]
Naganarasimha G R commented on YARN-3044:
-
Hi [~zjshen], [~djp] [~sjlee0],
I have
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493662#comment-14493662
]
Zhijie Shen commented on YARN-3044:
---
bq. correct it when i/Zhijie Shen work on YARN-3390,
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490287#comment-14490287
]
Junping Du commented on YARN-3044:
--
Hi [~Naganarasimha], sorry for coming late.
Just go
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490319#comment-14490319
]
Naganarasimha G R commented on YARN-3044:
-
Thanks for the review [~djp], had gone
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14485797#comment-14485797
]
Naganarasimha G R commented on YARN-3044:
-
Thanks for the review comments
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14485527#comment-14485527
]
Zhijie Shen commented on YARN-3044:
---
Before screening the patch details, I have some high
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14484265#comment-14484265
]
Naganarasimha G R commented on YARN-3044:
-
Hi [~zjshen], [~djp] [~sjlee0],
Can
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14484338#comment-14484338
]
Zhijie Shen commented on YARN-3044:
---
Naga, thanks for the patch. Will take a look at the
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481357#comment-14481357
]
Hadoop QA commented on YARN-3044:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387112#comment-14387112
]
Naganarasimha G R commented on YARN-3044:
-
Hi [~zjshen], [~djp] [~sjlee0],
I am
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387175#comment-14387175
]
Sangjin Lee commented on YARN-3044:
---
bq. I am planning to go ahead with the approach
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382308#comment-14382308
]
Sangjin Lee commented on YARN-3044:
---
{quote}
Well its not the limitation at RM timeline
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382343#comment-14382343
]
Naganarasimha G R commented on YARN-3044:
-
[~sjlee0],
bq. I see. So your point is
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382372#comment-14382372
]
Sangjin Lee commented on YARN-3044:
---
YARN-3401
[Event producers] Implement RM writing
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382362#comment-14382362
]
Sangjin Lee commented on YARN-3044:
---
I'll file a separate JIRA for this.
[Event
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382361#comment-14382361
]
Sangjin Lee commented on YARN-3044:
---
That's a fair point. As a rule, we need to prevent
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382387#comment-14382387
]
Junping Du commented on YARN-3044:
--
Thanks guys for good discussions above especially for
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381453#comment-14381453
]
Naganarasimha G R commented on YARN-3044:
-
Thanks [~vinodkv],[~vrushalic],
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380090#comment-14380090
]
Sangjin Lee commented on YARN-3044:
---
That sounds like a good list to start with. What are
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380518#comment-14380518
]
Vinod Kumar Vavilapalli commented on YARN-3044:
---
It's not just events. We
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380595#comment-14380595
]
Vrushali C commented on YARN-3044:
--
Hi [~Naganarasimha Garla]
I took a very quick look
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380622#comment-14380622
]
Naganarasimha G R commented on YARN-3044:
-
Thanks [~vrushalic], for reviewing it
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380567#comment-14380567
]
Vrushali C commented on YARN-3044:
--
The NM dealing with container level stats is part of
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380662#comment-14380662
]
Hadoop QA commented on YARN-3044:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380644#comment-14380644
]
Vinod Kumar Vavilapalli commented on YARN-3044:
---
[~Naganarasimha] /
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380675#comment-14380675
]
Vrushali C commented on YARN-3044:
--
bq. Well i too had the same doubt whether we need to
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380810#comment-14380810
]
Zhijie Shen commented on YARN-3044:
---
My 2 cents: as to a container, both RM and NM
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380916#comment-14380916
]
Vrushali C commented on YARN-3044:
--
[~zjshen] [~Naganarasimha] Okay, that sounds good to
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381058#comment-14381058
]
Sangjin Lee commented on YARN-3044:
---
Yes, I agree there are different definitions of the
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381019#comment-14381019
]
Zhijie Shen commented on YARN-3044:
---
bq. I think the key info is really around start
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380955#comment-14380955
]
Sangjin Lee commented on YARN-3044:
---
bq. But the life-cycle events of container should
[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376402#comment-14376402
]
Naganarasimha G R commented on YARN-3044:
-
Hi [~zjshen] [~sjlee0],
As part of this
80 matches
Mail list logo
