[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563777#comment-15563777
]
Naganarasimha G R commented on YARN-4855:
-
Hi [~Tao Jie], forgot to mention that we need to mention
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15543347#comment-15543347
]
Hadoop QA commented on YARN-4855:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15541681#comment-15541681
]
Hudson commented on YARN-4855:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10528 (See
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15541668#comment-15541668
]
Naganarasimha G R commented on YARN-4855:
-
Thanks for the patch [~Tao Jie], committed to trunk and
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15541065#comment-15541065
]
Naganarasimha G R commented on YARN-4855:
-
Thanks for the patch [~Tao Jie], +1 LGTM and as
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538717#comment-15538717
]
Hadoop QA commented on YARN-4855:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538593#comment-15538593
]
Tao Jie commented on YARN-4855:
---
Rename *--fail-on-unkown-nodes* to *-failOnUnknownNodes*...
> Should check
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535177#comment-15535177
]
Sunil G commented on YARN-4855:
---
I also generally agree with Wangda's approach. Improving to use cliParser
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529000#comment-15529000
]
Naganarasimha G R commented on YARN-4855:
-
bq. so it will be better to not add the hyphen-connected
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527090#comment-15527090
]
Wangda Tan commented on YARN-4855:
--
I prefer to make this option consistent to what we have, now we have
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523732#comment-15523732
]
Naganarasimha G R commented on YARN-4855:
-
Thanks for your copinion [~sunilg], but further to this
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522417#comment-15522417
]
Sunil G commented on YARN-4855:
---
To clarify more, i am fine with options like
- *-fail-on-unknown-nodes* with
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507056#comment-15507056
]
Sunil G commented on YARN-4855:
---
Thanks [~Tao Jie] and [~Naganarasimha] for taking the discussions forward.
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507006#comment-15507006
]
Hadoop QA commented on YARN-4855:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506856#comment-15506856
]
Naganarasimha G R commented on YARN-4855:
-
Thanks [~Tao Jie],
agree if you want to update all it
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506713#comment-15506713
]
Tao Jie commented on YARN-4855:
---
[~Naganarasimha], thank you for comments!
Yes, it is better to use
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506152#comment-15506152
]
Naganarasimha G R commented on YARN-4855:
-
[~Tao Jie], thanks for patiently redoing on most of the
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505385#comment-15505385
]
Hadoop QA commented on YARN-4855:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505224#comment-15505224
]
Tao Jie commented on YARN-4855:
---
[~leftnoteasy] , thank you for your comment!
Patch updated respect to your
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504186#comment-15504186
]
Wangda Tan commented on YARN-4855:
--
Thanks [~Tao Jie] a lot for updating the patch!
Generally approach
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503546#comment-15503546
]
Hadoop QA commented on YARN-4855:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500343#comment-15500343
]
Sunil G commented on YARN-4855:
---
I think I suggested for a new api to avoid issue with compatibility. After
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498235#comment-15498235
]
Naganarasimha G R commented on YARN-4855:
-
Some how missed to comment on this ...
Though i was in
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484371#comment-15484371
]
Sunil G commented on YARN-4855:
---
HI [~Tao Jie], I think we need not have to modify some apis in
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483364#comment-15483364
]
Tao Jie commented on YARN-4855:
---
Thank you for comments, [~sunilg].
Doing nodes check on client side is to
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483269#comment-15483269
]
Sunil G commented on YARN-4855:
---
HI [~Tao Jie] and [~Naganarasimha Garla]
Thanks for the work on this item.
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15481008#comment-15481008
]
Naganarasimha G R commented on YARN-4855:
-
Thanks [~Tao Jie],
White space issue can be fixed while
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480694#comment-15480694
]
Tao Jie commented on YARN-4855:
---
Thank you [~Naganarasimha]. Looks good to me!
> Should check if node exists
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480054#comment-15480054
]
Hadoop QA commented on YARN-4855:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15463958#comment-15463958
]
Hadoop QA commented on YARN-4855:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15463915#comment-15463915
]
Tao Jie commented on YARN-4855:
---
{quote}
"./yarn rmadmin -replaceLabelsOnNode " then error message is not
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15463872#comment-15463872
]
Tao Jie commented on YARN-4855:
---
Thank you for your comments, [~Naganarasimha].
{quote}
acceptNode =>
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459352#comment-15459352
]
Naganarasimha G R commented on YARN-4855:
-
Hi [~Tao Jie],
Sorry for the really long delay in
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15454040#comment-15454040
]
Hadoop QA commented on YARN-4855:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453986#comment-15453986
]
Tao Jie commented on YARN-4855:
---
refresh the patch and refine the checkstyle issues
> Should check if node
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15452779#comment-15452779
]
Naganarasimha G R commented on YARN-4855:
-
sorry for the delay [~Tao Jie], Will review tomorrow
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450868#comment-15450868
]
Hadoop QA commented on YARN-4855:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450811#comment-15450811
]
Tao Jie commented on YARN-4855:
---
Rebased the patch, [~Naganarasimha], [~sunilg], [~leftnoteasy] could you
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358559#comment-15358559
]
Hadoop QA commented on YARN-4855:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358505#comment-15358505
]
Tao Jie commented on YARN-4855:
---
Attached patch updated, [~Naganarasimha], [~sunilg], [~leftnoteasy] would
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234819#comment-15234819
]
Hadoop QA commented on YARN-4855:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234609#comment-15234609
]
Tao Jie commented on YARN-4855:
---
Attached patch fixes whitespace and some of style check
> Should check if
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234557#comment-15234557
]
Hadoop QA commented on YARN-4855:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233110#comment-15233110
]
Wangda Tan commented on YARN-4855:
--
Actually I think pulling running NM data from RM is a doable idea, it
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229557#comment-15229557
]
Tao Jie commented on YARN-4855:
---
[~sunilg] [~leftnoteasy] [~naganarasimha] Thanks for your comments.
I agree
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229478#comment-15229478
]
Sunil G commented on YARN-4855:
---
bq.he need not worry whether the node is temporarily down and he can just
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229408#comment-15229408
]
Wangda Tan commented on YARN-4855:
--
Thanks [~Tao Jie] and discussions from [~Naganarasimha], [~sunilg].
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228937#comment-15228937
]
Naganarasimha G R commented on YARN-4855:
-
Thanks [~sunilg] for sharing your views, as i mentioned
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228684#comment-15228684
]
Sunil G commented on YARN-4855:
---
bq.This would be a incompatible change
Yes. I agree with [~Naganarasimha
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228183#comment-15228183
]
Naganarasimha G R commented on YARN-4855:
-
Thanks for working on the patch, but would like to know
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227863#comment-15227863
]
Tao Jie commented on YARN-4855:
---
[~Naganarasimha], thanks for reply.
We are trying to split resource pool for
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227679#comment-15227679
]
Naganarasimha G R commented on YARN-4855:
-
Thanks [~Tao Jie], for sharing the alternate option but
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227603#comment-15227603
]
Tao Jie commented on YARN-4855:
---
[~Naganarasimha], agree. To keep compatible, how about improvement like
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15224217#comment-15224217
]
Naganarasimha G R commented on YARN-4855:
-
admin to cross verify if the node is up or down => admin
[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15224216#comment-15224216
]
Naganarasimha G R commented on YARN-4855:
-
[~Tao Jie], This would be a incompatible change and
55 matches
Mail list logo
