[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2015-05-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534941#comment-14534941 ] Hudson commented on YARN-644: - FAILURE: Integrated in Hadoop-trunk-Commit #7776 (See

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2015-05-08 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534803#comment-14534803 ] Robert Joseph Evans commented on YARN-644: -- Thanks [~varun_saxena], I agree with

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2015-05-07 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533304#comment-14533304 ] Varun Saxena commented on YARN-644: --- Fixed the tab issue and added tests. Basic null

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2015-05-07 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533448#comment-14533448 ] Li Lu commented on YARN-644: Hi [~varun_saxena], thanks for the patch! Asserting on the content

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2015-05-07 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533840#comment-14533840 ] Varun Saxena commented on YARN-644: --- OK...That's a good suggestion. Will make the change

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2015-05-07 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533890#comment-14533890 ] Li Lu commented on YARN-644: Thanks [~varun_saxena]! The latest patch LGTM. I'd appreciate

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2015-05-07 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533886#comment-14533886 ] Varun Saxena commented on YARN-644: --- Ok...Thats correct. We should not be using these

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2015-05-07 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533880#comment-14533880 ] Li Lu commented on YARN-644: Oh I mean the access modifiers. Can we use default level since all

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2015-05-07 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533866#comment-14533866 ] Li Lu commented on YARN-644: Hi [~varun_saxena], thanks for working on this! The patch is mostly

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2015-05-07 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533876#comment-14533876 ] Varun Saxena commented on YARN-644: --- Sorry couldn't get you. These 2 strings indicate two

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2015-05-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533373#comment-14533373 ] Hadoop QA commented on YARN-644: \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2015-05-06 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531731#comment-14531731 ] Li Lu commented on YARN-644: Hi [~varun_saxena], sorry I accidentally assigned this JIRA to

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2015-01-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14274002#comment-14274002 ] Hadoop QA commented on YARN-644: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2015-01-12 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14274003#comment-14274003 ] Varun Saxena commented on YARN-644: --- Kindly review Basic null check is not performed on

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2015-01-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14273766#comment-14273766 ] Hadoop QA commented on YARN-644: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2013-07-08 Thread Omkar Vinit Joshi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13702158#comment-13702158 ] Omkar Vinit Joshi commented on YARN-644: [~josephkniest] in these scenarios we

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2013-07-08 Thread Joseph Kniest (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13702870#comment-13702870 ] Joseph Kniest commented on YARN-644: I'm new to mapreduce2/yarn dev and am unfamiliar

[jira] [Commented] (YARN-644) Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

2013-07-07 Thread Joseph Kniest (JIRA)
[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701774#comment-13701774 ] Joseph Kniest commented on YARN-644: What should be done in the event that any