[Zope-dev] Re: Five and browser-oriented components

2008-04-17 Thread Martijn Faassen
Hanno Schlichting wrote: Martijn Faassen wrote: Alexander Limi wrote: On Mon, 14 Apr 2008 10:11:11 -0700, Philipp von Weitershausen [EMAIL PROTECTED] wrote: *IF* you'd like to be pragmatic, I'd suggest we clean up those failing Plone tests, merge the branch and be on our way. This gets

[Zope-dev] Re: Five and browser-oriented components

2008-04-15 Thread Martijn Faassen
Alexander Limi wrote: On Mon, 14 Apr 2008 10:11:11 -0700, Philipp von Weitershausen [EMAIL PROTECTED] wrote: *IF* you'd like to be pragmatic, I'd suggest we clean up those failing Plone tests, merge the branch and be on our way. I'm also happy to make it visible on the Plone agenda, as long

[Zope-dev] Re: Five and browser-oriented components

2008-04-15 Thread Hanno Schlichting
Martijn Faassen wrote: Alexander Limi wrote: On Mon, 14 Apr 2008 10:11:11 -0700, Philipp von Weitershausen [EMAIL PROTECTED] wrote: *IF* you'd like to be pragmatic, I'd suggest we clean up those failing Plone tests, merge the branch and be on our way. This gets back to Hanno's suggestion

[Zope-dev] Re: Five and browser-oriented components

2008-04-14 Thread Philipp von Weitershausen
Malthe Borch wrote: On Z2, certain imports need to come from Products.Five, to play nicely with ZPublisher and friends. Not really. You can inherit from zope.publisher.browser.BrowserView and Five's browser:page / directive will magically slap Acquisition.Explicit into a newly-created

[Zope-dev] Re: Five and browser-oriented components

2008-04-14 Thread Philipp von Weitershausen
Tres Seaver wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Martin Aspeli wrote: Martijn Faassen wrote: Technically, I think that this is going to be hard. You'd need to patch in the magic acquisition base class. Acquisition is the main reason that some of the code needed to be

Re: [Zope-dev] Re: Five and browser-oriented components

2008-04-14 Thread Chris McDonough
Philipp von Weitershausen wrote: *IF* you'd like to be pragmatic, I'd suggest we clean up those failing Plone tests, merge the branch and be on our way. +1 - C ___ Zope-Dev maillist - Zope-Dev@zope.org

Re: [Zope-dev] Re: Five and browser-oriented components

2008-04-14 Thread Jens Vagelpohl
On Apr 14, 2008, at 19:11 , Philipp von Weitershausen wrote: *IF* you'd like to be pragmatic, I'd suggest we clean up those failing Plone tests, merge the branch and be on our way. +1 jens ___ Zope-Dev maillist - Zope-Dev@zope.org

[Zope-dev] Re: Five and browser-oriented components

2008-04-14 Thread Martin Aspeli
Philipp von Weitershausen wrote: *IF* you'd like to be pragmatic, I'd suggest we clean up those failing Plone tests, merge the branch and be on our way. Yes, we *might* be plastering over a potential problem in the patch, but the other tests didn't seem to be affected and intensive alpha

[Zope-dev] Re: Five and browser-oriented components

2008-04-14 Thread Alexander Limi
On Mon, 14 Apr 2008 10:11:11 -0700, Philipp von Weitershausen [EMAIL PROTECTED] wrote: *IF* you'd like to be pragmatic, I'd suggest we clean up those failing Plone tests, merge the branch and be on our way. I'm also happy to make it visible on the Plone agenda, as long as it's made clear

[Zope-dev] Re: Five and browser-oriented components

2008-04-12 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Martin Aspeli wrote: Martijn Faassen wrote: Technically, I think that this is going to be hard. You'd need to patch in the magic acquisition base class. Acquisition is the main reason that some of the code needed to be duplicated - without the

[Zope-dev] Re: Five and browser-oriented components

2008-04-10 Thread Daniel Nouri
Malthe Borch [EMAIL PROTECTED] writes: On Z2, certain imports need to come from Products.Five, to play nicely with ZPublisher and friends. I'd like to ask for the motivation for not patching it onto the existing classes and/or modules. The effect of having Z2-developers import from

[Zope-dev] Re: Five and browser-oriented components

2008-04-10 Thread Malthe Borch
Daniel Nouri wrote: Therefore, I'd argue that we should, in contrary to what you suggest, make the Zope 2 compatibility layer more explicit in the form of utility functions, instead of more implicit. Because it makes things more transparent and easier to debug. You might be right; but it's a

[Zope-dev] Re: Five and browser-oriented components

2008-04-10 Thread Martijn Faassen
Malthe Borch wrote: On Z2, certain imports need to come from Products.Five, to play nicely with ZPublisher and friends. I'd like to ask for the motivation for not patching it onto the existing classes and/or modules. Technically, I think that this is going to be hard. You'd need to patch

[Zope-dev] Re: Five and browser-oriented components

2008-04-10 Thread Daniel Nouri
Malthe Borch [EMAIL PROTECTED] writes: Daniel Nouri wrote: Therefore, I'd argue that we should, in contrary to what you suggest, make the Zope 2 compatibility layer more explicit in the form of utility functions, instead of more implicit. Because it makes things more transparent and easier

[Zope-dev] Re: Five and browser-oriented components

2008-04-10 Thread Martin Aspeli
Martijn Faassen wrote: Technically, I think that this is going to be hard. You'd need to patch in the magic acquisition base class. Acquisition is the main reason that some of the code needed to be duplicated - without the existence of acquisition wrappers, security checks are not made for

[Zope-dev] Re: Five and browser-oriented components

2008-04-10 Thread Hanno Schlichting
Hi. Martin Aspeli wrote: Martijn Faassen wrote: Technically, I think that this is going to be hard. You'd need to patch in the magic acquisition base class. Acquisition is the main reason that some of the code needed to be duplicated - without the existence of acquisition wrappers, security

[Zope-dev] Re: Five and browser-oriented components

2008-04-10 Thread Martijn Faassen
Hanno Schlichting wrote: [snip] As the problems only showed themselves while doing browser testing inside Plone, I guess I can at least write some unit tests for them, so someone else can actually take a look at them more easily. I'll see if I can do that during my next 10% day [1] :) Yes,