Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410-stack into lp:zorba/stack-module

2013-08-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-stack/+merge/179389 Your team Zorba Coders is subscribed to branch lp:zorba/stack-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410-oracle-nosql-db into lp:zorba/oracle-nosql-db-module

2013-08-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-oracle-nosql-db/+merge/179382 Your team Zorba Coders is subscribed to branch lp:zorba/oracle-nosql-db-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410-sqlite into lp:zorba/sqlite-module

2013-08-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-sqlite/+merge/179388 Your team Zorba Coders is subscribed to branch lp:zorba/sqlite-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410-security into lp:zorba/security-module

2013-08-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-security/+merge/179387 Your team Zorba Coders is subscribed to branch lp:zorba/security-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410-read-pdf into lp:zorba/read-pdf-module

2013-08-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-read-pdf/+merge/179385 Your team Zorba Coders is subscribed to branch lp:zorba/read-pdf-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410 into lp:zorba

2013-08-09 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1210410 into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-couchbase/+merge/179365 https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-csv/+merge/179366

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410 into lp:zorba

2013-08-09 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1210410 into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-couchbase/+merge/179365 https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-csv/+merge/179366

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410-queue into lp:zorba/queue-module

2013-08-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-queue/+merge/179384 Your team Zorba Coders is subscribed to branch lp:zorba/queue-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410-schema-tools into lp:zorba/schema-tools-module

2013-08-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-schema-tools/+merge/179386 Your team Zorba Coders is subscribed to branch lp:zorba/schema-tools-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410-process into lp:zorba/process-module

2013-08-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-process/+merge/179383 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410-archive into lp:zorba/archive-module

2013-08-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-archive/+merge/179394 Your team Zorba Coders is subscribed to branch lp:zorba/archive-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410 into lp:zorba

2013-08-09 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1210410 into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-couchbase/+merge/179365 https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-csv/+merge/179405

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410-csv into lp:zorba/csv-module

2013-08-09 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1210410-csv into lp:zorba/csv-module. Commit message: Updated options and annotations URIs to zorba.io. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1210410

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410-html into lp:zorba/html-module

2013-08-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-html/+merge/179406 Your team Zorba Coders is subscribed to branch lp:zorba/html-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410 into lp:zorba

2013-08-09 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1210410 into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-couchbase/+merge/179365 https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-csv/+merge/179405

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410-html into lp:zorba/html-module

2013-08-09 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1210410-html into lp:zorba/html-module. Commit message: Updated options and annotations URIs to zorba.io. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410-graphviz into lp:zorba/graphviz-module

2013-08-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-graphviz/+merge/179407 Your team Zorba Coders is subscribed to branch lp:zorba/graphviz-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410 into lp:zorba

2013-08-09 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1210410 into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-couchbase/+merge/179365 https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-csv/+merge/179405

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410-graphviz into lp:zorba/graphviz-module

2013-08-09 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1210410-graphviz into lp:zorba/graphviz-module. Commit message: Updated options and annotations URIs to zorba.io. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410-csv into lp:zorba/csv-module

2013-08-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210410-csv/+merge/179405 Your team Zorba Coders is subscribed to branch lp:zorba/csv-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210410 into lp:zorba

2013-08-09 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1210410 into lp:zorba has been updated. Commit Message changed to: Change most non-module Zorba namespace URIs from www.zorba-xquery.com to zorba.io. Also replace functx module URI with correct version (no trailing slash). For more details,

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188058 into lp:zorba/system-module

2013-08-08 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188058/+merge/178905 Your team Zorba Coders is subscribed to branch lp:zorba/system-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188058 into lp:zorba/system-module

2013-08-08 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1188058 into lp:zorba/system-module has been updated. Commit Message changed to: Update non-core system module to Zorba 3.0 standards. Added system:all-properties() function. For more details, see:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-08-08 Thread Chris Hillery
Review: Needs Information A great number of parsing and serializing test cases fail with these changes. Do we have any plans to fix them up? It's not clear to me if anyone is driving this issue anymore... -- https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312 Your team

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189793-item-module into lp:zorba

2013-08-07 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1189793-item-module into lp:zorba. Commit message: Update core item module to Zorba 3.0 standards. Requested reviews: Chris Hillery (ceejatec) Related bugs: Bug #1189793 in Zorba: Update core module item https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189793-item-module into lp:zorba

2013-08-07 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189793-item-module/+merge/178904 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188058 into lp:zorba/system-module

2013-08-07 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1188058 into lp:zorba/system-module. Requested reviews: Zorba Coders (zorba-coders) Related bugs: Bug #1188058 in Zorba: Update non-core module system https://bugs.launchpad.net/zorba/+bug/1188058 For more details, see: https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189797-node-module into lp:zorba

2013-08-07 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1189797-node-module into lp:zorba. Commit message: Updated core module node to Zorba 3.0 standards. Requested reviews: Chris Hillery (ceejatec) Related bugs: Bug #1189797 in Zorba: Update core module node https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189797-node-module into lp:zorba

2013-08-07 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189797-node-module/+merge/178910 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188058 into lp:zorba/system-module

2013-08-07 Thread Chris Hillery
Review: Needs Fixing Looks very good, nice work. However, the moduleDocumentation test doesn't pass, so there must be a typo somewhere in the XQDoc. Also, I suspect once you fix that, it will complain that all those public variable declarations need to have XQDoc; you'll probably need to

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_QT_snapshot_August_8th into lp:zorba

2013-08-06 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bump_QT_snapshot_August_8th/+merge/178571 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zio-oracle-nosql into lp:zorba/oracle-nosql-db-module

2013-08-06 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/zio-oracle-nosql/+merge/178785 Your team Zorba Coders is subscribed to branch lp:zorba/oracle-nosql-db-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-windows-fix into lp:zorba

2013-08-06 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fix/+merge/178848 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-win64 into lp:zorba

2013-08-06 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/zorba-win64/+merge/178846 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/archive-module-win64 into lp:zorba/archive-module

2013-08-06 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/archive-module-win64/+merge/178845 Your team Zorba Coders is subscribed to branch lp:zorba/archive-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-errors-stack into lp:zorba/stack-module

2013-08-06 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/zorba-errors-stack into lp:zorba/stack-module. Commit message: Update to new zorba errors URI. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/zorba-errors-stack

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-errors-stack into lp:zorba/stack-module

2013-08-06 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/zorba-errors-stack into lp:zorba/stack-module has been updated. Commit Message changed to: Update to new zorba errors URI. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/zorba-errors-stack/+merge/178883 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-errors-queue into lp:zorba/queue-module

2013-08-06 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/zorba-errors-queue into lp:zorba/queue-module. Commit message: Update to new zorba errors URI. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/zorba-errors-queue

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-errors into lp:zorba

2013-08-06 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/zorba-errors/+merge/178885 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-errors-stack into lp:zorba/stack-module

2013-08-06 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/zorba-errors-stack/+merge/178883 Your team Zorba Coders is subscribed to branch lp:zorba/stack-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-errors-queue into lp:zorba/queue-module

2013-08-06 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/zorba-errors-queue/+merge/178884 Your team Zorba Coders is subscribed to branch lp:zorba/queue-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189784 into lp:zorba/sqlite-module

2013-07-29 Thread Chris Hillery
Review: Approve Looks good - nice job! I made three small changes: 1. Moved a p/ in the metadata() doc to immediately after the leading sentence of the comment. 2. Moved SqliteModule() constructor definition out-of-line. 3. Per mailing list discussion, marked a number of module functions as

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-cloudant into lp:zorba

2013-07-29 Thread Chris Hillery
There isn't really a fixed process for that since it happens so rarely. Here's what I'd suggest: 1. Create the module as a stand-alone directory, so that it works when located in the zorba_modules directory as part of a Zorba build. 2. Push that module to Launchpad as

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-cloudant into lp:zorba

2013-07-26 Thread Chris Hillery
Review: Needs Information The module itself looks OK at a quick glance. However, unless I'm missing something, I don't think this needs to be a core module. It should be a non-core module in a separate branch. -- https://code.launchpad.net/~zorba-coders/zorba/feature-cloudant/+merge/177111

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-cloudant into lp:zorba

2013-07-26 Thread Chris Hillery
Review: Needs Fixing Actually, a few code problems: 1. ConnectionMap::destroy() invokes a function in the http://28msec.io/modules/cloudant namespace. I think that should be in http://zorba.io/modules/cloudant, right? 2. The files in cloudant.xq.src have 28msec copyright notices. 3. I think

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-cloudant into lp:zorba

2013-07-26 Thread Chris Hillery
Ahh, I see, that call in ConnectionMap::destroy() is commented out. Didn't notice that the first time. Regarding the curl disconnect problems: That would all go away if this module used the http-client module, rather than using C++ to invoke CURL directly. Is there a reason this module

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-cloudant into lp:zorba

2013-07-26 Thread Chris Hillery
Yes, non-core modules can have C++ external functions; take a look at the process module, for instance. -- https://code.launchpad.net/~zorba-coders/zorba/feature-cloudant/+merge/177111 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/expath-http-on-json-http into lp:zorba/http-client-module

2013-07-26 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/expath-http-on-json-http into lp:zorba/http-client-module has been updated. Description changed to: Depends on https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980 . For more details, see:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-cloudant into lp:zorba

2013-07-26 Thread Chris Hillery
Review: Needs Information Since in its current state this module depends on CURL i made a single search for the CURL library and moved both the ADD_DIRECTORY(http-client) and ADD..(cloudant) inside the same check. The http client cmakelist doesn't do the search again. Aha! Now I see what

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/expath-http-on-json-http into lp:zorba/http-client-module

2013-07-26 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/expath-http-on-json-http/+merge/176996 Your team Zorba Coders is subscribed to branch lp:zorba/http-client-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-wrapper into lp:zorba

2013-07-26 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188033 into lp:zorba/archive-module

2013-07-26 Thread Chris Hillery
Review: Needs Fixing You didn't actually create singleton zorba::Items for the JSON object key strings. Using C++ #defines isn't the same. This code will still create a separate zorba::Item for the string name for every single entry in every archive passed to a:entries(). --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-based-on-json-http-client into lp:zorba/http-client-module

2013-07-25 Thread Chris Hillery
Is the code replication exact, or very nearly exact? If so I think I'd go with option 2. (If it was only 50-100 lines of code I'd pick option 1, but 600 lines seems like rather a lot.) I suspect that the XML http-client will be with us for quite some time. I agree that option 3, while clean,

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jdbc-mariadb-driver into lp:zorba/jdbc-module

2013-07-25 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/jdbc-mariadb-driver into lp:zorba/jdbc-module. Commit message: Additional expected result when using MariaDB JDBC driver. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jdbc-mariadb-driver into lp:zorba/jdbc-module

2013-07-25 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/jdbc-mariadb-driver into lp:zorba/jdbc-module has been updated. Commit Message changed to: Additional expected result when using MariaDB JDBC driver. For more details, see:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jdbc-mariadb-driver into lp:zorba/jdbc-module

2013-07-25 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/jdbc-mariadb-driver/+merge/177036 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-07-24 Thread Chris Hillery
Review: Approve Looks good, thanks! -- https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189801 into lp:zorba

2013-07-24 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189801 into lp:zorba has been updated. Commit Message changed to: Updated reference module to Zorba 3.0 standards. Removed node-reference module (use reference module instead). For more details, see:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189807 into lp:zorba

2013-07-24 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189807 into lp:zorba has been updated. Commit Message changed to: Updated xml module to Zorba 3.0 standards. Deleted backwards-compatible x:parse-xml-fragment() functions. For more details, see:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189807-html into lp:zorba/html-module

2013-07-24 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1189807-html into lp:zorba/html-module. Commit message: Fixes for new XML module. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189807-html/+merge/176636

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189807-html into lp:zorba/html-module

2013-07-24 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189807-html into lp:zorba/html-module has been updated. Commit Message changed to: Fixes for new XML module. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189807-html/+merge/176636 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189807-html into lp:zorba/html-module

2013-07-24 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189807-html/+merge/176636 Your team Zorba Coders is subscribed to branch lp:zorba/html-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-improve-ser-error into lp:zorba

2013-07-24 Thread Chris Hillery
Review: Approve Seems legit. -- https://code.launchpad.net/~zorba-coders/zorba/bug-improve-ser-error/+merge/176821 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189801 into lp:zorba

2013-07-24 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189801/+merge/176621 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_QT_snapshot_jul_24 into lp:zorba

2013-07-24 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bump_QT_snapshot_jul_24/+merge/176658 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188033 into lp:zorba/archive-module

2013-07-23 Thread Chris Hillery
Review: Needs Fixing In archive_module.cpp: 1. Please don't leave commented-out code. Just delete it; it's in the version history if we ever need to refer back to it. For example, remove these lines: +//Item lNameItem = theFactory-createString(lName); +//lMemberName =

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188033 into lp:zorba/archive-module

2013-07-23 Thread Chris Hillery
Review: Needs Fixing Also, you have at least one /p typo in archive.xq. Always remember to run ctest -R moduleDocumentation before committing, to be sure that your XQDoc is syntactically correct and that you didn't forget to document any parameters, etc. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_notRun_test-cases into lp:zorba

2013-07-19 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_notRun_test-cases/+merge/175734 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-07-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module has been updated. Description changed to: Might as well bring in https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553 too. For more details, see:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba

2013-07-17 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba

2013-07-17 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba. Commit message: Update base64 module to Zorba 3.0 standards. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-core/+merge

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba

2013-07-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/csv-module/+merge/175205 For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-core/+merge/175204 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba

2013-07-17 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-core/+merge/175204 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-csv into lp:zorba/csv-module

2013-07-17 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1189785-csv into lp:zorba/csv-module. Commit message: Updated to new base64 module URI. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-csv/+merge

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-csv into lp:zorba/csv-module

2013-07-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189785-csv into lp:zorba/csv-module has been updated. Commit Message changed to: Updated to new base64 module URI. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-csv/+merge/175208 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba

2013-07-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-csv/+merge/175208 For more details, see:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-csv into lp:zorba/csv-module

2013-07-17 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-csv/+merge/175208 Your team Zorba Coders is subscribed to branch lp:zorba/csv-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-archive into lp:zorba

2013-07-17 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-archive/+merge/175212 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba

2013-07-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-csv/+merge/175208 https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-archive/+merge/175212 For more details,

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-nosql into lp:zorba/oracle-nosql-db-module

2013-07-17 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1189785-nosql into lp:zorba/oracle-nosql-db-module. Commit message: Updated for new base64 module namespace URI. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-nosql into lp:zorba/oracle-nosql-db-module

2013-07-17 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-nosql/+merge/175214 Your team Zorba Coders is subscribed to branch lp:zorba/oracle-nosql-db-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba

2013-07-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-csv/+merge/175208 https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-archive/+merge/175215

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba

2013-07-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-csv/+merge/175208 https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-archive/+merge/175215

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-oauth into lp:zorba/oauth-module

2013-07-17 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1189785-oauth into lp:zorba/oauth-module. Commit message: Updated to new base64 module namespace URI. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-oauth into lp:zorba/oauth-module

2013-07-17 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-oauth/+merge/175217 Your team Zorba Coders is subscribed to branch lp:zorba/oauth-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-archive into lp:zorba/archive-module

2013-07-17 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-archive/+merge/175215 Your team Zorba Coders is subscribed to branch lp:zorba/archive-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-archive into lp:zorba/archive-module

2013-07-17 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1189785-archive into lp:zorba/archive-module. Commit message: Updated tests for new base64 module URI. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-archive into lp:zorba/archive-module

2013-07-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189785-archive into lp:zorba/archive-module has been updated. Commit Message changed to: Updated tests for new base64 module URI. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-archive/+merge/175215 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189794-core into lp:zorba

2013-07-17 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189794-core/+merge/175224 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188052-oauth-update into lp:zorba/oauth-module

2013-07-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1188052-oauth-update into lp:zorba/oauth-module has been updated. Commit Message changed to: Update oauth module to Zorba 3.0 standards. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1188052-oauth-update/+merge/173872

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189794-core into lp:zorba

2013-07-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189794-core into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1189794-oauth/+merge/175236 For more details, see:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189794-oauth into lp:zorba/oauth-module

2013-07-17 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189794-oauth/+merge/175236 Your team Zorba Coders is subscribed to branch lp:zorba/oauth-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba

2013-07-17 Thread Chris Hillery
FYI, I moved the string module into the new modules/atomic directory. Also fixed the version number in DECLARE_ZORBA_MODULE(). -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqdoc-private-variables into lp:zorba

2013-07-16 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/xqdoc-private-variables into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/xqdoc-private-variables/+merge/175166 Don't check %private variables

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqdoc-private-variables into lp:zorba

2013-07-16 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/xqdoc-private-variables/+merge/175166 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module

2013-07-16 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553 Your team Zorba Coders is subscribed to branch lp:zorba/stack-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-07-16 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188062/+merge/169946 Your team Zorba Coders is subscribed to branch lp:zorba/queue-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-07-16 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/xqdoc-private-variables/+merge/175166 For more details, see:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqdoc-private-variables into lp:zorba

2013-07-16 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/xqdoc-private-variables into lp:zorba has been updated. Commit Message changed to: Don't check %private variables. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/xqdoc-private-variables/+merge/175166 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-07-16 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module has been updated. Commit Message changed to: Update to 3.0 module guidelines; make JSON-ready. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1188062/+merge/169946 --

<    1   2   3   4   5   6   7   8   9   10   >