Review: Needs Fixing

Actually, a few code problems:

1. ConnectionMap::destroy() invokes a function in the 
http://28msec.io/modules/cloudant namespace. I think that should be in 
http://zorba.io/modules/cloudant, right?

2. The files in cloudant.xq.src have 28msec copyright notices.

3. I think the changes in modules/CMakeLists.txt are wrong; why are you 
eliminating the http-client subdirectory, for instance? Also, the search for 
CURL needs to only be once; will you remove the FIND_PACKAGE(CURL) from the 
http-client subdirectory, once those modules are all merged?
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-cloudant/+merge/177111
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to     : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Reply via email to