On Thu, 3 Sep 2026 13:43:34 GMT, Dan Heidinga <[email protected]> wrote:
>> Stefan Karlsson has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Fix alignments
>> - Fix inline entry point names
>> - Small fixes
>
> src/hotspot/share/asm/macroAssembler_common.cpp line 199:
>
>> 197: }
>> 198:
>> 199: bool MacroAssembler::shuffle_inline_args_spill(bool is_packing, const
>> GrowableArray<SigEntry>* sig, int sig_index,
>
> Suggestion:
>
> bool MacroAssembler::shuffle_value_args_spill(bool is_packing, const
> GrowableArray<SigEntry>* sig, int sig_index,
>
>
> Looks like some "inline" got missed in the conversion.
Fixing.
> src/hotspot/share/asm/macroAssembler_common.hpp line 60:
>
>> 58: VMRegPair* from, int from_count, int&
>> from_index, VMReg to,
>> 59: RegState reg_state[], Register val_array);
>> 60: int extend_stack_for_inline_args(int args_on_stack);
>
> shuffle_inline_args_spill -> shuffle_value_args_spill
>
> unpack_inline_helper -> unpack_value_helper
>
> pack_inline_helper -> pack_value_helper
>
> extend_stack_for_inline_args -> extend_stack_for_value_args
fixing
> src/hotspot/share/cds/heapShared.cpp line 1780:
>
>> 1778: // Found a non-null flattened instance of vk. Let's record vk.
>> 1779: add_value_class(_subgraph_info, vk);
>> 1780: if (vk->has_inlined_fields()) {
>
> Suggestion:
>
> if (vk->has_value_fields()) {
>
>
> Or may `has_flat_fields()`?
I'll wait until someone decides what name I should give this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32673#discussion_r3925845224
PR Review Comment: https://git.openjdk.org/jdk/pull/32673#discussion_r3925846726
PR Review Comment: https://git.openjdk.org/jdk/pull/32673#discussion_r3925851558
