On Thu, 3 Sep 2026 18:43:49 GMT, Stefan Karlsson <[email protected]> wrote:
>> This should be `has_inlined_fields` or `has_flattened_fields`, it should not >> be `has_value_fields`. I followed the chain of setters for this, and it >> starts at `fieldLayoutBuilder.cpp:885`. It means "this IK has fields laid >> out in a flat fashion" and not "some of the fields in here are values (as in >> declared using `value class` or `value record`). Using my suggested names >> makes this very explicit. > > Also see these comments about this: > https://github.com/openjdk/jdk/pull/32673#discussion_r3925747823 > https://github.com/openjdk/jdk/pull/32673#issuecomment-5530314561 Definitely agree to defer this one. I don't want to delay the overall PR while we figure out the "right" name here ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32673#discussion_r3929837485
