On Thu, 3 Sep 2026 15:02:42 GMT, Stefan Karlsson <[email protected]> wrote:

>> src/hotspot/share/asm/macroAssembler_common.cpp line 199:
>> 
>>> 197: }
>>> 198: 
>>> 199: bool MacroAssembler::shuffle_inline_args_spill(bool is_packing, const 
>>> GrowableArray<SigEntry>* sig, int sig_index,
>> 
>> Suggestion:
>> 
>> bool MacroAssembler::shuffle_value_args_spill(bool is_packing, const 
>> GrowableArray<SigEntry>* sig, int sig_index,
>> 
>> 
>> Looks like some "inline" got missed in the conversion.
>
> Fixing.

Done

>> src/hotspot/share/asm/macroAssembler_common.hpp line 60:
>> 
>>> 58:                           VMRegPair* from, int from_count, int& 
>>> from_index, VMReg to,
>>> 59:                           RegState reg_state[], Register val_array);
>>> 60:   int extend_stack_for_inline_args(int args_on_stack);
>> 
>> shuffle_inline_args_spill -> shuffle_value_args_spill
>> 
>> unpack_inline_helper -> unpack_value_helper
>> 
>> pack_inline_helper -> pack_value_helper
>> 
>> extend_stack_for_inline_args -> extend_stack_for_value_args
>
> fixing

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32673#discussion_r3925996515
PR Review Comment: https://git.openjdk.org/jdk/pull/32673#discussion_r3925995577

Reply via email to