[chromium-dev] Re: Chrome on Windows 2000

2008-09-11 Thread Dan Kegel
On Wed, Sep 10, 2008 at 11:58 PM, sfrahm [EMAIL PROTECTED] wrote: To help Chrome begin to work expediently on Windows 2000 would only take a single expression of cooperative intent towards the open source community. Yes, we are thankful that the source is openly available, but a spirit of

[chromium-dev] SSLClientSocket, TCPClientSocket design choices on linux

2008-09-16 Thread Dan Kegel
Here's what I'm thinking, please yell if it sounds wrong. When we implement SSLClientSocket on linux, we can do it with one-thread-per-connection, or with nonblocking I/O. Since all socket I/O goes through the browser process, one thread per connection would limit us to however many stacks fit

[chromium-dev] Re: SSLClientSocket, TCPClientSocket design choices on linux

2008-09-17 Thread Dan Kegel
On Wed, Sep 17, 2008 at 7:25 PM, Darin Fisher [EMAIL PROTECTED] wrote: One more data point: we'll also need to support SSL over SOCKS one day, and that means that the ClientSocket passed to SSLClientSocket will not be a TCPClientSocket. it will be a SOCKSClientSocket. the SOCKSClientSocket

[chromium-dev] Re: SSLClientSocket, TCPClientSocket design choices on linux

2008-09-18 Thread Dan Kegel
On Thu, Sep 18, 2008 at 2:36 PM, Wan-Teh Chang [EMAIL PROTECTED] wrote: Since we don't have access to the SSL state machine inside NSS's SSL library, we have to use PRFileDesc and PR_Recv and PR_Send, but we don't need to use PR_Poll. We can call the 'poll' method of PRFileDesc directly to

[chromium-dev] Re: SSLClientSocket, TCPClientSocket design choices on linux

2008-09-19 Thread Dan Kegel
based on the mac ssl apis so that we get good integration w/ the keychain or what have you. right? -darin On Fri, Sep 19, 2008 at 12:40 PM, Dan Kegel [EMAIL PROTECTED] wrote: On Fri, Sep 19, 2008 at 12:19 PM, Mike Pinkerton [EMAIL PROTECTED] wrote: we're blocked on getting the win32 out

[chromium-dev] Re: Embedding Chromium

2008-11-13 Thread Dan Kegel
Marshall Greenblatt [EMAIL PROTECTED] wrote: I think it would be nice to leverage chromium's multi-process architecture in a COM context. The chromium browser process would be hosted in a local COM server executable. Each browser window requested by the container application (and created by

[chromium-dev] Is the zlib valgrind warning in GZipUnitTest.DecodeDeflate spurious?

2008-12-19 Thread Dan Kegel
I just ran into this today (using valgrind-3.4.0.SVN for its nifty track-origins option): $ valgrind --track-origins=yes Hammer/net_unittests --gtest_filter=GZipUnitTest.DecodeDeflate [ RUN ] GZipUnitTest.DecodeDeflate Conditional jump or move depends on uninitialised value(s) at

[chromium-dev] Re: Questions About Contributing Codes

2008-12-29 Thread Dan Kegel
On Mon, Dec 29, 2008 at 8:50 PM, DeArto20 sy3...@gmail.com wrote: Hi. I'm new on this chromium project. Welcome... I have some questions about joining on this project as a developer. I wanna know how developers find the problems that should be improved or resolved. - 1. Do they check bug

[chromium-dev] dtrace and chromium?

2009-01-12 Thread Dan Kegel
Hey mac chrome developers, how useful is / will dtrace be for chrome development on macosx? (Beyond things like dtruss, I mean.) Is it going to be important for tracking down performance issues? Thanks, Dan --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: If you're feeling bored

2009-01-13 Thread Dan Kegel
On Mon, Jan 12, 2009 at 3:01 PM, Dean McNamee de...@chromium.org wrote: There are some static initializers that should be fixed. (If you're wondering why, see http://www.parashift.com/c++-faq-lite/ctors.html#faq-10.12 Static global objects are somewhat risky in C++. At least I think that's what

[chromium-dev] Re: OSX 10.4 and PPC support?

2009-01-15 Thread Dan Kegel
On Thu, Jan 15, 2009 at 3:26 PM, Amanda Walker ama...@chromium.org wrote: Also, on a related note, are there also any plans for supporting the PPC architecture in the future? Not currently. It would require, among other things, a PPC code generator for V8. While this is not impossible,

[chromium-dev] Re: Why do you use SCONS ?

2009-01-16 Thread Dan Kegel
On Fri, Jan 16, 2009 at 12:34 PM, Elliot Glaysher (Chromium) e...@chromium.org wrote: Usually Open Source projects use CMake Construction Tool Kit. Off the top of my head, KDE 4.x is the only project I know of that uses CMake, (which is different from the old unix make). There are a few

[chromium-dev] mismatched new/delete[] in webkit?

2009-01-27 Thread Dan Kegel
Noticed in passing while looking for something else this morning (though they may have been there a while). These sound potentially nasty; is anybody looking at them already? $ valgrind --track-origins=yes Hammer/test_shell_tests ... [ RUN ] WebFrameTest.GetContentAsPlainText UNIMPLEMENTED:

[chromium-dev] chromium linux meeting note

2009-02-03 Thread Dan Kegel
news flash: the team has decided to make the linux port more like the mac port, i.e. it will use a Views-like gtk layer rather than porting Views. More details later from somebody who knows more... --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Graceful updates on Linux

2009-02-05 Thread Dan Kegel
Firefox behaves terribly upon update on Linux because they didn't bother even trying to make distro updates work well, and everybody uses distro packages for Firefox. Let's avoid this same problem on Chrome for Linux. Does that sound like a reasonable goal? We're early enough in the port that it

[chromium-dev] Re: do we need a gcc 4.3 buildbot?

2009-02-19 Thread Dan Kegel
On Thu, Feb 19, 2009 at 9:57 AM, Ian Fette i...@chromium.org wrote: At some point, we're going to have to support a newer version of GCC, no? It seems like tackling these errors as they creep up is more manageable than trying to sometime later switch to supporting a more recent release of GCC

[chromium-dev] Re: Doing some research with views and GTK.

2009-03-16 Thread Dan Kegel
On Mon, Mar 16, 2009 at 11:49 AM, Ben Goodger (Google) b...@chromium.org wrote: We'd have to implement these APIs on Linux anyway for the custom-rendered tabstrip. From some basic digging it sounds like Gtk provides APIs similar to IAccessible in Atk that you implement. Maybe Jonas knows

[chromium-dev] depot_tools needs msvcrt71?

2009-03-21 Thread Dan Kegel
Our gclient's python may need to bundle msvcrt71.dll; without it, on my Win Vista 64 system, I get repeated this app needs msvcrt71 errors. Well-behaved apps, like http://prdownloads.sourceforge.net/bzflag/bzflag-2.0.10.exe?download do bundle that dll, and in fact the workaround I chose was to

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Dan Kegel
2009/3/24 John Abd-El-Malek j...@chromium.org: If I remember right when I looked at some of this, the Windows code uses the process filter as a hook to scan the windows to find a running Chromium and send it a message. So that whole functionality should be re-abstracted, if needed, instead

[chromium-dev] Layout test valgrind initial impressions

2009-03-28 Thread Dan Kegel
The change that adds support for valgrinding layout tests is http://codereview.chromium.org/55034 I'm about about 10% of the way through valgrinding the layout tests on a debug build, and about 20% of the way through on a release build. With valgrind set to ignore reachable and possible leaks,

[chromium-dev] Re: Chromium App Executables Disk Layout

2009-03-28 Thread Dan Kegel
On Sat, Mar 28, 2009 at 4:59 PM, Erik Kay erik...@chromium.org wrote: ...When you update in place, resources can be changed, removed, etc. So let's say that some dll hasn't been loaded yet, but then an autoupdate happens. Now you trigger loading the dll, and you crash, because this kind of

[chromium-dev] Re: Chromium App Executables Disk Layout

2009-03-29 Thread Dan Kegel
On Sun, Mar 29, 2009 at 11:56 AM, Dan Kegel d...@kegel.com wrote: How will in-place updating work on the Mac and Linux? For Linux, I was imagining that we'd open handles at startup to any file we'd need, and then never open any more handles after that. We looked into this more at one

[chromium-dev] Re: Changing default compile for Chrome Linux build?

2009-04-02 Thread Dan Kegel
On Wed, Apr 1, 2009 at 11:59 PM, QAH qah...@gmail.com wrote: Hello everyone! I am building the source code of chrome for linux, and I know that it uses gcc and g++. Since chrome is such a big build though and I have 3 computers, I wanted to use distcc to allow all 3 computers to compile

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Dan Kegel
And it seems to be built without debugging flags in debug mode. At least, I can't single-step through code on Linux. On Thu, Apr 2, 2009 at 4:18 AM, Dean McNamee de...@chromium.org wrote: (this isn't just V8, all of chromium is built without optimization in release).  There are lots of other

[chromium-dev] Re: Changing default compile for Chrome Linux build?

2009-04-02 Thread Dan Kegel
On Thu, Apr 2, 2009 at 4:23 PM, QAH qah...@gmail.com wrote: So all I have to do is set: CC=distcc gcc CXX=distcc g++ Somewhere in the .bashrc file and it will use distcc? You have to export those environment variables. Using CC for the C compiler is a convention that many build systems

[chromium-dev] Re: ubuntu intrepid

2009-04-19 Thread Dan Kegel
On Sun, Apr 19, 2009 at 4:23 AM, Marc-Antoine Ruel mar...@chromium.org wrote: On ubuntu intrepid, when running src/build/install-build-deps.sh, I get the following error : Package php5-timezondb is not available, but is referred to by another package. This may mean that the package is

[chromium-dev] New Using Valgrind page at dev.chromium.org

2009-05-06 Thread Dan Kegel
http://dev.chromium.org/developers now links to a Using Valgrind page which is supposed to be all you need to know to be a valgrind hero. It's not quite as complete as the Using Purify page, but it's close. Let me know if there are unclear or missing bits you'd like clarified. thestig is

[chromium-dev] Re: Graceful updates on Linux

2009-05-07 Thread Dan Kegel
? In this is what we are aiming for forking sounds great since we will end up using the same exe version and this should work as long as we know which shared library we are using with it. On Thu, Feb 5, 2009 at 9:33 AM, Dan Kegel daniel.r.ke...@gmail.com wrote: Firefox behaves terribly upon update

[chromium-dev] Re: No more local copy of WebCore and JavaScriptCore!

2009-05-08 Thread Dan Kegel
On Fri, May 8, 2009 at 9:49 AM, Darin Fisher da...@chromium.org wrote: I just committed a change that deletes our local copy of WebCore and JavaScriptCore (we use the wtf/ directory from here). http://src.chromium.org/viewvc/chrome?view=revrevision=15644 This change should be fairly

[chromium-dev] Re: No more local copy of WebCore and JavaScriptCore!

2009-05-08 Thread Dan Kegel
On Fri, May 8, 2009 at 10:16 AM, Darin Fisher da...@chromium.org wrote: gclient sync now crashes for me: That's unfortunate... I wonder what is different about your setup.  The buildbots and trybots and my personal Linux box were all happy with the change. Maybe just try deleting all of

[chromium-dev] OMG gold links chrome so much faster than old ld...

2009-05-10 Thread Dan Kegel
If you're on Linux, you probably want to give gold, Ian's faster replacement for ld, a whirl. If you, like I, have been hesitating because of the hassle of building gold from sources, hesitate no more. I have a patch pending to install-build-deps.sh that installs ld as the default system

[chromium-dev] Chromium Valgrind Fixit Day!

2009-05-11 Thread Dan Kegel
We've been using Valgrind to find memory leaks, pointer errors, and race conditions in Chromium on Mac and Linux for a while now. (See the valgrind bots at http://build.chromium.org.) That's cool, but it would be even cooler if we actually fixed the problems Valgrind has found. According to

[chromium-dev] Re: Which is the Xcode project for chromium on MacOS

2009-05-26 Thread Dan Kegel
On Tue, May 26, 2009 at 10:37 AM, Daniel Dreiberg daniel.dreiber...@gmail.com wrote: Can you please tell me where i can find Xcode project for chromium on MacOS? I tried $chromium_src_root/src/chrome/chrome.xcodeproj, but that does not seem to have html parser code, javascript engine code, css

[chromium-dev] Avoiding crash after autoupdate on Linux

2009-05-26 Thread Dan Kegel
http://codereview.chromium.org/115773 is my try at fixing http://crbug.com/11841 (autoupdate broke my browser, familiar to anyone who's used Firefox on Linux). I haven't cleaned up the code, but it's a lot less invasive than I thought it was going to be. It arranges for the .pak files to only be

[chromium-dev] Re: Avoiding crash after autoupdate on Linux

2009-05-26 Thread Dan Kegel
On Tue, May 26, 2009 at 1:06 PM, Adam Langley a...@chromium.org wrote: On Tue, May 26, 2009 at 12:00 PM, Dan Kegel daniel.r.ke...@gmail.com wrote: http://codereview.chromium.org/115773 is my try at fixing http://crbug.com/11841 (autoupdate broke my browser, familiar to anyone who's used

[chromium-dev] Re: Avoiding crash after autoupdate on Linux

2009-05-27 Thread Dan Kegel
to package manager, why not use a shell script? Could bash not be present on a system with X installed? That'd be surprising. $ cat /usr/bin/chrome #!/bin/sh # Call the right version here: /usr/bin/chrome2.0.1.2 $* No need for zygote with that. M-A On Tue, May 26, 2009 at 6:30 PM, Dan Kegel

[chromium-dev] Re: Avoiding crash after autoupdate on Linux

2009-05-27 Thread Dan Kegel
On Tue, May 26, 2009 at 1:06 PM, Adam Langley a...@chromium.org wrote: On Tue, May 26, 2009 at 12:00 PM, Dan Kegel daniel.r.ke...@gmail.com wrote: http://codereview.chromium.org/115773 is my try at fixing http://crbug.com/11841 (autoupdate broke my browser, familiar to anyone who's used

[chromium-dev] mingw build of chromium?

2009-05-31 Thread Dan Kegel
Does anyone have tips for how to try building chromium with mingw? I know it's not expected to work (since we still use ATL etc.), but I'd like to try anyway, and it'd be nice to not have to reinvent the wheel if somebody's already figured out how to coax gyp into outputting scons files that

[chromium-dev] Re: a brave new world for RTL languages (please comment)

2009-06-02 Thread Dan Kegel
On Tue, Jun 2, 2009 at 9:21 AM, nakro yoav.zilberb...@gmail.com wrote: יואב Zilberberg הוא 123 but!!! אולי ... i encourage you to select with the mouse the text and see how windows behaves It's not just Windows. Firefox on Linux does this, too. And I suspect Mac applications also behave

[chromium-dev] Re: recursive directory watcher on linux.

2009-06-03 Thread Dan Kegel
reason not to use FAM (File Alteration Monitor) which supports things like this? Yet another dependency for users of other DE's, but most of them probably won't use chromium due to GTK anyway. 2009/6/3 Dan Kegel daniel.r.ke...@gmail.com: Indeed.  And because it's not recursive, you have

[chromium-dev] Re: recursive directory watcher on linux.

2009-06-03 Thread Dan Kegel
/sources/ - Dan On Wed, Jun 3, 2009 at 11:03 AM, Stefan Nuxoll ste...@nuxoll.eu.org wrote: There is a rewrite (or cleaned up version, I'm not sure) maintained by GNOME called gamin. 2009/6/3 Dan Kegel daniel.r.ke...@gmail.com: FAM is pretty old, and didn't have a sterling reputation

[chromium-dev] trybots down?

2009-06-07 Thread Dan Kegel
http://build.chromium.org/buildbot/try-server/waterfall isn't showing any activity since 2pm, and my jobs aren't showing up or generating email...? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email

[chromium-dev] Re: chrome crashes - please help

2009-06-08 Thread Dan Kegel
On Mon, Jun 8, 2009 at 3:22 AM, mailandr...@gmail.comveena...@gmail.com wrote: Chrome just fails in Debug mode... I have tried with and without commandline switches. I am getting following error. [:FATAL:render_widget_host_view_win.cc(557)]Check failed:

[chromium-dev] Re: Zygote mode on by default in Linux now. Here's how to disable it...

2009-06-09 Thread Dan Kegel
On Tue, Jun 9, 2009 at 3:59 AM, Dean McNameede...@chromium.org wrote: On Tue, Jun 9, 2009 at 10:57 AM, Lei Zhangthes...@chromium.org wrote: Does this mean the zygote manager process is the parent process for the browser process and all renderer processes? Whereas before the browser process

[chromium-dev] Re: Throttling URLRequestFileJobs rate?

2009-06-12 Thread Dan Kegel
On Thu, Jun 11, 2009 at 10:24 PM, Stuart Morganstuartmor...@chromium.org wrote: Also, 256 is a pretty low limit. Dialing it up a few notches (say to 1024) to improve the performance of a better overall solution certainly isn't an issue. Don't you need root for that? - Dan

[chromium-dev] Re: Zygote mode on by default in Linux now. Here's how to disable it...

2009-06-15 Thread Dan Kegel
On Tue, Jun 9, 2009 at 3:59 AM, Dean McNameede...@chromium.org wrote: Is there a design document or anything somewhere? Adam wrote one: http://code.google.com/p/chromium/wiki/LinuxZygote - Dan --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] AutomationProvider for gtk?

2009-06-16 Thread Dan Kegel
AutomationProvider::GetActiveWindow() comes from browser/automation/automation_provider.cc on windows, but common/temp_scaffolding_stubs.cc on mac and linux. Is anyone working on a real AutomationProvider implementation for Linux? --~--~-~--~~~---~--~~ Chromium

[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?

2009-06-17 Thread Dan Kegel
On Tue, Jun 16, 2009 at 12:04 PM, pizhu.she...@gmail.com wrote: tab_restore_uitest.cc: TEST_F(TabRestoreUITest, RestoreToDifferentWindow) {  // This test is disabled on win2k. See bug 1215881. I cant find anything about  bug 1215881 on http://code.google.com/p/chromium/issues/list, where

[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?

2009-06-17 Thread Dan Kegel
On Wed, Jun 17, 2009 at 1:07 PM, pizhu.she...@gmail.com wrote: In the latest revision 18442,  there are comments such as Bug 1230446, Bug 1204135. Is there any means to view these internal bug reports? Not directly. What are you trying to do?

[chromium-dev] Re: What's the real reason of giving up Windows 2000 support?

2009-06-23 Thread Dan Kegel
On Tue, Jun 23, 2009 at 7:13 AM, pizhu.she...@gmail.com wrote: With a dozen of minim modifications, I have patched chrome 2.0.172.28 to run on Windows 2000. Great, please submit patches for review. - Dan --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: What's the real reason of giving up Windows 2000 support?

2009-06-23 Thread Dan Kegel
On Tue, Jun 23, 2009 at 8:36 AM, pizhu.she...@gmail.com wrote: please submit patches for review. Until now, I have only (1) patched HeapSetInformation(), GetUserGeoID(), GetGeoInfoW() and TTGetNewFontName() to do nothing and to return failure. (2) patched RtlGenRandom()/SystemFunction036()

[chromium-dev] gclient runhooks --force not forceful enough?

2009-06-25 Thread Dan Kegel
I did rm Makefile gclient runhooks --force and it didn't regenerate Makefile. tools/gyp/gyp -f make build/all.gyp does rebuild it. Seems like gclient runhooks --force ought to, no? --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: gclient runhooks --force not forceful enough?

2009-06-25 Thread Dan Kegel
On Thu, Jun 25, 2009 at 6:03 PM, Albert J. Wong (王重傑)ajw...@chromium.org wrote: Doesn't gclient runhooks --force setup the scons build on linux? Or did the make build become default at some point? Forgot to mention, I have GYP_GENERATORS=make in my environment. The scons build is so slow I

[chromium-dev] Re: gclient runhooks --force not forceful enough?

2009-06-25 Thread Dan Kegel
On Thu, Jun 25, 2009 at 6:13 PM, Antoine Labourpi...@google.com wrote: Are you seeing the same thing I am seeing ? For me, through gclient, Makefile is generated one directory up and is messed up. By gum, yes: $ diff Makefile ../Makefile 22c22 builddir ?=

[chromium-dev] Re: What's the real reason of giving up Windows 2000 support?

2009-06-26 Thread Dan Kegel
Is eComstation the OS/2 that dare not speak its name? :-) On Fri, Jun 26, 2009 at 6:50 AM, Itaiida...@chromium.org wrote: Feel free to make an eComstation port though, 2.0 is about to be released, plus its not that different from any other OS ;) - Itai On Jun 23, 12:48 pm, Elliot

[chromium-dev] Re: Should GYP files be UTF8 Encoded?

2009-06-26 Thread Dan Kegel
On Fri, Jun 26, 2009 at 1:50 PM, Daniel Cowxdaniel.c...@gmail.com wrote: Should GYP files be UTF8 Encoded? We can probably get away with ascii for now... are there any filenames that really need to be in a wider character set? --~--~-~--~~~---~--~~ Chromium

[chromium-dev] Re: Memory usage in chrome

2009-06-27 Thread Dan Kegel
On Sat, Jun 27, 2009 at 2:50 PM, Linus Upsonli...@google.com wrote: If I recall correctly, the best way we found to measure the total memory usage of a multi-process system like chrome was to measure the total commit charge of windows as you run the test. My favorite test is to plot the

[chromium-dev] Re: Mac Valgrind Bots

2009-07-17 Thread Dan Kegel
TThomas Van Lententhoma...@chromium.org wrote: We're already running at -O1 on Linux, so there isn't much improvement left to be had, I suspect. =A0 It might be worth it, dunno. There is a lot of code cut out by being NDEBUG instead of DEBUG, that's where I think the mac is getting its speed

[chromium-dev] Re: Mac Valgrind Bots

2009-07-17 Thread Dan Kegel
Right, we use -O1 instead of -O2 or -O0 with valgrind; it strikes a good balance between good stack and speed. On Jul 17, 2009 9:46 AM, Erik Kay erik...@chromium.org wrote: On Fri, Jul 17, 2009 at 8:12 AM, Nicolas Sylvain nsylv...@chromium.org wrote: On Fri, Jul ... One other tradeoff to

[chromium-dev] Please help fix Chromium crash/leak bugs this week

2009-07-18 Thread Dan Kegel
Dear Chromium developers, more and more people are trying Chrome on Mac and Linux... so it behooves us to really focus on stability. We put a bunch of work into getting the Valgrind buildbots green and on the main waterfall lately, so new bugs will be caught quickly... but that involved

[chromium-dev] Re: hammer base_unittests failed

2009-07-19 Thread Dan Kegel
On Sun, Jul 19, 2009 at 10:15 AM, empriserxueyunl...@gmail.com wrote: /home/chrome/src/skia/ext/bitmap_platform_device_linux.cc: In static member function 'static skia::BitmapPlatformDevice* skia::BitmapPlatformDevice::Create(int, int, bool, uint8_t*)':

[chromium-dev] Re: Chromium crash

2009-07-20 Thread Dan Kegel
OK, how about a backtrace? On Mon, Jul 20, 2009 at 8:24 PM, Thiago Farinathiago.far...@gmail.com wrote: Yes, I'm compiling the code under debug build option. Everytime I try to type in omnibox this happens. On Jul 20, 4:02 pm, Scott Hess sh...@chromium.org wrote: Looks to me like the code

[chromium-dev] Re: valgrind help office hours

2009-07-20 Thread Dan Kegel
On Tue, Jul 21, 2009 at 2:04 AM, John Abd-El-Malekj...@chromium.org wrote: I have a leak after a check-in.  I tried following the instructions on my Linux box, but couldn't (I hardly develop on Linux). jabdelma...@jabdelmalek:/usr/local/google/chrome/src$ sh tools/valgrind/chrome_tests.sh 

[chromium-dev] valgrind updated

2009-07-22 Thread Dan Kegel
If you don't run valgrind, you can probably ignore this. tools/valgrind/build-valgrind-for-chromium.sh has been updated. Used to be, if you had gold as your system linker, it would generate a valgrind that couldn't even valgrind /bin/true. It's now a bit smarter, and won't build or install a

[chromium-dev] Re: valgrind updated

2009-07-22 Thread Dan Kegel
. -- Evan Stade On Wed, Jul 22, 2009 at 8:53 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: Seems like a good news, but why should I use this script instead of regular valgrind? I don't know the difference. On Wed, Jul 22, 2009 at 20:39, Dan Kegel d...@kegel.com wrote: If you don't run

[chromium-dev] Re: avoiding compile failures on buildbot

2009-07-22 Thread Dan Kegel
That's consistent with trybots doing debug builds. Uninitialized var warnings only show up in optimized builds, nothing we can do there but turn on optimizations. On Thu, Jul 23, 2009 at 2:00 AM, Andrew Scherkusscher...@chromium.org wrote: On a related note, Frank (cc'd) ran into an issue where

[chromium-dev] Generating files in source tree considered harmful

2009-07-22 Thread Dan Kegel
Stop me if you've heard this one before. Today, a new directory was added to the source tree, and shortly thereafter was reverted. Should have been no problem, but... because the new directory contained a gyp file, a file was generated in that directory, and svn couldn't delete the directory

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-22 Thread Dan Kegel
On Thu, Jul 23, 2009 at 4:15 AM, Mark Larson (Google)m...@chromium.org wrote: Should have been no problem, but... because the new directory contained a gyp file, a file was generated in that directory, and svn couldn't delete the directory when the revert landed. This caused a build breakage,

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-23 Thread Dan Kegel
On Thu, Jul 23, 2009 at 4:56 AM, Mark Mentovaim...@chromium.org wrote: An objdir-ish solution would make sense, except the native build systems we use don't really work in terms of objdirs, so we'd just wind up generating a parallel directory structure with nothing but xcode projects,

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-23 Thread Dan Kegel
On Thu, Jul 23, 2009 at 2:28 PM, Darin Fisherda...@chromium.org wrote: An objdir-ish solution would make sense, except the native build systems we use don't really work in terms of objdirs, so we'd just wind up generating a parallel directory structure with nothing but xcode projects,

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-23 Thread Dan Kegel
On Thu, Jul 23, 2009 at 9:07 AM, Thomas Van Lententhoma...@chromium.org wrote: Here's my christmas wish: I'd like gyp and chrome to support cross-compilation, so that I could (on my Linux box) kick off distcc-accelerated builds for all three platforms, each one going into a separate objdir.

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-23 Thread Dan Kegel
On Thu, Jul 23, 2009 at 9:15 AM, Thomas Van Lententhoma...@chromium.org wrote: The other thing to remember is the buildbot scripts and a bunch of build scripts on all platforms are full of assumptions about the relationships between projects and the tree.  :( Well, yes. I didn't say it would

[chromium-dev] new valgrind mandatory if you use chrome_tests.sh

2009-07-23 Thread Dan Kegel
If you don't run tools/valgrind/chrome_tests.sh, you can ignore this message. tools/valgrind/chrome_tests.sh now uses the --show-possible option to valgrind. This option isn't in standard valgrind, so bad things will happen if you haven't run tools/valgrind/build-valgrind-for-chrome.sh to

[chromium-dev] Re: new valgrind mandatory if you use chrome_tests.sh

2009-07-23 Thread Dan Kegel
On Thu, Jul 23, 2009 at 10:55 PM, Dan Kegeld...@kegel.com wrote: If you don't run tools/valgrind/chrome_tests.sh, you can ignore this message. tools/valgrind/chrome_tests.sh now uses the --show-possible option to valgrind.  This option isn't in standard valgrind, so bad things will happen if

[chromium-dev] Re: CMake for chromium

2009-07-27 Thread Dan Kegel
On Mon, Jul 27, 2009 at 11:53 AM, Mark Mentovaim...@chromium.org wrote: I think i'll work on studying the current build system to figure out how to implement a CMake one. That's fine.  Let us (including me) know what you come up with. In particular, a CMake backend for gyp might be cool. -

[chromium-dev] Re: CMake for chromium

2009-07-27 Thread Dan Kegel
reported problem, pain on for example xcode or kdevelop users. What is the problem, again? Does the OP want xcode or kdevelop to run gyp when the user starts a build? On Mon, Jul 27, 2009 at 5:24 PM, Steven Knights...@google.com wrote: What's the coolness here? On Mon, Jul 27, 2009 at 11:58 AM, Dan

[chromium-dev] Re: [BUG][PATCH] Small compilation issue on Linux

2009-07-30 Thread Dan Kegel
That's the third such cl I've seen. Conclusion: tiny fixes like that should be committed as tbr to avoid duplication of effort. On Jul 30, 2009 12:44 PM, Wan-Teh Chang w...@google.com wrote: On Thu, Jul 30, 2009 at 12:13 PM, LivioSoareslivi...@gmail.com wrote: Hi,I'm running... Thanks a

[chromium-dev] new hunspell has tons of valgrind warnings... revert?

2009-08-01 Thread Dan Kegel
http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20(valgrind)/builds/1671/steps/valgrind%20test:%20unit/logs/stdio introduces 26 new unintialized memory references and two leaks. That's a big enough batch that it might be a good idea to revert it and commit something later

[chromium-dev] Re: new hunspell has tons of valgrind warnings... revert?

2009-08-01 Thread Dan Kegel
On Sat, Aug 1, 2009 at 4:10 PM, Mohamed Mansourm0.interact...@gmail.com wrote:  I am trying to learn about valgrind through the documentation, http://dev.chromium.org/developers/how-tos/using-valgrind, and it seems its Linux related, so I booted in Linux and installed all the valgrind tools.

[chromium-dev] Re: PSA: Consider upgrading to VS2008.

2009-08-01 Thread Dan Kegel
Yeah. How about a presubmit check? (only half joking) On Sat, Aug 1, 2009 at 9:41 PM, PhistucKphist...@gmail.com wrote: I am either wrong or just out of context here, but O3D has added another mentioning of ATL in their code -

Re: generated files in the tree (was Re: [chromium-dev] Fwd: Make workers functional on OSX and Linux.)

2009-08-04 Thread Dan Kegel
On Tue, Aug 4, 2009 at 10:18 AM, Dirk Prankedpra...@chromium.org wrote: On Tue, Aug 4, 2009 at 10:10 AM, Darin Fisherda...@chromium.org wrote: I think we need to make it possible for the buildbots to run in a mode where there are absolutely no generated files output into the source directory.

[chromium-dev] Mystery error Assertion failed: (slab-magic == SLAB_MAGIC), function slab_alloc, file x-alloc.c, line 353.

2009-08-04 Thread Dan Kegel
Twice now (three days ago and today) I got the error Assertion failed: (slab-magic == SLAB_MAGIC), function slab_alloc, file x-alloc.c, line 353. while running the ui tests under valgrind on the mac... and I can't figure out where it's coming from. I've grepped through the chromium and valgrind

[chromium-dev] Re: Mystery error Assertion failed: (slab-magic == SLAB_MAGIC), function slab_alloc, file x-alloc.c, line 353.

2009-08-05 Thread Dan Kegel
On Tue, Aug 4, 2009 at 5:14 PM, Adam Langleya...@chromium.org wrote: On Tue, Aug 4, 2009 at 5:11 PM, Peter Kastingpkast...@google.com wrote: That is probably coming from the allocator underneath Chrome (presumably the one provided by the OS kernel).  It probably means you have memory

[chromium-dev] Re: [POSIX] Reworking our child process reaping

2009-08-05 Thread Dan Kegel
Sounds good to me. It's nice living in the future and being able to rely on things like signalfd! - Dan p.s. I wrote a man page of sorts for that wy back in the past, before it existed: http://lkml.indiana.edu/hypermail/linux/kernel/0106.3/0404.html On Wed, Aug 5, 2009 at 12:12 PM, Adam

[chromium-dev] Re: Trick question: Who is responsible for repairing a red tree?

2009-08-05 Thread Dan Kegel
On Wed, Aug 5, 2009 at 2:45 PM, Tim Steelet...@chromium.org wrote: you have to keep asking, unless you're always on IRC and can cleverly search the window contents.  A constant place to go looking for this would make it easier, at least in my opinion.  Like right now I don't know what's up

[chromium-dev] Re: Trick question: Who is responsible for repairing a red tree?

2009-08-05 Thread Dan Kegel
On Wed, Aug 5, 2009 at 2:49 PM, Peter Kastingpkast...@google.com wrote:  Like right now I don't know what's up with Chromium Mac (valgrind) or Webkit dbg (12) to name a few; they're red but the tree is open. If you ever see a case like this, go ahead and close the tree yourself until you get

[chromium-dev] Re: Flakiness. Please help.

2009-08-06 Thread Dan Kegel
On Wed, Aug 5, 2009 at 9:44 PM, Peter Kastingpkast...@google.com wrote: * Yes, even purify, valgrind, and reliability bot redness.  If you can't figure out what to do with these, try pinging erikkay for purify issues and huanr for reliability issues.  (Not sure who a good general valgrind

[chromium-dev] Strange periodic popup window on 3.0.196.0 on Linux?

2009-08-06 Thread Dan Kegel
Ever since updating to 3.0.196.0, I've seen a blank window pop up and go away periodically (once an hour or so?). Anyone else seen that? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or

[chromium-dev] Re: Dev Chrome crashes on subsequent starts after installing a theme

2009-08-06 Thread Dan Kegel
Evan wrote about this earlier: A few people have found their trunk builds crashing on startup. This comes from a bug in theme loading and can bite you if you installed some of the in-development themes. The fix is to rm -rf your Extensions directory out of your profile directory. The next release

[chromium-dev] PluginTest.Refresh is hanging purify every time

2009-08-06 Thread Dan Kegel
Hi Erik, PluginTest.Refresh is hanging purify every time, ever since http://build.chromium.org/buildbot/waterfall/builders/Webkit%20(purify)/builds/9777 two days ago. Want me to file a bug / disable it? --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: Idea for next valgrind/purify fixit week: just delete the suppressions and watch the tree go red

2009-08-06 Thread Dan Kegel
On Thu, Aug 6, 2009 at 4:38 PM, Peter Kastingpkast...@google.com wrote: i.e. Next time we hold a valgrind fixit, how about we just delete the non-upstream-bugs suppressions files? I think this would be a mistake. There is a lot of accumulated knowledge in the valgrind suppresions file.  

[chromium-dev] Re: Idea for next valgrind/purify fixit week: just delete the suppressions and watch the tree go red

2009-08-06 Thread Dan Kegel
On Thu, Aug 6, 2009 at 4:48 PM, Peter Kastingpkast...@google.com wrote: I told Ben this morning that I'm taking ownership of the flakiness problem, and I meant it.  I will do my best to harass people.  Next on my list is going to every single subteam meeting and making noise at all of them.

[chromium-dev] Re: gyp failing while triggering gclient sync in linux with git

2009-08-06 Thread Dan Kegel
Please check to make sure the python scripts have UNIX line endings, not DOS ones. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

[chromium-dev] Re: How to debug Aw, Snap! error

2009-08-06 Thread Dan Kegel
On Thu, Aug 6, 2009 at 9:43 PM, n179911n179...@gmail.com wrote: When I load a page on chromium that I run on debugger,I get 'Aw, Snap! What page? My question is how can i debug problem like this? Is there a stack trace or core dump for situation like this? If you installed the dev channel

[chromium-dev] Re: lan manager in cloud

2009-08-11 Thread Dan Kegel
And are you looking to hire somebody to do the work? (That's what I seem to gather from your hourly comment.) On Tue, Aug 11, 2009 at 3:23 PM, Jeremy Orlowjor...@chromium.org wrote: Even with the translation, it's difficult to understand what you're saying and asking.  Chromium has a full

[chromium-dev] Re: Allocator Choice

2009-08-12 Thread Dan Kegel
On Tue, Aug 11, 2009 at 8:25 PM, Mike Belshembel...@google.com wrote:  Unlike Obama's plan for healthcare, this CL is about giving you more choice. Political comments are off-topic for this list, I think. --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] v8 update caused test shell tests crash?

2009-08-12 Thread Dan Kegel
Hi plesner, have you seen http://build.chromium.org/buildbot/waterfall/builders/Webkit%20(dbg)(1) in the last hour or so? It looks like LayoutTests/http/tests/security/cross-frame-access-protocol.html is reliably crashing since the v8 update to trunk/1.3.3 in

[chromium-dev] Re: Tree hygiene

2009-08-14 Thread Dan Kegel
Maybe that should automatically close the tree... On Fri, Aug 14, 2009 at 2:07 PM, Lei Zhangthes...@chromium.org wrote: Do we have a warning for when the difference between the ToT revision number and LKGR pass a certain threshold? On Fri, Aug 14, 2009 at 8:00 AM, Marc-Antoine

[chromium-dev] Re: Does Chromium use boost library

2009-08-16 Thread Dan Kegel
I think we haven't quite drunk the boost koolaid. We turn off rtti and exceptions, too. On Aug 16, 2009 12:42 AM, n179911 n179...@gmail.com wrote: Hi, Does Chromium use boost library? In the source tree, i see there is a 'boost' directory under 'third-party'. It appears to be an incomplete

[chromium-dev] linux dev channel crashing on first login to gmail today?

2009-08-19 Thread Dan Kegel
Has anyone else experienced chrome crashes on linux today? I'm on the dev channel (3.0.198.1) and both at home and at work it crashed on me when I tried to log in to gmail the first time. Hasn't crashed thereafter. --~--~-~--~~~---~--~~ Chromium Developers

  1   2   >