leizhiyuan commented on issue #1412: URL: https://github.com/apache/rocketmq-clients/issues/1412#issuecomment-6310262621
Update: item 14 (received message body not decompressed, digest not verified) now has #1428 / #1429. - It verifies the body digest and decompresses `GZIP`-encoded bodies, by magic number, so the ZLIB bodies that Remoting producers send (labelled `GZIP` by the proxy) are handled as well. It also adds `MessageView::is_corrupted()`. The PushConsumer nacks (standard) or dead-letters (FIFO) corrupted messages instead of calling the listener, as Java does. - End-to-end on the same server: a 5090-byte message from the Remoting producer now arrives as the original text (before: 472 bytes of ZLIB), the same as with Java 5.2.2. - It adds three small dependencies (`flate2`, `crc32fast`, `md-5`); they build with Rust 1.74. - It has textual conflicts with #1411 and #1414 in `push_consumer.rs` (both sides append tests, plus one neighbouring line each). The resolution is described in the conflict table (‡) and was verified on temporary merges. It merges cleanly with every other open Rust PR. The table and the conflict matrix above are updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
