leizhiyuan commented on issue #1412: URL: https://github.com/apache/rocketmq-clients/issues/1412#issuecomment-6310886258
Update: item 16 (ack after `change_invisible_duration` silently ignored) now has #1430 / #1431. - `SimpleConsumer::change_invisible_duration` writes the new receipt handle back into the `MessageView`, as Java `SimpleConsumerImpl#changeInvisibleDuration0` does. A later `ack` or change of the same view then takes effect. The public API is unchanged. - End-to-end on the same server: on `master`, "change once / change twice, then ack the same view" returned `Ok` and the message was redelivered after ~40 s. With the PR it is not redelivered. - It conflicts with #1427 in `simple_consumer.rs` (same function, plus tests appended at the same place). The resolution is described in the conflict table (ยง) and was verified on a temporary merge. It merges cleanly with every other open Rust PR. Since it changes a `pub(crate)` field type of `MessageView`, I also built and tested the merges with the PRs that use `MessageView`. The table and the conflict matrix above are updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
