leizhiyuan commented on issue #1412: URL: https://github.com/apache/rocketmq-clients/issues/1412#issuecomment-6311221253
Update: item 17 (SimpleConsumer keeps working after a failed `start()`) now has #1432 / #1433. - `Client::start` rolls back when the first session can not be created. `SimpleConsumer::start` shuts the client down when the startup route lookup fails. `receive` / `ack` / `change_invisible_duration` fail with `ClientIsNotRunning` before any RPC. This is aligned with Java `SimpleConsumerImpl#startUp` and its `isRunning()` checks. - End-to-end on the same server, after a failed start: on `master`, `receive` reconnected or long polled 20 s for `Ok([])`, and `ack` panicked in one case. With the PR, all three calls return `ClientIsNotRunning` within microseconds. - It conflicts in `simple_consumer.rs` with #1381, #1427 and #1431 (same methods, tests appended at the same place). With #1404 it merges cleanly as text, but its new test needs a two-line adjustment. Resolutions are in the conflict table (ΒΆ); all were verified on temporary merges. The table and the conflict matrix above are updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
