leizhiyuan commented on issue #1412: URL: https://github.com/apache/rocketmq-clients/issues/1412#issuecomment-6312270994
Item 21: #1434 / #1435. `LiteSimpleConsumer::change_invisible_duration` of a lite message now sends `suspend=true`, as Java `ConsumerImpl#wrapChangeInvisibleDuration` does. This is code review only, because this server rejects `LITE_SIMPLE_CONSUMER`. The PR depends on #1381 (temporary merge commit, one reviewable commit) and adds no conflicts beyond those #1381 already has. I deliberately did not apply this to the `LitePushConsumer` failure nack, although Java's standard consume service does. On a real server with local `fifo=false`, `suspend=true` kept the failing message at the same delivery attempt. It was redelivered every ~1.1 s together with the rest of its lite topic (114 times in 125 s) and never reached the DLQ. Maintainers, please confirm whether the push path should follow Java here. The details are in #1434 and #1435, and the table above is updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
