agarwalrahul2702 commented on PR #11489:
URL: https://github.com/apache/seatunnel/pull/11489#issuecomment-5015627589
Pushed follow-up commit `e8985e3c` to address the review blockers from the
`3a9067c9` head:
1. FakeSource restore correctness:
- `FakeSourceReader` no longer mutates the assigned split object when
batching.
- Requeued progress uses a new `FakeSourceSplit`.
- `FakeSourceSplit` identity/hash now uses `tableId` + `splitId`,
excluding mutable remaining-row progress.
- Added a restore regression test that verifies assigned splits are not
rediscovered when restored progress has a different remaining row count.
2. Multi-pipeline savepoint finalization:
- `CheckpointManager#triggerSavePoints()` now consumes
`CheckpointCoordinator#startSavepointAndWaitComplete()`.
- The future observed by `JobMaster` completes after the checkpoint
coordinator reaches its terminal state (`SUSPEND` for a successful savepoint),
not just after pending-checkpoint ACK.
- The multi-pipeline regression now asserts terminal pipeline states and
verifies that the successful pipeline coordinator reaches `SUSPEND`.
3. Synchronous trigger failure cleanup:
- `JobMaster#savePoint()` now puts `savepointJob()`,
`triggerSavePoints()`, aggregation, and the `savepointFailed()` fallback inside
the same guarded operation, so synchronous and asynchronous failures both leave
`DOING_SAVEPOINT` through the same cleanup path.
I also updated the PR description so it no longer describes the old “revert
to RUNNING / no forced cancellation” behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
