agarwalrahul2702 commented on PR #11489: URL: https://github.com/apache/seatunnel/pull/11489#issuecomment-5256311191
Pushed `8b56ffc60` after checking the latest failed run at head `0e3189a30`. Findings from `unit-test (11, ubuntu-latest)` job `93826638838`: - `SavePointBusySourceTest` now passes: `Tests run: 5, Failures: 0, Errors: 0`. - The remaining unit-test failure was `SeaTunnelClientTest.testSavePointAndRestoreWithSavePoint`. - Error: `SavePointFailedException: The job with id ... not running, save point failed`. Root cause: `SeaTunnelClientTest` uses `streaming_fake_to_console.conf`, but that fixture had FakeSource defaults (`row.num=5`, `split.num=1`, `split.read-interval=1ms`). On CI the job can finish between observing `RUNNING` and sending `savePointJob()`, so the master correctly reports that the job is no longer running. Fix in `8b56ffc60`: - Made the shared client streaming fixture actually long-running (`row.num=1000000`, `split.num=5`, `split.read-interval=100`). This also stabilizes the other client tests that expect this fixture to remain `RUNNING` until canceled. - Hardened the existing savepoint retry predicate to retry both "Task not all ready" and the transient "not running" savepoint race, with null-safe cause handling. Local validation: - `./mvnw -pl seatunnel-engine/seatunnel-engine-client spotless:apply` passes. - `git diff --check` passes. - `./mvnw -pl seatunnel-ci-tools -Dtest=ImportClassCheckTest#javaUtilCompletableFutureCheck test` passes. Targeted local client test execution is still blocked by local unresolved `seatunnel-shade` SNAPSHOT dependency; GitHub CI is queued on the new head: https://github.com/agarwalrahul2702/seatunnel/actions/runs/31515616274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
