agarwalrahul2702 commented on PR #11489: URL: https://github.com/apache/seatunnel/pull/11489#issuecomment-5023131482
Thanks for the current-head review. I pushed `35823e758` to address the remaining custom `rows` blocker. - `FakeDataGenerator` now has a bounded custom-row slice path instead of only the old emit-every-configured-row path. - `FakeSourceReader` now applies the same per-`pollNext` upper bound to explicit `rows` as to generated rows. - Custom-row progress is persisted in a newly requeued `FakeSourceSplit`: the first custom split starts at row index `0`, continuation splits encode the next custom-row index to emit, and `snapshotState()` therefore records only the not-yet-emitted portion. The reader does not mutate the assigned split object. - Added a large custom-`rows` stop-with-savepoint regression config/test so this branch exercises the actual savepoint path. - Added a custom-row slice unit test for bounded row generation. No user-facing config option was added or changed; the new config file is a test resource only, so docs/examples are unchanged. Verification after this commit: - `./mvnw spotless:check` passes. - `./mvnw spotless:apply` passes. - `git diff --check` passes. Targeted test execution is still blocked by local SeaTunnel build setup before the changed modules are reached: direct module runs fail resolving the local `seatunnel-shade` SNAPSHOT, and `-am` runs fail earlier in `seatunnel-config-shade` because generated/shaded Typesafe Config classes are unavailable in this cleaned workspace. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
