agarwalrahul2702 commented on PR #11489: URL: https://github.com/apache/seatunnel/pull/11489#issuecomment-5230199558
Pushed `d71d4c4e0` to address the two remaining non-blocking review nits from the latest review: - Added a fine-level log when the aggregate savepoint future completes exceptionally before the method deliberately inspects each pipeline future. - Replaced the fully-qualified JDK `CompletableFuture.allOf` reference with a static import, keeping the existing SeaTunnel `CompletableFuture` import unchanged. No savepoint behavior changed in this commit. Local verification: - `./mvnw spotless:apply` passes. - `./mvnw spotless:check` passes. - `git diff --check` passes. Targeted engine-server test/compile attempts are still blocked before this module by local repository setup: direct module compile cannot resolve the local `seatunnel-shade` SNAPSHOT from Apache snapshots, and `-am` reaches `seatunnel-config-shade` first and fails on generated/shaded Typesafe Config classes. I also verified the Hazelcast `ILogger#fine(String, Throwable)` API from the local Maven artifact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
