agarwalrahul2702 commented on PR #11489: URL: https://github.com/apache/seatunnel/pull/11489#issuecomment-5276022745
Pushed `a33faca4d` to address the latest blocking review finding. Root cause addressed: `TASK_NOT_ALL_READY_WHEN_SAVEPOINT` means the savepoint was rejected before a checkpoint could start. The previous `finally` path treated that the same as a mid-flight savepoint failure and called `physicalPlan.savepointFailed()`, which force-stopped the job and made client retries impossible. Fix: - `JobMaster.savePoint()` now inspects the per-pipeline savepoint result before deciding the cleanup path. - If the failure is `CheckpointException(TASK_NOT_ALL_READY_WHEN_SAVEPOINT)` and no pipeline reached `SUSPEND`, it restores the global job state from `DOING_SAVEPOINT` back to `RUNNING` so the caller can retry. - If any pipeline already reached `SUSPEND`, or the failure is not the not-ready precondition, the existing deterministic `savepointFailed()` stop fallback remains in place to avoid reporting a partially stopped job as running. - Added `SavePointBusySourceTest.testSavepointStartPreconditionFailureKeepsJobRunning`, which forces the checkpoint coordinator readiness flag false, calls savepoint, asserts the request fails, and verifies the job remains `RUNNING` and still has a `JobMaster`. Local verification: - `./mvnw -pl seatunnel-engine/seatunnel-engine-server spotless:apply` passes. - `git diff --check` passes. - `./mvnw -pl seatunnel-ci-tools -Dtest=ImportClassCheckTest#javaUtilCompletableFutureCheck test` passes. I also attempted the targeted server regression locally after installing `seatunnel-shade`; the direct module run reaches compilation but fails because this workspace mixes current checkout code with old Apache snapshot jars, and the reactor `-am` compile still stops earlier in `seatunnel-config-shade` on generated/shaded Typesafe Config classes before engine-server is reached. The GitHub workflow is running on the pushed head now: https://github.com/agarwalrahul2702/seatunnel/actions/runs/31667542329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
