agarwalrahul2702 commented on PR #11489: URL: https://github.com/apache/seatunnel/pull/11489#issuecomment-5021838942
Thanks for the review. I pushed `9e45d1415` to address the blocking API compatibility item. - Restored the existing public `CheckpointManager#triggerSavePoints()` signature to return `PassiveCompletableFuture<CompletedCheckpoint>[]`. - Added a separate additive method, `triggerSavePointsAndWaitComplete()`, for the `JobMaster` stop-with-savepoint path that needs finalized checkpoint-coordinator state. - Updated `JobMaster` to call the new method, so downstream callers of the existing public API keep the prior return type/behavior. For the low-severity config/docs note: this PR does not add or change any user-facing config option. The only config-like addition is a test resource used by the regression test, so I left user docs/examples unchanged. Verification after this change: - `./mvnw spotless:check` passes. - `./mvnw spotless:apply` passes. - `git diff --check` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
