agarwalrahul2702 commented on PR #11489:
URL: https://github.com/apache/seatunnel/pull/11489#issuecomment-5235569677

   Pushed `caf39c78d` to fix the merge-blocking CI regression from my previous 
cleanup commit.
   
   - Removed `import static java.util.concurrent.CompletableFuture.allOf;`.
   - Switched the aggregate wait to 
`CompletableFuture.allOf(passiveCompletableFutures).join()` using the 
already-imported 
`org.apache.seatunnel.engine.common.utils.concurrent.CompletableFuture`.
   - No savepoint behavior changed.
   
   Local verification:
   
   - `./mvnw spotless:check` passes.
   - `git diff --check` passes.
   - `./mvnw -pl seatunnel-ci-tools 
-Dtest=ImportClassCheckTest#javaUtilCompletableFutureCheck test` passes.
   - `rg -n 
"import\\s+(static\\s+)?java\\.util\\.concurrent\\.CompletableFuture" 
seatunnel-engine` returns no matches.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to