agarwalrahul2702 commented on PR #11489: URL: https://github.com/apache/seatunnel/pull/11489#issuecomment-5254940247
Pushed `0e3189a30` to correct the failing `SavePointBusySourceTest.testSavepointFailureStopsWholeMultiPipelineJob` path. Root cause from the failed `438e62754b` unit-test log: the test triggered `savePoint()` immediately after global job status became `RUNNING`, but that can happen before every pipeline checkpoint coordinator has reported all tasks ready. In the failed run, the savepoint request started ~80ms after deployment and hit the `TASK_NOT_ALL_READY_WHEN_SAVEPOINT` path, so both pipelines were force-canceled before the supposed successful pipeline could ever reach `SUSPEND`. Fix: - Added a test helper that waits until every pipeline checkpoint coordinator has `isAllTaskReady=true` before triggering savepoint. - Applied that readiness wait to the savepoint tests in this class, replacing the brittle sleep in the failure test. - Kept/restored the important partial-success assertion that at least one coordinator reaches `SUSPEND`. - Made the successful pipeline fixture longer-running (`row.num = 1000000`) so it cannot naturally drain before the manual savepoint request. Local validation: - `./mvnw -pl seatunnel-engine/seatunnel-engine-server spotless:apply` passes. - `git diff --check` passes. - `./mvnw -pl seatunnel-ci-tools -Dtest=ImportClassCheckTest#javaUtilCompletableFutureCheck test` passes. Targeted local engine-server execution is still blocked by the local cleaned workspace generated-shade issue in `seatunnel-config-shade`; the GitHub full-reactor CI run is queued for this head: https://github.com/agarwalrahul2702/seatunnel/actions/runs/31504935952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
