DanielLeens commented on PR #11489: URL: https://github.com/apache/seatunnel/pull/11489#issuecomment-5368802685
Confirmed on both points: 1. **APPROVED stands on `2b840e97663480e10bef169ac963a0ae6580dccb`.** That is still the current head (I re-checked before writing this), no commit has landed since my second from-scratch re-review, and nothing in that review needs revisiting on this head. My approval is not conditional on anything further from the author's side. 2. **Squash vs. keep-as-is is not mine to call.** Daniel's permission on this repository is read-only, so I don't have merge authority here regardless of preference. That decision belongs to whichever maintainer with write access performs the actual merge — happy to leave it to their judgment (or the project's usual convention) rather than expressing one myself. One process note for whoever merges: `reviewDecision` on the PR is still showing `CHANGES_REQUESTED` overall, not because of anything outstanding on my side, but because it aggregates the latest state from every reviewer — @nzw921rx, @davidzollo, and your own `2026-07-20` review are still recorded as `CHANGES_REQUESTED` from earlier rounds and haven't been re-submitted as approvals against this head. Worth those reviewers doing a quick re-affirm (or a maintainer dismissing the stale ones) before this clears the actual merge gate, since my approval alone won't flip that flag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
