agarwalrahul2702 commented on PR #11489: URL: https://github.com/apache/seatunnel/pull/11489#issuecomment-5344460225
Pushed `2b840e976` to address Daniel’s latest review. Changes: - Removed the cooperative-task-close production change from this PR. That takes `TaskExecutionService.java` back out of the net PR diff, so the unrelated lifecycle/test-coverage blocker is no longer part of this savepoint fix. - Added `awaitCheckpointCoordinatorsReady(jobMaster)` before forcing `isAllTaskReady=false` in the retry-precondition tests. The retry test now waits for the real coordinator-ready handshake first, injects exactly one precondition rejection, restores readiness, and then retries the savepoint. The retry fixture already has the periodic-checkpoint isolation from `037ea4335` (`checkpoint.interval = 600000`, `checkpoint.timeout = 60000`), so the test is driven by the explicit savepoint calls rather than an overlapping periodic checkpoint. Local validation: - `./mvnw -pl seatunnel-engine/seatunnel-engine-server spotless:apply` passes. - `git diff --check` passes. - `./mvnw -pl seatunnel-ci-tools -Dtest=ImportClassCheckTest#javaUtilCompletableFutureCheck test` passes. New Build run for this head: https://github.com/agarwalrahul2702/seatunnel/actions/runs/32271489557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
