agarwalrahul2702 commented on PR #11489:
URL: https://github.com/apache/seatunnel/pull/11489#issuecomment-5323268643
Pushed `8e4364915` after syncing the branch with current `upstream/dev`.
This addresses Daniel’s 2026-08-18 review:
- Split the flaky retry assertion out of
`testSavepointStartPreconditionFailureKeepsJobRunning`.
- The busy-source reproduction now only verifies the pre-start savepoint
failure keeps the job `RUNNING`, then cancels and checks slot cleanup.
- It no longer tries to prove retry success against the deliberately
checkpoint-hostile 100M-row / 60s-timeout config that failed in CI.
- Added `testSavepointStartPreconditionFailureCanBeRetriedAfterReady` with a
separate lightweight long-running FakeSource config
(`stream_fakesource_retryable_to_console_savepoint.conf`) so retry success is
verified without racing the original busy-source timeout budget.
- Added the missing comment on `isSavepointStartPreconditionException()`.
- Updated caller-facing failure selection so mixed failures prefer a
non-precondition/genuine failure over a benign first precondition failure, and
added
`JobMasterTest#testSavepointFailureExceptionPrefersNonPreconditionFailure` for
that behavior.
Local validation:
- `./mvnw -pl seatunnel-engine/seatunnel-engine-server spotless:apply`
passes.
- `git diff --check` passes.
- `./mvnw -pl seatunnel-ci-tools
-Dtest=ImportClassCheckTest#javaUtilCompletableFutureCheck test` passes.
I attempted the targeted engine-server tests both directly and with `-am`
after syncing `dev`:
- Direct module run still fails before tests because Maven resolves
stale/mismatched SNAPSHOT artifacts for reactor modules.
- Reactor `-am -DfailIfNoTests=false` gets past the no-tests module but
still stops before engine-server in `seatunnel-config-shade` because the
generated/shaded Typesafe Config classes are missing in this local workspace.
So the PR CI run for head `8e4364915` is the authoritative full-reactor
verification for the affected engine tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
