agarwalrahul2702 commented on PR #11489: URL: https://github.com/apache/seatunnel/pull/11489#issuecomment-5327101322
Pushed `8f5d15cd3` for the latest review blocker and the latest failed Build run. What changed: - Restored automated coverage for the retry contract requested in the latest review: `SavePointBusySourceTest#testSavepointStartPreconditionFailureCanBeRetriedAfterReady` now verifies that a savepoint rejected before coordinator readiness leaves the job `RUNNING`, and that a later retry after readiness reaches `SAVEPOINT_DONE`. - Re-added the retry fixture as `stream_fakesource_retryable_to_console_savepoint.conf`, but made it long-running with many small splits (`500000` rows / `500` splits) instead of using the checkpoint-hostile busy-source fixture. This keeps the job alive for retry without starving savepoint barrier injection. - Fixed the Paimon E2E thread-leak failure exposed by the last Build run. In cooperative execution, failed/abandoned tasks were marked done without calling `Task.close()`, unlike the blocking worker path. That can leave sink-owned executors such as `st-multi-table-sink-writer-*` parked after a failing sink test. The cooperative worker now closes failed tasks with the task connector classloader before marking them done, so sink close can shut down its internal executor. Validation run locally: - `./mvnw -pl seatunnel-engine/seatunnel-engine-server spotless:apply` passes. - `git diff --check` passes. - `./mvnw -pl seatunnel-ci-tools -Dtest=ImportClassCheckTest#javaUtilCompletableFutureCheck test` passes. I also retried direct `seatunnel-engine-server` compile locally; it is still blocked before useful module verification by this workspace resolving stale/mismatched local reactor artifacts (`JobRestoreInProgressException`, API metadata/signal classes, `RestoreMode`, metric constants, etc.). The full GitHub Build run on `8f5d15cd3` is now the authoritative verification: https://github.com/agarwalrahul2702/seatunnel/actions/runs/32128491990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
