agarwalrahul2702 commented on PR #11489: URL: https://github.com/apache/seatunnel/pull/11489#issuecomment-5317852719
Pushed `93a7a6672` to address the latest SEZ9 review on head `a33faca4d`. What changed: - `JobMaster` now preserves every per-pipeline savepoint exception instead of classifying the whole job from the first exception in pipeline-list order. - The restore-to-`RUNNING` path is now allowed only when no pipeline reached `SUSPEND` and every collected failure is a pre-start savepoint rejection. - `CHECKPOINT_COORDINATOR_SHUTDOWN` is handled alongside `TASK_NOT_ALL_READY_WHEN_SAVEPOINT` as a retryable pre-start rejection. - Any mixed result containing a genuine checkpoint failure, any partial suspension, interruption, or non-precondition failure still routes to the deterministic stop fallback. - Added comments/Javadoc around the aggregation/classification rule so the lifecycle distinction is explicit. Coverage added: - `JobMasterTest#testSavepointPreconditionClassificationRequiresAllFailuresPreconditionOnly` covers the mixed multi-pipeline case: one precondition failure plus one genuine `CHECKPOINT_EXPIRED` failure must not be restored to `RUNNING`. - `JobMasterTest#testSavepointPreconditionClassificationAcceptsAllPreStartFailures` covers all-pre-start failures, including `CHECKPOINT_COORDINATOR_SHUTDOWN`. - `SavePointBusySourceTest#testSavepointStartPreconditionFailureKeepsJobRunning` now also flips readiness back to true and verifies a retry reaches `SAVEPOINT_DONE` on the same job. Local validation: - `./mvnw -pl seatunnel-engine/seatunnel-engine-server spotless:apply` passes. - `git diff --check` passes. - `./mvnw -pl seatunnel-ci-tools -Dtest=ImportClassCheckTest#javaUtilCompletableFutureCheck test` passes. I also re-attempted the targeted engine-server tests locally, but this cleaned workspace still cannot compile `seatunnel-engine-server` because Maven resolves mismatched/stale local SNAPSHOT artifacts before test execution (`RestoreMode`, API metadata/signal classes, metric names, and generated Lombok members are missing). The PR CI has been triggered on the new head and should be the authoritative full-reactor verification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
