agarwalrahul2702 commented on PR #11489: URL: https://github.com/apache/seatunnel/pull/11489#issuecomment-5323782273
Pushed `ac936f844` for the latest CI/review feedback. What changed: - Removed the newly-added retry-success integration fixture/test that failed in CI by racing `SAVEPOINT_DONE` against the busy-source checkpoint timeout. - Deleted `stream_fakesource_retryable_to_console_savepoint.conf`, since that fixture existed only for the unstable retry assertion. - Kept `SavePointBusySourceTest.testSavepointStartPreconditionFailureKeepsJobRunning` focused on the deterministic requirement from #11473: an early savepoint precondition failure must fail the request but leave the job `RUNNING`, with cleanup verified by explicit cancel. - Kept the deterministic `JobMasterTest` coverage for multi-pipeline classification and mixed-failure reporting. - Synced the branch with current `upstream/dev` (`4a65e98ad`). This also addresses the two non-blocking notes from the latest review that were already present on the prior head: - `isSavepointStartPreconditionException()` has a dedicated comment explaining the pre-checkpoint boundary. - mixed failures prefer a non-precondition exception when surfacing the failure to the caller. Local validation on the pushed head: - `./mvnw -pl seatunnel-engine/seatunnel-engine-server spotless:apply` passes. - `git diff --check` passes. - `./mvnw -pl seatunnel-ci-tools -Dtest=ImportClassCheckTest#javaUtilCompletableFutureCheck test` passes. I also re-attempted `./mvnw -pl seatunnel-engine/seatunnel-engine-server -Dtest=JobMasterTest test`; this local workspace still fails during engine-server compile before tests because direct module resolution uses stale/missing intra-repo SNAPSHOT classes (`RestoreMode`, API metadata/signal/error classes, metric constants). The new fork Build is queued here: https://github.com/agarwalrahul2702/seatunnel/actions/runs/32100814768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
