SEZ9 commented on PR #11512: URL: https://github.com/apache/seatunnel/pull/11512#issuecomment-5724737280
Thanks @goutamadwant for rechecking F4/F6 on the current head. The automated pass traced both to their source commits, and the evidence lines up with what you described: - **F6** — `3eea0a0434f` changed the `CdcProgressLifecycle.SNAPSHOT` Javadoc to "The reader is reading snapshot splits.", removing the discovery/assignment wording, so it no longer contradicts the coordinator-owned enumerator-report ownership rule in the doc. - **F4** — `5410c581811` rewrote the "Runtime collection" section of `docs/en/developer/cdc-progress.md` to the coordinator-selected polling model (coordinator derives enumerator task group locations and requests reports from the assigned members), which is consistent with the implementation. With those two confirmed at `d8cb0cbb7d3`, and the transport-blocking fix in `8714c91bb` already in, I consider F1–F8 resolved on my side. Agreed that the REST startup issue is separate and tracked in #12338. Remaining asks before merge: 1. You mentioned shared integration failures still keep the aggregate Build red. Could you confirm those failures are unrelated to this PR's changes (e.g. point to where they're tracked or reproduce on master), so we have that on record? 2. Once the shared failures are addressed, please rebase/rerun so we get a green aggregate Build on this PR before I approve. No further code changes needed from the review scope. <!-- streview-comment:1144 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
