DanielLeens commented on PR #12443: URL: https://github.com/apache/seatunnel/pull/12443#issuecomment-6210074486
Thanks @SEZ9 for the pass on `bdcfccdb1b80`, and @hutiefang76 for the quick sync. I re-checked the one item that is still open, the REST integration evidence for the merged head, and here is where it stands. - **Head and diff:** the head is still `bdcfccdb1b80` (10 ahead / 1 behind `dev`, no conflict). The PR diff touches `RestApiIT` (`seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base`), which is what carries the REST-level cases `testSubmitJobWithHoconFormatAndQuotedLiteralKey` and `testSubmitJobWithJsonFormat`. - **CI state:** the apache-side `Build` check for this SHA is `action_required` (workflow approval pending) and I could not find a fork workflow run for this exact SHA, so there is currently no CI result for the merged tree. Labeler and the notify workflow are green. So the cleanest way to close the F4 point is for a committer to approve the pending `Build`: because this PR changes files under `seatunnel-e2e/seatunnel-engine-e2e/**`, the engine e2e lane should select `RestApiIT` on this head, and that run would be the evidence on exactly what will be merged. - **If you prefer to also run it locally**, @hutiefang76, any command that runs `RestApiIT` from `connector-seatunnel-e2e-base` (for example `./mvnw -pl seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base -am verify -Dit.test=RestApiIT` with the usual local flags) and pasting the result in the description would also satisfy @SEZ9's ask. I have not run it myself; this is static analysis only. From my side nothing else is outstanding: the source, tests and docs are unchanged since my last review, and the two Low items there (the HOCON doc qualifier and the fully qualified `Config` type in a test) remain non-blocking. As before, the final approval needs a committer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
