I'm scared by the thought of having a program "clean" our source code changing lots of files. I prefer the approach that the devs shall try to improve the code while they are working on it.
BTW, I think there's one or two rules in our Checkstyle file that probably should/could be removed. For example, the frequent warning about "field hiding" and "Utility classes should not have a public constructor". But that's a separate discussion I guess. 18000 PMD violations is just sick. Things like rule [1] doesn't really help the source code. We can do that if we get a budget for nuclear-power-plant-grade software. [1] http://pmd.sourceforge.net/rules/optimizations.html#MethodArgumentCouldBeFinal On 12.06.2008 08:28:35 Max Berger wrote: > Dear Fop-Devs, > > Jeremias is right - you actually need to use the output of these > reports. At this time there are: > > 1849 checkstyle violations > 18702 pmd violations > possible (find)bugs. > > Many of these could be automatically solved using the eclipse > "cleanup" tools (which can actually be called on the whole src dir!). > However, that would result in a change in almost every file, and > making merging of separate branches almost impossible. This should > therefore not be done until 0.95 is released, to allow backporting. > The main question is, should it be done at all? > > Max > > Am 11.06.2008 um 09:13 schrieb Jeremias Maerki: > > > I'm using FindBugs (as Eclipse plug-in) for some time now and it is > > really good. Not that I can really say yes to 100% of the suggestions. > > But about 98%. > > > > I'm not sure about the benefit of those reports. We've had the > > Checkstyle report for years now, but I doubt many people look at that > > often. Having those tools as IDE plug-ins is much more useful. But > > that > > needs to be set up by every dev him/herself. > > > > On 10.06.2008 10:01:03 Max Berger wrote: > >> Dear Fop-Devs, > >> > >> since this came up, here is a list of tools I use for software > >> quality > >> checking (and all them them can check for generic list types). All of > >> them have Eclipse and maven plugins (and ant tasks, and ....) > >> > >> Checkstyle: checkstyle.sf.net > >> > >> (already configured in fop, so nothing needs to be done) > >> > >> Findbugs: findbugs.sf.net > >> > >> (very good - all its advices should be followed) > >> > >> PMD: pmd.sf.net > >> > >> (contains almost too many rules, some of them are debatable) > >> > >> I'd be willing to set up reporting for these 3 tools, so that you can > >> check what they suggest. I usually try to follow of these rules when > >> creating new files. > >> > >> Max > >> > > > > > > > > > > Jeremias Maerki > > Jeremias Maerki
